[Intel-gfx] [PATCH v2 0/5] drm: Add decoding for DRM/KMS and i915 ioctls

2015-06-18 Thread Patrik Jakobsson
ar strings * Reworked entering() / exiting() handling for all ioctls * Use printstr() to print strings in properly quoted form Patrik Jakobsson (5): drm: Add config for detecting libdrm drm: Add private data field to trace control block drm: Add dispatcher and driver identification for DRM drm: Ad

[Intel-gfx] [PATCH v2 3/5] drm: Add dispatcher and driver identification for DRM

2015-06-18 Thread Patrik Jakobsson
* Makefile.am: Add compilation of drm.c * defs.h: Declarations of drm functions * drm.c: Utility functions for drm driver detection * io.c: Dispatch drm ioctls * ioctl.c: Distpatch generic and driver specific ioctls Signed-off-by: Patrik Jakobsson --- Makefile.am | 1 + defs.h | 4

[Intel-gfx] [PATCH v2 4/5] drm: Add decoding of i915 ioctls

2015-06-18 Thread Patrik Jakobsson
SETPARAM parameters * xlat/drm_i915_ioctls.in: List i915 ioctls Signed-off-by: Patrik Jakobsson --- Makefile.am| 1 + drm.c | 14 ++ drm_i915.c | 332 + xlat/drm_i915_getparams.in | 28 xlat

[Intel-gfx] [PATCH v2 2/5] drm: Add private data field to trace control block

2015-06-18 Thread Patrik Jakobsson
ioctl. * defs.h: Add private data field in struct tcb Signed-off-by: Patrik Jakobsson --- defs.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/defs.h b/defs.h index c02f810..5b0670e 100644 --- a/defs.h +++ b/defs.h @@ -266,6 +266,13 @@ struct tcb { int u_error

[Intel-gfx] [PATCH] drm/i915: Fix intel_crtc typo in intel_pre_plane_update()

2015-06-29 Thread Patrik Jakobsson
Fixes broken build introduced by: commit 81636fdb79346e415e4726f2b6d439ccff9af1c6 Author: Rodrigo Vivi Date: Fri Jun 26 13:55:54 2015 -0700 drm/i915: Fix IPS related flicker Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- 1 file changed, 2 insertions

Re: [Intel-gfx] [PATCH v2 0/5] drm: Add decoding for DRM/KMS and i915 ioctls

2015-06-29 Thread Patrik Jakobsson
On Thu, Jun 18, 2015 at 10:42:40AM +0200, Patrik Jakobsson wrote: > This set of patches adds a dispatcher for handling DRM ioctls. The > kernel headers for DRM might not be available on all distributions > so we depend on libdrm for those. If libdrm is not available we fall > back o

Re: [Intel-gfx] [PATCH v2 5/5] drm: Add decoding of DRM and KMS ioctls

2015-06-30 Thread Patrik Jakobsson
On Mon, Jun 29, 2015 at 07:35:00PM +0200, Gabriel Laskar wrote: > On Thu, 18 Jun 2015 10:42:45 +0200 > Patrik Jakobsson wrote: > > > This patch adds many of the DRM and KMS ioctls. The rest can be added as > > needed. > > > > * drm.c: Decode DRM_

Re: [Intel-gfx] [PATCH v2 4/5] drm: Add decoding of i915 ioctls

2015-06-30 Thread Patrik Jakobsson
On Mon, Jun 29, 2015 at 07:46:50PM +0200, Gabriel Laskar wrote: > On Thu, 18 Jun 2015 10:42:44 +0200 > Patrik Jakobsson wrote: > > > There are more ioctls to add but the ones in this patch are most > > commonly used. > > > > * Makefile.am: Add compilation of

Re: [Intel-gfx] [PATCH v2 5/5] drm: Add decoding of DRM and KMS ioctls

2015-06-30 Thread Patrik Jakobsson
On Thu, Jun 18, 2015 at 10:42:45AM +0200, Patrik Jakobsson wrote: > This patch adds many of the DRM and KMS ioctls. The rest can be added as > needed. > > * drm.c: Decode DRM_IOCTL_VERSION > * drm.c: Decode DRM_IOCTL_GET_UNIQUE > * drm.c: Decode DRM_IOCTL_GET_MAGIC

[Intel-gfx] [PATCH v3 0/5] drm: Add decoding for DRM/KMS and i915 ioctls

2015-07-01 Thread Patrik Jakobsson
n't return before private data is freed in drm_ioctl() Patrik Jakobsson (5): drm: Add config for detecting libdrm drm: Add private data field to trace control block drm: Add dispatcher and driver identification for DRM drm: Add decoding of i915 ioctls drm: Add decoding of DRM

[Intel-gfx] [PATCH v3 1/5] drm: Add config for detecting libdrm

2015-07-01 Thread Patrik Jakobsson
Use pkg-config to try to find libdrm. If that fails use the standard include directory for kernel drm headers in /usr/include/drm. * configure.ac: Use pkg-config to find libdrm Signed-off-by: Patrik Jakobsson --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac

[Intel-gfx] [PATCH v3 2/5] drm: Add private data field to trace control block

2015-07-01 Thread Patrik Jakobsson
ioctl. * defs.h: Add private data field in struct tcb Signed-off-by: Patrik Jakobsson --- defs.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/defs.h b/defs.h index c02f810..5b0670e 100644 --- a/defs.h +++ b/defs.h @@ -266,6 +266,13 @@ struct tcb { int u_error

[Intel-gfx] [PATCH v3 5/5] drm: Add decoding of DRM and KMS ioctls

2015-07-01 Thread Patrik Jakobsson
DRM_IOCTL_DIRTYFB * drm.c: Decode DRM_IOCTL_CREATE_DUMB * drm.c: Decode DRM_IOCTL_MAP_DUMB * drm.c: Decode DRM_IOCTL_DESTROY_DUMB * drm.c: Decode DRM_IOCTL_GEM_CLOSE Signed-off-by: Patrik Jakobsson --- drm.c | 544 ++ 1 file changed, 544

[Intel-gfx] [PATCH v3 4/5] drm: Add decoding of i915 ioctls

2015-07-01 Thread Patrik Jakobsson
SETPARAM parameters * xlat/drm_i915_ioctls.in: List i915 ioctls Signed-off-by: Patrik Jakobsson --- Makefile.am| 1 + drm.c | 18 ++- drm_i915.c | 332 + xlat/drm_i915_getparams.in | 28 xlat

[Intel-gfx] [PATCH v3 3/5] drm: Add dispatcher and driver identification for DRM

2015-07-01 Thread Patrik Jakobsson
* Makefile.am: Add compilation of drm.c * defs.h: Declarations of drm functions * drm.c: Utility functions for drm driver detection * io.c: Dispatch drm ioctls * ioctl.c: Distpatch generic and driver specific ioctls Signed-off-by: Patrik Jakobsson --- Makefile.am | 1 + defs.h | 4

Re: [Intel-gfx] [PATCH v3 2/5] drm: Add private data field to trace control block

2015-07-06 Thread Patrik Jakobsson
On Fri, Jul 03, 2015 at 03:33:31AM +0300, Dmitry V. Levin wrote: > On Wed, Jul 01, 2015 at 02:52:45PM +0200, Patrik Jakobsson wrote: > [...] > > --- a/defs.h > > +++ b/defs.h > > @@ -266,6 +266,13 @@ struct tcb { > > int u_error;/* E

Re: [Intel-gfx] [PATCH v3 4/5] drm: Add decoding of i915 ioctls

2015-07-06 Thread Patrik Jakobsson
On Fri, Jul 03, 2015 at 03:36:09AM +0300, Dmitry V. Levin wrote: > On Wed, Jul 01, 2015 at 02:52:47PM +0200, Patrik Jakobsson wrote: > [...] > > --- a/drm.c > > +++ b/drm.c > > @@ -35,6 +35,9 @@ > > > > #define DRM_MAX_NAME_LEN 128 > > > > +e

Re: [Intel-gfx] [PATCH v2 03/20] drm/i915: Fix noatomic crtc disabling.

2015-07-07 Thread Patrik Jakobsson
On Tue, Jul 07, 2015 at 12:22:12PM +0200, Maarten Lankhorst wrote: > Op 07-07-15 om 11:18 schreef Daniel Vetter: > > On Tue, Jul 07, 2015 at 09:08:14AM +0200, Maarten Lankhorst wrote: > >> This should fix suspend on newer platforms. > > Which patch broke this? Also what is "newer platform" and what

[Intel-gfx] [PATCH] drm/i915: Don't forget to mark crtc as inactive after disable

2015-07-07 Thread Patrik Jakobsson
per Signed-off-by: Daniel Vetter Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/i915/intel_display.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 99bf147..ffd2c96 100644 --- a/drivers/gpu/

Re: [Intel-gfx] [PATCH v2 03/20] drm/i915: Fix noatomic crtc disabling.

2015-07-08 Thread Patrik Jakobsson
On Tue, Jul 07, 2015 at 04:14:01PM +0200, Maarten Lankhorst wrote: > Op 07-07-15 om 14:39 schreef Patrik Jakobsson: > > On Tue, Jul 07, 2015 at 12:22:12PM +0200, Maarten Lankhorst wrote: > >> Op 07-07-15 om 11:18 schreef Daniel Vetter: > >>> On Tue, Jul 07, 201

[Intel-gfx] [PATCH v2] drm/i915: Don't forget to mark crtc as inactive after disable

2015-07-08 Thread Patrik Jakobsson
per Signed-off-by: Daniel Vetter v2: Don't touch disable_shared_dpll() Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/i915/intel_display.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index

[Intel-gfx] [PATCH v4 4/5] drm: Add decoding of i915 ioctls

2015-08-24 Thread Patrik Jakobsson
file. Signed-off-by: Patrik Jakobsson --- Makefile.am| 1 + defs.h | 2 + drm.c | 15 +- drm_i915.c | 342 + xlat/drm_i915_getparams.in | 28 xlat/drm_i915_ioctls.in

[Intel-gfx] [PATCH v4 1/5] drm: Add config for detecting libdrm

2015-08-24 Thread Patrik Jakobsson
Use pkg-config to try to find libdrm headers. If that fails look for the kernel headers. If no headers are found, drm support will not be compiled. * configure.ac: Use pkg-config to find libdrm Signed-off-by: Patrik Jakobsson --- configure.ac | 5 + 1 file changed, 5 insertions(+) diff

[Intel-gfx] [PATCH v4 5/5] drm: Add decoding of DRM and KMS ioctls

2015-08-24 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drm.c | 543 ++ 1 file changed, 543 insertions(+) diff --git a/drm.c b/drm.c index e220309..06f2265 100644 --- a/drm.c +++ b/drm.c @@ -104,6 +104,471 @@ int drm_decode_number(struct tcb *tcp

[Intel-gfx] [PATCH v4 3/5] drm: Add dispatcher and driver identification for DRM

2015-08-24 Thread Patrik Jakobsson
* Makefile.am: Add compilation of drm.c. * defs.h: Add extern declaration of drm_ioctl when drm headers are found. * drm.c: New file. * ioctl.c (ioctl_decode): Dispatch drm ioctls when drm headers are found. Signed-off-by: Patrik Jakobsson --- Makefile.am | 1 + defs.h | 3 ++ drm.c

[Intel-gfx] [PATCH v4 0/5] drm: Add decoding for DRM/KMS and i915 ioctls

2015-08-24 Thread Patrik Jakobsson
ecode functions * Various small fixes Patrik Jakobsson (5): drm: Add config for detecting libdrm drm: Add private data field to trace control block drm: Add dispatcher and driver identification for DRM drm: Add decoding of i915 ioctls drm: Add decoding of DRM and KMS ioctls Makefile.am

[Intel-gfx] [PATCH v4 2/5] drm: Add private data field to trace control block

2015-08-24 Thread Patrik Jakobsson
xtern declaration of free_tcb_priv_data. (struct tcb): Add priv_data and free_priv_data. * strace.c (free_tcb_priv_data): New function (drop_tcb): Execute free_tcb_priv_data callback * syscall.c (trace_syscall_exiting): Execute free_tcb_priv_data callback Signed-off-by: Patrik Jakobsson --- defs.h

[Intel-gfx] [PATCH] drm/i915: Unhook legacy suspend/resume when KMS is enabled

2015-08-25 Thread Patrik Jakobsson
river uses legacy suspend/resume helpers Legacy s/r hooks are only used for shadow-attaching drivers, warn when a KMS driver tries to use them. Signed-off-by: Gustavo Padovan Signed-off-by: Daniel Vetter Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/i915/i915_drv.

Re: [Intel-gfx] [PATCH] drm/i915: Unhook legacy suspend/resume when KMS is enabled

2015-08-25 Thread Patrik Jakobsson
On Tue, Aug 25, 2015 at 6:41 PM, Jani Nikula wrote: > On Tue, 25 Aug 2015, Daniel Vetter wrote: >> On Tue, Aug 25, 2015 at 10:51:10AM +0200, Patrik Jakobsson wrote: >>> It's not allowed to have legacy suspend/resume hooked up when >>> DRIVER_MODESET is se

Re: [Intel-gfx] [PATCH v4 2/5] drm: Add private data field to trace control block

2015-08-26 Thread Patrik Jakobsson
On Tue, Aug 25, 2015 at 11:12 PM, Mike Frysinger wrote: > On 24 Aug 2015 14:42, Patrik Jakobsson wrote: >> We need to be able to store private data in the tcb across it's >> lifetime. To ensure proper destruction of the data a free_priv_data >> callback must be provided

Re: [Intel-gfx] [PATCH v4 2/5] drm: Add private data field to trace control block

2015-08-31 Thread Patrik Jakobsson
On Wed, Aug 26, 2015 at 03:26:08PM +0200, Patrik Jakobsson wrote: > On Tue, Aug 25, 2015 at 11:12 PM, Mike Frysinger wrote: > > On 24 Aug 2015 14:42, Patrik Jakobsson wrote: > >> We need to be able to store private data in the tcb across it's > >> lifetime. To

Re: [Intel-gfx] [PATCH v4 2/5] drm: Add private data field to trace control block

2015-09-07 Thread Patrik Jakobsson
On Mon, Sep 7, 2015 at 6:51 PM, Dmitry V. Levin wrote: > On Mon, Aug 31, 2015 at 02:37:07PM +0200, Patrik Jakobsson wrote: > [...] >> Here's my take on it (I assume it needs some discussion): >> >> int >> set_tcb_priv_data(struct tcb *tcp, void *priv_data)

Re: [Intel-gfx] [PATCH v4 3/5] drm: Add dispatcher and driver identification for DRM

2015-09-11 Thread Patrik Jakobsson
On Tue, Sep 08, 2015 at 03:36:25AM +0300, Dmitry V. Levin wrote: > On Mon, Aug 24, 2015 at 02:42:48PM +0200, Patrik Jakobsson wrote: > > * Makefile.am: Add compilation of drm.c. > > * defs.h: Add extern declaration of drm_ioctl when drm headers are found. > > * drm.c: Ne

Re: [Intel-gfx] [PATCH v4 4/5] drm: Add decoding of i915 ioctls

2015-09-11 Thread Patrik Jakobsson
On Tue, Sep 08, 2015 at 04:18:11AM +0300, Dmitry V. Levin wrote: > On Mon, Aug 24, 2015 at 02:42:49PM +0200, Patrik Jakobsson wrote: > > +static int i915_getparam(struct tcb *tcp, const unsigned int code, long > > arg) > > +{ > > + struct drm_i915_getpar

Re: [Intel-gfx] [PATCH v4 5/5] drm: Add decoding of DRM and KMS ioctls

2015-09-11 Thread Patrik Jakobsson
On Wed, Sep 09, 2015 at 01:50:40AM +0300, Dmitry V. Levin wrote: > On Mon, Aug 24, 2015 at 02:42:50PM +0200, Patrik Jakobsson wrote: > > First batch of drm / kms ioctls. > > Several comments in addition to issues similar to 4/5 patch. > > > +static int drm_mode_rm_f

[Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

2015-09-11 Thread Patrik Jakobsson
o fixed in this patch. This is posted as an RFC since DMC and DC state handling is being reworked and will possibly affect the outcome of this patch. The patch has known warnings. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/i915/intel_ddi.c| 9 + drivers/gpu/drm/i915/intel_dr

Re: [Intel-gfx] [PATCH v4 5/5] drm: Add decoding of DRM and KMS ioctls

2015-09-11 Thread Patrik Jakobsson
On Fri, Sep 11, 2015 at 03:10:05PM +0300, Dmitry V. Levin wrote: > On Fri, Sep 11, 2015 at 01:39:29PM +0200, Patrik Jakobsson wrote: > > On Wed, Sep 09, 2015 at 01:50:40AM +0300, Dmitry V. Levin wrote: > > > On Mon, Aug 24, 2015 at 02:42:50PM +0200, Patrik Jakobsson wrote: &

Re: [Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

2015-09-14 Thread Patrik Jakobsson
On Mon, Sep 14, 2015 at 11:50:29AM +0200, Daniel Vetter wrote: > On Fri, Sep 11, 2015 at 01:55:22PM +0200, Patrik Jakobsson wrote: > > We need to be able to control if DC6 is allowed or not. Much like > > requesting power to a specific piece of the hardware we need to be able >

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Assign hwmode after encoder state readout

2015-09-14 Thread Patrik Jakobsson
ooks good. Here's a bug fixed by this patch. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91428 Reviewed-by: Patrik Jakobsson > > Cc: Maarten Lankhorst > Cc: Patrik Jakobsson > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_display.c | 57 &

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Move sprite/cursor plane disable to intel_sanitize_crtc()

2015-09-14 Thread Patrik Jakobsson
ree, this is better. Probably related bug report: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91910 Reviewed-by: Patrik Jakobsson > > Cc: Maarten Lankhorst > Cc: Patrik Jakobsson > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_display.c | 44

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move scanline_offset and timestamping constant setup to intel_modeset_readout_hw_state()

2015-09-14 Thread Patrik Jakobsson
y are basically part of the state we > read out. > > Cc: Maarten Lankhorst > Cc: Patrik Jakobsson > Signed-off-by: Ville Syrjälä Makes sense to move it. Reviewed-by: Patrik Jakobsson > --- > drivers/gpu/drm/i915/intel_display.c | 5 +++-- > 1 file changed, 3 insertio

Re: [Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

2015-09-21 Thread Patrik Jakobsson
On Wed, Sep 16, 2015 at 11:10:07PM +0300, Ville Syrjälä wrote: > On Fri, Sep 11, 2015 at 01:55:22PM +0200, Patrik Jakobsson wrote: > > We need to be able to control if DC6 is allowed or not. Much like > > requesting power to a specific piece of the hardware we need to be able >

Re: [Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

2015-09-21 Thread Patrik Jakobsson
On Mon, Sep 21, 2015 at 11:26:06AM +0300, Jani Nikula wrote: > On Mon, 21 Sep 2015, Patrik Jakobsson > wrote: > > On Wed, Sep 16, 2015 at 11:10:07PM +0300, Ville Syrjälä wrote: > >> On Fri, Sep 11, 2015 at 01:55:22PM +0200, Patrik Jakobsson wrote: > >> > We nee

Re: [Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

2015-09-21 Thread Patrik Jakobsson
On Thu, Sep 17, 2015 at 02:14:37PM +0300, Ville Syrjälä wrote: > On Wed, Sep 16, 2015 at 11:10:07PM +0300, Ville Syrjälä wrote: > > On Fri, Sep 11, 2015 at 01:55:22PM +0200, Patrik Jakobsson wrote: > > > We need to be able to control if DC6 is allowed or not. Much like > >

Re: [Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

2015-09-21 Thread Patrik Jakobsson
On Mon, Sep 21, 2015 at 12:43:36PM +0200, Patrik Jakobsson wrote: > On Thu, Sep 17, 2015 at 02:14:37PM +0300, Ville Syrjälä wrote: > > On Wed, Sep 16, 2015 at 11:10:07PM +0300, Ville Syrjälä wrote: > > > On Fri, Sep 11, 2015 at 01:55:22PM +0200, Patrik Jakobsson wrote: > >

Re: [Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

2015-09-23 Thread Patrik Jakobsson
On Wed, Sep 23, 2015 at 10:43:00AM +0200, Daniel Vetter wrote: > On Mon, Sep 21, 2015 at 10:00:45AM +0200, Patrik Jakobsson wrote: > > On Wed, Sep 16, 2015 at 11:10:07PM +0300, Ville Syrjälä wrote: > > > On Fri, Sep 11, 2015 at 01:55:22PM +0200, Patrik Jakobsson wrote: > >

Re: [Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

2015-09-24 Thread Patrik Jakobsson
On Wed, Sep 23, 2015 at 01:18:00PM +0200, Patrik Jakobsson wrote: > On Wed, Sep 23, 2015 at 10:43:00AM +0200, Daniel Vetter wrote: > > On Mon, Sep 21, 2015 at 10:00:45AM +0200, Patrik Jakobsson wrote: > > > On Wed, Sep 16, 2015 at 11:10:07PM +0300, Ville Syrjälä wrote: > >

Re: [Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

2015-09-25 Thread Patrik Jakobsson
On Thu, Sep 24, 2015 at 06:20:14PM +0300, Ville Syrjälä wrote: > On Thu, Sep 24, 2015 at 02:50:16PM +0200, Patrik Jakobsson wrote: > > On Wed, Sep 23, 2015 at 01:18:00PM +0200, Patrik Jakobsson wrote: > > > On Wed, Sep 23, 2015 at 10:43:00AM +0200, Daniel Vetter wrote: > >

Re: [Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

2015-09-25 Thread Patrik Jakobsson
On Fri, Sep 25, 2015 at 12:41:42PM +0300, Imre Deak wrote: > On pe, 2015-09-25 at 10:56 +0200, Patrik Jakobsson wrote: > > On Thu, Sep 24, 2015 at 06:20:14PM +0300, Ville Syrjälä wrote: > > > On Thu, Sep 24, 2015 at 02:50:16PM +0200, Patrik Jakobsson wrote: > > > >

Re: [Intel-gfx] [DMC_BUGFIX_SKL_V2 3/5] drm/i915/skl: Making DC6 entry is the last call in suspend flow.

2015-09-29 Thread Patrik Jakobsson
On Tue, Sep 29, 2015 at 11:01:35AM +0200, Daniel Vetter wrote: > On Tue, Sep 29, 2015 at 11:08:25AM +0530, Animesh Manna wrote: > > > > > > On 09/28/2015 12:51 PM, Daniel Vetter wrote: > > >On Wed, Aug 26, 2015 at 01:36:07AM +0530, Animesh Manna wrote: > > >>Mmio register access after dc6/dc5 ent

[Intel-gfx] [RFC 0/2] strace/drm: Add i915 ioctls to strace

2015-05-06 Thread Patrik Jakobsson
will extend this patch set if the approach looks ok. The generic drm ioctls are also missing. Give it a spin with: strace -e trace=ioctl -p `pidof X` Patrik Jakobsson (2): strace/drm: Print extended info for drm and i915 ioctls strace/drm: Print args for most common i915 ioctls

[Intel-gfx] [RFC 1/2] strace/drm: Print extended info for drm and i915 ioctls

2015-05-06 Thread Patrik Jakobsson
This adds a dispatcher for extending drm ioctl debugging info and adds the i915 ioctls to the xlat framework. Signed-off-by: Patrik Jakobsson --- Makefile.am | 2 + defs.h | 2 + drm.c | 104

[Intel-gfx] [RFC 2/2] strace/drm: Print args for most common i915 ioctls

2015-05-06 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drm_i915.c | 235 + xlat/drm_i915_getparams.in | 28 ++ xlat/drm_i915_setparams.in | 4 + 3 files changed, 267 insertions(+) create mode 100644 xlat/drm_i915_getparams.in create mode 100644

Re: [Intel-gfx] [RFC 0/2] strace/drm: Add i915 ioctls to strace

2015-05-11 Thread Patrik Jakobsson
On Thu, May 07, 2015 at 08:37:40AM -0700, Jesse Barnes wrote: > On 05/06/2015 07:48 AM, Patrik Jakobsson wrote: > > This patch set aims to make strace more useful when tracing i915 ioctls. > > The ioctl type is first checked for being drm and then the driver > > backing

Re: [Intel-gfx] [RFC 0/2] strace/drm: Add i915 ioctls to strace

2015-05-11 Thread Patrik Jakobsson
On Mon, May 11, 2015 at 12:50:36PM +0200, Gabriel Laskar wrote: > On Wed, 6 May 2015 16:48:01 +0200 > Patrik Jakobsson wrote: > > > This patch set aims to make strace more useful when tracing i915 ioctls. > > The ioctl type is first checked for being drm and then the d

Re: [Intel-gfx] [RFC 0/2] strace/drm: Add i915 ioctls to strace

2015-05-12 Thread Patrik Jakobsson
On Mon, May 11, 2015 at 08:08:19PM +0200, Gabriel Laskar wrote: > On Mon, 11 May 2015 15:54:24 +0200 > Patrik Jakobsson wrote: > > > On Mon, May 11, 2015 at 12:50:36PM +0200, Gabriel Laskar wrote: > > > On Wed, 6 May 2015 16:48:01 +0200 > > > Patrik Jakobsson

Re: [Intel-gfx] [RFC 0/2] strace/drm: Add i915 ioctls to strace

2015-05-19 Thread Patrik Jakobsson
On Wed, May 13, 2015 at 01:10:17AM +0300, Dmitry V. Levin wrote: > On Tue, May 12, 2015 at 07:37:59PM +0200, Gabriel Laskar wrote: > > On Tue, 12 May 2015 14:35:28 +0200, Patrik Jakobsson wrote: > > > On Mon, May 11, 2015 at 08:08:19PM +0200, Gabriel Laskar wrote: > > >

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't forget to mark crtc as inactive after disable

2015-07-10 Thread Patrik Jakobsson
ld be picked up from the commit msg by git-send-email but maybe that doesn't work on indented lines. Anyways, CCing them now. Thanks Patrik > > On Wed, Jul 08, 2015 at 03:31:52PM +0200, Patrik Jakobsson wrote: > > Watermark calculations depend on the intel_crtc->active flag to

Re: [Intel-gfx] [PATCH v3 4/5] drm: Add decoding of i915 ioctls

2015-07-10 Thread Patrik Jakobsson
On Wed, Jul 08, 2015 at 03:11:36AM +0300, Dmitry V. Levin wrote: > On Mon, Jul 06, 2015 at 04:40:24PM +0200, Gabriel Laskar wrote: > > On Mon, 6 Jul 2015 12:35:52 +0200, Patrik Jakobsson wrote: > > > On Fri, Jul 03, 2015 at 03:36:09AM +0300, Dmitry V. Levin wrote: > > >

Re: [Intel-gfx] [PATCH i-g-t v2 1/2] lib/igt_fb : Add more overlay plane support for bxt

2015-07-22 Thread Patrik Jakobsson
On Wed, Jul 22, 2015 at 04:34:27AM +, Gharpure, Mayuresh S wrote: > Hi Nabendu, > > PFA. I came across this patch from Damien Lespiau which prevents the topmost > plane from being exposed to user space. > > Once this patch is merged, the following correction in i-g-t won't be > required as

Re: [Intel-gfx] [PATCH v3 1/5] drm: Add config for detecting libdrm

2015-07-30 Thread Patrik Jakobsson
On Thu, Jul 23, 2015 at 05:48:21AM -0400, Mike Frysinger wrote: > On 01 Jul 2015 14:52, Patrik Jakobsson wrote: > > Use pkg-config to try to find libdrm. If that fails use the standard > > include directory for kernel drm headers in /usr/include/drm. > > > > * configure

Re: [Intel-gfx] [PATCH v3 1/5] drm: Add config for detecting libdrm

2015-07-31 Thread Patrik Jakobsson
On Thu, Jul 30, 2015 at 10:04:49AM -0400, Mike Frysinger wrote: > On 30 Jul 2015 15:30, Patrik Jakobsson wrote: > > On Thu, Jul 23, 2015 at 05:48:21AM -0400, Mike Frysinger wrote: > > > On 01 Jul 2015 14:52, Patrik Jakobsson wrote: > > > > Use pkg-config to try to

Re: [Intel-gfx] [PATCH 0/4] Fix SKL runtime PM

2015-07-31 Thread Patrik Jakobsson
ust not > failing 100% of the tests. Good find! I also started looking into this and came up with something similar. The series looks fine to me but I agree with Jani that you can squash enable/disable into one commit. Now lets hope the bugs uncovered by this series are trivial to fix. For t

[Intel-gfx] [PATCH] drm/i915: Postpone plane readout until after encoder readout

2015-07-31 Thread Patrik Jakobsson
skl_compute_linetime_wm() where pixel_rate becomes 0 when crtc_clock is 0. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/i915/intel_display.c | 38 +--- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers

Re: [Intel-gfx] [PATCH v3 1/5] drm: Add config for detecting libdrm

2015-08-02 Thread Patrik Jakobsson
On Sat, Aug 1, 2015 at 8:22 PM, Dmitry V. Levin wrote: > On Fri, Jul 31, 2015 at 11:09:11AM +0200, Patrik Jakobsson wrote: >> On Thu, Jul 30, 2015 at 10:04:49AM -0400, Mike Frysinger wrote: >> > On 30 Jul 2015 15:30, Patrik Jakobsson wrote: >> > > On Thu, Jul 23,

Re: [Intel-gfx] [PATCH] drm/i915: Postpone plane readout until after encoder readout

2015-08-04 Thread Patrik Jakobsson
On Mon, Aug 3, 2015 at 4:36 PM, Maarten Lankhorst wrote: > Hey, > > Op 31-07-15 om 15:04 schreef Patrik Jakobsson: >> When reading out hw state for planes we disable inactive planes which in >> turn triggers an update of the watermarks. The update depends on the >> cr

Re: [PATCH v2 12/19] drm/gma500: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct()

2025-07-01 Thread Patrik Jakobsson
; is needed. > > Cc: Patrik Jakobsson > Reviewed-by: Thomas Zimmermann > Signed-off-by: Ville Syrjälä Acked-by: Patrik Jakobsson > --- > drivers/gpu/drm/gma500/fbdev.c | 5 - > drivers/gpu/drm/gma500/framebuffer.c | 14 +++--- > drivers/gpu/drm

<    1   2   3