of WARN* with dev_WARN*, but there
are still cases where device pointer is not readily available in some
functions (or I missed them somehow) having warning hence some manual
churning is needed. Handle such remaining cases separately later.
Pankaj Bharadiya (7):
treewide: device: add condition
Device specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific dev_WARN*
variants in functions where first function argument is a
struct pointer and has drm_i915_private struct pointer
It's quite useful to print the device name on the stack dump caused
by WARN_ON*.
Introduce dev_WARN_ON and dev_WARN_ON_ONCE macros for the same.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/i915_utils.h | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gp
We will need struct device pointer to pass it to dev_WARN* calls.
Add helper functions to exract device pointer from various structs.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_display_types.h | 14 ++
drivers/gpu/drm/i915/gvt/gvt.h
ile.
Signed-off-by: Pankaj Bharadiya
---
arch/x86/platform/intel-mid/pwr.c | 3 ++-
drivers/base/core.c | 2 +-
drivers/base/dd.c | 3 ++-
drivers/dax/bus.c | 2 +-
drive
Device specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific dev_WARN*
variants in functions where any one of intel_pm, intel_encoder,
i915_perf_stream or intel_crtc_state struct poin
Device specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific dev_WARN*
variants in functions where drm_device struct pointer is readily
available.
The conversion was done automatical
* macros and use them as suggested by Sam and Jani
- Get rid of extra local variables
[1] https://patchwork.freedesktop.org/series/71668/
Pankaj Bharadiya (6):
drm/print: introduce new struct drm_device based WARN* macros
drm/i915: add helper functions to get device ptr
drm/i915: Make WARN* drm
.
Knowing the device specific information in the backtrace would be
helpful in development all around.
Signed-off-by: Pankaj Bharadiya
---
include/drm/drm_print.h | 30 ++
1 file changed, 30 insertions(+)
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
Drm specific drm_WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_device struct pointer is readily
available.
The conversion was done automatica
We will need struct drm_device pointer to pass it to drm_WARN* calls.
Add helper functions to exract drm_device pointer from various structs.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_display_types.h | 14 ++
drivers/gpu/drm/i915/gvt/gvt.h
Drm specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where first function argument is a
struct pointer and has drm_i915_private struct pointer mem
Drm specific drm_WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where any one of intel_pm, intel_encoder,
i915_perf_stream or intel_crtc_state struct poi
.
Knowing the device specific information in the backtrace would be
helpful in development all around.
Signed-off-by: Pankaj Bharadiya
---
include/drm/drm_print.h | 29 +
1 file changed, 29 insertions(+)
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
71668/
Pankaj Bharadiya (10):
drm/print: introduce new struct drm_device based WARN* macros
drm/i915/display: Make WARN* drm specific where drm_device ptr is available
drm/i915/display: Make WARN* drm specific where drm_priv ptr is available
drm/i915/display: Make WARN* drm specific where en
.
Knowing the device specific information in the backtrace would be
helpful in development all around.
Signed-off-by: Pankaj Bharadiya
---
include/drm/drm_print.h | 29 +
1 file changed, 29 insertions(+)
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
Drm specific drm_WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_device struct pointer is readily
available.
The conversion was done automatica
Drm specific drm_WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_device struct pointer is readily
available.
The conversion was done automatica
71668/
Pankaj Bharadiya (10):
drm/print: introduce new struct drm_device based WARN* macros
drm/i915/display: Make WARN* drm specific where drm_device ptr is available
drm/i915/display: Make WARN* drm specific where drm_priv ptr is available
drm/i915/display: Make WARN* drm specific where en
Drm specific drm_WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where intel_encoder struct pointer is available.
The conversion was done automatically w
drm specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_i915_private struct pointer is readily
available.
The conversion was done automati
drm specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_i915_private struct pointer is readily
available.
The conversion was done automati
drm specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_i915_private struct pointer is readily
available.
The conversion was done automati
drm specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_i915_private struct pointer is readily
available.
The conversion was done automati
Drm specific drm_WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_device struct pointer is readily
available.
The conversion was done automatica
drm specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_i915_private struct pointer is readily
available.
The conversion was done automati
drm specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where intel_uncore/i915_perf_stream struct
pointer is readily available.
The conversion was
Drm specific drm_WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_device struct pointer is readily
available.
The conversion was done automatica
local variables
[1] https://patchwork.freedesktop.org/series/71668/
Pankaj Bharadiya (4):
drm/i915/display: Make WARN* drm specific where drm_device ptr is available
drm/i915/display: Make WARN* drm specific where drm_priv ptr is available
drm/i915/gvt: Make WARN* drm specific where drm_pri
Drm specific drm_WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_device struct pointer is readily
available.
The conversion was done automatica
drm specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_i915_private struct pointer is readily
available.
The conversion was done automati
drm specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_i915_private struct pointer is readily
available.
The conversion was done automati
turn calls the
intel_bw_destroy_state() to make sure the intel_bw_state memory is
freed properly.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_bw.c | 5 +
drivers/gpu/drm/i915/display/intel_bw.h | 1 +
drivers/gpu/drm/i915/display/intel_display.c | 2 ++
3 fil
Add documentation for newly introduced KMS plane and CRTC scaling
filter properties.
changes since RFC:
* Add seperate documention for plane and CRTC.
Signed-off-by: Pankaj Bharadiya
---
Documentation/gpu/drm-kms.rst | 12
1 file changed, 12 insertions(+)
diff --git a
sharp, blocky images to deliver their
distinctive look.
changes since RFC:
* Add separate properties for plane and CRTC (Ville)
Signed-off-by: Shashank Sharma
Signed-off-by: Ankit Nautiyal
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/drm_atomic_uapi.c | 8
drivers/gpu/drm/drm_c
plane.
- Implements and enable integer scaling for i915
Userspace patch series link: TBD.
Thanks to Shashank for initiating this work. His initial work can be
found here [2]
[2] https://patchwork.freedesktop.org/patch/337082/
Pankaj Bharadiya (5):
drm: Introduce plane and CRTC scaling filter properties
ned-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/i915_reg.h | 48 +
1 file changed, 48 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index ee4a75ac9186..c64213755296 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++
e crtc co-ordinate (Danial Stone, Ville)
* Add new functions to handle scaling filter setup (Ville)
* Remove coefficient set 0 hardcoding.
Signed-off-by: Shashank Sharma
Signed-off-by: Ankit Nautiyal
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_displ
filter coefficients to enable nearest-neighbor
filtering.
Bspec: 49247
changes since RFC:
* Refine the skl_scaler_setup_nearest_neighbor_filter() logic (Ville)
Signed-off-by: Shashank Sharma
Signed-off-by: Ankit Nautiyal
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display
sharp, blocky images to deliver their
distinctive look.
changes since v1:
* None
changes since RFC:
* Add separate properties for plane and CRTC (Ville)
Signed-off-by: Shashank Sharma
Signed-off-by: Ankit Nautiyal
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/drm_atomic_uapi.c
nk to this cover letter.
* 4/5 - Rearrange skl_scaler_setup_nearest_neighbor_filter() to iterate
the registers directly instead of the phases and taps (Ville)
Pankaj Bharadiya (5):
drm: Introduce plane and CRTC scaling filter properties
drm/drm-kms.rst: Add plane and CRTC scaling filter pro
Add documentation for newly introduced KMS plane and CRTC scaling
filter properties.
changes since v1:
* None
changes since RFC:
* Add separate documentation for plane and CRTC.
Signed-off-by: Pankaj Bharadiya
---
Documentation/gpu/drm-kms.rst | 12
1 file changed, 12 insertions
(Ville)
Signed-off-by: Shashank Sharma
Signed-off-by: Ankit Nautiyal
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_display.c | 72
drivers/gpu/drm/i915/display/intel_display.h | 2 +
2 files changed, 74 insertions(+)
diff --git a/drivers/gpu/drm
lle)
* Do not round off the crtc co-ordinate (Danial Stone, Ville)
* Add new functions to handle scaling filter setup (Ville)
* Remove coefficient set 0 hardcoding.
Signed-off-by: Shashank Sharma
Signed-off-by: Ankit Nautiyal
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i91
-by: Ankit Nautiyal
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/i915_reg.h | 48 +
1 file changed, 48 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 9c53fe918be6..d40f12d2a6b5 100644
--- a/drivers/gp
ectly instead of the phases and taps (Ville)
Pankaj Bharadiya (5):
drm: Introduce plane and CRTC scaling filter properties
drm/drm-kms.rst: Add plane and CRTC scaling filter property
documentation
drm/i915: Introduce scaling filter related registers and bit fields.
drm/i915/display
Add documentation for newly introduced KMS plane and CRTC scaling
filter properties.
changes since v1:
* None
changes since RFC:
* Add separate documentation for plane and CRTC.
Signed-off-by: Pankaj Bharadiya
---
Documentation/gpu/drm-kms.rst | 12
1 file changed, 12 insertions
ly on sharp, blocky images to deliver their
distinctive look.
changes since v2:
* Create per-plane and per-CRTC scaling filter property (Ville)
changes since v1:
* None
changes since RFC:
* Add separate properties for plane and CRTC (Ville)
Signed-off-by: Pankaj Bharadiya
---
drivers/gp
registers directly instead of the phases and taps (Ville)
changes since RFC:
* Refine the skl_scaler_setup_nearest_neighbor_filter() logic (Ville)
Signed-off-by: Shashank Sharma
Signed-off-by: Ankit Nautiyal
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_display.c | 99
changes since RFC:
* Parametrize scaler coeffient macros by 'set' (Ville)
Signed-off-by: Shashank Sharma
Signed-off-by: Ankit Nautiyal
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/i915_reg.h | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drive
up (Ville)
* Remove coefficient set 0 hardcoding.
Signed-off-by: Shashank Sharma
Signed-off-by: Ankit Nautiyal
Signed-off-by: Pankaj Bharadiya
---
.../gpu/drm/i915/display/intel_atomic_plane.c | 1 +
drivers/gpu/drm/i915/display/intel_display.c| 17 +++--
.../gpu/drm/i91
With below commit, we have new struct drm_device based WARN* macros,
which include device specific information in the backtrace.
commit dc1a73e50f9c63d4dd928df538082200467dc4b1
Author: Pankaj Bharadiya
Date: Wed Jan 15 09:14:45 2020 +0530
drm/print: introduce new struct drm_device based
With below commit, we have new struct drm_device based WARN* macros,
which include device specific information in the backtrace.
commit dc1a73e50f9c63d4dd928df538082200467dc4b1
Author: Pankaj Bharadiya
Date: Wed Jan 15 09:14:45 2020 +0530
drm/print: introduce new struct drm_device based
Now we have new struct drm_device based drm_WARN* macros. These are
preferred over the regular WARN* macros.
Remove WARN_ON and WARN_ON_ONCE overriedes to avoid any temptations to
use them in the future.
Suggested-by: Jani Nikula
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN_ON over WARN_ON.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/icl_dsi.c | 2 +-
1 file changed, 1 insertion(+), 1
://patchwork.freedesktop.org/series/72035/
Pankaj Bharadiya (18):
drm/i915/display/icl_dsi: Prefer drm_WARN_ON over WARN_ON
drm/i915/display/atomic_plane: Prefer drm_WARN_ON over WARN_ON
drm/i915/display/ddi: Prefer drm_WARN* over WARN*
drm/i915/display/display: Prefer drm_WARN_ON over WARN_ON
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN_ON over WARN_ON.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_atomic_plane.c | 4 ++--
1 file changed, 2
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN* over WARN* calls.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_ddi.c | 14 --
1 file changed, 8
m_i915_private *i915 = dp_to_i915(T);
<+...
(
-WARN_ON(
+drm_WARN_ON(&i915->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONCE(&i915->drm,
...)
)
...+>
}
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_dp.c | 26 -
1 file changed, 17 ins
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN_ON over WARN_ON.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_frontbuffer.c | 6 --
1 file changed, 4
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN_ON over WARN_ON at places where struct drm_device
pointer can be extracted.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN* over WARN* calls.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_global_state.c | 4 ++--
1 file changed, 2
,...) {
<+...
-WARN_ON(
+drm_WARN_ON(T->base.base.dev,
...)
...+>
}
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_tc.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_tc.c
b/drivers/gpu/drm/i915/display/i
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN_ON over WARN_ON.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_overlay.c | 6 +++---
1 file changed, 3
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN* over WARN* calls.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_sdvo.c | 16 +---
1 file changed, 9
func, T;
@@
func(struct i915_power_domains *T,...) {
+ struct drm_i915_private *i915 = container_of(T, struct drm_i915_private,
power_domains);
<+...
-WARN_ON(
+drm_WARN_ON(&i915->drm,
...)
...+>
}
Signed-off-by: Pankaj Bharadiya
---
.../drm/i915/display/intel_display_po
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN_ON over WARN_ON at places where struct drm_device
pointer can be extracted.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915
drm_i915_private *i915 = container_of(T, struct drm_i915_private,
runtime_pm);
<+...
(
-WARN(
+drm_WARN(&i915->drm,
...)
|
-WARN_ON(
+drm_WARN_ON(&i915->drm,
...)
|
-WARN_ONCE(
+drm_WARN_ONCE(&i915->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONCE(&i915->drm,
...)
)
...+>
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN* over WARN* at places where struct drm_device pointer
can be extracted.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/gem
= ...;
<+...
-WARN_ON(
+drm_WARN_ON(T->base.dev,
...)
...+>
}
@@
identifier func, T;
@@
func(struct intel_crtc_state *T,...) {
<+...
-WARN_ON(
+drm_WARN_ON(T->uapi.crtc->dev,
...)
...+>
}
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/intel_pm.c | 57 ++--
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN_ON over WARN_ON.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/i915_drv.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN_ON over WARN_ON.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/vlv_dsi.c | 2 +-
1 file changed, 1 insertion(+), 1
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN_ON over WARN_ON.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/i915_pmu.c | 11 ---
1 file changed, 8 insertions(+), 3
e scaling filter setup (Ville)
* Remove coefficient set 0 hardcoding.
Signed-off-by: Shashank Sharma
Signed-off-by: Ankit Nautiyal
Signed-off-by: Pankaj Bharadiya
---
.../gpu/drm/i915/display/intel_atomic_plane.c | 1 +
drivers/gpu/drm/i915/display/intel_display.c| 17 +++--
..
* 4/5 - Rearrange skl_scaler_setup_nearest_neighbor_filter() to iterate
the registers directly instead of the phases and taps (Ville)
Pankaj Bharadiya (5):
drm: Introduce plane and CRTC scaling filter properties
drm/drm-kms.rst: Add plane and CRTC scaling filter property documentation
drm/i915: Intr
skl_scaler_setup_nearest_neighbor_filter() to iterate the
registers directly instead of the phases and taps (Ville)
changes since RFC:
* Refine the skl_scaler_setup_nearest_neighbor_filter() logic (Ville)
Signed-off-by: Shashank Sharma
Signed-off-by: Ankit Nautiyal
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915
CRTC (Ville)
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/drm_atomic_uapi.c | 8 +++
drivers/gpu/drm/drm_crtc.c | 48 +++
drivers/gpu/drm/drm_crtc_internal.h | 3 +
drivers/gpu/drm/drm_plane.c | 90 +
include/drm/drm_c
).
changes since v1:
* None
changes since RFC:
* Parametrize scaler coeffient macros by 'set' (Ville)
Signed-off-by: Shashank Sharma
Signed-off-by: Ankit Nautiyal
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/i915_reg.h | 22 ++
1 file changed, 22 insertion
Add documentation for newly introduced KMS plane and CRTC scaling
filter properties.
changes since v3:
* None
changes since v1:
* None
changes since RFC:
* Add separate documentation for plane and CRTC.
Signed-off-by: Pankaj Bharadiya
---
Documentation/gpu/drm-kms.rst | 12
1 file
://patchwork.freedesktop.org/series/72035/
changes since v1:
- Addressed Jani's review comments
- Rebase patches on latest tip.
Pankaj Bharadiya (9):
drm/i915/display/display_power: Prefer drm_WARN_ON over WARN_ON
drm/i915/display/dp: Prefer drm_WARN* over WARN*
drm/i915/display/sdvo: P
func, T;
@@
func(struct i915_power_domains *T,...) {
+ struct drm_i915_private *i915 = container_of(T, struct drm_i915_private,
power_domains);
<+...
-WARN_ON(
+drm_WARN_ON(&i915->drm,
...)
...+>
}
changes since v1:
- Fix commit subject (Jani)
Signed-off-by: Pankaj Bharadiya
---
m_WARN_ON_ONCE(&i915->drm,
...)
)
...+>
}
@rule4@
identifier func, T;
@@
func(...) {
...
struct intel_dp *T = ...;
+ struct drm_i915_private *i915 = dp_to_i915(T);
<+...
(
-WARN_ON(
+drm_WARN_ON(&i915->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONCE(&i915->drm,
...)
)
...+>
rm_WARN_ON(&dev_priv->drm,
...)
...+>
}
changes since v1:
- Added dev_priv local variable and used it in drm_WARN_ON calls (Jani)
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/intel_pm.c | 63 -
1 file changed, 38 insertions(+), 25 deletions(-)
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN_ON over WARN_ON.
changes since v1:
- Add parentheses around the dev_priv macro argument (Jani)
Signed-off-by: Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN_ON over WARN_ON.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/i915_pmu.c | 12 +---
1 file changed, 9 insertions
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN* over WARN* calls.
changes since v1:
- Added dev_priv local variable and used it in drm_WARN* calls (Jani)
Signed-off-by: Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.
Prefer drm_WARN* over WARN* at places where struct drm_device pointer
can be extracted.
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/gem
local variable and use it in drm_WARN_ON (Jani)
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_tc.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_tc.c
b/drivers/gpu/drm/i915/display/intel_tc.c
index d3bd
drm_i915_private *i915 = container_of(T, struct drm_i915_private,
runtime_pm);
<+...
(
-WARN(
+drm_WARN(&i915->drm,
...)
|
-WARN_ON(
+drm_WARN_ON(&i915->drm,
...)
|
-WARN_ONCE(
+drm_WARN_ONCE(&i915->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONCE(&i915->drm,
...)
)
...+>
tions
- Split patches by directory
Changes since RFC at [1]
- Introduce drm_WARN* macros and use them as suggested by Sam and Jani
- Get rid of extra local variables
[1] https://patchwork.freedesktop.org/series/71668/
Pankaj Bharadiya (4):
drm/i915/display: Make WARN* drm specific where drm_d
Drm specific drm_WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_device struct pointer is readily
available.
The conversion was done automatica
Drm specific drm_WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_device struct pointer is readily
available.
The conversion was done automatica
drm specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_i915_private struct pointer is readily
available.
The conversion was done automati
drm specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_i915_private struct pointer is readily
available.
The conversion was done automati
ggested by Sam and Jani
- Get rid of extra local variables
[1] https://patchwork.freedesktop.org/series/71668/
Pankaj Bharadiya (21):
drm/i915/display/icl_dsi: Make WARN* drm specific where drm_priv ptr is
available
drm/i915/display/audio: Make WARN* drm specific where drm_priv ptr is
er func, T;
@@
func(struct drm_i915_private *T,...) {
<+...
(
-WARN(
+drm_WARN(&T->drm,
...)
|
-WARN_ON(
+drm_WARN_ON(&T->drm,
...)
|
-WARN_ONCE(
+drm_WARN_ONCE(&T->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONCE(&T->drm,
...)
)
...+>
}
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu
drm_WARN_ON_ONCE(&T->drm,
...)
)
...+>
}
@rule2@
identifier func, T;
@@
func(struct drm_i915_private *T,...) {
<+...
(
-WARN(
+drm_WARN(&T->drm,
...)
|
-WARN_ON(
+drm_WARN_ON(&T->drm,
...)
|
-WARN_ONCE(
+drm_WARN_ONCE(&T->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONC
T->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONCE(&T->drm,
...)
)
...+>
}
Signed-off-by: Pankaj Bharadiya
---
drivers/gpu/drm/i915/display/intel_audio.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_audio.c
b/drivers
drm_WARN_ON_ONCE(&T->drm,
...)
)
...+>
}
@rule2@
identifier func, T;
@@
func(struct drm_i915_private *T,...) {
<+...
(
-WARN(
+drm_WARN(&T->drm,
...)
|
-WARN_ON(
+drm_WARN_ON(&T->drm,
...)
|
-WARN_ONCE(
+drm_WARN_ONCE(&T->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONC
T->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONCE(&T->drm,
...)
)
...+>
}
Signed-off-by: Pankaj Bharadiya
---
.../drm/i915/display/intel_display_power.c| 168 ++
1 file changed, 96 insertions(+), 72 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display
1 - 100 of 199 matches
Mail list logo
