Return early if crtc or connector's debugfs root dentries are NULL.
CC: Thierry Reding
CC: David Airlie
CC: Daniel Vetter
CC: Jonathan Hunter
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/tegra/dc.c | 5 +
drivers/gpu/drm/tegra/dsi.c | 4
drivers/gpu/drm/tegra/hdmi.
Return early if dri minor root dentry is NULL.
CC: Zhenyu Wang
CC: Zhi Wang
CC: Jani Nikula
CC: Joonas Lahtinen
CC: Rodrigo Vivi
CC: David Airlie
CC: Daniel Vetter
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gvt/debugfs.c | 3 +++
drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
2
t
CC: Maxime Ripard
CC: Thomas Zimmermann
CC: David Airlie
CC: Daniel Vetter
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/drm_debugfs.c | 25 +++--
drivers/gpu/drm/drm_drv.c | 16 ++--
drivers/gpu/drm/drm_internal.h | 7 +++
3 files changed, 36 inser
Return early if dri minor root dentry is NULL.
CC: Alex Deucher
CC: "Christian König"
CC: "Pan, Xinhui"
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/radeon/r100.c | 9 +
drivers/gpu/drm/radeon/r300.c | 3 +++
drivers/gpu/drm/radeon/r420.c
Return early if dri minor root dentry is NULL.
CC: Russell King
CC: David Airlie
CC: Daniel Vetter
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/armada/armada_debugfs.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/armada/armada_debugfs.c
b/drivers/gpu/drm
Debugfs APIs returns encoded error on failure so use
debugfs_lookup() instead of checking for NULL.
CC: Lukas Wunner
CC: David Airlie
CC: Daniel Vetter
CC: Maarten Lankhorst
CC: Maxime Ripard
CC: Thomas Zimmermann
Signed-off-by: Nirmoy Das
---
drivers/gpu/vga/vga_switcheroo.c | 2 +-
1
Do not check for NULL value as drm.primary->debugfs_root
will either contain a valid pointer or an encoded error
instead of NULL.
CC: Jani Nikula
CC: Joonas Lahtinen
CC: Rodrigo Vivi
CC: David Airlie
CC: Daniel Vetter
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/debugfs_gt.c
for NULL, as saved dentry pointers will either contain a
valid pointer or an error code.
CC: Maarten Lankhorst
CC: Maxime Ripard
CC: Thomas Zimmermann
CC: David Airlie
CC: Daniel Vetter
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/drm_debugfs.c | 9 -
1 file changed, 9 deletions
For debugfs directory, it is recommended to save the result
and pass over to next debugfs API for creating debugfs
files/directories. Error conditions are handled by debugfs APIs.
CC: Christian Koenig
CC: Huang Rui
CC: David Airlie
CC: Daniel Vetter
Signed-off-by: Nirmoy Das
---
drivers
for NULL, as saved dentry pointers will either contain a
valid pointer or an error code.
Also document this for future reference.
CC: Maarten Lankhorst
CC: Maxime Ripard
CC: Thomas Zimmermann
CC: David Airlie
CC: Daniel Vetter
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/drm_debugfs.c
For debugfs directory, it is recommended to save the result
and pass over to next debugfs API for creating debugfs
files/directories. Error conditions are handled by debugfs APIs.
CC: Christian Koenig
CC: Huang Rui
CC: David Airlie
CC: Daniel Vetter
Signed-off-by: Nirmoy Das
---
drivers
Do not check for NULL value as drm.primary->debugfs_root
will either contain a valid pointer or an encoded error
instead of NULL.
CC: Jani Nikula
CC: Joonas Lahtinen
CC: Rodrigo Vivi
CC: David Airlie
CC: Daniel Vetter
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/debugfs_gt.c
Debugfs APIs returns encoded error on failure so use
debugfs_lookup() instead of checking for NULL.
CC: Lukas Wunner
CC: David Airlie
CC: Daniel Vetter
CC: Maarten Lankhorst
CC: Maxime Ripard
CC: Thomas Zimmermann
Signed-off-by: Nirmoy Das
---
drivers/gpu/vga/vga_switcheroo.c | 2 +-
1
TT access safe because
reset path make sure of that.
Suggested-by: Chris Wilson
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/intel_gt_gmch.c | 2 ++
drivers/gpu/drm/i915/gt/intel_gtt.h | 9 +
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 5 -
drivers/gpu/drm/i915/i9
TT access safe because
reset path make sure of that.
v2: Fix rebase conflict and added a comment.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5595
Reviewed-by: Gwan-gyeong Mun
Suggested-by: Chris Wilson
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/intel_g
Determine lmem_size using ADDR_RANGE register so that module
load on platfrom with small bar with css works.
Signed-off-by: Nirmoy Das
---
I once reserved a dg2 machine with small bar and module load failed on
it. I can't find that machine anymore hence sending this as RFC.
drivers/gp
From: Bommu Krishnaiah
Enable Tile4 tiling mode on platform that supports
Tile4 but no TileY like DG2.
Signed-off-by: Bommu Krishnaiah
Co-developed-by: Nirmoy Das
Signed-off-by: Nirmoy Das
---
.../i915/gem/selftests/i915_gem_client_blt.c | 238 ++
drivers/gpu/drm/i915/gt
Caller of setup_lmem() ignores -ENODEV but failing
to setup lmem on dGPU isn't ignorable error.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem
Until we enable small-bar, we can't support CCS so error
out gracefully on such platforms.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
b/drivers/gpu/drm/i9
Determine lmem_size using ADDR_RANGE register so that lmem_setup()
works on platform with small-bar as well.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt
From: Bommu Krishnaiah
Enable Tile4 tiling mode on platform that supports
Tile4 but no TileY like DG2.
v2: disable X-tile for iGPU in fastblit
fix checkpath --strict warnings
Signed-off-by: Bommu Krishnaiah
Co-developed-by: Nirmoy Das
Signed-off-by: Nirmoy Das
---
.../i915/gem
: Nirmoy Das
Signed-off-by: Nirmoy Das
---
.../i915/gem/selftests/i915_gem_client_blt.c | 250 ++
drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 22 ++
2 files changed, 227 insertions(+), 45 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c
b
_i915_vma_move_to_active() can receive > 1 fence for
multiple batch buffer submission so make sure to
individualize fences before adding to dma_resv obj
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5614
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/i915_vma.c |
function to find X-tile availability for a platform.
v2: disable Tile X for iGPU in fastblit and
fix checkpath --strict warnings.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5879
Signed-off-by: Bommu Krishnaiah
Co-developed-by: Nirmoy Das
Signed-off-by: Nirmoy Das
---
.../i915/gem
_i915_vma_move_to_active() can receive > 1 fence for
multiple batch buffer submission so make sure to
individualize fences before adding to dma_resv obj
v2: make sure to reserve fence slots before adding.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5614
Signed-off-by: Nirmoy
to reserve enough fence slots before adding.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5614
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/i915_vma.c | 47 +++--
1 file changed, 27 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/i
v3: dma_resv_reserve_fences is not cumulative so pass num_fences.
v2: make sure to reserve enough fence slots before adding.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5614
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/i915_vma.c | 47 +++--
1 file changed,
ues/5614
Signed-off-by: Nirmoy Das
---
.../gpu/drm/i915/gem/i915_gem_execbuffer.c| 10 +++-
drivers/gpu/drm/i915/i915_vma.c | 47 +++
2 files changed, 36 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
b/drivers/gpu/drm/i
ses: https://gitlab.freedesktop.org/drm/intel/-/issues/5614
Signed-off-by: Nirmoy Das
---
.../gpu/drm/i915/gem/i915_gem_execbuffer.c| 3 +-
drivers/gpu/drm/i915/i915_vma.c | 47 +++
2 files changed, 29 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/i
nce slots before adding.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5614
Signed-off-by: Nirmoy Das
---
.../gpu/drm/i915/gem/i915_gem_execbuffer.c| 3 +-
drivers/gpu/drm/i915/i915_vma.c | 48 +++
2 files changed, 30 insertions(+), 21 deletions(-)
d
Make sure to allocate ahnd so that spinner starts with no-reloc
execbuf otherwise this will fail on platforms with relocation disabled.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6117
Signed-off-by: Nirmoy Das
---
tests/i915/gem_exec_balancer.c | 3 +++
1 file changed, 3
userspace.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4936
Signed-off-by: Chris Wilson
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
b/drivers/gpu
PCI bar resize only works with 64 bit BAR so disable
this on 32-bit machine.
Fixes: a91d1a17cd341 ("drm/i915: Add support for LMEM PCIe resizable bar")
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 4
1 file changed, 4 insertions(+)
diff --git a/d
userspace.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4936
Signed-off-by: Chris Wilson
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
b/drivers/gpu
From: Chris Wilson
The obj->base.resv may be shared across many objects, some of which may
still be live and locked, preventing objects from being freed
indefintely. We could individualise the lock during the free, or rely on
a freed object having no contention and being able to immediately free
onal Testing
Acked-by: Matthew Auld
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
index 6e90032e12e9..aa6aed837194
userspace.
v2: Add NOWARN in few more places from where we might return
ENOMEM to userspace.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4936
Signed-off-by: Chris Wilson
Co-developed-by: Nirmoy Das
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6
Run CI for these two patches for:
https://gitlab.freedesktop.org/drm/intel/-/issues/5701
Nirmoy Das (1):
ALSA: hda: handle UAF at probe error
Takashi Iwai (1):
ALSA: core: Add snd_card_free_on_error() helper
include/sound/core.h | 1 +
sound/core/init.c | 28
From: Takashi Iwai
This is a small helper function to handle the error path more easily
when an error happens during the probe for the device with the
device-managed card. Since devres releases in the reverser order of
the creations, usually snd_card_free() gets called at the last in the
probe e
Call snd_card_free_on_error() on probe error instead of
calling snd_card_free() which should handle devres call orders.
Issues: https://gitlab.freedesktop.org/drm/intel/-/issues/5701
Fixes: e8ad415b7a55 ("ALSA: core: Add managed card creation")
Signed-off-by: Nirmoy Das
---
sou
Call snd_card_free_on_error() on probe error instead of
calling snd_card_free() which should handle devres call orders.
Issues: https://gitlab.freedesktop.org/drm/intel/-/issues/5701
Fixes: e8ad415b7a55 ("ALSA: core: Add managed card creation")
Signed-off-by: Nirmoy Das
---
sou
ris P Wilson
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
index 9aad84059d56..6f5d5c0909b4 100644
--- a/driver
tthew Auld
Suggested-by: Chris P Wilson
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
index 9aad840
ences: https://gitlab.freedesktop.org/drm/intel/-/issues/6529
Reviewed-by: Matthew Auld
Reviewed-by: Andrzej Hajda
Suggested-by: Chris P Wilson
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/driver
op.org/drm/intel/-/issues/6639
Fixes: 842d9346b2fd ("drm/i915: Individualize fences before adding to dma_resv
obj")
Signed-off-by: Nirmoy Das
Cc: # v5.16+
Cc: Matthew Auld
Cc: Andrzej Hajda
---
drivers/gpu/drm/i915/i915_vma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
di
i915_gem_drain_freed_objects() might not be enough to
free all the objects and RCU delayed work might get
scheduled after the i915 device struct gets freed.
Call i915_gem_drain_workqueue() to catch all RCU delayed work.
Suggested-by: Chris Wilson
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm
i915_gem_drain_workqueue() call i915_gem_drain_freed_objects()
so no need to call that again.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/i915_gem.c | 2 --
drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/gpu
0 and 2 insertions
took 40 and 44 msecs
[ 8112.847733] drm_mm: evict fragmented insert of 1 and 2 insertions
took 8 and 20 msecs
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/selftests/drm_mm_selftests.h | 1 +
drivers/gpu/drm/selftests/test-drm_mm.c | 73
2
by freeing every other node.
only test bottom-up and top-down for now.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/selftests/drm_mm_selftests.h | 1 +
drivers/gpu/drm/selftests/test-drm_mm.c | 124 +++
2 files changed, 125 insertions(+)
diff --git a/drivers/gpu/drm
by freeing every other node.
only test bottom-up and top-down for now.
v3:
fix incorrect mode check
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/selftests/drm_mm_selftests.h | 1 +
drivers/gpu/drm/selftests/test-drm_mm.c | 124 +++
2 files changed, 125 insertions(+)
diff
Hi Jouni,
On 5/29/2023 8:27 AM, Jouni Högander wrote:
Add getter/setter for i915_gem_object->frontbuffer and use it instead of
directly touching i915_gem_object->frontbuffer frontbuffer pointer.
Signed-off-by: Jouni Högander
---
.../gpu/drm/i915/display/intel_frontbuffer.c | 18 ++---
.../
Högander
Reviewed-by: Jani Nikula
Reviewed-by: Nirmoy Das
---
.../gpu/drm/i915/display/intel_frontbuffer.c | 18 +-
.../gpu/drm/i915/gem/i915_gem_object_types.h | 3 +++
2 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/display
r into i915_gem_object.h
Signed-off-by: Jouni Högander
Reviewed-by: Nirmoy Das
---
.../gpu/drm/i915/display/intel_frontbuffer.c | 20 ++
.../gpu/drm/i915/display/intel_frontbuffer.h | 27
drivers/gpu/drm/i915/gem/i915_gem_object.c| 4 +-
drivers/gpu/drm/i915/gem/i915_gem_object.h
: Jouni Högander
Reviewed-by: Jani Nikula
Reviewed-by: Nirmoy Das
---
.../gpu/drm/i915/display/intel_frontbuffer.c | 8 +---
drivers/gpu/drm/i915/i915_vma.c | 20 +++
drivers/gpu/drm/i915/i915_vma.h | 2 ++
3 files changed, 23 insertions
u/drm/i915/gt/intel_gt_types.h
b/drivers/gpu/drm/i915/gt/intel_gt_types.h
index f08c2556aa25..121a53f908d1 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_types.h
+++ b/drivers/gpu/drm/i915/gt/intel_gt_types.h
@@ -306,4 +306,6 @@ enum intel_gt_scratch_field {
INTEL_GT_SCRATCH_FIELD_COHERENTL3_WA = 256,
Hi Jouni,
On 6/14/2023 7:17 AM, Jouni Högander wrote:
We are preparing for Xe. Xe stolen memory handling differs from i915 so we
want to move stolen memory handling details into i915_gem_stolen.
Also add a common type for fbc compressed fb and use it from fbc code
instead of underlying type dir
On 8/1/2023 10:33 AM, Hogander, Jouni wrote:
On Tue, 2023-08-01 at 10:02 +0200, Nirmoy Das wrote:
Hi Jouni,
On 6/14/2023 7:17 AM, Jouni Högander wrote:
We are preparing for Xe. Xe stolen memory handling differs from
i915 so we
want to move stolen memory handling details into i915_gem_stolen
Hi Jouni,
On 8/2/2023 9:52 AM, Hogander, Jouni wrote:
On Wed, 2023-08-02 at 09:51 +0200, Nirmoy Das wrote:
On 8/1/2023 10:33 AM, Hogander, Jouni wrote:
On Tue, 2023-08-01 at 10:02 +0200, Nirmoy Das wrote:
Hi Jouni,
On 6/14/2023 7:17 AM, Jouni Högander wrote:
We are preparing for Xe. Xe
On 8/28/2023 8:34 AM, Tejas Upadhyay wrote:
Now this workaround is permanent workaround on MTL and DG2,
earlier we used to apply on MTL A0 step only.
VLK-45480
Please remove the internal VLK reference. Otherwise this is
Acked-by: Nirmoy Das
Fixes: d922b80b1010 ("drm/i915/gt
On 8/31/2023 7:40 PM, Matt Roper wrote:
On Thu, Aug 31, 2023 at 08:09:54AM -0700, Jonathan Cavitt wrote:
From: Nirmoy Das
Apply WABB blit for Wa_16018031267 / Wa_16018063123.
Additionally, update the lrc selftest to exercise the new
WABB changes.
Co-developed-by: Nirmoy Das
Drive-by
mit message(Andi)
v3: use revid as we want to target SOC stepping(Radhakrishna)
Cc: Matthew Auld
Cc: Andi Shyti
Cc: Daniele Ceraolo Spurio
Cc: Lucas De Marchi
Cc: Radhakrishna Sripada
Signed-off-by: Nirmoy Das
Reviewed-by: Andi Shyti
---
drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 8
From: Fei Yang
On MTL, LLC is not shared between GT and CPU, set has_llc=0.
Signed-off-by: Fei Yang
Reviewed-by: Andi Shyti
Reviewed-by: Andrzej Hajda
Reviewed-by: Nirmoy Das
---
drivers/gpu/drm/i915/i915_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915
MTL.
BSpec: 45101
Signed-off-by: Fei Yang
Reviewed-by: Andi Shyti
Acked-by: Nirmoy Das
Reviewed-by: Andrzej Hajda
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gem/i915_gem_pages.c | 5 -
drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 13 +
drivers/gpu/drm/i915/gt/uc
coded to return WC for MTL.
v2: Simplify the commit message(Matt).
BSpec: 45101
Signed-off-by: Fei Yang
Reviewed-by: Andi Shyti
Acked-by: Nirmoy Das
Reviewed-by: Andrzej Hajda
Reviewed-by: Matt Roper
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gem/i915_gem_pages.c | 5 -
drivers
Implement a way to update GGTT using MI_UPDATE_GTT command
when possible for MTL as a suggested work around for
a HW bug.
Chris Wilson (1):
drm/i915: Lift runtime-pm acquire callbacks out of intel_wakeref.mutex
Nirmoy Das (4):
drm/i915: Create a kernel context for GGTT updates
drm/i915
the mutex, is that it will reduce
contention for frequent sleeps and wakes (such as when being used
for soft-rc6).
Signed-off-by: Chris Wilson
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/intel_wakeref.c | 43 ++--
1 file changed, 21 insertions(+), 22 deletions
Create a separate kernel context if a platform requires
GGTT updates using MI_UPDATE_GTT blitter command.
Subsequent patch will introduce methods to update
GGTT using this bind context and MI_UPDATE_GTT blitter
command.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/intel_engine.h
Implement a way to iterate over sgt with pre-initialized
sgt_iter state.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/i915_scatterlist.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_scatterlist.h
b/drivers/gpu/drm/i915/i915_scatterlist.h
index
lock.
Signed-off-by: Nirmoy Das
Signed-off-by: Oak Zeng
---
drivers/gpu/drm/i915/gt/intel_ggtt.c | 235 +++
drivers/gpu/drm/i915/gt/intel_gtt.h | 3 +
2 files changed, 238 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c
b/drivers/gpu/drm/i915/gt
runtime suspend and re-enable
after runtime resume.
v3: Remove above as we check if the GT is awake.
Signed-off-by: Nirmoy Das
Signed-off-by: Oak Zeng
---
drivers/gpu/drm/i915/gt/intel_gtt.c | 3 ++-
drivers/gpu/drm/i915/i915_driver.c | 5 +
2 files changed, 7 insertions(+), 1 deletion
On 9/5/2023 9:36 PM, Andi Shyti wrote:
In preparation for multi-gt cache flushing debugfs interface,
split the cache dropping function and gt idling.
Based on a patch by Tvrtko.
Signed-off-by: Andi Shyti
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 32 +
On 9/7/2023 2:58 PM, Andi Shyti wrote:
From: Tvrtko Ursulin
Walk all GTs when doing the respective bits of drop_caches work.
Signed-off-by: Tvrtko Ursulin
Signed-off-by: Andi Shyti
Reviewed-by: Nirmoy Das
---
Hi,
I'm proposing this new version of the series I sent here[*].
Pa
On 9/12/2023 9:35 AM, Andrzej Hajda wrote:
Some DG2 firmware locks this register for modification. Using wa_add
with read_mask 0 allows to skip checks of such registers.
Signed-off-by: Andrzej Hajda
Reviewed-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 +--
1
On 9/7/2023 3:41 PM, Andi Shyti wrote:
Hi Nirmoy,
[...]
+ /* mark the bind context's availability status */
+ bool bind_context_ready;
Do we need some locking here?
bind_context_ready is changed in suspend/resume or after mod probe so no need to
worry about locking here.
On 9/7/2023 3:48 PM, Andi Shyti wrote:
Hi Nirmoy,
On Wed, Sep 06, 2023 at 01:31:20PM +0200, Nirmoy Das wrote:
Implement GGTT update method with blitter command, MI_UPDATE_GTT
and install those handlers if a platform requires that.
v2: Make sure we hold the GT wakeref and Blitter engine
-with: 20230913094252.6246-1-nirmoy@intel.com
Chris Wilson (1):
drm/i915: Lift runtime-pm acquire callbacks out of intel_wakeref.mutex
Nirmoy Das (6):
drm/i915: Create a kernel context for GGTT updates
drm/i915: Implement for_each_sgt_daddr_next
drm/i915: Parameterize binder context
-with: 20230913094252.6246-1-nirmoy@intel.com
Chris Wilson (1):
drm/i915: Lift runtime-pm acquire callbacks out of intel_wakeref.mutex
Nirmoy Das (6):
drm/i915: Create a kernel context for GGTT updates
drm/i915: Implement for_each_sgt_daddr_next
drm/i915: Parameterize binder context
mutex, is that it will reduce
contention for frequent sleeps and wakes (such as when being used
for soft-rc6).
Signed-off-by: Chris Wilson
Signed-off-by: Nirmoy Das
Reviewed-by: Andi Shyti
---
drivers/gpu/drm/i915/intel_wakeref.c | 43 ++--
1 file changed, 21 insertions
Implement a way to iterate over sgt with pre-initialized
sgt_iter state.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/intel_gtt.h | 3 +++
drivers/gpu/drm/i915/i915_scatterlist.h | 10 ++
2 files changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.h
Add i915_ggtt_require_binder() to indicate that i915
needs to create binder context which will be used
by subsequent patch to enable i915_address_space vfuncs
that will use GPU commands to update GGTT.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
drivers/gpu
-enablement
post-resume. This is acceptable as those transition periods are
mostly single threaded.
Signed-off-by: Nirmoy Das
Signed-off-by: Oak Zeng
---
drivers/gpu/drm/i915/i915_driver.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_driver.c
b/drivers/gpu/drm
lock.
Signed-off-by: Nirmoy Das
Signed-off-by: Oak Zeng
---
drivers/gpu/drm/i915/gt/intel_ggtt.c | 235 +++
1 file changed, 235 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c
b/drivers/gpu/drm/i915/gt/intel_ggtt.c
index dd0ed941441a..b94de7cebfce 100644
MTL can hang because of a HW bug while parallel reading/writing
from/to LMEM/GTTMMADR BAR so try to reduce GGTT update
related pci transactions with blitter command as recommended
for Wa_13010847436 and Wa_14019519902.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/intel_gtt.c | 3 ++-
1
Create a separate kernel context if a platform requires
GGTT updates using MI_UPDATE_GTT blitter command.
Subsequent patch will introduce methods to update
GGTT using this bind context and MI_UPDATE_GTT blitter
command.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/intel_engine.h
MI_UPDATE_GTT blitter
command.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/intel_engine.h | 2 ++
drivers/gpu/drm/i915/gt/intel_engine_cs.c| 33 +++-
drivers/gpu/drm/i915/gt/intel_engine_types.h | 3 ++
drivers/gpu/drm/i915/gt/intel_gt.c | 18
ce leak(Oak)
Test-with: 20230914201809.1804-1-nirmoy@intel.com
Chris Wilson (1):
drm/i915: Lift runtime-pm acquire callbacks out of intel_wakeref.mutex
Nirmoy Das (6):
drm/i915: Create a kernel context for GGTT updates
drm/i915: Implement for_each_sgt_daddr_next
drm/i915
mutex, is that it will reduce
contention for frequent sleeps and wakes (such as when being used
for soft-rc6).
Signed-off-by: Chris Wilson
Signed-off-by: Nirmoy Das
Reviewed-by: Andi Shyti
---
drivers/gpu/drm/i915/intel_wakeref.c | 43 ++--
1 file changed, 21 insertions
Create a separate kernel context if a platform requires
GGTT updates using MI_UPDATE_GTT blitter command.
Subsequent patch will introduce methods to update
GGTT using this bind context and MI_UPDATE_GTT blitter
command.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gt/intel_engine.h
Add i915_ggtt_require_binder() to indicate that i915
needs to create binder context which will be used
by subsequent patch to enable i915_address_space vfuncs
that will use GPU commands to update GGTT.
Signed-off-by: Nirmoy Das
Reviewed-by: Oak Zeng
---
drivers/gpu/drm/i915/gt
-enablement
post-resume. This is acceptable as those transition periods are
mostly single threaded.
Signed-off-by: Nirmoy Das
Signed-off-by: Oak Zeng
---
drivers/gpu/drm/i915/i915_driver.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_driver.c
b/drivers/gpu/drm
lock.
Signed-off-by: Nirmoy Das
Signed-off-by: Oak Zeng
---
drivers/gpu/drm/i915/gt/intel_ggtt.c | 235 +++
1 file changed, 235 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c
b/drivers/gpu/drm/i915/gt/intel_ggtt.c
index dd0ed941441a..b94de7cebfce 100644
Implement a way to iterate over sgt with pre-initialized
sgt_iter state.
Signed-off-by: Nirmoy Das
Reviewed-by: Oak Zeng
---
drivers/gpu/drm/i915/gt/intel_gtt.h | 3 +++
drivers/gpu/drm/i915/i915_scatterlist.h | 10 ++
2 files changed, 13 insertions(+)
diff --git a/drivers/gpu
MTL can hang because of a HW bug while parallel reading/writing
from/to LMEM/GTTMMADR BAR so try to reduce GGTT update
related pci transactions with blitter command as recommended
for Wa_13010847436 and Wa_14019519902.
Signed-off-by: Nirmoy Das
Reviewed-by: Oak Zeng
---
drivers/gpu/drm/i915/gt
On 9/15/2023 11:50 AM, Jani Nikula wrote:
On Fri, 15 Sep 2023, Nirmoy Das wrote:
Toggle binder context ready status when needed.
To issue gpu commands, the driver must be primed to receive
requests. Maintain binder-based GGTT update disablement until driver
probing completes. Moreover
circular lock. So hold the GT/blitter engine wakeref
before calling mutex_lock, to fix the circular lock.
Signed-off-by: Nirmoy Das
Signed-off-by: Oak Zeng
---
drivers/gpu/drm/i915/gt/intel_ggtt.c | 235 +++
1 file changed, 235 insertions(+)
diff --git a/drivers/gpu/drm/i915
ce leak(Oak)
v5: rebase & resend with new "Test-with"
Test-with: 20230918164747.30171-1-nirmoy@intel.com
Chris Wilson (1):
drm/i915: Lift runtime-pm acquire callbacks out of intel_wakeref.mutex
Nirmoy Das (6):
drm/i915: Create a kernel context for GGTT updates
drm/i
mutex, is that it will reduce
contention for frequent sleeps and wakes (such as when being used
for soft-rc6).
Signed-off-by: Chris Wilson
Signed-off-by: Nirmoy Das
Reviewed-by: Andi Shyti
---
drivers/gpu/drm/i915/intel_wakeref.c | 43 ++--
1 file changed, 21 insertions
Create a separate kernel context if a platform requires
GGTT updates using MI_UPDATE_GTT blitter command.
Subsequent patch will introduce methods to update
GGTT using this bind context and MI_UPDATE_GTT blitter
command.
Signed-off-by: Nirmoy Das
Reviewed-by: Oak Zeng
---
drivers/gpu/drm/i915
Implement a way to iterate over sgt with pre-initialized
sgt_iter state.
Signed-off-by: Nirmoy Das
Reviewed-by: Oak Zeng
---
drivers/gpu/drm/i915/gt/intel_gtt.h | 3 +++
drivers/gpu/drm/i915/i915_scatterlist.h | 10 ++
2 files changed, 13 insertions(+)
diff --git a/drivers/gpu
-enablement
post-resume. This is acceptable as those transition periods are
mostly single threaded.
Signed-off-by: Nirmoy Das
Signed-off-by: Oak Zeng
---
drivers/gpu/drm/i915/i915_driver.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_driver.c
b/drivers/gpu/drm
1 - 100 of 438 matches
Mail list logo
