Remove dependency for I915_MAX_PIPES by replacing it with
for_each_pipe() macro.
v2: use 'enum pipe pipe' instead of 'i'
Reviewed-by: Ville Syrjälä
Signed-off-by: Ramalingam C
Signed-off-by: Mika Kahola
---
drivers/gpu/drm/i915/intel_display.c | 5 -
drivers/gpu/
Fold IRQ pipe masks into one loop instead of hardcoding per pipe.
Reviewed-by: Ville Syrjälä
Signed-off-by: Mika Kahola
---
drivers/gpu/drm/i915/i915_irq.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915
Favor for_each_pipe() macro when looping through pipes.
v2: use 'enum pipe pipe' instead of 'i'
Reviewed-by: Ville Syrjälä
Signed-off-by: Mika Kahola
---
drivers/gpu/drm/i915/intel_pipe_crc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/
On Wed, 2017-10-11 at 15:43 +0300, Ville Syrjälä wrote:
> On Mon, Oct 09, 2017 at 03:26:07PM +0300, Mika Kahola wrote:
> >
> > For Cannonlake the number of scalers for each pipe is 2. Let's
> > increase
> > the number of scalers for pipe C.
>
pipes' variable which caches
the maximum number of available pipes.
Reference: https://bugs.freedesktop.org/show_bug.cgi?id=103206
Signed-off-by: Mika Kahola
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/intel_audio.c | 2 +-
drivers/gpu/drm/i915/intel_device_
Favor for_each_pipe() macro when looping through pipes.
This patch is related to miscellenous fixes to reduce dependency on
I915_MAX_PIPES.
https://patchwork.freedesktop.org/series/30336/
Signed-off-by: Mika Kahola
---
drivers/gpu/drm/i915/intel_dp_mst.c | 14 --
1 file changed, 8
On Thu, 2017-10-12 at 09:55 +0300, Jani Nikula wrote:
> On Thu, 12 Oct 2017, Mika Kahola wrote:
> >
> > CI system spotted an error on CFL system when running IGT tests
> > with
> > display disabled. In this case, the 'INTEL_INFO(dev_priv)-
> > >num_pipes&
On Wed, 2017-10-18 at 23:48 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Redo some switch statements in the cdclk code to use a common
> fall through for the default case. Makes everything look a bit
> more uniform
>
> Cc: Mika Kahola
> Cc: Manasi Navare
>
IXED(i,f) ((i) << 16 | (f))
>
> -/**
> - * igt_atomic_populate_plane_req:
> - * @req: A pointer to drmModeAtomicReq
> - * @plane: A pointer igt_plane_t
> - * @prop: one of igt_atomic_plane_properties
> - * @value: the value to add
> - */
> -#defi
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> In the future I want to allow tests to commit more properties,
> but for this to work I have to fix all properties to work better
> with atomic commit. Instead of special casing each
> property ma
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> Blacklist some explicit atomic properties. We could theoretically set
> them but that's not what the legacy path is for. :)
>
> When adding new properties, this means we could test those thr
tage(dev_priv);
> > }
> >
> > static void cnl_cdclk_pll_disable(struct drm_i915_private
> > *dev_priv)
> > @@ -1594,8 +1600,7 @@ static void cnl_set_cdclk(struct
> > drm_i915_private *dev_priv,
> >
> > intel_update_cdclk(dev_priv);
> >
> > + dev_pri
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> With the replace_prop_blob functions we can safely replace the blob
> for
> any property, without having to care about error handling ourselves.
>
> This will for example allow overriding c
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> Setting broadcast rgb was only used by chamelium, but is now handled
> in igt_display by default. This means that chamelium doesn't need to
> set it, and this can be hidden. The broadcast RGB pro
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 17:33 +0200, Maarten Lankhorst wrote:
> This allows test to test whether a property is supported, in
> a nice and clean way. It removes the need for special case
> functions like igt_plane_supports_rotation.
>
> Conve
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> Some tests need to get the current kernel value for properties
> as part of the test. Add get_prop functions that will retrieve
> the current kernel value.
>
> Signed-off-by: Maarten Lankhors
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> igt_pipe_get_property has been replaced by igt_pipe_obj_get_prop.
>
> Signed-off-by: Maarten Lankhorst
> ---
> lib/igt_kms.c | 10 --
> lib/igt_kms.h | 3 ---
> 2 files
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> This can be handled by generic properties.
>
> Signed-off-by: Maarten Lankhorst
> ---
> lib/igt_kms.c | 21 -
> lib/igt_kms.h
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> IGT has an api that can find a matching pipe for a given connector,
> so use that.
>
> igt_output_override_mode already forces a modeset on an affected pipe
> since an earlier commit, so the
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> igt_pipe_get_property is about to be removed, so use
> igt_pipe_obj_get_prop instead. This requires adding 2 more properties
> to the crtc property list. Also get rid of the Broadcast RGB call,
On Thu, 2017-10-19 at 11:44 +0200, Maarten Lankhorst wrote:
> Op 19-10-17 om 11:08 schreef Mika Kahola:
> >
> > On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> > >
> > > In the future I want to allow tests to commit more properties,
> > &
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> Everything except CRTC_ID can be set in the legacy paths,
> we even have 2, the legacy and universal path. Excercise both. :D
>
> Signed-off-by: Maarten Lankhorst
> ---
>
On Thu, 2017-10-12 at 17:33 +0200, Maarten Lankhorst wrote:
> Now that we can set individual properties through the igt_kms api,
> we no longer need to duplicate functionality from igt_kms. Set
> invalid
> properties directly, and rewrite kms_atomic.c to use igt_display.
> This will allow us to rem
Reviewed-by: Mika Kahola
On Thu, 2017-10-19 at 13:15 +0200, Maarten Lankhorst wrote:
> igt_pipe_refresh was added for the forked helper, we could just call
> it
> from the fork to prevent races against MODE_ID.
>
> The static 1024x768 mode is allocated on the stack and returne
On Fri, 2017-10-20 at 12:08 +0200, Maarten Lankhorst wrote:
> Op 20-10-17 om 12:02 schreef Mika Kahola:
> >
> > On Thu, 2017-10-12 at 17:33 +0200, Maarten Lankhorst wrote:
> > >
> > > Now that we can set individual properties through the igt_kms
> > >
Reviewed-by: Mika Kahola
On Fri, 2017-10-13 at 16:58 +0200, Maarten Lankhorst wrote:
> kmstest_get_crtc was skipping because at that point the crtc was not
> active yet, instead we should only use igt_assert_plane_visible
> directly. Unexport kmstest_get_crtc, since nothing here should
sed or unused pipes")
> Fixes: 0b7029b7e43f ("drm/i915: Check for fused or unused pipes")
> Cc: # v4.10+
> Cc: Mika Kahola
> Cc: Rodrigo Vivi
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: intel-gfx@lists.freedesktop.org
Reviewed-by: Mika Kahola
> Signed-
t; > > Daniel Vetter
> > > Sent: Monday, July 31, 2017 11:13 AM
> > > To: Kahola, Mika
> > > Cc: intel-gfx
> > > Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple:
> > > Fix reference
> > > CRC
> > >
On Wed, 2017-08-02 at 14:16 +0200, Daniel Vetter wrote:
> On Wed, Aug 2, 2017 at 2:06 PM, Mika Kahola
> wrote:
> >
> > On Wed, 2017-08-02 at 13:36 +0200, Daniel Vetter wrote:
> > >
> > > On Mon, Jul 31, 2017 at
On Wed, 2017-08-02 at 15:42 +0300, Petri Latvala wrote:
> After a bit of digging into this n_words conundrum that I also could
> not understand, I found the issue Mika described.
>
> kms_plane_multiple et al basically do
>
> igt_crc_t crc;
>
>
> and then they pass &crc to test-internal helper f
system and at least affects on HSW platform.
V2: Don't change function that collects CRC for reference CRC
Fix CRC pointers
Remove unnecessary struct for holding test data
Signed-off-by: Mika Kahola
---
tests/kms_plane_multiple.c | 25 +
1 file chang
y struct for test data as we only need
> > reference CRC here.
> >
> > The problem was caught by CI system and at least affects on HSW
> > platform.
> >
> > V2: Don't change function that collects CRC for reference CRC
> > Fix CRC pointers
> >
.h b/lib/igt_aux.h
> index 499a16796ebb..7e080089dcbc 100644
> --- a/lib/igt_aux.h
> +++ b/lib/igt_aux.h
> @@ -55,6 +55,8 @@ extern int num_trash_bos;
> /* generally useful helpers */
> void igt_fork_signal_helper(void);
> void igt_stop_signal_helper(void);
> +int6
run_plane_test(&display, pipe, output,
> test_setplane, DRM_PLANE_TYPE_CURSOR, COMMIT_LEGACY);
> + break;
> + }
> +
> + igt_subtest("universal-setplane-primary")
> + for_each_pipe_with_valid_output(&display, pipe,
> output) {
> + run_plane_test(&display, pipe, output,
> test_setplane, DRM_PLANE_TYPE_PRIMARY, COMMIT_UNIVERSAL);
> + break;
> + }
> +
> + igt_subtest("universal-setplane-cursor")
> + for_each_pipe_with_valid_output(&display, pipe,
> output) {
> + run_plane_test(&display, pipe, output,
> test_setplane, DRM_PLANE_TYPE_CURSOR, COMMIT_UNIVERSAL);
> + break;
> + }
> +
> + /* TODO: DPMS, gamma_set, setprop, getprop */
> + igt_fixture {
> + igt_display_fini(&display);
> + }
> +}
Otherwise looks good to me.
--
Mika Kahola - Intel OTC
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
}
>
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 35428f3e9675..d18a92600933 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -323,7 +323,6 @@ typedef struct {
> struct igt_pipe {
> igt_display_t *display;
> enum pipe pipe;
> - bool enabled;
>
> int n_planes;
> int plane_cursor;
--
Mika Kahola - Intel OTC
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Mon, 2017-08-07 at 10:42 +0200, Maarten Lankhorst wrote:
> Op 04-08-17 om 10:07 schreef Mika Kahola:
> >
> > On Wed, 2017-08-02 at 12:29 +0200, Maarten Lankhorst wrote:
> > >
> > > With the conversion to atomic, this is already handled in the
> > >
equencies over 5.4 GHz only supported on certain DDI ports and SKUs"
The only difference between SKUs that I spotted was related to DDI D
port speeds. If BSpec is correct, then we should somehow separate the
max port speeds for DDI D port.
>
> v2: Rebase on top of source_rates changes.
&g
On Thu, 2017-07-06 at 13:54 -0700, Rodrigo Vivi wrote:
> Different from SKL we don't need ctrl1 and cfgcr2, but
> we need to dump cfgcr0 amd cfgcr1 instead.
With minor typo fixed in commit message, this is
Reviewed-by: Mika Kahola
>
> v2: rebase and commit message
>
>
Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01)
Tested-by: Mika Kahola
On Thu, 2017-08-17 at 13:55 +0300, Andy Shevchenko wrote:
> The commit 213e08ad60ba
> ("drm/i915/bxt: add bxt dsi gpio element support")
> enables GPIO support for Broxton based platform
r Cannonlake.
> This patch only removes unecessary steps probably saving
> us from some useless warnings.
>
> Cc: Clint Taylor
> Cc: Mika Kahola
> Signed-off-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 dele
On Thu, 2017-08-17 at 14:06 +0300, Mika Kahola wrote:
> Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01)
Tested also with APL + MIPI/DSI setup.
>
> Tested-by: Mika Kahola
>
> On Thu, 2017-08-17 at 13:55 +0300, Andy Shevchenko wrote:
> >
> > The commit 213e
In my view, this is a valid check.
Reviewed-by: Mika Kahola
On Tue, 2017-08-29 at 13:32 +0300, Marta Lofstedt wrote:
> Check for valid crtc is missing in igt@kms_atomic@atomic_invalid_para
> ms.
> This leads to segfault on machines where the subtest should be
> skipped.
>
versions 3 or higher.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102404
Signed-off-by: Mika Kahola
---
drivers/gpu/drm/i915/intel_dsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index 2a0f5d
Error message indicating that the same MIPI command is sent consecutively
is perhaps too strongly said. Let's replace that as a debug message instead.
Signed-off-by: Mika Kahola
---
drivers/gpu/drm/i915/intel_dsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driver
02404
Mika Kahola (2):
drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's
drm/i915/dsi: Replace MIPI command error message with debug message
drivers/gpu/drm/i915/intel_dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.7.4
___
On Fri, 2017-09-01 at 16:43 +0300, Ville Syrjälä wrote:
> On Fri, Sep 01, 2017 at 10:51:00AM +0300, Mika Kahola wrote:
> >
> > According to spec we should send SHUTDOWN before
> > MIPI_SEQ_DISPLAY_OFF for
> > v3+ VBT's. Testing with VBT v3 the current implementat
On Mon, 2017-09-04 at 18:04 +0300, Ville Syrjälä wrote:
> On Mon, Sep 04, 2017 at 10:59:32AM +0300, Mika Kahola wrote:
> >
> > On Fri, 2017-09-01 at 16:43 +0300, Ville Syrjälä wrote:
> > >
> > > On Fri, Sep 01, 2017 at 10:51:00AM +0300, Mika Kahola wrote:
>
The revert patch solved the issue
*ERROR* Video mode command 0x0041 send failed.
on my setup with APL+MIPI/DSI single link combo.
Tested-by: Mika Kahola
On Tue, 2017-09-05 at 15:14 +0530, Vidya Srinivas wrote:
> From: Uma Shankar
>
> This rever
https://bugs.freedesktop.org/show_bug.cgi?id=102403
Signed-off-by: Mika Kahola
---
drivers/gpu/drm/i915/intel_sprite.c | 32 +---
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_sprite.c
b/drivers/gpu/drm/i915/intel_sprite.c
index b0d6e3e..85
On Tue, 2017-09-05 at 18:11 +0200, Daniel Vetter wrote:
> On Tue, Sep 05, 2017 at 04:35:04PM +0300, Mika Kahola wrote:
> >
> > It appears that we cannot trust scanline counters when MIPI/DSI
> > display is
> > connected. In CI system this appears as flickering errors t
On Thu, 2017-09-07 at 13:29 +0200, Maarten Lankhorst wrote:
> Op 05-09-17 om 15:35 schreef Mika Kahola:
> >
> > It appears that we cannot trust scanline counters when MIPI/DSI
> > display is
> > connected. In CI system this appears as flickering errors that
> >
On Thu, 2018-01-11 at 11:27 +0200, Petri Latvala wrote:
> Fixes: 834321a5d76a ("tools: Cannonlake port clock programming")
Reviewed-by: Mika Kahola
> Signed-off-by: Petri Latvala
> Cc: Mika Kahola
> ---
> tools/.gitignore | 1 +
> 1 file changed, 1 insertio
ommits the same on display.
>
> Changes since v1:
> - Make the test more generic and try on all planes, including legacy
> cursor.
>
Reviewed-by: Mika Kahola
> Signed-off-by: Mahesh Kumar
> Signed-off-by: Jyoti Yadav
> Signed-off-by: Vidya Srinivas
> Signed-off-by:
On Fri, 2018-01-12 at 11:21 +0100, Maarten Lankhorst wrote:
> We will add more subtests in the future, it's more clear if we split
> out the actual test to its own function first.
>
Reviewed-by: Mika Kahola
> Signed-off-by: Maarten Lankhorst
> ---
> tests/km
the
> image to avoid "Max pixel rate limitation" of the hardware.
>
> Later patches in this series will cover corner cases of
> scaling.
>
> Changes since v1:
> - Move out the code reshuffle to a separate commit. (Maarten)
> This makes it more clear what's f
On Fri, 2018-01-12 at 11:21 +0100, Maarten Lankhorst wrote:
> Convert the test to run subtests per pipe, before we start adding
> more subtests.
>
Reviewed-by: Mika Kahola
> Signed-off-by: Maarten Lankhorst
> ---
> tests/kms_pl
On Fri, 2018-01-12 at 11:21 +0100, Maarten Lankhorst wrote:
> The next patch wants to call for_each_pipe_with_valid_output
> with *pipe and *output, this fails miserably without these braces.
>
Reviewed-by: Mika Kahola
> Signed-off-by: Maarten Lankhorst
> ---
>
utput_on_pipe(&data.dis
> play, pipe);
>
> + igt_require(get_num_scalers(data.devid,
> pipe) > 0);
> + }
> +
> igt_subtest_f("pipe-%s-plane-scaling",
> kmstest_pipe_name(pipe))
> for_each_valid_
se failures in other
> subtests.
>
> Changes since v1:
> - Rebase on top of num_scalers changes.
>
Reviewed-by: Mika Kahola
> Signed-off-by: Maarten Lankhorst
> ---
> tests/kms_plane_scaling.c | 235 +++-
> --
> 1 file changed,
; Changes since v2:
> - Use get_num_scalers() to skip when needed.
>
Reviewed-by: Mika Kahola
> Signed-off-by: Jyoti Yadav
> Signed-off-by: Mahesh Kumar
> Signed-off-by: Vidya Srinivas
> Signed-off-by: Maarten Lankhorst
> ---
> tests/kms_plane_scaling.c | 43
> +++
On Tue, 2018-01-16 at 11:03 +0100, Maarten Lankhorst wrote:
> The number of scalers can depend on the pipe, so require at least 1
> scaler before running any subtests.
>
> Changes since v1:
> - More closely match kernel implementation. (Mika)
>
Reviewed-by: Mika Kahola
ling on plane2 */
> static void iterate_plane_scaling(data_t *d, drmModeModeInfo *mode)
> {
> @@ -293,6 +443,15 @@ igt_main
> igt_subtest_f("pipe-%s-plane-scaling",
> kmstest_pipe_name(pipe))
> for_each_valid_output_on_pipe(&da
t; + igt_plane_set_size(d->plane1, mode1->hdisplay, mode1-
> >vdisplay);
> + igt_plane_set_size(d->plane3, mode2->hdisplay, mode2-
> >vdisplay);
> + igt_display_commit2(display, COMMIT_ATOMIC);
> +
> + /* Upscaling Sprites */
> + igt_plane_set_size(d->plane2 ?: d
On Tue, 2018-01-16 at 14:47 +0100, Maarten Lankhorst wrote:
> Op 16-01-18 om 14:46 schreef Mika Kahola:
> >
> > On Mon, 2018-01-15 at 15:28 +0100, Maarten Lankhorst wrote:
> > >
> > > From: Jyoti Yadav
> > >
> > > Add a subtest to display prim
display, mode->vdisplay);
> + igt_plane_set_rotation(plane, rot);
> + igt_display_commit2(display, COMMIT_ATOMIC);
> +
> + igt_plane_set_fb(plane, NULL);
> + igt_plane_set_position(plane, 0, 0);
> +}
> +
> +static const igt_rotation_t rotations[] = {
> + IGT_R
On Sun, 2018-01-21 at 03:15 +0530, Vidya Srinivas wrote:
> From: Mahesh Kumar
>
> Add support of recognizing DRM_FORMAT_NV12 from plane_format
> register value.
>
Reviewed-by: Mika Kahola
> Signed-off-by: Mahesh Kumar
> ---
> drivers/gpu/drm/i915/intel_display.c | 2
On Mon, 2018-01-22 at 17:33 +0530, Vidya Srinivas wrote:
> From: Mahesh Kumar
>
> Add support of recognizing DRM_FORMAT_NV12 from plane_format
> register value.
>
Reviewed-by: Mika Kahola
> Signed-off-by: Mahesh Kumar
> ---
> drivers/gpu/drm/i915/intel_display.c | 2
On Tue, 2018-01-30 at 22:38 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> WaDoubleCursorLP3Latency was meant for pre-production hardware.
> Drop it.
>
Reviewed-by: Mika Kahola
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 -
te 0 to these bits. Let's
> follow that recommendation. On ilk+ the bits become hardwired to 0.
>
> Also looks like ICL repurposes these bits for some other use, so
> we had better stop setting them to bogus values there.
>
Reviewed-by: Mika Kahola
> Signed-off-by: Vil
re register
> would read, should we want to cross check the two.
>
Reviewed-by: Mika Kahola
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_disp
/include/uapi/drm/drm_mode.h? Although, I
wasn't able to find these definitions from that file. Do we have a
patch under review in drm to fill this gap?
Otherwise, the patch looks good.
Acked-by: Mika Kahola
> /**
> * SECTION:igt_kms
> * @short_descrip
On Tue, 2018-02-13 at 15:22 +0530, Vidya Srinivas wrote:
> From: Mahesh Kumar
>
> Add support of recognizing DRM_FORMAT_NV12 from plane_format
> register value.
>
Reviewed-by: Mika Kahola
> Signed-off-by: Mahesh Kumar
> ---
> drivers/gpu/drm/i915/intel_display.c | 2
On Wed, 2017-03-08 at 13:38 +0100, Maarten Lankhorst wrote:
> Hey,
>
> Op 07-02-17 om 14:33 schreef Mika Kahola:
> >
> > When doing a full atomic modeset, kernel should fail if the flag
> > DRM_MODE_ATOMIC_ALLOW_MODESET is not set. Let's add this test as
&
On Wed, 2017-03-08 at 15:08 +0100, Maarten Lankhorst wrote:
> Op 17-02-17 om 14:39 schreef Mika Kahola:
> >
> > We need to make sure that TEST_ONLY really only touches the free-
> > standing
> > state objects and nothing else. Test approach here is the
> > foll
On Wed, 2017-03-08 at 16:44 +0200, Petri Latvala wrote:
> Unused since 99bdf4f0ff3e ("tests/testdisplay: Use cairo helpers to
> draw to plane")
>
> Signed-off-by: Petri Latvala
Reviewed-by: Mika Kahola
> ---
> tests/testdisplay.c | 1 -
> 1 file changed, 1 dele
none of that is clobbered
v2: use ATOMIC_RELAX_NONE instead of CRTC_RELAX_MODE when checking crtc or
plane state (Maarten)
rename subtest and function that executes this test (Maarten)
Signed-off-by: Mika Kahola
---
tests/kms_atomic.c | 82
On Wed, 2017-03-08 at 15:00 +0100, Maarten Lankhorst wrote:
> Op 23-02-17 om 14:26 schreef Mika Kahola:
> >
> > This test case introduces concurrently running test cases for
> > atomic
> > modesetting.
> >
> > The first test or thread draws blue backroun
On Wed, 2017-03-08 at 16:44 +0200, Petri Latvala wrote:
> Signed-off-by: Petri Latvala
Reviewed-by: Mika Kahola
> ---
> assembler/gen8_disasm.c | 5 -
> 1 file changed, 5 deletions(-)
>
> diff --git a/assembler/gen8_disasm.c b/assembler/gen8_disasm.c
> index 7f
so let's follow suit.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Mika Kahola
> ---
> drivers/gpu/drm/i915/i915_irq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c
> b/drivers/gpu/drm/i915/i915_irq
ad changes resolution from higher to lower one and back.
The delay between resolution changes is randomly selected between 20 and
50 milliseconds.
The test runs by default 32 iterations to increase the coverage.
v2: use igt_fork instead of pthreads to create concurrent test runs (Maarten)
Signed-of
On Wed, 2017-03-08 at 15:59 +0100, Maarten Lankhorst wrote:
> Op 01-02-17 om 14:18 schreef Mika Kahola:
> >
> > Add an option to force atomic commits to do commits with TEST_ONLY
> > flag
> > first before doing the actual commit.
> >
> > Signed-off-by:
selection in igt core
separate test cases for TEST_ONLY atomic commits (Maarten)
v4: Clear force_test_atomic flag if atomic commit fails (Maarten)
For: VIZ-6956
Mika Kahola (7):
lib/igt_kms: Add forcing TEST_ONLY for atomic commits
tests/kms_plane_multiple: Add TEST_ONLY flag Cc
Add TEST_ONLY flag to test atomic modesetting commits without
actual real-life commit.
Signed-off-by: Mika Kahola
---
tests/kms_plane_lowres.c | 40
1 file changed, 36 insertions(+), 4 deletions(-)
diff --git a/tests/kms_plane_lowres.c b/tests
Add TEST_ONLY flag to test atomic modesetting commits without
actual real-life commit.
Signed-off-by: Mika Kahola
---
tests/kms_rotation_crc.c | 139 +++
1 file changed, 139 insertions(+)
diff --git a/tests/kms_rotation_crc.c b/tests
Add TEST_ONLY flag to test atomic modesetting commits without
actual real-life commit.
v2: Use flag to indicate to test with TEST_ONLY flag with atomic
commit
v3: Moved force_test_atomic flag set to 'test_plane_position()'
Signed-off-by: Mika Kahola
---
tests/kms_plane_multi
Add TEST_ONLY flag to test atomic modesetting commits without
actual real-life commit.
v2: Use flag to indicate to test with TEST_ONLY flag with atomic
commit
v3: Moved force_test_atomic flag set to 'test_plane_position()'
Signed-off-by: Mika Kahola
---
tests/kms_plane_multi
Add TEST_ONLY flag to test atomic scaling without
actually committing the changes.
v2: Create subtests with TEST_ONLY flag and one without
v3: Rename subtest 'force-atomic-test' as 'with-atomic-test'
Signed-off-by: Mika Kahola
---
tests/kms_plane_scaling.c | 28 +++
Add an option to force atomic commits to do commits with TEST_ONLY flag
first before doing the actual commit.
v2: Clear force_test_atomic flag if atomic commit with TEST_ONLY
flag fails (Maarten)
Signed-off-by: Mika Kahola
---
lib/igt_kms.c | 22 +-
lib/igt_kms.h | 1
Add TEST_ONLY flag to test atomic transition display commits without
actual real-life commit.
v2: use flag to force atomic commit with TEST_ONLY flag
v3: Rebase
Signed-off-by: Mika Kahola
---
tests/kms_atomic_transition.c | 72 +++
1 file changed, 59
Add TEST_ONLY flag to test atomic modesetting commits without
actual real-life commit.
Signed-off-by: Mika Kahola
---
tests/kms_cursor_legacy.c | 230 --
1 file changed, 204 insertions(+), 26 deletions(-)
diff --git a/tests/kms_cursor_legacy.c b
Add TEST_ONLY flag to test atomic modesetting commits without
actual real-life commit.
v2: Use flag to indicate to test with TEST_ONLY flag with atomic
commit
v3: Moved force_test_atomic flag set to 'test_plane_position()'
v4: Fix typo in subject field
Signed-off-by: Mika Kahola
Hi Bob,
On Tue, 2016-12-20 at 09:53 -0800, Bob Paauwe wrote:
> On Tue, 13 Dec 2016 16:11:20 +0200
> Jani Nikula wrote:
>
> >
> > On Mon, 05 Dec 2016, Mika Kahola wrote:
> > >
> > > From: Jani Nikula
> > >
> > > Request the GPIO by i
Add TEST_ONLY flag to test atomic modesetting commits without
actual real-life commit.
Signed-off-by: Mika Kahola
---
tests/kms_plane_multiple.c | 79 --
1 file changed, 49 insertions(+), 30 deletions(-)
diff --git a/tests/kms_plane_multiple.c b
TEST_ONLY flag the real deal atomic commit
is executed and the outcome is verified.
For: VIZ-6956
Mika Kahola (5):
tests/kms_plane_multiple: Add TEST_ONLY flag
tests/kms_atomic_transition: Add TEST_ONLY flag
tests/kms_plane_scaling: Add TEST_ONLY flag
tests/kms_rotation_crc: Add TEST_ONLY flag
Add TEST_ONLY flag to test atomic transition display commits without
actual real-life commit.
Signed-off-by: Mika Kahola
---
tests/kms_rotation_crc.c | 282 +--
1 file changed, 222 insertions(+), 60 deletions(-)
diff --git a/tests/kms_rotation_crc.c
TEST_ONLY flag the real deal atomic commit
is executed and the outcome is verified.
The test runs by default for 64 iterations.
Signed-off-by: Mika Kahola
---
tests/Makefile.sources | 1 +
tests/kms_test_only.c | 455 +
2 files changed, 456 insertions
Add TEST_ONLY flag to test atomic scaling without
actually committing the changes.
Signed-off-by: Mika Kahola
---
tests/kms_plane_scaling.c | 152 --
1 file changed, 135 insertions(+), 17 deletions(-)
diff --git a/tests/kms_plane_scaling.c b/tests
Add TEST_ONLY flag to test atomic transition display commits without
actual real-life commit.
Signed-off-by: Mika Kahola
---
tests/kms_atomic_transition.c | 227 --
1 file changed, 152 insertions(+), 75 deletions(-)
diff --git a/tests
ert_plane_visibility() function
drop option for multiple test iterations (Daniel Vetter)
v4: switch 'for_each_connected_output()' to
'for_each_valid_output_on_pipe()' (Maarten)
Cc: Daniel Stone
Cc: Maarten Lankhorst
Signed-off-by: Mika Kahola
---
lib/igt_
Remove reference to drm/drm_edid.h and drm/drmP.h as these are no longer
required.
Signed-off-by: Mika Kahola
---
drivers/gpu/drm/i915/intel_display.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index ab72858
401 - 500 of 995 matches
Mail list logo
