[Intel-gfx] [PATCH CI run 1/3] drm/i915/bxt: add bxt dsi gpio element support

2016-11-17 Thread Mika Kahola
From: Jani Nikula Use a table similar to vlv to check for accepted gpio indexes. For now, add all, but this list should be trimmed down. Use managed gpio request, which will be automatically released when the driver is detached. Cc: Mika Kahola Signed-off-by: Jani Nikula --- drivers/gpu/drm

[Intel-gfx] [PATCH CI run 3/3] drm/i915: Adding the parsing logic for the i2c element

2016-11-17 Thread Mika Kahola
Mika - rebase Cc: Ville Syrjälä Signed-off-by: vkorjani Signed-off-by: Deepak M Signed-off-by: Jani Nikula Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 78 +- 1 file changed, 76 insertions(+), 2 deletions(-) diff --git a/drivers/gp

[Intel-gfx] [PATCH i-g-t v2] tests/kms_plane_lowres: Plane visibility after atomic modesets

2016-11-23 Thread Mika Kahola
ck if decent mode has not been found (Daniel) add tiling MODE_NONE (Daniel) Cc: Daniel Stone Signed-off-by: Mika Kahola --- lib/igt_kms.c| 93 +++ lib/igt_kms.h| 9 ++ tests/Makefile.sources | 1 + tests/kms_plane_lowres.c | 394

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix CRC based atomic correctness test

2016-11-29 Thread Mika Kahola
Fixes issues on kms_plane_multiple i-g-t test found when running CI tests v1: - don't use tiling for cursor plane (Ville) - for y/yf tiling check that the platform is at least GEN9 (Ville) Cc: Ville Syrjala Cc: Maarten Lankhorst Signed-off-by: Mika Kahola --- tests/kms_plane_multiple.

Re: [Intel-gfx] [PATCH alternative #1] drm/i915/bxt: add bxt dsi gpio element support

2016-12-01 Thread Mika Kahola
On Tue, 2016-11-15 at 14:08 +0200, Jani Nikula wrote: > Request the GPIO by index through the consumer API. For now, use a > quick > hack to store the already requested ones, simply because I have no > idea > whether this actually works or not, and I have no way to test it. >

[Intel-gfx] [PATCH v2] drm/i915/bxt: add bxt dsi gpio element support

2016-12-04 Thread Mika Kahola
r MIPI/DSI panel. (Mika) Signed-off-by: Jani Nikula Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 38 +- 1 file changed, 32 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gp

Re: [Intel-gfx] [PATCH] drm/i915: Parse panel BL controller from VBT

2016-12-07 Thread Mika Kahola
Tested-by: Mika Kahola On Wed, 2016-12-07 at 20:32 +0530, Vidya Srinivas wrote: > Currently the backlight controller is taken as 0. It needs to derive > value from the VBT. Adding the necessary changes. > > v2: Updated the commit header > > Signed-off-by: Uma Shankar >

[Intel-gfx] [PATCH 3/3] drm/i915: Hz to PWM for i965

2016-12-13 Thread Mika Kahola
Unify function structure as any other *_hz_to_pwm() functions are structured. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_panel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index

[Intel-gfx] [PATCH 1/3] drm/i915: Intel panel detection cleanup

2016-12-13 Thread Mika Kahola
Let's switch to use private dev_priv instead of dev when detecting intel panels. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c| 3 ++- drivers/gpu/drm/i915/intel_drv.h | 2 +- drivers/gpu/drm/i915/intel_lvds.c | 4 ++-- drivers/gpu/drm/i915/intel_panel.c | 4 +-

[Intel-gfx] [PATCH 2/3] drm/i915: Intel panel downclock cleanup

2016-12-13 Thread Mika Kahola
Let's switch to use dev_priv instead of dev when calling intel_find_panel_downclock() function. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c| 2 +- drivers/gpu/drm/i915/intel_drv.h | 2 +- drivers/gpu/drm/i915/intel_panel.c | 6 +++--- 3 files changed, 5 insertions(

[Intel-gfx] [PATCH 0/3] Various cleanups on intel_panel.c

2016-12-13 Thread Mika Kahola
Proposal for cleanup. Let's favor dev_priv instead of dev in intel_panel.c functions. Cleanup for HZ to PWM functions to unify the look and feel of these functions. Mika Kahola (3): drm/i915: Intel panel detection cleanup drm/i915: Intel panel downclock cleanup drm/i915: Hz to PWM for

[Intel-gfx] [PATCH i-g-t v3] tests/kms_plane_lowres: Plane visibility after atomic modesets

2016-12-16 Thread Mika Kahola
ert_plane_visibility() function drop option for multiple test iterations (Daniel Vetter) Cc: Daniel Stone Signed-off-by: Mika Kahola --- lib/igt_kms.c| 161 ++ lib/igt_kms.h| 23 tests/Makefile.sources

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Update CDCLK_FREQ register on BDW after changing cdclk frequency

2016-04-27 Thread Mika Kahola
Indeed, BSpec says that this register should be programmed by CD clock minus one. Reviewed-by: Mika Kahola On Tue, 2016-04-26 at 19:46 +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Update CDCLK_FREQ on BDW after changing the cdclk frequency. Not sure >

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Use cached cdclk value in i915_audio_component_get_cdclk_freq()

2016-04-27 Thread Mika Kahola
Looks reasonable. Reviewed-by: Mika Kahola On Tue, 2016-04-26 at 19:46 +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > No point in reading the cdclk out from the hardware every single time > since we have it cached already. Just return the cached value to

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix comments about GMBUSFREQ register

2016-04-27 Thread Mika Kahola
s/Programmng/Programming With this nitpick fixed, this is Reviewed-by: Mika Kahola On Tue, 2016-04-26 at 19:46 +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The comment about GMBUSFREQ is confused. The spec actually explains > the 4MHz thing perfectly by

[Intel-gfx] [PATCH 3/3] drm/i915: Check HDMI TMDS clock rate from DPCD

2016-05-03 Thread Mika Kahola
Read TMDS clock rate from DPCD for HDMI to filter out modes that might require higher TMDS clock rate than supported. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 3 +++ drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_hdmi.c | 7 --- 3 files changed

[Intel-gfx] [PATCH 2/3] drm: Add DP port types from DP 1.3 specification

2016-05-03 Thread Mika Kahola
DP specification 1.3 defines DP downstream ports for DP++ and wireless devices. Let's add these to port definitions. Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h

[Intel-gfx] [PATCH 0/3] drm/i915: DP branch devices

2016-05-03 Thread Mika Kahola
This series of patches reads either pixel rate or TMDS clock rate from DPCD. Pixel rate is defined for DP to VGA dongles and TMDS clock rate for others except wireless dongle. The mode that requires either higher pixel rate or TMDS clock rate are filtered out during the mode validity check. Mika

[Intel-gfx] [PATCH 1/3] drm/i915: Check pixel rate for DP to VGA dongle

2016-05-03 Thread Mika Kahola
rate divided by 8 in MP/s. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 34 ++ drivers/gpu/drm/i915/intel_drv.h | 9 + 2 files changed, 43 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c

Re: [Intel-gfx] [PATCH 2/3] drm: Add DP port types from DP 1.3 specification

2016-05-04 Thread Mika Kahola
On Tue, 2016-05-03 at 10:35 -0400, Ilia Mirkin wrote: > > On May 3, 2016 9:49 AM, "Mika Kahola" wrote: > > > > DP specification 1.3 defines DP downstream ports for > > DP++ and wireless devices. Let's add these to port > > definitions. > > >

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Check pixel rate for DP to VGA dongle

2016-05-10 Thread Mika Kahola
On Tue, 2016-05-03 at 16:28 +0200, Daniel Vetter wrote: > On Tue, May 03, 2016 at 04:23:34PM +0300, Ville Syrjälä wrote: > > On Tue, May 03, 2016 at 02:46:36PM +0300, Mika Kahola wrote: > > > Prep work to improve DP branch device handling. > > > > > > Filter o

[Intel-gfx] [PATCH v2 0/7] drm/i915: DP branch devices

2016-05-16 Thread Mika Kahola
defines max pixel rate for VGA dongles. This check is carried out during mode validation. Acronyms: DFPDownstream-Facing Port v2: DPCD register read outs moved to drm (Ville, Daniel) Mika Kahola (7): drm: Add missing DP downstream port types drm: Read DPCD receiver capability for DP to

[Intel-gfx] [PATCH v2 1/7] drm: Add missing DP downstream port types

2016-05-16 Thread Mika Kahola
Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 92d9a52..4049af9

[Intel-gfx] [PATCH v2 6/7] drm: Read DPCD receiver capability for DP to Wireless Converter

2016-05-16 Thread Mika Kahola
active Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 7 +++ include/drm/drm_dp_helper.h | 13 + 2 files changed, 20 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index f98e4be..2c91771 100644 --- a/drivers/gpu/drm

[Intel-gfx] [PATCH v2 2/7] drm: Read DPCD receiver capability for DP to VGA converter

2016-05-16 Thread Mika Kahola
Read from DPCD receiver capability field the max allowed pixel clock and bits per component for DP to VGA converter. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 46 drivers/gpu/drm/i915/intel_drv.h | 2 ++ include/drm

[Intel-gfx] [PATCH v2 4/7] drm: Read DPCD receiver capability for DP to HDMI converter

2016-05-16 Thread Mika Kahola
pass through - support for conversion from YCBCR444 to YCBCR422 - support for conversion from YCBCR444 to YCBCR420 Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 8 include/drm/drm_dp_helper.h | 19 +++ 2 files changed, 27 insertions(+) diff --git

[Intel-gfx] [PATCH v2 7/7] drm/i915: Check pixel rate for DP to VGA dongle

2016-05-16 Thread Mika Kahola
rate divided by 8 in MP/s. v2: DPCD read outs and computation moved to drm (Ville, Daniel) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 3633002

[Intel-gfx] [PATCH v2 3/7] drm: Read DPCD receiver capability for DP to DVI converter

2016-05-16 Thread Mika Kahola
Read from DPCD receiver capability field for the following features: - max TMDS clock rate - max bits per component - single or dual link support - high color depth support Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 5 + include/drm/drm_dp_helper.h | 14

[Intel-gfx] [PATCH v2 5/7] drm: Read DPCD receiver capability for DP++

2016-05-16 Thread Mika Kahola
Read from DPCD receiver capability field for the DP++ devices. The features are - max TMDS charachter clock - max bits per component - support for conversion from 3D frame sequential to frame pack Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 4 include/drm

[Intel-gfx] [PATCH v3 01/12] drm: Add missing DP downstream port types

2016-05-23 Thread Mika Kahola
Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 5a848e7..e384c7f

[Intel-gfx] [PATCH v3 02/12] drm: Read DPCD receiver capability for DP to VGA converter

2016-05-23 Thread Mika Kahola
Read from DPCD receiver capability field the max allowed pixel clock and bits per component for DP to VGA converter. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 46 drivers/gpu/drm/i915/intel_drv.h | 2 ++ include/drm

[Intel-gfx] [PATCH v3 00/12] drm/i915: DP branch devices

2016-05-23 Thread Mika Kahola
o drm (Ville, Daniel) v3: Max pixel rate computation moved to drm (Daniel) Mika Kahola (12): drm: Add missing DP downstream port types drm: Read DPCD receiver capability for DP to VGA converter drm: Read DPCD receiver capability for DP to DVI converter drm: Read DPCD receiver capability for DP to

[Intel-gfx] [PATCH v3 08/12] drm/i915: Check pixel rate for DP to VGA dongle

2016-05-23 Thread Mika Kahola
rate divided by 8 in MP/s. v2: DPCD read outs and computation moved to drm (Ville, Daniel) v3: Sink pixel rate computation moved to drm_dp_max_sink_dotclock() function (Daniel) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 7 +++ 1 file changed, 7 insertions(+) diff

[Intel-gfx] [PATCH v3 03/12] drm: Read DPCD receiver capability for DP to DVI converter

2016-05-23 Thread Mika Kahola
Read from DPCD receiver capability field for the following features: - max TMDS clock rate - max bits per component - single or dual link support - high color depth support Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 5 + include/drm/drm_dp_helper.h | 14

[Intel-gfx] [PATCH v3 06/12] drm: Read DPCD receiver capability for DP to Wireless Converter

2016-05-23 Thread Mika Kahola
active Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 7 +++ include/drm/drm_dp_helper.h | 13 + 2 files changed, 20 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index f98e4be..2c91771 100644 --- a/drivers/gpu/drm

[Intel-gfx] [PATCH v3 09/12] drm/i915: Read DP branch device id

2016-05-23 Thread Mika Kahola
Read device ID for DisplayPort branch devices. The device ID is defined in DPCD register 0x503 and it is mandatory field for DP branch devices. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 6 ++ include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 8 insertions

[Intel-gfx] [PATCH v3 04/12] drm: Read DPCD receiver capability for DP to HDMI converter

2016-05-23 Thread Mika Kahola
pass through - support for conversion from YCBCR444 to YCBCR422 - support for conversion from YCBCR444 to YCBCR420 Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 8 include/drm/drm_dp_helper.h | 19 +++ 2 files changed, 27 insertions(+) diff --git

[Intel-gfx] [PATCH v3 05/12] drm: Read DPCD receiver capability for DP++

2016-05-23 Thread Mika Kahola
Read from DPCD receiver capability field for the DP++ devices. The features are - max TMDS charachter clock - max bits per component - support for conversion from 3D frame sequential to frame pack Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 4 include/drm

[Intel-gfx] [PATCH v3 12/12] drm/i915: Add DP branch device info on debugfs

2016-05-23 Thread Mika Kahola
Read DisplayPort branch device info from through debugfs interface. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/i915_debugfs.c | 37 + 1 file changed, 37 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v3 07/12] drm: Compute max pixel rate for DP sink

2016-05-23 Thread Mika Kahola
For DP branch devices DPCD register may define the max supported pixel rate for VGA dongles. This patch adds a check if DPCD register value is less than current setting for pixel rate. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 22 ++ include/drm

[Intel-gfx] [PATCH v3 10/12] drm/i915: Read DP branch device HW revision

2016-05-23 Thread Mika Kahola
HW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x509. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 5 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v3 11/12] drm/i915: Read DP branch device SW revision

2016-05-23 Thread Mika Kahola
SW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x50A. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 5 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v3 8/14] drm/i915/dp: Move max. vswing check to it's own function

2016-09-08 Thread Mika Kahola
: Mika Kahola On Wed, 2016-09-07 at 11:28 -0700, Manasi Navare wrote: > From: Dhinakaran Pandiyan > > Wrap the max. vswing check in a separate function. > This makes the clock recovery phase of DP link training cleaner > > v3: > Fixed the paranthesis warning (Mika Kahola) >

Re: [Intel-gfx] [PATCH v3 9/14] drm/dp/i915: Make clock recovery in the link training compliant with DP Spec 1.2

2016-09-08 Thread Mika Kahola
Reviewed-by: Mika Kahola On Wed, 2016-09-07 at 11:28 -0700, Manasi Navare wrote: > From: Dhinakaran Pandiyan > > This function cleans up clock recovery loop in link training > compliant > tp Dp Spec 1.2. It tries the clock recovery 5 times for the same > voltage > or until

Re: [Intel-gfx] [PATCH v4 11/14] drm/i915: Fallback to lower link rate and lane count during link training

2016-09-08 Thread Mika Kahola
Reviewed-by: Mika Kahola On Wed, 2016-09-07 at 17:30 -0700, Manasi Navare wrote: > According to the DisplayPort Spec, in case of Clock Recovery failure > the link training sequence should fall back to the lower link rate > followed by lower lane count until CR succeeds. > On CR

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/dp/mst: Add support for upfront link training for DP MST

2016-09-08 Thread Mika Kahola
On Wed, 2016-09-07 at 09:40 -0700, Jim Bride wrote: > On Wed, Sep 07, 2016 at 01:53:31PM +0300, Mika Kahola wrote: > > > > On Tue, 2016-09-06 at 17:13 -0700, Manasi Navare wrote: > > > > > > From: Jim Bride > > > > > > Add upfront li

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/dp/mst: Add support for upfront link training for DP MST

2016-09-08 Thread Mika Kahola
Reviewed-by: Mika Kahola On Wed, 2016-09-07 at 13:53 +0300, Mika Kahola wrote: > On Tue, 2016-09-06 at 17:13 -0700, Manasi Navare wrote: > > > > From: Jim Bride > > > > Add upfront link training to intel_dp_mst_mode_valid() so that we > > know > > topo

Re: [Intel-gfx] [PATCH v13 13/14] drm/i915/dp: Enable Upfront link training for typeC DP support on HSW/BDW/SKL/BXT (DDI platforms)

2016-09-08 Thread Mika Kahola
these changes. > > Changes since v12: > * Fix Rebase issues (Mika Kahola) > Changes since v11: > * Change the fallback link rate logic (Manasi) > Changes since v10: > * Use the ddi link train function that loops through all the link > rates > and lane counts starting from the

Re: [Intel-gfx] [PATCH v8 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

2016-09-09 Thread Mika Kahola
On Thu, 2016-09-08 at 15:48 +0300, Ville Syrjälä wrote: > On Wed, Aug 17, 2016 at 01:49:49PM +0300, Mika Kahola wrote: > > > > Respect max TMDS clock frequency from DPCD for active > > DP to HDMI adapters. > > > > Signed-off-by: Mika Kahola > > --- >

[Intel-gfx] [PATCH v9 02/12] drm: Drop VGA from bpc definitions

2016-09-09 Thread Mika Kahola
Drop "VGA" from bits per component definitions as these are also used by other standards such as DVI, HDMI, DP++. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/i

[Intel-gfx] [PATCH v9 04/12] drm: Helper to read max bits per component

2016-09-09 Thread Mika Kahola
Helper routine to read out maximum supported bits per component for DisplayPort legay converters. v2: Return early if detailed port cap info is not available. Replace if-else ladder with switch-case (Ville) Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm

[Intel-gfx] [PATCH v9 00/12] drm/i915: DP branch devices

2016-09-09 Thread Mika Kahola
: Indentation fixes (Jim Bride) Mika Kahola (12): drm: Add missing DP downstream port types drm: Drop VGA from bpc definitions drm: Helper to read max clock rate drm: Helper to read max bits per component drm: Read DP branch device id drm/i915: Cleanup DisplayPort AUX channel initialization drm

[Intel-gfx] [PATCH v9 07/12] drm/i915: Read DP branch device HW revision

2016-09-09 Thread Mika Kahola
(Ville) Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 21 + include/drm/drm_dp_helper.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index c69ad13

[Intel-gfx] [PATCH v9 10/12] drm/i915: Update bits per component for display info

2016-09-09 Thread Mika Kahola
ction (Daniel) v4: remove updating bpc for display info as it may be overridden when parsing EDID. Instead, check bpc for DP branch device during compute_config v5: Indentation fixes (Jim Bride) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 16 +++- 1

[Intel-gfx] [PATCH v9 11/12] drm: Add DP branch device info on debugfs

2016-09-09 Thread Mika Kahola
al step to move debugging info from intel_dp. to drm_dp_helper.c (Daniel) v6: read hw and sw revision without using specific drm_dp_helper routines v7: indentation fixes (Jim Bride) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 85 + d

[Intel-gfx] [PATCH v9 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

2016-09-09 Thread Mika Kahola
Respect max TMDS clock frequency from DPCD for active DP to HDMI adapters. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_drv.h | 3 +++ drivers/gpu/drm/i915/intel_hdmi.c | 27 +++ 2 files changed, 30 insertions(+) diff --git a

[Intel-gfx] [PATCH v9 09/12] drm/i915: Check pixel rate for DP to VGA dongle

2016-09-09 Thread Mika Kahola
lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) v7: Cleanup as suggested by Ville Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH v9 08/12] drm/i915: Read DP branch device SW revision

2016-09-09 Thread Mika Kahola
info to dmesg (Ville) v4: commit message fix (Jim Bride) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 20 include/drm/drm_dp_helper.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v9 03/12] drm: Helper to read max clock rate

2016-09-09 Thread Mika Kahola
) Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 33 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 031c4d3

[Intel-gfx] [PATCH v9 05/12] drm: Read DP branch device id

2016-09-09 Thread Mika Kahola
Read DisplayPort branch device id string. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 12 include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm

[Intel-gfx] [PATCH v9 01/12] drm: Add missing DP downstream port types

2016-09-09 Thread Mika Kahola
Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h

[Intel-gfx] [PATCH v9 06/12] drm/i915: Cleanup DisplayPort AUX channel initialization

2016-09-09 Thread Mika Kahola
Let's remove reference to "struct intel_connector *connector" in intel_dp_aux_init() function as it is no longer required. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

Re: [Intel-gfx] [PATCH v8 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

2016-09-09 Thread Mika Kahola
On Fri, 2016-09-09 at 12:09 +0300, Ville Syrjälä wrote: > On Fri, Sep 09, 2016 at 10:45:27AM +0300, Mika Kahola wrote: > > > > On Thu, 2016-09-08 at 15:48 +0300, Ville Syrjälä wrote: > > > > > > On Wed, Aug 17, 2016 at 01:49:49PM +0300, Mika Kahola wrote: >

Re: [Intel-gfx] [PATCH v5 1/5] drm/i915: Fallback to lower link rate and lane count during link training

2016-09-14 Thread Mika Kahola
in intel_dp_link_rate_index > v4: > * Fixed the link rate fallback loop (Manasi Navare) > v3: > * Fixed some rebase issues (Mika Kahola) > v2: > * Add a helper function to return index of requested link rate > into common_rates array > * Changed the link rate fallb

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Change the placement of some static functions in intel_dp.c

2016-09-15 Thread Mika Kahola
common_rates[k] = source_rates[i]; > - ++k; > - ++i; > - ++j; > - } else if (source_rates[i] < sink_rates[j]) { > - ++i; > - } else { > -

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Code cleanup to use dev_priv and INTEL_GEN

2016-09-16 Thread Mika Kahola
Reviewed-by: Mika Kahola On Thu, 2016-09-15 at 17:04 -0700, Manasi Navare wrote: > Replace dev with dev_priv and INTEL_INFO with INTEL_GEN > > Signed-off-by: Manasi Navare > --- >  drivers/gpu/drm/i915/intel_dp.c | 14 +++--- >  1 file changed, 7 insertions(+), 7 dele

Re: [Intel-gfx] [PATCH v3 3/6] drm/i915: Change the placement of some static functions in intel_dp.c

2016-09-16 Thread Mika Kahola
Reviewed-by: Mika Kahola On Thu, 2016-09-15 at 17:04 -0700, Manasi Navare wrote: > These static helper functions are required to be used within upfront > link training related functions so they need to be placed at the top > of the file. It also changes macro dev to dev_priv. > &

Re: [Intel-gfx] [PATCH v6 1/6] drm/i915: Fallback to lower link rate and lane count during link training

2016-09-16 Thread Mika Kahola
with Channel EQ. > In case of Channel EQ failures, it should fallback to > lower link rate and lane count and start the CR phase again. > > v6: > * Do not split quoted string across line (Mika Kahola) > v5: > * Reset the link rate index to the max link rate index > before

Re: [Intel-gfx] [drm-intel:for-linux-next 6/12] htmldocs: drivers/gpu/drm/drm_dp_helper.c:523: warning: No description found for parameter 'id[6]'

2016-09-16 Thread Mika Kahola
I'll fix this. Cheers, Mika On Fri, 2016-09-16 at 10:53 +0300, Jani Nikula wrote: > Mika, please send in the documentation fix. > > BR, > Jani. > > > On Fri, 16 Sep 2016, kbuild test robot > wrote: > > > > tree:   git://anongit.freedesktop.org/drm-intel for-linux-next > > head:   80209e5f2c4

[Intel-gfx] [PATCH] drm: Fix DisplayPort branch device ID

2016-09-16 Thread Mika Kahola
Fix missing parameter description for DisplayPort branch device ID. This fixes warning of "No description found for parameter 'id[6]'" when creating documentation by 'make htmldocs'. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 1 + 1 file chang

Re: [Intel-gfx] [PATCH 1/5] drm/i915/skl: drop workarounds for A0 and B0 revisions

2016-09-19 Thread Mika Kahola
   GEN9_GAPS_TSV_CREDIT_DISA > BLE)); > - } > - > - /* WaDisablePowerCompilerClockGating:skl */ > - if (IS_SKL_REVID(dev_priv, SKL_REVID_B0, SKL_REVID_B0)) > - WA_SET_BIT_MASKED(HIZ_CHICKEN, > -   BDW_HIZ_POWER_COMPILER_CLOCK_GATIN > G_DISABLE); > + I915_WRITE(GEN8_GARBCNTL, (I915_READ(GEN8_GARBCNTL) | > +    GEN9_GAPS_TSV_CREDIT_DISABLE)); >   >   /* WaBarrierPerformanceFixDisable:skl */ >   if (IS_SKL_REVID(dev_priv, SKL_REVID_C0, SKL_REVID_D0)) -- Mika Kahola - Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: CRC based atomic correctness test

2016-10-07 Thread Mika Kahola
holes so that the output is the identical to reference crc - composite all with one ioctl call - grab crc and verify that the reference crc is equal - repeat this for dozen iterations to maximize coverage Signed-off-by: Mika Kahola --- tests/Makefile.sources | 1 + tests

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: CRC based atomic correctness test

2016-10-12 Thread Mika Kahola
unmet test requirements Signed-off-by: Mika Kahola --- tests/kms_plane_multiple.c | 421 + 1 file changed, 421 insertions(+) create mode 100644 tests/kms_plane_multiple.c diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c new file mode

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: CRC based atomic correctness test

2016-10-17 Thread Mika Kahola
On Wed, 2016-10-12 at 14:54 +0200, Maarten Lankhorst wrote: > Op 07-10-16 om 13:45 schreef Mika Kahola: > > > > This is a testcase with multiple planes. The idea here is the > > following > > > >  - draw a uniform frame with blue color > >  - grab crc for

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: CRC based atomic correctness test

2016-10-17 Thread Mika Kahola
Signed-off-by: Mika Kahola --- tests/Makefile.sources | 1 + tests/kms_plane_multiple.c | 423 + 2 files changed, 424 insertions(+) create mode 100644 tests/kms_plane_multiple.c diff --git a/tests/Makefile.sources b/tests/Makefile.sources index

[Intel-gfx] [PATCH] drm/i915: Fix eDP low vswing for Broadwell

2016-03-16 Thread Mika Kahola
the DDI translations table for DP instead of eDP (low vswing) table. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94087 Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_ddi.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Fix eDP low vswing for Broadwell

2016-03-16 Thread Mika Kahola
On Wed, 2016-03-16 at 11:49 +0200, Jani Nikula wrote: > On Wed, 16 Mar 2016, Mika Kahola wrote: > > [ text/plain ] > > It was noticed on bug #94087 that module parameter > > i915.edp_vswing=2 that should override the VBT setting > > to use default voltage swing (400

[Intel-gfx] [PATCH v2] drm/i915: Fix eDP low vswing for Broadwell

2016-03-18 Thread Mika Kahola
the DDI translations table for DP instead of eDP (low vswing) table. v2: Combine two if statements into one (Jani) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94087 Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_ddi.c | 12 ++-- 1 file changed, 10 insertions(+), 2

Re: [Intel-gfx] [PATCH v2 9/9] drm/i915/bxt: add bxt dsi gpio element support

2016-03-23 Thread Mika Kahola
CAMERASB08_PIN, BXT_GP_CAMERASB08_OFFSET }, > + { BXT_GP_CAMERASB09_PIN, BXT_GP_CAMERASB09_OFFSET }, > + { BXT_GP_CAMERASB10_PIN, BXT_GP_CAMERASB10_OFFSET }, > + { BXT_GP_CAMERASB11_PIN, BXT_GP_CAMERASB11_OFFSET }, > +}; > + > static inline enum port intel_dsi_seq_p

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915/dsi: refer to gpio index instead of gpio to avoid confusion

2016-03-24 Thread Mika Kahola
Housekeeping stuff. Reviewed-by: Mika Kahola On Fri, 2016-03-18 at 13:11 +0200, Jani Nikula wrote: > The DSI sequence blocks contain gpio index references, not actual gpio > numbers. No functional changes. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_ds

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix eDP low vswing for Broadwell

2016-04-12 Thread Mika Kahola
On Mon, 2016-04-11 at 16:30 +0300, Ville Syrjälä wrote: > On Thu, Mar 17, 2016 at 12:23:10PM +0200, Mika Kahola wrote: > > It was noticed on bug #94087 that module parameter > > i915.edp_vswing=2 that should override the VBT setting > > to use default voltage swing (400 mV) wa

[Intel-gfx] [RESEND FOR CI PATCH v2] drm/i915: Fix eDP low vswing for Broadwell

2016-04-13 Thread Mika Kahola
the DDI translations table for DP instead of eDP (low vswing) table. v2: Combine two if statements into one (Jani) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94087 Signed-off-by: Mika Kahola Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_ddi.c | 12 ++-- 1 file

[Intel-gfx] [PATCH] drm/i915: Cache DisplayPort link signal levels

2016-04-20 Thread Mika Kahola
trained until the signal levels of previus link training is achieved and clock recovery is achieved. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91393 Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 1 + drivers/gpu/drm/i915/intel_dp_link_training.c | 7

Re: [Intel-gfx] [RESEND FOR CI PATCH v2] drm/i915: Fix eDP low vswing for Broadwell

2016-04-20 Thread Mika Kahola
CI hasn't catch this patch for testing? On Wed, 2016-04-13 at 12:11 +0300, Mika Kahola wrote: > It was noticed on bug #94087 that module parameter > i915.edp_vswing=2 that should override the VBT setting > to use default voltage swing (400 mV) was not applied > for Broadwell

[Intel-gfx] [PATCH v3] drm/i915: Fix eDP low vswing for Broadwell

2016-04-20 Thread Mika Kahola
the DDI translations table for DP instead of eDP (low vswing) table. v2: Combine two if statements into one (Jani) v3: Change dev_priv->edp_low_vswing to use dev_priv->vbt.edp.low_vswing Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94087 Signed-off-by: Mika Kahola --- drivers/g

Re: [Intel-gfx] [PATCH i-g-t v2 29/33] tests/kms_vblank: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_vblank.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 d

Re: [Intel-gfx] [PATCH i-g-t v2 30/33] tests/prime_mmap_kms: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/prime_mmap_kms.c | 2 +- >  1 file changed, 1 insertion(+), 1

Re: [Intel-gfx] [PATCH i-g-t v2 31/33] tests/kms_ccs: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_ccs.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions

Re: [Intel-gfx] [PATCH i-g-t v2 32/33] tests/kms_plane_lowres: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_plane_lowres.c | 27 +-- >  1 file c

Re: [Intel-gfx] [PATCH i-g-t v2 33/33] lib/igt_kms: Remove code obsoleted by dyn n_planes implementation

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:34 -0500, Robert Foss wrote: > Due to the dyn n_planes implementation some attributes and functions > were made obsolete and cand be removed. > > However to keep all of the tests building the obsolete code is > removed after a

[Intel-gfx] [PATCH i-g-t v2] tests: Validate TEST_ONLY correctness against full atomic commit

2017-01-30 Thread Mika Kahola
Validate atomic commit correctness before actual commit. For: VIZ-6956 v2: Add flag to toggle TEST_ONLY for atomic commit. Remove DRM_MODE_PAGE_FLIP_EVENT flag, if enabled, before trying atomic commit with TEST_ONLY flag (Maarten) Cc: Maarten Lankhorst Signed-off-by: Mika Kahola

Re: [Intel-gfx] [PATCH i-g-t v2] tests: Validate TEST_ONLY correctness against full atomic commit

2017-01-30 Thread Mika Kahola
On Mon, 2017-01-30 at 13:43 +0100, Maarten Lankhorst wrote: > Op 30-01-17 om 12:37 schreef Mika Kahola: > > > > Validate atomic commit correctness before actual commit. > > > > For: VIZ-6956 > > > > v2: Add flag to toggle TEST_ONLY for atomic commit. >

Re: [Intel-gfx] [PATCH] drm/i915: Add MIPI_IO WA and program DSI regulators

2017-01-31 Thread Mika Kahola
Looks ok. Acked-by: Mika Kahola On Wed, 2017-01-25 at 19:43 +0530, Vidya Srinivas wrote: > From: Uma Shankar > > Enable MIPI IO WA for BXT DSI as per bspec and > program the DSI regulators. > > v2: Moved IO enable to pre-enable as per Mika's > review comments

[Intel-gfx] [PATCH i-g-t v3 1/7] lib/igt_kms: Add forcing TEST_ONLY for atomic commits

2017-02-01 Thread Mika Kahola
Add an option to force atomic commits to do commits with TEST_ONLY flag first before doing the actual commit. Signed-off-by: Mika Kahola --- lib/igt_kms.c | 18 +- lib/igt_kms.h | 1 + 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c

[Intel-gfx] [PATCH i-g-t v3 2/7] tests/kms_plane_multiple: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. v2: Use flag to indicate to test with TEST_ONLY flag with atomic commit Signed-off-by: Mika Kahola --- tests/kms_plane_multiple.c | 35 +++ 1 file changed, 35 insertions

[Intel-gfx] [PATCH i-g-t v3 7/7] tests/kms_cursor_legacy: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola --- tests/kms_cursor_legacy.c | 230 -- 1 file changed, 204 insertions(+), 26 deletions(-) diff --git a/tests/kms_cursor_legacy.c b

[Intel-gfx] [PATCH i-g-t v3 4/7] tests/kms_plane_scaling: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic scaling without actually committing the changes. v2: Create subtests with TEST_ONLY flag and one without Signed-off-by: Mika Kahola --- tests/kms_plane_scaling.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a

[Intel-gfx] [PATCH i-g-t v3 0/7] Validate TEST_ONLY correctness against full atomic commit

2017-02-01 Thread Mika Kahola
selection in igt core separate test cases for TEST_ONLY atomic commits (Maarten) For: VIZ-6956 Mika Kahola (7): lib/igt_kms: Add forcing TEST_ONLY for atomic commits tests/kms_plane_multiple: Add TEST_ONLY flag tests/kms_atomic_transition: Add TEST_ONLY flag tests/kms_plane_scaling: Add

[Intel-gfx] [PATCH i-g-t v3 6/7] tests/kms_plane_lowres: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola --- tests/kms_plane_lowres.c | 40 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/tests/kms_plane_lowres.c b/tests

[Intel-gfx] [PATCH i-g-t v3 3/7] tests/kms_atomic_transition: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic transition display commits without actual real-life commit. v2: use flag to force atomic commit with TEST_ONLY flag Signed-off-by: Mika Kahola --- tests/kms_atomic_transition.c | 66 --- 1 file changed, 56 insertions

<    1   2   3   4   5   6   7   8   9   10   >