[Intel-gfx] [PATCH 44/53] docs: gpu: avoid using UTF-8 chars

While UTF-8 characters can be used at the Linux documentation, the best is to use them only when ASCII doesn't offer a good replacement. So, replace the occurences of the following UTF-8 characters: - U+2019 ('’'): RIGHT SINGLE QUOTATION MARK Signed-off-by: Mauro

[Intel-gfx] [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

└'): BOX DRAWINGS LIGHT UP AND RIGHT - U+251c ('├'): BOX DRAWINGS LIGHT VERTICAL AND RIGHT - U+2b0d ('⬍'): UP DOWN BLACK ARROW PS.: maintainers were bcc on patch 00/53, in order to reduce the risk of patch 00 to be rejected by list servers. - For U+00b7

Re: [Intel-gfx] [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

Em Mon, 10 May 2021 14:16:16 +0100 Edward Cree escreveu: > On 10/05/2021 12:55, Mauro Carvalho Chehab wrote: > > The main point on this series is to replace just the occurrences > > where ASCII represents the symbol equally well > > > - U+2014 ('—'): E

Re: [Intel-gfx] [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

Em Mon, 10 May 2021 12:52:44 +0200 Thorsten Leemhuis escreveu: > On 10.05.21 12:26, Mauro Carvalho Chehab wrote: > > > > As Linux developers are all around the globe, and not everybody has UTF-8 > > as their default charset, better to use UTF-8 only on cases where it is

Re: [Intel-gfx] [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

Hi David, Em Mon, 10 May 2021 11:54:02 +0100 David Woodhouse escreveu: > On Mon, 2021-05-10 at 12:26 +0200, Mauro Carvalho Chehab wrote: > > There are several UTF-8 characters at the Kernel's documentation. > > > > Several of them were due to the process of convert

Re: [Intel-gfx] [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

Em Mon, 10 May 2021 13:19:50 +0200 Mauro Carvalho Chehab escreveu: > Em Mon, 10 May 2021 12:52:44 +0200 > Thorsten Leemhuis escreveu: > > > On 10.05.21 12:26, Mauro Carvalho Chehab wrote: > > > > > > As Linux developers are all around the globe, and not e

Re: [Intel-gfx] [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

Em Mon, 10 May 2021 15:33:47 +0100 Edward Cree escreveu: > On 10/05/2021 14:59, Matthew Wilcox wrote: > > Most of these > > UTF-8 characters come from latex conversions and really aren't > > necessary (and are being used incorrectly). > I fully agree with fixing those. > The cover-letter, howev

Re: [Intel-gfx] [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

Em Mon, 10 May 2021 15:22:02 -0400 "Theodore Ts'o" escreveu: > On Mon, May 10, 2021 at 02:49:44PM +0100, David Woodhouse wrote: > > On Mon, 2021-05-10 at 13:55 +0200, Mauro Carvalho Chehab wrote: > > > This patch series is doing conversion only when using

Re: [Intel-gfx] [PATCH 00/53] Get rid of UTF-8 chars that can be mapped as ASCII

Em Mon, 10 May 2021 14:49:44 +0100 David Woodhouse escreveu: > On Mon, 2021-05-10 at 13:55 +0200, Mauro Carvalho Chehab wrote: > > This patch series is doing conversion only when using ASCII makes > > more sense than using UTF-8. > > > > See, a number of converted

[Intel-gfx] [PATCH v2 00/40] Use ASCII subset instead of UTF-8 alternate symbols

641727.git.mchehab+hua...@kernel.org/ I also changed the patch texts, in order to better describe the patches goals. Mauro Carvalho Chehab (40): docs: hwmon: Use ASCII subset instead of UTF-8 alternate symbols docs: admin-guide: Use ASCII subset instead of UTF-8 alternate symbols do

Re: [Intel-gfx] [PATCH v2 00/40] Use ASCII subset instead of UTF-8 alternate symbols

Em Wed, 12 May 2021 10:14:44 -0400 "Theodore Ts'o" escreveu: > On Wed, May 12, 2021 at 02:50:04PM +0200, Mauro Carvalho Chehab wrote: > > v2: > > - removed EM/EN DASH conversion from this patchset; > > Are you still thinking about doing

[Intel-gfx] [PATCH v2 32/40] docs: gpu: Use ASCII subset instead of UTF-8 alternate symbols

tps://docutils.sourceforge.io/docs/user/smartquotes.html So, replace the occurences of the following UTF-8 characters: - U+2019 ('’'): RIGHT SINGLE QUOTATION MARK Acked-by: Jani Nikula Acked-by: Liviu Dudau Signed-off-by: Mauro Carvalho Chehab --- Documentation/gpu/i915.

Re: [Intel-gfx] [PATCH v2 00/40] Use ASCII subset instead of UTF-8 alternate symbols

Em Wed, 12 May 2021 18:07:04 +0100 David Woodhouse escreveu: > On Wed, 2021-05-12 at 14:50 +0200, Mauro Carvalho Chehab wrote: > > Such conversion tools - plus some text editor like LibreOffice or similar > > - have > > a set of rules that turns some typed ASCII

Re: [Intel-gfx] [PATCH v2 00/40] Use ASCII subset instead of UTF-8 alternate symbols

Em Fri, 14 May 2021 12:08:36 +0100 Edward Cree escreveu: > For anyone who doesn't know about it: X has this wonderful thing called > the Compose key[1]. For instance, type ⎄--- to get —, or ⎄<" for “. > Much more mnemonic than Unicode codepoints; and you can extend it with > user-defined seque

Re: [Intel-gfx] [PATCH v2 00/40] Use ASCII subset instead of UTF-8 alternate symbols

Em Fri, 14 May 2021 10:06:01 +0100 David Woodhouse escreveu: > On Fri, 2021-05-14 at 10:21 +0200, Mauro Carvalho Chehab wrote: > > Em Wed, 12 May 2021 18:07:04 +0100 > > David Woodhouse escreveu: > > > > > On Wed, 2021-05-12 at 14:50 +0200, Mauro Carvalh

Re: [Intel-gfx] [PATCH v2 00/40] Use ASCII subset instead of UTF-8 alternate symbols

Em Sat, 15 May 2021 10:24:28 +0100 David Woodhouse escreveu: > On Sat, 2021-05-15 at 10:22 +0200, Mauro Carvalho Chehab wrote: > > > > Here, U is not working. No idea why. I haven't > > > > test it for *years*, as I din't see any reason why I

[Intel-gfx] [PATCH 1/3] gpu: drm: replace occurrences of invalid character

There are some places at drm that ended receiving a REPLACEMENT CHARACTER U+fffd ('�'), probably because of some bad charset conversion. Fix them by using what it seems to be the proper character. Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/include/atombios.h

Re: [Intel-gfx] [PATCH 2/2] drm/doc: Fix more kerneldoc/sphinx warnings

Em Tue, 19 Jul 2016 14:36:50 +0200 Daniel Vetter escreveu: > On Tue, Jul 19, 2016 at 01:42:55PM +0200, Daniel Vetter wrote: > > These are the leftovers I could only track down using keep_warnings = > > True. For some of them we might want to update our style guide on how > > to reference structur

Re: [Intel-gfx] [PATCH 1/2] doc/sphinx: Enable keep_warnings

Em Wed, 20 Jul 2016 14:29:01 +0200 Markus Heiser escreveu: > Am 20.07.2016 um 13:27 schrieb Daniel Vetter : > > > On Wed, Jul 20, 2016 at 12:55 PM, Markus Heiser > > wrote: > >> Hi Daniel, hi Mauro, > >> > >> Am 19.07.2016 um 17:32 schrieb Daniel Vetter : > >> > >>> On Tue, Jul 19, 2016 a

Re: [Intel-gfx] [PATCH 2/2] drm/doc: Fix more kerneldoc/sphinx warnings

Em Wed, 20 Jul 2016 20:35:09 +0200 Markus Heiser escreveu: > Am 20.07.2016 um 14:20 schrieb Mauro Carvalho Chehab > : > > > Em Tue, 19 Jul 2016 14:36:50 +0200 > > Daniel Vetter escreveu: > > > >> On Tue, Jul 19, 2016 at 01:42:55PM +0200, Daniel Vetter wr

Re: [Intel-gfx] [PATCH 2/2] drm/doc: Fix more kerneldoc/sphinx warnings

Em Wed, 20 Jul 2016 20:35:09 +0200 Markus Heiser escreveu: > Am 20.07.2016 um 14:20 schrieb Mauro Carvalho Chehab > : > > > Em Tue, 19 Jul 2016 14:36:50 +0200 > > Daniel Vetter escreveu: > > > >> On Tue, Jul 19, 2016 at 01:42:55PM +0200, Daniel Vetter wr

[Intel-gfx] [PATCH 12/22] gpu: i915.rst: Fix references to renamed files

lists ./drivers/gpu/drm/i915/intel_lrc.c' failed with return code 1 WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -internal ./drivers/gpu/drm/i915/intel_lrc.c' failed with return code 2 Fixes: 112ed2d31a46 ("drm/i915: Move GraphicsTechnology files under gt/&quo

[Intel-gfx] [PATCH v2 08/22] gpu: i915.rst: Fix references to renamed files

lists ./drivers/gpu/drm/i915/intel_lrc.c' failed with return code 1 WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -internal ./drivers/gpu/drm/i915/intel_lrc.c' failed with return code 2 Fixes: 112ed2d31a46 ("drm/i915: Move GraphicsTechnology files under gt/&quo

Re: [Intel-gfx] [PATCH v4 18/28] docs: convert docs to ReST and rename to *.rst

Em Wed, 12 Jun 2019 17:25:39 -0700 "Srivatsa S. Bhat" escreveu: > On 6/12/19 10:52 AM, Mauro Carvalho Chehab wrote: > > Convert the PM documents to ReST, in order to allow them to > > build with Sphinx. > > > > The conversion is actually: > > -

[Intel-gfx] [PATCH] docs: fix some broken references due to txt->rst renames

There are three left-overs from the recent file renames, probably due to some other conflicting patch. Fix them. Signed-off-by: Mauro Carvalho Chehab --- This patch is against today's next-20190617 branch. Not sure if it will apply cleanly at -docs tree. If not, Please let me know for

[Intel-gfx] [PATCH 5/9] docs: fix some broken references due to txt->rst renames

There are three left-overs from the recent file renames, probably due to some other conflicting patch. Fix them. Signed-off-by: Mauro Carvalho Chehab Acked-by: Wolfram Sang Acked-by: Daniel Vetter --- Documentation/devicetree/bindings/arm/idle-states.txt | 2 +- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 0/9] Some doc fixes

. Mauro Carvalho Chehab (9): hrtimer: Use a bullet for the returns bullet list docs: trace: fix a broken label docs: signal: fix a kernel-doc markup dt: leds-lm36274.txt: fix a broken reference to ti-lmu.txt docs: fix some broken references due to txt->rst renames docs: virtual: there are

[Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

lström Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 0/6] at: https://lore.kernel.org/all/cover.1655306128.git.mche...@kernel.org/ drivers/gpu/drm/i915/gt/intel_reset.c | 37 --- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/g

[Intel-gfx] [PATCH 6/6] drm/i915/gt: Serialize TLB invalidates with GT resets

the mmio access, thereby serialising with the GDRST. Tested on a NUC5i7RYB, BIOS RYBDWi35.86A.0380.2019.0517.1530 with i915 selftest/hangcheck. Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Reported-by: Mauro Carvalho Chehab Tested-by: Mauro Carvalho Chehab

[Intel-gfx] [PATCH 0/6] Fix TLB invalidate issues with Broadwell

i915 selftest hangcheck is causing the i915 driver timeouts, as reported by Intel CI bot: http://gfx-ci.fi.intel.com/cibuglog-ng/issuefilterassoc/24297?query_key=42a999f48fa6ecce068bc8126c069be7c31153b4 When such test runs, the only output is: [ 68.811639] i915: Performing liv

[Intel-gfx] [PATCH 4/6] drm/i915/gt: Only invalidate TLBs exposed to user manipulation

drm/i915: Flush TLBs before releasing backing store") Signed-off-by: Chris Wilson Cc: Fei Yang Cc: Andi Shyti Cc: sta...@vger.kernel.org Acked-by: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 0/6] at: https://lore.kernel.org/all/cover.1655306128.git.mche...@kerne

[Intel-gfx] [PATCH 3/6] drm/i915/gt: Skip TLB invalidations once wedged

releasing backing store") Signed-off-by: Chris Wilson Cc: Fei Yang Cc: Andi Shyti Cc: sta...@vger.kernel.org Acked-by: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 0/6] at: https://lore.kernel.org/all/cover.1655306128.git.mche...@kernel.org/ drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH 2/6] drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations

i Cc: sta...@vger.kernel.org Acked-by: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 0/6] at: https://lore.kernel.org/all/cover.1655306128.git.mche...@kernel.org/ drivers/gpu/drm/i915/gt/intel_gt.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/d

[Intel-gfx] [PATCH 1/6] drm/i915/gt: Ignore TLB invalidations on idle engines

can only do so when the connection to the GuC is awake. Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Signed-off-by: Chris Wilson Cc: Fei Yang Cc: Andi Shyti Cc: sta...@vger.kernel.org Acked-by: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab ---

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

Hi Tvrtko, On Fri, 24 Jun 2022 09:34:21 +0100 Tvrtko Ursulin wrote: > On 23/06/2022 12:17, Andi Shyti wrote: > > Hi Mauro, > > > > On Wed, Jun 15, 2022 at 04:27:39PM +0100, Mauro Carvalho Chehab wrote: > >> From: Chris Wilson > >> > >> Don

[Intel-gfx] [PATCH v2 0/3] Fix TLB invalidate issues with Broadwell

i915 selftest hangcheck is causing the i915 driver timeouts, as reported by Intel CI bot: http://gfx-ci.fi.intel.com/cibuglog-ng/issuefilterassoc/24297?query_key=42a999f48fa6ecce068bc8126c069be7c31153b4 When such test runs, the only output is: [ 68.811639] i915: Performing live selftes

[Intel-gfx] [PATCH v2 1/3] drm/i915/gt: Ignore TLB invalidations on idle engines

only do so when the connection to the GuC is awake. Cc: sta...@vger.kernel.org Signed-off-by: Chris Wilson Cc: Fei Yang Reviewed-by: Andi Shyti Acked-by: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab --- See [PATCH v2 0/3] at: https://lore.kernel.org/all/cover.1656516220.git.mche

[Intel-gfx] [PATCH v2 2/3] drm/i915/gt: Serialize GRDOM access between multiple engine resets

ure that no other GT state changes at the same time as the actual reset. Cc: sta...@vger.kernel.org Reported-by: Mika Kuoppala Signed-off-by: Chris Wilson Cc: Mika Kuoppala Reviewed-by: Andi Shyti Acked-by: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab --- See [PATCH v2 0/3] at

[Intel-gfx] [PATCH v2 3/3] drm/i915/gt: Serialize TLB invalidates with GT resets

the mmio access, thereby serialising with the GDRST. Tested on a NUC5i7RYB, BIOS RYBDWi35.86A.0380.2019.0517.1530 with i915 selftest/hangcheck. Cc: sta...@vger.kernel.org Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Reported-by: Mauro Carvalho Chehab Tes

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

On Tue, 28 Jun 2022 16:49:23 +0100 Tvrtko Ursulin wrote: >.. which for me means a different patch 1, followed by patch 6 (moved > to be patch 2) would be ideal stable material. > > Then we have the current patch 2 which is open/unknown (to me at least). > > And the rest seem like optimisations

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

Em Wed, 29 Jun 2022 17:02:59 +0100 Tvrtko Ursulin escreveu: > On 29/06/2022 16:30, Mauro Carvalho Chehab wrote: > > On Tue, 28 Jun 2022 16:49:23 +0100 > > Tvrtko Ursulin wrote: > > > >> .. which for me means a different patch 1, followed by patch 6 (moved >

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

Em Thu, 30 Jun 2022 09:12:41 +0100 Tvrtko Ursulin escreveu: > On 30/06/2022 08:32, Mauro Carvalho Chehab wrote: > > Em Wed, 29 Jun 2022 17:02:59 +0100 > > Tvrtko Ursulin escreveu: > > > >> On 29/06/2022 16:30, Mauro Carvalho Chehab wrote: > >&

[Intel-gfx] [PATCH v3 1/2] drm/i915/gt: Serialize GRDOM access between multiple engine resets

ure that no other GT state changes at the same time as the actual reset. Cc: sta...@vger.kernel.org # Up to 4.4 Reported-by: Mika Kuoppala Signed-off-by: Chris Wilson Cc: Mika Kuoppala Reviewed-by: Andi Shyti Acked-by: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbomb

[Intel-gfx] [PATCH v3 0/2] Fix TLB invalidate issues with Broadwell

i915 selftest hangcheck is causing the i915 driver timeouts, as reported by Intel CI bot: http://gfx-ci.fi.intel.com/cibuglog-ng/issuefilterassoc/24297?query_key=42a999f48fa6ecce068bc8126c069be7c31153b4 When such test runs, the only output is: [ 68.811639] i915: Performing live selftes

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

On Fri, 1 Jul 2022 08:56:53 +0100 Tvrtko Ursulin wrote: > On 30/06/2022 17:01, Mauro Carvalho Chehab wrote: > > Em Thu, 30 Jun 2022 09:12:41 +0100 > > Tvrtko Ursulin escreveu: > > > >> On 30/06/2022 08:32, Mauro Carvalho Chehab wrote: > >>> Em We

[Intel-gfx] [PATCH v3 2/2] drm/i915/gt: Serialize TLB invalidates with GT resets

the mmio access, thereby serialising with the GDRST. Tested on a NUC5i7RYB, BIOS RYBDWi35.86A.0380.2019.0517.1530 with i915 selftest/hangcheck. Cc: sta...@vger.kernel.org # Up to 4.4 Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Reported-by: Mauro Carvalho Cheh

Re: [Intel-gfx] [PATCH v2 1/7] drm: Move and add a few utility macros into drm util header

On Tue, 5 Jul 2022 15:24:49 +0300 Gwan-gyeong Mun wrote: > It moves overflows_type utility macro into drm util header from i915_utils > header. The overflows_type can be used to catch the truncation between data > types. And it adds safe_conversion() macro which performs a type conversion > (cas

Re: [Intel-gfx] [PATCH v2 2/7] drm/i915/gem: Typecheck page lookups

gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c > index ef3b04c7e153..28443c77b45a 100644 > --- a/drivers/gpu/drm/i915/i915_vma.c > +++ b/drivers/gpu/drm/i915/i915_vma.c > @@ -911,7 +911,7 @@ rotate_pages(struct drm_i915_gem_object *obj, unsigned > int offset, >struct sg_table *st, struct scatterlist *sg) > { > unsigned int column, row; > - unsigned int src_idx; > + pgoff_t src_idx; > > for (column = 0; column < width; column++) { > unsigned int left; > @@ -1017,7 +1017,7 @@ add_padding_pages(unsigned int count, > > static struct scatterlist * > remap_tiled_color_plane_pages(struct drm_i915_gem_object *obj, > - unsigned int offset, unsigned int alignment_pad, > + unsigned long offset, unsigned int alignment_pad, > unsigned int width, unsigned int height, > unsigned int src_stride, unsigned int dst_stride, > struct sg_table *st, struct scatterlist *sg, > @@ -1076,7 +1076,7 @@ remap_tiled_color_plane_pages(struct > drm_i915_gem_object *obj, > > static struct scatterlist * > remap_contiguous_pages(struct drm_i915_gem_object *obj, > -unsigned int obj_offset, > +pgoff_t obj_offset, > unsigned int count, > struct sg_table *st, struct scatterlist *sg) > { > @@ -1109,7 +1109,7 @@ remap_contiguous_pages(struct drm_i915_gem_object *obj, > > static struct scatterlist * > remap_linear_color_plane_pages(struct drm_i915_gem_object *obj, > -unsigned int obj_offset, unsigned int > alignment_pad, > +pgoff_t obj_offset, unsigned int alignment_pad, > unsigned int size, > struct sg_table *st, struct scatterlist *sg, > unsigned int *gtt_offset) Once fixed the above nitpicks, feel free to add: Reviewed-by: Mauro Carvalho Chehab

Re: [Intel-gfx] [PATCH v2 4/7] drm/i915: Check for integer truncation on the configuration of ttm place

On Tue, 5 Jul 2022 15:24:52 +0300 Gwan-gyeong Mun wrote: > There is an impedance mismatch between the first/last valid page > frame number of ttm place in unsigned and our memory/page accounting in > unsigned long. > As the object size is under the control of userspace, we have to be prudent > a

Re: [Intel-gfx] [PATCH v2 3/7] drm/i915: Check for integer truncation on scatterlist creation

: Tvrtko Ursulin > Cc: Brian Welty > Cc: Matthew Auld > Cc: Thomas Hellström > Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab > --- > drivers/gpu/drm/i915/gem/i915_gem_internal.c | 6 -- > drivers/gpu/drm/i915/gem/i915_gem_object.h | 3 --- > drivers/gpu/

Re: [Intel-gfx] [PATCH v2 5/7] drm/i915: Check if the size is too big while creating shmem file

the size is larger than the size that can be handled. > > Signed-off-by: Gwan-gyeong Mun > Cc: Chris Wilson > Cc: Matthew Auld > Cc: Thomas Hellström > Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab > --- > drivers/gpu/drm/i915/gem/i915_gem_shmem.

Re: [Intel-gfx] [PATCH v2 6/7] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

BIG when the size is > too large, it converts return value to -E2BIG. > > Signed-off-by: Gwan-gyeong Mun > Cc: Chris Wilson > Cc: Matthew Auld > Cc: Thomas Hellström > Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab > --- > drivers/gpu/drm/i915/gem/i9

Re: [Intel-gfx] [PATCH v2 7/7] drm/i915: Remove truncation warning for large objects

> Cc: Thomas Hellström > Testcase: igt@gem_create@create-massive > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4991 > Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab > --- > drivers/gpu/drm/i915/gem/i915_gem_object.h | 15 --- > 1 file cha

Re: [Intel-gfx] [PATCH v2 1/7] drm: Move and add a few utility macros into drm util header

On Wed, 6 Jul 2022 18:04:20 +0300 Gwan-gyeong Mun wrote: > On 7/5/22 5:23 PM, Mauro Carvalho Chehab wrote: > > On Tue, 5 Jul 2022 15:24:49 +0300 > > Gwan-gyeong Mun wrote: > > > >> It moves overflows_type utility macro into drm util header from i915_utils >

Re: [Intel-gfx] [PATCH v2 2/7] drm/i915/gem: Typecheck page lookups

On Wed, 6 Jul 2022 19:33:22 +0300 Gwan-gyeong Mun wrote: > On 7/5/22 5:35 PM, Mauro Carvalho Chehab wrote: > > On Tue, 5 Jul 2022 15:24:50 +0300 > > Gwan-gyeong Mun wrote: > > > >> From: Chris Wilson > >> > >> We need to check that w

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fix TLB invalidate issues with Broadwell (rev4)

On Fri, 8 Jul 2022 10:29:42 -0400 Rodrigo Vivi wrote: > On Thu, Jul 07, 2022 at 02:47:57PM -, Patchwork wrote: > > == Series Details == > > > > Series: Fix TLB invalidate issues with Broadwell (rev4) > > URL : https://patchwork.freedesktop.org/series/105167/ > > State : warning > > > > ==

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Fix TLB invalidate issues with Broadwell (rev4)

Yeah, that sounds to be a false-positive: Starting dynamic subtest: perf Starting dynamic subtest: perf Dmesg <6> [1163.312914] [IGT] i915_selftest: starting dynamic subtest perf <5> [1164.217938] Setting dangerous option enable_psr - t

[Intel-gfx] [PATCH v4 0/2] Fix TLB invalidate issues with Broadwell

i915 selftest hangcheck is causing the i915 driver timeouts, as reported by Intel CI bot: http://gfx-ci.fi.intel.com/cibuglog-ng/issuefilterassoc/24297?query_key=42a999f48fa6ecce068bc8126c069be7c31153b4 When such test runs, the only output is: [ 68.811639] i915: Performing live selftes

[Intel-gfx] [PATCH v4 2/2] drm/i915/gt: Serialize TLB invalidates with GT resets

the mmio access, thereby serialising with the GDRST. Tested on a NUC5i7RYB, BIOS RYBDWi35.86A.0380.2019.0517.1530 with i915 selftest/hangcheck. Cc: sta...@vger.kernel.org # v4.4 and upper Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Reported-by: Mauro Ca

[Intel-gfx] [PATCH v4 1/2] drm/i915/gt: Serialize GRDOM access between multiple engine resets

ure that no other GT state changes at the same time as the actual reset. Cc: sta...@vger.kernel.org # v4.4 and upper Reported-by: Mika Kuoppala Signed-off-by: Chris Wilson Acked-by: Mika Kuoppala Reviewed-by: Andi Shyti Reviewed-by: Andrzej Hajda Acked-by: Thomas Hellström Signed-off-by: Mauro

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Fix TLB invalidate issues with Broadwell (rev5)

On Mon, 11 Jul 2022 10:06:38 -0400 Rodrigo Vivi wrote: > On Mon, Jul 11, 2022 at 08:22:33AM -, Patchwork wrote: > >Patch Details > > > >Series: Fix TLB invalidate issues with Broadwell (rev5) > >URL: [1]https://patchwork.freedesktop.org/series/105167/ > >State: failure

[Intel-gfx] [PATCH 15/32] drm/i915: intel_pm.c: fix some ascii artwork at kernel-doc

the last line are indented with the same amount of spaces. Also, a "\" at the end means that the next line should be merged with the first one. Change the ascii artwork to be on code-blocks, starting all lines at the same characters and not ending with a backslash. Signed-off-by: Maur

[Intel-gfx] [PATCH 06/32] drm/i915: intel_wakeref.h: fix some kernel-doc markups

/i915/intel_wakeref.h:149: warning: expecting prototype for intel_wakeref_put_flags(). Prototype was for __intel_wakeref_put() instead Fix them. Additionally, improve title for intel_wakeref_get_if_active(). Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people,

[Intel-gfx] [PATCH 25/32] drm/i915: i915_deps: use a shorter title markup

The DOC: tag waits for a one-line short title for the doc section. Using multiple lines will produce a weird output. So, add a shorter description for the title, while keeping the current content below it. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people

[Intel-gfx] [PATCH 13/32] drm/i915: intel_fb: fix a kernel-doc issue with Sphinx

We can't use %foo[] as this produces a bad markup. Use instead, the emphasis markup directly. Fix this issue: Documentation/gpu/i915:136: ./drivers/gpu/drm/i915/display/intel_fb.c:280: WARNING: Inline strong start-string without end-string. Signed-off-by: Mauro Carvalho Chehab --

[Intel-gfx] [PATCH 30/32] docs: gpu: i915.rst: PM: add more kernel-doc markups

Both intel_runtime_pm.h and intel_pm.c contains kAPI for runtime PM. So, add them to the documentation. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00/32] at: https://lore.kernel.org/all/cover

[Intel-gfx] [PATCH 22/32] drm/i915: i915_vma_resource.c: fix some kernel-doc markups

-string without end-string. That's because @foo evaluates into **foo**, and placing anything after it without spaces cause Sphinx to warn and do the wrong thing.. So, replace them by a different Sphinx-compatible tag. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large numb

[Intel-gfx] [PATCH 07/32] drm/i915: i915_gem_ttm: fix a kernel-doc markup

Two new fields were added to __i915_gem_ttm_object_init() without their corresponding documentation. Document them. Fixes: 9b78b5dade2d ("drm/i915: add i915_gem_object_create_region_at()") Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, on

[Intel-gfx] [PATCH 02/32] drm/i915: display: fix kernel-doc markup warnings

'dig_port' description in 'intel_tc_port_disconnect_phy_work' Those are due to wrong parameter of function name. Address them. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00/32] at:

[Intel-gfx] [PATCH 28/32] docs: gpu: i915.rst: GuC: add more kernel-doc markups

There are several documented GuC kAPI that aren't currently part of the docs. Add them, as this allows identifying issues with badly-formatted tags. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [

[Intel-gfx] [PATCH 00/32] drm/i915: fix kernel-doc issues

s all it is needed is to search for "/**" at i915 files to know what of them have embedded documentation. Mauro Carvalho Chehab (32): drm/i915: fix kernel-doc trivial warnings on i915/*.[ch] files drm/i915: display: fix kernel-doc markup warnings drm/i915: gt: fix some Kernel-doc i

[Intel-gfx] [PATCH 26/32] docs: gpu: i915.rst: display: add kernel-doc markups

There are several documented kAPI at the display side that aren't currently part of the docs. Add them, as this allows identifying issues with badly-formatted tags. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C o

[Intel-gfx] [PATCH 29/32] docs: gpu: i915.rst: GVT: add more kernel-doc markups

There are several documented GVT kAPI that aren't currently part of the docs. Add them, as this allows identifying issues with badly-formatted tags. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [

[Intel-gfx] [PATCH 32/32] docs: gpu: i915.rst: add the remaining kernel-doc markup files

fi; done >aaa Add them to i915.rst as well. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00/32] at: https://lore.kernel.org/all/cover.1657565224.git.mche...

[Intel-gfx] [PATCH 16/32] drm/i915: i915_gem_region.h: fix i915_gem_apply_to_region_ops doc

ribed, using a list, in order for it to be properly parsed during documentation build time. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00/32] at: https://lore.kernel.org/all/cover.1657565224.git

[Intel-gfx] [PATCH 31/32] docs: gpu: i915.rst: GEM/TTM: add more kernel-doc markups

There are several documented GEM/TTM kAPI that aren't currently part of the docs. Add them, as this allows identifying issues with badly-formatted tags. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover

[Intel-gfx] [PATCH 12/32] drm/i915: intel_dp_link_training.c: fix kernel-doc markup

: ./drivers/gpu/drm/i915/display/intel_dp_link_training.c:186: WARNING: Definition list ends without a blank line; unexpected unindent. Use table markups to fix it. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover

[Intel-gfx] [PATCH 18/32] drm/i915: fix i915_gem_ttm_move.c DOC: markup

The doc markup should not end with ":", as it would generate a warning on Sphinx while generating the cross-reference tag. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00/32]

[Intel-gfx] [PATCH 11/32] drm/i915: document kernel-doc trivial issues

drm/i915/gt/uc/intel_guc_hwconfig.c:113: warning: Function parameter or member 'gt' not described in 'guc_hwconfig_init' drivers/gpu/drm/i915/gt/intel_engine_types.h:276: warning: Function parameter or member 'preempt_hang' not described in 'intel_engine_execlists'

[Intel-gfx] [PATCH 27/32] docs: gpu: i915.rst: gt: add more kernel-doc markups

There are several documented GT kAPI that aren't currently part of the docs. Add them, as this allows identifying issues with badly-formatted tags. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PAT

[Intel-gfx] [PATCH 24/32] drm/i915: i915_scatterlist.h: fix some kernel-doc markups

warn and do the wrong thing.. So, replace them by a different Sphinx-compatible tag. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00/32] at: https://lore.kernel.org/all/cover.1657565224.git

[Intel-gfx] [PATCH 09/32] drm/i915: gem: add missing trivial function parameters

Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00/32] at: https://lore.kernel.org/all/cover.1657565224.git.mche...@kernel.org/ drivers/gpu/drm/i915/gem/i915_gem_object.c | 2 ++ drivers/gpu/drm

[Intel-gfx] [PATCH 14/32] drm/i915: skl_scaler: fix return value kernel-doc markup

The way it is, it produces this warning: Documentation/gpu/i915:150: ./drivers/gpu/drm/i915/display/skl_scaler.c:213: WARNING: Block quote ends without a blank line; unexpected unindent. Use list markups to suppress the warning. Signed-off-by: Mauro Carvalho Chehab --- To avoid

[Intel-gfx] [PATCH 19/32] drm/i915: stop using kernel-doc markups for something else

There are some occurrences of "/**" that aren't actually part of a kernel-doc markup. Replace them by "/*", in order to make easier to identify what i915 files contain kernel-doc markups. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large numbe

[Intel-gfx] [PATCH 17/32] drm/i915: i915_gem_wait.c: fix a kernel-doc markup

The return codes for i915_gem_wait_ioctl() have identation issues, and will be displayed on a very confusing way. Use lists to improve its output. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00

[Intel-gfx] [PATCH 23/32] drm/i915: i915_gem.c fix a kernel-doc issue

Prevent this Sphinx warning: Documentation/foo/i915:728: ./drivers/gpu/drm/i915/i915_gem.c:447: WARNING: Inline emphasis start-string without end-string. By using @data to identify the data field, as expected by kernel-doc. Signed-off-by: Mauro Carvalho Chehab --- To avoid

[Intel-gfx] [PATCH 08/32] drm/i915: i915_gem_ttm_pm.c: fix kernel-doc markups

i915_gem_ttm_pm.c:199: warning: Excess function parameter 'allow_gpu' description in 'i915_ttm_restore_region' Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00/32] at: https://lore

[Intel-gfx] [PATCH 10/32] drm/i915: i915_gpu_error.c: document dump_flags

Kernel-doc dump_flags parameter is missing at i915_capture_error_state(). Document it. Fixes: a6f0f9cf330a ("drm/i915/guc: Plumb GuC-capture into gpu_coredump") Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on

[Intel-gfx] [PATCH 21/32] drm/i915: dvo_sil164.c: use SPDX header

This file is licensed with MIT license. Change its license text to use SPDX. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00/32] at: https://lore.kernel.org/all/cover.1657565224.git.mche

[Intel-gfx] [PATCH 05/32] drm/i915: gem: fix some Kernel-doc issues

gpu/drm/i915/gem/i915_gem_wait.c:130: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Caused by: - lack of function name at the kernel-doc markup; - renamed parameters. Address them. Signed-off-b

[Intel-gfx] [PATCH 03/32] drm/i915: gt: fix some Kernel-doc issues

rap_offset' not described in 'guc_log_buffer_state' drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:401: warning: Function parameter or member 'flush_to_file' not described in 'guc_log_buffer_state' drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:40

[Intel-gfx] [PATCH 01/32] drm/i915: fix kernel-doc trivial warnings on i915/*.[ch] files

rs/gpu/drm/i915/i915_utils.h:291: warning: Function parameter or member 'US' not described in '__wait_for' drivers/gpu/drm/i915/i915_utils.h:291: warning: Function parameter or member 'Wmin' not described in '__wait_for' drivers/gpu/drm/i915/i9

[Intel-gfx] [PATCH 04/32] drm/i915: gvt: fix kernel-doc trivial warnings

otype for intel_gvt_deactive_vgpu(). Prototype was for intel_gvt_deactivate_vgpu() instead drivers/gpu/drm/i915/gvt/vgpu.c:358: warning: expecting prototype for intel_gvt_destroy_vgpu(). Prototype was for intel_gvt_destroy_idle_vgpu() instead Signed-off-by: Mauro Carvalho Chehab --- T

[Intel-gfx] [PATCH 20/32] drm/i915: dvo_ch7xxx.c: use SPDX header

This file is licensed with MIT license. Change its license text to use SPDX. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00/32] at: https://lore.kernel.org/all/cover.1657565224.git.mche

[Intel-gfx] [PATCH v5 1/2] drm/i915/gt: Serialize GRDOM access between multiple engine resets

ure that no other GT state changes at the same time as the actual reset. Cc: sta...@vger.kernel.org # v4.4 and upper Reported-by: Mika Kuoppala Signed-off-by: Chris Wilson Acked-by: Mika Kuoppala Reviewed-by: Andi Shyti Reviewed-by: Andrzej Hajda Acked-by: Thomas Hellström Signed-off-by: Mauro

[Intel-gfx] [PATCH v5 2/2] drm/i915/gt: Serialize TLB invalidates with GT resets

the mmio access, thereby serialising with the GDRST. Tested on a NUC5i7RYB, BIOS RYBDWi35.86A.0380.2019.0517.1530 with i915 selftest/hangcheck. Cc: sta...@vger.kernel.org # v4.4 and upper Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Reported-by: Mauro Ca

[Intel-gfx] [PATCH v5 0/2] Fix TLB invalidate issues with Broadwell

i915 selftest hangcheck is causing the i915 driver timeouts, as reported by Intel CI bot: http://gfx-ci.fi.intel.com/cibuglog-ng/issuefilterassoc/24297?query_key=42a999f48fa6ecce068bc8126c069be7c31153b4 When such test runs, the only output is: [ 68.811639] i915: Performing live selftes

[Intel-gfx] [PATCH v6 0/4] Let userspace know when snd-hda-intel needs i915

a single line for the new function prototype. v2: - the dependencies are now handled directly at try_module_get(). Mauro Carvalho Chehab (4): module: drop prototype for non-existing __symbol_get_gpl() module: update dependencies at try_module_get() module: set holders when symbol_get() is used

[Intel-gfx] [PATCH v6 1/4] module: drop prototype for non-existing __symbol_get_gpl()

There's no such function, and __symbol_get() is already declared as GPL. So, this is likely a left-over. Signed-off-by: Mauro Carvalho Chehab --- See [PATCH v6 0/4] at: https://lore.kernel.org/all/cover.1652113087.git.mche...@kernel.org/ include/linux/module.h | 1 - 1 file chang

[Intel-gfx] [PATCH v6 2/4] module: update dependencies at try_module_get()

-by: Greg Kroah-Hartman Signed-off-by: Mauro Carvalho Chehab --- See [PATCH v6 0/4] at: https://lore.kernel.org/all/cover.1652113087.git.mche...@kernel.org/ include/linux/module.h | 8 +++-- kernel/module/main.c | 73 ++ 2 files changed, 64 insertions

  1   2   3   4   >