Hi,
On 06/05/2021 22:13, Matthew Brost wrote:
Basic GuC submission support. This is the first bullet point in the
upstreaming plan covered in the following RFC [1].
At a very high level the GuC is a piece of firmware which sits between
the i915 and the GPU. It offloads some of the scheduling of
On 10/05/2021 02:11, Jason Ekstrand wrote:
On May 9, 2021 12:12:36 Martin Peres wrote:
Hi,
On 06/05/2021 22:13, Matthew Brost wrote:
Basic GuC submission support. This is the first bullet point in the
upstreaming plan covered in the following RFC [1].
At a very high level the GuC is a
On 11/05/2021 05:58, Dixit, Ashutosh wrote:
On Sun, 09 May 2021 16:11:43 -0700, Jason Ekstrand wrote:
Yes, landing GuC support may be the first step in removing execlist
support. The inevitable reality is that GPU scheduling is coming and
likely to be there only path in the not-too-distant f
On 10/05/2021 19:25, Jason Ekstrand wrote:
On May 10, 2021 08:55:55 Martin Peres wrote:
On 10/05/2021 02:11, Jason Ekstrand wrote:
On May 9, 2021 12:12:36 Martin Peres wrote:
Hi,
On 06/05/2021 22:13, Matthew Brost wrote:
Basic GuC submission support. This is the first bullet point in
On 10/05/2021 19:33, Daniel Vetter wrote:
On Mon, May 10, 2021 at 3:55 PM Martin Peres wrote:
On 10/05/2021 02:11, Jason Ekstrand wrote:
On May 9, 2021 12:12:36 Martin Peres wrote:
Hi,
On 06/05/2021 22:13, Matthew Brost wrote:
Basic GuC submission support. This is the first bullet point
On 11/05/2021 19:39, Matthew Brost wrote:
On Tue, May 11, 2021 at 08:26:59AM -0700, Bloomfield, Jon wrote:
-Original Message-
From: Martin Peres
Sent: Tuesday, May 11, 2021 1:06 AM
To: Daniel Vetter
Cc: Jason Ekstrand ; Brost, Matthew
; intel-gfx ;
dri-devel ; Ursulin, Tvrtko
On 29/06/2021 22:35, Matthew Brost wrote:
Add entry for i915 GuC submission / DRM scheduler integration plan.
Follow up patch with details of new parallel submission uAPI to come.
v2:
(Daniel Vetter)
- Expand explaination of why bonding isn't supported for GuC
submission
- CC some o
On 24/06/2021 10:05, Matthew Brost wrote:
From: Daniele Ceraolo Spurio
Unblock GuC submission on Gen11+ platforms.
Signed-off-by: Michal Wajdeczko
Signed-off-by: Daniele Ceraolo Spurio
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/i915/gt/uc/intel_guc.h| 1 +
drivers/g
On 29/06/2021 22:35, Matthew Brost wrote:
Add entry for i915 new parallel submission uAPI plan.
v2:
(Daniel Vetter):
- Expand logical order explaination
- Add dummy header
- Only allow N BBs in execbuf IOCTL
- Configure parallel submission per slot not per gem context
v3:
(Marcin
On 30/06/2021 21:00, Matthew Brost wrote:
On Wed, Jun 30, 2021 at 11:22:38AM +0300, Martin Peres wrote:
On 24/06/2021 10:05, Matthew Brost wrote:
From: Daniele Ceraolo Spurio
Unblock GuC submission on Gen11+ platforms.
Signed-off-by: Michal Wajdeczko
Signed-off-by: Daniele Ceraolo Spurio
On 01/07/2021 11:14, Pekka Paalanen wrote:
On Wed, 30 Jun 2021 11:58:25 -0700
John Harrison wrote:
On 6/30/2021 01:22, Martin Peres wrote:
On 24/06/2021 10:05, Matthew Brost wrote:
From: Daniele Ceraolo Spurio
Unblock GuC submission on Gen11+ platforms.
Signed-off-by: Michal Wajdeczko
On 02/07/2021 10:29, Pekka Paalanen wrote:
On Thu, 1 Jul 2021 21:28:06 +0200
Daniel Vetter wrote:
On Thu, Jul 1, 2021 at 8:27 PM Martin Peres wrote:
On 01/07/2021 11:14, Pekka Paalanen wrote:
On Wed, 30 Jun 2021 11:58:25 -0700
John Harrison wrote:
On 6/30/2021 01:22, Martin Peres
On 01/07/2021 21:24, Martin Peres wrote:
[...]
+ i915->params.enable_guc = ENABLE_GUC_LOAD_HUC;
+ return;
+ }
+
+ /* Default: enable HuC authentication and GuC submission */
+ i915->params.enable_guc = ENABLE_GUC_LOAD_HUC |
ENABLE_GUC_SUBMISSION;
This seems to
On 02/07/2021 16:06, Michal Wajdeczko wrote:
On 02.07.2021 10:13, Martin Peres wrote:
On 01/07/2021 21:24, Martin Peres wrote:
[...]
+ i915->params.enable_guc = ENABLE_GUC_LOAD_HUC;
+ return;
+ }
+
+ /* Default: enable HuC authentication and GuC submiss
On 02/07/2021 18:07, Michal Wajdeczko wrote:
On 02.07.2021 10:09, Martin Peres wrote:
On 02/07/2021 10:29, Pekka Paalanen wrote:
On Thu, 1 Jul 2021 21:28:06 +0200
Daniel Vetter wrote:
On Thu, Jul 1, 2021 at 8:27 PM Martin Peres
wrote:
On 01/07/2021 11:14, Pekka Paalanen wrote:
On Wed
On 16/05/2019 16:18, Shankar, Uma wrote:
>
>
>>>
-Original Message-
From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com]
Sent: Thursday, May 16, 2019 1:02 AM
To: Shankar, Uma
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: fai
On 23/05/2019 16:08, Imre Deak wrote:
> An IO failure happens if the sink is unplugged. This scenario shouldn't
> be logged with error level, since it is not a user visible problem.
> Converting the corresponding error messages to be debug messages also
> ensures that we don't fail some CI test inc
On 11/04/2019 11:44, Michal Wajdeczko wrote:
> Some CI systems might be configured to run with no longer supported
> configuration "enable_guc=3" or "enable_guc=1". Hack that ;)
This is not a hack, this is what we need to do: Users put parameters in
their command line and forget about them, myself
On 11/04/2019 11:44, Michal Wajdeczko wrote:
> Due to the upcoming changes to the GuC ABI interface, we must
> disable GuC submission mode until final ABI will be available
> on all GuC firmwares.
If I understand correctly, you are disabling command submission by
returning -EIO, which leads to the
urio
> Cc: John Spotswood
> Cc: Vinay Belgaumkar
> Cc: Tony Ye
> Cc: Anusha Srivatsa
> Cc: Jeff Mcgee
> Cc: Antonio Argenziano
> Cc: Sujaritha Sundaresan
> Cc: Martin Peres
Thanks for the update! This will also allow you to drop the HAX patch
(patch 22/22) :)
Acked
On 20/04/2019 20:24, Noralf Trønnes wrote:
>
>
> Den 20.04.2019 12.45, skrev Noralf Trønnes:
>> This moves the modesetting code from drm_fb_helper to drm_client so it
>> can be shared by all internal clients.
>>
>> Changes this time:
>> - Use full drm_client_init/release for the modesets (Daniel
On 29/11/2018 19:36, Rodrigo Vivi wrote:
> On Wed, Nov 28, 2018 at 11:52:49PM -0800, Saarinen, Jani wrote:
>> Hi,
>>
>>> -Original Message-
>>> From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf
>>> Of
>>> Rodrigo Vivi
>>> Sent: torstai 29. marraskuuta 2018 8.18
listing such pertinent information,
> so add the iommu status.
>
> Suggested-by: Martin Peres
> Signed-off-by: Chris Wilson
> Cc: Martin Peres
> Cc: Tomi Sarvela
> Cc: Mika Kuoppala
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 7 +++
> 1 file changed, 7
> Signed-off-by: Chris Wilson
> Cc: Mika Kuoppala
> Cc: Martin Peres
> ---
> tests/i915/gem_mmap_gtt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> index ac439cdf8..e2c6ad9a0 100644
&g
f I am not, then let's hold the merging of this patch :)
Martin
>
> Signed-off-by: Chris Wilson
> Cc: Ville Syrjälä
> Cc: Martin Peres
> ---
> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 7 ---
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu
On 18/09/2019 23:28, Summers, Stuart wrote:
> On Wed, 2019-09-18 at 19:31 +, Patchwork wrote:
>> == Series Details ==
>>
>> Series: drm/i915: Allow set context SSEU on platforms after gen 11
>> URL : https://patchwork.freedesktop.org/series/66870/
>> State : success
>>
>> == Summary ==
>>
>>
On 28/05/2019 12:45, Chris Wilson wrote:
> Quoting Petri Latvala (2019-05-28 10:40:31)
>> On Tue, May 28, 2019 at 10:23:24AM +0100, Chris Wilson wrote:
>>> Quoting Michal Wajdeczko (2019-05-27 19:35:56)
New GuC firmwares (for SKL, BXT, KBL, GLK, ICL) with updated ABI interface.
>>>
>>> All rev
gt; Cc: Mika Kuoppala
> Cc: Martin Peres
> ---
> tests/i915/gem_mmap_gtt.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> index 034658e64..c3cb5db2d 100644
> --- a/tests/i915/gem_mmap_gtt.c
> ++
On 27/06/2019 16:26, Arkadiusz Hiler wrote:
> On Thu, Jun 27, 2019 at 08:18:36AM +, Ser, Simon wrote:
>> On Thu, 2019-06-27 at 08:36 +0100, Chris Wilson wrote:
>>> The "basic" subtests perform no verification that the read/write work,
>>> only function as mere API exercisers and loose benchmark
On 30/09/2019 19:13, Matt Roper wrote:
> CRTC background color kernel patches were written about 2.5 years ago
> and floated on the upstream mailing list, but since no opensource
> userspace materialized, we never actually merged them. However the
> corresponding IGT test did get merged and has ba
On 28/09/2019 00:42, Daniele Ceraolo Spurio wrote:
> To better organize the information, add a microcontrollers section and
> move/link the GuC, HuC and DMC documentation under it. Also add a small
> intro.
>
> Signed-off-by: Daniele Ceraolo Spurio
Reviewed-by: Martin Peres
On 28/09/2019 00:42, Daniele Ceraolo Spurio wrote:
> Add a short description of what we expect from GuC and some minor
> improvements to existing documentation. Also remove a comment about a
> difference between GuC and HuC that is not true anymore.
>
> Signed-off-by: Daniele Ceraolo Spurio
> Cc:
On 28/09/2019 00:42, Daniele Ceraolo Spurio wrote:
> Better explain the usage of the microcontroller and what i915 is
> responsible of. While at it, fix the documentation for the auth
> function, which doesn't do any pinning anymore.
>
> Signed-off-by: Daniele Ceraolo Spurio
> Cc: Michal Wajdeczk
s not mandatory (Martin)
>
> Signed-off-by: Daniele Ceraolo Spurio
> Cc: Michal Wajdeczko
> Cc: Matthew Brost
> Cc: Martin Peres
> Acked-by: Anna Karas
> ---
> Documentation/gpu/i915.rst| 22 +-
> drivers/gpu/drm/i915/gt/uc/intel_guc.c
nal and descrive how HuC accesses
> memory (Martin)
>
> Signed-off-by: Daniele Ceraolo Spurio
> Cc: Michal Wajdeczko
> Cc: Martin Peres
> Acked-by: Anna Karas
> ---
> Documentation/gpu/i915.rst| 16 +--
> drivers/gpu/drm/i915/gt/uc/intel_h
On 10/10/2019 23:18, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [1/4] drm/i915/display: Handle fused off display
> correctly
> URL : https://patchwork.freedesktop.org/series/67872/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7058 -> P
This reflects the fact that freedesktop.org's bugzilla instance is no
more, and bugs got migrated to gitlab.freedesktop.org/drm/intel.
Signed-off-by: Martin Peres
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index c6278fa
Freedesktop's Bugzilla instance is no more, and bugs have been migrated
to gitlab.freedesktop.org/drm/intel.
The instructions also moved from 01.org to fd.o's gitlab to make it
easier to keep up to date.
This patch updates the link presented to the user after a GPU hang.
Signed-off-
Hi,
Sorry for the delay, I was on vacation. The machine fi-skl-6770hq was
not marked as having an LSPCON. This is now done, and this means that
this issue should be covered by ab existing bug.
I queued another run, and we'll see if it gives us a green (new tests
don't need to pass on all machines
On 18/08/2019 18:51, Michal Wajdeczko wrote:
> We hope that now all issues related to missing uC firmwares
> are fixed and that driver can continue to load without GuC
> or HuC firmware available and running:
>
> - missing or corrupted HuC firmware has no impact to driver
>load (clients shoul
On 19/08/2019 21:22, Lucas De Marchi wrote:
> On Mon, Aug 19, l we need is to add2019 at 4:15 AM Michal Wajdeczko
> wrote:
>>
>> On Mon, 19 Aug 2019 10:09:15 +0200, Martin Peres
>> wrote:
>>
>>> On 18/08/2019 18:51, Michal Wajdeczko wrote:
>>>>
-by: Chris Wilson
> Cc: Martin Peres
The only difference between the previous behaviour and the new one
introduced by the patch is that reset_stress() is called for only the
default exec engine as opposed to all of them previously. So, the patch is:
Reviewed-by: Martin Peres
> ---
On 2020-02-20 18:57, Chris Wilson wrote:
> Convert from using a fixed number of iterations (1 million), to using a
> fixed runtime so that we have predictable (and shorter!) run times across
> a wide variety of machines.
>
> Signed-off-by: Chris Wilson
> Cc: Martin Peres
Than
hich apparently is one of the better
> behaving systems).
>
> Signed-off-by: Chris Wilson
> Cc: Martin Peres
I don't like this patch because the first read might not have the gpu
suspended, and there shouldn't be much overhead in checking twice rather
than once.
What
On 2020-02-21 10:21, Chris Wilson wrote:
> Quoting Martin Peres (2020-02-21 07:33:59)
>> On 2020-02-20 19:41, Chris Wilson wrote:
>>> Since we check before and then after each debugfs entry, we do not need
>>> to check before each time as well. We will error out as soon
hich apparently is one of the better
> behaving systems).
>
> v2: Assert that we are currently suspended prior to opening the file,
> i.e. that nothing else is waking up the device behind our backs.
>
> Signed-off-by: Chris Wilson
> Cc: Martin Peres
This changes the pur
> case.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/1289
> Signed-off-by: Chris Wilson
> Cc: Martin Peres
I can't review easily that what Chris' statement that
gem_exec_parallel/gem_exec_whisper are testing a superset of
gem_exec_reuse, but I can agree with
On 17/04/18 11:00, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/audio: Fix audio detection issue on GLK (rev2)
> URL : https://patchwork.freedesktop.org/series/41334/
> State : failure
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_4058 -> Patchwork_8701 =
>
> == S
On 16/04/18 14:45, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/gvt: Deliver guest cursor hotspot info (rev2)
> URL : https://patchwork.freedesktop.org/series/41727/
> State : failure
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_4054_full -> Patchwork_8694_full =
>
On 20/04/18 19:55, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [1/2] drm/i915: Use ktime on wait_for
> URL : https://patchwork.freedesktop.org/series/42035/
> State : failure
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_4072_full -> Patchwork_8764_full
On 29/10/2018 13:55, Patchwork wrote:
> == Series Details ==
>
> Series: Implement HDCP2.2: PART-I (rev2)
> URL : https://patchwork.freedesktop.org/series/51495/
> State : failure
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_5044_full -> Patchwork_10620_full =
>
> == Summary - F
On 05/11/2018 15:42, Imre Deak wrote:
> On Sat, Nov 03, 2018 at 12:45:01AM +, Patchwork wrote:
>> == Series Details ==
>>
>> Series: drm/i915/icl: Fix suspend/resume for TypeC HDMI
>> URL : https://patchwork.freedesktop.org/series/51976/
>> State : failure
>
> The failures are unrelated si
people it'll take a while to get there. For now this is good enough I
think.
All true.
Reviewed-by: Daniel Stone
Thanks for this, Daniel!
Reviewed-by: Sumit Semwal
Acked-by: Archit Taneja
Thanks for doing this, this was long overdue!
Reviewed-by: Martin
On 12/04/17 15:31, Peter Zijlstra wrote:
On Wed, Apr 12, 2017 at 12:04:00PM +, Lofstedt, Marta wrote:
Hi,
We have this "old" Lenovo Cantiga laptop(Intel Core 2 Duo L9400), hocked up to
our i915 pre-merge CI system, that has started to give unstable results after commit:
commit 7b09cc5a9
On 31/03/17 12:37, Martin Peres wrote:
On 30/03/17 08:39, Zhang, Xiong Y wrote:
On Wed, Mar 29, 2017 at 05:02:47PM +0800, Xiong Zhang wrote:
In a virtual passthrough environment, the ISA bridge isn't able to
be passed through. So pch_id couldn't be gotten from ISA bridge, but
pch_
On 12/04/17 17:32, Peter Zijlstra wrote:
On Wed, Apr 12, 2017 at 04:40:11PM +0300, Martin Peres wrote:
So, why is this only affecting the Core 2 Duo?
Core2 doesn't have a usable TSC and would revert to the slow path. I'll
have another look at that patch.
So, by default, it is
On 13/04/17 14:48, Peter Zijlstra wrote:
On Wed, Apr 12, 2017 at 05:49:53PM +0300, Martin Peres wrote:
Good to know. Is there a way to disable this behaviour, as a workaround for
our CI system until a proper fix lands? We already pushed locally the revert
for this patch, but that may affect
On 18/04/17 12:14, Dan Carpenter wrote:
On Tue, Apr 18, 2017 at 10:58:44AM +0300, Jani Nikula wrote:
On Mon, 17 Apr 2017, Dan Carpenter wrote:
On Fri, Apr 14, 2017 at 08:13:43PM -, Patchwork wrote:
== Series Details ==
Series: drm/i915: uninitialized value on error path (rev3)
URL : ht
e, improving debuggability"
With the commit title and the typo fixed, the patch is:
Acked-by: Martin Peres
Signed-off-by: Marta Lofstedt
---
tests/Makefile.sources| 1 +
tests/initial_state.c | 52 +++
tests/intel-ci/ext
On 03/10/2018 12:34, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Fix the HDMI hot plug disconnection failure
> URL : https://patchwork.freedesktop.org/series/50477/
> State : failure
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_4916_full -> Patchwork_10333_full =
On 03/10/2018 11:38, Patchwork wrote:
> == Series Details ==
>
> Series: drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE
> URL : https://patchwork.freedesktop.org/series/50462/
> State : failure
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_4915_full -> Patchwork_10330_full =
>
>
On 03/10/2018 11:29, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Rename full ppgtt configuration to be more generic (rev5)
> URL : https://patchwork.freedesktop.org/series/49021/
> State : failure
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_4915_full -> Patchwo
On 03/10/2018 09:24, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/selftests: Hold task_struct ref for smoking kthread
> URL : https://patchwork.freedesktop.org/series/50441/
> State : failure
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_4915_full -> Patchwork_1032
On 03/10/2018 05:47, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [1/4] drm/i915: Replace some open-coded
> i915_map_coherent_type() (rev2)
> URL : https://patchwork.freedesktop.org/series/50408/
> State : failure
>
> == Summary ==
>
> = CI Bug Log - changes from C
On 23/10/2018 08:42, C, Ramalingam wrote:
>
> On 10/22/2018 10:47 PM, Patchwork wrote:
>> == Series Details ==
>>
>> Series: Enabling the IGT for HDCP1.4 (rev4)
>> URL : https://patchwork.freedesktop.org/series/51113/
>> State : failure
>>
>> == Summary ==
>>
>> = CI Bug Log - changes from CI_DR
der.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106989
>> Signed-off-by: Chris Wilson
>> Cc: Zhi Wang
>
> Martin, would you care to ack?
ACK, since we have no tests for GVT-d anyway, we can consider it is
broken by default:
Acked-by: Martin Peres
Zhi,
hat!
Acked-by: Martin Peres
>
> Signed-off-by: Chris Wilson
> ---
> kernel/panic.c | 15 ---
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/kernel/panic.c b/kernel/panic.c
> index 8b2e002d52eb..c0334516cb15 100644
> --- a/kernel/panic.c
&
On 07/09/2018 14:37, Patchwork wrote:
> == Series Details ==
>
> Series: Add XYUV format support (rev6)
> URL : https://patchwork.freedesktop.org/series/48007/
> State : failure
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_4786_full -> Patchwork_10123_full =
>
> == Summary - FAI
On 02/06/16 08:18, sourab.gu...@intel.com wrote:
From: Sourab Gupta
This patch introduces a framework to enable OA counter reports associated
with Render command stream. We can then associate the reports captured
through this mechanism with their corresponding context id's. This can be
further
On 21/01/16 04:26, tom.orou...@intel.com wrote:
From: Tom O'Rourke
SLPC (Single Loop Power Controller) is a replacement for
some host-based power management features. The SLPC
implemenation runs in firmware on GuC.
This series is a first request for comments. This series
is not expected to b
On 26/01/16 19:00, Daniel Vetter wrote:
On Tue, Jan 26, 2016 at 07:45:42AM -0800, Jesse Barnes wrote:
On 01/22/2016 09:00 AM, Daniel Vetter wrote:
On Wed, Jan 20, 2016 at 06:26:02PM -0800, tom.orou...@intel.com wrote:
From: Tom O'Rourke
I'd say we need to keep the boost-deboost stuff alive,
On 10/02/16 09:37, Daniel Vetter wrote:
On Tue, Feb 09, 2016 at 02:08:23PM +0200, Martin Peres wrote:
On 26/01/16 19:00, Daniel Vetter wrote:
On Tue, Jan 26, 2016 at 07:45:42AM -0800, Jesse Barnes wrote:
On 01/22/2016 09:00 AM, Daniel Vetter wrote:
On Wed, Jan 20, 2016 at 06:26:02PM -0800
Caught by Klockwork.
Signed-off-by: Martin Peres
---
src/uxa/intel_display.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/uxa/intel_display.c b/src/uxa/intel_display.c
index 8bf0184..44744a5 100644
--- a/src/uxa/intel_display.c
+++ b/src/uxa/intel_display.c
@@ -688,6 +688,11
Caught by Klockwork and I genuinely can't tell if it is safe without
it, especially since all the surrounding code is checking for NULL.
Signed-off-by: Martin Peres
---
src/sna/sna_accel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/sna/sna_accel.c b/sr
I got lost in all the changes done on priv->flush and gpu_bo enough
not to be able to guarantee that if flush is non-null, so is gpu_bo.
Caught by Klockwork.
Signed-off-by: Martin Peres
---
src/sna/sna_accel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/sna/sna_accel.c b/src/
Caught by Klockwork.
Signed-off-by: Martin Peres
---
src/sna/sna_accel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/sna/sna_accel.c b/src/sna/sna_accel.c
index 8ceb1e1..f1c136a 100644
--- a/src/sna/sna_accel.c
+++ b/src/sna/sna_accel.c
@@ -4376,6 +4376,7 @@ sna_pixmap_move_to_gpu
Caught by Klockwork. This will be enough to catch those issues during
bringup.
Signed-off-by: Martin Peres
---
src/sna/sna_video_sprite.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/sna/sna_video_sprite.c b/src/sna/sna_video_sprite.c
index 9e85049..ae08ef7 100644
--- a/src/sna
Caught by Klockwork, but it was a false positive. However, better safe
than sorry.
Signed-off-by: Martin Peres
---
src/sna/sna_display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/sna/sna_display.c b/src/sna/sna_display.c
index 9215b23..78937c2 100644
--- a/src
This is not a big issue to return -1 since the only codepath that uses
it is for display purposes.
Caught by Klockwork.
Signed-off-by: Martin Peres
---
src/intel_device.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/intel_device.c b/src/intel_device.c
index
The DDX clearly is making Klockwork unhappy but I found those potential
issues. Let's use them as a basis for discussion on the real code that
should be written.
Martin Peres (7):
device: prevent a NULL pointer dereference in __intel_peek_fd
display: prevent a NULL pointer dereferen
On 15/02/16 14:24, Dave Gordon wrote:
On 12/02/16 16:31, Martin Peres wrote:
This is not a big issue to return -1 since the only codepath that uses
it is for display purposes.
Caught by Klockwork.
Signed-off-by: Martin Peres
---
src/intel_device.c | 5 -
1 file changed, 4 insertions
On 15/02/16 15:47, Dave Gordon wrote:
On 15/02/16 13:40, Martin Peres wrote:
On 15/02/16 14:24, Dave Gordon wrote:
On 12/02/16 16:31, Martin Peres wrote:
This is not a big issue to return -1 since the only codepath that uses
it is for display purposes.
Caught by Klockwork.
Signed-off-by
On 16/02/16 10:54, Dave Gordon wrote:
On 15/02/16 15:56, Martin Peres wrote:
On 15/02/16 15:47, Dave Gordon wrote:
On 15/02/16 13:40, Martin Peres wrote:
On 15/02/16 14:24, Dave Gordon wrote:
On 12/02/16 16:31, Martin Peres wrote:
This is not a big issue to return -1 since the only codepath
On 09/03/16 11:09, akash.g...@intel.com wrote:
From: Akash Goel
A new libdrm interface 'drm_intel_gem_bo_map_wc' is provided by this
patch. Through this interface Gfx clients can create write combining
virtual mappings of the Gem object. It will provide the same funtionality
of 'mmap_gtt' inter
On 10/03/16 10:39, Martin Peres wrote:
On 09/03/16 11:09, akash.g...@intel.com wrote:
From: Akash Goel
A new libdrm interface 'drm_intel_gem_bo_map_wc' is provided by this
patch. Through this interface Gfx clients can create write combining
virtual mappings of the Gem object. It wi
On 20/04/16 17:23, Robert Bragg wrote:
Gen graphics hardware can be set up to periodically write snapshots of
performance counters into a circular buffer via its Observation
Architecture and this patch exposes that capability to userspace via the
i915 perf interface.
Cc: Chris Wilson
Signed-off
On 03/05/16 22:34, Robert Bragg wrote:
Sorry for the delay replying to this, I missed it.
No worries!
On Sat, Apr 23, 2016 at 11:34 AM, Martin Peres mailto:martin.pe...@free.fr>> wrote:
On 20/04/16 17:23, Robert Bragg wrote:
Gen graphics hardware can be set up to period
On 03/05/16 23:03, Robert Bragg wrote:
On Tue, May 3, 2016 at 8:34 PM, Robert Bragg mailto:rob...@sixbynine.org>> wrote:
Sorry for the delay replying to this, I missed it.
On Sat, Apr 23, 2016 at 11:34 AM, Martin Peres mailto:martin.pe...@free.fr>> wrote:
On 20
On 06/10/16 13:26, Conselvan De Oliveira, Ander wrote:
On Thu, 2016-10-06 at 13:11 +0300, Jani Nikula wrote:
On Wed, 05 Oct 2016, "Argotti, Yann" wrote:
On Mon, 03 Oct 2016, Jairo Miramontes
wrote:
This week regressions
In the past we used "regression", "bisect_pending", and "bisected
On 06/04/16 22:24, tom.orou...@intel.com wrote:
From: Tom O'Rourke
Update sysfs and debugfs functions to set SLPC
parameters when setting max/min frequency.
v2: Update for SLPC 2015.2.4 (params for both slice and unslice)
Replace HAS_SLPC with intel_slpc_active() (Paulo)
Thanks for doin
On 07/02/17 15:22, Uwe Kleine-König wrote:
Hello,
On 02/01/2017 03:37 PM, Ville Syrjälä wrote:
On Wed, Feb 01, 2017 at 01:41:08PM +0100, Maarten Lankhorst wrote:
Op 31-01-17 om 20:13 schreef Uwe Kleine-König:
On Tue, Jan 31, 2017 at 10:03:26AM +0100, Maarten Lankhorst wrote:
Op 31-01-17 om 0
On 27/10/15 12:24, Russell King - ARM Linux wrote:
In passing, while reading the Intel DDX driver code, I've noticed
that the Intel driver contains code which assumes that the master and
render devices are related by minor device number, eg:
/* Are we a render-node ourselves? */
On 26/05/17 14:48, Chris Wilson wrote:
If we do a shallow probe of the connector and it reports the link failed
previous (link-status != GOOD), force a full probe of the connector to
give the kernel a chance to validate the mode list.
Sounds good, but will this make the tests SKIP if no modes a
On 31/05/17 15:42, Chris Wilson wrote:
On Wed, May 31, 2017 at 01:40:00PM +0300, Martin Peres wrote:
On 26/05/17 14:48, Chris Wilson wrote:
If we do a shallow probe of the connector and it reports the link failed
previous (link-status != GOOD), force a full probe of the connector to
give the
On 31/05/17 16:55, Chris Wilson wrote:
On Wed, May 31, 2017 at 04:44:41PM +0300, Martin Peres wrote:
On 31/05/17 15:42, Chris Wilson wrote:
On Wed, May 31, 2017 at 01:40:00PM +0300, Martin Peres wrote:
On 26/05/17 14:48, Chris Wilson wrote:
If we do a shallow probe of the connector and it
On 01/06/17 09:02, Daniel Kasak wrote:
Any news? Seems every TV I bump into these days has Miracast support ...
Sorry, it must be frustrating. Some code needs to be re-implemented
because it was GPL-based and we need it as MIT. Until I have some time
to do this, this will probably not move fo
On 07/06/17 13:34, Chris Wilson wrote:
This reverts commit 7c8703fb02b248c2bcf9756bba8812bcfe7ed5d3.
If we expect it to fail until we find a solution, let the hw fail and
continue to track the known failure in CI/bugs.
Cc: Martin Peres
I agree, the kernel/HW is broken.
However, this fix is
On 31/05/17 17:45, Martin Peres wrote:
On 31/05/17 16:55, Chris Wilson wrote:
On Wed, May 31, 2017 at 04:44:41PM +0300, Martin Peres wrote:
On 31/05/17 15:42, Chris Wilson wrote:
On Wed, May 31, 2017 at 01:40:00PM +0300, Martin Peres wrote:
On 26/05/17 14:48, Chris Wilson wrote:
If we do a
On 07/06/17 14:33, Chris Wilson wrote:
Quoting Martin Peres (2017-06-07 12:13:24)
How about this: When the modeset call fails, check if the link-status is
BAD. If not, return a FAIL. If so, force a full re-probe, pick the
highest available mode and try again. Do this until a mode applies. If
no
I would like to send this patch to the core-for-CI branch, in order to
verify the theory I exposed in fdo#101246.
This patch also hides a potentially serious bug in the sound/hda
driver, which may improve our chances of not being affected by
bugs there. It may actually also fix some of the incompl
1 - 100 of 134 matches
Mail list logo
