ducts.
> To
> +of course we'd better share as much as possible between different products.
> To
> achieve this, split the komeda device into two layers: CORE and CHIP.
>
> - CORE: for common features and capabilities handling.
Acked-by: Liviu D
R_LEGACY)))
> > >
> > > return dev->irq_enabled;
> > >
> > > #endif
> > > return drm_dev_has_vblank(dev);
> > >
> > > }
> > >
> > >
> > > ?
> > >
> &g
nit
>
> this is done automatically as part of plane init, if drivers set the
> modifier list correctly. Which is the case here for both komeda and
> malidp.
>
> Signed-off-by: Daniel Vetter
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
Acked-by: Liviu Dudau
Best rega
On Tue, Apr 27, 2021 at 11:20:12AM +0200, Daniel Vetter wrote:
> Even when all we support is linear, make that explicit. Otherwise the
> uapi is rather confusing.
:)
>
> Cc: sta...@vger.kernel.org
> Cc: Pekka Paalanen
> Cc: Liviu Dudau
> Cc: Brian Starkey
> Sign
Hi Uma,
On Tue, Jan 08, 2019 at 02:41:20PM +0530, Uma Shankar wrote:
> Hardware may have HDR capability on certain plane
> engines. Enabling the same in drm plane structure
> so that this can be communicated to user space.
>
> Each drm driver should set this flag to true for planes
> which suppor
On Tue, Jan 08, 2019 at 02:41:16PM +0530, Uma Shankar wrote:
> This patch adds a blob property to get HDR metadata
> information from userspace. This will be send as part
> of AVI Infoframe to panel.
>
> v2: Rebase and modified the metadata structure elements
> as per Ville's POC changes.
>
> v3:
(which can take advantage of word-access speedup), we can do the hash
on a cached copy, which is much faster (10x speedup on my platform).
Signed-off-by: Brian Starkey
[rebased and updated to the most recent API]
Signed-off-by: Liviu Dudau
---
lib/igt_fb.c | 66
From: Brian Starkey
An output can be added as a clone of any other output(s) attached to a
pipe using igt_output_clone_pipe()
Signed-off-by: Brian Starkey
---
lib/igt_kms.c | 100 +++---
lib/igt_kms.h | 5 +++
2 files changed, 67 insertions(+), 38
From: Brian Starkey
Add support in igt_kms for writeback connectors, with the ability
to attach framebuffers.
Signed-off-by: Brian Starkey
[rebased and updated to the latest igt style]
Signed-off-by: Liviu Dudau
---
lib/igt_kms.c | 57 +++
lib
]
Signed-off-by: Liviu Dudau
---
tests/kms_writeback.c | 64 +++
1 file changed, 59 insertions(+), 5 deletions(-)
diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
index 0f20dadd2..ae536bbfa 100644
--- a/tests/kms_writeback.c
+++ b/tests
We're trying to introduce support for writeback connectors, a way to
expose in DRM the hardware functionality from display engines that
allows to write back into memory the result of the DE's composition
of supported planes.
Although this is a rebase of v4 with all the comments addressed, I'm not
: Liviu Dudau
---
tests/Makefile.sources | 1 +
tests/kms_writeback.c | 314 +
tests/meson.build | 1 +
3 files changed, 316 insertions(+)
create mode 100644 tests/kms_writeback.c
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index
From: Brian Starkey
Add a test which makes commits using the writeback connector, and
checks the output buffer hash to make sure it is/isn't written as
appropriate.
Signed-off-by: Brian Starkey
---
tests/kms_writeback.c | 124 ++
1 file changed, 124 inse
On Tue, Jan 15, 2019 at 06:47:47PM +, Chris Wilson wrote:
> Quoting Liviu Dudau (2019-01-15 17:47:44)
> > +int igt_fb_get_crc(struct igt_fb *fb, igt_crc_t *crc)
> > +{
> > +#define FNV1a_OFFSET_BIAS 2166136261
> > +#define FNV1a_PRIME 16777619
> > + uin
API]
Signed-off-by: Liviu Dudau
---
lib/igt_fb.c | 66
lib/igt_fb.h | 3 +++
2 files changed, 69 insertions(+)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 5cd1829a3..044fd57de 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -2379,6 +2379,72
> + DRM_ROTATE_0);
>
> drm_plane_helper_add(&plane->base,
>&malidp_de_plane_helper_funcs);
This patch touches arm/mali-dp driver but the maintainers have not been Cc-ed
in the pat
; Signed-off-by: Maarten Lankhorst
> Cc: Liviu Dudau
Acked-by: Liviu Dudau
If you need me to take this patch into malidp tree let me know,
otherwise I expect is going to show up in drm-misc-next at some moment.
Best regards,
Liviu
> Cc: Brian Starkey
> ---
> drivers/gpu
play->drm_fd);
> igt_assert(plane_resources);
>
> I'm not 100% confident about this issue, because of this I will send an
> RFC and see if I can get more details about this issue.
It actually looks correct to me, so
Acked-by: Liviu Dudau
>
> Additionally, if
On Mon, Mar 18, 2019 at 07:05:29PM -0300, Rodrigo Siqueira wrote:
> On 03/18, Liviu Dudau wrote:
> > On Wed, Mar 06, 2019 at 06:30:05PM -0300, Rodrigo Siqueira wrote:
> > > Hi Liviu,
> > >
> > > I’m using your patchset to guide my implementation of writeback
/komeda/Makefile
> b/drivers/gpu/drm/arm/display/komeda/Makefile
> index 1b875e5..a72e30c 100644
> --- a/drivers/gpu/drm/arm/display/komeda/Makefile
> +++ b/drivers/gpu/drm/arm/display/komeda/Makefile
> @@ -1,8 +1,8 @@
> # SPDX-License-Identifier: GPL-2.0
>
> ccflags-y
Eric Anholt
> Cc: Maarten Lankhorst
> Cc: Harry Wentland
> Cc: Leo Li
> Cc: amd-...@lists.freedesktop.org
> Cc: James (Qian) Wang
> Cc: Liviu Dudau
> Cc: Mali DP Maintainers
> Cc: CK Hu
> Cc: Philipp Zabel
> Cc: Yannick Fertre
> Cc: Philippe Cornu
>
On Wed, Jun 12, 2019 at 11:16:02PM -0300, Brian Starkey wrote:
> Add support in igt_kms for writeback connectors, with the ability
> to attach framebuffers.
>
> v5: Rebase and add DRM_CLIENT_CAP_WRITEBACK_CONNECTORS before
> drmModeGetResources()
Reviewed-by: Liviu Dudau
Than
On Fri, Jun 14, 2019 at 10:35:23PM +0200, Daniel Vetter wrote:
> Read the docs, komeda is not an old enough driver for this :-)
>
> Signed-off-by: Daniel Vetter
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
Acked-by: Liviu Dudau
I'm assuming the whole series goe
On Fri, Jun 14, 2019 at 10:35:27PM +0200, Daniel Vetter wrote:
> They're the default.
>
> Aside: Would be really nice to switch the others over to
> drm_gem_object_funcs.
>
> Signed-off-by: Daniel Vetter
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
>
patchset made by
> Brian Starkey and Liviu Dudau for adding a writeback connectors test to
> IGT. It is important to highlight that DRM already have writeback
> connectors support, which is a way to expose in DRM the hardware
> functionality from display engines that allows writing b
aniel Vetter
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
Acked-by: Liviu Dudau
Thanks for the patch!
Best regards,
Liviu
> Cc: Mihail Atanassov
> ---
> drivers/gpu/drm/arm/malidp_drv.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gp
ink:
> https://syzkaller.appspot.com/bug?id=0ba17d70d062b2595e1f061231474800f076c7cb
> Reported-by: Tetsuo Handa
> Reported-by: syzbot+0871b14ca2e2fb64f...@syzkaller.appspotmail.com
> Cc: Tetsuo Handa
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
> Cc: Mihail Atanassov
> Cc: Brian Star
On Wed, May 27, 2020 at 01:07:05PM +0200, Daniel Vetter wrote:
> On Wed, May 27, 2020 at 12:57 PM Liviu Dudau wrote:
> >
> > Hi Daniel,
> >
> > On Wed, May 27, 2020 at 11:53:32AM +0200, Daniel Vetter wrote:
> > > Only when vblanks are supported ofc.
> >
ot.com/bug?id=0ba17d70d062b2595e1f061231474800f076c7cb
> Reported-by: Tetsuo Handa
> Reported-by: syzbot+0871b14ca2e2fb64f...@syzkaller.appspotmail.com
> Cc: Tetsuo Handa
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
> Cc: Mihail Atanassov
> Cc: Brian Starkey
> Cc:
e
and I was hitting warnings from 84014b0a39eef6df ("drm/atomic-helper: check that
drivers call drm_crtc_vblank_off"), but I'm happy that things have now been
fixed.
> Signed-off-by: Daniel Vetter
> Cc: Liviu Dudau
Acked-by: Liviu Dudau
Best regards,
Liviu
> Cc: Brian
rtc, so need to reorder that.
>
> Signed-off-by: Daniel Vetter
> Cc: Liviu Dudau
Acked-by: Liviu Dudau
Best regards,
Liviu
> Cc: Brian Starkey
> Cc:
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/
down reordered.
Got confused by the subject not having any version of the patch, so I've
acked the other one, but this is the one I've meant to Ack.
So, Acked-by: Liviu Dudau
Best regards,
Liviu
>
> Signed-off-by: Daniel Vetter
> Cc: Liviu Dudau
> Cc: Brian Starkey
>
o a testing for this patch but when I dug out the
series
from the ML it looked like it has extra dependencies, so I was waiting for the
dust
to settle.
Otherwise, LGTM.
Best regards,
Liviu
>
> Signed-off-by: Daniel Vetter
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
&g
t made by
> Brian Starkey and Liviu Dudau for adding a writeback connectors test to
> IGT. It is important to highlight that DRM already have writeback
> connectors support, which is a way to expose in DRM the hardware
> functionality from display engines that allows writing back into m
On Fri, Sep 04, 2020 at 02:56:05PM +0300, Petri Latvala wrote:
> On Fri, Sep 04, 2020 at 12:09:18PM +0100, Liviu Dudau wrote:
> > On Sun, Aug 30, 2020 at 01:44:06PM -0400, Rodrigo Siqueira wrote:
> > > Hi,
> >
> > Hi,
> >
> > Can this series be merged?
On Thu, Feb 27, 2020 at 07:14:49PM +0100, Daniel Vetter wrote:
> These are the leftover drivers that didn't have a ->release hook that
> needed to be updated.
>
> Signed-off-by: Daniel Vetter
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
> Cc: Mihail Atana
emented its own __drm_atomic_helper_crtc_reset(),
> convert it to the common one.
>
> Signed-off-by: Maarten Lankhorst
> Cc: Harry Wentland
> Cc: Leo Li
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: "David (ChunMing) Zhou"
> Cc: David Airlie
>
On Tue, May 02, 2017 at 10:14:26PM -0700, Ben Widawsky wrote:
> v2: A minor addition from Daniel
>
> Cc: Daniel Stone
You are *really* pushing your luck by not Cc-ing *any* of the maintainers of
the drivers you touch. You do want reviews, don't you?
> Signed-off-by: Ben Widawsky
> ---
> drive
On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote:
> Updated blob layout (Rob, Daniel, Kristian, xerpi)
>
> Cc: Rob Clark
> Cc: Daniel Stone
> Cc: Kristian H. Kristensen
> Signed-off-by: Ben Widawsky
> ---
> drivers/gpu/drm/drm_mode_config.c | 7 +++
> drivers/gpu/drm/drm_plane.c
On Wed, May 03, 2017 at 02:45:26PM +0100, Daniel Stone wrote:
> Hi Liviu,
>
> On 3 May 2017 at 11:34, Liviu Dudau wrote:
> > On Tue, May 02, 2017 at 10:14:26PM -0700, Ben Widawsky wrote:
> >> v2: A minor addition from Daniel
> >
> > You are *really* pushing
On Wed, May 03, 2017 at 03:14:56PM +0100, Daniel Stone wrote:
> On 3 May 2017 at 15:07, Liviu Dudau wrote:
> > On Wed, May 03, 2017 at 02:45:26PM +0100, Daniel Stone wrote:
> >> On 3 May 2017 at 11:34, Liviu Dudau wrote:
> >> > You are *really* pushing your l
On Wed, May 03, 2017 at 06:45:05PM +0200, Daniel Vetter wrote:
> On Wed, May 03, 2017 at 03:52:23PM +0100, Liviu Dudau wrote:
> > On Wed, May 03, 2017 at 03:14:56PM +0100, Daniel Stone wrote:
> > > On 3 May 2017 at 15:07, Liviu Dudau wrote:
> > > > On Wed, May 03, 20
On Wed, May 10, 2017 at 09:34:40AM -0700, Ben Widawsky wrote:
> On 17-05-03 18:30:07, Liviu Dudau wrote:
> > On Wed, May 03, 2017 at 06:45:05PM +0200, Daniel Vetter wrote:
> > > On Wed, May 03, 2017 at 03:52:23PM +0100, Liviu Dudau wrote:
> > > > On Wed, May 03, 20
On Wed, May 10, 2017 at 12:33:15PM -0700, Ben Widawsky wrote:
> On 17-05-10 18:24:52, Liviu Dudau wrote:
> >On Wed, May 10, 2017 at 09:34:40AM -0700, Ben Widawsky wrote:
> >>On 17-05-03 18:30:07, Liviu Dudau wrote:
> >>> On Wed, May 03, 2017 at 06:45:05PM +0200, Danie
On Fri, Oct 19, 2018 at 10:50:49AM +0200, Daniel Vetter wrote:
> Hi all,
Hi,
(Replying from my personal address as the work email seems to have let
this one go to /dev/null)
>
> This is just to collect feedback on this idea, and see whether the
> overall dri-devel community stands on all this.
wrote:
> Op 01-03-18 om 18:38 schreef Liviu Dudau:
> > From: Brian Starkey
> >
> > Add support in igt_kms for Writeback connectors, with the ability to
> > attach framebuffers and retrieve fences.
> >
> > Signed-off-by: Brian S
On Mon, Jun 25, 2018 at 02:48:47PM +0200, Maarten Lankhorst wrote:
> Op 01-03-18 om 18:38 schreef Liviu Dudau:
> > From: Brian Starkey
> >
> > Add tests for the WRITEBACK_PIXEL_FORMATS, WRITEBACK_OUT_FENCE_PTR and
> > WRITEBACK_FB_ID properties on writeback
On Sun, May 29, 2016 at 08:35:13PM +0200, Daniel Vetter wrote:
> Again, just doing them as blocking commits isn't cool.
>
> From a cursory check hdlcd does seem to at least try to handle
> drm_pending_vblank_event, so hopefully this works.
>
> Cc: Liviu Dudau
> Si
On Tue, May 31, 2016 at 01:07:15PM +0200, Daniel Vetter wrote:
> On Tue, May 31, 2016 at 12:02:23PM +0100, Liviu Dudau wrote:
> > On Sun, May 29, 2016 at 08:35:13PM +0200, Daniel Vetter wrote:
> > > Again, just doing them as blocking commits isn't cool.
> > >
>
On Tue, Oct 25, 2016 at 11:20:44AM +1100, Stephen Rothwell wrote:
> Hi Liviu,
Hi Stephen,
>
> Today's linux-next merge of the mali-dp tree got a conflict in:
>
> drivers/gpu/drm/arm/malidp_planes.c
>
> between commit:
>
> ea0e1ce20f73 ("drm/arm: Use per-plane rotation property")
>
> from
On Fri, Nov 04, 2016 at 04:38:54PM +1100, Stephen Rothwell wrote:
> Hi Liviu,
>
> On Thu, 3 Nov 2016 17:19:58 +0000 Liviu Dudau wrote:
> >
> > I have revamped the mali-dp tree and rebased it on the newer
> > version of drm-next (which includes the drm-misc change)
On Sat, Nov 05, 2016 at 03:55:03AM +1100, Stephen Rothwell wrote:
> Hi Liviu,
>
> On Fri, 4 Nov 2016 15:48:02 +0000 Liviu Dudau wrote:
> >
> > Brian Starkey is a co-maintainer for the Mali DP tree, so his Signed-off-by
> > alone should be good. Baoyou's patch is i
On Tue, Apr 26, 2016 at 04:11:36PM +0200, Maarten Lankhorst wrote:
> The async name is deprecated and should be changed to nonblocking.
>
> Cc: Liviu Dudau
> Signed-off-by: Maarten Lankhorst
Acked-by: Liviu Dudau
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 2 +-
> 1 file
ank_init.
>
> Stumbled over this in a discussion on irc with Chris.
>
> v2: Remove leftover debug gunk from psr hacking (Alex).
>
> Cc: Chris Wilson
> Cc: Alex Deucher
> Cc: Liviu Dudau
> Cc: Russell King
> Cc: Thierry Reding
> Cc: Eric Anholt
> Cc: La
; * Change comment about modifier (Liviu)
> * Remove arguments to blob creation, use plane instead (Liviu)
> * Fix data types (Ben)
> * Make the blob part of uapi (Daniel)
Thanks for updating the patch!
>
> Cc: Rob Clark
> Cc: Daniel Stone
> Cc: Kristian H. Kristensen
>
INVALID (Liviu)
> Remove some excess newlines (Liviu)
> Update comment for > 64 modifiers (Liviu)
>
> Cc: Liviu Dudau
> Reviewed-by: Daniel Stone (v2)
> Signed-off-by: Ben Widawsky
Minor nits, see below, but otherwise:
Reviewed-by: Liviu Dudau
Thanks,
Liviu
> ---
> dr
On Wed, May 17, 2017 at 05:26:14PM -0700, Ben Widawsky wrote:
> On 17-05-17 11:17:57, Liviu Dudau wrote:
> > On Tue, May 16, 2017 at 02:31:24PM -0700, Ben Widawsky wrote:
> > > This is the plumbing for supporting fb modifiers on planes. Modifiers
> > > have already bee
ATE_180 |
> + DRM_MODE_ROTATE_270 | DRM_MODE_REFLECT_X |
> DRM_MODE_REFLECT_Y;
> u32 *formats;
> int ret, i, j, n;
>
> @@ -420,7 +420,7 @@ int malidp_de_planes_init(struct drm_device *drm)
> continue;
>
>
> Same story for both hdlcd and mali.
>
> v2: Move misplaced malidp hunk to this patch (Liviu).
>
> Cc: Liviu Dudau
> Cc: Brian Starkey
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 2 --
> drivers/gpu/drm/arm/malidp_drv.c | 2 --
&
On Wed, May 31, 2017 at 01:03:34PM +0200, Daniel Vetter wrote:
> On Wed, May 31, 2017 at 12:57 PM, Liviu Dudau wrote:
> > On Wed, May 24, 2017 at 04:51:51PM +0200, Daniel Vetter wrote:
> >> IRQs are properly shut down, so it almost works as race-free shutdown.
> >> Exce
things gets stopped. So no harm in removing the
> drm_vblank_cleanup here really.
>
> Same story for both hdlcd and mali.
>
> v2: Move misplaced malidp hunk to this patch (Liviu).
>
> Cc: Liviu Dudau
> Cc: Brian Starkey
> Signed-off-by: Daniel Vetter
On the assumpti
On Wed, May 31, 2017 at 06:41:05PM +0200, Daniel Vetter wrote:
> On Wed, May 31, 2017 at 1:22 PM, Liviu Dudau wrote:
> > On Wed, May 31, 2017 at 01:03:34PM +0200, Daniel Vetter wrote:
> >> On Wed, May 31, 2017 at 12:57 PM, Liviu Dudau wrote:
> >> > On Wed, Ma
From: Brian Starkey
Not all elements in the crc array may be valid, so only use the valid
ones to generate the string.
Signed-off-by: Brian Starkey
---
lib/igt_debugfs.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index f5ed3
From: Brian Starkey
It's not used anymore, so remove it.
Signed-off-by: Brian Starkey
---
lib/igt_debugfs.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index 7584be5f..f5ed3daf 100644
--- a/lib/igt_debugfs.c
+++ b/lib/igt_debugfs.c
@@ -84,11 +8
From: Brian Starkey
In trying to fix igt_display_init() for devices without cursors, I
actually made matters worse. Fix the assert.
Fixes: 545aa3398223 lib/igt_kms: Remove redundant cursor code
Signed-off-by: Brian Starkey
---
lib/igt_kms.c | 10 +-
1 file changed, 5 insertions(+), 5 d
From: Liviu Dudau
Hello,
I believe Brian has sent these patches before, but he did not had any
luck getting them accepted, so it is now my turn :)
These fixes were found while developing code for memory writeback testing
and general use of igt with Mali DP KMS driver, which does not have a
From: Brian Starkey
igt_display_commit isn't refreshing all outputs anymore, which means
that an override mode may never get picked up.
Instead of forcing a reprobe to handle copying the override_mode into
default_mode, just change igt_output_get_mode() to return the
override_mode if it's been s
On Tue, Jun 06, 2017 at 01:30:28PM +0300, Arkadiusz Hiler wrote:
> On Mon, Jun 05, 2017 at 02:28:38PM +0100, Liviu Dudau wrote:
> > From: Brian Starkey
> >
> > igt_display_commit isn't refreshing all outputs anymore, which means
> > that an override mode may never
On Fri, Jun 09, 2017 at 03:37:54PM +0300, Arkadiusz Hiler wrote:
> On Fri, Jun 09, 2017 at 03:34:42PM +0300, Arkadiusz Hiler wrote:
> > On Mon, Jun 05, 2017 at 02:28:36PM +0100, Liviu Dudau wrote:
> > > From: Liviu Dudau
> > >
> > > Hello,
> > >
On Fri, Jun 09, 2017 at 03:37:54PM +0300, Arkadiusz Hiler wrote:
> On Fri, Jun 09, 2017 at 03:34:42PM +0300, Arkadiusz Hiler wrote:
> > On Mon, Jun 05, 2017 at 02:28:36PM +0100, Liviu Dudau wrote:
> > > From: Liviu Dudau
> > >
> > > Hello,
> > >
On Fri, Jun 16, 2017 at 02:08:25PM +0300, Arkadiusz Hiler wrote:
> On Mon, Jun 12, 2017 at 11:33:13AM +0100, Liviu Dudau wrote:
> > On Fri, Jun 09, 2017 at 03:37:54PM +0300, Arkadiusz Hiler wrote:
> > > On Fri, Jun 09, 2017 at 03:34:42PM +0300, Arkadiusz Hiler wrote:
> >
t needing the output to be reprobed.
This change means that output->config.default_mode always contains the
"non-overridden" default mode.
Signed-off-by: Brian Starkey
Signed-off-by: Liviu Dudau
---
lib/igt_kms.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
di
On Tue, Jun 20, 2017 at 04:28:14PM +0300, Arkadiusz Hiler wrote:
> On Fri, Jun 16, 2017 at 03:00:06PM +0100, Liviu Dudau wrote:
> > From: Brian Starkey
> >
> > Changelog:
> > - v2: removed the forced overwrite of output->config.default_mode
> >
On Wed, Jun 21, 2017 at 08:28:03PM +0200, Daniel Vetter wrote:
> Hi all,
>
> This is Thierry's deferred fbdev setup series, with the locking rework almost
> entirely redone. The much wider scope is to get rid of drm_modeset_lock_all
> calls for atomic drivers and remove users of the fairly nasty
>
On Fri, Jun 23, 2017 at 09:38:49AM +0200, Daniel Vetter wrote:
> On Thu, Jun 22, 2017 at 4:54 PM, Liviu Dudau wrote:
> > On Wed, Jun 21, 2017 at 08:28:03PM +0200, Daniel Vetter wrote:
> >> Hi all,
> >>
> >> This is Thierry's deferred fbdev setup ser
don't need two functions to probe
> connectors), we can stick much closer to the existing code. And update
> some comments I've spotted that are outdated.
>
> v5: Don't pass -EAGAIN to drivers, it's just an internal error code
> (Liviu).
>
> Cc: Liviu Dudau
>
haviour by checking in the
drm_fb_helper_hotplug_event() function if the deferred setup is still
active. If not, that means we now have a valid framebuffer that can be
used for setting the correct mode.
Fixes: b0aa06e9a7fd ("drm/fb-helper: Support deferred setup")
Signed-off-by: Liviu Duda
On Fri, Jun 30, 2017 at 08:13:58PM +0200, Daniel Vetter wrote:
> On Fri, Jun 30, 2017 at 6:51 PM, Liviu Dudau wrote:
> > Prior to commit b0aa06e9a7fd ("drm/fb-helper: Support deferred setup"),
> > if no output is connected at framebuffer setup time, we get a default
don't need two functions to probe
> connectors), we can stick much closer to the existing code. And update
> some comments I've spotted that are outdated.
>
> v5: Don't pass -EAGAIN to drivers, it's just an internal error code
> (Liviu).
>
> v6: Add _and_un
From: Brian Starkey
An output can be added as a clone of any other output(s) attached to a
pipe using igt_output_clone_pipe()
Signed-off-by: Brian Starkey
Signed-off-by: Liviu Dudau
---
lib/igt_kms.c | 90 +--
lib/igt_kms.h | 3 ++
2
From: Brian Starkey
Update the connector search to also optionally attempt to find a
non-writeback connector to clone to.
Add a subtest which is the same as writeback-check-output, but also
clones to the second connector.
Signed-off-by: Brian Starkey
Signed-off-by: Liviu Dudau
---
tests
(which can take advantage of word-access speedup), we can do the hash
on a cached copy, which is much faster (10x speedup on my platform).
Signed-off-by: Brian Starkey
Signed-off-by: Liviu Dudau
---
lib/igt_fb.c | 65
lib/igt_fb.h
From: Brian Starkey
Separate out the CRC code for better compartmentalisation. Should ease
the addition of more/different CRC sources in the future.
Signed-off-by: Brian Starkey
Signed-off-by: Liviu Dudau
---
lib/Makefile.sources | 2 +
lib/igt_chamelium.h | 1
From: Brian Starkey
Add a test which makes commits using the writeback connector, and
checks the output buffer hash to make sure it is/isn't written as
appropriate.
Signed-off-by: Brian Starkey
Signed-off-by: Liviu Dudau
---
tests/kms_writeback.c
From: Brian Starkey
Add support in igt_kms for Writeback connectors, with the ability to
attach framebuffers and retrieve fences.
Signed-off-by: Brian Starkey
Signed-off-by: Liviu Dudau
---
lib/igt_aux.c | 1 +
lib/igt_kms.c | 76
From: Brian Starkey
Add tests for the WRITEBACK_PIXEL_FORMATS, WRITEBACK_OUT_FENCE_PTR and
WRITEBACK_FB_ID properties on writeback connectors, ensuring their
behaviour is correct.
Signed-off-by: Brian Starkey
Signed-off-by: Liviu Dudau
---
lib/igt_kms.c | 6 +-
lib/igt_kms.h
We're trying to introduce support for writeback connectors, a way to
expose in DRM the hardware functionality from display engines that
allows to write back into memory the result of the DE's composition
of supported planes.
Generic DRM support is available here [1] and will be merged once
this pa
On Wed, Jul 12, 2017 at 10:13:39AM +0200, Maarten Lankhorst wrote:
> for_each_obj_in_state is about to be removed, so use the new iterator
> macros.
>
> Signed-off-by: Maarten Lankhorst
> Cc: Liviu Dudau
> Cc: Brian Starkey
> Cc: Mali DP Maintainers
Hi Maarten,
Acked-
On Wed, Jul 12, 2017 at 12:00:40PM +0200, Maarten Lankhorst wrote:
> Op 12-07-17 om 11:44 schreef Liviu Dudau:
> > On Wed, Jul 12, 2017 at 10:13:39AM +0200, Maarten Lankhorst wrote:
> >> for_each_obj_in_state is about to be removed, so use the new iterator
> >> macr
From: Brian Starkey
To use writeback buffers as a CRC source, we need to be able to hash
them. Implement a simple FVA-1a hashing routine for this purpose.
Doing a bytewise hash on the framebuffer directly can be very slow if
the memory is noncached. By making a copy of each line in the FB first
From: Brian Starkey
Update the connector search to also optionally attempt to find a
non-writeback connector to clone to.
Add a subtest which is the same as writeback-check-output, but also
clones to the second connector.
Signed-off-by: Brian Starkey
---
tests/kms_writeback.c | 63 +++
From: Brian Starkey
An output can be added as a clone of any other output(s) attached to a
pipe using igt_output_clone_pipe()
Signed-off-by: Brian Starkey
---
lib/igt_kms.c | 90 +--
lib/igt_kms.h | 3 ++
2 files changed, 59 insertions(+
From: Brian Starkey
Add support in igt_kms for Writeback connectors, with the ability to
attach framebuffers and retrieve fences.
Signed-off-by: Brian Starkey
---
lib/igt_aux.c | 1 +
lib/igt_kms.c | 76 ++-
lib/igt_kms.h | 16 ++
From: Brian Starkey
Add a test which makes commits using the writeback connector, and
checks the output buffer hash to make sure it is/isn't written as
appropriate.
Signed-off-by: Brian Starkey
---
tests/kms_writeback.c | 123 ++
1 file changed,
From: Brian Starkey
Add tests for the WRITEBACK_PIXEL_FORMATS, WRITEBACK_OUT_FENCE_PTR and
WRITEBACK_FB_ID properties on writeback connectors, ensuring their
behaviour is correct.
Signed-off-by: Brian Starkey
---
lib/igt_kms.c | 6 +-
lib/igt_kms.h | 7 +
tests/Makefile.s
From: Brian Starkey
Separate out the CRC code for better compartmentalisation. Should ease
the addition of more/different CRC sources in the future.
Signed-off-by: Brian Starkey
---
lib/Makefile.sources | 2 +
lib/igt_chamelium.h | 1 +
lib/igt_crc.c
We're trying to introduce support for writeback connectors, a way to
expose in DRM the hardware functionality from display engines that
allows to write back into memory the result of the DE's composition
of supported planes.
Generic DRM support is available here [1] and will be merged once
this pa
all the current cases), so let's put that in the doc too.
>
> While I was at it I got rid of strdup() in favor of an early allocation.
>
> Cc: Martin Peres
> Cc: Liviu Dudau
Reviewed-by: Liviu Dudau
> Signed-off-by: Arkadiusz Hiler
> ---
> lib/igt_debugfs.c |
On Mon, Jul 17, 2017 at 04:50:27PM +0300, Arkadiusz Hiler wrote:
> On Thu, Jul 06, 2017 at 05:14:18PM +0100, Liviu Dudau wrote:
> > From: Brian Starkey
> >
> > Separate out the CRC code for better compartmentalisation. Should ease
> > the addition of more/differen
On Tue, Jul 25, 2017 at 10:01:19AM +0200, Daniel Vetter wrote:
> It's dead code, the core handles all this directly now. This also
> allows us to unexport drm_atomic_helper_plane_set_property.
>
> Signed-off-by: Daniel Vetter
> Cc: Liviu Dudau
> Cc: Brian Starkey
&g
1 - 100 of 125 matches
Mail list logo
