ts.
>
> Signed-off-by: Thomas Gleixner
> Cc: Linus Walleij
> Cc: Lee Jones
> Cc: linux-arm-ker...@lists.infradead.org
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Thu, Dec 10, 2020 at 8:42 PM Thomas Gleixner wrote:
> Let the core code do the fiddling with irq_desc.
>
> Signed-off-by: Thomas Gleixner
> Cc: Linus Walleij
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-g...@vger.kernel.org
Reviewed-by: Linus Walleij
I suppo
On Fri, May 21, 2021 at 11:10 AM Daniel Vetter wrote:
> Goes through all the drivers and deletes the default hook since it's
> the default now.
>
> Signed-off-by: Daniel Vetter
> Cc: Joel Stanley
> Cc: Andrew Jeffery
> Cc: "Noralf Trønnes"
> Cc: Linus
is trace down to the calls I
need and understand the small pieces I use.
Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
blocks of include files
>
> Signed-off-by: Sam Ravnborg
> Cc: Thierry Reding
> Cc: Linus Walleij
> Cc: Stefan Mavrodiev
> Cc: David Airlie
> Cc: Daniel Vetter
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
___
Intel-gfx maili
On Sun, May 26, 2019 at 8:05 PM Sam Ravnborg wrote:
> The num_supplies variable is not used, delete it.
> Build tested.
>
> Signed-off-by: Sam Ravnborg
> Cc: Thierry Reding
> Cc: David Airlie
> Cc: Daniel Vetter
Reviewed-by: Linus Walleij
On Fri, Jun 14, 2019 at 10:36 PM Daniel Vetter wrote:
> They're the default.
>
> Aside: Would be really nice to switch the others over to
> drm_gem_object_funcs.
>
> Signed-off-by: Daniel Vetter
> Cc: Linus Walleij
Reviewed-by: Linus Wall
On Fri, Jun 14, 2019 at 10:36 PM Daniel Vetter wrote:
> They're the default.
>
> Aside: Would be really nice to switch the others over to
> drm_gem_object_funcs.
>
> Signed-off-by: Daniel Vetter
> Cc: Linus Walleij
Reviewed-by: Linus Walleij
When you write "
On Thu, Jul 21, 2022 at 8:24 AM Slark Xiao wrote:
> Replace 'the the' with 'the' in the comment.
>
> Signed-off-by: Slark Xiao
Patch applied!
Yours,
Linus Walleij
se some
really complex DSI panel from drivers/gpu/drm/panel/*
though.
Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
connects to the other review comments where
I feel we should be spawning gpio backlight devices from
somewhere.
I understand those things may be a bit big, if the intel
pinctrl maintainers are fine with this solution I am fine
with it too, it's not like it is the biggest deal, I am just worri
nn (v1)
> Cc: Thomas Zimmermann
> Cc: Noralf Trønnes
> Cc: Gerd Hoffmann
> Cc: Eric Anholt
> Cc: Emil Velikov
> Cc: virtualizat...@lists.linux-foundation.org
> Cc: Linus Walleij
> Signed-off-by: Daniel Vetter
Makes perfect sense.
Revi
.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=ib-pinctrl-unreg-mappings
And pulled that into the pinctrl "devel" branch for v5.6.
Please pull this immutable branch into the Intel DRM tree and apply
the rest of the stuff on top!
Yours,
Linus Walleij
nctrl_maps. So this is easy, but I wonder if we cannot
> get rid of the dupping all together ?
Maybe ... I don't know. What do you think? I suppose you could
make u300 crash if you do that.
Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
ll this in and put the other patches on top of that.
I had a bit of mess in my subsystems last kernel cycle so I
want to avoid that by strictly including all larger commits
in my trees.
Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists
ue accordingly.
>
> This fixes the panel not lighting up on a Thundersoft TST168 tablet when
> booted with an external monitor connected over HDMI.
>
> Signed-off-by: Hans de Goede
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
___
where instead of the PMIC the SoC is used
> for backlight control.
>
> Signed-off-by: Hans de Goede
The kernel looks prettier after than before and it seems correct so:
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
___
Intel-gfx mailing
s devices when booted
> with a HDMI monitor connected. This has been tested to fix this on the
> following devices:
>
> Peaq C1010
> Point of View MOBII TAB-P800W
> Point of View MOBII TAB-P1005W
> Terra Pad 1061
> Yours Y8W81
>
> Signe
>
> Since the lookup-table is attached to the i915 PCI device it really
> should be part of the i915 driver, this will also allow us to extend
> it with GPIOs from other sources when necessary.
>
> Signed-off-by: Hans de Goede
Looks OK to me
Acked-by: Linus Walleij
But Lee
nctrl/cirrus/pinctrl-madera-core.c: ret =
pinctrl_register_mappings(pdata->gpio_configs,
Delete __initdata from the u300 table, the other one seems
safe. Fold this into your patch.
Go with the original idea.
Yours,
Linus Walleij
___
Intel-gf
On Fri, Apr 3, 2020 at 10:41 PM Ville Syrjala
wrote:
> From: Ville Syrjälä
>
> htotal*vtotal*vrefresh ~= clock. So just say "clock" when we mean it.
>
> Cc: Linus Walleij
> Cc: Sam Ravnborg
> Signed-off-by: Ville Syrjälä
Indeed :)
Reviewed-by: Linus
On Fri, Apr 3, 2020 at 3:59 PM Daniel Vetter wrote:
> Upcasting using a container_of macro is more typesafe, faster and
> easier for the compiler to optimize.
>
> Signed-off-by: Daniel Vetter
> Cc: Linus Walleij
Nice, thanks!
Reviewed-by: Linus Walleij
Yours
On Wed, Apr 15, 2020 at 9:41 AM Daniel Vetter wrote:
> Already using devm_drm_dev_init, so very simple replacment.
>
> v2: Move misplaced double-assignement to next patch (Sam)
>
> Acked-by: Sam Ravnborg
> Signed-off-by: Daniel Vetter
> Cc: Linus Walleij
Reviewed-by:
On Wed, Feb 19, 2020 at 11:22 AM Daniel Vetter wrote:
> Allows us to drop the drm_driver.release callback.
>
> Signed-off-by: Daniel Vetter
> Cc: Linus Walleij
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
___
Intel-gfx mailing li
On Wed, Feb 19, 2020 at 11:21 AM Daniel Vetter wrote:
> With this we can drop the final kfree from the release function.
>
> Signed-off-by: Daniel Vetter
> Cc: Linus Walleij
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
___
Intel
> losing their ->remove hook.
>
> Signed-off-by: Daniel Vetter
> Cc: Linus Walleij
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Wed, Feb 19, 2020 at 9:35 PM Ville Syrjala
wrote:
> drm/exynos: Use mode->clock instead of reverse calculating it from the
> vrefresh
> drm: Nuke mode->vrefresh
I'm sure this is fine.
Acked-by: Linus Walleij
We need one: either clock or refresh settings, so i
2 + 2 + 2)
> panel-arm-versatile.c:184/versatile_panels[]: 390 vs. 1523 (.clock=62500
> .htotal=176 + 2 + 3 + 3 .vtotal=220 + 0 + 2 + 1)
The only driver drivers/gpu/drm/pl111/pl111_display.c
Uses mode->clock so just drop vrefresh.
Yours,
Linus Walleij
__
On Wed, Feb 26, 2020 at 12:57 PM Ville Syrjälä
wrote:
> On Tue, Feb 25, 2020 at 10:52:25PM +0100, Linus Walleij wrote:
> > I have long suspected that a whole bunch of the "simple" displays
> > are not simple but contains a display controller and memory.
> > Tha
On Wed, Feb 26, 2020 at 3:34 PM Ville Syrjälä
wrote:
> On Wed, Feb 26, 2020 at 01:08:06PM +0100, Linus Walleij wrote:
> > On Wed, Feb 26, 2020 at 12:57 PM Ville Syrjälä
> > wrote:
> > > On Tue, Feb 25, 2020 at 10:52:25PM +0100, Linus Walleij wrote:
> >
> > &g
On Fri, Apr 22, 2016 at 9:38 PM, wrote:
> From: Ville Syrjälä
>
> GPIO lookup tables are supposed to be zero terminated. Let's do that
> and avoid accidentally walking off the end.
>
> Cc: Shobhit Kumar
> Cc: Samuel Ortiz
> Cc: Linus Walleij
> Cc: Alexand
On Wed, Mar 16, 2016 at 2:34 PM, Daniel Vetter wrote:
> On Wed, Mar 16, 2016 at 01:27:49PM +0100, Linus Walleij wrote:
>> - What is a HPD interrupt?
>
> hotplug interrupt, fires when you plug in a cable.
>
>> - What is a Type-C DP HPD?
>
> usb type C connector can
fred Schlaegl
> Cc: Marek Vasut
> Cc: Archit Taneja
> Cc: Andrzej Hajda
> Cc: Alison Wang
> Cc: Eric Anholt
> Cc: Linus Walleij
> Cc: linux-renesas-...@vger.kernel.org
> Cc: Maxime Ripard
> Signed-off-by: Ville Syrjälä
Acked-by: Linus Walleij
On Fri, Aug 16, 2024 at 2:54 PM Thomas Zimmermann wrote:
> Call drm_client_setup() to run the kernel's default client setup
> for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> Signed-off-by: Thomas Zimmermann
red color mode of 32. As this
> is the default if no format has been given, leave it out entirely.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Linus Walleij
Acked-by: Linus Walleij
Yours,
Linus Walleij
On Wed, Jul 31, 2024 at 2:23 PM Thomas Zimmermann wrote:
> Replace FB_BLANK_ constants with their counterparts from the
> backlight subsystem. The values are identical, so there's no
> change in functionality or semantics.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Li
us but long. I think I stayed off it
because changing stuff like that all over the place creates churn
and churn is bad.
Yours,
Linus Walleij
light thingy. But for the Panel power control, I am at loss
> for how best to program that.
Isn't it just a very simple regulator (just on/off of fixed voltage) cell?
Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists.
ugh CRC PMIC
>
> Cc: Linus Walleij
> Cc: Alexandre Courbot
> Cc: Thierry Reding
> Signed-off-by: Shobhit Kumar
This seems very unintuitive. I have a hard time believeing this:
> +#define GPIOPANELCTL 0x51
A special GPIO only designated to panel control? That is total
On Thu, Mar 12, 2015 at 4:06 PM, Kumar, Shobhit wrote:
> On Mon, 2015-03-09 at 18:15 +0100, Linus Walleij wrote:
>> On Fri, Mar 6, 2015 at 5:23 PM, Kumar, Shobhit
>> wrote:
>>
>> > There are actually two lines for Panel Power control and Backlight
>> &g
On Thu, Mar 12, 2015 at 5:31 PM, Shobhit Kumar wrote:
> Export PANEL_EN/DISABLE (offset 0x52) as additional GPIO. Needed
> by display driver to enable the DSI panel on BYT platform where
> the Panel EN/Disable control is routed thorugh CRC PMIC
>
> CC: Samuel Ortiz
> Cc: L
the newer gpiod interface(Alexandre)
> v3: Remove the redundant checks and unused code (Ville)
>
> CC: Samuel Ortiz
> Cc: Linus Walleij
> Cc: Alexandre Courbot
> Cc: Thierry Reding
> Signed-off-by: Shobhit Kumar
NACK.
This is not a GPIO but a special-purpose register as can
->dev.parent;
struct intel_soc_pmic *pmic = dev_get_drvdata(dev);
struct regulator_config config = { };
config.dev = &pdev->dev;
config.driver_data = pmic;
return devm_regulator_register(&pdev->dev,
&crystal_panel_regulator, config);
}
Untested, but
On Thu, Mar 12, 2015 at 5:31 PM, Shobhit Kumar wrote:
> On some Intel SoC platforms, the panel enable/disable signals are
> controlled by CRC PMIC. Add those control as a new GPIO in a lookup
> table for gpio-crystalcove chip during CRC driver load
>
> CC: Samuel Ortiz
> Cc: L
On Wed, Mar 18, 2015 at 2:27 PM, Daniel Vetter wrote:
> On Wed, Mar 18, 2015 at 12:50:51PM +0100, Linus Walleij wrote:
>> This is not a GPIO, this is a special purpose thing and IMO
>> it should be modeled directly as a regulator.
>
> The idea behind reusing gpio was
On Tue, Mar 24, 2015 at 10:50 AM, Daniel Vetter wrote:
> On Tue, Mar 24, 2015 at 10:35:32AM +0100, Linus Walleij wrote:
>> Some stuff may be needed to associate the regulator with the right
>> device indeed but nothing horribly complicated.
>
> Nack, really. We've ha
On Tue, Mar 24, 2015 at 11:53 AM, Daniel Vetter wrote:
> On Tue, Mar 24, 2015 at 11:16 AM, Linus Walleij
> wrote:
> So summary:
> - Reusing the dynamic gpio lookup stuff would be nice, and might be
> interesting as a new crazy use-case (or maybe not). But not a
> requirement
ugh CRC PMIC
>
> Cc: Linus Walleij
> Cc: Alexandre Courbot
> Cc: Thierry Reding
> Signed-off-by: Shobhit Kumar
Patch applied, after Daniel convinced me that this is the lesser
of several possible evils to the kernel code base.
Yours,
Linus Walleij
__
On Wed, Mar 25, 2015 at 3:15 PM, Kumar, Shobhit wrote:
> On Wed, 2015-03-25 at 13:27 +0100, Linus Walleij wrote:
>> On Wed, Feb 18, 2015 at 1:18 PM, Shobhit Kumar
>> wrote:
>>
>> > Export Panel BACKLIGHT_EN(offset 0x51) and PANEL_EN(offset 0x52) as two
>> &
On Thu, Mar 12, 2015 at 5:31 PM, Shobhit Kumar wrote:
> Export PANEL_EN/DISABLE (offset 0x52) as additional GPIO. Needed
> by display driver to enable the DSI panel on BYT platform where
> the Panel EN/Disable control is routed thorugh CRC PMIC
>
> CC: Samuel Ortiz
> Cc: L
On Thu, Mar 12, 2015 at 5:31 PM, Shobhit Kumar wrote:
> On some Intel SoC platforms, the panel enable/disable signals are
> controlled by CRC PMIC. Add those control as a new GPIO in a lookup
> table for gpio-crystalcove chip during CRC driver load
>
> CC: Samuel Ortiz
> Cc: L
On Wed, Mar 25, 2015 at 2:13 PM, Daniel Vetter wrote:
> I quickly checked out your linux-gpio and it only has patch 2 to implement
> the gpio. We also need patch 1 (but with the leak Thierry spotted fixed).
> Should we drop Shobit's patch until that's done?
Nah I trust that Lee will merge it to
static (Thierry)
> Remove the lookup table during driver remove (Thierry)
>
> CC: Samuel Ortiz
> Cc: Linus Walleij
> Cc: Alexandre Courbot
> Cc: Thierry Reding
> Signed-off-by: Shobhit Kumar
Acked-by: Linus Walleij
Yours,
Linus Walleij
_
the newer gpiod interface(Alexandre)
> v3: Remove the redundant checks and unused code (Ville)
>
> CC: Samuel Ortiz
> Cc: Linus Walleij
> Cc: Alexandre Courbot
> Cc: Thierry Reding
> Signed-off-by: Shobhit Kumar
Acked-by: Linus Walleij
> + /* Panel Enable o
>
> Cc: Samuel Ortiz
> Cc: Linus Walleij
> Cc: Alexandre Courbot
> Cc: Thierry Reding
> Reviewed-by: Alexandre Courbot
> Signed-off-by: Shobhit Kumar
Reviewed-by: Linus Walleij
Since it is core support I'd prefer to merge this into the GPIO git
tree. Is it OK or d
static (Thierry)
> Remove the lookup table during driver remove (Thierry)
>
> CC: Samuel Ortiz
> Cc: Linus Walleij
> Cc: Alexandre Courbot
> Cc: Thierry Reding
> Signed-off-by: Shobhit Kumar
Acked-by: Linus Walleij
Yours,
Linus Walleij
_
On Wed, May 6, 2015 at 5:09 PM, Daniel Vetter wrote:
> On Wed, May 06, 2015 at 04:49:36PM +0200, Linus Walleij wrote:
>> On Wed, Apr 29, 2015 at 3:59 PM, Shobhit Kumar
>> wrote:
>>
>> > In case we unload and load a driver module again that is registering a
>
static (Thierry)
> Remove the lookup table during driver remove (Thierry)
>
> v3: Correct the subject line (Lee jones)
>
> CC: Samuel Ortiz
> Cc: Linus Walleij
> Cc: Alexandre Courbot
> Cc: Thierry Reding
> Acked-by: Lee Jones
> Signed-off-by: Shobhit Kumar
A
the newer gpiod interface(Alexandre)
> v3: Remove the redundant checks and unused code (Ville)
>
> CC: Samuel Ortiz
> Cc: Linus Walleij
> Cc: Alexandre Courbot
> Cc: Thierry Reding
> Signed-off-by: Shobhit Kumar
Acked-by: Linus Walleij
Yours,
Linus Walleij
_
s
> v3: Correct the subject line (Lee jones)
>
> Cc: Samuel Ortiz
> Cc: Linus Walleij
> Cc: Alexandre Courbot
> Cc: Thierry Reding
> Reviewed-by: Alexandre Courbot
> Reviewed-by: Linus Walleij
> Signed-off-by: Shobhit Kumar
Do you plan to take this upstream for th
60 matches
Mail list logo
