Re: [Intel-gfx] [PATCH v4 2/5] drm/atomic: Make drm_atomic_plane_disabling easier to understand.

e dropped. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_atomic_helper.c | 7 --- > drivers/gpu/drm/drm_plane_helper.c | 2 +- > include/drm/drm_atomic_helper.h | 26 -- > 3 files changed,

Re: [Intel-gfx] [PATCH v4 3/5] drm/atomic: Add macros to access existing old/new state, v2.

> The calls to drm_atomic_get_existing_$obj_state should no longer be > used, and converted over to these new calls. > > Changes since v1: > - Expand commit message. > - Deprecate get_existing_*_state functions in the documentation. > > Signed-off-by: Maarten Lankh

Re: [Intel-gfx] [PATCH v4 5/5] drm/blend: Use new atomic iterator macros.

p. For clarity, also rename the > variables from $obj_state to (old,new)_$obj_state as well. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_blend.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) &

Re: [Intel-gfx] [PATCH v4 4/5] drm/atomic: Convert get_existing_state callers to get_old/new_state, v3.

e->crtc); I believe more *_state -> *_(new|old)_state renames could be useful, but that can be addressed as a subsequent patch, so Reviewed-by: Laurent Pinchart > crtc_state->connector_mask &= > ~(1 << drm_connector_index(conn_stat

Re: [Intel-gfx] [PATCH v4.1 1/5] drm/atomic: Fix atomic helpers to use the new iterator macros, v3.

Hi Maarten, Thank you for the resend. For the whole series, Tested-by: Laurent Pinchart On Wednesday 01 Mar 2017 10:21:26 Maarten Lankhorst wrote: > There are new iterator macros that annotate whether the new or old > state should be used. This is better than using a state that depe

Re: [Intel-gfx] [PATCH 06/24] drm/doc: document fallback behaviour for atomic events

er side of how to > make hw work correctly where it's possible is imo already sufficiently > documented. > > v2: Review from Laurent. > > Cc: Laurent Pinchart > Signed-off-by: Daniel Vetter Reviewed-by: Laurent Pinchart > --- > include/drm/drm_crtc.h | 6 ++ &

Re: [Intel-gfx] [RFC 0/4] Introduce drmfs pseudo filesystem for drm subsystem

| 1 + > drivers/gpu/drm/drm_drv.c | 26 ++ > drivers/gpu/drm/drmfs.c| 566 ++ > drivers/gpu/drm/i915/i915_guc_submission.c | 33 +- > include/drm/drm_drv.h | 3 + > include/drm/drmfs.h| 77

Re: [Intel-gfx] [PATCH 11/17] drm/cma-helper: simplify setup for drivers with ->dirty callbacks

7;s a KMS feature, only > used by the fbdev deferred_io support to implement flushing/upload. > > Cc: Noralf Trønnes > Cc: Laurent Pinchart > Signed-off-by: Daniel Vetter Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_fb_cma_helper.c | 58 ++

Re: [Intel-gfx] [PATCH 14/17] drm/cma-helpers: Use recommened kerneldoc for struct member refs

tables (where the > per-member kerneldoc tends to be long). > > Also some minor drive-by polish where it makes sense, I read a lot > of docs ... > > Cc: Laurent Pinchart > Cc: Jani Nikula > Cc: Chris Wilson > Signed-off-by: Daniel Vetter >

Re: [Intel-gfx] [PATCH v2.1 1/7] drm/atomic: Add new iterators over all state, v3.

t;planes[__i].old_state, 1); \ > + (__i)++) \ > + for_each_if (plane) > + > +#define for_each_new_plane_in_state(__state, plane, new_plane_state, __i) \ > + for ((__i) = 0;

Re: [Intel-gfx] [PATCH v3 1/7] drm/atomic: Add new iterators over all state, v3.

((plane) = (__state)->planes[__i].ptr, \ > + (old_plane_state) = (__state)->planes[__i].old_state, 1); \ > + (__i)++) \ > + for_each_if (plane) > + > +#define for_each_new_plane_in_state(__state, plane, new_plane_state, __i) \ > + for ((__i) = 0; \ > + (__i) < (__state)->dev->mode_config.num_total_plane && \ > + ((plane) = (__state)->planes[__i].ptr, \ > + (new_plane_state) = (__state)->planes[__i].new_state, 1); \ > + (__i)++) \ > + for_each_if (plane) > + > /** > * drm_atomic_crtc_needs_modeset - compute combined modeset need > * @state: &drm_crtc_state for the CRTC > diff --git a/include/drm/drm_atomic_helper.h > b/include/drm/drm_atomic_helper.h index 9afcd3810785..2c4549e98c16 100644 > --- a/include/drm/drm_atomic_helper.h > +++ b/include/drm/drm_atomic_helper.h > @@ -105,6 +105,8 @@ int __drm_atomic_helper_set_config(struct drm_mode_set > *set, int drm_atomic_helper_disable_all(struct drm_device *dev, > struct drm_modeset_acquire_ctx *ctx); > struct drm_atomic_state *drm_atomic_helper_suspend(struct drm_device *dev); > +int drm_atomic_helper_commit_duplicated_state(struct drm_atomic_state > *state, > + struct drm_modeset_acquire_ctx > *ctx); > int drm_atomic_helper_resume(struct drm_device *dev, >struct drm_atomic_state *state); -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v3 2/7] drm/atomic: Make add_affected_connectors look at crtc_state.

ed-off-by: Maarten Lankhorst Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_atomic.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index 1c1cbf436717..18cdf2c956c6 100644

Re: [Intel-gfx] [PATCH v3 3/7] drm/atomic: Use new atomic iterator macros.

Hi Maarten, Thank you for the patch. On Monday 16 Jan 2017 10:37:40 Maarten Lankhorst wrote: Could we please get a description ? Apart from that, Reviewed-by: Laurent Pinchart > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/drm_atomic.c | 16 > 1 fil

Re: [Intel-gfx] [PATCH v3 0/7] drm/atomic: Add accessor macros for all atomic state.

ivers/gpu/drm/drm_atomic_helper.c | 377 ++-- > drivers/gpu/drm/drm_blend.c | 23 +-- > drivers/gpu/drm/i915/intel_display.c | 13 +- > include/drm/drm_atomic.h | 180 - > include/drm/drm_atomic_helper.h |

Re: [Intel-gfx] [PATCH v3 4/7] drm/atomic: Fix atomic helpers to use the new iterator macros.

ne_state, *new_plane_state; > int i; > > - for_each_plane_in_state(old_state, plane, plane_state, i) { > + for_each_oldnew_plane_in_state(old_state, plane, plane_state, > new_plane_state, i) { > const struct drm_plane_helper_funcs *funcs; >

Re: [Intel-gfx] [PATCH v3 5/7] drm/atomic: Add macros to access existing old/new state

te for the given connector, > + * or NULL if the connector is not part of the global atomic state. > + */ > +static inline struct drm_connector_state * > +drm_atomic_get_new_connector_state(struct drm_atomic_state *state, > +struct drm_connector *c

Re: [Intel-gfx] [PATCH v3 6/7] drm/atomic: Convert get_existing_state callers to get_old/new_state, v2.

he new state before this patch ? > const struct drm_plane_helper_funcs *plane_funcs; > > plane_funcs = plane->helper_private; -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v3 7/7] drm/blend: Use new atomic iterator macros.

Hi Maarten, Thank you for the patch. On Monday 16 Jan 2017 10:37:44 Maarten Lankhorst wrote: Could we please get a commit message ? Apart from that, Reviewed-by: Laurent Pinchart > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/drm_blend.c | 22 +++---

Re: [Intel-gfx] [PATCH v3 6/7] drm/atomic: Convert get_existing_state callers to get_old/new_state, v2.

; if (!old_crtc_state->active || > !drm_atomic_crtc_needs_modeset(old_conn_state->crtc- >state)) -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v3 0/7] drm/atomic: Add accessor macros for all atomic state.

; include/drm/drm_atomic.h | 180 - > include/drm/drm_atomic_helper.h | 2 + > 6 files changed, 438 insertions(+), 196 deletions(-) -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v3 4/7] drm/atomic: Fix atomic helpers to use the new iterator macros.

Hi Maarten, On Wednesday 18 Jan 2017 15:49:56 Maarten Lankhorst wrote: > Op 17-01-17 om 02:01 schreef Laurent Pinchart: > > On Monday 16 Jan 2017 10:37:41 Maarten Lankhorst wrote: > >> Signed-off-by: Maarten Lankhorst > >> --- > >> > >&g

Re: [Intel-gfx] [PATCH v3 1/7] drm/atomic: Add new iterators over all state, v3.

Hi Maarten, On Tuesday 17 Jan 2017 08:41:03 Maarten Lankhorst wrote: > Op 17-01-17 om 00:11 schreef Laurent Pinchart: > > On Monday 16 Jan 2017 10:37:38 Maarten Lankhorst wrote: > >> Add for_each_(old)(new)_(plane,connector,crtc)_in_state iterators to > >> replace th

Re: [Intel-gfx] [PATCH] drm: Provide a driver hook for drm_dev_release()

Hi Chris, On Thursday 19 Jan 2017 11:20:37 Chris Wilson wrote: > On Wed, Dec 14, 2016 at 12:04:38AM +0200, Laurent Pinchart wrote: > > On Thursday 08 Dec 2016 08:18:40 Chris Wilson wrote: > >> Some state is coupled into the device lifetime outside of the > >> load/un

Re: [Intel-gfx] [PATCH v3] drm: Provide a driver hook for drm_dev_release()

tch that shows usage of the release callback in a driver ? > Signed-off-by: Chris Wilson > Cc: Laurent Pinchart > Cc: Daniel Vetter > --- > drivers/gpu/drm/drm_drv.c | 56 ++-- > include/drm/drm_drv.h | 11 ++ > 2 files c

Re: [Intel-gfx] [PATCH 2/4] drm/bridge-connector: handle subconnector types

roperty > > exists, > > and perhaps add a warning if not. > > This property is created in the previous call, > drm_mode_create_tv_properties() -> > drm_mode_create_tv_properties_legacy(). > > > AFAIK same for DRM_MODE_CONNECTOR_DVII. > > > > > + } > > > + > > > return connector; > > > } > > > EXPORT_SYMBOL_GPL(drm_bridge_connector_init); > > > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > > > index bf964cdfb330..68b14ac5ac0d 100644 > > > --- a/include/drm/drm_bridge.h > > > +++ b/include/drm/drm_bridge.h > > > @@ -739,6 +739,10 @@ struct drm_bridge { > > >* identifies the type of connected display. > > >*/ > > > int type; > > > + /** > > > + * @subtype: the subtype of the connector for the DP/TV/DVI-I cases. > > > + */ > > > + enum drm_mode_subconnector subtype; > > > /** > > >* @interlace_allowed: Indicate that the bridge can handle > > > interlaced > > >* modes. -- Regards, Laurent Pinchart

Re: [Intel-gfx] [PATCH 1/4] drm: allow specifying default subtype for the DP subconnector property

ent_type_name(int val); > int drm_get_tv_mode_from_name(const char *name, size_t len); > > int drm_mode_create_dvi_i_properties(struct drm_device *dev); > -void drm_connector_attach_dp_subconnector_property(struct drm_connector > *connector); > +void drm_connector_attach_dp_subconnector_property(struct drm_connector > *connector, > +enum drm_mode_subconnector > subtype); > > int drm_mode_create_tv_margin_properties(struct drm_device *dev); > int drm_mode_create_tv_properties_legacy(struct drm_device *dev, -- Regards, Laurent Pinchart

Re: [Intel-gfx] [PATCH 3/4] drm/uapi: document the USB subconnector type

{ > DRM_MODE_SUBCONNECTOR_HDMIA = 11, /*DP */ > DRM_MODE_SUBCONNECTOR_Native = 15, /*DP */ > DRM_MODE_SUBCONNECTOR_Wireless= 18, /* DP */ > + DRM_MODE_SUBCONNECTOR_USB = 20, /*DP */ > }; > > #define DRM_MODE_CONNECTOR_Unknown 0 -- Regards, Laurent Pinchart

Re: [Intel-gfx] [PATCH 3/4] drm/uapi: document the USB subconnector type

On Wed, Aug 02, 2023 at 10:01:19PM +0300, Dmitry Baryshkov wrote: > On 02/08/2023 21:55, Laurent Pinchart wrote: > > Hi Dmitry, > > > > Thank you for the patch. > > > > On Sat, Jul 29, 2023 at 03:49:12AM +0300, Dmitry Baryshkov wrote: > >> To properly d

Re: [Intel-gfx] [PATCH 3/4] drm/uapi: document the USB subconnector type

gure > this out isn't super optimal perhaps. > > [1]: > https://lore.kernel.org/dri-devel/20221108185004.2263578-1-wonch...@google.com/ -- Regards, Laurent Pinchart

Re: [Intel-gfx] 2023 X.Org Foundation Membership deadline for voting in the election

the > > upcoming election is 26 March 2023 at 23:59 UTC. > > > > If you are interested in joining the X.Org Foundation or in renewing > > your membership, please visit the membership system site at: > > https://members.x.org/ > > > > Ricardo Garcia, on behalf of the X.Org elections committee -- Regards, Laurent Pinchart

Re: [Intel-gfx] [RFC 1/2] drm/connector: add connector list iteration with filtering

struct drm_connector_list_iter *iter) > { > - iter->dev = dev; > - iter->conn = NULL; > - lock_acquire_shared_recursive(&connector_list_iter_dep_map, 0, 1, NULL, > _RET_IP_); > + drm_connector_list_iter_filter_begin(dev, iter, NULL, NULL); &g

Re: [Intel-gfx] [RFC 0/2] drm/connector: connector iterator with filtering

he call. If there's a general consensus it's better to require all drivers to handle writeback connectors explicitly everywhere (Daniel and Dave may want to chime in here), I can be overruled, like anybody else. > > This series is > > Acked-by: Harry Wentland > >

Re: [Intel-gfx] [PATCH v2] drm/scdc-helper: Pimp SCDC debugs

ime) > > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jernej Skrabec > Cc: Thierry Reding > Cc: Emma Anholt > Cc: Maxime Ripard > Cc: intel-gfx@lists.freedesktop.org > Cc: linux-te...@vge

Re: [Intel-gfx] [PATCH v2] drm/probe_helper: sort out poll_running vs poll_enabled

00/0x474 > worker_thread+0x74/0x43c > kthread+0xfc/0x110 > ret_from_fork+0x10/0x20 > ---[ end trace ]--- > > Reported-by: Laurentiu Palcu > Fixes: c8268795c9a9 ("drm/probe-helper: enable and disable HPD on connectors") > Tested-by: Marek Szyp

Re: [PATCH 01/86] drm/fbdev-helper: Move color-mode lookup into 4CC format helper

helpers into a 4CC helper, s/form/from/ > so that is can be shared among DRM clients. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_fb_helper.c | 70 +++-- > drivers/gpu/drm/drm_fourcc.c|

Re: [PATCH 04/86] drm: Add client-agnostic setup helper

*format); void drm_client_setup_with_color_mode(struct drm_device *dev, unsigned int color_mode); #define drm_client_setup_(dev, format_or_color_mode) \ _Generic(format_or_color_mode, \ const struct drm_format_info *: drm_client_setup_with_format(dev, format_or_color_mode), \ unsigned int: drm_client_setup_with_color_mode(dev, format_or_color_mode)\ ) Up to you. Reviewed-by: Laurent Pinchart > + > +#endif -- Regards, Laurent Pinchart

Re: [PATCH 34/86] drm/renesas/rcar-du: Run DRM default client setup

> > The rcar-du driver specifies a preferred color mode of 32. As this > is the default if no format has been given, leave it out entirely. > > Signed-off-by: Thomas Zimmermann > Cc: Laurent Pinchart > Cc: Kieran Bingham Reviewed-by: Laurent Pinchart > --- > driv

Re: [PATCH 36/86] drm/renesas/shmobile: Run DRM default client setup

gt; > Signed-off-by: Thomas Zimmermann > Cc: Laurent Pinchart > Cc: Geert Uytterhoeven Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/

Re: [PATCH 48/86] drm/xlnx: Run DRM default client setup

gt; > Signed-off-by: Thomas Zimmermann > Cc: Laurent Pinchart > Cc: Tomi Valkeinen > Cc: Michal Simek > --- > drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c &

Re: [PATCH 04/86] drm: Add client-agnostic setup helper

Hi Thomas, On Tue, Aug 20, 2024 at 09:22:36AM +0200, Thomas Zimmermann wrote: > Am 18.08.24 um 22:07 schrieb Laurent Pinchart: > > On Fri, Aug 16, 2024 at 02:22:30PM +0200, Thomas Zimmermann wrote: > >> DRM may support multiple in-kernel clients that run as soon as a DRM &g

Re: 2024 X.Org Foundation Membership deadline for voting in the election

I know for sure of one other person falling > for the same. Make that two. Thanks for the notice. > Now, the members page for this year says "Application for the period: > 02/2024-02/2025". Thanks to the people adding the month to reduce > confusion. -- Regards, Laurent Pinchart

Re: [PATCH 2/8] drm: renesas: rcar-du: annotate rcar_cmm_read() with __maybe_unused

oss the series. Jiapeng Chong has sent a patch to drop the function, and I've reviewed it. See https://lore.kernel.org/r/20240619075436.86407-1-jiapeng.ch...@linux.alibaba.com I've sent a pull request for v6.12 but it hasn't been processed in time :-( See https://lore.kernel.org/r/20240822234445.ga23...@pendragon.ideasonboard.com -- Regards, Laurent Pinchart

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add drm_plane_force_disable()

b/include/drm/drm_crtc.h > @@ -894,6 +894,7 @@ extern int drm_plane_init(struct drm_device *dev, > const uint32_t *formats, uint32_t format_count, > bool priv); > extern void drm_plane_cleanup(struct drm_plane *plane); > +extern void d

Re: [Intel-gfx] [PATCH] drm: Add kernel-doc for plane functions

be the function should be renamed to drm_plane_disable(), and the documentation updated to mention that the function just disables the plane and disassociate with from its frame buffer. > + * > + * Used when the plane's current framebuffer is destroyed, > + * and when restoring

Re: [Intel-gfx] [PATCH 4/4] drm: Constify the pretty-print functions

de_group *group); extern bool drm_probe_ddc(struct i2c_adapter > *adapter); > @@ -994,7 +995,7 @@ extern int drm_mode_create_tv_properties(struct > drm_device *dev, int num_formats extern int > drm_mode_create_scaling_mode_property(struct drm_device *dev); extern int > drm_mode_create_dit

Re: [Intel-gfx] [PATCH v2] drm: Remove some unused stuff from drm_plane

Hello, On Wednesday 08 May 2013 15:52:10 Laurent Pinchart wrote: > On Wednesday 08 May 2013 16:40:54 ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > There's a bunch of unused members inside drm_plane, bloating the size of > > the stru

Re: [Intel-gfx] [PATCH 13/20] drm/gem: create drm_gem_dumb_destroy

leaves the option open for kms drivers which don't use GEM > for backing storage, but it does decently simplify matters for gem > drivers. > > Cc: Inki Dae > Cc: Laurent Pinchart > Cc: Intel Graphics Development > Cc: Ben Skeggs > Cc: Rob Clark > Cc: Alex

Re: [Intel-gfx] [PATCH 1/1] Documentation: drm: describing drm properties exposed by various drivers

es. > > Also eventually I want to pull these tables directly out of source > code comments - everything else tends to never get updated when the > code changes. On the subject of moving documentation from docbook to source code, do your kerneldoc extensions plans include supporting imag

Re: [Intel-gfx] [PATCH] drm/doc: Discourage usage of MODESET_CTL ioctl

Hi Daniel, Thank you for the patch. On Thursday 15 May 2014 15:00:08 Daniel Vetter wrote: > Leftover from the old days of ums and should be used any longer. Since > > commit 29935554b384b1b3a7377d6f0b03b21d18a61683 > Author: Laurent Pinchart > Date: Wed May 30 00:5

Re: [Intel-gfx] [PATCH v5 1/1] Documentation: drm: describing drm properties exposed by various drivers

gt; + > + > +“contrast” > +RANGE > +Min=0, Max=8192-1 > +Plane > +TBD > + > + > +“brightness” > +RANGE > +Min=0, Max=1024 > +Plane > +TBD > + > + > +“hue” > +RANGE > +Min=0, Max=359 > +Plane > +TBD > + > + > +“saturation” > +RANGE > +Min=0, Max=8192-1 > +Plane > +TBD > + > + > +“iturbt_709” > +RANGE > +Min=0, Max=1 > +Plane > +TBD > + > + > +Nv04 Overlay > +“colorkey” > +RANGE > +Min=0, Max=0x01ff > +Plane > +TBD > + > + > +“brightness” > +RANGE > +Min=0, Max=1024 > +Plane > +TBD > + > + > +Display > +“dithering mode” > +ENUM > +{ "auto", "off", "on" } > +Connector > +TBD > + > + > +“dithering depth” > +ENUM > +{ "auto", "off", "on", "static 2x2", "dynamic 2x2", > "temporal" } +Connector > +TBD > + > + > +“underscan” > +ENUM > +{ "auto", "6 bpc", "8 bpc" } > +Connector > +TBD > + > + > +“underscan hborder” > +RANGE > +Min=0, Max=128 > +Connector > +TBD > + > + > +“underscan vborder” > +RANGE > +Min=0, Max=128 > +Connector > +TBD > + > + > +“vibrant hue” > +RANGE > +Min=0, Max=180 > +Connector > +TBD > + > + > +“color vibrance” > +RANGE > +Min=0, Max=200 > +Connector > +TBD > + > + > +Generic > +Standard name as in DRM > +Standard type as in DRM > +Standard value as in DRM > +Standard Object as in DRM > +TBD > + > + > +omap > +Generic > +“rotation” > +BITMASK > +{ 0, "rotate-0" }, > +{ 1, "rotate-90" }, > +{ 2, "rotate-180" }, > +{ 3, "rotate-270" }, > +{ 4, "reflect-x" }, > +{ 5, "reflect-y" } > +CRTC, Plane > +TBD > + > + > +“zorder” > +RANGE > +Min=0, Max=3 > +CRTC, Plane > +TBD > + > + > +qxl > +Generic > +“hotplug_mode_update" > +RANGE > +Min=0, Max=1 > +Connector > +TBD > + > + > +radeon > +DVI-I > +“coherent” > +RANGE > +Min=0, Max=1 > +Connector > +TBD > + > + > +DAC enable load detect > +“load detection” > +RANGE > +Min=0, Max=1 > +Connector > +TBD > + > + > +TV Standard > +"tv standard" > +ENUM > +{ "ntsc", "pal", "pal-m", "pal-60", "ntsc-j" > +, "scart-pal", "pal-cn", "secam" } > +Connector > +TBD > + > + > +legacy TMDS PLL detect > +"tmds_pll" > +ENUM > +{ "driver", "bios" } > +- > +TBD > + > + > +Underscan > +"underscan" > +ENUM > +{ "off", "on", "auto" } > +Connector > +TBD > + > + > +"underscan hborder" > +RANGE > +Min=0, Max=128 > +Connector > +TBD > + > + > +"underscan vborder" > +RANGE > +Min=0, Max=128 > +Connector > +TBD > + > + > +Audio > +“audio” > +ENUM > +{ "off", "on", "auto" } > +Connector > +TBD > + > + > +FMT Dithering > +“dither” > +ENUM > +{ "off", "on" } > +Connector > +TBD > + > + > +Generic > +Standard name as in DRM > +Standard type as in DRM > +Standard value as in DRM > +Standard Object as in DRM > +TBD > + > + > +rcar-du > +Generic > +"alpha" > +RANGE > +Min=0, Max=255 > +Plane > +TBD > + > + > +"colorkey" > +RANGE > +Min=0, Max=0x01ff > +Plane > +TBD > + > + > +"zpos" > +RANGE > +Min=1, Max=7 > +Plane > +TBD > + > + > + > > > -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 4/4] Documentation: drm: describing plane alpha and color blending property

Hi Sagar, Thank you for the patch. On Saturday 08 March 2014 13:51:19 sagar.a.kam...@intel.com wrote: > From: Sagar Kamble > > Cc: Rob Landley > Cc: Dave Airlie > Cc: Daniel Vetter > Cc: Laurent Pinchart > Cc: David Herrmann > Cc: Alex Deucher > Cc: "Vi

Re: [Intel-gfx] [PATCH 1/1] Documentation: drm: describing drm properties exposed by various drivers

rview. Docbook is indeed hard to read and write when it comes to such tables. However I like having the properties documented in the DRM core documentation. Maybe we could come up with a simpler text format that would be transformed into docbook when compiling the documentation ? -- Reg

Re: [Intel-gfx] [PATCH v6 1/1] Documentation: drm: describing drm properties exposed by various drivers

n refined.[Ville's review comments] > > v4: Removed whitespace warnings and minor nits. [Randy's review comments] > > v5: Restructured output for ENUM properties > > v6: Review comments on formatting the table. [Laurent's review comments] > > Cc: Rob Landley &g

Re: [Intel-gfx] [PATCH v7 1/1] Documentation: drm: describing drm properties exposed by various drivers

cturing. [Laurent's review comments] > > Cc: Rob Landley > Cc: Dave Airlie > Cc: Daniel Vetter > Cc: Laurent Pinchart > Cc: David Herrmann > Cc: Alex Deucher > Cc: "Ville Syrjälä" > Cc: Sagar Kamble > Cc: "Purushothaman, Vijay A" > Cc:

Re: [Intel-gfx] [PATCH 1/1] Documentation: drm: describing drm properties exposed by various drivers

Hi Sagar, On Wednesday 12 March 2014 16:46:05 Sagar Arun Kamble wrote: > On Mon, 2014-03-10 at 15:36 +0100, Laurent Pinchart wrote: > > On Monday 10 March 2014 06:21:49 Daniel Vetter wrote: > > > On Wed, Mar 5, 2014 at 11:56 AM, wrote: > > > > + > > > >

Re: [Intel-gfx] [PATCH v3 1/4] drm: Add struct drm_rect and assorted utility functions

+ * drm_rect_height - determine the rect height > + * @r: rect whose height is returned > + * > + * RETURNS: > + * The height of the rect. > + */ > +static inline int drm_rect_height(const struct drm_rect *r) > +{ > + return r->y2 - r->y1; > +} > + > +/**

Re: [Intel-gfx] [PATCH v3 1/4] drm: Add struct drm_rect and assorted utility functions

Hi Ville, On Thursday 04 April 2013 22:52:37 Ville Syrjälä wrote: > On Thu, Apr 04, 2013 at 06:38:15PM +0200, Laurent Pinchart wrote: > > On Wednesday 27 March 2013 17:46:22 ville.syrj...@linux.intel.com wrote: > > > From: Ville Syrjälä > > > > > > struct dr

Re: [Intel-gfx] [PATCH v4] drm: Add struct drm_rect and assorted utility functions

multiplied by @hscale and @vscale. > + * > + * RETUTRNS: s/RETUTRNS/RETURNS/ > + * %true if rectangle @dst is still visible after being clipped, > + * %false otherwise > + */ Otherwise, Reviewed-by: Laurent Pinchart -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 7/7] drm: Remove some unused stuff from drm_plane

_crtc *crtc; > struct drm_framebuffer *fb; > > - /* CRTC gamma size for reporting to userspace */ > - uint32_t gamma_size; > - uint16_t *gamma_store; > - > - bool enabled; > - > const struct drm_plane_funcs *funcs; > - void *hel

Re: [Intel-gfx] [PATCH 1/7] drm: Add fb_helper->restore_fbdev_mode hook

(*restore_fbdev_mode)(struct drm_fb_helper *fb_helper); Could you please document this new function in the struct drm_fb_helper_funcs kerneldoc block ? > }; > > struct drm_fb_helper_connector { -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2] drm: Remove some unused stuff from drm_plane

Signed-off-by: Ville Syrjälä Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_crtc.c | 2 +- > include/drm/drm_crtc.h | 11 --- > 2 files changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c >

Re: [Intel-gfx] [PATCH v2] drm: Add fb_helper->restore_fbdev_mode hook

t can take care > of such details. > > Initially just plug in drm_fb_helper_restore_fbdev_mode for all > drivers. > > v2: Add kernel-doc for the new hook > > Signed-off-by: Ville Syrjälä Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/ast/ast_fb.c

Re: [Intel-gfx] [RFC 0/4] drm: add raw monotonic timestamp support

|4 +- > kernel/time/timekeeping.c |2 +- > 13 files changed, 113 insertions(+), 61 deletions(-) -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [RFC 0/4] drm: add raw monotonic timestamp support

drm.h |5 +- > include/drm/drmP.h| 38 +++-- > include/drm/drm_mode.h|4 +- > kernel/time/timekeeping.c |2 +- > 13 files changed, 113 insertions(+), 61 deletions(-) -- Regards

Re: [Intel-gfx] [PATCH 1/2] drm: add helper to sort panels to the head of the connector list

m_crtc_helper.h > @@ -137,6 +137,8 @@ extern bool drm_helper_encoder_in_use(struct drm_encoder > *encoder); > > extern void drm_helper_connector_dpms(struct drm_connector *connector, int > mode); > > +extern void drm_helper_move_panel_connectors_to_head(struct drm_device *); > + > ext

Re: [Intel-gfx] [PATCH 1/4] drm/doc: Helpers are not a Midlayer!

; >The CRTC, encoder and connector functions provided by the drivers >implement the DRM API. They're called by the DRM core and ioctl > handlers -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/4] drm/doc: integrate crtc helper api into docbook

x27;ve only looked at > those kerneldoc headers that actually resulted in a complaint from > the kerneldoc parser tool. > > Signed-off-by: Daniel Vetter After fixing the small mistake below, Acked-by: Laurent Pinchart > --- > Documentation/DocBook/drm.tmpl

Re: [Intel-gfx] [PATCH 3/4] drm/doc: integrate fb helper reference into docs

-off-by: Daniel Vetter With the error below fixed, Acked-by: Laurent Pinchart > --- > Documentation/DocBook/drm.tmpl | 5 + > drivers/gpu/drm/drm_fb_helper.c | 19 ++- > 2 files changed, 19 insertions(+), 5 deletions(-) > > diff --git a/Documentation

Re: [Intel-gfx] [PATCH 4/4] drm/doc: add new dp helpers into drm DocBook

+/** > + * struct i2c_algo_dp_aux_data - driver interface structure for i2c over dp > + * aux algo s/algo/algorithm/ ? > + * @running: set by the algo indicating whether an i2c is ongoing or > + * whether the i2c bus is quiescent > + * @address: i2c target address for the currentl

Re: [Intel-gfx] [PATCH 1/1] Documentation: drm: describing drm properties exposed by various drivers

s you to do that > >> and pull in the different libararies (== header files with declarations > >> for C) in the order you want. So imo the docbook toolchain is good enough > >> for my needs. > >> > >> Or what do you mean by getting rid of all docbook usag

Re: [Intel-gfx] [PATCH 1/1] Documentation: drm: describing drm properties exposed by various drivers

On Monday 04 August 2014 09:30:04 Daniel Vetter wrote: > On Fri, Aug 01, 2014 at 02:58:21PM +0200, Laurent Pinchart wrote: > > On Thursday 31 July 2014 15:16:21 Randy Dunlap wrote: > >> On 05/12/14 11:04, Randy Dunlap wrote: > >>> On 05/12/2014 08:54 AM, Daniel Vette

Re: [Intel-gfx] [PATCH] drm/atomic-helper: properly annotate functions in kerneldoc

t; expose > + * drm_atomic_helper_check() and for the commit callback with > + * drm_atomic_helper_commit(). But the individual stages and callbacks are > expose While at it, could you fix the typo here with s/expose/exposed/ ? Apart from that, Acked-by: Laurent Pinchart >

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Add option to update planes only on active crtc

; Also move the check for wether a plane gets a new CRTC assigned while > still in active use out of this patch. > > v4: Rebase over exynos changes. > > Cc: Maarten Lankhorst > Cc: Thierry Reding > Cc: Laurent Pinchart > Signed-off-by: Daniel Vetter > --- > driv

Re: [Intel-gfx] [PATCH 2/2] drm/doc: Update docs about device instance setup

s function still calls the ->load() callback to provide > backwards > + * compatibility with existing drivers. Using that callback is depracated s/depracated/deprecated/ > and > + * when using drm_dev_alloc() and drm_dev_regiter() directly actually s/regiter/register/ > unsafe: > + * Becuase of backwards compatibility needs ->load() is only called _after_ > the s/Becuase/Because/ > + * device instance is already registered. > + * This could be stated more clearly. I'd write NOTE: To ensure backward compatibility with existing drivers that still rely on the deprecated .load() method this function calls the .load() method after registering the device nodes, creating race conditions. Usage of the .load() (and .unload()) methods is deprecated, drivers should perform device initialization before calling drm_dev_register(). > * RETURNS: > * 0 on success, negative error code on failure. > */ -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/doc: Update docs about device instance setup

t; drm_platform_init any more ;-) > > v2: Reword the deprecation note for ->load a bit, using Laurent's > suggestion as an example (but making the wording a bit stronger even). > Fix spelling in commit message. > > Cc: Laurent Pinchart > Cc: David Herrmann >

Re: [Intel-gfx] [PATCH 3/3] drm/atomic-helper: Don't call atomic_update_plane when it stays off

> Cc: dri-de...@lists.freedesktop.org > Cc: Inki Dae > Cc: Matt Roper > Signed-off-by: Daniel Vetter Acked-by: Laurent Pinchart Tested-by: Laurent Pinchart (with the ongoing omapdrm atomic update conversion work) > --- > drivers/gpu/drm/drm_atomic_helper.c | 3 ++- >

Re: [Intel-gfx] [PATCH] drm/i915: Drop pipe_enable checks in vblank funcs

questions Laurent had about how the new > atomic helpers work. > > Cc: Laurent Pinchart > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_irq.c | 52 -- > 1 file changed, 52 deletions(-) > > diff --git a/dri

Re: [Intel-gfx] [PATCH 1/4] drm/irq: Add drm_crtc_vblank_reset

-is. Wouldn't it then be better to modify the core to default to off, and let drivers call drm_crtc_vblank_on() explicitly if the default isn't correct ? I think I like this solution better, and it could be conditioned by a driver flag if we don't want to audit all drivers for po

Re: [Intel-gfx] [PATCH 1/5] drm/irq: Add drm_crtc_vblank_reset

k the vblank pipe as off, > but don't do any vblank counter saving or event flushing - neither of > that is required. > > v2: Clarify the code flow slightly as suggested by Ville. > > Cc: Ville Syrjälä > Cc: Laurent Pinchart > Cc: Imre D

Re: [Intel-gfx] [PATCH 5/5] drm/atomic-helpers: make mode_set hooks optional

tially makes > these callbacks useless for drivers support runtime PM, so make them > optional. Again motivated by discussions with Laurent. > > Cc: Laurent Pinchart > Signed-off-by: Daniel Vetter I think we should go one step further and remove .mode_set() completely for drivers

Re: [Intel-gfx] [PATCH 4/5] drm/atomic-helper: Rename commmit_post/pre_planes

t; So rename them to something more descriptive and update the kerneldoc > a bit. Motivated in a discussion with Laurent about how to restore > plane state for dpms for drivers with runtime pm. > > Cc: Laurent Pinchart > Signed-off-by: Daniel Vetter Acked-by: Laurent

Re: [Intel-gfx] [PATCH 5/5] drm/atomic-helpers: make mode_set hooks optional

Hi Daniel, On Sunday 22 February 2015 19:53:23 Laurent Pinchart wrote: > On Sunday 22 February 2015 12:24:20 Daniel Vetter wrote: > > With runtime PM the hw might still be off while doing the ->mode_set > > callbacks - runtime PM get/put should only happen in the > >

Re: [Intel-gfx] [PATCH 05/14] drm: Check locking in drm_for_each_connector

> \ > + connector = list_first_entry(&(dev)->mode_config.connector_list, \ > + struct drm_connector, head); > \ > + &connector->head != (&(dev)->mode_config.connector_list); > \ > +

Re: [Intel-gfx] [PATCH] drm: Fixup locking WARNINGs in drm_mode_config_reset

lock. > > v2: Drink coffee and all that ... > > Cc: Laurent Pinchart > Reported-by: Laurent Pinchart > Signed-off-by: Daniel Vetter This gets rid of the warning at driver load time with the rcar-du-drm driver. Tested-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_c

Re: [Intel-gfx] [PATCH] scripts/kernel-doc Allow struct arguments documentation in struct body

. The topic of documentation has been raised in the mail thread of the kernel recruitment proposal for the kernel summit. I believe it's an important one, and I will be very interested in contributing if it is discussed as a separate topic. -- Regards, Laurent Pinchart

Re: [PATCH 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

ept const argument. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Laurent Pinchart On a side note, there's only two I2C slave encoder drivers left... I wonder if we could so something about them. The ch7006 and sil164 drivers seem to be used by nouveau only, could they be move

Re: [PATCH 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

On Mon, Nov 18, 2024 at 11:26:03AM +0200, Jani Nikula wrote: > On Mon, 18 Nov 2024, Dmitry Baryshkov wrote: > > On Mon, 18 Nov 2024 at 01:33, Laurent Pinchart wrote: > >> On Mon, Nov 18, 2024 at 01:22:12AM +0200, Dmitry Baryshkov wrote: > >> > On Sun, 17 Nov 2024 at

Re: [PATCH 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

On Mon, Nov 18, 2024 at 01:22:12AM +0200, Dmitry Baryshkov wrote: > On Sun, 17 Nov 2024 at 22:54, Laurent Pinchart wrote: > > On Fri, Nov 15, 2024 at 11:09:26PM +0200, Dmitry Baryshkov wrote: > > > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > &g

Re: [PATCH 4/5] drm/connector: make mode_valid_ctx accept const struct drm_display_mode

ept const argument. I would write "take a const argument" instead of "accept". Same in the other patches. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- > include/drm/drm_modeset_h

Re: [PATCH 5/5] drm/connector: make mode_valid accept const struct drm_display_mode

ept const argument. > > Signed-off-by: Dmitry Baryshkov Assuming you've compile-tested all this, Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 8 > drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +-

Re: [PATCH 3/5] drm/sti: hda: pass const struct drm_display_mode* to hda_get_mode_idx()

llback of drm_connector to accept const > struct drm_display_mode argument. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/sti/sti_hda.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/dr

Re: [PATCH 2/5] drm/amdgpu: don't change mode in amdgpu_dm_connector_mode_valid()

> - drm_mode_set_crtcinfo(mode, 0); > + test_mode = drm_mode_duplicate(connector->dev, mode); > + if (!test_mode) > + goto fail; > + > + drm_mode_set_crtcinfo(test_mode, 0); I wonder if things could be refactored further to avoid t

Re: [PATCH v2 2/3] drm: renesas: rcar-du: annotate rcar_cmm_read() with __maybe_unused

ctions for W=1 build"). > > Signed-off-by: Jani Nikula https://lore.kernel.org/r/20240911095113.gb4...@pendragon.ideasonboard.com I wonder if Dave and Sima are starting to ignore my pull request in the hope I'll switch to using drm-misc :-S I'll send another one. > --- >

Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

; > drivers/gpu/drm/tegra/hdmi.c | 2 +- > > drivers/gpu/drm/tegra/sor.c | 2 +- > > drivers/gpu/drm/vc4/vc4_txp.c| 2 +- > > drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 +- > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 2 +- > > drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 2 +- > > include/drm/display/drm_hdmi_state_helper.h | 2 +- > > include/drm/drm_encoder_slave.h | 2 +- > > include/drm/drm_modeset_helper_vtables.h | 4 ++-- > > 71 files changed, 92 insertions(+), 93 deletions(-) > > --- > > base-commit: 4176cf5c5651c33769de83bb61b0287f4ec7719f > > change-id: 20241115-drm-connector-mode-valid-const-ae3db0ef6cb7 -- Regards, Laurent Pinchart

Re: [PATCH 02/19] drm: Pass pixel_format+modifier directly to drm_get_format_info()

Valkeinen > Cc: Alex Deucher > Cc: Sandy Huang > Cc: "Heiko Stübner" > Cc: Andy Yan > Cc: Thierry Reding > Cc: Mikko Perttunen > Cc: linux-arm-...@vger.kernel.org > Cc: freedr...@lists.freedesktop.org > Cc: nouv...@lists.freedesktop.org > Cc: amd-...@lists.

Re: [PATCH 01/19] drm: Pass pixel_format+modifier to .get_format_info()

was to support formats with auxialiary compression control planes, this won't be possible anymore if we pass cmd->modifier[0] only. Is that an issue, or was this a foreseen use case that never materialized ? If we don't need to support this anymore then the code change is fine, and the documentation should be updated accordingly. >*/ > - const struct drm_format_info *(*get_format_info)(const struct > drm_mode_fb_cmd2 *mode_cmd); > + const struct drm_format_info *(*get_format_info)(u32 pixel_format, u64 > modifier); > > /** >* @mode_valid: -- Regards, Laurent Pinchart

Re: [PATCH 03/19] drm: Look up the format info earlier

-by: Ville Syrjälä Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_framebuffer.c | 25 + > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/drm_framebuffer.c > b/drivers/gpu/drm/drm_framebuffer.c > index

Re: [PATCH 07/19] drm/gem: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct()

struct drm_file *file, > +const struct drm_format_info *info, > const struct drm_mode_fb_cmd2 *mode_cmd, > const struct drm_framebuffer_funcs *funcs); > struct drm_framebuffer * > drm_gem_fb_create_with_funcs(struct drm_device *dev, struct drm_file *file, > + const struct drm_format_info *info, >const struct drm_mode_fb_cmd2 *mode_cmd, >const struct drm_framebuffer_funcs *funcs); > struct drm_framebuffer * -- Regards, Laurent Pinchart

Re: [PATCH 19/19] drm: Make passing of format info to drm_helper_mode_fill_fb_struct() mandatory

; > Signed-off-by: Ville Syrjälä Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_modeset_helper.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_modeset_helper.c > b/drivers/gpu/drm/drm_modeset_helper.c > index

Re: [PATCH 04/19] drm: Pass the format info to .fb_create()

mat_info *info, > const struct drm_mode_fb_cmd2 *mode_cmd); > ... > }; > > Cc: Alex Deucher > Cc: Liviu Dudau > Cc: Maxime Ripard > Cc: Russell King > Cc: Inki Dae > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Patrik Jak

<    1   2   3   4   >