Re: [Intel-gfx] [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

* verifies the source of CRC checksums of frames before setting the > + * source for CRC and during crc open. > + * > + * This callback is optional if the driver does not support any CRC > + * generation functionality. > +

Re: [Intel-gfx] [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

upport exporting of > + * possible CRC sources list. CRC-core does the verification of sources. > + * > + * RETURNS: > + * > + * a constant character pointer to the list of all the available CRC > + * sources > + */ > + const char *const *(*get_crc_sources)(struct drm_crtc *crtc, > + size_t *count); > > /** >* @atomic_print_state: -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

@@ static const struct drm_crtc_funcs crtc_funcs_gen3 = { > .enable_vblank = rcar_du_crtc_enable_vblank, > .disable_vblank = rcar_du_crtc_disable_vblank, > .set_crc_source = rcar_du_crtc_set_crc_source, > + .verify_crc_source = rcar_du_crtc_verify_crc_source, > }; > > /* -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

gt;f_inode->i_private; > struct drm_crtc_crc *crc = &crtc->crc; > - size_t values_cnt; > > - crtc->funcs->set_crc_source(crtc, NULL, &values_cnt); > + crtc->funcs->set_crc_source(crtc, NULL); > > spin_lock_irq(&crc->lock); > crtc_crc_cleanup(crc); > @@ -370,7 +362,7 @@ int drm_debugfs_crtc_crc_add(struct drm_crtc *crtc) > { > struct dentry *crc_ent, *ent; > > - if (!crtc->funcs->set_crc_source) > + if (!crtc->funcs->set_crc_source || !crtc->funcs->verify_crc_source) > return 0; > > crc_ent = debugfs_create_dir("crc", crtc->debugfs_entry); [snip] -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 09/10] Revert "drm: crc: Wait for a frame before returning from open()"

ter read call, it can use > poll/read blocking read() call. > > Suggested-by: Ville Syrjälä > Signed-off-by: Mahesh Kumar > Cc: dri-de...@lists.freedesktop.org > Cc: Tomeu Vizoso Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_debugfs_crc.c | 16 ---

Re: [Intel-gfx] [PATCH 10/10] drm: crc: Introduce pre_crc_read function

s not support CRC > + * generation or no prework is required before reading the crc > + * > + * RETURNS: > + * > + * 0 on success or a negative error code on failure. > + */ > + int (*pre_crc_read)(struct drm_crtc *crtc); > > /** >

Re: [Intel-gfx] [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

Hi Mahesh, On Tuesday, 10 July 2018 15:01:38 EEST Kumar, Mahesh wrote: > On 7/10/2018 4:52 PM, Laurent Pinchart wrote: > > Hi Mahesh, > > On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote: > >> This patch introduce a callback function "get_crc_sources" whi

Re: [Intel-gfx] [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

Hi Mahesh, On Tuesday, 10 July 2018 14:54:11 EEST Kumar, Mahesh wrote: > On 7/10/2018 4:56 PM, Laurent Pinchart wrote: > > On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote: > >> This patch adds a new callback function "verify_crc_source" which will > &g

Re: [Intel-gfx] [PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

Hi Mahesh, On Tuesday, 10 July 2018 15:59:11 EEST Kumar, Mahesh wrote: > On 7/10/2018 5:07 PM, Laurent Pinchart wrote: > > On Monday, 2 July 2018 14:07:24 EEST Mahesh Kumar wrote: > >> This patch implements "verify_crc_source" callback function for > >> rcar

Re: [Intel-gfx] [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

g string for source. > > Changes since V1: > - do not yet verify_crc_source during open. > > Signed-off-by: Mahesh Kumar > Cc: dri-de...@lists.freedesktop.org > Cc: Laurent Pinchart > Reviewed-by: Maarten Lankhorst > --- > drivers/gpu/drm/drm_debugfs_crc.c | 8 +

Re: [Intel-gfx] [PATCH 00/10] Improve crc-core driver interface

+ > drivers/gpu/drm/rcar-du/rcar_du_kms.h | 1 + > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 26 - > include/drm/drm_crtc.h | 40 ++- > 14 files changed, 396 insertions(+), 74 deletions(-) -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

-core > Changes Since V2: > - update commit message > - update callback documentation > - print one source name per line > > Signed-off-by: Mahesh Kumar > Cc: dri-de...@lists.freedesktop.org > Cc: Laurent Pinchart > Reviewed-by: Maarten Lankhorst > --- > drivers

Re: [Intel-gfx] [PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

-by: Mahesh Kumar > Cc: dri-de...@lists.freedesktop.org > Cc: Laurent Pinchart > Reviewed-by: Maarten Lankhorst > --- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 66 --- > 1 file changed, 53 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

y allocation. > Now set_crc_source takes only two variable inputs, values_cnt we > already gets as part of verify_crc_source. > > Changes since V1: > - refactor code to use single spin lock > > Signed-off-by: Mahesh Kumar > Cc: dri-de...@lists.freedesktop.org > Cc: L

Re: [Intel-gfx] [PATCH 10/10] drm/rcar-du/crc: Implement get_crc_sources callback

Hi Mahesh, Thank you for the patch. On Thursday, 12 July 2018 11:36:35 EEST Mahesh Kumar wrote: > This patch implements get_crc_sources callback, which returns list of > all the crc sources supported by driver in current platform. > > Signed-off-by: Mahesh Kumar > Cc: L

Re: [Intel-gfx] [PATCH v4 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

r optimize the code > > Signed-off-by: Mahesh Kumar > Cc: dri-de...@lists.freedesktop.org > Cc: Laurent Pinchart > Reviewed-by: Maarten Lankhorst > --- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 71 +-- > 1 file changed, 51 insertions(+), 20

Re: [Intel-gfx] [PATCH v4 10/10] drm/rcar-du/crc: Implement get_crc_sources callback

-crtc > - init sources-list only for gen3 > > Signed-off-by: Mahesh Kumar > Cc: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 96 ++- > drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 3 ++ > 2 files changed, 98 insertions(+), 1 de

Re: [Intel-gfx] [PATCH v5 10/10] drm/rcar-du/crc: Implement get_crc_sources callback

-crtc > - init sources-list only for gen3 > Changes Since V2: > - Adopt to driver style > - Address other review comments from Laurent Pinchart I'm pretty sure this has changed since v4 as well. > Signed-off-by: Mahesh Kumar > Cc: dri-de...@lists.freedesktop.org > Cc: L

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

, the 1920x2160 res fbdev should still be ok, as only > 1920x1080 is actually displayed at one time. > > So it seems like we might need to multiply the max_height by the > overalloc factor when we are checking it in > drm_internal_framebuffer_create? > > Does that approach sou

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

Hi John, On Thursday, 23 August 2018 20:48:40 EEST John Stultz wrote: > On Thu, Aug 23, 2018 at 1:09 AM, Daniel Vetter wrote: > > On Thu, Aug 23, 2018 at 10:46:15AM +0300, Laurent Pinchart wrote: > >> On Thursday, 23 August 2018 07:14:08 EEST John Stultz wrote: > >>&

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

Hi John, On Friday, 24 August 2018 00:12:46 EEST John Stultz wrote: > On Thu, Aug 23, 2018 at 1:49 PM, Laurent Pinchart wrote: > > On Thursday, 23 August 2018 20:48:40 EEST John Stultz wrote: > >> On Thu, Aug 23, 2018 at 1:09 AM, Daniel Vetter wrote: > >>> On T

Re: [Intel-gfx] [PATCH igt 2/8] tests/kms_panel_fitting: check for i915 before checking version

? Can't we replace the Intel generation check with a different feature check ? > for_each_pipe_with_valid_output(display, pipe, output) { -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH igt 1/8] tests/kms_addfb_basic: skip i915-specific tests on other platforms

Hi Ulrich, Thank you for the patch. On Thursday, 15 March 2018 16:45:37 EET Ulrich Hecht wrote: > Add is_i915_device() requirement to tests using Intel-specific APIs. > > Signed-off-by: Ulrich Hecht Reviewed-by: Laurent Pinchart > --- > tests/kms_addfb_basic.c | 3 +++ >

Re: [Intel-gfx] [PATCH igt 0/8] Non-Intel test suite fixes

;s good news ! (Not that I'm happy that we have bugs, but catching them shows that igt is useful for us). I hope this will help convincing management that we should keep contributing to igt going forward. Ulrich, for the record, I agree with all of Daniel's and Ville's comments poste

Re: [Intel-gfx] [PATCH igt 2/8] tests/kms_panel_fitting: check for i915 before checking version

Hi Daniel, On Wednesday, 21 March 2018 10:34:33 EET Daniel Vetter wrote: > On Tue, Mar 20, 2018 at 01:24:09PM +0200, Laurent Pinchart wrote: > > Hi Ulrich, > > > > Thank you for the patch. > > > > On Thursday, 15 March 2018 16:45:38 EET Ulrich Hecht wrote: &

Re: [Intel-gfx] [drm-tip:drm-tip 711/734] drivers/gpu/drm/rcar-du/rcar_du_vsp.c:317:6: error: 'struct rcar_du_vsp_plane_state' has no member named 'alpha'

Hi Dave, On Thursday, 17 May 2018 08:05:03 EEST Dave Airlie wrote: > On 17 May 2018 at 14:42, Dave Airlie wrote: > > On 16 May 2018 at 01:37, Laurent Pinchart wrote: > >> On Tuesday, 15 May 2018 17:24:52 EEST kbuild test robot wrote: > >>> tree: git://anongit.f

Re: [Intel-gfx] [PATCH 04/26] drm/rcar-du: Use for_each_*_in_state

continue; > - > - plane = to_rcar_plane(state->planes[i]); > - plane_state = to_rcar_plane_state(state->plane_states[i]); > + plane = to_rcar_plane(drm_plane); > + plane_state = to_rcar_plane_state(drm_plane_state); > > dev_dbg(rcdu->dev, "%s: allocating plane (%u,%tu)\n", __func__, > plane->group->index, plane - plane->group->planes); -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 09/20] drm: rcar-du: Rely on the default ->best_encoder() behavior

rcar_du_vga_connector_init(), it's not needed anymore. The same code in rcar_du_hdmi_connector_init() has to stay for now though, as it's used to locate the slave encoder in the HDMI support code. That should change when the driver will be converted to use drm_bridge. I can also fix this

Re: [Intel-gfx] [PATCH 16/20] drm: omap: Rely on the default ->best_encoder() behavior

der *omap_connector_attached_encoder( > - struct drm_connector *connector) > -{ > - struct omap_connector *omap_connector = to_omap_connector(connector); > - return omap_connector->encoder; The omap_connector::encoder field is assigned but not used anymore, you can remov

Re: [Intel-gfx] [PATCH 01/20] drm/atomic: Fix remaining places where !funcs->best_encoder is valid

* NULL we fallback to the default drm_atomic_helper_best_encoder() > + * helper. > + */ > + if (fb_helper->dev->mode_config.funcs->atomic_commit && > + !connector_funcs->best_encoder) > + encoder = drm_atom

Re: [Intel-gfx] [PATCH 06/38] drm/omap: Use for_each_plane_in_state

Hi Daniel, Thank you for the patch. On Thursday 02 Jun 2016 00:06:29 Daniel Vetter wrote: > We want to hide drm_atomic_stat internals a bit better. > > Cc: Laurent Pinchart > Cc: Tomi Valkeinen > Signed-off-by: Daniel Vetter Acked-by: Laurent Pinchart > --- > dr

Re: [Intel-gfx] [PATCH 04/38] drm/rcar-du: Use for_each_*_in_state

Hi Daniel, Thank you for the patch. On Thursday 02 Jun 2016 00:06:27 Daniel Vetter wrote: > We want to hide drm_atomic_state internals better. > > Cc: Laurent Pinchart > Signed-off-by: Daniel Vetter Acked-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/rc

Re: [Intel-gfx] [PATCH 04/26] drm/rcar-du: Use for_each_*_in_state

Hi Daniel, On Monday 30 May 2016 16:54:10 Daniel Vetter wrote: > On Mon, May 30, 2016 at 11:58:27AM +0200, Maarten Lankhorst wrote: > > Op 30-05-16 om 11:18 schreef Laurent Pinchart: > >> Hi Daniel, > >> > >> Thank you for the patch. > >> > &

Re: [Intel-gfx] [PATCH 04/26] drm/rcar-du: Use for_each_*_in_state

Hi Daniel, On Friday 03 Jun 2016 08:55:36 Daniel Vetter wrote: > On Fri, Jun 03, 2016 at 01:54:44AM +0300, Laurent Pinchart wrote: > > On Monday 30 May 2016 16:54:10 Daniel Vetter wrote: > >> On Mon, May 30, 2016 at 11:58:27AM +0200, Maarten Lankhorst wrote: > >>>

Re: [Intel-gfx] [PATCH 04/26] drm/rcar-du: Use for_each_*_in_state

Hi Daniel, On Friday 03 Jun 2016 11:45:56 Daniel Vetter wrote: > On Fri, Jun 3, 2016 at 11:40 AM, Laurent Pinchart wrote: > > On Friday 03 Jun 2016 08:55:36 Daniel Vetter wrote: > >> On Fri, Jun 03, 2016 at 01:54:44AM +0300, Laurent Pinchart wrote: > >>> On Mond

Re: [Intel-gfx] [PATCH 10/16] drm: Don't call drm_dev_set_unique from platform drivers

Philipp Zabel > Cc: Maxime Ripard > Cc: Laurent Pinchart > Cc: Emil Velikov > Signed-off-by: Daniel Vetter Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_drv.c | 35 +- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2

Re: [Intel-gfx] [PATCH 7/7] drm/rcar-du: Remove redundant calls to drm_connector_register_all()

an > move drm_connector_register_all() to drm_dev_register() and not suffer > from any backwards compatibility issues with drivers not following the > more rigorous init ordering. > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > Cc: Laurent Pinchart &g

Re: [Intel-gfx] [PATCH 1/5] [RFC] drm: Documentation style guide

ctures: Either in the comment for the lock explaining what it > > + protects, or data fields need a note about which lock protects > > them, or > > + both. > > + > > + > > + Functions which have a non-void return value should > > ha

Re: [Intel-gfx] [PATCH] drm: Documentation style guide

fixes from Pierre, Laurent and Jani. > > Nah, you ignored my comment about "these documentations use American > English". :/ Isn't documentation uncountable when meaning information recorded in a document ? -- Regards, Laurent Pinchart _

Re: [Intel-gfx] [PATCH] drm: Documentation style guide

On Wednesday 09 December 2015 16:17:47 Jani Nikula wrote: > On Wed, 09 Dec 2015, Laurent Pinchart wrote: > > On Wednesday 09 December 2015 13:21:09 Jani Nikula wrote: > >> On Wed, 09 Dec 2015, Daniel Vetter wrote: > >> > Every time I type or review docs this

Re: [Intel-gfx] [PATCH 12/15] drm: RIP mode_config->rotation_property

ramebuffer. >*/ > @@ -2960,8 +2955,6 @@ extern int drm_mode_plane_set_obj_prop(struct > drm_plane *plane, struct drm_property *property, > uint64_t value); > > -extern struct drm_property *drm_mode_create_rotation_property(struct > drm_device *dev, - unsigned int supported_rotations); > extern int drm_plane_create_rotation_property(struct drm_plane *plane, > unsigned int rotation, > unsigned int supported_rotations); -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 12/15] drm: RIP mode_config->rotation_property

Hi Daniel, On Tuesday 18 Oct 2016 09:36:23 Daniel Vetter wrote: > On Tue, Oct 18, 2016 at 01:38:05AM +0300, Laurent Pinchart wrote: > > On Friday 22 Jul 2016 16:43:13 ville.syrj...@linux.intel.com wrote: > >> From: Ville Syrjälä > >> > >> Now that all drivers

Re: [Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()

a quick explanation or point me to a doc/page that > explains how the various trees and branches get merged? > I googled a bit and found this doc [4] by Jani, but it doesn't mention > drm-misc for instance, so I'm not sure how up-to-date and >

Re: [Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()

Hi Jani, On Thursday 10 Nov 2016 12:30:09 Jani Nikula wrote: > On Thu, 10 Nov 2016, Laurent Pinchart wrote: > > On Wednesday 09 Nov 2016 16:59:31 Eric Engestrom wrote: > >> On Wednesday, 2016-11-09 14:13:40 +0100, Daniel Vetter wrote: > >>> On Wed, Nov 9, 2016 at

Re: [Intel-gfx] [PATCH 36/37] drm: Add mode_config .get_format_info() hook

format_info: > + * > + * Allows a driver to return custom format information for special > + * fb layouts (eg. ones with auxiliary compresssion control planes). > + * > + * RETURNS: > + * > + * The format information specific to the given fb metadata, or > + * NULL if none is found. > + */ > + const struct drm_format_info *(*get_format_info)(struct drm_device *dev, > + const struct drm_mode_fb_cmd2 *mode_cmd); > + > + /** >* @output_poll_changed: >* >* Callback used by helpers to inform the driver of output configuration -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 36/37] drm: Add mode_config .get_format_info() hook

Hi Ville, On Monday 21 Nov 2016 15:18:23 Ville Syrjälä wrote: > On Sun, Nov 20, 2016 at 10:13:10AM +0200, Laurent Pinchart wrote: > > On Friday 18 Nov 2016 21:53:12 ville.syrj...@linux.intel.com wrote: > >> From: Ville Syrjälä > >> > >> Allow drivers to retur

Re: [Intel-gfx] [PATCH 36/37] drm: Add mode_config .get_format_info() hook

Hi Ville, On Monday 21 Nov 2016 15:31:57 Ville Syrjälä wrote: > On Mon, Nov 21, 2016 at 03:23:19PM +0200, Laurent Pinchart wrote: > > On Monday 21 Nov 2016 15:18:23 Ville Syrjälä wrote: > >> On Sun, Nov 20, 2016 at 10:13:10AM +0200, Laurent Pinchart wrote: > >>>

Re: [Intel-gfx] [PATCH 2/6] drm/atomic: Unconditionally call prepare_fb.

ate; > > > > if (funcs->cleanup_fb) > > > > @@ -1952,9 +1946,6 @@ void drm_atomic_helper_cleanup_planes(struct > > drm_device *dev,> > > for_each_plane_in_state(old_state, plane, plane_state, i) { > >

Re: [Intel-gfx] [PATCH 06/34] drm: Add a simple linear congruent generator PRNG

Chris Wilson This doesn't seem very DRM-specific, is there a reason why we can't use the ansi_cprng already present in the kernel ? -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm: Provide a driver hook for drm_dev_release()

*); > + > int (*dma_ioctl) (struct drm_device *dev, void *data, struct drm_file > *file_priv); > int (*dma_quiescent) (struct drm_device *); > int (*context_dtor) (struct drm_device *dev, int context); -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/6] drm/atomic: Unconditionally call prepare_fb.

Hi Maarten, On Tuesday 13 Dec 2016 15:13:54 Maarten Lankhorst wrote: > Op 09-12-16 om 09:25 schreef Daniel Vetter: > > On Fri, Dec 09, 2016 at 12:42:19AM +0200, Laurent Pinchart wrote: > >> On Thursday 08 Dec 2016 16:41:04 Daniel Vetter wrote: > >>> On Thu, De

Re: [Intel-gfx] [PATCH v2 2/6] drm/atomic: Unconditionally call prepare_fb.

On Fri, Dec 09, 2016 at 12:42:19AM +0200, Laurent Pinchart wrote: > >>>> On Thursday 08 Dec 2016 16:41:04 Daniel Vetter wrote: > >>>>> On Thu, Dec 08, 2016 at 02:45:25PM +0100, Maarten Lankhorst wrote: > >>>>>> Atomic drivers may set propertie

Re: [Intel-gfx] [PATCH 07/12] drm/rcar-du: Rename async to nonblock.

Hi Maarten, Thank you for the patch. On Tuesday 26 Apr 2016 16:11:40 Maarten Lankhorst wrote: > The async name is deprecated and should be changed to nonblocking. > > Cc: Laurent Pinchart > Signed-off-by: Maarten Lankhorst Acked-by: Laurent Pinchart > --- > drive

Re: [Intel-gfx] [PATCH 1/3] drm: Drop crtc argument from __drm_atomic_helper_crtc_destroy_state

troy_state); > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 1e7692a10c83..cde9b5af7553 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -897,7 +897,7 @@ int drm_connector_init(struct drm_device *dev, > struct ida *connec

Re: [Intel-gfx] [PATCH 2/3] drm: Drop crtc argument from __drm_atomic_helper_connector_destroy_state

Hi Daniel, Thank you for the patch. On Friday 06 May 2016 10:32:29 Daniel Vetter wrote: > It's unused, and really this helper should only look at the state > structure and nothing else. > > Cc: Maarten Lankhorst > Cc: Thierry Reding > Cc: Eric Anholt > Cc: Lauren

Re: [Intel-gfx] [PATCH 3/3] drm: Drop crtc argument from __drm_atomic_helper_connector_destroy_state

Hi Daniel, Thank you for the patch. s/crtc/connector/ in the subject (I've just realized that the same comment applies to patch 2/3, with s/connector/plane/ as well). Apart from that, Acked-by: Laurent Pinchart On Friday 06 May 2016 10:32:30 Daniel Vetter wrote: > It's unuse

Re: [Intel-gfx] [PATCH] drm: Nuke ->vblank_disable_allowed

for DRIVER_MODESET in drm_vblank_init. > > Stumbled over this in a discussion on irc with Chris. > > v2: Remove leftover debug gunk from psr hacking (Alex). > > Cc: Chris Wilson > Cc: Alex Deucher > Cc: Liviu Dudau > Cc: Russell King > Cc: Thierry Reding >

Re: [Intel-gfx] [PATCH 01/46] drm: Provide a driver hook for drm_dev_release()

rm_dev_init() to note that driver->release() > allows for arbitrary embedding. > > Signed-off-by: Chris Wilson > Cc: Laurent Pinchart > Cc: Daniel Vetter > --- > drivers/gpu/drm/drm_drv.c | 65 ++-- > include/drm/drm_drv.h

Re: [Intel-gfx] [PATCH v3 1/7] drm/atomic: Add new iterators over all state, v3.

Hi Daniel, On Monday 23 Jan 2017 09:48:54 Daniel Vetter wrote: > On Thu, Jan 19, 2017 at 12:56:29AM +0200, Laurent Pinchart wrote: > > On Tuesday 17 Jan 2017 08:41:03 Maarten Lankhorst wrote: > >> Op 17-01-17 om 00:11 schreef Laurent Pinchart: > >>> On Monda

Re: [Intel-gfx] [PATCH v3 1/7] drm/atomic: Add new iterators over all state, v3.

ommitting the state. > > Changes since v1: > - Remove nonblock parameter for commit_duplicated_state. > Changes since v2: > - Use commit_duplicated_state for i915 load detection. > - Add WARN_ON(old_state != obj->state) before swapping. > > Signed-off-by: Maarten La

Re: [Intel-gfx] [PATCH v3 0/7] drm/atomic: Add accessor macros for all atomic state.

rm_atomic.c | 39 ++-- > drivers/gpu/drm/drm_atomic_helper.c | 377 ++-- > drivers/gpu/drm/drm_blend.c | 23 +-- > drivers/gpu/drm/i915/intel_display.c | 13 +- > include/drm/drm_atomic.h | 180 - > include/drm/drm_atomi

Re: [Intel-gfx] [PATCH v3 3/7] drm/atomic: Use new atomic iterator macros.

Hi Daniel, On Tuesday 14 Feb 2017 21:03:07 Daniel Vetter wrote: > On Tue, Jan 17, 2017 at 01:55:50AM +0200, Laurent Pinchart wrote: > > On Monday 16 Jan 2017 10:37:40 Maarten Lankhorst wrote: > > > > Could we please get a description ? Apart from that, > > Typed som

Re: [Intel-gfx] [PATCH] drm: Clean up pending events in the core

e/drm/drmP.h b/include/drm/drmP.h > index ae73abf5c2cf..3d78a7406d54 100644 > --- a/include/drm/drmP.h > +++ b/include/drm/drmP.h > @@ -283,6 +283,7 @@ struct drm_ioctl_desc { > struct drm_pending_event { > struct drm_event *event; > struct list_head link; > + struct list_head pending_link; > struct drm_file *file_priv; > pid_t pid; /* pid of requester, no guarantee it's valid by the time > we deliver the event, for tracing only */ > @@ -346,6 +347,7 @@ struct drm_file { > struct list_head blobs; > > wait_queue_head_t event_wait; > + struct list_head pending_event_list; > struct list_head event_list; > int event_space; -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/5] drm/shmob: Nuke preclose hook

Hi Daniel, Thank you for the patch. On Sunday 10 January 2016 23:26:06 Daniel Vetter wrote: > Again since the drm core takes care of event unlinking/disarming this > is now just needless code. > > v2: Fixup misplaced hunk. > > Cc: Laurent Pinchart > Signed-off-by: Danie

Re: [Intel-gfx] [PATCH 16/21] drm/rcar: Nuke preclose hook

me at the moment :-) After closing the "[PATCH] drm: Clean up pending events in the core" discussion (and assuming the conclusion is that is works), Reviewed-by: Laurent Pinchart > Cc: Laurent Pinchart > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm

Re: [Intel-gfx] [PATCH 15/21] drm/omap: Nuke close hooks

Hi Daniel, Thank you for the patch. On Friday 08 January 2016 21:36:47 Daniel Vetter wrote: > Again since the core takes care of this we can remove them. While at > it also remove the postclose hook, it's empty. > > Cc: Laurent Pinchart > Cc: Tomi Valkeinen > Signe

Re: [Intel-gfx] [PATCH] drm/omap: Nuke close hooks

> v3: Remove unused flags (Tomi). > > Cc: Laurent Pinchart > Cc: Tomi Valkeinen > Acked-by: Daniel Stone > Reviewed-by: Alex Deucher > Signed-off-by: Daniel Vetter Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/omap_crtc.c | 13 +

Re: [Intel-gfx] [PATCH 02/22] drm: Add functions to setup/tear down drm_events.

g more weird/subtle, then > breaks it in a fun way). > > Based upon a patch from Rob Clark, rebased and polished. > > v2: Spelling fixes (Alex). > > Cc: Alex Deucher > Acked-by: Daniel Stone > Reviewed-by: Alex Deucher > Cc: Rob Clark > Signed-off-by:

Re: [Intel-gfx] [PATCH 09/22] drm: Clean up pending events in the core

3: Improve wording of the kerneldoc and split out vblank cleanup (Laurent). > > Cc: Alex Deucher > Cc: Laurent Pinchart Reviewed-by: Laurent Pinchart > Acked-by: Daniel Stone > Reviewed-by: Alex Deucher (v1) > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm

Re: [Intel-gfx] [PATCH] drm: Clean up pending events in the core

Hi Daniel, On Monday 11 January 2016 14:51:46 Daniel Stone wrote: > On 10 January 2016 at 23:48, Laurent Pinchart wrote: > > On Saturday 09 January 2016 14:28:46 Daniel Vetter wrote: > >> @@ -353,18 +354,16 @@ static void drm_events_release(struct drm_fi

Re: [Intel-gfx] [PATCH 05/22] drm: Create drm_send_event helpers

the core code in > drm_fops.c. And that is interruptible. > > v2: Adjust existing kerneldoc too. > > Reviewed-by: Alex Deucher (v1) > Acked-by: Daniel Stone > Cc: Alex Deucher > Cc: Thomas Hellstrom > Cc: Inki Dae > Signed-off-by: Daniel Vetter Reviewed-by: Laurent

Re: [Intel-gfx] [PATCH 10/22] drm: Nuke vblank event file cleanup code

y have a > drm_vblank_put. > > Cc: Laurent Pinchart > Acked-by: Daniel Stone > Reviewed-by: Alex Deucher > Signed-off-by: Daniel Vetter Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_fops.c | 9 - > 1 file changed, 9 deletions(-) > > diff --gi

Re: [Intel-gfx] [PATCH] drm/fbdev-helper: Explain how to debug console_lock fun

t to consoles, not even serial console. Which means when your Similarly, s/Which means when/This means that if/ > + * driver crashes, you will see absolutely nothing else but a system stuck > in > + * this function, with no further output. And any kind of printk() you s/And any/Any/ A

Re: [Intel-gfx] [PATCH 09/13] drm/shmob: Drop drm_vblank_cleanup

ultimately from drm_dev_release(), calls drm_vblank_cleanup(). The commit message could be a bit more explicit. Apart from that, Acked-by: Laurent Pinchart > Cc: Laurent Pinchart > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 +--- > 1 file chang

Re: [Intel-gfx] [PATCH 2/2] drm/hdmi: Allow HDMI infoframe without VIC or S3D

sil-sii8620 doesn't have a connector around when > >> + * we need one, so we have to be prepared for a NULL connector. > >> + */ > >> + bool has_hdmi_infoframe = connector ? > >> + &connector->display_info.has_hdmi_infoframe : NULL; > >

Re: [Intel-gfx] [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

s/gpu/drm/rcar-du/rcar_du_lvdscon.c | 1 - For the above, Reviewed-by: Laurent Pinchart -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 3/7] drm/rcar-du: Use new iterator macros, v2.

n use. They should be the same except when reallocating, > (in which case this code is skipped) and we should really stop looking > at obj->state whenever possible. > > Changes since v1: > - Actually compile correctly. > > Signed-off-by: Maarten Lankhorst &

Re: [Intel-gfx] [PATCH v2 3/7] drm/rcar-du: Use new iterator macros, v2.

Hi Maarten, On Wednesday 26 Jul 2017 14:53:33 Laurent Pinchart wrote: > On Wednesday 19 Jul 2017 16:39:16 Maarten Lankhorst wrote: > > for_each_obj_in_state is about to be removed, so use the correct new > > iterator macros. > > > > Also look at new_plane_state i

Re: [Intel-gfx] [PATCH 1/8] drm/omap: Simplify the rotation-on-crtc hack

gt; v2: don't forget zorder and get_property! > >> > >> Cc: Tomi Valkeinen >> Cc: Laurent Pinchart > >> Signed-off-by: Daniel Vetter > >> --- > >> > >> drivers/gpu/drm/omapdrm/omap_crtc.c | 64 ++- >

Re: [Intel-gfx] [PATCH] Add drm ioctl DRM_IOCTL_MODE_GETFB2 & associated helpers.

> index b2c52843bc70..c81c75335cca 100644 > --- a/include/uapi/drm/drm.h > +++ b/include/uapi/drm/drm.h > @@ -814,6 +814,8 @@ extern "C" { > #define DRM_IOCTL_MODE_CREATEPROPBLOBDRM_IOWR(0xBD, struct > drm_mode_create_blob) > #define DRM_IOCTL_MODE_DESTROYPROPB

Re: [Intel-gfx] [PATCH] Add drm ioctl DRM_IOCTL_MODE_GETFB2 & associated helpers.

Hi Joe, On Tuesday 01 Aug 2017 10:24:25 Joe Kniss wrote: > On Tue, Aug 1, 2017 at 5:09 AM, Laurent Pinchart wrote: > > On Monday 31 Jul 2017 11:29:13 Joe Kniss wrote: > >> New getfb2 functionality uses drm_mode_fb_cmd2 struct to be symmetric > >> with addfb2. > >

Re: [Intel-gfx] [PATCH 0/8] drm/fb-helper: Use drm_file to get a dumb framebuffer

| 2 + > include/drm/drm_fb_helper.h | 9 + > include/drm/drm_file.h | 2 + > include/drm/drm_framebuffer.h | 4 + > 11 files changed, 305 insertions(+), 237 deletions(-) -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 0/8] drm/fb-helper: Use drm_file to get a dumb framebuffer

Hi Noralf, On Wednesday, 13 September 2017 18:19:22 EEST Noralf Trønnes wrote: > Den 13.09.2017 07.09, skrev Laurent Pinchart: > > On Monday, 11 September 2017 17:31:54 EEST Noralf Trønnes wrote: > >> Hi, > >> > >> I want to start out by saying that this patc

Re: [Intel-gfx] [PATCH v2] drm: gem_cma_helper.c: Allow importing of contiguous scatterlists with nents > 1

buffer with multiple entries that > have consecutive sg_dma_addresses, effectively making it contiguous. > Allow for that scenario by testing the entries in the sg_table for > contiguous coverage. > > Reviewed-by: Laurent Pinchart > Signed-off-by: Liviu Dudau > --- > > Laure

Re: [Intel-gfx] [PATCH 3/5] drm/vmwgfx: Try to fix plane clipping

the hardware. That's why I use it in rcar-du. Are drivers allowed to adjust the hdisplay and vdisplay values though ? I thought unsupported values there had to be rejected with an error at atomic check time, not adjusted. > I guess I just volunteered myself to do this. Just needs plenty

Re: [Intel-gfx] [PATCH 4/5] drm: Check crtc_state->enable rather than crtc->enabled in drm_plane_helper_check_state()

hange should be reverted when the function is dropped, otherwise we'll carry the CRTC state argument for a long time without realizing it's not needed anymore. Apart from that, Reviewed-by: Laurent Pinchart > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/arm/hdlcd

Re: [Intel-gfx] [PATCH 5/5] drm: Move drm_plane_helper_check_state() into drm_atomic_helper.c

> drm_atomic_helper.c. > > Cc: Daniel Vetter > Suggested-by: Daniel Vetter > Signed-off-by: Ville Syrjälä I would move this patch before 4/5 to make it easier to revert 4/5 (for the reason explaining as a reply to that patch). Reviewed-by: Laurent Pinchart > --- > driver

Re: [Intel-gfx] [PATCH 1/5] drm/vmwgfx: Remove bogus crtc coords vs fb size check

hich have been checked by the core already. > > Cc: VMware Graphics > Cc: Sinclair Yeh > Cc: Thomas Hellstrom > Signed-off-by: Ville Syrjälä Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 -- > 1 file changed, 6 deletions(-) > &g

Re: [Intel-gfx] [PATCH 2/5] drm/vmwgfx: Use drm_plane_helper_check_state()

: VMware Graphics > Cc: Sinclair Yeh > Cc: Thomas Hellstrom > Signed-off-by: Ville Syrjälä Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 17 +++-- > 1 file changed, 3 insertions(+), 14 deletions(-) > > diff --git a/drivers/

Re: [Intel-gfx] [PATCH 0/5] drm: drm_plane_helper_check_state() related stuff

ushed to drm-misc-next. Thanks for the reviews. And I now realize my review comments aren't very useful (apart possibly the one about adding a comment to the drm_plane_helper_check_update() function, feel free to submit a patch for that if you think it's useful) as the series has been merged already :-/ I should really start reading mails in the reverse chronological order. -- Regards, Laurent Pinchart ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 5/8] drm: Nuke drm_atomic_helper_plane_set_property

, Reviewed-by: Laurent Pinchart > Signed-off-by: Daniel Vetter > Cc: Liviu Dudau > Cc: Brian Starkey > Cc: Mali DP Maintainers > Cc: Boris Brezillon > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: Sean Paul > Cc: David Airlie > Cc: Inki Dae > Cc: Joonyou

Re: [Intel-gfx] [PATCH 2/8] drm: Don't update property values for atomic drivers

continue; > > if (*arg_count_props > count) { > - ret = drm_object_property_get_value(obj, prop, &val); > + ret = __drm_object_property_get_value(obj, prop, &val); > if (ret) >

Re: [Intel-gfx] [PATCH 2/8] drm: Don't update property values for atomic drivers

On Monday 14 Aug 2017 09:25:47 Daniel Vetter wrote: > On Sat, Aug 12, 2017 at 12:20 AM, Laurent Pinchart > > wrote: > > On Tuesday 25 Jul 2017 10:01:16 Daniel Vetter wrote: > >> diff --git a/drivers/gpu/drm/drm_mode_object.c > >> b/drivers/gpu/drm/drm

Re: [Intel-gfx] [PATCH 1/2] drm/atomic: Move drm_crtc_commit to drm_crtc_state.

t; drm_property_blob_put(state->mode_blob); > drm_property_blob_put(state->degamma_lut); > drm_property_blob_put(state->ctm); > diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h > index 8a5808eb5628..e76d9f95c191 100644 > --- a/include/drm/d

Re: [Intel-gfx] [PATCH 3/5] drm/atomic: Move drm_crtc_commit to drm_crtc_state, v2.

through the > + * various phases. This is never cleared, except when we destroy the > + * state, so that subsequent commits can synchronize with previous ones. > + */ > + struct drm_crtc_commit *commit; > + > struct drm_atom

Re: [Intel-gfx] [PATCH 4/5] drm/atomic: Fix freeing connector/plane state too early by tracking commits, v2.

- Only create a single disable commit. (danvet) > - Fix leak in intel_legacy_cursor_update. > > Signed-off-by: Maarten Lankhorst > Testcase: kms_atomic_transition.plane-use-after-nonblocking-unbind* > Cc: Laurent Pinchart > --- > drivers/gpu/drm/drm_atomic.c | 4 + > driver

Re: [Intel-gfx] [PATCH 4/5] drm/atomic: Fix freeing connector/plane state too early by tracking commits, v2.

On Wednesday, 30 August 2017 17:17:36 EEST Daniel Vetter wrote: > On Wed, Aug 30, 2017 at 05:10:43PM +0300, Laurent Pinchart wrote: > > Hi Maarten, > > > > Thank you for the patch. > > > > On Wednesday, 30 August 2017 15:17:51 EEST Maarten Lankhorst wrote: &g

Re: [Intel-gfx] [RFC v2 3/8] drm: Export some ioctl functions

ffers.h > @@ -0,0 +1,10 @@ You should add an SPDX header to specify the file license. > +#ifndef _DRM_DUMB_BUFFERS_H_ > +#define _DRM_DUMB_BUFFERS_H_ > + > +struct drm_device; > +struct drm_file; > + > +int drm_mode_create_dumb_ioctl(struct drm_device *

Re: [Intel-gfx] [RFC v2 2/8] drm/ioctl: Remove trailing whitespace

Hi Noralf, Thank you for the patch. On Thursday, 4 January 2018 00:21:04 EET Noralf Trønnes wrote: > Remove a couple of trailing spaces. > > Signed-off-by: Noralf Trønnes Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_ioctl.c | 4 ++-- > 1 file changed,

Re: [Intel-gfx] [PATCH v4 1/5] drm/atomic: Fix atomic helpers to use the new iterator macros, v2.

const struct drm_plane_helper_funcs *funcs; > + struct drm_plane_state *plane_state; > + > + /* > + * This might be called before swapping when commit is aborted, > + * in which case we have to free the new state. s/free/cleanup/ Apart from that, Reviewed-by: La

<    1   2   3   4   >