Re: [Intel-gfx] [PATCH 00/10] Allow mdev drivers to directly create the vfio_device

2021-06-14 Thread Kirti Wankhede
Jason, I couldn't find patch 1,2,4 and 5 of these series. Can you please keep k...@vger.kernel.org cc for all patches? Also it will be helpful if you can add version prefix, eg. 'v3' for this series, in subject line. Thanks, Kirti On 6/8/2021 6:25 AM, Jason Gunthorpe wrote: This is a "v3"

Re: [Intel-gfx] [PATCH 02/10] driver core: Better distinguish probe errors in really_probe

2021-06-14 Thread Kirti Wankhede
On 6/14/2021 8:38 PM, Christoph Hellwig wrote: really_probe tries to special case errors from ->probe, but due to all other initialization added to the function over time now a lot of internal errors hit that code path as well. Untangle that by adding a new probe_err local variable and apply

Re: [Intel-gfx] [PATCH 02/10] driver core: Better distinguish probe errors in really_probe

2021-06-16 Thread Kirti Wankhede
ply the special casing only to that. Signed-off-by: Christoph Hellwig Reviewed-by: Kirti Wankhede ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 06/10] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE

2021-06-16 Thread Kirti Wankhede
driver entirely. Signed-off-by: Jason Gunthorpe Signed-off-by: Christoph Hellwig Reviewed-by: Cornelia Huck Reviewed-by: Kirti Wankhede ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel

Re: [Intel-gfx] [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind

2021-06-16 Thread Kirti Wankhede
/vfio/mdev/mdev_core.c | 30 ++ drivers/vfio/mdev/mdev_driver.c | 10 ++ include/linux/mdev.h| 2 ++ 3 files changed, 34 insertions(+), 8 deletions(-) Reviewed-by: Kirti Wankhede ___ Intel-gfx mailing

Re: [Intel-gfx] [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev()

2021-06-16 Thread Kirti Wankhede
x27;, probably 'vfio-mdev-mtty' or 'vfio-mtty' Rest looks fine to me. Reviewed-by: Kirti Wankhede ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 00/13] Provide core infrastructure for managing open/release

2021-07-15 Thread Kirti Wankhede
On 7/15/2021 5:50 AM, Jason Gunthorpe wrote: Prologue: This is the first series of three to send the "mlx5_vfio_pci" driver that has been discussed on the list for a while now. - Reorganize reflck to support splitting vfio_pci - Split vfio_pci into vfio_pci/vfio_pci_core and provide infra

Re: [Intel-gfx] [PATCH V11 1/6] mdev: class id support

2019-11-07 Thread Kirti Wankhede
od to pair the mdev device and mdev driver correctly. So this patch adds id_table to mdev_driver and class_id for mdev device with the match method for mdev bus. Reviewed-by: Parav Pandit Reviewed-by: Cornelia Huck Signed-off-by: Jason Wang Reviewed-by: Kirti Wankhede Thanks,

Re: [Intel-gfx] [PATCH V11 2/6] modpost: add support for mdev class id

2019-11-07 Thread Kirti Wankhede
On 11/7/2019 8:41 PM, Jason Wang wrote: Add support to parse mdev class id table. Reviewed-by: Parav Pandit Reviewed-by: Cornelia Huck Signed-off-by: Jason Wang Reviewed-by: Kirti Wankhede Thanks, Kirti --- drivers/vfio/mdev/vfio_mdev.c | 2 ++ scripts/mod/devicetable

Re: [Intel-gfx] [PATCH V11 3/6] mdev: introduce device specific ops

2019-11-07 Thread Kirti Wankhede
structure. This allows different set of callback to be used by vfio-mdev and virtio-mdev. Reviewed-by: Parav Pandit Signed-off-by: Jason Wang Reviewed-by: Kirti Wankhede Thanks, Kirti --- .../driver-api/vfio-mediated-device.rst | 35 + MAINTAINERS

Re: [Intel-gfx] [PATCH V11 4/6] mdev: introduce virtio device and its device ops

2019-11-07 Thread Kirti Wankhede
On 11/7/2019 8:41 PM, Jason Wang wrote: This patch implements basic support for mdev driver that supports virtio transport for kernel virtio driver. Reviewed-by: Cornelia Huck Signed-off-by: Jason Wang I'm not expert on virtio part, my ack is from mdev perspective. Reviewed-by:

Re: [Intel-gfx] [PATCH v3 11/12] samples: vfio-mdev: constify fb ops

2019-12-09 Thread Kirti Wankhede
On 12/9/2019 7:31 PM, Jani Nikula wrote: On Tue, 03 Dec 2019, Jani Nikula wrote: Now that the fbops member of struct fb_info is const, we can start making the ops const as well. v2: fix typo (Christophe de Dinechin) Cc: Kirti Wankhede Cc: k...@vger.kernel.org Reviewed-by: Daniel Vetter

Re: [Intel-gfx] [PATCH v5 5/5] drm/i915/gvt: Adding interface so user space can get the dma-buf

2017-05-24 Thread Kirti Wankhede
On 5/23/2017 7:39 PM, Gerd Hoffmann wrote: > Hi, > >> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h >> index ae46105..285dc16 100644 >> --- a/include/uapi/linux/vfio.h >> +++ b/include/uapi/linux/vfio.h >> @@ -502,10 +502,58 @@ struct vfio_pci_hot_reset { >> >> #define

Re: [Intel-gfx] [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations

2017-05-31 Thread Kirti Wankhede
On 5/31/2017 11:48 AM, Chen, Xiaoguang wrote: > Hi, > >> -Original Message- >> From: Gerd Hoffmann [mailto:kra...@redhat.com] >> Sent: Monday, May 29, 2017 3:20 PM >> To: Chen, Xiaoguang ; >> alex.william...@redhat.com; ch...@chris-wilson.co.uk; intel- >> g...@lists.freedesktop.org; linu

Re: [Intel-gfx] [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations

2017-06-01 Thread Kirti Wankhede
On 6/1/2017 10:08 PM, Alex Williamson wrote: > On Thu, 1 Jun 2017 03:01:28 + > "Chen, Xiaoguang" wrote: > >> Hi Kirti, >> >>> -----Original Message- >>> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] >>> Sent: Thursday, Jun

Re: [Intel-gfx] [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations

2017-06-05 Thread Kirti Wankhede
On 6/2/2017 2:08 PM, Gerd Hoffmann wrote: > >> struct vfio_vgpu_surface_info { >> __u64 start; >> __u32 width; >> __u32 height; >> __u32 stride; >> __u32 size; >> __u32 x_pos; >> __u32 y_pos; >> __u32 padding; >> /* Only use

Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations

2017-06-15 Thread Kirti Wankhede
On 6/15/2017 1:30 PM, Xiaoguang Chen wrote: > Here we defined a new ioctl to create a fd for a vfio device based on > the input type. Now only one type is supported that is a dma-buf > management fd. > Two ioctls are defined for the dma-buf management fd: query the vfio > vgpu's plane information

Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations

2017-06-16 Thread Kirti Wankhede
On 6/16/2017 2:08 AM, Alex Williamson wrote: > On Thu, 15 Jun 2017 18:00:38 +0200 > Gerd Hoffmann wrote: > >> Hi, >> +struct vfio_dmabuf_mgr_plane_info { + __u64 start; + __u64 drm_format_mod; + __u32 drm_format; + __u32 width; + __u32 height; + __u32

Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations

2017-06-16 Thread Kirti Wankhede
On 6/16/2017 10:09 PM, Alex Williamson wrote: > On Fri, 16 Jun 2017 19:02:30 +0530 > Kirti Wankhede wrote: > >> On 6/16/2017 2:08 AM, Alex Williamson wrote: >>> On Thu, 15 Jun 2017 18:00:38 +0200 >>> Gerd Hoffmann wrote: >>> >>>>

Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations

2017-06-20 Thread Kirti Wankhede
On 6/19/2017 8:25 PM, Alex Williamson wrote: > On Mon, 19 Jun 2017 08:38:32 +0200 > Gerd Hoffmann wrote: > >> Hi, >> >>> My suggestion was to use vfio device fd for this ioctl and have >>> dmabuf >>> mgr fd as member in above query_plane structure, for region type it >>> would be set to 0.

Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations

2017-06-20 Thread Kirti Wankhede
On 6/20/2017 2:05 PM, Gerd Hoffmann wrote: > Hi, > >>> Hmm, plane isn't really an ID, it is a type, with type being either >>> DRM_PLANE_TYPE_PRIMARY or DRM_PLANE_TYPE_CURSOR, so I don't think >>> the >>> flage above make sense. >> >> The intention was that ..._REGION_ID and ...PLANE_ID are de

Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations

2017-06-20 Thread Kirti Wankhede
On 6/20/2017 8:30 PM, Alex Williamson wrote: > On Tue, 20 Jun 2017 12:57:36 +0200 > Gerd Hoffmann wrote: > >> On Tue, 2017-06-20 at 08:41 +, Zhang, Tina wrote: >>> Hi, >>> >>> Thanks for all the comments. Here are the summaries: >>> >>> 1. Modify the structures to make it more general. >>>

Re: [Intel-gfx] [PATCH v10] vfio: ABI for mdev display dma-buf operation

2017-07-06 Thread Kirti Wankhede
On 7/6/2017 3:59 AM, Tina Zhang wrote: > Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user mode query and > get the plan and its related information. > > The dma-buf's life cycle is handled by user mode and tracked by kernel. > The returned fd in struct vfio_device_query_gfx_plane can be

Re: [Intel-gfx] [PATCH v10] vfio: ABI for mdev display dma-buf operation

2017-07-12 Thread Kirti Wankhede
r >>> Sent: Tuesday, July 11, 2017 5:13 PM >>> To: Gerd Hoffmann >>> Cc: Tian, Kevin ; linux-ker...@vger.kernel.org; intel- >>> g...@lists.freedesktop.org; alex.william...@redhat.com; >>> zhen...@linux.intel.com; ch...@chris-wilson.co.uk;

Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations

2017-07-12 Thread Kirti Wankhede
Hey Gerd, Sorry, I missed this mail earlier. On 6/21/2017 12:52 PM, Gerd Hoffmann wrote: > Hi, > >> We don't support cursor for console vnc. Ideally console vnc should >> be >> used by admin for configuration or during maintenance, which refresh >> primary surface at low refresh rate, 10 fps.

Re: [Intel-gfx] [PATCH v10] vfio: ABI for mdev display dma-buf operation

2017-07-14 Thread Kirti Wankhede
On 7/14/2017 7:00 AM, Zhang, Tina wrote: > > >> -Original Message- >> From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On >> Behalf Of Kirti Wankhede >> Sent: Wednesday, July 12, 2017 8:45 PM >> To: Zhang, Tina ; Gerd Hoffm

Re: [Intel-gfx] [PATCH v10] vfio: ABI for mdev display dma-buf operation

2017-07-14 Thread Kirti Wankhede
On 7/14/2017 3:31 PM, Gerd Hoffmann wrote: > Hi, > >> In case when VFIO region is used to provide surface to QEMU, plane_id >> would be region index, > > Then we should name it "region_index" not "plane_id". > >> for example region 10 could be used for primary >> surface and region 11 could

Re: [Intel-gfx] [PATCH v10] vfio: ABI for mdev display dma-buf operation

2017-07-14 Thread Kirti Wankhede
On 7/14/2017 5:35 PM, Gerd Hoffmann wrote: > Hi, > >> There could be only two planes, one DRM_PLANE_TYPE_PRIMARY and one >> DRM_PLANE_TYPE_CURSOR. >> Steps from gfx_update for region case would be: >> - VFIO_DEVICE_QUERY_GFX_PLANE with plane_type = >> DRM_PLANE_TYPE_PRIMARY > >> - if vfio_dev

Re: [Intel-gfx] [PATCH v10] vfio: ABI for mdev display dma-buf operation

2017-07-19 Thread Kirti Wankhede
On 7/19/2017 11:55 AM, Gerd Hoffmann wrote: > On Wed, 2017-07-19 at 00:16 +, Zhang, Tina wrote: >>> -Original Message- >>> From: Gerd Hoffmann [mailto:kra...@redhat.com] >>> Sent: Monday, July 17, 2017 7:03 PM >>> To: Kirti Wankhede ; Zhang,

Re: [Intel-gfx] [PATCH v18 5/6] vfio: ABI for mdev display dma-buf operation

2017-11-18 Thread Kirti Wankhede
Extremely sorry for the delay. This works for VFIO_GFX_PLANE_TYPE_REGION. Tested with local changes. Reviewed-by: Kirti Wankhede Thanks, Kirti On 11/18/2017 9:00 PM, Alex Williamson wrote: > > Kirti? > > On Wed, 15 Nov 2017 21:11:42 -0700 > Alex Williamson wrote: > >

Re: [Intel-gfx] [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-08-02 Thread Kirti Wankhede
On 8/2/2017 2:48 AM, Alex Williamson wrote: > On Tue, 25 Jul 2017 17:28:18 +0800 > Tina Zhang wrote: > >> Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user mode query and >> get the plan and its related information. >> >> The dma-buf's life cycle is handled by user mode and tracked by k

Re: [Intel-gfx] [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-08-08 Thread Kirti Wankhede
On 8/7/2017 11:13 PM, Alex Williamson wrote: > On Mon, 7 Aug 2017 08:11:43 + > "Zhang, Tina" wrote: > >> After going through the previous discussions, here are some summaries may be >> related to the current discussion: >> 1. How does user mode figure the device capabilities between region

Re: [Intel-gfx] [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-08-09 Thread Kirti Wankhede
On 8/8/2017 11:37 PM, Alex Williamson wrote: > On Tue, 8 Aug 2017 14:18:07 +0530 > Kirti Wankhede wrote: > >> On 8/7/2017 11:13 PM, Alex Williamson wrote: >>> On Mon, 7 Aug 2017 08:11:43 + >>> "Zhang, Tina" wrote: >>> >>>