[Intel-gfx] [PATCH 2/3] drm/i915: Bump GT idling delay to 2 jiffies

userspace prevents us from prematurely parking and having to exit powersaving immediately. Link: https://gitlab.freedesktop.org/drm/intel/-/issues/6284 Signed-off-by: Chris Wilson Signed-off-by: Karolina Drobnik --- drivers/gpu/drm/i915/i915_active.c | 2 +- 1 file changed, 1 insertion(+), 1

[Intel-gfx] [PATCH 3/3] drm/i915/gt: Only kick the signal worker if there's been an update

to check signaling. References: 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") Signed-off-by: Chris Wilson Signed-off-by: Karolina Drobnik --- drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/d

[Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Signed-off-by: Karolina Drobnik Tested-by: Thomas Voegtle --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 35 1 file changed, 35 insertions(+)

[Intel-gfx] [PATCH 0/3] drm/i915: Apply waitboosting before fence wait

Waitboost is a heuristic that detects latency sensitive workloads waiting for the results from previous execution. The wait can be seen as GPU under-utilisation by RPS, Render Power State management, which might lower the GPU frequency to save power. Limiting the frequency means more waiting for re

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

Hi Rodrigo and Andi, Thank you very much for your reviews. On 07.07.2022 23:50, Andi Shyti wrote: Hi Rodrigo, Chris and Karolina, On Thu, Jul 07, 2022 at 01:57:52PM -0400, Rodrigo Vivi wrote: On Tue, Jul 05, 2022 at 12:57:17PM +0200, Karolina Drobnik wrote: From: Chris Wilson We employ a

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

Hi Andi, On 08.07.2022 13:38, Andi Shyti wrote: Hi Karolina, [...] + dma_resv_for_each_fence_unlocked(&cursor, fence) { + if (dma_fence_is_i915(fence) && + !i915_request_started(to_request(fence))) + intel_rps_boost(to_request(fence)

[Intel-gfx] [PATCH v2 0/3] drm/i915: Apply waitboosting before fence wait

Waitboost is a heuristic that detects latency sensitive workloads waiting for the results from previous execution. The wait can be seen as GPU under-utilisation by RPS, Render Power State management, which might lower the GPU frequency to save power. Limiting the frequency means more waiting for re

[Intel-gfx] [PATCH v2 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Signed-off-by: Karolina Drobnik Tested-by: Thomas Voegtle Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 34 1 file cha

[Intel-gfx] [PATCH v2 2/3] drm/i915: Bump GT idling delay to 2 jiffies

userspace prevents us from prematurely parking and having to exit powersaving immediately. Link: https://gitlab.freedesktop.org/drm/intel/-/issues/6284 Signed-off-by: Chris Wilson Signed-off-by: Karolina Drobnik Reviewed-by: Rodrigo Vivi Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2 3/3] drm/i915/gt: Only kick the signal worker if there's been an update

to check signaling. References: 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround") Signed-off-by: Chris Wilson Signed-off-by: Karolina Drobnik --- drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/d

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Apply waitboosting before fence wait (rev2)

On 08.07.2022 16:55, Patchwork wrote: == Series Details == Series: drm/i915: Apply waitboosting before fence wait (rev2) URL : https://patchwork.freedesktop.org/series/105925/ State : warning == Summary == Error: dim checkpatch failed e35c61e9e46c drm/i915/gem: Look for waitboosting across

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Apply waitboosting before fence wait (rev2)

On 09.07.2022 04:00, Patchwork wrote: *Patch Details* *Series:* drm/i915: Apply waitboosting before fence wait (rev2) *URL:* https://patchwork.freedesktop.org/series/105925/ *State:*failure *Details:* https://intel-gfx-ci.01.o

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/gt: Only kick the signal worker if there's been an update

Hi Rodrigo, Many thanks for taking another look at the patches. On 08.07.2022 16:40, Rodrigo Vivi wrote: On Fri, Jul 08, 2022 at 04:20:13PM +0200, Karolina Drobnik wrote: From: Chris Wilson One impact of commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround&quo

Re: [Intel-gfx] [PATCH] dma-buf: revert "return only unsignaled fences in dma_fence_unwrap_for_each v3"

the filter in the merge function again where it makes sense. Signed-off-by: Christian König After applying the patch, fence merging works and all sw_sync subtests are passing. Thanks for taking care of this. Tested-by: Karolina Drobnik --- drivers/dma-buf/dma-fence-unwrap.c | 3

[Intel-gfx] [PATCH] drm/i915/selftests: Check for incomplete LRI from the context image

emit an invalid zero-length LRI. Reported-by: Daniele Ceraolo Spurio Signed-off-by: Chris Wilson Cc: Daniele Ceraolo Spurio Signed-off-by: Karolina Drobnik --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 61 +++--- 1 file changed, 54 insertions(+), 7 deletions(-) diff --git a

[Intel-gfx] [PATCH v5 1/4] drm/i915/gt: Explicitly clear BB_OFFSET for new contexts

From: Chris Wilson Even though the initial protocontext we load onto HW has the register cleared, by the time we save it into the default image, BB_OFFSET has had the enable bit set. Reclear BB_OFFSET for each new context. Testcase: igt/i915_selftests/gt_lrc v2: Extend it for gen8. v3: BB_O

[Intel-gfx] [PATCH v5 0/4] lrc selftest fixes

Few bug fixes for lrc selftest. v5: - Add Reviewed-by tag to "drm/i915/selftests: Check for incomplete LRI from the context image" patch, as it got reviewed in different series: https://patchwork.freedesktop.org/series/108487/ Chris Wilson (4): drm/i915/gt: Explicitly clear BB_OFF

[Intel-gfx] [PATCH v5 4/4] drm/i915/selftest: Clear the output buffers before GPU writes

From: Chris Wilson When testing whether we can get the GPU to leak information about non-privileged state, we first need to ensure that the output buffer is set to a known value as the HW may opt to skip the write into memory for a non-privileged read of a sensitive register. We chose POISON_INUS

[Intel-gfx] [PATCH v5 2/4] drm/i915/selftests: Check for incomplete LRI from the context image

Signed-off-by: Ramalingam C Acked-by: Thomas Hellstrom Signed-off-by: Karolina Drobnik Reviewed-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 61 +++--- 1 file changed, 54 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b

[Intel-gfx] [PATCH v5 3/4] drm/i915/selftest: Always cancel semaphore on error

From: Chris Wilson Ensure that we always signal the semaphore when timing out, so that if it happens to be stuck waiting for the semaphore we will quickly recover without having to wait for a reset. Reported-by: CQ Tang Signed-off-by: Chris Wilson Cc: CQ Tang cc: Joonas Lahtinen Signed-off-b

[Intel-gfx] [topic/core-for-CI] Revert "iommu/dma: Fix race condition during iova_domain initialization"

8a0 cpuhp_thread_fun+0x188/0x1f0 ? smpboot_thread_fn+0x1e/0x260 smpboot_thread_fn+0x1b5/0x260 ? sort_range+0x20/0x20 kthread+0xed/0x120 ? kthread_complete_and_exit+0x20/0x20 ret_from_fork+0x1f/0x30 Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6641 Signed-off-by: Karolina Dr

Re: [Intel-gfx] [topic/core-for-CI] Revert "iommu/dma: Fix race condition during iova_domain initialization"

On 14.09.2022 17:01, Lucas De Marchi wrote: On Wed, Sep 14, 2022 at 02:40:45PM +0200, Karolina Drobnik wrote: This reverts commit ac9a5d522bb80be50ea84965699e1c8257d745ce. This change introduces a regression on Alder Lake that completely blocks testing. To enable CI and avoid possible circular

Re: [Intel-gfx] [topic/core-for-CI] Revert "iommu/dma: Fix race condition during iova_domain initialization"

On 14.09.2022 17:54, Robin Murphy wrote: On 2022-09-14 16:01, Lucas De Marchi wrote: On Wed, Sep 14, 2022 at 02:40:45PM +0200, Karolina Drobnik wrote: This reverts commit ac9a5d522bb80be50ea84965699e1c8257d745ce. This change introduces a regression on Alder Lake that completely blocks testing

Re: [Intel-gfx] [topic/core-for-CI] Revert "iommu/dma: Fix race condition during iova_domain initialization"

On 16.09.2022 22:32, Lucas De Marchi wrote: On Fri, Sep 16, 2022 at 02:24:00PM +0200, Karolina Drobnik wrote: On 14.09.2022 17:54, Robin Murphy wrote: On 2022-09-14 16:01, Lucas De Marchi wrote: On Wed, Sep 14, 2022 at 02:40:45PM +0200, Karolina Drobnik wrote: This reverts commit

[Intel-gfx] [PATCH] i915/i915_gem_context: Remove debug message in i915_gem_context_create_ioctl

We know that as long as GEM context create ioctl succeeds, a context was created. There is no need to write about it, especially when such a message heavily pollutes dmesg and makes debugging actual errors harder. Suggested-by: Chris Wilson Signed-off-by: Karolina Drobnik Cc: Andi Shyti