[Intel-gfx] [PATCH 1/8] drm/i915/guc: Do not conflate lrc_desc with GuC id for registration

2022-02-17 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as a check for context registration, use the GuC id instead (being the thing that actually gets registered with the GuC). Also, rename the set/clear/query helper functions for context id mappings to better reflect their

[Intel-gfx] [PATCH 7/8] drm/i915/guc: Drop obsolete H2G definitions

2022-02-17 Thread John . C . Harrison
From: John Harrison The CTB registration process changed significantly a while back using a single KLV based H2G. So drop the original and now obsolete H2G definitions. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 2 -- 1 file changed, 2 deletions(-) dif

[Intel-gfx] [PATCH 3/8] drm/i915/guc: Better name for context id limit

2022-02-17 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as the limit for how many context ids are available. While at it, also update a kzalloc(sizeof()*count) to be a kcalloc(count,size). Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/intel_context.c |

[Intel-gfx] [PATCH 2/8] drm/i915/guc: Add an explicit 'submission_initialized' flag

2022-02-17 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as a check for whether submission has been initialised or not. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.h| 2 ++ drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 8 +---

[Intel-gfx] [PATCH 8/8] drm/i915/guc: Fix potential invalid pointer dereferences when decoding G2Hs

2022-02-17 Thread John . C . Harrison
From: John Harrison Some G2H handlers were reading the context id field from the payload before checking the payload met the minimum length required. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[Intel-gfx] [PATCH 6/8] drm/i915/guc: Rename desc_idx to ctx_id

2022-02-17 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop naming context ids as descriptor pool indecies. While at it, add a bunch of missing line feeds to some error messages. Signed-off-by: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 56 +-- 1

[Intel-gfx] [PATCH 0/3] Improve anti-pre-emption w/a for compute workloads

2022-02-18 Thread John . C . Harrison
From: John Harrison Compute workloads are inherently not pre-emptible on current hardware. Thus the pre-emption timeout was disabled as a workaround to prevent unwanted resets. Instead, the hang detection was left to the heartbeat and its (longer) timeout. This is undesirable with GuC submission

[Intel-gfx] [PATCH 3/3] drm/i915: Improve long running OCL w/a for GuC submission

2022-02-18 Thread John . C . Harrison
From: John Harrison A workaround was added to the driver to allow OpenCL workloads to run 'forever' by disabling pre-emption on the RCS engine for Gen12. It is not totally unbound as the heartbeat will kick in eventually and cause a reset of the hung engine. However, this does not work well in G

[Intel-gfx] [PATCH 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-02-18 Thread John . C . Harrison
From: John Harrison GuC converts the pre-emption timeout and timeslice quantum values into clock ticks internally. That significantly reduces the point of 32bit overflow. On current platforms, worst case scenario is approximately 110 seconds. Rather than allowing the user to set higher values and

[Intel-gfx] [PATCH 2/3] drm/i915/gt: Make the heartbeat play nice with long pre-emption timeouts

2022-02-18 Thread John . C . Harrison
From: John Harrison Compute workloads are inherantly not pre-emptible for long periods on current hardware. As a workaround for this, the pre-emption timeout for compute capable engines was disabled. This is undesirable with GuC submission as it prevents per engine reset of hung contexts. Hence t

[Intel-gfx] [PATCH v2 0/8] Prep work for next GuC release

2022-02-24 Thread John . C . Harrison
From: John Harrison The next GuC firmware release includes some significant backwards breaking API changes. One such is that there is no longer an LRC descriptor pool. A bunch of prep work for that change can be done in advance - the descriptor pool was being used for things it shouldn't really h

[Intel-gfx] [PATCH v2 8/8] drm/i915/guc: Fix potential invalid pointer dereferences when decoding G2Hs

2022-02-24 Thread John . C . Harrison
From: John Harrison Some G2H handlers were reading the context id field from the payload before checking the payload met the minimum length required. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 6 -- 1 file chang

[Intel-gfx] [PATCH v2 5/8] drm/i915/guc: Move lrc desc setup to where it is needed

2022-02-24 Thread John . C . Harrison
From: John Harrison The LRC descriptor was being initialised early on in the context registration sequence. It could then be determined that the actual registration needs to be delayed and the descriptor would be wiped out. This is inefficient, so move the setup to later in the process after the

[Intel-gfx] [PATCH v2 6/8] drm/i915/guc: Rename desc_idx to ctx_id

2022-02-24 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop naming context ids as descriptor pool indecies. While at it, add a bunch of missing line feeds to some error messages. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio --- .../gpu/drm/i915/gt/uc/intel_guc_sub

[Intel-gfx] [PATCH v2 1/8] drm/i915/guc: Do not conflate lrc_desc with GuC id for registration

2022-02-24 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as a check for context registration, use the GuC id instead (being the thing that actually gets registered with the GuC). Also, rename the set/clear/query helper functions for context id mappings to better reflect their

[Intel-gfx] [PATCH v2 2/8] drm/i915/guc: Add an explicit 'submission_initialized' flag

2022-02-24 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as a check for whether submission has been initialised or not. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_guc.h| 2 ++ drivers/gpu/drm/i915/gt/uc

[Intel-gfx] [PATCH v2 3/8] drm/i915/guc: Better name for context id limit

2022-02-24 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as the limit for how many context ids are available. Instead, size the pool according to the number of contexts allowed. Note that this is just a naming change, the actual limit is identical in value. While at it, also

[Intel-gfx] [PATCH v2 7/8] drm/i915/guc: Drop obsolete H2G definitions

2022-02-24 Thread John . C . Harrison
From: John Harrison The CTB registration process changed significantly a while back using a single KLV based H2G. So drop the original and now obsolete H2G definitions. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 2 --

[Intel-gfx] [PATCH v2 4/8] drm/i915/guc: Split guc_lrc_desc_pin apart

2022-02-24 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. Further, the function that was populating it was also doing a bunch of logic about the context registration sequence. So, split that code apart into separate state setup and try to register functions. Note that some of those 'try to regis

[Intel-gfx] [PATCH v3] drm/i915/guc: Do not complain about stale reset notifications

2022-02-24 Thread John . C . Harrison
From: John Harrison It is possible for reset notifications to arrive for a context that is in the process of being banned. So don't flag these as an error, just report it as informational (because it is still useful to know that resets are happening even if they are being ignored). v2: Better wo

[Intel-gfx] [PATCH] drm/i915/guc: Add fetch of hwconfig table

2022-02-24 Thread John . C . Harrison
From: John Harrison Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer. The table is stored in the GT structure so that it can be fetched once at dri

[Intel-gfx] [PATCH v2 2/3] drm/i915/gt: Make the heartbeat play nice with long pre-emption timeouts

2022-02-25 Thread John . C . Harrison
From: John Harrison Compute workloads are inherently not pre-emptible for long periods on current hardware. As a workaround for this, the pre-emption timeout for compute capable engines was disabled. This is undesirable with GuC submission as it prevents per engine reset of hung contexts. Hence t

[Intel-gfx] [PATCH v2 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-02-25 Thread John . C . Harrison
From: John Harrison GuC converts the pre-emption timeout and timeslice quantum values into clock ticks internally. That significantly reduces the point of 32bit overflow. On current platforms, worst case scenario is approximately 110 seconds. Rather than allowing the user to set higher values and

[Intel-gfx] [PATCH v2 0/3] Improve anti-pre-emption w/a for compute workloads

2022-02-25 Thread John . C . Harrison
From: John Harrison Compute workloads are inherently not pre-emptible on current hardware. Thus the pre-emption timeout was disabled as a workaround to prevent unwanted resets. Instead, the hang detection was left to the heartbeat and its (longer) timeout. This is undesirable with GuC submission

[Intel-gfx] [PATCH v2 3/3] drm/i915: Improve long running OCL w/a for GuC submission

2022-02-25 Thread John . C . Harrison
From: John Harrison A workaround was added to the driver to allow OpenCL workloads to run 'forever' by disabling pre-emption on the RCS engine for Gen12. It is not totally unbound as the heartbeat will kick in eventually and cause a reset of the hung engine. However, this does not work well in G

[Intel-gfx] [PATCH v3 4/8] drm/i915/guc: Split guc_lrc_desc_pin apart

2022-03-01 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. Further, the function that was populating it was also doing a bunch of logic about the context registration sequence. So, split that code apart into separate state setup and try to register functions. Note that some of those 'try to regis

[Intel-gfx] [PATCH v3 3/8] drm/i915/guc: Better name for context id limit

2022-03-01 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as the limit for how many context ids are available. Instead, size the pool according to the number of contexts allowed. Note that this is just a naming change, the actual limit is identical in value. While at it, also

[Intel-gfx] [PATCH v3 0/8] Prep work for next GuC release

2022-03-01 Thread John . C . Harrison
From: John Harrison The next GuC firmware release includes some significant backwards breaking API changes. One such is that there is no longer an LRC descriptor pool. A bunch of prep work for that change can be done in advance - the descriptor pool was being used for things it shouldn't really h

[Intel-gfx] [PATCH v3 2/8] drm/i915/guc: Add an explicit 'submission_initialized' flag

2022-03-01 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as a check for whether submission has been initialised or not. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_guc.h| 2 ++ drivers/gpu/drm/i915/gt/uc

[Intel-gfx] [PATCH v3 8/8] drm/i915/guc: Fix potential invalid pointer dereferences when decoding G2Hs

2022-03-01 Thread John . C . Harrison
From: John Harrison Some G2H handlers were reading the context id field from the payload before checking the payload met the minimum length required. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 6 -- 1 file chang

[Intel-gfx] [PATCH v3 6/8] drm/i915/guc: Rename desc_idx to ctx_id

2022-03-01 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop naming context ids as descriptor pool indecies. While at it, add a bunch of missing line feeds to some error messages. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio --- .../gpu/drm/i915/gt/uc/intel_guc_sub

[Intel-gfx] [PATCH v3 5/8] drm/i915/guc: Move lrc desc setup to where it is needed

2022-03-01 Thread John . C . Harrison
From: John Harrison The LRC descriptor was being initialised early on in the context registration sequence. It could then be determined that the actual registration needs to be delayed and the descriptor would be wiped out. This is inefficient, so move the setup to later in the process after the

[Intel-gfx] [PATCH v3 7/8] drm/i915/guc: Drop obsolete H2G definitions

2022-03-01 Thread John . C . Harrison
From: John Harrison The CTB registration process changed significantly a while back using a single KLV based H2G. So drop the original and now obsolete H2G definitions. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 2 --

[Intel-gfx] [PATCH v3 1/8] drm/i915/guc: Do not conflate lrc_desc with GuC id for registration

2022-03-01 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as a check for context registration, use the GuC id instead (being the thing that actually gets registered with the GuC). Also, rename the set/clear/query helper functions for context id mappings to better reflect their

[Intel-gfx] [PATCH v3 2/4] drm/i915: Fix compute pre-emption w/a to apply to compute engines

2022-03-03 Thread John . C . Harrison
From: John Harrison An earlier patch added support for compute engines. However, it missed enabling the anti-pre-emption w/a for the new engine class. So move the 'compute capable' flag earlier and use it for the pre-emption w/a test. Fixes: c674c5b9342e ("drm/i915/xehp: CCS should use RCS setup

[Intel-gfx] [PATCH v3 0/4] Improve anti-pre-emption w/a for compute workloads

2022-03-03 Thread John . C . Harrison
From: John Harrison Compute workloads are inherently not pre-emptible on current hardware. Thus the pre-emption timeout was disabled as a workaround to prevent unwanted resets. Instead, the hang detection was left to the heartbeat and its (longer) timeout. This is undesirable with GuC submission

[Intel-gfx] [PATCH v3 1/4] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-03-03 Thread John . C . Harrison
From: John Harrison GuC converts the pre-emption timeout and timeslice quantum values into clock ticks internally. That significantly reduces the point of 32bit overflow. On current platforms, worst case scenario is approximately 110 seconds. Rather than allowing the user to set higher values and

[Intel-gfx] [PATCH v3 4/4] drm/i915: Improve long running OCL w/a for GuC submission

2022-03-03 Thread John . C . Harrison
From: John Harrison A workaround was added to the driver to allow OpenCL workloads to run 'forever' by disabling pre-emption on the RCS engine for Gen12. It is not totally unbound as the heartbeat will kick in eventually and cause a reset of the hung engine. However, this does not work well in G

[Intel-gfx] [PATCH v3 3/4] drm/i915: Make the heartbeat play nice with long pre-emption timeouts

2022-03-03 Thread John . C . Harrison
From: John Harrison Compute workloads are inherently not pre-emptible for long periods on current hardware. As a workaround for this, the pre-emption timeout for compute capable engines was disabled. This is undesirable with GuC submission as it prevents per engine reset of hung contexts. Hence t

[Intel-gfx] [PATCH i-g-t] tests/i915/gem_exec_capture: Fix memory object size in gem_exec_capture

2022-01-20 Thread John . C . Harrison
From: John Harrison The capture tests require knowing exactly how big the test allocation is. Part of the test is to compare the captured size against the allocated size to make sure they match. That doesn't work if the allocator creates an object of a different size than was requested without re

[Intel-gfx] [CI] PR for GuC v69.0.3 for DG2

2022-02-07 Thread John . C . Harrison
The following changes since commit eb8ea1b46893c42edbd516f971a93b4d097730ab: Merge branch 'v1.1.7' of https://github.com/irui-wang/linux_fw_vpu_v1.1.7 into main (2022-01-24 06:49:52 -0500) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware dg2_guc_v69.0.3

[Intel-gfx] [PATCH v3] drm/i915/dg2: Define GuC firmware version for DG2

2022-02-07 Thread John . C . Harrison
From: John Harrison First release of GuC for DG2. Signed-off-by: John Harrison CC: Tomasz Mistat CC: Ramalingam C CC: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/g

[Intel-gfx] [PATCH] drm/i915/guc: Fix flag query to not modify state

2022-02-07 Thread John . C . Harrison
From: John Harrison A flag query helper was actually writing to the flags word rather than just reading. Fix that. Also update the function's comment as it was out of date. Fixes: 0f7976506de61 ("drm/i915/guc: Rework and simplify locking") Signed-off-by: John Harrison --- drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 0/8] Prep work for next GuC release

2022-02-07 Thread John . C . Harrison
From: John Harrison The next GuC firmware release includes some significant backwards breaking API changes. One such is that there is no longer an LRC descriptor pool. A bunch of prep work for that change can be done in advance - the descriptor pool was being used for things it shouldn't really h

[Intel-gfx] [PATCH 2/8] drm/i915/guc: Add an explicit 'submission_initialized' flag

2022-02-07 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as a check for whether submission has been initialised or not. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.h| 2 ++ drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 8 +---

[Intel-gfx] [PATCH 3/8] drm/i915/guc: Better name for context id limit

2022-02-07 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as the limit for how many context ids are available. While at it, also update a kzalloc(sizeof()*count) to be a kcalloc(count,size). Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/intel_context.c |

[Intel-gfx] [PATCH 1/8] drm/i915/guc: Do not conflate lrc_desc with GuC id for registration

2022-02-07 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as a check for context registration, use the GuC id instead (being the thing that actually gets registered with the GuC). Signed-off-by: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 69 ++-

[Intel-gfx] [PATCH 8/8] drm/i915/guc: Fix potential invalid pointer dereferences when decoding G2Hs

2022-02-07 Thread John . C . Harrison
From: John Harrison Some G2H handlers were reading the context id field from the payload before checking the payload met the minimum length required. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[Intel-gfx] [PATCH 7/8] drm/i915/guc: Drop obsolete H2G definitions

2022-02-07 Thread John . C . Harrison
From: John Harrison The CTB registration process changed significantly a while back using a single KLV based H2G. So drop the original and now obsolete H2G definitions. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 2 -- 1 file changed, 2 deletions(-) dif

[Intel-gfx] [PATCH 6/8] drm/i915/guc: Rename desc_idx to ctx_id

2022-02-07 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop naming context ids as descriptor pool indecies. While at it, add a bunch of missing line feeds to some error messages. Signed-off-by: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 56 +-- 1

[Intel-gfx] [PATCH 5/8] drm/i915/guc: Move lrc desc setup to where it is needed

2022-02-07 Thread John . C . Harrison
From: John Harrison The LRC descriptor was being initialised early on in the context registration sequence. It could then be determined that the actual registration needs to be delayed and the descriptor would be wiped out. This is inefficient, so move the setup to later in the process after the

[Intel-gfx] [PATCH 4/8] drm/i915/guc: Split guc_lrc_desc_pin apart

2022-02-07 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. Further, the function that was populating it was also doing a bunch of logic about the context registration sequence. So, split that code apart into separate state setup and try to register functions. Note that some of those 'try to regis

[Intel-gfx] [PATCH] drm/i915/guc: Do not complain about stale reset notifications

2022-02-10 Thread John . C . Harrison
From: John Harrison It is possible for reset notifications to arrive for a context that is in the process of being banned. So don't flag these as an error, just report it as informational (because it is still useful to know that resets are happening even if they are being ignored). Signed-off-by

[Intel-gfx] [PATCH v2] drm/i915/guc: Do not complain about stale reset notifications

2022-02-11 Thread John . C . Harrison
From: John Harrison It is possible for reset notifications to arrive for a context that is in the process of being banned. So don't flag these as an error, just report it as informational (because it is still useful to know that resets are happening even if they are being ignored). v2: Better wo

[Intel-gfx] [PATCH v2 0/3] Drop version numbers from firmware files

2022-08-25 Thread John . C . Harrison
From: John Harrison Upstream direction is to include the bare minimum of version numbers in firmware files and to replace them in the repo rather than accumulating them. For HuC, that means going completely versionless. For GuC, the major version needs to be kept as that indicates a break in back

[Intel-gfx] [PATCH v2 3/3] drm/i915/uc: Enable version reduced firmware files for newest platforms

2022-08-25 Thread John . C . Harrison
From: John Harrison Going forwards, the intention is for GuC firmware files to be named for their major version only and HuC firmware files to have no version number in the name at all. This patch adds those entries for DG1/2 and ADL-P/S. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/g

[Intel-gfx] [PATCH v2 1/3] drm/i915/uc: Support for version reduced and multiple firmware files

2022-08-25 Thread John . C . Harrison
From: John Harrison There was a misunderstanding in how firmware file compatibility should be managed within i915. This has been clarified as: i915 must support all existing firmware releases forever new minor firmware releases should replace prior versions only backwards compatibility brea

[Intel-gfx] [PATCH v2 2/3] drm/i915/uc: Add patch level version number support

2022-08-25 Thread John . C . Harrison
From: John Harrison With the move to un-versioned filenames, it becomes more difficult to know exactly what version of a given firmware is being used. So add the patch level version number to the debugfs output. Also, support matching by patch level when selecting code paths for firmware compati

[Intel-gfx] [CI] PR for versionless GuC and HuC files

2022-08-26 Thread John . C . Harrison
The following changes since commit 8413c63c7a539a912be8851ce941eea32dcd1786: Merge branch 'lenovo-thinkpad-x13s' of https://github.com/mrhpearson/linux-firmware (2022-08-15 09:02:17 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware guc_huc_nover

[Intel-gfx] [PATCH v3 0/3] Drop version numbers from firmware files

2022-08-26 Thread John . C . Harrison
From: John Harrison Upstream direction is to include the bare minimum of version numbers in firmware files and to replace them in the repo rather than accumulating them. For HuC, that means going completely versionless. For GuC, the major version needs to be kept as that indicates a break in back

[Intel-gfx] [PATCH v3 3/3] drm/i915/uc: Enable version reduced firmware files for newest platforms

2022-08-26 Thread John . C . Harrison
From: John Harrison Going forwards, the intention is for GuC firmware files to be named for their major version only and HuC firmware files to have no version number in the name at all. This patch adds those entries for DG1/2 and ADL-P/S. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/g

[Intel-gfx] [PATCH v3 2/3] drm/i915/uc: Add patch level version number support

2022-08-26 Thread John . C . Harrison
From: John Harrison With the move to un-versioned filenames, it becomes more difficult to know exactly what version of a given firmware is being used. So add the patch level version number to the debugfs output. Also, support matching by patch level when selecting code paths for firmware compati

[Intel-gfx] [PATCH v3 1/3] drm/i915/uc: Support for version reduced and multiple firmware files

2022-08-26 Thread John . C . Harrison
From: John Harrison There was a misunderstanding in how firmware file compatibility should be managed within i915. This has been clarified as: i915 must support all existing firmware releases forever new minor firmware releases should replace prior versions only backwards compatibility brea

[Intel-gfx] [PATCH 0/1] Fix bug in version reduced firmware update

2022-09-12 Thread John . C . Harrison
From: John Harrison The earlier patch to support firmware files with reduced versioning introduced an issue with the firmware override module parameter. So fix that. Signed-off-by: John Harrison John Harrison (1): drm/i915/uc: Fix issues with overriding firmware files drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/1] drm/i915/uc: Fix issues with overriding firmware files

2022-09-12 Thread John . C . Harrison
From: John Harrison The earlier update to support reduced versioning of firmware files introduced an issue with the firmware override module parameter. If an invalid file was specified then an infinite loop could occur trying to find a backup firmware. The fix is that if an explicit override has

[Intel-gfx] [PATCH 1/1] drm/i915/guc: Fix release build bug in 'remove log size module parameters'

2022-09-12 Thread John . C . Harrison
From: John Harrison A patch was merged to remove the GuC log size override module parameters. That patch was broken and caused kernel error messages on boot in non CONFIG_DEBUG_GUC|GEM builds: [ 12.085121] i915 :00:02.0: [drm] *ERROR* Zero GuC log crash dump size! [ 12.092035] i915 :0

[Intel-gfx] [PATCH 0/1] Fix 'remove log size module parameters'

2022-09-12 Thread John . C . Harrison
From: John Harrison The patch 'remove log size module parameters' broke loading the kernel when not compiling for debug. Fix it. Signed-off-by: John Harrison John Harrison (1): drm/i915/guc: Fix release build bug in 'remove log size module parameters' drivers/gpu/drm/i915/gt/uc/intel_

[Intel-gfx] [CI] PR for new GuC v70.5.1

2022-09-13 Thread John . C . Harrison
The following changes since commit f09bebf31b0590bdc875d7236aa705279510cfd0: amdgpu: update yellow carp DMCUB firmware (2022-09-13 08:02:23 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware guc_70.5.1 for you to fetch changes up to fa124b323eb3935

[Intel-gfx] [PATCH v2 0/1] Fix bug in version reduced firmware update

2022-09-13 Thread John . C . Harrison
From: John Harrison The earlier patch to support firmware files with reduced versioning introduced an issue with the firmware override module parameter. So fix that. v2: Also remove ANSI colour codes that accidentally got left in an error message in the original patch. Signed-off-by: John Harri

[Intel-gfx] [PATCH v2 1/1] drm/i915/uc: Fix issues with overriding firmware files

2022-09-13 Thread John . C . Harrison
From: John Harrison The earlier update to support reduced versioning of firmware files introduced an issue with the firmware override module parameter. If an invalid file was specified then an infinite loop could occur trying to find a backup firmware. The fix is that if an explicit override has

[Intel-gfx] [PATCH 1/1] drm/i915/uc: Enable version reduced firmware files for newest platforms

2022-09-14 Thread John . C . Harrison
From: John Harrison Going forwards, the intention is for GuC firmware files to be named for their major version only and HuC firmware files to have no version number in the name at all. This patch adds those entries for all platforms that are officially GuC/HuC enabled. Also, update the expected

[Intel-gfx] [PATCH 0/1] Update to version reduced firmware file names

2022-09-14 Thread John . C . Harrison
From: John Harrison Start using GuC/HuC firmware files with reduced version information in the file name. Signed-off-by: John Harrison John Harrison (1): drm/i915/uc: Enable version reduced firmware files for newest platforms drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 12 +++-

[Intel-gfx] [PATCH 1/3] drm/i915/guc: Add non blocking CTB send function

2019-11-20 Thread John . C . Harrison
From: Matthew Brost Add non blocking CTB send fuction, intel_guc_send_nb. In order to support a non blocking CTB send fuction a spin lock is needed to protect the CTB descriptors fields. Also the non blocking call must not update the fence value as this value is owned by the blocking call (intel_

[Intel-gfx] [PATCH 3/3] drm/i915/guc: Increase size of CTB buffers

2019-11-20 Thread John . C . Harrison
From: Matthew Brost With the introduction of non-blocking CTBs more than one CTB can be in flight at a time. Increasing the size of the CTBs should reduce how often software hits the case where no space is available in the CTB buffer. Cc: John Harrison Signed-off-by: Matthew Brost --- drivers

[Intel-gfx] [PATCH 0/3] drm/i915/guc: CTB improvements

2019-11-20 Thread John . C . Harrison
From: John Harrison These patches improve the CTB infrastructure - Command Transport Buffer, the communication mechanism between i915 and GuC. They are part of the (large) series for updating the i915 GuC implementation to support the new GuC API. That series is still in progress (but getting cl

[Intel-gfx] [PATCH 2/3] drm/i915/guc: Optimized CTB writes and reads

2019-11-20 Thread John . C . Harrison
From: Matthew Brost CTB writes are now in the path of command submission and should be optimized for performance. Rather than reading CTB descriptor values (e.g. head, tail, size) which could result in accesses across the PCIe bus, store shadow local copies and only read/write the descriptor valu

[Intel-gfx] [PATCH] drm/i915/uc: Extra info notice about FW version mis-match vs overrides

2019-11-20 Thread John . C . Harrison
From: John Harrison If a FW override is present then a version mis-match is actually ignored. The warning message was still being printed, though. Which could confuse people by implying that the load had failed due to the mis-match when actually something else had failed. This patch adds an extr

[Intel-gfx] [PATCH] drm/i915/uc: Extra info notice about FW version mis-match vs overrides

2019-11-20 Thread John . C . Harrison
From: John Harrison If a FW override is present then a version mis-match is actually ignored. The warning message was still being printed, though. Which could confuse people by implying that the load had failed due to the mis-match when actually something else had failed. This patch adds an extr

[Intel-gfx] [PATCH] drm/i915: Add Gen/GT info to GPU error state

2019-11-20 Thread John . C . Harrison
From: John Harrison Added gen & GT info to the error capture. Signed-off-by: John Harrison CC: Matthew Brost --- drivers/gpu/drm/i915/i915_gpu_error.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c index 711

[Intel-gfx] [PATCH] drm/i915/guc: Update to GuC FW v40

2020-01-14 Thread John . C . Harrison
From: Matthew Brost The GuC major version has jumped from 35 to 40. This is because this FW includes a significant re-write of the API that completely breaks backwards compatibility for command submission. This patch is sufficient to enable loading of the GuC and hence authentication of the HuC.

[Intel-gfx] [PATCH v2] drm/i915/guc: Update to GuC FW v40

2020-01-15 Thread John . C . Harrison
From: Michal Wajdeczko The GuC major version has jumped from 35 to 40. This is because this FW includes a significant re-write of the API that completely breaks backwards compatibility for command submission. This patch is sufficient to enable loading of the GuC and hence authentication of the Hu

[Intel-gfx] [CI v2 1/2] drm/i915/guc: Update to GuC FW v40

2020-01-21 Thread John . C . Harrison
From: Matthew Brost The GuC major version has jumped from 35 to 40. This is because this FW includes a significant re-write of the API that completely breaks backwards compatibility for command submission. This patch is sufficient to enable loading of the GuC and hence authentication of the HuC.

[Intel-gfx] [CI v2 2/2] Hack for CI: enable HuC loading by default

2020-01-21 Thread John . C . Harrison
From: John Harrison --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 947d0a38fa3c..b53dee57f69b 100644 --- a/drivers/gpu/drm/i915/i915_params.h +++ b/drivers/g

[Intel-gfx] [PATCH] drm/i915/guc: Update uncore access path in flush_ggtt_writes

2019-12-06 Thread John . C . Harrison
From: Matthew Brost The preferred way to access the uncore is through the GT structure. Update the GuC function, flush_ggtt_writes, to use this path. Signed-off-by: Matthew Brost Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 5 ++--- 1 file changed, 2 insertions(+)

[Intel-gfx] [PATCH] drm/i915/uc: Don't complain about FW versions when overridden

2019-12-06 Thread John . C . Harrison
From: John Harrison If a FW override is present then a version mis-match is actually ignored. The warning notice was still being printed, though. Which could confuse people by implying that the load had failed when it had actually succeeded. Given that the whole point of the override is to use di

[Intel-gfx] [PATCH v3] drm/i915/uc: More useful FW version mis-match notice

2019-12-10 Thread John . C . Harrison
From: John Harrison If a FW override is present then a version mis-match is actually ignored. The warning notice was still being printed, though. Which could confuse people by implying that the load had failed when it had actually succeeded. So add an extra tag to the notice to say whether the mi

[Intel-gfx] [PATCH v2 2/3] drm/i915: Implement read-only support in whitelist selftest

2019-07-12 Thread John . C . Harrison
From: John Harrison Newer hardware supports extra feature in the whitelist registers. This patch updates the selftest to test that entries marked as read only are actually read only. v2: Removed all use of 'rsvd' for read-only registers to avoid ambiguous code or error messages. Signed-off-by:

[Intel-gfx] [PATCH v2 0/3] Improve whitelist selftest for read-only registers

2019-07-12 Thread John . C . Harrison
From: John Harrison Follow up patch to earlier whitelist updates. This series adds some extra sanity checking to the driver and improves the self-test. v2: Resolved abiguity over meaning of 'rsvd' in read-only mode by removing it. Rebased to newer tree. John Harrison (3): drm/i915: Add test f

[Intel-gfx] [PATCH v2 3/3] drm/i915: Add engine name to workaround debug print

2019-07-12 Thread John . C . Harrison
From: John Harrison There is a debug message in the workaround initialisation path that reports how many entries were added of each type. However, whitelist workarounds exist for multiple engines but the type name is just 'whitelist'. Tvrtko suggested adding the engine name to make the message mo

[Intel-gfx] [PATCH v2 1/3] drm/i915: Add test for invalid flag bits in whitelist entries

2019-07-12 Thread John . C . Harrison
From: John Harrison As per review feedback by Tvrtko, added a check that no invalid bits are being set in the whitelist flags fields. Also updated the read/write access definitions to make it clearer that they are an enum field not a set of single bit flags. Signed-off-by: John Harrison CC: Tv

[Intel-gfx] [PATCH 2/2] drm/i915: Engine relative MMIO for Gen12

2019-08-22 Thread John . C . Harrison
From: John Harrison Gen12 introduces a completely new and different scheme for implementing engine relative MMIO accesses - MI_LRI_MMIO_REMAP. This requires using the base address of instance zero of the relevant engine class. And then, it is only valid if the register in question falls within a

[Intel-gfx] [PATCH 0/2] drm/i915: Engine relative MMIO

2019-08-22 Thread John . C . Harrison
From: John Harrison Newer hardware has support for making LRI accesses to MMIO registers relative to the engine that is executing the LRI instruction. This is required for things like hardware based load balancing across engines. John Harrison (2): drm/i915: Engine relative MMIO drm/i915: En

[Intel-gfx] [PATCH 1/2] drm/i915: Engine relative MMIO

2019-08-22 Thread John . C . Harrison
From: John Harrison With virtual engines, it is no longer possible to know which specific physical engine a given request will be executed on at the time that request is generated. This means that the request itself must be engine agnostic - any direct register writes must be relative to the engi

[Intel-gfx] [PATCH] drm/i915/uc: Add function to define defaults for GuC/HuC enable

2021-01-13 Thread John . C . Harrison
From: John Harrison There is a module parameter for controlling what GuC/HuC features are enabled. Setting to -1 means 'use the default'. However, the default was not well defined, out of date and needs to be different across platforms. The default is now to disable both GuC and HuC on legacy pl

[Intel-gfx] [PATCH] drm/i915/uc: Use platform specific defaults for GuC/HuC enabling

2021-01-20 Thread John . C . Harrison
From: John Harrison The meaning of 'default' for the enable_guc module parameter has been updated to accurately reflect what is supported on current platforms. So start using the defaults instead of forcing everything off. Signed-off-by: John Harrison CC: Daniele Ceraolo Spurio --- drivers/gp

[Intel-gfx] [PATCH] drm/i915/uc: Use platform specific defaults for GuC/HuC enabling

2021-01-25 Thread John . C . Harrison
From: John Harrison The meaning of 'default' for the enable_guc module parameter has been updated to accurately reflect what is supported on current platforms. So start using the defaults instead of forcing everything off. Although, note that right now, the default is for everything to be off any

[Intel-gfx] linux firmware PR for i915 GuC v49.0.1

2020-11-24 Thread John . C . Harrison
Hi Josh, Kyle, Ben, Kindly add the below i915 changes to linux-firmware.git: The following changes since commit b362fd4cb8963ad75517dbcf424974f65a29a60e: Mellanox: Add new mlxsw_spectrum firmware xx.2008.2018 (2020-11-24 09:55:03 -0500) are available in the Git repository at: git://anong

[Intel-gfx] [PATCH] drm/i915/uc: Use platform specific defaults for GuC/HuC enabling

2021-02-25 Thread John . C . Harrison
From: John Harrison The meaning of 'default' for the enable_guc module parameter has been updated to accurately reflect what is supported on current platforms. So start using the defaults instead of forcing everything off. Although, note that right now, the default is for everything to be off any

[Intel-gfx] [PATCH v2 2/3] drm/i915/guc: Improved reporting when GuC fails to load

2020-10-13 Thread John . C . Harrison
From: John Harrison Rather than just saying 'GuC failed to load: -110', actually print out the GuC status register and break it down into the individual fields. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 31 --- 1 file changed, 22 insertion

[Intel-gfx] [PATCH v2 0/3] drm/i915/guc: Update to GuC v49

2020-10-13 Thread John . C . Harrison
From: John Harrison Update to the latest GuC firmware v2: Rebase to newer tree, updated a commit message (review feedback from Daniele) and dropped the patch to enable GuC/HuC loading by default as apparently this is not allowed. Signed-off-by: John Harrison John Harrison (3): drm/i915/guc

<    1   2   3   4   5   6   7   8   9   10   >