We really need some rev checking for workarounds like these that don't
apply to every version, or I'm afraid we'll forget them, like we've
done on previous gens (not that it's particularly critical for simple
clock gating ones like this, but for perf critical ones it
liminary_hw_support,
> + "GEN8_CENTROID_PIXEL_OPT_DIS not be needed for production\n");
> + I915_WRITE(HALF_SLICE_CHICKEN3,
> +_MASKED_BIT_ENABLE(GEN8_CENTROID_PIXEL_OPT_DIS));
> I915_WRITE(GAMTARBMODE, _MASKED_BIT_ENABLE(ARB_
->opregion.asle_work);
> +
> if (opregion->acpi) {
> iowrite32(0, &opregion->acpi->drdy);
>
> @@ -828,6 +842,8 @@ int intel_opregion_setup(struct drm_device *dev)
> return -ENOTSUPP;
> }
>
> + INIT_WORK(&opr
dev_priv->rps.rpe_delay);
>
> valleyview_set_rps(dev_priv->dev, dev_priv->rps.rpe_delay);
> @@ -5945,12 +5939,12 @@ int sandybridge_pcode_write(struct drm_i915_private
> *dev_priv, u8 mbox, u32 val)
> return 0;
> }
>
> -int vlv_gpu_freq(int ddr_fre
;
> - return vco_freq[hpll_freq];
> + dev_priv->hpll_vco = vco_freq[hpll_freq];
> +
> + return dev_priv->hpll_vco;
> }
>
> /* Adjust CDclk dividers to allow high res or save power if possible */
I'd just move this to init_clock_gating or something
-1;
> +
> + return 0xee + (10 << 1) - DIV_ROUND_CLOSEST(hpll_freq << 1,
> val);
> + }
> +
> /* 4 x czclk */
> switch (dev_priv->mem_freq) {
> case 800:
I don't think we want to add this; even though it's a small amount of
code it's totally unnecessary on real hw, and will probably just bit
rot.
--
Jesse Barnes, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
This fixes a mismatch between our vblank enable code and our IRQ
handler. Also, since vblank start events come in before page flips
reliably, it also fixes the kms_flip plain-flip test on my BYT system.
Spotted-by: Ville Syrjälä
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_irq.c
gt; - if (val > 0xea)
> - val = 0xea;
> -
> - return val;
> + return DIV_ROUND_CLOSEST(4 * mul * val, ddr_freq) + 0xbd - 6;
> }
>
> void intel_pm_init(struct drm_device *dev)
Yeah these values look better at 1066 and 1333. No differences at 800
though.
Reviewed-by: Jesse Barnes
--
Jesse Barnes, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
There was a TODO from last time that Daniel and I talked about:
- reconstruct fb state in our get_config callbacks instead
- reconstruct per-crtc fb state and allocate separate buffers if
needed
- make sure we only preserve the buffer if it's the preferred mode
Just wanted to get this re
gned-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_dma.c | 8 +-
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/intel_display.c | 14 +-
drivers/gpu/drm/i915/intel_drv.h | 4 +
drivers/gpu/drm/i915/intel_fbdev.c | 295 +-
en two CRTCs due to bad
detection on one, it could cause a blank screen issue.
commit 07bf139b906013ecef0c5e0441564d1ae10e974a
Author: Jesse Barnes
Date: Thu Oct 31 18:55:50 2013 +0200
drm/i915/vlv: use per-pipe backlight controls v2
commit 752aa88a1e784c22d514db3b440e49427b58259e
Author: Jesse Barnes
Date: T
On Thu, 7 Nov 2013 14:22:55 +
Chris Wilson wrote:
> On Wed, Nov 06, 2013 at 11:25:55AM -0800, Jesse Barnes wrote:
> > Retrieve current framebuffer config info from the regs and create an fb
> > object for the buffer the BIOS or boot loader left us. This should
>
Reviewed-by: Ville Syrjälä
Yeah and just for the record books, the old encoding was listed as 00 =
800, 01=800, 10=1066, 11=1333. But apparently it's been shifted left,
with 11 staying as 1333. So Chon Ming's patch looks ok.
I don't understand 2/2 though; was there a Punit HAS or P
m_freq, val));
>
> - val = vlv_punit_read(dev_priv, PUNIT_REG_GPU_LFM);
> + val = valleyview_rps_min_freq(dev_priv);
> seq_printf(m, "min GPU freq: %d MHz\n",
> vlv_gpu_freq(dev_priv->mem_freq, val));
>
Ok yea
s.max_delay);
> WARN_ON(val < dev_priv->rps.min_delay);
>
> - vlv_update_rps_cur_delay(dev_priv);
> -
> DRM_DEBUG_DRIVER("GPU freq request from %d MHz (%u) to %d MHz (%u)\n",
>vlv_gpu_freq(dev_priv->mem_freq,
>
ay - dev_priv->rps.cur_delay;
>
> if (IS_VALLEYVIEW(dev_priv->dev))
What a nice little helper.
Reviewed-by: Jesse Barnes
--
Jesse Barnes, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
move fb config fetch to display code (Jesse)
re-order hw state readout on initial load to suit fb inherit (Jesse)
re-add pin_and_fence in fbdev code to make sure we refcount properly (Jesse)
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_dma.c | 4 -
drivers/gpu/drm/
management of stolen objects
in this patch...
--
Jesse Barnes, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
at time span then I'm going to be
> > quite pissed.
>
> It's kinda too late imo for 3.13 (and there's an open question whether
> we need one more flag or not), so I wanted to pull it in into 3.14.
> Which also gives us plenty of time to add or not add that option
On Fri, 8 Nov 2013 16:53:31 +0200
Artem Bityutskiy wrote:
> Thanks Jesse for you answer, but it brought more questions.
>
> On Thu, 2013-11-07 at 08:04 -0800, Jesse Barnes wrote:
> > Hm, I wonder if this bug is also related to the backlight stuff Jani
> > recently push
o the original VT on resume, but rather leave things
alone for a nicer looking suspend and resume sequence.
v2: make a function so we can handle multiple drivers (Alan)
Signed-off-by: Jesse Barnes
---
include/linux/pm.h |2 ++
kernel/power/console.c |
The IDs are off in the VLV doc sites, which are separate and internal
only atm.
Jesse
On Sat, 2 Feb 2013 15:30:59 -0200
Rodrigo Vivi wrote:
> I was going to review them, but I couldn't find vlv ids at bspec.
> where is the ids list?
>
> On Sat, Feb 2, 2013 at 10:56 AM, Jesse
On Sat, 02 Feb 2013 21:50:35 +0100
"Rafael J. Wysocki" wrote:
> > > + * Drivers can indicate support for switchless suspend/resume, which can
> > > + * save time and flicker, by using this routine and passing 'false' as
> > > + * the argument. If any loaded driver needs VT switching, or the
> > >
field parsing, which would be extra nice.
Acked-by: Jesse Barnes
Jesse
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
flag to indicate we don't need to VT switch
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_drv.c | 28 +---
drivers/gpu/drm/i915/i915_drv.h |1 +
drivers/gpu/drm/i915/intel_display.c | 25 +
drivers/gpu/drm
Use the new PM routines to indicate whether we need to VT switch at suspend
and resume time. When a new driver is bound, set its flag accordingly,
and when unbound, remove it from the PM's console tracking list.
Signed-off-by: Jesse Barnes
---
drivers/video/fbmem.c |7 +++
in
o the original VT on resume, but rather leave things
alone for a nicer looking suspend and resume sequence.
v2: make a function so we can handle multiple drivers (Alan)
v3: use a list to track device requests (Rafael)
Signed-off-by: Jesse Barnes
---
include/linux/pm.h |4 ++
kernel/power/cons
On Mon, 04 Feb 2013 21:26:26 +0100
"Rafael J. Wysocki" wrote:
> On Monday, February 04, 2013 01:37:20 PM Jesse Barnes wrote:
> > KMS drivers can potentially restore the display configuration without
> > userspace help. Such drivers can can call a new funciton,
> &
On Tue, 5 Feb 2013 20:01:15 +0200
Ville Syrjälä wrote:
> On Sat, Feb 02, 2013 at 01:56:10PM +0100, Jesse Barnes wrote:
> > The Gunit has a separate reg for this, so allocate some stolen space for
> > the power context and initialize the reg.
>
> AFAIK the BIOS is responsib
aders if that's not selected. The
> offending config option itself was created itself to fix compile fail:
>
> commit 37cce26b32142f09a8967f6d238178af654b20de
> Author: H Hartley Sweeten
> Date: Wed Sep 21 22:47:55 2011 +0200
>
> PM / VT: Cleanup #if defined uglyness and fix compile error
>
&
register" interrupts form inside the
> interrupt handler.
>
> Signed-off-by: Paulo Zanoni
> ---
OTOH there's nothing the user can do about it... so we might do a
WARN_ONCE or something here instead. But even then, I'm not sure
there's much *we* can do about thes
On Fri, 8 Feb 2013 17:54:23 -0200
Paulo Zanoni wrote:
> Hi
>
> 2013/2/8 Jesse Barnes :
> > On Fri, 8 Feb 2013 17:35:18 -0200
> > Paulo Zanoni wrote:
> >
> >> From: Paulo Zanoni
> >>
> >> On ILK/SNB all we need to do is to enable the "
; Jesse, Rafael?
I think this should work, but I don't build with PM_SLEEP disabled...
Jesse
>From 0941d71fac64cb208b4cfb89a1698991c3902862 Mon Sep 17 00:00:00 2001
From: Jesse Barnes
Date: Mon, 11 Feb 2013 14:25:43 -0800
Subject: [PATCH] pm: provide stubs for PM VT console switch routines
On Mon, 11 Feb 2013 14:27:08 -0800
Jesse Barnes wrote:
> On Fri, 8 Feb 2013 10:51:48 +0100
> Daniel Vetter wrote:
>
> > On Fri, Feb 8, 2013 at 10:30 AM, kbuild test robot
> > wrote:
> > > tree: git://people.freedesktop.org/~danvet/drm-intel.git
>
ny tests don't rely on libdrm, this isn't a good idea.
>
> This patch has been sitting around on an internal tree for a while, but
> because Jesse recently pushed VLV ID updates it painfully made me
> realize that I should probably try to upstream it sooner rather than
> late
ny tests don't rely on libdrm, this isn't a good idea.
>
> This patch has been sitting around on an internal tree for a while, but
> because Jesse recently pushed VLV ID updates it painfully made me
> realize that I should probably try to upstream it sooner rather than
&g
> Comments, flames and ideas for the patches themselves, but also for the above
> issues in general highly welcome.
Overall I like this approach, it should make fastboot state tracking a
lot easier.
We'll also want to track gamma enable; unfortunately that can only be
changed with t
that work isn't ready yet either I've dropped the offending
> patches.
I sent a patch yesterday for this. I'll bounce it over again.
--
Jesse Barnes, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
If PM_SLEEP is disabled, we need stub versions of these functions.
v2: fix up struct device forward decl.
Signed-off-by: Jesse Barnes
---
include/linux/pm.h |9 +
1 file changed, 9 insertions(+)
diff --git a/include/linux/pm.h b/include/linux/pm.h
index 98310eb..e5da2f3 100644
On Fri, 15 Feb 2013 11:05:26 +0100
Daniel Vetter wrote:
> On Thu, Feb 14, 2013 at 02:28:19PM -0800, Jesse Barnes wrote:
> > Well, I think we'll have to punt in quite a few configs due to hw
> > limitations about what can be changed without a full pipe shutdown, but
>
kage introduced in
>
> commit 6c2a75325c800de286166c693e0cd33c3a1c5ec8
> Author: Daniel Vetter
> Date: Tue Dec 11 00:59:24 2012 +0100
>
> drm: refcounting for sprite framebuffers
>
> Reported-by: Jesse Barnes
> Cc: Jesse Barnes
> Cc: Rob Clark
> Sig
To be used to restore sprite state on resume.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_drv.h|5 +
drivers/gpu/drm/i915/intel_sprite.c | 23 +++
2 files changed, 28 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm
Had to fix up a few things:
- LVDS blind restore from old suspend/resume code
- cursor restore
- sprite restore
Plus a couple of misc patches. Enough to make things work in X, though
our handling of sprites still needs improvement; I think our watermarks
are programmed out of order even tho
Commented out and unneeded.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_fb.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c
index 987bc33..f4e0b88 100644
--- a/drivers/gpu/drm/i915/intel_fb.c
+++ b/drivers
Needed for VT switchless resume.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 3e6dadf..2bf076e 100644
With the other bits in place, we can do this safely.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_drv.c |9 ++---
drivers/gpu/drm/i915/intel_fb.c |3 +++
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm
This will poke userspace into probing for configuration changes that may
have occurred across suspend/resume.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_drv.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu
We still rely on a few LVDS bits, but restoring the enable bit can cause
trouble at this point, so don't.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_suspend.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_suspend.c
b/dr
Fixed up the sprite bits to actually work, I had the tracking of the
state in the wrong place, which meant we'd use pre-modified bits on
resume, leading to breakage. The other patches are the same.
Thanks,
Jesse
___
Intel-gfx mailing list
Intel-gfx@lis
Needed for VT switchless resume.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 3e6dadf..2bf076e 100644
With the other bits in place, we can do this safely.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_drv.c |9 ++---
drivers/gpu/drm/i915/intel_fb.c |3 +++
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm
To be used to restore sprite state on resume.
v2: move sprite tracking bits up so we don't track modified sprite state
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_drv.h|5 +
drivers/gpu/drm/i915/intel_sprite.c | 23 +++
2 files change
Commented out and unneeded.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_fb.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c
index 987bc33..f4e0b88 100644
--- a/drivers/gpu/drm/i915/intel_fb.c
+++ b/drivers
We still rely on a few LVDS bits, but restoring the enable bit can cause
trouble at this point, so don't.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_suspend.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_suspend.c
b/dr
This will poke userspace into probing for configuration changes that may
have occurred across suspend/resume.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_drv.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu
On Fri, 15 Feb 2013 22:10:39 +0100
Daniel Vetter wrote:
> On Fri, Feb 15, 2013 at 12:42:32PM -0800, Jesse Barnes wrote:
> > We still rely on a few LVDS bits, but restoring the enable bit can cause
> > trouble at this point, so don't.
> >
> > Signed-off-by: Jesse
To be used to restore sprite state on resume.
v2: move sprite tracking bits up so we don't track modified sprite state
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_drv.h|5 +
drivers/gpu/drm/i915/intel_sprite.c | 23 +++
2 files change
Needed for VT switchless resume.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 3e6dadf..2bf076e 100644
With the other bits in place, we can do this safely.
v2: disable backlight on suspend to prevent premature enablement on resume
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_drv.c | 12 +---
drivers/gpu/drm/i915/intel_fb.c |3 +++
2 files changed, 12 insertions(+), 3
This will poke userspace into probing for configuration changes that may
have occurred across suspend/resume.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_drv.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu
We still rely on a few LVDS bits, but restoring the enable bit can cause
trouble at this point, so don't.
v2: use the right mask to prevent restore (Daniel)
conditionalize on KMS support (Denial)
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_suspend.c |8 ++--
1
Commented out and unneeded.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_fb.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c
index 987bc33..f4e0b88 100644
--- a/drivers/gpu/drm/i915/intel_fb.c
+++ b/drivers
A few more fixes from Daniel.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Mon, 18 Feb 2013 16:03:20 +0100
Daniel Vetter wrote:
> On Fri, Feb 15, 2013 at 01:23:08PM -0800, Jesse Barnes wrote:
> > A few more fixes from Daniel.
>
> So one thing that crossed my mind which we should at least quickly
> discuss: How is userspace supposed to notice the r
On Mon, 18 Feb 2013 19:58:26 -0500
Kristian Høgsberg wrote:
> On Mon, Feb 18, 2013 at 10:03 AM, Daniel Vetter wrote:
> > On Fri, Feb 15, 2013 at 01:23:08PM -0800, Jesse Barnes wrote:
> >> A few more fixes from Daniel.
> >
> > So one thing that crossed my mind wh
On Mon, 18 Feb 2013 19:19:55 +0200
Ville Syrjälä wrote:
> On Fri, Feb 15, 2013 at 01:23:10PM -0800, Jesse Barnes wrote:
> > To be used to restore sprite state on resume.
> >
> > v2: move sprite tracking bits up so we don't track modified sprite state
> >
To be used to restore sprite state on resume.
v2: move sprite tracking bits up so we don't track modified sprite state
v3: use src_x/y in sprite suspend/resume code (Ville)
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_drv.h|5 +
drivers/gpu/drm/i915/intel_spr
We still rely on a few LVDS bits, but restoring the enable bit can cause
trouble at this point, so don't.
v2: use the right mask to prevent restore (Daniel)
conditionalize on KMS support (Denial)
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_suspend.c |8 ++--
1
This will poke userspace into probing for configuration changes that may
have occurred across suspend/resume.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_drv.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu
Needed for VT switchless resume.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 3e6dadf..2bf076e 100644
With the other bits in place, we can do this safely.
v2: disable backlight on suspend to prevent premature enablement on resume
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_drv.c | 12 +---
drivers/gpu/drm/i915/intel_fb.c |3 +++
2 files changed, 12 insertions(+), 3
Commented out and unneeded.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_fb.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c
index 987bc33..f4e0b88 100644
--- a/drivers/gpu/drm/i915/intel_fb.c
+++ b/drivers
Updated with the fix from Ville.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
From: Chris Wilson
Wrap a preallocated region of stolen memory within an ordinary GEM
object, for example the BIOS framebuffer.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.h|5 +++
drivers/gpu/drm/i915/i915_gem_stolen.c | 65
2 f
driver can still fall back the same way as the core.
Signed-off-by: Jesse Barnes
Signed-off-by: Chris Wilson
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/drm_fb_helper.c | 23 +++
include/drm/drm_fb_helper.h |4
2 files changed, 19 insertions(+), 8
This one adds some extra checks on top of Chris's last set:
- check for panel fit modes when inheriting from the BIOS
- update pfit state at pipe_set_base time
It also changes the mode set vs flip checking to include the non-fb case
(e.g. if the BIOS fb was too small for the native mode), sinc
From: Chris Wilson
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_display.c |9 +
drivers/gpu/drm/i915/intel_dp.c |1 +
drivers/gpu/drm/i915/intel_drv.h |8
drivers/gpu/drm/i915/intel_fb.c |9 +
drivers/gpu/drm/i915/intel_lvds.c
From: Chris Wilson
As we retrieve the mode from the BIOS it may be constructed using
different assumptions for its configuration, such as utilizing the panel
fitter in a conflicting manner. As such the associated framebuffer may be
insufficient for our setup, and so we need to reject the current
Missing a curly brace.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 0a2279e..595590c 100644
--- a/drivers/gpu/drm
From: Chris Wilson
This will be shared with wrapping the BIOS framebuffer into the fbdev
later. In the meantime, we can tidy the code slightly and improve the
error path handling.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_display.c |7 --
drivers/gpu/drm/i915/intel_drv.h
From: Chris Wilson
Modifying the clock sources (via the DREF control on the PCH) is a slow
multi-stage process as we need to let the clocks stabilise between each
stage. If we are not actually changing the clock sources, then we can
return early.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm
From: Chris Wilson
Read the current hardware state to retrieve the active mode and populate
our CRTC config if that mode matches our presumptions.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.h |2 +
drivers/gpu/drm/i915/intel_crt.c | 27 +++-
drivers/gpu/dr
From: Chris Wilson
Signed-off-by: Chris Wilson
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_dma.c |8 +-
drivers/gpu/drm/i915/i915_drv.h |2 +-
drivers/gpu/drm/i915/intel_display.c | 14 +-
drivers/gpu/drm/i915/intel_drv.h |4 +
drivers/gpu/drm/i915
In case we don't get an fb from the BIOS, we may still be able to re-use
existing state and flip a new buffer.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display
If the mode is non-native using the panel fitter, don't try to re-use
the fb the BIOS allocated for it.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_fb.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm
We may need to disable the panel when flipping to a new buffer, so check
the state here and zero it out if needed, otherwise leave it alone.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers
Turns out it's easy to get the clock, though it may correspond to a
potential pfit mode. In that case, we may still be able to flip if
we can get the native mode params somehow.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c | 26 +++---
1
> associated GPU lockups, which makes my ivy bridge machine stable.
> >
> >
> Ping?
Seems ok to me. Ouping, can you measure any power difference between
the two values?
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
__
e for it.
>
> Tbh, I think that cache should die. I think the hitrate is near zero,
> and offers no benefit over just writing the register directly.
> -Chris
>
Seconded.
--
Jesse Barnes, Intel Open Source Technology Center
__
wrote:
> Hi Jesse,
>
> Do you mean increase /sys/class/drm/card0/power/rc6p_residency_ms from 10
> to 15, and measure power difference on IVB when system is on idle?
>
> -----Original Message-
> From: Jesse Barnes [mailto:jbar...@virtuousgeek.org]
> Sen
management up to the callers) provided that the i915 driver appears to
> not be loaded (according to sysfs)
>
> Requested by Jesse.
>
> Cc: Jesse Barnes
> Signed-off-by: Ben Widawsky
> ---
> lib/intel_mmio.c | 30 ++
> 1 file changed, 26 inse
ass/drm/card0/power/rc6p_residency_ms
> rc6_residency_ms increase from 6708 to 483627
> rc6p_residency_ms increase from 410092 to 423378
>
> -Original Message-
> From: Jesse Barnes [mailto:jbar...@virtuousgeek.org]
> Sent: Friday, February 22, 2013 12:50 AM
> To: Zhang, Ou
On Mon, 25 Feb 2013 16:19:53 -0300
Paulo Zanoni wrote:
> Hi
>
> 2013/2/19 Paulo Zanoni :
> > 2013/2/19 Jesse Barnes :
> >> Updated with the fix from Ville.
> >
> > Very briefly tested on SNB (LVDS) and HSW (eDP + DP). Suspend-to-ram +
> > resume
Great, then if it helps Stephane, I think we should merge it.
Acked-by-top-post: Jesse Barnes
On Wed, 27 Feb 2013 05:50:08 +
"Zhang, Ouping" wrote:
> Increase the RC6p threshold from 10 to 15, there is no power
> difference between the two values.
> for exampl
a, and you seem to have completely ignored them. Moreover, this
> interface provides no mechanism to query for its existence (other than
> relying on the kernel version), and no method to deprecate it.
Before you get all wound up about this, note that you're replying to a
kernel internal funct
Lots of updates and additions for VLV, all tested this time. The
biggest changes are the DPIO programming bits. Lots of the clock and
lane configuration stuff is off on the other side of DPIO, and these
patches are enough to get dual-head configs working with eDP and HDMI,
complete with hotplug a
No constant alpha yet though, that needs a new ioctl and/or property to
get/set.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_dma.c |4 +
drivers/gpu/drm/i915/i915_drv.h |1 +
drivers/gpu/drm/i915/i915_reg.h | 57 +
drivers/gpu/drm/i915
Need to make sure sprites are disabled before shutting off a pipe.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index
References: https://bugs.freedesktop.org/show_bug.cgi?id=50250
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_reg.h |3 +++
drivers/gpu/drm/i915/intel_pm.c |4
2 files changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
In Valleyview voltage swing, pre-emphasis and lane control registers can
be programmed only through the h/w side band fabric. Update
vlv_update_pll, i9xx_crtc_enable, and intel_enable_pll with the
appropriate programming.
We need to make sure that the tx lane reset occurs in both the full mode
se
901 - 1000 of 3350 matches
Mail list logo