[Intel-gfx] [PATCH 05/24] drm/i915: add wrappers around cdclk vtable funcs.

From: Dave Airlie This adds wrappers around all the vtable callers so they are in one place. Suggested by Jani. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c| 47 +++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH 07/24] drm/i915: split clock gating init from display vtable

From: Dave Airlie This function is only used inside intel_pm.c Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 9 ++- drivers/gpu/drm/i915/intel_pm.c | 48 - 2 files changed, 32

[Intel-gfx] [PATCH 08/24] drm/i915: split watermark vfuncs from display vtable.

From: Dave Airlie These are the watermark api between display and pm. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 34 - drivers/gpu/drm/i915/i915_drv.h | 24

[Intel-gfx] [PATCH 06/24] drm/i915/display: add intel_fdi_link_train wrapper.

From: Dave Airlie This wraps the fdi link training vfunc to make it clearer. Suggested by Jani. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_fdi.c | 8

[Intel-gfx] [PATCH 09/24] drm/i915: split color functions from display vtable

From: Dave Airlie These are only used internally in the color module Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c | 64 +++--- drivers/gpu/drm/i915/i915_drv.h| 39 +++-- 2

[Intel-gfx] [PATCH 10/24] drm/i915: split audio functions from display vtable

From: Dave Airlie These are only used internally in the audio code Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_audio.c | 24 +++--- drivers/gpu/drm/i915/i915_drv.h| 19 +++-- 2

[Intel-gfx] [PATCH 12/24] drm/i915: split irq hotplug function from display vtable

From: Dave Airlie This provide a service from irq to display, so make it separate Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hotplug.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 9 - drivers

[Intel-gfx] [PATCH 14/24] drm/i915: split the dpll clock compute out from display vtable.

From: Dave Airlie this single function might be possible to merge later, but for now it's simple to just split it out. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 +++--- drivers/gpu/drm/i915/di

[Intel-gfx] [PATCH 13/24] drm/i915: split fdi link training from display vtable.

From: Dave Airlie It may make sense to merge this with display again later, however the fdi use of the vtable is limited to only a few generations. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fdi.c | 8

[Intel-gfx] [PATCH 15/24] drm/i915: constify fdi link training vtable

From: Dave Airlie Put the vtable into ro memory. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fdi.c | 20 drivers/gpu/drm/i915/i915_drv.h | 2 +- 2 files changed, 17 insertions(+), 5

[Intel-gfx] [PATCH 11/24] drm/i915: split cdclk functions from display vtable.

From: Dave Airlie This moves all the cdclk related functions into their own vtable. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 142 ++--- drivers/gpu/drm/i915/i915_drv.h| 8

[Intel-gfx] [PATCH 16/24] drm/i915: constify hotplug function vtable.

From: Dave Airlie Use a macro to avoid mistakes, this type of macro is only used in a couple of places. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hotplug.c | 4 +-- drivers/gpu/drm/i915/i915_drv.h | 2

[Intel-gfx] [PATCH 17/24] drm/i915: constify color function vtable.

From: Dave Airlie This clarifies quite well what functions get used on what platforms instead of having to decipher the old tree. v2: fixed IVB mistake (Jani) Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c | 138

[Intel-gfx] [PATCH 18/24] drm/i915: constify the audio function vtable

From: Dave Airlie Move the functions into read-only tables. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_audio.c | 43 ++ drivers/gpu/drm/i915/i915_drv.h| 2 +- 2 files changed, 28

[Intel-gfx] [PATCH 19/24] drm/i915: constify the dpll clock vtable

From: Dave Airlie Most the dpll vtable into read-only memory. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 +-- drivers/gpu/drm/i915/display/intel_dpll.c| 48 drivers/gpu/drm

[Intel-gfx] [PATCH 20/24] drm/i915: constify the cdclk vtable

From: Dave Airlie This is a bit of a twisty one since each platform is slightly different, so might take some more review care. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 300 ++--- drivers

[Intel-gfx] [PATCH 21/24] drm/i915: drop unused function ptr and comments.

From: Dave Airlie There was some excess comments and an unused vtbl ptr. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu

[Intel-gfx] [PATCH 22/24] drm/i915: constify display function vtable

From: Dave Airlie Make nice clear tables instead of having things in two places. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 81 drivers/gpu/drm/i915/i915_drv.h | 2 +- 2

[Intel-gfx] [PATCH 23/24] drm/i915: constify clock gating init vtable.

From: Dave Airlie I used a macro to avoid making any really silly mistakes here. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_pm.c | 78 +++-- 2 files

[Intel-gfx] [PATCH 24/24] drm/i915: constify display wm vtable

From: Dave Airlie Use a nop table for the cases where CxSR doesn't init properly. v2: use a nop table (Jani) Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 34 - drivers/gpu/drm/i915/i915_

Re: [Intel-gfx] [PATCH] drm/i915: Tile F plane format support

k; > + case I915_FORMAT_MOD_F_TILED: > + if (!HAS_FTILE(dev_priv)) > + return false; > + fallthrough; > default: > return false; > } Seems odd. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center

[Intel-gfx] [PULL] drm-intel-fixes

/drm/i915/display/intel_dmc.c | 5 - drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 9 + 3 files changed, 25 insertions(+), 8 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH] drm/i915/guc, docs: Fix pdfdocs build error by removing nested grid

--+ | > + * | 0 | 31:0 | > | > + * +---+---+ > | > + * |...| | [Embedded `HXG Message`_] > | > + * +---+---+ > | > + * | n | 31:0 | > | > * > +---+---+--+ > */ > > > base-commit: 242f4c77b1c8cebfdfa0ad5b40e2e4ae0316e57d -- Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH 0/6] drm/i915: Reject bogus modes with fixed mode panels

lay/intel_sdvo.c | 21 ++- > drivers/gpu/drm/i915/display/vlv_dsi.c | 39 +--- > 9 files changed, 116 insertions(+), 65 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH 01/13] drm/i915/tc: Fix TypeC port init/resume time sanitization

gt; @@ -12502,17 +12503,6 @@ intel_modeset_setup_hw_state(struct drm_device *dev, >> intel_modeset_readout_hw_state(dev); >> >> /* HW state is read out, now we need to sanitize this mess. */ >> - >> -/* Sanitize the TypeC port mode upfront, encoders depend on this */ >> -for_each_intel_encoder(dev, encoder) { >> -enum phy phy = intel_port_to_phy(dev_priv, encoder->port); >> - >> -/* We need to sanitize only the MST primary port. */ >> -if (encoder->type != INTEL_OUTPUT_DP_MST && >> -intel_phy_is_tc(dev_priv, phy)) >> -intel_tc_port_sanitize(enc_to_dig_port(encoder)); >> -} >> - >> get_encoder_power_domains(dev_priv); >> >> if (HAS_PCH_IBX(dev_priv)) > -- Jani Nikula, Intel Open Source Graphics Center

[Intel-gfx] [CI 01/24] drm/i915/uncore: split the fw get function into separate vfunc

From: Dave Airlie constify it while here. drop the put function since it was never overloaded and always has done the same thing, no point in indirecting it for show. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_uncore.c | 70

[Intel-gfx] [CI 02/24] drm/i915/pm: drop get_fifo_size vfunc.

From: Dave Airlie The i845_update_wm code was always calling the i845 variant, and the i9xx_update_wm had only a choice between i830 and i9xx paths, hardly worth the vfunc overhead. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915

[Intel-gfx] [CI 03/24] drm/i915: make update_wm take a dev_priv.

From: Dave Airlie The crtc was never being used here. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 10 +- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [CI 04/24] drm/i915/wm: provide wrappers around watermark vfuncs calls (v2)

v2: fixup warnings in wrong place error. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 187 --- drivers/gpu/drm/i915/intel_pm.c | 39 drivers/gpu/drm/i915/intel_p

[Intel-gfx] [CI 05/24] drm/i915: add wrappers around cdclk vtable funcs.

From: Dave Airlie This adds wrappers around all the vtable callers so they are in one place. Suggested by Jani. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c| 47 +++ drivers/gpu/drm/i915

[Intel-gfx] [CI 06/24] drm/i915/display: add intel_fdi_link_train wrapper.

From: Dave Airlie This wraps the fdi link training vfunc to make it clearer. Suggested by Jani. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_fdi.c | 8

[Intel-gfx] [CI 07/24] drm/i915: split clock gating init from display vtable

From: Dave Airlie This function is only used inside intel_pm.c Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 9 ++- drivers/gpu/drm/i915/intel_pm.c | 48 - 2 files changed, 32

[Intel-gfx] [CI 08/24] drm/i915: split watermark vfuncs from display vtable.

From: Dave Airlie These are the watermark api between display and pm. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 34 - drivers/gpu/drm/i915/i915_drv.h | 24

[Intel-gfx] [CI 09/24] drm/i915: split color functions from display vtable

From: Dave Airlie These are only used internally in the color module Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c | 64 +++--- drivers/gpu/drm/i915/i915_drv.h| 39 +++-- 2

[Intel-gfx] [CI 10/24] drm/i915: split audio functions from display vtable

From: Dave Airlie These are only used internally in the audio code Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_audio.c | 24 +++--- drivers/gpu/drm/i915/i915_drv.h| 19 +++-- 2

[Intel-gfx] [CI 11/24] drm/i915: split cdclk functions from display vtable.

From: Dave Airlie This moves all the cdclk related functions into their own vtable. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 142 ++--- drivers/gpu/drm/i915/i915_drv.h| 8

[Intel-gfx] [CI 12/24] drm/i915: split irq hotplug function from display vtable

From: Dave Airlie This provide a service from irq to display, so make it separate Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hotplug.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 9 - drivers

[Intel-gfx] [CI 13/24] drm/i915: split fdi link training from display vtable.

From: Dave Airlie It may make sense to merge this with display again later, however the fdi use of the vtable is limited to only a few generations. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fdi.c | 8

[Intel-gfx] [CI 14/24] drm/i915: split the dpll clock compute out from display vtable.

From: Dave Airlie this single function might be possible to merge later, but for now it's simple to just split it out. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 +++--- drivers/gpu/drm/i915/di

[Intel-gfx] [CI 15/24] drm/i915: constify fdi link training vtable

From: Dave Airlie Put the vtable into ro memory. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fdi.c | 20 drivers/gpu/drm/i915/i915_drv.h | 2 +- 2 files changed, 17 insertions(+), 5

[Intel-gfx] [CI 16/24] drm/i915: constify hotplug function vtable.

From: Dave Airlie Use a macro to avoid mistakes, this type of macro is only used in a couple of places. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hotplug.c | 4 +-- drivers/gpu/drm/i915/i915_drv.h | 2

[Intel-gfx] [CI 18/24] drm/i915: constify the audio function vtable

From: Dave Airlie Move the functions into read-only tables. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_audio.c | 43 ++ drivers/gpu/drm/i915/i915_drv.h| 2 +- 2 files changed, 28

[Intel-gfx] [CI 20/24] drm/i915: constify the cdclk vtable

From: Dave Airlie This is a bit of a twisty one since each platform is slightly different, so might take some more review care. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 300 ++--- drivers

[Intel-gfx] [CI 17/24] drm/i915: constify color function vtable.

From: Dave Airlie This clarifies quite well what functions get used on what platforms instead of having to decipher the old tree. v2: fixed IVB mistake (Jani) Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c | 138

[Intel-gfx] [CI 21/24] drm/i915: drop unused function ptr and comments.

From: Dave Airlie There was some excess comments and an unused vtbl ptr. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu

[Intel-gfx] [CI 19/24] drm/i915: constify the dpll clock vtable

From: Dave Airlie Most the dpll vtable into read-only memory. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 +-- drivers/gpu/drm/i915/display/intel_dpll.c| 48 drivers/gpu/drm

[Intel-gfx] [CI 22/24] drm/i915: constify display function vtable

From: Dave Airlie Make nice clear tables instead of having things in two places. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 81 drivers/gpu/drm/i915/i915_drv.h | 2 +- 2

[Intel-gfx] [CI 23/24] drm/i915: constify clock gating init vtable.

From: Dave Airlie I used a macro to avoid making any really silly mistakes here. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_pm.c | 78 +++-- 2 files

[Intel-gfx] [CI 24/24] drm/i915: constify display wm vtable

From: Dave Airlie Use a nop table for the cases where CxSR doesn't init properly. v2: use a nop table (Jani) Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 34 - drivers/gpu/drm/i915/i915_

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix the dsc check while selecting min_cdclk

er min cdclk if vDSC enabled") > Suggested-by: Jani Nikula > Signed-off-by: Vandita Kulkarni Sorry for the delay! Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_cdclk.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) >

Re: [Intel-gfx] [PULL] gvt-fixes

-- > Zhi A Wang (1): > drm/i915/gvt: fix the usage of ww lock in gvt scheduler. > > drivers/gpu/drm/i915/gvt/scheduler.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH V5] drm/i915/gen11: Disable cursor clock gating in HDR mode

plane control register >* are blocked if the memory self-refresh mode is active at that > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index ef594df039db..7b3eed5b4e42 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/dr

Re: [Intel-gfx] [PATCH] drm/i915/audio: Use BIOS provided value for RKL HDA link

This had fallen between the cracks, pushed now. Thanks for the patch and review. BR, Jani. > > Br, Kai -- Jani Nikula, Intel Open Source Graphics Center

[Intel-gfx] [CI AGAIN 1/8] drm/i915/uncore: split the fw get function into separate vfunc

From: Dave Airlie constify it while here. drop the put function since it was never overloaded and always has done the same thing, no point in indirecting it for show. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_uncore.c | 70

[Intel-gfx] [CI AGAIN 2/8] drm/i915/pm: drop get_fifo_size vfunc.

From: Dave Airlie The i845_update_wm code was always calling the i845 variant, and the i9xx_update_wm had only a choice between i830 and i9xx paths, hardly worth the vfunc overhead. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915

[Intel-gfx] [CI AGAIN 3/8] drm/i915: make update_wm take a dev_priv.

From: Dave Airlie The crtc was never being used here. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 10 +- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [CI AGAIN 4/8] drm/i915/wm: provide wrappers around watermark vfuncs calls (v2)

v2: fixup warnings in wrong place error. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 187 --- drivers/gpu/drm/i915/intel_pm.c | 39 drivers/gpu/drm/i915/intel_p

[Intel-gfx] [CI AGAIN 5/8] drm/i915: add wrappers around cdclk vtable funcs.

From: Dave Airlie This adds wrappers around all the vtable callers so they are in one place. Suggested by Jani. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c| 47 +++ drivers/gpu/drm/i915

[Intel-gfx] [CI AGAIN 6/8] drm/i915/display: add intel_fdi_link_train wrapper.

From: Dave Airlie This wraps the fdi link training vfunc to make it clearer. Suggested by Jani. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_fdi.c | 8

[Intel-gfx] [CI AGAIN 7/8] drm/i915: split clock gating init from display vtable

From: Dave Airlie This function is only used inside intel_pm.c Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 9 ++- drivers/gpu/drm/i915/intel_pm.c | 48 - 2 files changed, 32

[Intel-gfx] [CI AGAIN 8/8] drm/i915: split watermark vfuncs from display vtable.

From: Dave Airlie These are the watermark api between display and pm. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 34 - drivers/gpu/drm/i915/i915_drv.h | 24

[Intel-gfx] [PATCH] drm/locking: add backtrace for locking contended locks without backoff

ce. [1] https://lore.kernel.org/r/20210924114741.15940-4-jani.nik...@intel.com Cc: Daniel Vetter Cc: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/Kconfig| 13 drivers/gpu/drm/drm_modeset_lock.c | 49 -- include/drm/drm_modeset_l

[Intel-gfx] [PATCH 00/24] i915/display: split and constify vtable, again

I must have read the series several times over without spotting the issue, but finally figured it out with the help of [1]. Return value and check added to intel_compute_global_watermarks() in patch 4, and a couple of patches rebased. Seems so obvious now... Fingers crossed. BR, Jani. [1] http

[Intel-gfx] [PATCH 01/24] drm/i915/uncore: split the fw get function into separate vfunc

From: Dave Airlie constify it while here. drop the put function since it was never overloaded and always has done the same thing, no point in indirecting it for show. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_uncore.c | 70

[Intel-gfx] [PATCH 02/24] drm/i915/pm: drop get_fifo_size vfunc.

From: Dave Airlie The i845_update_wm code was always calling the i845 variant, and the i9xx_update_wm had only a choice between i830 and i9xx paths, hardly worth the vfunc overhead. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 03/24] drm/i915: make update_wm take a dev_priv.

From: Dave Airlie The crtc was never being used here. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 10 +- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH 04/24] drm/i915/wm: provide wrappers around watermark vfuncs calls (v3)

v2: fixup warnings in wrong place error. v3 by Jani: fix intel_compute_global_watermarks() return value check Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 186 --- drivers/gpu/drm/i915/intel_p

[Intel-gfx] [PATCH 05/24] drm/i915: add wrappers around cdclk vtable funcs.

From: Dave Airlie This adds wrappers around all the vtable callers so they are in one place. Suggested by Jani. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c| 47 +++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH 06/24] drm/i915/display: add intel_fdi_link_train wrapper.

From: Dave Airlie This wraps the fdi link training vfunc to make it clearer. Suggested by Jani. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_fdi.c | 8

[Intel-gfx] [PATCH 07/24] drm/i915: split clock gating init from display vtable

From: Dave Airlie This function is only used inside intel_pm.c Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 9 ++- drivers/gpu/drm/i915/intel_pm.c | 48 - 2 files changed, 32

[Intel-gfx] [PATCH 08/24] drm/i915: split watermark vfuncs from display vtable.

From: Dave Airlie These are the watermark api between display and pm. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 34 - drivers/gpu/drm/i915/i915_drv.h | 24

[Intel-gfx] [PATCH 09/24] drm/i915: split color functions from display vtable

From: Dave Airlie These are only used internally in the color module Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c | 64 +++--- drivers/gpu/drm/i915/i915_drv.h| 39 +++-- 2

[Intel-gfx] [PATCH 10/24] drm/i915: split audio functions from display vtable

From: Dave Airlie These are only used internally in the audio code Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_audio.c | 24 +++--- drivers/gpu/drm/i915/i915_drv.h| 19 +++-- 2

[Intel-gfx] [PATCH 11/24] drm/i915: split cdclk functions from display vtable.

From: Dave Airlie This moves all the cdclk related functions into their own vtable. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 142 ++--- drivers/gpu/drm/i915/i915_drv.h| 8

[Intel-gfx] [PATCH 12/24] drm/i915: split irq hotplug function from display vtable

From: Dave Airlie This provide a service from irq to display, so make it separate Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hotplug.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 9 - drivers

[Intel-gfx] [PATCH 13/24] drm/i915: split fdi link training from display vtable.

From: Dave Airlie It may make sense to merge this with display again later, however the fdi use of the vtable is limited to only a few generations. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fdi.c | 8

[Intel-gfx] [PATCH 14/24] drm/i915: split the dpll clock compute out from display vtable.

From: Dave Airlie this single function might be possible to merge later, but for now it's simple to just split it out. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 +++--- drivers/gpu/drm/i915/di

[Intel-gfx] [PATCH 15/24] drm/i915: constify fdi link training vtable

From: Dave Airlie Put the vtable into ro memory. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fdi.c | 20 drivers/gpu/drm/i915/i915_drv.h | 2 +- 2 files changed, 17 insertions(+), 5

[Intel-gfx] [PATCH 16/24] drm/i915: constify hotplug function vtable.

From: Dave Airlie Use a macro to avoid mistakes, this type of macro is only used in a couple of places. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hotplug.c | 4 +-- drivers/gpu/drm/i915/i915_drv.h | 2

[Intel-gfx] [PATCH 17/24] drm/i915: constify color function vtable.

From: Dave Airlie This clarifies quite well what functions get used on what platforms instead of having to decipher the old tree. v2: fixed IVB mistake (Jani) Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c | 138

[Intel-gfx] [PATCH 18/24] drm/i915: constify the audio function vtable

From: Dave Airlie Move the functions into read-only tables. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_audio.c | 43 ++ drivers/gpu/drm/i915/i915_drv.h| 2 +- 2 files changed, 28

[Intel-gfx] [PATCH 19/24] drm/i915: constify the dpll clock vtable

From: Dave Airlie Most the dpll vtable into read-only memory. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 +-- drivers/gpu/drm/i915/display/intel_dpll.c| 48 drivers/gpu/drm

[Intel-gfx] [PATCH 20/24] drm/i915: constify the cdclk vtable

From: Dave Airlie This is a bit of a twisty one since each platform is slightly different, so might take some more review care. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 300 ++--- drivers

[Intel-gfx] [PATCH 21/24] drm/i915: drop unused function ptr and comments.

From: Dave Airlie There was some excess comments and an unused vtbl ptr. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu

[Intel-gfx] [PATCH 22/24] drm/i915: constify display function vtable

From: Dave Airlie Make nice clear tables instead of having things in two places. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 81 drivers/gpu/drm/i915/i915_drv.h | 2 +- 2

[Intel-gfx] [PATCH 23/24] drm/i915: constify clock gating init vtable.

From: Dave Airlie I used a macro to avoid making any really silly mistakes here. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_pm.c | 78 +++-- 2 files

[Intel-gfx] [PATCH 24/24] drm/i915: constify display wm vtable

From: Dave Airlie Use a nop table for the cases where CxSR doesn't init properly. v2: use a nop table (Jani) Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 34 - drivers/gpu/drm/i915/i915_

Re: [Intel-gfx] [PATCH 0/6] drm/i915: Reject bogus modes with fixed mode panels

pimp the connector's mode list validation > a bit. On the series, Reviewed-by: Jani Nikula > > Ville Syrjälä (6): > drm/i915: Extract intel_panel_mode_valid() > drm/i915: Use intel_panel_mode_valid() for DSI/LVDS/DVO > drm/i915: Reject modes that don't match f

Re: [Intel-gfx] [PATCH 00/24] i915/display: split and constify vtable, again

On Wed, 29 Sep 2021, Jani Nikula wrote: > I must have read the series several times over without spotting the > issue, but finally figured it out with the help of [1]. > > Return value and check added to intel_compute_global_watermarks() in > patch 4, and a couple of patches re

Re: [Intel-gfx] [PATCH v2] drm/i915: Update memory bandwidth formulae

"BW%d / PSF GV %d: num_planes=%d bw=%u\n", > i, j, bi->num_planes, bi->psf_bw[j]); > } > - > - if (bi->num_planes == 1) > - break; > } > > /* > @@ -339,7 +378,7 @@ static int icl_get_bw_info(struct drm_i915_private > *dev_priv, const struct intel >* SAGV point, but we can't send PCode commands to restrict it >* as it will fail and pointless anyway. >*/ > - if (qi.num_points == 1) > + if (qi.num_points >= 1) > dev_priv->sagv_status = I915_SAGV_NOT_CONTROLLED; > else > dev_priv->sagv_status = I915_SAGV_ENABLED; -- Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/dp: Add Additional DP2 Headers (rev2)

On Tue, 28 Sep 2021, "Zuo, Jerry" wrote: > [AMD Official Use Only] > > Hi: > > I don’t think this failure is related to the patch. Please help to > confirm. It's not, sorry for the noise. BR, Jani. > > Regards, > Jerry > > From: Patchwork > Sent: September 27, 2021 7:51 PM > To: Zuo, Jerry >

Re: [Intel-gfx] [PATCH] drm/i915: Enable TPS3/4 on all platforms that support them

15) I guess it's fathomable we'd have different ports supporting different training patterns, similar to the max rates. But it's easy enough to pass intel_dp again in that case. Acked-by: Jani Nikula > { > - int max_rate = intel_dp->source_rates[intel_dp->num_so

[Intel-gfx] [PULL] drm-intel-fixes

rker Akira Yokosawa (1): drm/i915/guc, docs: Fix pdfdocs build error by removing nested grid Jani Nikula (1): Merge tag 'gvt-fixes-2021-09-18' of https://github.com/intel/gvt-linux into drm-intel-fixes Matthew Auld (1): drm/i915/requ

[Intel-gfx] [PATCH 0/4] drm/i915/display: move modeset asserts out of intel_display.c

m together. In any case, I think *all* the assert functions need to be moved out of intel_display.c. BR, Jani. Jani Nikula (4): drm/i915/fdi: move fdi modeset asserts to intel_fdi.c drm/i915/pps: move pps (panel) modeset asserts to intel_pps.c drm/i915/dpll: move dpll modeset asserts

[Intel-gfx] [PATCH 1/4] drm/i915/fdi: move fdi modeset asserts to intel_fdi.c

Keep the functionality and the assert code together. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 72 drivers/gpu/drm/i915/display/intel_display.h | 4 - drivers/gpu/drm/i915/display/intel_fdi.c | 91 drivers/gpu/drm

[Intel-gfx] [PATCH 2/4] drm/i915/pps: move pps (panel) modeset asserts to intel_pps.c

atter. However, intel_pps.c is the best fit for anything touching the PPS registers. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 60 +--- drivers/gpu/drm/i915/display/intel_display.h | 2 - drivers/gpu/drm/i915/display/intel_dpll.c

[Intel-gfx] [PATCH 4/4] drm/i915/dsi: move dsi pll modeset asserts to vlv_dsi_pll.c

Keep the functionality and the assert code together. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c | 1 + drivers/gpu/drm/i915/display/intel_display.c | 16 -- drivers/gpu/drm/i915/display/intel_display.h | 3 --- drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH 3/4] drm/i915/dpll: move dpll modeset asserts to intel_dpll.c

Keep the functionality and the assert code together. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c| 1 + drivers/gpu/drm/i915/display/intel_display.c | 14 drivers/gpu/drm/i915/display/intel_display.h | 4 .../drm/i915/display

[Intel-gfx] [PATCH] drm/i915/fdi: use -EAGAIN instead of local special return value

Using standard -EAGAIN should be perfectly fine instead of using a special case value. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 11 +-- drivers/gpu/drm/i915/display/intel_fdi.c | 2 +- drivers/gpu/drm/i915/display/intel_fdi.h | 1 - 3 files

Re: [Intel-gfx] [PATCH 1/4] drm/i915/fdi: move fdi modeset asserts to intel_fdi.c

On Thu, 30 Sep 2021, Ville Syrjälä wrote: > On Thu, Sep 30, 2021 at 12:22:58PM +0300, Jani Nikula wrote: > >> diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c >> b/drivers/gpu/drm/i915/display/intel_fdi.c >> index af01d1fa761e..02d3294bad7b 100644 >> ---

<    1   2   3   4   5   6   7   8   9   10   >