[Intel-gfx] [PATCH 03/21] drm/i915/dvo: rename dvo.h to intel_dvo_dev.h and make self-contained

Put the header more in line with the rest. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/dvo_ch7017.c | 3 ++- drivers/gpu/drm/i915/dvo_ch7xxx.c | 3 ++- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 04/21] drm/i915: make intel_dpll_mgr.h self-contained

And ensure it stays that way. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/intel_dpll_mgr.c | 1 + drivers/gpu/drm/i915/intel_dpll_mgr.h | 8 ++-- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 07/21] drm/i915: extract intel_dp_link_training.h from intel_drv.h

minimal further includes, using forward declarations as needed. Include the new header only where needed, and sort the modified include directives while at it and as needed. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm

[Intel-gfx] [PATCH 06/21] drm/i915: extract intel_fifo_underrun.h from intel_drv.h

minimal further includes, using forward declarations as needed. Include the new header only where needed, and sort the modified include directives while at it and as needed. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 14/21] drm/i915: extract intel_vdsc.h from intel_drv.h and i915_drv.h

minimal further includes, using forward declarations as needed. Include the new header only where needed, and sort the modified include directives while at it and as needed. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 11/21] drm/i915: extract intel_bios.h functions from i915_drv.h

minimal further includes, using forward declarations as needed. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 16 drivers/gpu/drm/i915/intel_bios.h | 19 +++ 2 files changed, 19 insertions(+), 16 deletions(-) diff --git a

[Intel-gfx] [PATCH 09/21] drm/i915: extract i915_irq.h from intel_drv.h and i915_drv.h

minimal further includes, using forward declarations as needed. Include the new header only where needed, and sort the modified include directives while at it and as needed. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 15/21] drm/i915: extract intel_dp_mst.h from intel_drv.h

minimal further includes, using forward declarations as needed. Include the new header only where needed, and sort the modified include directives while at it and as needed. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 16/21] drm/i915: extract intel_dsi_dcs_backlight.h from intel_drv.h

minimal further includes, using forward declarations as needed. Include the new header only where needed, and sort the modified include directives while at it and as needed. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm

[Intel-gfx] [PATCH 17/21] drm/i915: extract intel_atomic.h from intel_drv.h

minimal further includes, using forward declarations as needed. Include the new header only where needed, and sort the modified include directives while at it and as needed. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 18/21] drm/i915: extract intel_runtime_pm.h from intel_drv.h

minimal further includes, using forward declarations as needed. Include the new header only where needed, and sort the modified include directives while at it and as needed. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 21/21] drm/i915: add single combo phy init/unit functions

Work on the principle that files should prefer not to expose platform specific functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_combo_phy.c | 24 drivers/gpu/drm/i915/intel_combo_phy.h | 6 ++ drivers/gpu/drm/i915/intel_runtime_pm.c | 10

[Intel-gfx] [PATCH 20/21] drm/i915: extract intel_combo_phy.h from i915_drv.h

minimal further includes, using forward declarations as needed. Include the new header only where needed, and sort the modified include directives while at it and as needed. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 19/21] drm/i915: move some leftovers to intel_pm.h from i915_drv.h

Commit 696173b064c6 ("drm/i915: extract intel_pm.h from intel_drv.h") missed the declarations in i915_drv.h. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 13 - drivers/gpu/drm/i915/i915_pmu.c | 3 ++- drivers/gpu/drm/i915/i915_sysfs.c | 3 ++- d

[Intel-gfx] [PATCH 02/21] drm/i915: make intel_bios.h self-contained

Just a types include required. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/intel_bios.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test

[Intel-gfx] [PATCH 10/21] drm/i915: extract intel_hotplug.h from intel_drv.h and i915_drv.h

minimal further includes, using forward declarations as needed. Include the new header only where needed, and sort the modified include directives while at it and as needed. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 12/21] drm/i915: extract intel_quirks.h from intel_drv.h

minimal further includes, using forward declarations as needed. Include the new header only where needed, and sort the modified include directives while at it and as needed. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 3 ++- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 08/21] drm/i915: extract intel_dp_aux_backlight.h from intel_drv.h

minimal further includes, using forward declarations as needed. Include the new header only where needed, and sort the modified include directives while at it and as needed. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm

[Intel-gfx] [PATCH 00/21] drm/i915: the great header refactoring, part two

Continue the header refactoring started in part one [1]. BR, Jani. [1] https://patchwork.freedesktop.org/series/59022/ Jani Nikula (21): drm/i915: ensure more headers remain self-contained drm/i915: make intel_bios.h self-contained drm/i915/dvo: rename dvo.h to intel_dvo_dev.h and make

[Intel-gfx] [PATCH 13/21] drm/i915: extract intel_overlay.h from intel_drv.h and i915_drv.h

minimal further includes, using forward declarations as needed. Include the new header only where needed, and sort the modified include directives while at it and as needed. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2] drm/i915: extract intel_atomic.h from intel_drv.h

minimal further includes, using forward declarations as needed. Include the new header only where needed, and sort the modified include directives while at it and as needed. No functional changes. v2: fix sparse warnings on undeclared global functions Signed-off-by: Jani Nikula --- drivers/gpu/drm

[Intel-gfx] [PATCH v2] drm/i915: extract intel_hotplug.h from intel_drv.h and i915_drv.h

minimal further includes, using forward declarations as needed. Include the new header only where needed, and sort the modified include directives while at it and as needed. No functional changes. v2: fix sparse warnings on undeclared global functions Signed-off-by: Jani Nikula --- drivers/gpu/drm

Re: [Intel-gfx] [PATCH 19/21] drm/i915: move some leftovers to intel_pm.h from i915_drv.h

On Mon, 29 Apr 2019, Chris Wilson wrote: > Quoting Jani Nikula (2019-04-29 13:29:37) >> Commit 696173b064c6 ("drm/i915: extract intel_pm.h from intel_drv.h") >> missed the declarations in i915_drv.h. > > Fwiw, I want to pull these along with gt powermanagement and

Re: [Intel-gfx] [PATCH 2/3] drm/i915/icl: Add register definitions for Multi Segmented gamma

_PAL_PREC_MULTI_SEG_DATA_B) > + > /* pipe CSC & degamma/gamma LUTs on CHV */ > #define _CGM_PIPE_A_CSC_COEFF01 (VLV_DISPLAY_BASE + 0x67900) > #define _CGM_PIPE_A_CSC_COEFF23 (VLV_DISPLAY_BASE + 0x67904) -- Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915/csr: alpha_support doesn't depend on csr or vice versa

Debug logging should not be dependent on alpha support flag. Cc: Rodrigo Vivi Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_csr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c index f43c2a2563a5

Re: [Intel-gfx] [PATCH v2] drm/i915: Corrupt DSI picture fix for GeminiLake

IS_GEMINILAKE(dev_priv)) > + min_cdclk = max(158400, min_cdclk); > + > if (min_cdclk > dev_priv->max_cdclk_freq) { > DRM_DEBUG_KMS("required cdclk (%d kHz) exceeds max (%d kHz)\n", > min_cdclk, dev_priv->max_cdclk

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Use local variable for SSEU info in GETPARAM ioctl

915_PARAM_SLICE_MASK: > - value = RUNTIME_INFO(dev_priv)->sseu.slice_mask; > + value = sseu->slice_mask; > if (!value) > return -ENODEV; > break; > case I915_PARAM_SUBSLICE_MASK: > - value = RUNTIME_

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Move sseu helper functions to intel_sseu.h

void sseu_set_eus(struct sseu_dev_info *sseu, > - int slice, int subslice, u16 eu_mask) > -{ > - int i, offset = sseu_eu_idx(sseu, slice, subslice); > - > - for (i = 0; > - i < DIV_ROUND_UP(sseu->max_eus_per_subslice, BITS_PER_BYTE); i++) {

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Expand subslice mask

_ENA_SHIFT; > - sseu->max_slices = 3; > - sseu->max_subslices = 3; > - sseu->max_eus_per_subslice = 8; > + set_sseu_info(sseu, 3, 3, 8); > > /* >* The subslice disable field is global, i.e. it applies > @@ -464,18 +482,21 @@ static void broadwe

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Add N & CTS values for 10/12 bit deep color

ware for deep color modes. >> >> v2: Remove redundant code and make it generic.(Jani) >> >> Signed-off-by: Aditya Swarup >> Cc: Clint Taylor >> Cc: Ville Syrjälä >> Cc: Jani Nikula >> Cc: Manasi Navare >> --- >> drivers/gpu/drm/i915/intel

Re: [Intel-gfx] [v2 2/3] drm/i915: Fix pipe config mismatch for bpp, output format

s/gpu/drm/i915/vlv_dsi.c > index b4c6583..790ada8 100644 > --- a/drivers/gpu/drm/i915/vlv_dsi.c > +++ b/drivers/gpu/drm/i915/vlv_dsi.c > @@ -260,7 +260,7 @@ static void band_gap_reset(struct drm_i915_private > *dev_priv) > vlv_flisdsi_put(dev_priv); > } > > -stati

Re: [Intel-gfx] [PATCH 00/21] drm/i915: the great header refactoring, part two

On Tue, 30 Apr 2019, Chris Wilson wrote: > Quoting Jani Nikula (2019-04-29 13:29:18) >> Continue the header refactoring started in part one [1]. >> >> BR, >> Jani. >> >> [1] https://patchwork.freedesktop.org/series/59022/ >> >> >> Ja

[Intel-gfx] [PATCH] drm/i915: add single combo phy init/unit functions

Work on the principle that files should prefer not to expose platform specific functions. v2: Rebase Cc: Imre Deak Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_combo_phy.c | 24 drivers/gpu/drm/i915/intel_combo_phy.h | 6

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/icl: Factor out combo PHY lane power setup helper

conflicts with the header refactoring I pushed earlier, as well as the function name changes in [1]. I think I'd like the function here to be renamed accordingly. Other than that, for both, Reviewed-by: Jani Nikula [1] http://patchwork.freedesktop.org/patch/msgid/20190430124128.23606-1-jan

Re: [Intel-gfx] [v2 2/3] drm/i915: Fix pipe config mismatch for bpp, output format

patches to rename haswell_set_pipemisc to bdw_set_pipemisc. >> >> BR, >> Jani. >> >> >> > >> > /* vlv_dsi_pll.c */ >> > int vlv_dsi_pll_compute(struct intel_encoder *encoder, diff --git >> > a/drivers/gpu/drm/i915/vlv_dsi.c b/d

Re: [Intel-gfx] [PATCH v3] drm/i915: Corrupt DSI picture fix for GeminiLake

x(158400, min_cdclk); > + > if (min_cdclk > dev_priv->max_cdclk_freq) { > DRM_DEBUG_KMS("required cdclk (%d kHz) exceeds max (%d kHz)\n", > min_cdclk, dev_priv->max_cdclk_freq); -- Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] backlight: Avoid double fbcon backlight handling

ed/unblanked and do not require backlight trying > to do the same. Acked-by: Jani Nikula -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/guc: Consolidate firmware major-minor to one place

t; + guc_fw->guc_fw_minor_wanted = SKL_FW_MINOR; > } else if (IS_BROXTON(dev)) { > fw_path = I915_BXT_GUC_UCODE; > - guc_fw->guc_fw_major_wanted = 8; > - guc_fw->guc_fw_minor_wanted = 7; > +

[Intel-gfx] [PULL] drm-intel-fixes

- 5 files changed, 22 insertions(+), 22 deletions(-) -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v4 0/2] drm/i915/opregion: proper handling of DIDL and CADL

ls to cadl update are made. BR, Jani. > > Best regards > Rainer > > Am 30.06.2016 um 11:19 schrieb Rainer Koenig: >> Am 29.06.2016 um 17:36 schrieb Jani Nikula: >>> This is v4 of [1]. The first three have already been pushed to >>> drm-intel-next-queued. The

Re: [Intel-gfx] drm-intel.git Committers: Reminder about tagging bugfixes

read them in a while would be good to check them out > again, quite a few improvements and clarifications over the past few > months. > > Thanks, Daniel -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] tools/intel_reg: enable quiet option for mmio

goto builtin; > + This is just wrong. Why should *verbosity* matter in the selection of spec file? Why should verbosity potentially *change* the interpretation of a register name? BR, Jani. > path = config->specfile; > if (!path) > path = getenv("INTE

Re: [Intel-gfx] [PATCH 03/23] drm/i915: Move HAS_RUNTIME_PM definition to platform

= 1, > .display_mmio_offset = VLV_DISPLAY_BASE, > GEN_CHV_PIPEOFFSETS, > CURSOR_OFFSETS, > @@ -340,6 +344,7 @@ static const struct intel_device_info intel_broxton_info > = { > .has_ddi = 1, > .has_fpga_dbg = 1, > .has_fbc = 1, > + .has_

Re: [Intel-gfx] [PATCH 13/23] drm/i915: Introduce GEN5_FEATURES for device info

g_mask = RENDER_RING | BSD_RING, > - GEN_DEFAULT_PIPEOFFSETS, > - CURSOR_OFFSETS, > + Do not add superfluous empty lines. BR, Jani. > }; > > #define GEN6_FEATURES \ -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 00/23] drm/i915: Organize most GPU features by platform

; > drivers/gpu/drm/i915/i915_drv.h | 67 +- > drivers/gpu/drm/i915/i915_pci.c | 272 > +--- > 2 files changed, 206 insertions(+), 133 deletions(-) -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Accept symbolic link in firmware name

regressions policy for its users. The firmware has no such guarantees, and it is expected to go hand in hand with the operating system versions it has been validated against. And as I've explained numerous times, we do not have the resources to validate all kernel releases against all firmware

Re: [Intel-gfx] [drm-intel-nightly] 2016y-07m-14d-21h-13m-02s UTC: locking dependency: drm_modeset_lock_all() || __blocking_notifier_call_chain

On Fri, 15 Jul 2016, Sedat Dilek wrote: > Hi, > > I see the below call-trace with latest d-i-n, guess latest linux-next FWIW, "d-i-n" is ambiguous (drm-intel-next vs. drm-intel-nightly) and we don't use that ourselves. BR, Jani. > will cause same issues. > ( Beyond this, there exist also a bui

Re: [Intel-gfx] [Eaglelake][i915] pipe state doesn't match

[] worker_thread+0x47/0x4c0 > [ 11.571357] [] kthread+0xbd/0xe0 > [ 11.571360] [] ret_from_fork+0x22/0x40 > [ 11.572001] DWARF2 unwinder stuck at ret_from_fork+0x22/0x40 > [ 11.572001] Leftover inexact backtrace: > [ 11.572001] [] ? kthread_worker_fn+0x170/0x170 > [

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915/guc: symbolic names for GuC submission preferences

s_context = engine->last_context; > engine->last_context = request->ctx; > > - if (i915.enable_guc_submission) > + if (i915.enable_guc_submission != GUC_SUBMISSION_DISABLED) > i915_guc_submit(request); > else > execlists_context_queu

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915/guc: symbolic names for GuC submission preferences

On Mon, 01 Aug 2016, Dave Gordon wrote: > On 01/08/16 14:54, Jani Nikula wrote: >> On Fri, 22 Jul 2016, Dave Gordon wrote: >>> - } else if (i915.enable_guc_submission > 1) { >>> + } else if (i915.enable_guc_submission >= GUC_SUBMISSION_MANDATORY) { >>

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Consistent struct device naming

rting fixes, and so on? I'm firmly behind sticking with struct drm_i915_private *dev_priv and struct drm_device *dev. BR, Jani. > > Regards, Joonas > >> (struct i915_device is move apt now than drm_i915_private due to the >> subclassing) >> >> made more

Re: [Intel-gfx] [PATCH] drm/i915: set proper N/M in modeset

so", it makes me think the patch should probably be split to several patches. And that is certainly true here. -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] linux-firmware-i915 pull request (bxt dmc, kbl dmc)

_ver1.bin >  delete mode 100644 i915/skl_guc_ver1_1059.bin >  mode change 12 => 100644 i915/skl_guc_ver4.bin >  delete mode 100644 i915/skl_guc_ver4_3.bin Why are you deleting old versions? BR, Jani. > > Thanks, > Rodrigo. >

Re: [Intel-gfx] [PATCH 0197/1285] Replace numeric parameter like 0444 with macro

deset functionality; asynchronous mode is not >> yet supported. (default: false)."); >> >> /* WA to get away with the default setting in VBT for early platforms.Will >> be removed */ >> -module_param_named_unsafe(edp_vswing, i915.edp_vswing, int, 0400); >> +module_param_named_unsafe(edp_vswin

Re: [Intel-gfx] [PATCH] drm/i915: Fix iboost setting for SKL Y/U DP DDI buffer translation entry 2

011, 0x00CD, 0x3 }, > { 0x80009010, 0x000000C0, 0x3 }, > { 0x0018, 0x009D, 0x0 }, > { 0x80005012, 0x00C0, 0x3 }, -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 12/21] drm/i915: Move HAS_AUX_IRQ definition to platform definition

HV_PIPEOFFSETS, >> CURSOR_OFFSETS, >> @@ -357,6 +360,7 @@ static const struct intel_device_info intel_broxton_info >> = { >> .has_resource_streamer = 1, >> .has_rc6 = 1, >> .has_dp_mst = 1, >> +.has_aux_irq = 1, >> GEN_DEFAULT_PIPEOFFSETS, >> IVB_CURSOR_OFFSETS, >> BDW_COLORS, >> -- >> 1.9.1 >> >> ___ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [drm-intel-nightly] 2016y-07m-14d-21h-13m-02s UTC: locking dependency: drm_modeset_lock_all() || __blocking_notifier_call_chain

On Tue, 02 Aug 2016, Sedat Dilek wrote: > On Mon, Aug 1, 2016 at 3:33 PM, Jani Nikula > wrote: >> On Fri, 15 Jul 2016, Sedat Dilek wrote: >>> Hi, >>> >>> I see the below call-trace with latest d-i-n, guess latest linux-next >> >> FWIW, "d

Re: [Intel-gfx] linux-firmware-i915 pull request (bxt dmc, kbl dmc)

On Wed, 03 Aug 2016, Ben Hutchings wrote: > [ Unknown signature status ] > On Tue, 2016-08-02 at 20:48 +, Vivi, Rodrigo wrote: >> On Tue, 2016-08-02 at 14:04 +0300, Jani Nikula wrote: > [...] >> > Why are you deleting old versions? >> >> Mainly to keep it

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Accept symbolic link in firmware name

guarantees, and it is expected to go >> hand in hand with the operating system versions it has been validated >> against. And as I've explained numerous times, we do not have the resources >> to validate all kernel releases against all firmware releases. >> >>

Re: [Intel-gfx] [PATCH v2] drm/i915/fbc: FBC causes display flicker when VT-d is enabled on Skylake

se; > fbc->work.scheduled = false; > > + if (need_fbc_wa(dev_priv)) > + mkwrite_device_info(dev_priv)->has_fbc = false; > + > i915.enable_fbc = intel_sanitize_fbc_option(dev_priv); > DRM_DEBUG_KMS("Sanitized enable_fbc value: %d\n", i915.enable_fbc); -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Enable fine-grained kcov instrumentation

efile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -3,6 +3,7 @@ > # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > > subdir-ccflags-$(CONFIG_DRM_I915_WERROR) := -Werror > +subdir-ccflags-$(CONFIG_DRM_I915_KCOV) := $(CFLAGS_KCOV) >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use drm_crtc_vblank_wait_one_vblank instead the legacy one.

ev_priv->pipe_to_crtc_mapping[pipe]) everywhere else. BR, Jani. > } > static inline void > intel_wait_for_vblank_if_active(struct drm_device *dev, int pipe) -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 4/4] drm/i915/dp: Dump DP link status when link training stages fails

ay that allows the early patches to be merged even when the review rounds are still in progress on the later patches. Crucial fixes first (so they can be backported without conflicts), trivial and non-controversial things next, and so on. You'll have a feeling of making progress, you'll have fe

Re: [Intel-gfx] [PATCH] backlight: Avoid double fbcon backlight handling

;> [ 18.984334] [] fbcon_event_notify+0x658/0x750 >> [ 18.984336] [] notifier_call_chain+0x3e/0xb0 >> [ 18.984338] [] __blocking_notifier_call_chain+0x4d/0x70 >> [ 18.984340] [] blocking_notifier_call_chain+0x16/0x20 >> [ 18.984342] [] fb_notifier_call_chain+

Re: [Intel-gfx] [PATCH] drm: Paper over locking inversion after registration rework

ev) > struct drm_connector *connector; > int ret; > > - mutex_lock(&dev->mode_config.mutex); > - > - drm_for_each_connector(connector, dev) { > + /* FIXME: taking the mode config mutex ends up in a clash with > + * fbcon/backlight registration */ > + list_for_each_entry(connector, &dev->mode_config.connector_list, head) { > ret = drm_connector_register(connector); > if (ret) > goto err; > } > > - mutex_unlock(&dev->mode_config.mutex); > - > return 0; > > err: -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm: Paper over locking inversion after registration rework

ated. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v3] drm/i915/gen9: Update i915_drpc_info debugfs for coarse pg & forcewake info

merged. > Fret not, however, I've got a few patches that'll clean this up :) David means INTEL_GEN(), not IS_GEN(). ;) BR, Jani. > > > Regards, David Weinehall > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH i-g-t 1/3] tools/intel_reg: Don't reuse stale decoded results for later registers

r->reg, > + val, devid) == 0) > + continue; > + } else if (devid) { > return 0; > - else > + } else { >

Re: [Intel-gfx] [PULL] drm-intel-next

t; > drivers/gpu/drm/i915/intel_tv.c| 718 >> > > + >> > > drivers/gpu/drm/i915/intel_workarounds.c | 70 +- >> > > drivers/gpu/drm/i915/selftests/i915_gem_evict.c

[Intel-gfx] Fixes that failed to apply to v5.0-rc5

ltage Swing programming") 32db0b6501d9 ("drm/i915: Don't try to use the hardware frame counter with i965gm TV output") Cherry-pick fine but fail to build: 7bed8adcd9f8 ("drm/i915: Try to sanitize bogus DPLL state left over by broken SNB BIOSen") BR, Jani. -- Jani

Re: [Intel-gfx] [PATCH -fixes] drm/i915: Try to sanitize bogus DPLL state left over by broken SNB BIOSen

e(encoder, crtc_state, > + connector->base.state); > if (encoder->post_disable) > - encoder->post_disable(encoder, > to_intel_crtc_state(crtc_state), connector->base.state); > + encoder->post_disable(encoder, crtc_state, > + connector->base.state); > + > + connector->base.state->best_encoder = best_encoder; > } > encoder->base.crtc = NULL; -- Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] Fixes that failed to apply to v5.0-rc5

On Tue, 05 Feb 2019, Ville Syrjälä wrote: > On Tue, Feb 05, 2019 at 03:42:05PM +0200, Jani Nikula wrote: >> >> The following commits have been marked as Cc: stable or fixing something >> in v5.0-rc5 or earlier, but failed to cherry-pick to >> drm-intel-fixes. P

[Intel-gfx] [PULL] drm-intel-fixes

DPLL state left over by broken SNB BIOSen drivers/gpu/drm/i915/intel_ddi.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 50 +++- drivers/gpu/drm/i915/intel_sprite.c | 2 +- 3 files changed, 46 insertions(+), 8 deletions(-) -- Jani Nikula, Intel Open

[Intel-gfx] [PATCH 2/3] drm/i915/opregion: rvda is relative from opregion base in opregion 2.1+

machines relying on absolute RVDA in the wild. Fixes: 04ebaadb9f2d ("drm/i915/opregion: handle VBT sizes bigger than 6 KB") Cc: Ville Syrjälä Cc: Imre Deak Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_opregion.c | 24 +--- 1 file changed, 21

[Intel-gfx] [PATCH 1/3] drm/i915/opregion: fix version check

The u32 version field encodes major version in the high word. We've been checking for version >= 0.2. Add opregion version logging while at it. Fixes: 04ebaadb9f2d ("drm/i915/opregion: handle VBT sizes bigger than 6 KB") Cc: Ville Syrjälä Cc: Imre Deak Signed-off-by: Jani Ni

[Intel-gfx] [PATCH 3/3] HACK: drm/i915/opregion: ICL should have opregion 2.1+ and relative rvda

Temporary CI workaround before proper opregion version bump propagates to the machines. Cc: Ville Syrjälä Cc: Imre Deak Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_opregion.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 1/3] drm/i915/opregion: fix version check

On Fri, 08 Feb 2019, Jani Nikula wrote: > The u32 version field encodes major version in the high word. We've been > checking for version >= 0.2. > > Add opregion version logging while at it. > > Fixes: 04ebaadb9f2d ("drm/i915/opregion: handle VBT sizes bigger

Re: [Intel-gfx] [PATCH 1/3] drm/i915/opregion: fix version check

On Fri, 08 Feb 2019, Ville Syrjälä wrote: > On Fri, Feb 08, 2019 at 02:43:30PM +0200, Jani Nikula wrote: >> The u32 version field encodes major version in the high word. We've been >> checking for version >= 0.2. >> >> Add opregion version logging while at i

Re: [Intel-gfx] [PATCH 1/3] drm/i915/opregion: fix version check

On Fri, 08 Feb 2019, Ville Syrjälä wrote: > On Fri, Feb 08, 2019 at 05:57:53PM +0200, Ville Syrjälä wrote: >> On Fri, Feb 08, 2019 at 05:09:51PM +0200, Jani Nikula wrote: >> > On Fri, 08 Feb 2019, Jani Nikula wrote: >> > > The u32 version field encodes major versio

Re: [Intel-gfx] [PATCH 1/3] drm/i915/opregion: fix version check

On Fri, 08 Feb 2019, Jani Nikula wrote: > On Fri, 08 Feb 2019, Ville Syrjälä wrote: >> On Fri, Feb 08, 2019 at 05:57:53PM +0200, Ville Syrjälä wrote: >>> On Fri, Feb 08, 2019 at 05:09:51PM +0200, Jani Nikula wrote: >>> > On Fri, 08 Feb 2019, Jani Nikula wrote:

[Intel-gfx] [PATCH v3 1/3] drm/i915/opregion: fix version check

uot;) Cc: Ville Syrjälä Cc: Imre Deak Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_opregion.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c index 30ae96c5c97c..f1b8415805

[Intel-gfx] [PATCH v3 3/3] HACK: drm/i915/opregion: ICL should have opregion 2.1+ and relative rvda

Temporary CI workaround before proper opregion version bump propagates to the machines. v2: Rebase Cc: Ville Syrjälä Cc: Imre Deak Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_opregion.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v3 2/3] drm/i915/opregion: rvda is relative from opregion base in opregion 2.1+

machines relying on absolute RVDA in the wild. v3: Fix the version checks Fixes: 04ebaadb9f2d ("drm/i915/opregion: handle VBT sizes bigger than 6 KB") Cc: Ville Syrjälä Cc: Imre Deak Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_opregion.c | 24 +-

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/opregion: rvda is relative from opregion base in opregion 2.1+

On Fri, 08 Feb 2019, Ville Syrjälä wrote: > On Fri, Feb 08, 2019 at 08:42:53PM +0200, Jani Nikula wrote: >> Starting from opregion version 2.1 (roughly corresponding to ICL+) the >> RVDA field is relative from the beginning of opregion, not absolute >> address. >> >

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/opregion: rvda is relative from opregion base in opregion 2.1+

On Fri, 08 Feb 2019, Ville Syrjälä wrote: > On Fri, Feb 08, 2019 at 09:00:59PM +0200, Jani Nikula wrote: >> On Fri, 08 Feb 2019, Ville Syrjälä wrote: >> > On Fri, Feb 08, 2019 at 08:42:53PM +0200, Jani Nikula wrote: >> >> Starting from opregion version 2.1 (roug

[Intel-gfx] [PULL] drm-intel-fixes

--- Aditya Swarup (1): drm/i915/cnl: Fix CNL macros for Voltage Swing programming Clint Taylor (1): drm/i915/icl: combo port vswing programming changes per BSPEC Jani Nikula (2): drm/i915/opregion: fix version check drm/i915/opregion: rvda is relative from opregion base in op

Re: [Intel-gfx] [PATCH 0/3] Make DRM DSC helpers more generally usable

g function > to operate only on the packing struct, to allow for drivers with > their own SDP struct headers Acked-by: Jani Nikula as long as you've ironed out the details with Manasi's review. Also okay to merge via drm-misc. Ideally, please rebase on drm-tip and continue t

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make MG phy macros semantically consistent

>> > >> > Cc: Clint Taylor >> > Cc: Imre Deak >> > Cc: Jani Nikula >> > Signed-off-by: Aditya Swarup >> >> Also please add Fixes tag with SHA of the original patch that >> adds these macros. > > but this doesn't fix a bu

Re: [Intel-gfx] [RFC PATCH 03/42] drm/i915: buddy allocator

} > + > + list_add(&block->link, &blocks); > + > + if (i915_gem_buddy_block_order(block) != order) { > + pr_err("buddy_alloc order mismatch\n"); > + err = -EINVAL; > +

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: Preliminary support for DP YCbCr4:2:0 outputs

^ > > total: 0 errors, 0 warnings, 2 checks, 119 lines checked > > _______ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open

Re: [Intel-gfx] [RFC PATCH 03/42] drm/i915: buddy allocator

On Fri, 15 Feb 2019, Chris Wilson wrote: > Quoting Jani Nikula (2019-02-15 12:34:02) >> Please replace the above with >> >> // SPDX-License-Identifier: MIT >> /* >> * Copyright © 2019 Intel Corporation >> */ >> >> Ditto for all new files bei

[Intel-gfx] [PULL] drm-intel-fixes

Chris Wilson (1): drm/i915/fbdev: Actually configure untiled displays drivers/gpu/drm/i915/intel_fbdev.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH v2 1/2] drm: move i915_kick_out_vgacon to drm_fb_helper

unregistered". */ > - if (ret == -ENODEV) > - ret = 0; > - } > - console_unlock(); > - > - return ret; > -} > -#endif > - > static void intel_init_dpio(struct drm_i915_private *dev_priv) > { > /* > @@ -1420,7 +1387,7 @

Re: [Intel-gfx] [PATCH v2 1/2] drm: move i915_kick_out_vgacon to drm_fb_helper

On Thu, 21 Feb 2019, Gerd Hoffmann wrote: > On Thu, Feb 21, 2019 at 03:08:39PM +0200, Jani Nikula wrote: >> On Thu, 21 Feb 2019, Gerd Hoffmann wrote: >> > It'll be useful for other drivers too, so move it to drm_fb_helper.c >> > (and rename it of course). Also a

Re: [Intel-gfx] [PATCH] drm/i915: Call MG_DP_MODE() macro with the right parameters order

t; Reviewed-by: Lucas De Marchi Thanks for the patch and review, pushed. BR, Jani. > > thanks > Lucas De Marchi > >> Cc: Clint Taylor >> Cc: Imre Deak >> Cc: Jani Nikula >> Cc: Aditya Swarup >> Cc: Manasi navare >> Cc: Jani Nikula >> Si

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add support for retrying hotplug

org/patch/msgid/20180925071836.24711-1-jani.nik...@intel.com BR, Jani. > > Cc: Ville Syrjälä > Signed-off-by: José Roberto de Souza > Signed-off-by: Jani Nikula > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/i915_debugfs.c | 2 +- > drivers/gpu/drm/i915/i91

Re: [Intel-gfx] [PATCH] drm/i915: Sort ctx workarounds init from newer to older platforms.

kbl_ctx_workarounds_init(engine); >> > + else if (IS_BROXTON(i915)) >> > + bxt_ctx_workarounds_init(engine); >> > + else if (IS_SKYLAKE(i915)) >> > + skl_ctx_workarounds_init(engine); >> > + else if (IS_CHERRYVIEW(i915)) >> > + chv_

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Generalize pci quirks

> > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_drv.h| 9 + > drivers/gpu/drm/i915/intel_quirks.c | 28 +++- > 2 files changed, 24 insertions(+), 13 deletions(-) > > diff --git a/drivers

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use intel_apply_pci_quirks() to apply ILK+ wm quirks

pm.c > @@ -3059,10 +3059,17 @@ static void ilk_wm_disable_lp1_quirk(struct > drm_i915_private *dev_priv) > ilk_wm_disable_quirk(dev_priv, 1); > } > > +static const struct intel_pci_quirk ilk_wm_quirks[] = { Mmmh, ilk prefix, do you propose to add separate quirk arrays f

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Restrict SNB LP3+ disable to Thinkpad X220 tablet

_priv) > } > > static const struct intel_pci_quirk ilk_wm_quirks[] = { > + /* > + * Lenovo ThinkPad X220 Tablet (snb) > + * CPU doesn't wake up for vblank interrupts with LP3. > + */ > + { 0x0126, 0x17aa, 0x21db, ilk_wm_disable_lp3 }, The ilk nami

<    9   10   11   12   13   14   15   16   17   18   >