e: the outstanding DRM_AUTH instances are:
> - legacy DRI1 ioctls, which are already neutered
> - modern but deprecated ioctls
>
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: intel-gfx@lists.freedesktop.org
> Cc: David Airlie
> Cc: Daniel Vett
On Fri, 24 May 2019, Chris Wilson wrote:
> Quoting Jani Nikula (2019-05-24 19:52:53)
>> REG_BIT() and REG_GENMASK() were intended to work with both constant
>> expressions and otherwise, with the former having extra compile time
>> checks for the bit ranges. Incr
rate 30 --set "max bpc" 8
>
> Signed-off-by: Clinton Taylor
> Signed-off-by: Aditya Swarup
> Cc: Ville Syrjälä
> Cc: Jani Nikula
> Cc: Manasi Navare
> ---
> Fixes changing modes from 8 bit to 10/12 bit deep color.
>
> drivers/gpu/drm/i915/intel_hdmi
r
> Cc: Ville Syrjälä
> Cc: Jani Nikula
> Cc: Manasi Navare
> ---
> drivers/gpu/drm/i915/intel_audio.c | 80 +++---
> 1 file changed, 74 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c
> b/drivers/gpu/drm/i915
WpftLhnxw@mail.gmail.com
[2] Documentation/kbuild/kconfig-language.txt "In general use select
only for non-visible symbols (no prompts anywhere) and for symbols
with no dependencies."
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Cc: Chris Wilson
Cc: Tvrtko Ursulin
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile | 16 +-
drivers/gpu/drm/i915/Makefile.header-test | 21 +++
.../i915/test_i915_active_types_standalone.c | 7 ---
.../test_i915_gem_co
On Wed, 03 Apr 2019, Chris Wilson wrote:
> From: Jani Nikula
>
> The below commits added dummy files to test that certain headers are
> self-contained, i.e. compilable as standalone units:
>
> 39e2f501c1b4 ("drm/i915: Split struct intel_context definition to its own
&g
.
v2 by Chris:
- Use patsubst
- Add .gitignore
- Add clean-files for generated dummy sources
v3 by Jani:
- Fix make clean
- Add the tests to i915-y instead of extra-y
Cc: Chris Wilson
Cc: Tvrtko Ursulin
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/.gitignore | 1 +
.
v2 by Chris:
- Use patsubst
- Add .gitignore
- Add clean-files for generated dummy sources
v3 by Jani:
- Fix make clean
- Add the tests to i915-y instead of extra-y
v4 by Jani:
- quiet_cmd whitespace fix
Cc: Chris Wilson
Cc: Tvrtko Ursulin
Reviewed-by: Chris Wilson
Signed-off-by: Jani Nik
On Wed, 03 Apr 2019, Chris Wilson wrote:
> Quoting Jani Nikula (2019-04-03 14:32:36)
>> The below commits added dummy files to test that certain headers are
>> self-contained, i.e. compilable as standalone units:
>>
>> 39e2f501c1b4 ("drm/i915: Split struct int
> > used to be. The panic is entirely correct, we should not be
>> > > > unloading
>> > > > the module before those dangling pointers have been made safe.
>> > > >
>> > > > This is papering over the symptom.
do#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
>
>
> Participating hosts (10 -> 9)
> --
>
> Missing(1): shard-hsw
>
>
> Build changes
> -
>
> * Linux: CI_DRM_5863 -> Patchwork_12674
>
> CI
ing the structure to begin with.
BR,
Jani.
Jani Nikula (25):
drm/i915: make intel_frontbuffer.h self-contained
drm/i915: extract intel_audio.h from intel_drv.h
drm/i915: extract intel_crt.h from intel_drv.h
drm/i915: extract intel_ddi.h from intel_drv.h
drm/i915: extract intel_connecto
This will be helpful in the follow-up work. No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915/i915_drv.h | 11 ++-
drivers/gpu/drm/i915/intel_frontbuffer.h | 10 ++
3 files changed, 13
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
this adds one "unnecessary" if ladder within
the entry points. However it should be considered more of a CDCLK
implementation detail how this is done per platform, instead of exposing
the fact. In other words, abstract the CDCLK module better.
No functional changes.
Signed-off-
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
On Fri, 05 Apr 2019, Jani Nikula wrote:
> It used to be handy that we only had a couple of headers, but over time
> intel_drv.h has become unwieldy. Extract declarations to a separate
> header file corresponding to the implementation module, clarifying the
> modul
ide by zero */
> - if (!pipe_bpp) {
> - DRM_ERROR("Invalid BPP(0)\n");
> - return 0;
> - }
> + int bpp = mipi_dsi_pixel_format_to_bpp(intel_dsi->pixel_format);
>
> config->dsi_pll.ctrl = I915_READ(BXT_DSI_PLL_CTL);
>
t;
Cc: Dave Airlie
Cc: intel-gfx@lists.freedesktop.org
Cc: # v5.0+
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dp.c | 67 +
1 file changed, 9 insertions(+), 58 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp
On Fri, 05 Apr 2019, Jani Nikula wrote:
> Commit 7769db588384 ("drm/i915/dp: optimize eDP 1.4+ link config fast
> and narrow") started to optize the eDP 1.4+ link config, both per spec
> and as preparation for display stream compression support.
>
> Sadly, we again face
re
Cc: Rodrigo Vivi
Cc: Matt Atwood
Cc: "Lee, Shawn C"
Cc: Dave Airlie
Cc: intel-gfx@lists.freedesktop.org
Cc: # v5.0+
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dp.c | 69 +
1 file changed, 10 insertions(+), 59 deletions(-)
dif
This will be helpful in the follow-up work. No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915/i915_drv.h | 11 ++-
drivers/gpu/drm/i915
anges.
BR,
Jani.
[1] https://patchwork.freedesktop.org/series/59022/
Jani Nikula (25):
drm/i915: make intel_frontbuffer.h self-contained
drm/i915: extract intel_audio.h from intel_drv.h
drm/i915: extract intel_crt.h from intel_drv.h
drm/i915: extract intel_ddi.h from intel_drv.h
drm/i91
Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915/i915_drv.c | 1 +
drivers/gpu/drm/i915/intel_csr.c | 3 +++
drivers/gpu/drm/i915/intel_csr.h | 17 +
drivers/gpu/drm/i915/intel_drv.h
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915/i915_debugfs.c| 8 +++--
drivers/gpu/drm/i915/i915_reset.h | 1 +
drivers/gpu/drm/i915/i915_suspend.c| 4 ++-
drivers/gpu/drm/i915/intel_display.c | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915/i915_debugfs.c | 1 +
drivers/gpu/drm/i915/i915_drv.c | 1 +
drivers/gpu/drm/i915/i915_gem.c | 1 +
drivers/gpu/drm/i915/i915_request.c | 3 +-
drivers
-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915/i915_debugfs.c | 1 +
drivers/gpu/drm/i915/i915_irq.c | 11 ---
drivers/gpu/drm/i915/intel_ddi.c | 1 +
drivers/gpu/drm/i915/intel_display.c | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
ilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_cdclk.c | 120 ++--
drivers/gpu/drm/i915/intel_cdclk.h | 10 +-
drivers/gpu/drm/i915/intel_runtime_pm.c | 16 ++--
3 files changed, 58 insertions(+), 88 deletions(-)
diff
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915/intel_atomic_plane.c | 1 +
drivers/gpu/drm/i915/intel_atomic_plane.h | 40 +++
drivers/gpu/drm/i915/intel_display.c | 1 +
drivers/gpu/drm
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Reviewed-by: Chris Wilson
Acked-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
vate_flags |=
>> I915_MODE_FLAG_GET_SCANLINE_FROM_TIMESTAMP;
>> --
>> 2.19.2
>>
>> ___
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, 05 Apr 2019, Jani Nikula wrote:
> v2 of [1] with:
>
> - each foo.c now includes the corresponding new foo.h to avoid sparse warnings
>
> - minor sparse/checkpatch/whitespace fixes
>
> - commit message tab screwup fixed
>
> I didn't add changelog to each p
y, and is there a way to backport it to kernel 3.10.61?
Perhaps you're looking for the I915_SET_SPRITE_COLORKEY ioctl?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, 05 Apr 2019, Rodrigo Vivi wrote:
> On Fri, Apr 05, 2019 at 10:52:20AM +0300, Jani Nikula wrote:
>> Commit 7769db588384 ("drm/i915/dp: optimize eDP 1.4+ link config fast
>> and narrow") started to optize the eDP 1.4+ link config, both per spec
>> and as
s/gpu/drm/arm/Kconfig |1 -
> drivers/gpu/drm/exynos/Kconfig |2 --
> drivers/gpu/drm/i915/Kconfig|3 ---
> drivers/gpu/drm/i915/Kconfig.debug | 13 -
For i915,
Acked-by: Jani Nikula
and can be merged through whichever tree you like.
>
-by: Emanuele Panigati # v5.0 backport
Tested-by: Matteo Iervasi # v5.0 backport
Signed-off-by: Jani Nikula
Link:
https://patchwork.freedesktop.org/patch/msgid/20190405075220.9815-1-jani.nik...@intel.com
(cherry picked from commit f11cb1c19ad0563b3c1ea5eb16a6bac0e401f428)
Signed-off-by: Rodrigo V
: 39564ae86d51 ("drm/i915/ehl: Inherit Ice Lake conditional code")
Cc: José Roberto de Souza
Cc: Lucas De Marchi
Cc: Bob Paauwe
Cc: Rodrigo Vivi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_cdclk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/driv
Also removing BDW_EDP_PSR_BASE from GVT because it is not used as
> the only PSR register that GVT have is this one(SRD/PSR_CTL).
>
> Cc: Dhinakaran Pandiyan
> Cc: Rodrigo Vivi
> Cc: Jani Nikula
> Cc: Ville Syrjälä
> Signed-off-by: José Roberto de Souza
> ---
> dri
-13,5 +13,6 @@
> int intel_color_check(struct intel_crtc_state *crtc_state);
> void intel_color_commit(const struct intel_crtc_state *crtc_state);
> void intel_color_load_luts(const struct intel_crtc_state *crtc_state);
> +void intel_get_color_config(struct intel_crtc_state *crtc_sta
pipe_config->csc_enable = true;
> } else {
> i9xx_get_pipe_color_config(pipe_config);
> + intel_get_color_config(pipe_config);
> }
>
> power_domain = POWER_DOMAIN_PIPE_PANEL_FITTER(crtc->pipe);
--
Jani Nikula, Intel Open Source Graphics C
"hw_state doesn't match sw_state\n"); \
> + ret = false; \
> + } \
> +} while (0)
> +
> #define PIPE_CONF_QUIRK(quirk) \
> ((current_config->quirks | pipe_config->quirks) & (quirk))
>
> @@ -12379,6 +12387,8 @@ st
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile| 1 +
drivers/gpu/drm/i915/intel_display.c | 474 +--
drivers/gpu/drm/i915/intel_drv.h | 12 +
drivers/gpu/drm/i915/intel_verify.c | 464 ++
drivers/gpu/drm/i915
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_display.c | 471 +--
drivers/gpu/drm/i915/intel_drv.h | 9 +-
drivers/gpu/drm/i915/intel_verify.c | 465 ++
drivers/gpu/drm/i915/intel_verify.h | 8 +
4 files changed, 478
m_i915_private *dev_priv = to_i915(crtc->base.dev);
> @@ -1248,6 +1298,7 @@ void intel_color_init(struct intel_crtc *crtc)
> dev_priv->display.color_check = i9xx_color_check;
> dev_priv->display.color_commit = i9xx_color_commit;
>
On Tue, 16 Apr 2019, Jani Nikula wrote:
> On Mon, 15 Apr 2019, Swati Sharma wrote:
>> Signed-off-by: Swati Sharma
>> ---
>> drivers/gpu/drm/i915/i915_reg.h| 3 +++
>> drivers/gpu/drm/i915/intel_color.c | 51
>> ++
&
e_bpp based on bw_constrained flag.
>
> v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
>
> v6: Fix comment formatting (Ville)
>
> v7: Add reviewed by Ville
>
> Signed-off-by: Clinton Taylor
> Signed-off-by: Aditya Swarup
> Cc: Ville S
intel_dsi->dual_link) {
>> > + hsync_start *= 2;
>> > + hsync_end *= 2;
>> > + }
>> > + }
>>
>> This looks like a hand rolled intel_get_pipe_timings() with an extra twist.
>> I would
>>
nt gen11_dsi_compute_config(struct intel_encoder *encoder,
> @@ -1253,6 +1280,7 @@ static int gen11_dsi_compute_config(struct
> intel_encoder *encoder,
> struct drm_display_mode *adjusted_mode =
> &pipe_config->base.adjusted_mode;
>
> + pipe_config->ou
; gen11_dsi_get_timings(encoder, pipe_config);
> pipe_config->output_types |= BIT(INTEL_OUTPUT_DSI);
> pipe_config->pipe_bpp = mipi_dsi_pixel_format_to_bpp
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Wed, 17 Apr 2019, "Souza, Jose" wrote:
> On Tue, 2019-04-16 at 11:28 +0300, Jani Nikula wrote:
>> The cdclk init/uninit code was changed by commit 93a643f29bcb
>> ("drm/i915/cdclk: have only one init/uninit function") between the
>> versions of commit
atus)
> + if (old_status != connector->status ||
> + connector->status == connector_status_connected)
> changed = true;
> }
> drm_connector_list_iter_end(&conn_iter);
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
I'll want two things:
* Explicit ack from Rodrigo too
* The dependencies merged first, and this one posted as a single
patch. I really want this to stand out better, instead of semi-hidden
in the middle of a 30+ patch series.
Acked-by: Jani Nikula
On Tue, 23 Apr 2019, Joonas Lah
ther (and split out the submission
> code from the ringbuffer and logical context handling). This patch aims
> to be simple motion so git can fixup inflight patches with little mess.
>
> Signed-off-by: Chris Wilson
> Acked-by: Joonas Lahtinen
> Acked-by: Jani Nikula
> A
gs) were actually undefined in the spec and didn't make much
> sense either.
Only PWR_DOWN_LN_1 is undefined in the spec.
>
> Cc: Jani Nikula
> Cc: Madhav Chauhan
> Cc: Ville Syrjala
> Signed-off-by: Imre Deak
> ---
> drivers/gpu/drm/i915/i915_drv.h| 3 +++
>
On Thu, 25 Apr 2019, Chris Wilson wrote:
> Having removed the urge to modify the engine_mask at runtime, we can
> promote the num_engines from a runtime calculation to a static and push
> it into the device_info tables.
\o/
Acked-by: Jani Nikula
>
> Signed-off-by: Chr
_color_config()
> [v4] drm/i915: Extract ivb_get_color_config()
> [v4] drm/i915: Extract ilk_get_color_config()
> [v4] drm/i915: Add intel_color_lut_equal() to compare hw and sw gamma
> lut values
>
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/
quirk))
>
> @@ -12379,6 +12387,8 @@ static bool fastboot_enabled(struct drm_i915_private
> *dev_priv)
> PIPE_CONF_CHECK_INFOFRAME(spd);
> PIPE_CONF_CHECK_INFOFRAME(hdmi);
>
> + PIPE_CONF_CHECK_COLOR_LUT(base.gamma_lut, pipe_config->gamma_mode);
> +
Hmm, we check gamma_mode and gamma_enable within if (!adjust), I suppose
this should be there too.
> #undef PIPE_CONF_CHECK_X
> #undef PIPE_CONF_CHECK_I
> #undef PIPE_CONF_CHECK_BOOL
Please add
#undef PIPE_CONF_CHECK_COLOR_LUT
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
dalone
instead of hidden in a series, explicit acks.
Provided the split makes sense to Joonas,
Acked-by: Jani Nikula
> i915-y += \
> i915_active.o \
> i915_cmd_parser.o \
> diff --git a/drivers/gpu/drm/i915/gem/Makefile
> b/drivers/gpu/drm/i915/gem/Makefile
>
hdmi_deep_color_possible,
> to not set 12 bit deep color for every modeset. This fixes the issue
> where 12 bit color was selected even when user selected 10 bit.(Ville)
>
> Co-Developed-by: Aditya Swarup
> Co-Developed-by: Ville Syrjälä
> Signed-off-by: Clinton Taylor
>
Add more headers to the header test list:
* i915_drv.h
* i915_params.h
* i915_reg.h
* intel_drv.h
* intel_uncore.h
Happily they already are self-contained, but keep them that way.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 5 +
1 file changed, 5 insertions
Keep the header self-contained. It'll need rework of its own in the
future, but gotta start somewhere.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915/intel_drv.h | 5 -
drivers/gpu/drm/i915/intel_dsi.h | 4
3
1201 - 1300 of 18224 matches
Mail list logo
