Now that intel_lvds_init() is only called for platforms that might have
LVDS, move the remaining checks to intel_setup_outputs(), again similar
to other outputs, and remove the overlapping checks.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_display.c
Gen 2 mobile and not I830 is, in fact, I85X. Simplify.
Suggested-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915
Clarify that the name is specific to ILK+ PCH platforms.
v2: prefix the name with ilk rather than pch (Ville)
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b
r the uninitiated to figure out which
platforms actually have what.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_display.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/driver
On Mon, 21 Jan 2019, Ville Syrjälä wrote:
> On Mon, Jan 21, 2019 at 04:21:33PM +0200, Jani Nikula wrote:
>> With most platforms not having TV support, only call intel_tv_init() on
>> platforms that might actually have TV, specifically gens 3 and 4.
>>
>> This puts i
On Mon, 21 Jan 2019, Ville Syrjälä wrote:
> On Mon, Jan 21, 2019 at 04:21:30PM +0200, Jani Nikula wrote:
>> With new platforms not having CRT support and most conditions in
>> intel_crt_present() being specific to DDI, split out the CRT
>> initialization to platform spec
On Mon, 21 Jan 2019, Ville Syrjälä wrote:
> On Mon, Jan 21, 2019 at 01:27:58PM +0200, Jani Nikula wrote:
>> We have a wrapper for a reason.
>>
>> Signed-off-by: Jani Nikula
>
> Reviewed-by: Ville Syrjälä
Thanks, pushed to drm-misc-next.
BR,
Jani.
>
>> ---
else if (dev_priv->vbt.psr.tp2_tp3_wakeup_time_us <= 500)
> + else if (dev_priv->vbt.psr.tp2_tp3_tp4_wakeup_time_us <= 500)
> val |= EDP_PSR2_TP2_TIME_500us;
> else
> val |= EDP_PSR2_TP2_TIME_2500us;
> d
gt; + val |= dev_priv->vbt.psr.tp2_tp3_tp4_wakeup_time <<
> EDP_PSR_TP2_TP3_TIME_SHIFT;
>
> if (intel_dp_source_supports_hbr2(intel_dp) &&
> drm_dp_tps3_supported(intel_dp->dpcd))
> @@ -509,15 +494,7 @@ static void hs
vers/gpu/drm/i915/intel_vbt_defs.h
> b/drivers/gpu/drm/i915/intel_vbt_defs.h
> index 4ed66efde49f..dc0a14977953 100644
> --- a/drivers/gpu/drm/i915/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/intel_vbt_defs.h
> @@ -772,6 +772,9 @@ struct psr_tab
otal_width == 0 ?
> + 0 : ddb_size * width_before_pipe / total_width;
> + alloc->end = total_width == 0 ?
> + 0 : ddb_size * (width_before_pipe + pipe_width) / total_width;
> }
>
> static unsigned int sk
c: Basil Eric Rabi
> Cc: Hans de Goede
> Cc: Ville Syrjälä
> Reported-by: Ville Syrjälä
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/icl_dsi.c | 1 +
> drivers/gpu/drm/i915/intel_ddi.c | 2 ++
> drivers/gpu/drm
bugs.freedesktop.org/show_bug.cgi?id=108225
> Cc: Basil Eric Rabi
> Cc: Hans de Goede
> Cc: Tolga Cakir
> Cc: Ville Syrjälä
> Tested-by: Tolga Cakir
> Cc: Jani Nikula
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/intel_panel.c | 26 ++
;&
> - intel_pipe_config_compare(dev_priv,
> + if (intel_pipe_config_compare(dev_priv,
> to_intel_crtc_state(old_crtc_state),
> pipe_config, true)) {
> crtc_state->mode_changed = false;
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
dth;
>
> Can't happen.
Yeah, it's about stfu the checker...
>
>> }
>>
>> static unsigned int skl_cursor_allocation(int num_active)
>> --
>> 2.17.1
>>
>> ___
>> Intel-gfx mailing li
On Mon, 21 Jan 2019, Jani Nikula wrote:
> On Fri, 18 Jan 2019, Jani Nikula wrote:
>> Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
>>
>> sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
>>
>> v2: rebase
>>
>&
j = 0; /* not valid C */
case 0:
/* ... */
}
but can have e.g.:
switch (i) {
case 0:
{
int j = 0;
/* ... */
}
}
I think Kees' approach of moving such variable d
On Wed, 23 Jan 2019, Jani Nikula wrote:
> On Wed, 23 Jan 2019, Greg KH wrote:
>> On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote:
>>> Variables declared in a switch statement before any case statements
>>> cannot be initialized, so move all instances out of t
;.
This obviously fails because the patch is against upstream rather than
our development tree. No worries.
BR,
Jani.
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel
On Wed, 23 Jan 2019, Edwin Zimmerman wrote:
> On Wed, 23 Jan 2019, Jani Nikula wrote:
>> On Wed, 23 Jan 2019, Greg KH wrote:
>> > On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote:
>> >> Variables declared in a switch statement before any case statements
&
On Wed, 23 Jan 2019, Ville Syrjälä wrote:
> On Tue, Jan 22, 2019 at 10:23:07AM +0200, Jani Nikula wrote:
>> The VBT int_crt_support can't be trusted on earlier platforms, and is
>> always set to true in intel_bios.c for pre-DDI and pre-VLV platforms. We
>> can si
ror handling for
> prepare_execlist_workload")
>
> has these problem(s):
>
> - Subject does not match target commit subject
>
> Just some whitespace.
Thanks for the report. The commit being referenced seems to be the right
one, though, so I don't think I'm going t
++-
drivers/gpu/drm/i915/intel_lrc.c | 4
2 files changed, 10 insertions(+), 5 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
touched the lists of include files was grouped
> and sorted.
>
> Build tested on x86 and arm allmodconfig / allyesconfig.
>
> Signed-off-by: Sam Ravnborg
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc
or older kernels, and we can only try to
backport the fix.
Fix the error path while at it.
Fixes: 04ebaadb9f2d ("drm/i915/opregion: handle VBT sizes bigger than 6 KB")
Cc: Ville Syrjälä
Cc: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_opregion.c | 12 ++-
different on
> drm-intel-fixes. IS_GEN(dev_priv, 6) needs to be converted to
> IS_GEN6(dev_priv).
>
> Lucas De Marchi
>
>>
>> I have reverted that commit for today.
Dropped the commit from drm-intel-fixes.
Somehow I had managed to screw up my kernel config in a way that av
-fixes-2019-01-24
>
> - Fix destroy of shadow batch and indirect ctx (Weinan)
>
>
> Weinan Li (1):
> drm/i915/gvt: release shadow batch buffer and wa_ctx before destroy one
> workload
>
> drivers/gpu/drm/i915/gvt/scheduler.c | 11 ++-
On Tue, 29 Jan 2019, Jani Nikula wrote:
> This is obviously a backward/forward incompatible change. I've been
> told there are no systems out there using the field.
There are systems like that, in our CI too. Back to the drawing board.
BR,
Jani.
--
Jani Nikula, Intel Open Sour
, I just
>> > > want to understand where you're coming from ;)
>> >
>> > This was a request from Jani Nikula in a previous series update. I
>> > don't have a strong preference either way personally. If you don't
>> > have any major c
NILAKE(dev_priv))
> + min_cdclk = max(158400, min_cdclk);
> +
> if (min_cdclk > dev_priv->max_cdclk_freq) {
> DRM_DEBUG_KMS("required cdclk (%d kHz) exceeds max (%d kHz)\n",
> min_cdclk, dev_priv->max_cdclk_fr
On Mon, 29 Apr 2019, Rodrigo Vivi wrote:
> On Mon, Apr 29, 2019 at 05:22:53PM +0300, Jani Nikula wrote:
>> Debug logging should not be dependent on alpha support flag.
>>
>> Cc: Rodrigo Vivi
>> Signed-off-by: Jani Nikula
>
> I agree... this is not th
Using arithmetic operators with booleans is confusing. Switch to logical
operators.
Cc: Paulo Zanoni
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915
oids CI tainting the kernel and stopping the test run.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110578
> Cc: Jani Nikula
> Signed-off-by: Imre Deak
> ---
> drivers/gpu/drm/i915/intel_dp.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>
->pipe;
>
> + /* FIXME precompute the ELD in .compute_config() */
> if (!connector->eld[0])
> - return;
> + DRM_DEBUG_KMS("Bogus ELD on [CONNECTOR:%d:%s]\n",
> + connector->base.id, connector->name);
>
&
cross checking against the spec.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/i915_reg.h| 12 +++
> drivers/gpu/drm/i915/intel_audio.c | 55 ++
> 2 files changed, 32 insertions(+), 35 deletions
t;> [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>> [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
>> [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
>> [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=10
Work on the principle that files should prefer not to expose platform
specific functions.
v2, v3: Rebase
Cc: Imre Deak
Reviewed-by: Chris Wilson
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_combo_phy.c | 24
drivers/gpu/drm/i915/intel_combo_phy.h | 6
On Thu, 02 May 2019, "Summers, Stuart" wrote:
> On Thu, 2019-05-02 at 10:15 +0300, Jani Nikula wrote:
>> Acked-by: Jani Nikula
>
> Jani, based on Daniele's feedback, I'm planning on squashing this patch
> with the patch that moves these helper functions to
Reduce clutter from intel_drv.h with the minimal change.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_drv.h | 5 -
drivers/gpu/drm/i915/intel_dvo.c | 5 +
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915
Continue the header refactoring started in [1] and [2].
BR,
Jani.
[1] https://patchwork.freedesktop.org/series/59022/
[2] https://patchwork.freedesktop.org/series/60060/
Jani Nikula (13):
drm/i915/dvo: move DVO chip types to intel_dvo.c
drm/i915/dsi: move operation mode types to intel_dsi.h
Reduce clutter from intel_drv.h with the minimal change.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_drv.h | 3 ---
drivers/gpu/drm/i915/intel_dsi.h | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915
Reduce clutter from i915_drv.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_debugfs.c | 1 +
drivers/gpu/drm/i915/i915_drv.h | 4
drivers/gpu/drm/i915/i915_gpu_error.c | 1 +
drivers/gpu/drm/i915/intel_csr.h | 4
4 files changed, 6 insertions(+), 4 deletions
Reduce clutter from intel_drv.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_drv.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 709647..addf6f 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
Reduce clutter from intel_drv.h with the minimal change.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_display.c | 15 +++
drivers/gpu/drm/i915/intel_drv.h | 15 ---
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915
Reduce clutter from i915_drv.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h | 10 --
drivers/gpu/drm/i915/intel_display.c | 10 ++
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915
Reduce clutter from i915_drv.h and intel_drv.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h | 44 -
drivers/gpu/drm/i915/i915_utils.h | 153 ++
drivers/gpu/drm/i915/intel_drv.h | 108 -
3 files changed, 153
And ensure it stays that way.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.header-test | 1 +
drivers/gpu/drm/i915/i915_utils.h | 6 --
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/Makefile.header-test
b/drivers/gpu/drm/i915
minimal further
includes, using forward declarations as needed. Include the new header
only where needed, and sort the modified include directives while at it
and as needed.
While at it, rename intel_i2c.c to intel_gmbus.c and the functions to
intel_gmbus_*.
No functional changes.
Signed-off-by: Jani
On Thu, 02 May 2019, Imre Deak wrote:
> On Thu, May 02, 2019 at 05:45:45PM +0300, Jani Nikula wrote:
>> On Thu, 02 May 2019, Imre Deak wrote:
>> > Thanks for the review, series pushed to -dinq, with the s/icl_/intel_/
>> > change and adding the headers to intel_
On Thu, 02 May 2019, Chris Wilson wrote:
> Quoting Jani Nikula (2019-05-02 16:02:34)
>> Continue the header refactoring started in [1] and [2].
>>
>> BR,
>> Jani.
>>
>> [1] https://patchwork.freedesktop.org/series/59022/
>> [2] https://patchwork.fre
On Thu, 02 May 2019, Jani Nikula wrote:
> Work on the principle that files should prefer not to expose platform
> specific functions.
>
> v2, v3: Rebase
>
> Cc: Imre Deak
> Reviewed-by: Chris Wilson
> Signed-off-by: Jani Nikula
And pushed, thanks for the review.
BR,
On Thu, 02 May 2019, Paulo Zanoni wrote:
> Em qui, 2019-05-02 às 11:29 +0300, Jani Nikula escreveu:
>> Using arithmetic operators with booleans is confusing. Switch to logical
>> operators.
>>
>> Cc: Paulo Zanoni
>> Signed-off-by: Jani Nikula
>> ---
drm/i915/intel_color.h
> +++ b/drivers/gpu/drm/i915/intel_color.h
> @@ -13,5 +13,6 @@
> int intel_color_check(struct intel_crtc_state *crtc_state);
> void intel_color_commit(const struct intel_crtc_state *crtc_state);
> void intel_color_load_lut
On Mon, 06 May 2019, Ville Syrjälä wrote:
> On Mon, May 06, 2019 at 04:21:07PM +0300, Jani Nikula wrote:
>> On Sat, 04 May 2019, Swati Sharma wrote:
>> > In this patch, a vfunc read_luts() is introduced to create a hw lut
>> > i.e. lut having values read from gamma/d
_DRM_I915_FORCE_PROBE config option to replace the
DRM_I915_ALPHA_SUPPORT option. This defaults to "*" if
DRM_I915_ALPHA_SUPPORT=y.
Instead of replacing i915.alpha_support immediately, let the two coexist
for a while, with a deprecation message, for a transition period.
Cc: Joonas Lahtinen
Cc: Rodrigo
e in deep color mode. Remove
> hdmi_sink_is_deep_color() - no longer needed as checking pipe_bpp > 24
> takes care of the deep color mode scenario.
>
> Separate patch for fixing switch from 12 bit to 10 bit deep color
> mode.
>
> Co-developed-by: Aditya Swarup
> Signed-off-b
On Mon, 06 May 2019, "Sharma, Swati2" wrote:
> On 06-May-19 7:11 PM, Jani Nikula wrote:
>> On Mon, 06 May 2019, Ville Syrjälä wrote:
>>> On Mon, May 06, 2019 at 04:21:07PM +0300, Jani Nikula wrote:
>>>> On Sat, 04 May 2019, Swati Sharma wrote:
>
On Tue, 07 May 2019, Jani Nikula wrote:
> On Mon, 06 May 2019, "Sharma, Swati2" wrote:
>> On 06-May-19 7:11 PM, Jani Nikula wrote:
>>> On Mon, 06 May 2019, Ville Syrjälä wrote:
>>>> On Mon, May 06, 2019 at 04:21:07PM +0300, Jani Nikula wrote:
>&g
gt;
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/i915_drv.c| 3 ++-
> drivers/gpu/drm/i915/i915_drv.h| 4 +---
> drivers/gpu/drm/i915/intel_gmbus.c | 6 ++
> 3 files changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a
On Tue, 07 May 2019, Ville Syrjälä wrote:
> On Tue, May 07, 2019 at 09:42:48AM +0300, Jani Nikula wrote:
>> On Mon, 29 Apr 2019, Aditya Swarup wrote:
>> > From: Clinton Taylor
>> >
>> > v2: Fix commit msg to reflect why issue occurs(Jani)
>> > Set GC
tel_engine_cs.c | 2 +-
For i915,
Acked-by: Jani Nikula
> drivers/isdn/hardware/mISDN/mISDNisar.c | 6 --
> drivers/mailbox/mailbox-test.c| 2 +-
> drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +-
> drivers/net/ethernet/synopsys/
https://bugs.freedesktop.org/show_bug.cgi?id=108085
>> > > Signed-off-by: Daniel Drake
>> > > Signed-off-by: Jian-Hong Pan
>> >
>> > Fixes: fd7d6c5c8f3e ("drm/i915: enable FBC on gen9+ too") ?
>> > Cc: Paulo Zanoni
>> > Cc: Daniel
INTEL_ICL_PORT_F_IDS(info), \
> - INTEL_VGA_DEVICE(0x8A51, info)
> + INTEL_VGA_DEVICE(0x8A51, info), \
> + INTEL_VGA_DEVICE(0x8A5D, info)
>
> /* EHL */
> #define INTEL_EHL_IDS(info) \
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
t;base.adjusted_mode.crtc_vblank_end = ((tmp >> 16) &
> 0x) + 1;
> +
> + if (!transcoder_is_dsi(cpu_transcoder)) {
> + tmp = I915_READ(VBLANK(cpu_transcoder));
> + pipe_config->base.adjusted_mode.crtc_vblank_start =
> +
On Mon, 13 May 2019, Imre Deak wrote:
> On Mon, May 13, 2019 at 04:56:25PM +0300, Jani Nikula wrote:
>> On Fri, 10 May 2019, Imre Deak wrote:
>> > Add another ICL-Y PCIID that proved to have only 5 ports to the
>> > corresponding PCIID list.
>> >
>> >
/drivers/gpu/drm/i915/intel_color.h
>> index b8a3ce6..057e8ac 100644
>> --- a/drivers/gpu/drm/i915/intel_color.h
>> +++ b/drivers/gpu/drm/i915/intel_color.h
>> @@ -13,5 +13,6 @@
>> int intel_color_check(struct intel_crtc_state *crtc_state);
>> void int
)
>
> Signed-off-by: Aditya Swarup
> Cc: Clint Taylor
> Cc: Ville Syrjälä
> Cc: Jani Nikula
> Cc: Manasi Navare
> ---
> drivers/gpu/drm/i915/intel_audio.c | 82 +-
> 1 file changed, 69 insertions(+), 13 deletions(-)
>
> diff --git a
On Wed, 15 May 2019, Harish Chegondi wrote:
> display_pipe_crc_irq_handler() skips the first CRC for all GPUs and the
> second CRC for GEN8+ GPUs. The second CRC is invalid even for BYT which
> is a GEN7 GPU. So, skip the second CRC even for GEN7 GPUs.
>
> Cc: Jani Nikula
>
anything* else.
> But this is just one side of the coin... when product is out there
> and we want the user to debug the issue to see if it is a RC6 bug
> we have no way to verify that. :/
The problem is, if it works with rc6 disabled, it doesn't prove it's an
rc6 bug either.
B
Dell) monitors */
> + drm_atomic_helper_shutdown(&i915->drm);
I think we could use this to replace edp_notify_handler(). But the above
alone is not enough because it won't do the wait, as we do the waits in
enable, and after boot we've lost track of when the last disable wa
e second CRC even for GEN7 GPUs.
>>
>> Cc: Jani Nikula
>> Cc: Tomi Sarvela
>> Cc: Petri Latvala
>> Cc: Ville Syrjälä
>> Cc: Maarten Lankhorst
>> Signed-off-by: Harish Chegondi
>> References: https://bugs.freedesktop.org/show_bug.cgi?id=103191
&
On Thu, 16 May 2019, "Summers, Stuart" wrote:
> On Thu, 2019-05-16 at 12:59 +0300, Jani Nikula wrote:
>> On Tue, 14 May 2019, Rodrigo Vivi wrote:
>> > One possibility that just came to my mind now is, what if we make
>> > this only for platforms that are sti
On Thu, 16 May 2019, Ville Syrjälä wrote:
> On Thu, May 16, 2019 at 03:55:25PM +0300, Jani Nikula wrote:
>> On Thu, 16 May 2019, Maarten Lankhorst
>> wrote:
>> > Op 16-05-2019 om 07:58 schreef Harish Chegondi:
>> >> display_pipe_crc_irq_handler() skip
ested if CONFIG_HEADER_TEST is enabled. This will
generate a dummy C file per header that gets built as part of extra-y.
Cc: Chris Wilson
Cc: Masahiro Yamada
Cc: Michal Marek
Signed-off-by: Jani Nikula
---
Documentation/kbuild/makefiles.txt | 7 +++
init/Kconfig
Demonstrate build failure on a header that is not self-contained.
Cc: Chris Wilson
Cc: Masahiro Yamada
Cc: Michal Marek
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915
Use the new header test facility.
Cc: Chris Wilson
Cc: Masahiro Yamada
Cc: Michal Marek
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index 1787e1299b1b
On Fri, 17 May 2019, Aditya Swarup wrote:
> On Wed, May 15, 2019 at 05:40:10PM +0300, Jani Nikula wrote:
>> On Tue, 02 Apr 2019, Aditya Swarup wrote:
>> > Adding N & CTS values for 10/12 bit deep color from Appendix C
>> > table in HDMI 2.0 spec. The cor
> [1]: https://patchwork.freedesktop.org/series/60357/
>
> Signed-off-by: Oleg Vasilev
> Cc: Arkadiusz Hiler
> Cc: Imre Deak
> Cc: Ville Syrjälä
> Cc: Jani Nikula
It's probably more common to add Cc's before the Signed-off-by.
> ---
> drivers/gpu/drm/i915/
On Sat, 18 May 2019, Masahiro Yamada wrote:
> On Fri, May 17, 2019 at 4:48 AM Jani Nikula wrote:
>>
>> Sometimes it's useful to be able to explicitly ensure certain headers
>> remain self-contained, i.e. that they are compilable as standalone
>> units, by in
t; + * DB[0] - DB[15]: Reserved
> + * DB[16]: Pixel Encoding and Colorimetry Formats
> + * DB[17]: Dynamic Range and Component Bit Depth
> + * DB[18]: Content Type
> + * DB[19] - DB[31]: Reserved
> + */
> +struct dp_sdp {
> struct dp_sdp_header sdp_header;
> - u8 DB0; /*
t it'll have to include intel_display.h,
>> which isn't on the list.
>
> Yes. If we have to include intel_display.h, that means whenever we get
> around to splitting intel_display.h, we will remember to update
> intel_display_power.h. Rainy day tasks will be to delete #include at
> random and see which are still required in headers.
Storm day task will be to bang iwyu [1] to work nicely with the kernel
build.
BR,
Jani.
[1] https://include-what-you-use.org/
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
ct
>> > > > acpi_device
>> > > *device)
>> > > >if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS))
>> > > >dev_dbg(&device->dev, "CPPC data invalid or not
>> > > > present\n");
>> > > >
>> > > > - id = x86_match_cpu(intel_cpu_ids);
>> > > > - if (!id && (!cpuidle_get_driver() || cpuidle_get_driver() ==
>> > > > - &acpi_idle_driver))
>> > > > + if (!cpuidle_get_driver() || cpuidle_get_driver() ==
>> > > > +&acpi_idle_driver)
>> > > >acpi_processor_power_init(pr);
>> > > >
>> > > >result = acpi_pss_perf_init(pr, device);
>> > > > --
>> > > > 2.7.4
>> > > >
>> > > > ___
>> > > > Intel-gfx mailing list
>> > > > Intel-gfx@lists.freedesktop.org
>> > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>> > > ___
>> > > Intel-gfx mailing list
>> > > Intel-gfx@lists.freedesktop.org
>> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>> > ___
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
he system suspend direct complete optimization, which can
> @@ -5190,7 +5177,7 @@ void intel_runtime_pm_enable(struct drm_i915_private
> *i915)
> * so the driver's own RPM reference tracking asserts also work on
>* platforms without RPM support.
>
-archive.com/20190521183850.GA9157@archlinux-epyc
References:
https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/201754420#L2435
Fixes: 0d5adc5f2f01 ("drm/i915: extract intel_runtime_pm.h from intel_drv.h")
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile.heade
On Tue, 21 May 2019, Nathan Chancellor wrote:
> Hi Jani,
>
> On Mon, Apr 29, 2019 at 03:29:36PM +0300, Jani Nikula wrote:
>> It used to be handy that we only had a couple of headers, but over time
>> intel_drv.h has become unwieldy. Extract declarations to a separate
>>
On Wed, 22 May 2019, Chris Wilson wrote:
> For convenience in avoiding inline spaghetti, keep the type definition
> as a separate header.
>
> Signed-off-by: Chris Wilson
> Reviewed-by: Matthew Auld
> Acked-by: Rodrigo Vivi
> Acked-by: Jani Nikula
Yup, applies to the ent
intel_mark_busy(), intel_mark_idle(), and skl_cdclk_get_vco() no longer
exist.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_drv.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 270f5b..720a27 100644
Some function declarations in intel_drv.h were missed when
intel_atomic_plane.h was created.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_atomic_plane.h | 16
drivers/gpu/drm/i915/intel_drv.h | 12
2 files changed, 16 insertions(+), 12
Move more missed declarations from i915_drv.h to intel_pm.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h | 10 --
drivers/gpu/drm/i915/i915_irq.c | 1 +
drivers/gpu/drm/i915/intel_pm.h | 9 +
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a
Move i915_reg_read_ioctl() declaration to intel_uncore.h, corresponding
to the definition in intel_uncore.c, and rename to
intel_uncore_reg_read_ioctl(). No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
drivers/gpu/drm/i915/i915_drv.h | 3
nq with Laurent's and Maarten's acks
to queue patch 2 via drm-intel.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
en needs to be backmerged to drm-intel-next-queued. We don't do
merges from drm-misc-next to drm-intel-next-queued directly.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.fr
On Wed, 22 May 2019, Nathan Chancellor wrote:
> On Wed, May 22, 2019 at 01:35:05PM +0300, Jani Nikula wrote:
>> Fix the duplicate typedef for intel_wakeref_t leading to Clang build
>> issues. While at it, actually make the intel_runtime_pm.h header
>> self-contained, whi
---
> [If I can possibly get an ack for this, I would like to send it up soon
> with the other Sphinx-related fixes.]
Thanks, whatever works,
Acked-by: Jani Nikula
>
> drivers/gpu/drm/i915/i915_reg.h | 6 +++---
> drivers/gpu/drm/i915/intel_workarounds.c | 2 +-
> 2 file
lock for non-eDP/VLV/CHV
drm/i915: Assert that TypeC ports are not used for eDP
Jani Nikula (39):
Merge drm/drm-next into drm-intel-next-queued
drm/i915: ensure more headers remain self-contained
drm/i915: make intel_bios.h self-contained
drm/i915/dvo: rename dvo.h
to errors in BUILD_BUG_ON_ZERO().
Replace __builtin_constant_p() with the __is_constexpr() magic spell.
Reported-by: Ville Syrjala
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_reg.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915
1101 - 1200 of 18224 matches
Mail list logo
