Re: [Intel-gfx] [PATCH 1/1] usb: typec: altmodes/displayport: reorder dp_altmode_configured()

2021-10-08 Thread Heikki Krogerus
Fixes: fc27e04630e9 ("usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic") Either way, this is OK by me, so once you have cleaned the commit message, please feel free to include my: Reviewed-by: Heikki Krogerus > Signed-off-by: Cameron Nemo > --- >

Re: [Intel-gfx] [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification (v2)

2021-05-05 Thread Heikki Krogerus
On Tue, May 04, 2021 at 05:35:49PM +0200, Hans de Goede wrote: > Hi, > > On 5/4/21 5:10 PM, Heikki Krogerus wrote: > >> +/** > >> + * drm_connector_oob_hotplug_event - Report out-of-band hotplug event to > >> connector > >> + * @connector: connecto

Re: [Intel-gfx] [PATCH 8/9] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2021-05-05 Thread Heikki Krogerus
Hi Hans, On Mon, May 03, 2021 at 05:46:46PM +0200, Hans de Goede wrote: > Use the new drm_connector_find_by_fwnode() and > drm_connector_oob_hotplug_event() functions to let drm/kms drivers > know about DisplayPort over Type-C hotplug events. > > Signed-off-by: Hans de Goede > --- > Changes in v

Re: [Intel-gfx] [PATCH 7/8] usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic

2021-05-10 Thread Heikki Krogerus
On Wed, May 05, 2021 at 06:24:14PM +0200, Hans de Goede wrote: > Make dp_altmode_notify() handle the dp->data.conf == 0 case too, > rather then having separate code-paths for this in various places > which call it. > > Signed-off-by: Hans de Goede Reviewed-by: Heikki Krogerus

Re: [Intel-gfx] [PATCH 8/8] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2021-05-10 Thread Heikki Krogerus
On Wed, May 05, 2021 at 06:24:15PM +0200, Hans de Goede wrote: > Use the new drm_connector_oob_hotplug_event() functions to let drm/kms > drivers know about DisplayPort over Type-C hotplug events. > > Signed-off-by: Hans de Goede Reviewed-by: Heikki Krogerus > --- > Chang

Re: [Intel-gfx] [PATCH 0/8] drm + usb-type-c: Add support for out-of-band hotplug notification (v3)

2021-05-11 Thread Heikki Krogerus
On Wed, May 05, 2021 at 06:24:07PM +0200, Hans de Goede wrote: > Hi All, > > Here is v3 of my patchset making DP over Type-C work on devices where the > Type-C controller does not drive the HPD pin on the GPU, but instead > we need to forward HPD events from the Type-C controller to the DRM driver

Re: [Intel-gfx] [PATCH 0/8] drm + usb-type-c: Add support for out-of-band hotplug notification (v3)

2021-05-21 Thread Heikki Krogerus
On Tue, May 11, 2021 at 10:05:26AM +0300, Heikki Krogerus wrote: > On Wed, May 05, 2021 at 06:24:07PM +0200, Hans de Goede wrote: > > Hi All, > > > > Here is v3 of my patchset making DP over Type-C work on devices where the > > Type-C controller does not drive the HPD

Re: [Intel-gfx] [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification

2021-05-03 Thread Heikki Krogerus
Hi Hans, On Wed, Apr 28, 2021 at 11:52:52PM +0200, Hans de Goede wrote: > +/** > + * struct drm_connector_oob_hotplug_event_data: OOB hotplug event data > + * > + * Contains data about out-of-band hotplug events, signalled through > + * drm_connector_oob_hotplug_event(). > + */ > +struct drm_conne

Re: [Intel-gfx] [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification

2021-05-04 Thread Heikki Krogerus
On Mon, May 03, 2021 at 04:35:29PM +0200, Hans de Goede wrote: > Hi, > > On 5/3/21 10:00 AM, Heikki Krogerus wrote: > > Hi Hans, > > > > On Wed, Apr 28, 2021 at 11:52:52PM +0200, Hans de Goede wrote: > >> +/** > >> + * struct drm_connector_o

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries

2021-05-04 Thread Heikki Krogerus
Hi Andy, > > +/* NOTE: The connector order must be final before this is called. */ > > +void intel_acpi_assign_connector_fwnodes(struct drm_i915_private *i915) > > +{ > > + struct drm_connector_list_iter conn_iter; > > + struct drm_device *drm_dev = &i915->drm; > > + struct devic

Re: [Intel-gfx] [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification (v2)

2021-05-04 Thread Heikki Krogerus
> +/** > + * drm_connector_oob_hotplug_event - Report out-of-band hotplug event to > connector > + * @connector: connector to report the event on > + * @data: data related to the event > + * > + * On some hardware a hotplug event notification may come from outside the > display > + * driver / dev

Re: [Intel-gfx] [PATCH 0/9] drm + usb-type-c: Add support for out-of-band hotplug notification (v2)

2021-05-04 Thread Heikki Krogerus
d in the event send to the DRM-subsystem, specifically sending > the following info was requested: > > 1. Which DP connector on the GPU the event is for > 2. How many lanes are available > 3. Connector orientation > > This series is basically an entirely new approach, which

Re: [Intel-gfx] [PATCH 3/3] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2019-02-27 Thread Heikki Krogerus
On Mon, Feb 25, 2019 at 02:20:37PM +0100, Hans de Goede wrote: > Use the new drm_kms_call_oob_hotplug_notifier_chain() function to load > drm/kms drivers know about DisplayPort over Type-C hotplug events. > > Signed-off-by: Hans de Goede I'm OK with this. I'll wait for the v2 and see if I can te

Re: [Intel-gfx] [PATCH 0/3] Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers

2019-02-27 Thread Heikki Krogerus
Hi Hans, On Mon, Feb 25, 2019 at 02:20:34PM +0100, Hans de Goede wrote: > Hi All, > > On some Cherry Trail devices, DisplayPort over Type-C is supported through > a USB-PD microcontroller (e.g. a fusb302) + a mux to switch the superspeed > datalines between USB-3 and DP (e.g. a pi3usb30532). The

Re: [Intel-gfx] [PATCH 0/3] Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers

2019-02-27 Thread Heikki Krogerus
On Wed, Feb 27, 2019 at 01:16:27PM +0200, Jani Nikula wrote: > On Wed, 27 Feb 2019, Heikki Krogerus wrote: > > One thing that this series does not consider is the DP lane count > > problem. The GPU drivers (i915 in this case) does not know is four, > > two or one DP la

Re: [Intel-gfx] [PATCH 0/3] Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers

2019-02-28 Thread Heikki Krogerus
On Wed, Feb 27, 2019 at 04:45:32PM +0100, Hans de Goede wrote: > Hi, > > On 27-02-19 12:16, Jani Nikula wrote: > > On Wed, 27 Feb 2019, Heikki Krogerus > > wrote: > > > One thing that this series does not consider is the DP lane count > > > problem. The G

Re: [Intel-gfx] [PATCH 0/3] Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers

2019-02-28 Thread Heikki Krogerus
Hi Hans, On Thu, Feb 28, 2019 at 12:24:25PM +0100, Hans de Goede wrote: > Hi, > > On 28-02-19 10:15, Heikki Krogerus wrote: > > On Wed, Feb 27, 2019 at 04:45:32PM +0100, Hans de Goede wrote: > > > Hi, > > > > > > On 27-02-19 12:16, Jani Nikula wrote: &g

Re: [Intel-gfx] [PATCH 0/3] Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers

2019-03-04 Thread Heikki Krogerus
Hi Hans, On Thu, Feb 28, 2019 at 05:54:21PM +0100, Hans de Goede wrote: > Hi Heikki, > > On 28-02-19 15:47, Heikki Krogerus wrote: > > Hi Hans, > > > > On Thu, Feb 28, 2019 at 12:24:25PM +0100, Hans de Goede wrote: > > > Hi, > > > &

[Intel-gfx] [PATCH 0/2] drm: connector firmware nodes

2019-03-25 Thread Heikki Krogerus
case (those nodes do seem to be supplying the connectors all kinds of resources, not only references to other components), I'm proposing this now instead of waiting for the USB Type-C patches. thanks, Heikki Krogerus (2): drm: Add fwnode member to the struct drm_connector drm/i915: Asso

[Intel-gfx] [PATCH 2/2] drm/i915: Associate ACPI connector nodes with connector entries

2019-03-25 Thread Heikki Krogerus
connector entry straightforward (it's one-on-one mapping). Signed-off-by: Heikki Krogerus --- drivers/gpu/drm/i915/intel_display.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH 1/2] drm: Add fwnode member to the struct drm_connector

2019-03-25 Thread Heikki Krogerus
case of ACPI, the connector's sysfs directory will have a symlink named "firmware_node" pointing to the node object directory in sysfs if a node is associated with the connector. Signed-off-by: Heikki Krogerus --- drivers/gpu/drm/drm_sysfs.c | 49 +---

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm: connector firmware nodes

2019-03-26 Thread Heikki Krogerus
On Mon, Mar 25, 2019 at 08:57:44PM -, Patchwork wrote: > == Series Details == > > Series: drm: connector firmware nodes > URL : https://patchwork.freedesktop.org/series/58531/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5810_full -> Patchwork_12592_full > =

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm: connector firmware nodes

2019-03-27 Thread Heikki Krogerus
Hi Jani, On Tue, Mar 26, 2019 at 03:16:29PM +, Saarinen, Jani wrote: > > -Original Message- > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > > Of Heikki > > Krogerus > > Sent: tiistai 26. maaliskuuta 2019 10.32 > >

Re: [Intel-gfx] [PATCH v4 2/5] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-05-16 Thread Heikki Krogerus
+Hans Hans, do you have any comments? On Mon, May 02, 2022 at 09:53:13AM -0700, Bjorn Andersson wrote: > In some implementations, such as the Qualcomm platforms, the display > driver has no way to query the current HPD state and as such it's > impossible to distinguish between disconnect and atte

Re: [Intel-gfx] [PATCH v4 2/5] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-05-17 Thread Heikki Krogerus
; Add a parameter to drm_connector_oob_hotplug_event() to pass the HPD > state. > > Also push the test for unchanged state in the displayport altmode driver > into the i915 driver, to allow other drivers to act upon each update. > > Signed-off-by: Bjorn Andersson Acked-by: Heik

Re: [Intel-gfx] Linux 5.2, usb: typec: Support for Alternate Modes

2019-08-01 Thread Heikki Krogerus
me, however attempting to enable both > of them will fail. > The returned error message is: > xrandr: Configure crtc 2 failed > > > On Tue, 30 Jul 2019 at 15:27, Heikki Krogerus > wrote: > > > > Hi Matthew, > > > > Copying the respective mailing list.

Re: [Intel-gfx] USB-C DP mode problem on linux

2020-10-19 Thread Heikki Krogerus
Hi Andrzej, On Sat, Oct 17, 2020 at 01:34:54PM +0200, Andrzej Kre wrote: > Hi, > > I know that You were involved in working on USB-C DP drivers. > You are my last chance to resolve my issue. > > On my HP laptop I have Intel UHD Graphics 620. > When I'm connecting my 4K monitor to Display Port. I

Re: [Intel-gfx] [PATCH v1] ACPI: Switch to use generic UUID API

2017-05-04 Thread Heikki Krogerus
Amir Goldstein > Cc: Jarkko Sakkinen > Cc: Jani Nikula > Cc: Ben Skeggs > Cc: Benjamin Tissoires > Cc: Joerg Roedel > Cc: Adrian Hunter > Cc: Yisen Zhuang > Cc: Bjorn Helgaas > Cc: Zhang Rui > Cc: Felipe Balbi > Cc: Mathias Nyman > Cc: Heikki Kroger

Re: [PATCH] usb: typec: ucsi: Fix connector status writing past buffer size

2024-12-04 Thread Heikki Krogerus
0xaa/0x120 >kernfs_seq_show+0x41/0x60 > > Just use the buffer size as argument to fix it. > > Fixes: 226ff2e681d0 ("usb: typec: ucsi: Convert connector specific commands > to bitmaps") > Signed-off-by: Lucas De Marchi Reviewed-by: Heikki Krogerus > --- &g

Re: [PATCH 5/8] drm/i915: Associate ACPI connector nodes with connector entries (v2)

2025-05-23 Thread Heikki Krogerus
Hi Jani, On Fri, May 23, 2025 at 12:28:11PM +0300, Jani Nikula wrote: > > Resurrecting an old thread because I am clueless and I have > questions. :) > > On Tue, 17 Aug 2021, Hans de Goede wrote: > > From: Heikki Krogerus > > > > On Intel platforms we kn