On Thu, Dec 10, 2020 at 08:25:38PM +0100, Thomas Gleixner wrote:
> These checks are used by modules and prevent the removal of the export of
> irq_to_desc(). Move the accessor into the core.
>
> Signed-off-by: Thomas Gleixner
Yes, but that means that irq_check_status_bit() may be called from mod
On Mon, Oct 18, 2021 at 06:45:03PM +0100, Matthew Auld wrote:
> As pointed out by Thomas, we likely need to flush the pages here if the
> GPU can read the page contents directly from main memory. Underneath we
> don't know what the sg_table is pointing to, so just add a
> wbinvd_on_all_cpus() here,
Use list_entry() instead of container_of() to access list members.
Also drop unnecessary and misleading NULL checks on the result of
list_entry().
Signed-off-by: Guenter Roeck
---
drivers/gpu/drm/i915/gvt/dmabuf.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff
Use list_entry() instead of container_of() to access list members.
Also drop unnecessary and misleading NULL checks on the result of
list_entry().
Signed-off-by: Guenter Roeck
---
v2: Checkpatch fixes:
- Fix alignment
- Replace comparison against NULL with !
drivers/gpu/drm/i915/gvt
On Tue, Jul 27, 2021 at 02:10:37PM +0200, Daniel Vetter wrote:
> The module init code is somewhat misplaced in i915_pci.c, since it
> needs to pull in init/exit functions from every part of the driver and
> pollutes the include list a lot.
>
> Extract an i915_module.c file which pulls all the bits
Hi Claire,
On Thu, Jun 24, 2021 at 11:55:24PM +0800, Claire Chang wrote:
> Add the initialization function to create restricted DMA pools from
> matching reserved-memory nodes.
>
> Regardless of swiotlb setting, the restricted DMA pool is preferred if
> available.
>
> The restricted DMA pools pr
Hi,
On Thu, Jun 24, 2021 at 11:55:26PM +0800, Claire Chang wrote:
> If a device is not behind an IOMMU, we look up the device node and set
> up the restricted DMA when the restricted-dma-pool is presented.
>
> Signed-off-by: Claire Chang
> Tested-by: Stefano Stabellini
> Tested-by: Will Deacon
On 7/2/21 6:18 AM, Will Deacon wrote:
On Fri, Jul 02, 2021 at 12:39:41PM +0100, Robin Murphy wrote:
On 2021-07-02 04:08, Guenter Roeck wrote:
On Thu, Jun 24, 2021 at 11:55:26PM +0800, Claire Chang wrote:
If a device is not behind an IOMMU, we look up the device node and set
up the restricted
On Fri, Dec 21, 2018 at 11:33:56AM +0100, Vincent Guittot wrote:
> From: Thara Gopinath
>
> This patch replaces jiffies based accounting for runtime_active_time
> and runtime_suspended_time with ktime base accounting. This makes the
> runtime debug counters inline with genpd and other pm subsytem
On 1/18/19 2:42 AM, Vincent Guittot wrote:
Hi Guenter,
Le Thursday 17 Jan 2019 à 14:16:28 (-0800), Guenter Roeck a écrit :
On Fri, Dec 21, 2018 at 11:33:56AM +0100, Vincent Guittot wrote:
From: Thara Gopinath
This patch replaces jiffies based accounting for runtime_active_time
and
On 1/18/19 3:05 AM, Rafael J. Wysocki wrote:
On Fri, Jan 18, 2019 at 11:53 AM Vincent Guittot
wrote:
On Fri, 18 Jan 2019 at 11:42, Vincent Guittot
wrote:
Hi Guenter,
Le Thursday 17 Jan 2019 à 14:16:28 (-0800), Guenter Roeck a écrit :
On Fri, Dec 21, 2018 at 11:33:56AM +0100, Vincent
On 1/21/19 7:17 AM, Vincent Guittot wrote:
On Fri, 18 Jan 2019 at 13:08, Guenter Roeck wrote:
On 1/18/19 3:05 AM, Rafael J. Wysocki wrote:
On Fri, Jan 18, 2019 at 11:53 AM Vincent Guittot
wrote:
On Fri, 18 Jan 2019 at 11:42, Vincent Guittot
wrote:
Hi Guenter,
Le Thursday 17 Jan 2019 à
Hi,
On Thu, Feb 07, 2019 at 10:54:53AM +0200, Joonas Lahtinen wrote:
> Make sure the underlying VMA in the process address space is the
> same as it was during vm_mmap to avoid applying WC to wrong VMA.
>
> A more long-term solution would be to have vm_mmap_locked variant
> in linux/mmap.h for wh
On Thu, Feb 28, 2019 at 11:12:49AM -0800, Guenter Roeck wrote:
> Hi,
>
> On Thu, Feb 07, 2019 at 10:54:53AM +0200, Joonas Lahtinen wrote:
> > Make sure the underlying VMA in the process address space is the
> > same as it was during vm_mmap to avoid applying WC to wrong VMA.
On Thu, Feb 28, 2019 at 01:32:41PM -0800, Guenter Roeck wrote:
> On Thu, Feb 28, 2019 at 11:12:49AM -0800, Guenter Roeck wrote:
> > Hi,
> >
> > On Thu, Feb 07, 2019 at 10:54:53AM +0200, Joonas Lahtinen wrote:
> > > Make sure the underlying VMA in the process address
On Thu, Feb 28, 2019 at 10:01:45PM +, Chris Wilson wrote:
> Quoting Guenter Roeck (2019-02-28 21:57:03)
> > On Thu, Feb 28, 2019 at 01:32:41PM -0800, Guenter Roeck wrote:
> > > On Thu, Feb 28, 2019 at 11:12:49AM -0800, Guenter Roeck wrote:
> > > > Hi,
> >
On Thu, Feb 28, 2019 at 10:18:32PM +, Chris Wilson wrote:
>
> If you have userspace that is broken, we need to fix it. We can get away
> with quietly changing ABI only so long as nobody notices. It sounds like
> you have some userspace that will break if you updated the kernel; ergo
> we have
On Thu, Feb 28, 2019 at 10:34:20PM +, Chris Wilson wrote:
> Quoting Guenter Roeck (2019-02-28 22:27:35)
> > On Thu, Feb 28, 2019 at 10:18:32PM +, Chris Wilson wrote:
> > >
> > > If you have userspace that is broken, we need to fix it. We can get away
> >
On 6/20/22 13:46, Badal Nilawar wrote:
From: Dale B Stimson
As part of the System Managemenent Interface (SMI), use the HWMON
subsystem to display power utilization.
v2:
- Fix review comments (Ashutosh)
- Do not restore power1_max upon module unload/load sequence
because on producti
On 6/20/22 13:46, Badal Nilawar wrote:
From: Dale B Stimson
As part of the System Managemenent Interface (SMI), use the HWMON
subsystem to display energy utilization
v2:
- Updated the date and kernel version in feature description
Signed-off-by: Dale B Stimson
Signed-off-by: Ashutosh Dixi
On 6/20/22 13:46, Badal Nilawar wrote:
From: Riana Tauro
As part of the System Managemenent Interface (SMI), use the HWMON
subsystem to display current voltage
v2:
- Updated date and kernel version in feature description
- Fixed review comments (Ashutosh)
Cc: Anshuman Gupta
Signed-off-
On Mon, Jun 20, 2022 at 11:41:41PM -0700, Dixit, Ashutosh wrote:
> On Mon, 20 Jun 2022 13:58:49 -0700, Guenter Roeck wrote:
> >
>
> Hi Guenter, Thanks for taking a look.
>
> > > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
> > > b/Do
On Tue, Jun 21, 2022 at 12:29:21PM -0700, Dixit, Ashutosh wrote:
> On Tue, 21 Jun 2022 10:44:21 -0700, Guenter Roeck wrote:
> >
> > On Mon, Jun 20, 2022 at 11:41:41PM -0700, Dixit, Ashutosh wrote:
> > > On Mon, 20 Jun 2022 13:58:49 -0700, Guenter Roeck wrote:
> > >
On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> During a patch discussion, Linus brought up the option of changing
> the C standard version from gnu89 to gnu99, which allows using variable
> declaration inside of a for() loop. While the C99, C11 and later
On 5/16/22 06:31, Greg KH wrote:
On Mon, May 16, 2022 at 06:10:23AM -0700, Guenter Roeck wrote:
On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote:
From: Arnd Bergmann
During a patch discussion, Linus brought up the option of changing
the C standard version from gnu89 to gnu99
On 5/18/22 00:46, Arnd Bergmann wrote:
On Mon, May 16, 2022 at 3:19 PM Guenter Roeck wrote:
On 5/16/22 06:31, Greg KH wrote:
On Mon, May 16, 2022 at 06:10:23AM -0700, Guenter Roeck wrote:
On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote:
From: Arnd Bergmann
During a patch
On Mon, Jul 11, 2022 at 09:58:59AM +0100, Matthew Auld wrote:
> If we encounter some monster sized local-memory page that exceeds the
> maximum sg length (UINT32_MAX), ensure that don't end up with some
> misaligned address in the entry that follows, leading to fireworks
> later. Also ensure we hav
__udivdi3'
Fix the problem by using DIV_ROUND_UP_ULL() instead of DIV_ROUND_UP().
Fixes: aff1e0b09b54 ("drm/i915/ttm: fix sg_table construction")
Cc: Matthew Auld
Cc: Nirmoy Das
Cc: Rodrigo Vivi
Signed-off-by: Guenter Roeck
---
I took a stab at the problem. Please ignore the nois
On 7/17/22 09:35, Patchwork wrote:
== Series Details ==
Series: drm/i915: Fix 32-bit build
URL : https://patchwork.freedesktop.org/series/106421/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Failure is unrelated to this patch. No problem seen with ToT spa
On 8/12/22 10:37, Badal Nilawar wrote:
From: Dale B Stimson
The i915 HWMON module will be used to expose voltage, power and energy
values for dGfx. Here we set up i915 hwmon infrastructure including i915
hwmon registration, basic data structures and functions.
v2:
- Create HWMON infra patch
:
- Fixed review comments (Ashutosh)
- Use hwm_ prefix for static functions (Ashutosh)
Cc: Guenter Roeck
Cc: Anshuman Gupta
Signed-off-by: Riana Tauro
Signed-off-by: Badal Nilawar
Acked-by: Guenter Roeck
---
.../ABI/testing/sysfs-driver-intel-i915-hwmon | 7 +++
drivers/gpu/drm/i915/gt
: Use hwm_ prefix for static functions (Ashutosh)
Cc: Guenter Roeck
Signed-off-by: Dale B Stimson
Signed-off-by: Ashutosh Dixit
Signed-off-by: Riana Tauro
Signed-off-by: Badal Nilawar
Acked-by: Guenter Roeck
---
.../ABI/testing/sysfs-driver-intel-i915-hwmon | 20 ++
drivers/gpu/drm/i915
Nilawar
Acked-by: Guenter Roeck
---
.../ABI/testing/sysfs-driver-intel-i915-hwmon | 8 ++
drivers/gpu/drm/i915/i915_hwmon.c | 119 +-
drivers/gpu/drm/i915/i915_hwmon.h | 1 +
drivers/gpu/drm/i915/intel_mchbar_regs.h | 2 +
4 files
:
- Use HWMON_CHANNEL_INFO to define power1_crit, curr1_crit (Badal)
- Update date and kernel version in Documentation.
v4: Use hwm_ prefix for static functions (Ashutosh)
Acked-by: Sujaritha Sundaresan
Signed-off-by: Ashutosh Dixit
Signed-off-by: Badal Nilawar
Acked-by: Guenter Roeck
in Documentation (Badal)
Signed-off-by: Ashutosh Dixit
Signed-off-by: Badal Nilawar
Acked-by: Guenter Roeck
---
.../ABI/testing/sysfs-driver-intel-i915-hwmon | 9 ++
drivers/gpu/drm/i915/i915_hwmon.c | 128 +-
drivers/gpu/drm/i915/i915_reg.h
On 8/12/22 10:37, Badal Nilawar wrote:
From: Dale B Stimson
Extend hwmon power/energy for XEHPSDV especially per gt level energy
usage.
v2: Update to latest HWMON spec (Ashutosh)
Signed-off-by: Ashutosh Dixit
Signed-off-by: Dale B Stimson
Signed-off-by: Badal Nilawar
Acked-by: Guenter
er case.
>
> So why not do this in i915 Kconfig:
>
> config DRM_I915
> ...
> depends on HWMON || HWMON=n
>
Ok with me, but not my call to make. The ifdef should then use
IS_ENABLED(), though.
Guenter
> Which rejects the CONFIG_HWMON=m && CONFIG_DRM_I
On Tue, Aug 23, 2022 at 12:46:14PM +0300, Jani Nikula wrote:
[ ... ]
> >>
> >> So why not do this in i915 Kconfig:
> >>
> >> config DRM_I915
> >>...
> >>depends on HWMON || HWMON=n
> > With this change I am getting recursive dependancy error when I run make
> > oldconfig
> >
> > badal@bn
ince the former
> doesn't work if hwmon is compiled as a module (Guenter)
> v5: Fixed review comments (Jani)
>
> Cc: Guenter Roeck
> Signed-off-by: Dale B Stimson
> Signed-off-by: Ashutosh Dixit
> Signed-off-by: Riana Tauro
> Signed-off-by: Badal Nilawar
On Fri, Jul 26, 2019 at 07:23:13PM +0200, Andrzej Pietrasiewicz wrote:
> Use the ddc pointer provided by the generic connector.
>
> Signed-off-by: Andrzej Pietrasiewicz
> Reviewed-by: Neil Armstrong
This patch results in a crash when running qemu:versatilepb.
Unable to handle kernel NULL point
On Fri, Dec 20, 2019 at 12:03:53PM -0800, Rajat Jain wrote:
> Certain laptops now come with panels that have integrated privacy
> screens on them. This patch adds support for such panels by adding
> a privacy-screen property to the intel_connector for the panel, that
> the userspace can then use to
On Tue, Jan 19, 2021 at 02:49:08PM +, Chris Wilson wrote:
> When flushing objects larger than the CPU cache it is preferrable to use
> a single wbinvd() rather than overlapping clflush(). At runtime, we
> avoid wbinvd() due to its system-wide latencies, but during
> singlethreaded suspend, no o
On Tue, Sep 03, 2019 at 07:21:33AM +0100, Chris Wilson wrote:
> If we make sure we grab a strong reference to each object as we dump it,
> we can reduce the locks outside of our iterators to an rcu_read_lock.
>
> This should prevent errors like:
> [ 2138.371911] BUG: KASAN: use-after-free in per_f
On Tue, Jun 30, 2020 at 10:14:25AM +0100, Chris Wilson wrote:
[ ... ]
> > > @@ -328,9 +334,9 @@ static void print_context_stats(struct seq_file *m,
> > > struct task_struct *task;
> > > char name[80];
> > >
> > > - spin_lock(&file->t
On Tue, Jun 30, 2020 at 04:08:00PM +0100, Chris Wilson wrote:
> Quoting Guenter Roeck (2020-06-30 16:01:05)
> > On Tue, Jun 30, 2020 at 10:14:25AM +0100, Chris Wilson wrote:
> > [ ... ]
> > > > > @@ -328,9 +334,9 @@ static void print_context_stats
On Wed, Mar 30, 2016 at 10:03:31PM +0200, Boris Brezillon wrote:
> The PWM framework has clarified the concept of reference PWM config
> (the platform dependent config retrieved from the DT or the PWM
> lookup table) and real PWM state.
>
> Use pwm_get_args() when the PWM user wants to retrieve th
On 2/13/23 21:33, Ashutosh Dixit wrote:
On ATSM the PL1 power limit is disabled at power up. The previous uapi
assumed that the PL1 limit is always enabled and therefore did not have a
notion of a disabled PL1 limit. This results in erroneous PL1 limit values
when PL1 limit is disabled. For examp
On 2/16/23 10:57, Rodrigo Vivi wrote:
On Tue, Feb 14, 2023 at 07:11:16PM -0800, Dixit, Ashutosh wrote:
On Mon, 13 Feb 2023 22:16:44 -0800, Guenter Roeck wrote:
Hi Guenter,
On 2/13/23 21:33, Ashutosh Dixit wrote:
On ATSM the PL1 power limit is disabled at power up. The previous uapi
lvare / Guenter Roeck for drivers/hwmon/pwm-fan.c
- Javier Martinez Canillas for drivers/gpu/drm/solomon/ssd130x.c
- Liam Girdwood / Mark Brown for drivers/regulator/pwm-regulator.c
- Helge Deller for drivers/video/fbdev/ssd1307fb.c
Best regards
Uwe
Personally I find the change unnecessar
On 9/26/22 10:52, Badal Nilawar wrote:
This series adds the HWMON support for DGFX
Test-with: 20220919144408.251981-1-riana.ta...@intel.com
v2:
- Reorganized series. Created first patch as infrastructure patch
followed by feature patches. (Ashutosh)
- Fixed review comments (Jani)
On Wed, Oct 05, 2022 at 04:26:28PM +0200, Thorsten Leemhuis wrote:
> [adding the coretemp maintainer (Fenghua Yu) and the appropriate mailing
> list to the list of recipients, as there apparently is a coretemp bug
> that results in a iommu change causing a regression]
>
> On 30.09.22 18:57, Janusz
On Wed, Oct 05, 2022 at 05:15:49PM +0100, Robin Murphy wrote:
> On 2022-10-05 16:25, Guenter Roeck wrote:
> > On Wed, Oct 05, 2022 at 04:26:28PM +0200, Thorsten Leemhuis wrote:
> > > [adding the coretemp maintainer (Fenghua Yu) and the appropriate mailing
> > > list to
On Tue, Feb 28, 2023 at 01:18:55PM -0800, Dixit, Ashutosh wrote:
> On Fri, 12 Aug 2022 11:06:58 -0700, Guenter Roeck wrote:
> >
>
> Hi Guenter/linux-hwmon,
>
>
> > On 8/12/22 10:37, Badal Nilawar wrote:
> > > From: Dale B Stimson
> > >
> >
On Fri, Nov 04, 2022 at 01:40:53AM -0400, Steven Rostedt wrote:
>
> Back in April, I posted an RFC patch set to help mitigate a common issue
> where a timer gets armed just before it is freed, and when the timer
> goes off, it crashes in the timer code without any evidence of who the
> culprit was
On Fri, Nov 04, 2022 at 03:42:09PM -0400, Steven Rostedt wrote:
> On Fri, 4 Nov 2022 12:22:32 -0700
> Guenter Roeck wrote:
>
> > Unfortunately the renaming caused some symbol conflicts.
> >
> > Global definition: timer_shutdown
> >
> > File
On Fri, Nov 04, 2022 at 04:38:34PM -0400, Steven Rostedt wrote:
> On Fri, 4 Nov 2022 15:42:09 -0400
> Steven Rostedt wrote:
>
[ ... ]
>
> > drivers/clocksource/timer-fttmr010.c: fttmr010->timer_shutdown(evt);
> > drivers/clocksource/timer-fttmr010.c: fttmr010->timer_shutdown(evt);
> > driver
On Fri, Nov 04, 2022 at 01:40:53AM -0400, Steven Rostedt wrote:
>
> Back in April, I posted an RFC patch set to help mitigate a common issue
> where a timer gets armed just before it is freed, and when the timer
> goes off, it crashes in the timer code without any evidence of who the
> culprit was
On Sat, Nov 05, 2022 at 02:00:24AM -0400, Steven Rostedt wrote:
>
> Back in April, I posted an RFC patch set to help mitigate a common issue
> where a timer gets armed just before it is freed, and when the timer
> goes off, it crashes in the timer code without any evidence of who the
> culprit was
ing the other patches
> 4b for the next merge window.
>
For the series, as far as my testbed goes:
Build results:
total: 152 pass: 152 fail: 0
Qemu test results:
total: 500 pass: 500 fail: 0
No runtime crashes or warnings observed.
Tested-by: Guenter Roeck
Guenter
On Wed, Feb 14, 2024 at 06:48:53PM +0530, Arunpravin Paneer Selvam wrote:
> From: Matthew Auld
>
> Sanity check DRM_BUDDY_CONTIGUOUS_ALLOCATION.
>
> v2: Fix checkpatch warnings.
>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3097
> Signed-off-by: Matthew Auld
> Cc: Arunpravin Pane
On 3/11/24 09:58, Rodrigo Vivi wrote:
On Mon, Mar 11, 2024 at 09:06:46AM +0100, Janusz Krzysztofik wrote:
In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an
rpm wakeref. That results in lock inversion:
<4> [197.079335]
On Thu, May 16, 2024 at 01:34:54PM -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)"
>
> [
>This is a treewide change. I will likely re-create this patch again in
>the second week of the merge window of v6.10 and submit it then. Hoping
>to keep the conflicts that it will
On 5/17/24 10:48, Steven Rostedt wrote:
On Fri, 17 May 2024 10:36:37 -0700
Guenter Roeck wrote:
Building csky:allmodconfig (and others) ... failed
--
Error log:
In file included from include/trace/trace_events.h:419,
from include/trace/define_trace.h:102
Hi,
On Tue, Mar 05, 2024 at 11:07:35AM +0200, Jani Nikula wrote:
> At least the i915 and amd drivers enable a bunch more compiler warnings
> than the kernel defaults.
>
> Extend most of the W=1 warnings to the entire drm subsystem by
> default. Use the copy-pasted warnings from scripts/Makefile.e
On 5/17/24 11:00, Guenter Roeck wrote:
On 5/17/24 10:48, Steven Rostedt wrote:
On Fri, 17 May 2024 10:36:37 -0700
Guenter Roeck wrote:
Building csky:allmodconfig (and others) ... failed
--
Error log:
In file included from include/trace/trace_events.h:419,
from
Hi all,
after upgrading one of my servers to 3.8, then 3.9.7 and 3.10-rc6, I started to
see lots of "Timed out waiting for forcewake old ack to clear" error messages,
including hang-ups especially if the system was highly loaded. With 3.5.24
everything was fine.
After backing out commit 36ec8f877
On Sat, Jun 22, 2013 at 12:16:46PM -0700, Jesse Barnes wrote:
> On Fri, 21 Jun 2013 23:58:08 -0700
> Guenter Roeck wrote:
>
> > Hi all,
> >
> > after upgrading one of my servers to 3.8, then 3.9.7 and 3.10-rc6, I
> > started to
> > see lots of "Time
On Wed, Jun 26, 2013 at 09:24:07AM -0700, Jesse Barnes wrote:
> On Sat, 22 Jun 2013 13:04:09 -0700
> Guenter Roeck wrote:
>
> > On Sat, Jun 22, 2013 at 12:16:46PM -0700, Jesse Barnes wrote:
> > > On Fri, 21 Jun 2013 23:58:08 -0700
> > > Guenter Ro
m won't be able to run the upstream kernel on affected boards).
Cc: Jesse Barnes
Cc: Daniel Vetter
Cc: Mika Kuoppala
Signed-off-by: Guenter Roeck
---
drivers/gpu/drm/i915/intel_pm.c | 31 +++
1 file changed, 27 insertions(+), 4 deletions(-)
diff --git a/drive
On Tue, Jul 09, 2013 at 10:33:22PM +0200, Daniel Vetter wrote:
> On Tue, Jul 09, 2013 at 01:14:09PM -0700, Guenter Roeck wrote:
> > This reverts commit 36ec8f877481449bdfa072e6adf2060869e2b970.
> >
> > The commit results in repeated 'Timed out waiting for forcewake old
Cc: Jesse Barnes
Cc: Daniel Vetter
Cc: Mika Kuoppala
Signed-off-by: Guenter Roeck
---
v2: Only revert patch for Ivybridge CPUs
Issue info message if mt forcewake is disabled on Ivybridge
drivers/gpu/drm/i915/intel_pm.c | 31 ++-
1 file changed, 30 insertions(+),
On 10/27/2013 10:33 AM, Greg KH wrote:
On Sun, Oct 27, 2013 at 04:13:42PM +, Rob Pearce wrote:
From: Rob Pearce
The Intel D410PT(LW) and D425KT Mini-ITX desktop boards both show up as
having LVDS but the hardware is not populated. This patch adds them to
the list of such systems. Patch is
On 9/24/24 09:57, Maxime Ripard wrote:
On Tue, Sep 24, 2024 at 06:56:26PM GMT, Jani Nikula wrote:
On Tue, 24 Sep 2024, Guenter Roeck wrote:
On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote:
Yeah I think long-term we might want a kunit framework so that we can
catch dmesg warnings
On 9/24/24 04:54, Maxime Ripard wrote:
+Guenter
On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote:
On Tue, Sep 17, 2024 at 08:43:50PM +0300, Jani Nikula wrote:
The tests consistently trigger WARNs in drm_framebuffer code. I'm not
sure what the point is with type of belts and suspende
On 9/24/24 08:56, Jani Nikula wrote:
On Tue, 24 Sep 2024, Guenter Roeck wrote:
On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote:
Yeah I think long-term we might want a kunit framework so that we can
catch dmesg warnings we expect and test for those, without those warnings
actually
On 9/24/24 06:56, Maxime Ripard wrote:
On Tue, Sep 24, 2024 at 06:37:59AM GMT, Guenter Roeck wrote:
On 9/24/24 04:54, Maxime Ripard wrote:
+Guenter
On Tue, Sep 24, 2024 at 12:06:28PM GMT, Simona Vetter wrote:
On Tue, Sep 17, 2024 at 08:43:50PM +0300, Jani Nikula wrote:
The tests
On 9/25/24 05:59, Maxime Ripard wrote:
...
All I'm saying it generates an extra burden for current real world CI
systems that run tests on a massive scale and even have paid
maintainers. It's not trivial to sort out expected and unexpected
warnings, and keep the filters updated every time the wa
On 9/25/24 06:05, Maxime Ripard wrote:
[ ... ]
We've had similar discussions in the past around unit tests that wasted
too much cpu time with randomized combinatorial testing, and we've thrown
those out too from drm. Test hygiene matters.
We had that discussion because those tests could run fo
On 2/2/25 05:27, David Laight wrote:
On Tue, 21 Jan 2025 15:15:09 -0800
Linus Torvalds wrote:
On Tue, 21 Jan 2025 at 14:59, Rodrigo Vivi wrote:
I'm pushing this soon to drm-intel-next, unless Linus want to take
this one directly to his tree
Let's just go through the proper channels and go
after a warning. While at it, fix divide by zero error seen
if source_min == source_max.
Analyzed-by: Linus Torvalds
Suggested-by: Linus Torvalds
Suggested-by: David Laight
Cc: David Laight
Cc: Jani Nikula
Cc: Andy Shevchenko
Signed-off-by: Guenter Roeck
---
drivers/gpu/drm/i915/display/int
after a warning. While at it, fix divide by zero error seen
if source_min == source_max.
Analyzed-by: Linus Torvalds
Suggested-by: Linus Torvalds
Suggested-by: David Laight
Cc: David Laight
Cc: Jani Nikula
Cc: Andy Shevchenko
Signed-off-by: Guenter Roeck
---
v2: Simplify code to always retu
On 1/20/25 11:14, Linus Torvalds wrote:
On Mon, 20 Jan 2025 at 10:55, Andy Shevchenko
wrote:
Excuse me if I am missing something, but clamp() has a warning inside it,
correct?
Why do we need an additional warning on top of that?
Note: the warning in clamp() only finds compile-time obvious w
On 1/18/25 14:11, David Laight wrote:
On Sat, 18 Jan 2025 13:21:39 -0800
Linus Torvalds wrote:
On Sat, 18 Jan 2025 at 09:49, Guenter Roeck wrote:
No idea why the compiler would know that the values are invalid.
It's not that the compiler knows tat they are invalid, but I bet what
ha
On 1/18/25 13:18, David Laight wrote:
On Sat, 18 Jan 2025 10:36:11 -0800
Guenter Roeck wrote:
On 1/18/25 10:09, David Laight wrote:
On Sat, 18 Jan 2025 09:49:21 -0800
Guenter Roeck wrote:
On Sat, Jan 18, 2025 at 05:09:59PM +, David Laight wrote:
On Sat, 18 Jan 2025 08:13:06 -0800
On 1/18/25 13:21, Linus Torvalds wrote:
On Sat, 18 Jan 2025 at 09:49, Guenter Roeck wrote:
No idea why the compiler would know that the values are invalid.
It's not that the compiler knows tat they are invalid, but I bet what
happens is in scale() (and possibly other places that do si
Hi,
On Mon, Nov 18, 2024 at 07:13:31PM +, David Laight wrote:
> Use BUILD_BUG_ON_MSG(statically_true(ulo > uhi), ...) for the sanity
> check of the bounds in clamp().
> Gives better error coverage and one less expansion of the arguments.
>
> Signed-off-by: David Laight
This patch triggers a
On Sat, Jan 18, 2025 at 05:09:59PM +, David Laight wrote:
> On Sat, 18 Jan 2025 08:13:06 -0800
> Guenter Roeck wrote:
>
> > Hi,
> >
> > On Mon, Nov 18, 2024 at 07:13:31PM +, David Laight wrote:
> > > Use BUILD_BUG_ON_MSG(statically_true(ulo > uhi),
On 1/20/25 03:21, Jani Nikula wrote:
On Mon, 20 Jan 2025, David Laight wrote:
On Mon, 20 Jan 2025 12:48:11 +0200
Jani Nikula wrote:
On Sun, 19 Jan 2025, David Laight wrote:
On Sat, 18 Jan 2025 14:58:48 -0800
Guenter Roeck wrote:
On 1/18/25 14:11, David Laight wrote:
On Sat, 18 Jan
On 1/18/25 10:09, David Laight wrote:
On Sat, 18 Jan 2025 09:49:21 -0800
Guenter Roeck wrote:
On Sat, Jan 18, 2025 at 05:09:59PM +, David Laight wrote:
On Sat, 18 Jan 2025 08:13:06 -0800
Guenter Roeck wrote:
Hi,
On Mon, Nov 18, 2024 at 07:13:31PM +, David Laight wrote:
Use
89 matches
Mail list logo
