Re: [Intel-gfx] v5.10 stable backport request

2021-01-06 Thread Greg KH
On Wed, Jan 06, 2021 at 07:53:01PM +0200, Imre Deak wrote: > Stable team, please backport the upstream commit > > 8f329967d596 ("drm/i915/tgl: Fix Combo PHY DPLL fractional divider for > 38.4MHz ref clock") > > to the v5.10 stable kernel. I see no such commit id in Linus's kernel :( ___

Re: [Intel-gfx] v5.10 stable backport request

2021-01-07 Thread Greg KH
On Wed, Jan 06, 2021 at 09:09:45PM +0200, Imre Deak wrote: > On Wed, Jan 06, 2021 at 07:04:42PM +0100, Greg KH wrote: > > On Wed, Jan 06, 2021 at 07:53:01PM +0200, Imre Deak wrote: > > > Stable team, please backport the upstream commit > > > > > > 8f329967d59

Re: [Intel-gfx] [CI] drm/i915: Disable atomics in L3 for gen9

2021-05-28 Thread Greg KH
On Fri, May 28, 2021 at 01:25:43PM -0400, J. Bruce Fields wrote: > Would it be possible to apply > > 58586680ffad "drm/i915: Disable atomics in L3 for gen9" > > to stable kernels? > > I'm finding it quite easy to crash my Thinkpad X1 Carbon 6th gen with > Blender on Fedora 34 (which is usi

Re: [Intel-gfx] [PATCH 1/5] dri: cleanup debugfs error handling

2021-10-08 Thread Greg KH
On Fri, Oct 08, 2021 at 12:40:47PM +0300, Jani Nikula wrote: > On Fri, 08 Oct 2021, Nirmoy Das wrote: > > Debugfs API returns encoded error instead of NULL. > > This patch cleanups drm debugfs error handling to > > properly set dri and its minor's root dentry to NULL. > > > > Also do not error out

Re: [Intel-gfx] [PATCH v2] component: do not leave master devres group open after bind

2021-10-13 Thread Greg KH
On Wed, Oct 06, 2021 at 04:47:57PM +0300, Kai Vehmanen wrote: > Hi, > > On Tue, 5 Oct 2021, Greg KH wrote: > > > On Wed, Sep 22, 2021 at 11:54:32AM +0300, Kai Vehmanen wrote: > > > In current code, the devres group for aggregate master is left open > > >

Re: [Intel-gfx] linux-next: manual merge of the char-misc tree with the drm-intel tree

2021-10-29 Thread Greg KH
On Thu, Oct 28, 2021 at 06:27:53PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the char-misc tree got a conflict in: > > drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c > > between commit: > > 5740211ea442 ("drm/i915/dmabuf: fix broken build") > > from the drm-intel

Re: [Intel-gfx] [PATCH v2] component: do not leave master devres group open after bind

2021-10-05 Thread Greg KH
On Wed, Sep 22, 2021 at 11:54:32AM +0300, Kai Vehmanen wrote: > In current code, the devres group for aggregate master is left open > after call to component_master_add_*(). This leads to problems when the > master does further managed allocations on its own. When any > participating driver calls c

Re: [Intel-gfx] refactor the i915 GVT support

2021-07-22 Thread Greg KH
On Thu, Jul 22, 2021 at 10:49:47AM +, Wang, Zhi A wrote: > But it's hard for some customers to contribute their own "hypervisor" > module to the upstream Linux kernel. What prevents them from doing this? We will take any code that meets our standards, what format is this external code in? >

Re: [Intel-gfx] refactor the i915 GVT support

2021-07-28 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer

2021-06-30 Thread Greg KH
On Wed, Jun 30, 2021 at 11:52:28AM +0200, Thomas Zimmermann wrote: > Remove all references to DRM's IRQ midlayer. i915 uses Linux' interrupt > functions directly. > > v2: > * also remove an outdated comment > * move IRQ fix into separate patch > * update Fixes tag (Daniel) > > S

Re: [Intel-gfx] drm/i915: v5.11 stable backport request

2021-05-03 Thread Greg KH
On Mon, May 03, 2021 at 07:40:01PM +0300, Imre Deak wrote: > Stable team, please backport the upstream commits > > 7962893ecb85 ("drm/i915: Disable runtime power management during shutdown") > > to the v5.11 stable kernel, they fix a system shutdown failure. > > References: > https://lore.kerne

Re: [Intel-gfx] [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-23 Thread Greg KH
On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote: > Variables declared in a switch statement before any case statements > cannot be initialized, so move all instances out of the switches. > After this, future always-initialized stack variables will work > and not throw warnings like this:

Re: [Intel-gfx] [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-24 Thread Greg KH
On Thu, Jan 24, 2019 at 07:55:51AM +1300, Kees Cook wrote: > On Thu, Jan 24, 2019 at 4:44 AM Jani Nikula > wrote: > > > > On Wed, 23 Jan 2019, Edwin Zimmerman wrote: > > > On Wed, 23 Jan 2019, Jani Nikula wrote: > > >> On Wed, 23 Jan 2019, Greg KH wrote:

Re: [Intel-gfx] [PATCH 03/16] lib, treewide: add new match_string() helper/macro

2019-05-08 Thread Greg KH
On Wed, May 08, 2019 at 04:11:28PM +0300, Andy Shevchenko wrote: > On Wed, May 08, 2019 at 02:28:29PM +0300, Alexandru Ardelean wrote: > > This change re-introduces `match_string()` as a macro that uses > > ARRAY_SIZE() to compute the size of the array. > > The macro is added in all the places that

Re: [Intel-gfx] [PATCH 14/33] staging/olpc: lock_fb_info can't fail

2019-05-27 Thread Greg KH
On Mon, May 27, 2019 at 09:10:10AM +0200, Daniel Vetter wrote: > On Fri, May 24, 2019 at 10:53:35AM +0200, Daniel Vetter wrote: > > Simply because olpc never unregisters the damn thing. It also > > registers the framebuffer directly by poking around in fbdev > > core internals, so it's all around r

Re: [Intel-gfx] [PATCH 32/33] staging/olpc_dcon: Add drm conversion to TODO

2019-05-27 Thread Greg KH
On Mon, May 27, 2019 at 09:11:26AM +0200, Daniel Vetter wrote: > On Fri, May 24, 2019 at 10:53:53AM +0200, Daniel Vetter wrote: > > this driver is pretty horrible from a design pov, and needs a complete > > overhaul. Concrete thing that annoys me is that it looks at > > registered_fb, which is an i

Re: [Intel-gfx] [v5.0 stable PATCH] drm/i915/dp: revert back to max link rate and lane count on eDP

2019-04-15 Thread Greg KH
On Mon, Apr 15, 2019 at 03:58:37PM +0300, Jani Nikula wrote: > commit 21635d7311734d2d1b177f8a95e2f9386174b76d upstream. > > Commit 7769db588384 ("drm/i915/dp: optimize eDP 1.4+ link config fast > and narrow") started to optize the eDP 1.4+ link config, both per spec > and as preparation for displ

Re: [Intel-gfx] [PATCH v12 21/38] mei: me: add ice lake point device id.

2019-02-08 Thread Greg KH
On Sat, Feb 09, 2019 at 12:42:50PM +0530, Ramalingam C wrote: > From: Tomas Winkler > > Add icelake mei device id. > > Cc: > Signed-off-by: Tomas Winkler > Signed-off-by: Greg Kroah-Hartman > Cherry-picked from > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git > char-mis

Re: [Intel-gfx] [PULL] topic/component-typed

2019-02-11 Thread Greg KH
On Mon, Feb 11, 2019 at 08:18:04PM +0100, Daniel Vetter wrote: > On Mon, Feb 11, 2019 at 7:57 PM Takashi Iwai wrote: > > > > On Mon, 11 Feb 2019 19:25:12 +0100, > > Sam Ravnborg wrote: > > > > > > Hi Daniel. > > > > > > On Mon, Feb 11, 2019 at 06:15:20PM +0100, Daniel Vetter wrote: > > > > Hi all,

Re: [Intel-gfx] [PULL] topic/mei-hdcp

2019-02-19 Thread Greg KH
On Tue, Feb 19, 2019 at 08:55:27AM +0100, Daniel Vetter wrote: > Hi all, > > topic/mei-hdcp-2019-02-19: > Prep patches + headers for the mei-hdcp/i915 component interfaces > > Also contains the prep work in the component helpers plus adjustements > for the snd-hda/i915 component interface. > > P

Re: [Intel-gfx] [PULL] topic/mei-hdcp for char-misc-next

2019-02-28 Thread Greg KH
On Tue, Feb 26, 2019 at 10:17:10PM +0100, Daniel Vetter wrote: > Hi Greg&Arnd > > topic/mei-hdcp-2019-02-26: > mei-hdcp driver > > mei driver for the me hdcp client, for use by drm/i915. > > Including the following prep work: > - whitelist hdcp client in mei bus > - merge to include char-misc-ne

Re: [Intel-gfx] [PATCH v3] Return only active connectors for get_resources ioctl

2018-11-29 Thread Greg KH
On Thu, Nov 29, 2018 at 01:09:21PM +0200, Stanislav Lisovskiy wrote: > Currently kernel might allocate different connector ids > for the same outputs in case of DP MST, which seems to > confuse userspace. There are can be different connector > ids in the list, which could be assigned to the same >

Re: [Intel-gfx] [BACKPORT 4.14.y 1/8] drm/i915/fbdev: Actually configure untiled displays

2019-09-04 Thread Greg KH
On Tue, Sep 03, 2019 at 02:55:26PM +0800, Baolin Wang wrote: > From: Chris Wilson > > If we skipped all the connectors that were not part of a tile, we would > leave conn_seq=0 and conn_configured=0, convincing ourselves that we > had stagnated in our configuration attempts. Avoid this situation

Re: [Intel-gfx] [PATCH 12/16] staging/comedi: mark as broken

2019-06-14 Thread Greg KH
On Fri, Jun 14, 2019 at 03:47:22PM +0200, Christoph Hellwig wrote: > comedi_buf.c abuse the DMA API in gravely broken ways, as it assumes it > can call virt_to_page on the result, and the just remap it as uncached > using vmap. Disable the driver until this API abuse has been fixed. > > Signed-of

Re: [Intel-gfx] [PATCH 12/16] staging/comedi: mark as broken

2019-06-14 Thread Greg KH
On Fri, Jun 14, 2019 at 04:48:57PM +0200, Christoph Hellwig wrote: > On Fri, Jun 14, 2019 at 04:02:39PM +0200, Greg KH wrote: > > Perhaps a hint as to how we can fix this up? This is the first time > > I've heard of the comedi code not handling dma properly. > > I

Re: [Intel-gfx] [PATCH stable-4.9+] drm/i915/dmc: protect against reading random memory

2019-07-03 Thread Greg KH
On Tue, Jul 02, 2019 at 12:23:04PM -0700, Lucas De Marchi wrote: > commit bc7b488b1d1c71dc4c5182206911127bc6c410d6 upstream. > > While loading the DMC firmware we were double checking the headers made > sense, but in no place we checked that we were actually reading memory > we were supposed to. T

Re: [Intel-gfx] [greybus-dev] Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-05-16 Thread Greg KH
On Mon, May 16, 2022 at 06:10:23AM -0700, Guenter Roeck wrote: > On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > During a patch discussion, Linus brought up the option of changing > > the C standard version from gnu89 to gnu99, which allows using var

Re: [Intel-gfx] [PATCH v4 00/41] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-08-11 Thread Greg KH
ng: dyndbg: use ESCAPE_SPACE for cat control > > > Applying: dyndbg: let query-modname override actual module name > > > Applying: dyndbg: add test_dynamic_debug module > > > Applying: dyndbg: drop EXPORTed dynamic_debug_exec_queries > > > > > > Jason, >

Re: [Intel-gfx] [PATCH v2 18/19] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-05 Thread Greg KH
On Tue, Apr 05, 2022 at 03:24:40PM +0200, Geert Uytterhoeven wrote: > Hi Daniel, > > On Tue, Apr 5, 2022 at 1:48 PM Daniel Vetter wrote: > > On Tue, 5 Apr 2022 at 11:52, Javier Martinez Canillas > > wrote: > > > On 4/5/22 11:24, Daniel Vetter wrote: > > > > On Tue, 5 Apr 2022 at 11:19, Javier Ma

Re: [Intel-gfx] [PATCH v2 18/19] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-05 Thread Greg KH
On Tue, Apr 05, 2022 at 06:12:59PM +0200, Daniel Vetter wrote: > On Tue, Apr 05, 2022 at 03:33:17PM +0200, Greg KH wrote: > > On Tue, Apr 05, 2022 at 03:24:40PM +0200, Geert Uytterhoeven wrote: > > > Hi Daniel, > > > > > > On Tue, Apr 5, 2022 at 1:48 PM Daniel

Re: [Intel-gfx] [PATCH v2 18/19] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-07 Thread Greg KH
On Tue, Apr 05, 2022 at 07:29:22PM +0200, Daniel Vetter wrote: > On Tue, 5 Apr 2022 at 18:45, Greg KH wrote: > > > > On Tue, Apr 05, 2022 at 06:12:59PM +0200, Daniel Vetter wrote: > > > On Tue, Apr 05, 2022 at 03:33:17PM +0200, Greg KH wrote: > > > > On T

Re: [Intel-gfx] [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Greg KH
On Fri, Apr 29, 2022 at 09:07:57AM +0100, Mauro Carvalho Chehab wrote: > Hi Daniel, > > Em Fri, 29 Apr 2022 09:54:10 +0200 > Daniel Vetter escreveu: > > > On Fri, Apr 29, 2022 at 07:31:15AM +0100, Mauro Carvalho Chehab wrote: > > > Sometimes, device drivers are bound using indirect references, >

Re: [Intel-gfx] [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Greg KH
On Fri, Apr 29, 2022 at 10:15:03AM +0100, Mauro Carvalho Chehab wrote: > HI Greg, > > Em Fri, 29 Apr 2022 10:30:33 +0200 > Greg KH escreveu: > > > On Fri, Apr 29, 2022 at 09:07:57AM +0100, Mauro Carvalho Chehab wrote: > > > Hi Daniel, > > > > > >

Re: [Intel-gfx] [PATCH 1/2] module: add a function to add module references

2022-04-29 Thread Greg KH
On Fri, Apr 29, 2022 at 11:23:51AM +0100, Mauro Carvalho Chehab wrote: > Em Fri, 29 Apr 2022 12:10:07 +0200 > Greg KH escreveu: > > > On Fri, Apr 29, 2022 at 10:15:03AM +0100, Mauro Carvalho Chehab wrote: > > > HI Greg, > > > > > > Em Fri, 29 Apr 2

Re: [Intel-gfx] [PATCH v2 1/2] module: update dependencies at try_module_get()

2022-04-30 Thread Greg KH
On Sat, Apr 30, 2022 at 11:30:58AM +0100, Mauro Carvalho Chehab wrote: > Sometimes, device drivers are bound into each other via try_module_get(), > making such references invisible when looking at /proc/modules or lsmod. > > Add a function to allow setting up module references for such > cases, a

Re: [Intel-gfx] [PATCH v3 1/2] module: update dependencies at try_module_get()

2022-04-30 Thread Greg KH
On Sat, Apr 30, 2022 at 02:41:47PM +0100, Mauro Carvalho Chehab wrote: > Sometimes, device drivers are bound into each other via try_module_get(), > making such references invisible when looking at /proc/modules or lsmod. > > Add a function to allow setting up module references for such > cases, a

Re: [Intel-gfx] [PATCH bpf v2] treewide: add missing includes masked by cgroup -> bpf dependency

2021-12-02 Thread Greg KH
On Thu, Dec 02, 2021 at 12:34:00PM -0800, Jakub Kicinski wrote: > cgroup.h (therefore swap.h, therefore half of the universe) > includes bpf.h which in turn includes module.h and slab.h. > Since we're about to get rid of that dependency we need > to clean things up. > > v2: drop the cpu.h include

Re: [Intel-gfx] [PATCH] [v2] Kbuild: move to -std=gnu11

2022-02-28 Thread Greg KH
On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > During a patch discussion, Linus brought up the option of changing > the C standard version from gnu89 to gnu99, which allows using variable > declaration inside of a for() loop. While the C99, C11 and later

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Greg KH
On Mon, Feb 28, 2022 at 12:08:18PM +0100, Jakob Koschel wrote: > If the list does not contain the expected element, the value of > list_for_each_entry() iterator will not point to a valid structure. > To avoid type confusion in such case, the list iterator > scope will be limited to list_for_each_e

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread Greg KH
On Mon, Feb 28, 2022 at 01:06:57PM +0100, Jakob Koschel wrote: > > > > On 28. Feb 2022, at 12:20, Greg KH wrote: > > > > On Mon, Feb 28, 2022 at 12:08:18PM +0100, Jakob Koschel wrote: > >> If the list does not contain the expected element, the value of > &g

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread Greg KH
On Tue, Mar 01, 2022 at 12:28:15PM +0100, Jakob Koschel wrote: > > > > On 1. Mar 2022, at 01:41, Linus Torvalds > > wrote: > > > > On Mon, Feb 28, 2022 at 1:47 PM Jakob Koschel > > wrote: > >> > >> The goal of this is to get compiler warnings right? This would indeed be > >> great. > > >

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread Greg KH
On Tue, Mar 01, 2022 at 06:40:04PM +0100, Jakob Koschel wrote: > > > > On 1. Mar 2022, at 18:36, Greg KH wrote: > > > > On Tue, Mar 01, 2022 at 12:28:15PM +0100, Jakob Koschel wrote: > >> > >> > >>> On 1. Mar 2022, at 01:41, Linus Torval

Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

2022-09-05 Thread Greg KH
On Mon, Sep 05, 2022 at 03:46:09PM +0800, Zheng Hacker wrote: > I rewrote the letter. Hope it works. > > There is a double-free security bug in split_2MB_gtt_entry. > > Here is a calling chain : > ppgtt_populate_spt->ppgtt_populate_shadow_entry->split_2MB_gtt_entry. > If intel_gvt_dma_map_guest_p

Re: [Intel-gfx] [PATCH v4 00/41] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-09-06 Thread Greg KH
On Tue, Sep 06, 2022 at 09:18:09PM +0200, Daniel Vetter wrote: > On Fri, Aug 12, 2022 at 08:03:47AM +0200, Greg KH wrote: > > On Thu, Aug 11, 2022 at 06:52:40PM +0200, Daniel Vetter wrote: > > > On Wed, Aug 03, 2022 at 04:13:05PM -0400, Jason Baron wrote: > > > > &g

Re: [Intel-gfx] [PATCH v6 21/57] dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes

2022-09-07 Thread Greg KH
On Sun, Sep 04, 2022 at 03:40:58PM -0600, Jim Cromie wrote: > Demonstrate use of DECLARE_DYNDBG_CLASSMAP macro, and expose them as > sysfs-nodes for testing. Wait, why sysfs? sysfs isn't for testing, why not use debugfs? > > For each of the 4 class-map-types: > > - declare a class-map of th

Re: [Intel-gfx] [PATCH v6 21/57] dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes

2022-09-07 Thread Greg KH
On Wed, Sep 07, 2022 at 04:54:00PM +0200, Greg KH wrote: > On Sun, Sep 04, 2022 at 03:40:58PM -0600, Jim Cromie wrote: > > Demonstrate use of DECLARE_DYNDBG_CLASSMAP macro, and expose them as > > sysfs-nodes for testing. > > Wait, why sysfs? > > sysfs isn't

Re: [Intel-gfx] [PATCH v6 00/57] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-09-07 Thread Greg KH
On Sun, Sep 04, 2022 at 03:40:37PM -0600, Jim Cromie wrote: > hi Greg, Jason, DRM-folk, Steven, > > If Im not too late for linux-next in this cycle, heres V6. Diffs are minor: > > - rebased onto e47eb90a0a9a (tag: next-20220901, linux-next/master) >gets past Kconfig conflict, same for drm-t

Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

2022-09-08 Thread Greg KH
On Thu, Sep 08, 2022 at 05:09:40PM +0800, Zheng Hacker wrote: > Hi Zhenyu, > > This issue has been open for a few days. Could you plz write a patch > for that :) I'm not familiar with the logical code here. As this is only able to be hit in a theoretical system, it isn't that high of a priority,

Re: [Intel-gfx] [PATCH 04/15] staging/android/ion: delete dma_buf->kmap/unmap implemenation

2019-11-18 Thread Greg KH
On Mon, Nov 18, 2019 at 11:35:25AM +0100, Daniel Vetter wrote: > There's no callers in-tree anymore. > > For merging probably best to stuff this into drm-misc, since that's > where the dma-buf heaps will land too. And the resulting conflict > hopefully ensures that dma-buf heaps wont have a new ->

Re: [Intel-gfx] [PATCH V13 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-18 Thread Greg KH
On Mon, Nov 18, 2019 at 06:59:23PM +0800, Jason Wang wrote: > +static void mvnet_device_release(struct device *dev) > +{ > + dev_dbg(dev, "mvnet: released\n"); > +} We used to have documentation in the kernel source tree that said that whenever anyone did this, I got to make fun of them. Unfo

Re: [Intel-gfx] kernel 5.6: baytrail hdmi audio not working

2020-04-03 Thread Greg KH
On Thu, Apr 02, 2020 at 10:53:36AM -0400, Giacomo Comes wrote: > On Thu, Apr 02, 2020 at 04:52:03PM +0300, Ville Syrjälä wrote: > > On Wed, Apr 01, 2020 at 06:53:17PM -0400, Giacomo Comes wrote: > > > Hi, > > > on my Intel Compute Stick STCK1 (baytrail hdmi audio) > > > sound is not working with t

Re: [Intel-gfx] [PATCH 0/1] drm/i915: Fix a deadlock that only affects 5.4

2020-04-06 Thread Greg KH
On Mon, Apr 06, 2020 at 11:26:21PM -0700, Sultan Alsawaf wrote: > From: Sultan Alsawaf > > Hi, > > There's a mutex lock deadlock in i915 that only affects 5.4, but was fixed in > 5.5. Normally, I would send a backport of the fix from 5.5, but the patch set > that fixes the deadlock involves mass

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-10 Thread Greg KH
On Tue, Apr 07, 2020 at 12:18:09AM -0700, Sultan Alsawaf wrote: > From: Sultan Alsawaf > > The following deadlock exists in i915_active_wait() due to a double lock > on ref->mutex (call chain listed in order from top to bottom): > i915_active_wait(); > mutex_lock_interruptible(&ref->mutex); <--

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-11 Thread Greg KH
On Fri, Apr 10, 2020 at 07:17:38AM -0700, Sultan Alsawaf wrote: > On Fri, Apr 10, 2020 at 11:08:38AM +0200, Greg KH wrote: > > On Tue, Apr 07, 2020 at 12:18:09AM -0700, Sultan Alsawaf wrote: > > > From: Sultan Alsawaf > > > > > > The following deadlock e

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-14 Thread Greg KH
On Tue, Apr 14, 2020 at 09:15:07AM +0100, Chris Wilson wrote: > Quoting Greg KH (2020-04-11 12:39:57) > > On Fri, Apr 10, 2020 at 07:17:38AM -0700, Sultan Alsawaf wrote: > > > On Fri, Apr 10, 2020 at 11:08:38AM +0200, Greg KH wrote: > > > > On Tue, Apr 07, 2020 at 12

Re: [Intel-gfx] [PATCH 3/3] kernel: set USER_DS in kthread_use_mm

2020-04-15 Thread Greg KH
On Thu, Apr 16, 2020 at 07:31:58AM +0200, Christoph Hellwig wrote: > Some architectures like arm64 and s390 require USER_DS to be set for > kernel threads to access user address space, which is the whole purpose > of kthread_use_mm, but other like x86 don't. That has lead to a huge > mess where so

Re: [Intel-gfx] [PATCH 2/3] kernel: better document the use_mm/unuse_mm API contract

2020-04-15 Thread Greg KH
On Thu, Apr 16, 2020 at 07:31:57AM +0200, Christoph Hellwig wrote: > Switch the function documentation to kerneldoc comments, and add > WARN_ON_ONCE asserts that the calling thread is a kernel thread and > does not have ->mm set (or has ->mm set in the case of unuse_mm). > > Also give the function

Re: [Intel-gfx] [PATCH stable v5.2] drm/i915/vbt: Fix VBT parsing for the PSR section

2019-07-24 Thread Greg KH
On Mon, Jul 22, 2019 at 04:13:25PM -0700, Dhinakaran Pandiyan wrote: > A single 32-bit PSR2 training pattern field follows the sixteen element > array of PSR table entries in the VBT spec. But, we incorrectly define > this PSR2 field for each of the PSR table entries. As a result, the PSR1 > traini

Re: [Intel-gfx] [PATCH stable v5.2] drm/i915/vbt: Fix VBT parsing for the PSR section

2019-07-30 Thread Greg KH
On Tue, Jul 30, 2019 at 08:19:08AM -0700, Rodrigo Vivi wrote: > Hi Greg, > > On Wed, Jul 24, 2019 at 10:40:29AM -0700, Rodrigo Vivi wrote: > > On Wed, Jul 24, 2019 at 05:27:42PM +, Souza, Jose wrote: > > > On Wed, 2019-07-24 at 14:06 +0200, Greg KH wrote: > > >

Re: [Intel-gfx] [PATCH stable v5.2] drm/i915/vbt: Fix VBT parsing for the PSR section

2019-07-30 Thread Greg KH
On Tue, Jul 30, 2019 at 09:22:07AM -0700, Rodrigo Vivi wrote: > On Tue, Jul 30, 2019 at 05:27:24PM +0200, Greg KH wrote: > > On Tue, Jul 30, 2019 at 08:19:08AM -0700, Rodrigo Vivi wrote: > > > Hi Greg, > > > > > > On Wed, Jul 24, 2019 at 10:40:29AM -0700, Rod

Re: [Intel-gfx] [PATCH stable v5.2] drm/i915/vbt: Fix VBT parsing for the PSR section

2019-07-30 Thread Greg KH
On Tue, Jul 30, 2019 at 09:56:59AM -0700, Rodrigo Vivi wrote: > > On Tue, Jul 30, 2019 at 06:27:09PM +0200, Greg KH wrote: > > On Tue, Jul 30, 2019 at 09:22:07AM -0700, Rodrigo Vivi wrote: > > > On Tue, Jul 30, 2019 at 05:27:24PM +0200, Greg KH wrote: > > > > O

Re: [Intel-gfx] [PATCH stable-5.10] drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4

2021-01-25 Thread Greg KH
On Mon, Jan 25, 2021 at 03:27:11PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > commit 1c4995b0a576d24bb7ead991fb037c8b47ab6e32 upstream. > > Let's not enable the 4:4:4->4:2:0 conversion bit in the DFP unless we're > actually outputting YCbCr 4:4:4. It would appear some protocol > conve

Re: [Intel-gfx] [PATCH stable-5.4] drm/i915: Correctly set SFC capability for video engines

2020-11-17 Thread Greg KH
On Mon, Nov 16, 2020 at 04:03:26PM -0800, Daniele Ceraolo Spurio wrote: > From: Venkata Sandeep Dhanalakota > > Commit 5ce6861d36ed5207aff9e5eead4c7cc38a986586 upstream. > > This backport targets stable version 5.4, since the original patch fails > to apply there, due to a variable having moved

Re: [Intel-gfx] [PATCH stable-5.10 2/2] drm/i915: Skip vswing programming for TBT

2021-02-11 Thread Greg KH
On Mon, Feb 08, 2021 at 07:53:41PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > commit eaf5bfe37db871031232d2bf2535b6ca92afbad8 upstream. > > In thunderbolt mode the PHY is owned by the thunderbolt controller. > We are not supposed to touch it. So skip the vswing programming > as well (

Re: [Intel-gfx] -stable regression in Intel graphics, introduced in Linux 5.10.9

2021-02-28 Thread Greg KH
On Sun, Feb 28, 2021 at 03:29:07PM +0100, Diego Calleja wrote: > Hi, > > There is a regression in Linux 5.10.9 that does not happen in 5.10.8. It is > still there as > of 5.11.1 Is this the same issue reported here: https://lore.kernel.org/r/f1070486-891a-8ec0-0390-b9aeb0317...@redhat.c

Re: [Intel-gfx] -stable regression in Intel graphics, introduced in Linux 5.10.9

2021-02-28 Thread Greg KH
On Sun, Feb 28, 2021 at 05:28:06PM +0100, Hans de Goede wrote: > Hi, > > On 2/28/21 4:14 PM, Greg KH wrote: > > On Sun, Feb 28, 2021 at 03:29:07PM +0100, Diego Calleja wrote: > >> Hi, > >> > >> There is a regression in Linux 5.10.9 that does not ha

Re: [Intel-gfx] -stable regression in Intel graphics, introduced in Linux 5.10.9

2021-03-01 Thread Greg KH
On Sun, Feb 28, 2021 at 09:05:45PM +0100, Diego Calleja wrote: > El domingo, 28 de febrero de 2021 16:14:54 (CET) Greg KH escribió: > > Is this the same issue reported here: > > > > https://lore.kernel.org/r/f1070486-891a-8ec0-0390-b9aeb0317...@redhat.com > > ?

Re: [Intel-gfx] -stable regression in Intel graphics, introduced in Linux 5.10.9

2021-03-01 Thread Greg KH
On Mon, Mar 01, 2021 at 11:11:13AM +0100, Diego Calleja wrote: > El lunes, 1 de marzo de 2021 10:09:10 (CET) Greg KH escribió: > > I do not see all 3 commits in Linus's tree already, am I missing > > something? > > > > What are the git ids that you are looking at?

Re: [Intel-gfx] linux-next: manual merge of the extcon tree with the drm-misc tree

2020-10-06 Thread Greg KH
On Tue, Oct 06, 2020 at 08:00:03PM +1100, Stephen Rothwell wrote: > Hi all, > > On Thu, 10 Sep 2020 14:18:54 +1000 Stephen Rothwell > wrote: > > > > Today's linux-next merge of the extcon tree got a conflict in: > > > > MAINTAINERS > > > > between commit: > > > > f61249dddecc ("MAINTAINER

Re: [Intel-gfx] [PATCH] drm/atomic: Take the atomic toys away from X

2020-05-08 Thread Greg KH
On Fri, May 08, 2020 at 11:06:56AM +0200, Yves-Alexis Perez wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On Thu, 2019-09-05 at 20:53 +0200, Daniel Vetter wrote: > > The -modesetting ddx has a totally broken idea of how atomic works: > > - doesn't disable old connectors, assuming

Re: [Intel-gfx] [PATCH] drm/atomic: Take the atomic toys away from X

2020-05-08 Thread Greg KH
On Fri, May 08, 2020 at 01:59:17PM +0200, Yves-Alexis Perez wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On Fri, 2020-05-08 at 11:54 +0200, Greg KH wrote: > > > Hi Daniel and Greg (especially). It seems that this patch was never > > > applied

Re: [Intel-gfx] [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-12 Thread Greg KH
On Wed, May 13, 2020 at 07:19:21AM +0530, ashwin-h wrote: > From: Linus Torvalds > > commit 594cc251fdd0d231d342d88b2fdff4bc42fb0690 upstream. > > Originally, the rule used to be that you'd have to do access_ok() > separately, and then user_access_begin() before actually doing the > direct (opti

Re: [Intel-gfx] [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-12 Thread Greg KH
On Wed, May 13, 2020 at 06:13:17AM +, Ashwin H wrote: > This patch fixes CVE-2018-20669 in 4.19 tree. Ok, but what does that mean for us? You need to say why you are sending a patch, otherwise we will guess wrong. greg k-h ___ Intel-gfx mailing lis

Re: [Intel-gfx] [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-27 Thread Greg KH
On Wed, May 13, 2020 at 05:08:19PM +, Ashwin H wrote: > > Ok, but what does that mean for us? > > > > You need to say why you are sending a patch, otherwise we will guess wrong. > > In drivers/gpu/drm/i915/i915_gem_execbuffer.c, ioctl functions does > user_access_begin() without doing access

Re: [Intel-gfx] [PATCH 09/13] firmware_loader: simplify sysctl declaration with register_sysctl_subdir()

2020-05-29 Thread Greg KH
On Fri, May 29, 2020 at 07:41:04AM +, Luis Chamberlain wrote: > From: Xiaoming Ni > > Move the firmware config sysctl table to fallback_table.c and use the > new register_sysctl_subdir() helper. This removes the clutter from > kernel/sysctl.c. > > Signed-off-by: Xiaoming Ni > Signed-off-by:

Re: [Intel-gfx] [PATCH 11/13] random: simplify sysctl declaration with register_sysctl_subdir()

2020-05-29 Thread Greg KH
On Fri, May 29, 2020 at 07:41:06AM +, Luis Chamberlain wrote: > From: Xiaoming Ni > > Move random_table sysctl from kernel/sysctl.c to drivers/char/random.c > and use register_sysctl_subdir() to help remove the clutter out of > kernel/sysctl.c. > > Signed-off-by: Xiaoming Ni > Signed-off-by

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Make Wa_14010229206 permanent

2020-06-19 Thread Greg KH
On Thu, Jun 18, 2020 at 01:27:00PM -0700, Rodrigo Vivi wrote: > From: Swathi Dhanavanthri > > commit 63d0f3ea8ebb67160eca281320d255c72b0cb51a upstream. > > This workaround now applies to all steppings, not just A0. > Wa_1409085225 is a temporary A0-only W/A however it is > identical to Wa_140102

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Make Wa_14010229206 permanent

2020-06-23 Thread Greg KH
On Fri, Jun 19, 2020 at 01:14:04PM -0700, Rodrigo Vivi wrote: > On Fri, Jun 19, 2020 at 10:09:00AM +0200, Greg KH wrote: > > On Thu, Jun 18, 2020 at 01:27:00PM -0700, Rodrigo Vivi wrote: > > > From: Swathi Dhanavanthri > > > > > > commit 63d0f3ea8ebb6

Re: [Intel-gfx] [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread Greg KH
On Wed, Aug 19, 2020 at 07:00:53AM -0600, Jens Axboe wrote: > On 8/18/20 1:00 PM, James Bottomley wrote: > > On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: > >> On 8/17/20 12:48 PM, Kees Cook wrote: > >>> On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote: > On 8/17/20 12:29 PM,

Re: [Intel-gfx] [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread Greg KH
On Wed, Aug 19, 2020 at 07:17:19AM -0600, Jens Axboe wrote: > On 8/19/20 6:11 AM, Greg KH wrote: > > On Wed, Aug 19, 2020 at 07:00:53AM -0600, Jens Axboe wrote: > >> On 8/18/20 1:00 PM, James Bottomley wrote: > >>> On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wro

Re: [Intel-gfx] [PATCH] mm: Track page table modifications in __apply_to_page_range() construction

2020-08-21 Thread Greg KH
On Fri, Aug 21, 2020 at 12:09:02PM +0200, Joerg Roedel wrote: > The __apply_to_page_range() function is also used to change and/or > allocate page-table pages in the vmalloc area of the address space. > Make sure these changes get synchronized to other page-tables in the > system by calling arch_sy

Re: [Intel-gfx] [PATCH 2/4] drm/i915/gt: Wait for CSB entries on Tigerlake

2020-09-15 Thread Greg KH
On Tue, Sep 15, 2020 at 01:41:48PM +0100, Chris Wilson wrote: > On Tigerlake, we are seeing a repeat of commit d8f505311717 ("drm/i915/icl: > Forcibly evict stale csb entries") where, presumably, due to a missing > Global Observation Point synchronisation, the write pointer of the CSB > ringbuffer

Re: [Intel-gfx] [PATCH 2/4] drm/i915/gt: Wait for CSB entries on Tigerlake

2020-09-16 Thread Greg KH
On Wed, Sep 16, 2020 at 09:26:58AM +0100, Chris Wilson wrote: > Quoting Greg KH (2020-09-16 07:33:58) > > On Tue, Sep 15, 2020 at 01:41:48PM +0100, Chris Wilson wrote: > > > On Tigerlake, we are seeing a repeat of commit d8f505311717 > > > ("drm/i915/icl: > &

Re: [Intel-gfx] [PATCH 0/4] Backported vlv fixes for 4.7.y

2016-08-22 Thread Greg KH
On Mon, Aug 22, 2016 at 11:31:31AM -0400, Lyude wrote: > Hope this didn't take too long! Here's the backported versions of the patches > you had trouble applying to stable. The patch for FBC won't be necessary as > that is already present in 4.7.y. > > Cheers, > Lyude Thanks, but what are t

Re: [Intel-gfx] [PATCH 0/4] Backported vlv fixes for 4.7.y

2016-09-05 Thread Greg KH
On Mon, Aug 29, 2016 at 05:27:38PM -0400, Lyude Paul wrote: > drm/i915/vlv: Make intel_crt_reset() per-encoder: > 4570d833390b10043d082fe535375d4a0e071d9c > drm/i915/vlv: Reset the ADPA in vlv_display_power_well_init(): > 4c732e6ee9e71903934d75b12a021eb3520b6197 > drm/i915/vlv: Disable HPD in valle

Re: [Intel-gfx] The i915 stable patch marking is totally broken

2017-04-12 Thread Greg KH
On Mon, Mar 13, 2017 at 07:49:59AM +0100, Daniel Vetter wrote: > On Sun, Mar 12, 2017 at 10:52 PM, Greg KH wrote: > > Why don't the maintainers know which tree to put them in when they are > > submitted? As an example, if I get a patch that needs to go to Linus, I > &

Re: [Intel-gfx] The i915 stable patch marking is totally broken

2017-04-12 Thread Greg KH
On Wed, Apr 12, 2017 at 02:48:55PM +0200, Greg KH wrote: > On Mon, Mar 13, 2017 at 07:49:59AM +0100, Daniel Vetter wrote: > > On Sun, Mar 12, 2017 at 10:52 PM, Greg KH > > wrote: > > > Why don't the maintainers know which tree to put them in when they are > >

Re: [Intel-gfx] [STABLE v4.18 BACKPORT] drm/i915: set DP Main Stream Attribute for color range on DDI platforms

2018-09-12 Thread Greg KH
On Wed, Sep 12, 2018 at 04:59:10PM +0300, Jani Nikula wrote: > commit 6209c285e7a5e68dbcdf8fd2456c6dd68433806b upstream. Thanks for the backport, now queued up. greg k-h ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedeskt

Re: [Intel-gfx] [STABLE v4.14 PATCH] drm/i915: set DP Main Stream Attribute for color range on DDI platforms

2018-09-17 Thread Greg KH
On Fri, Sep 14, 2018 at 04:39:42PM +0300, Jani Nikula wrote: > commit 6209c285e7a5e68dbcdf8fd2456c6dd68433806b upstream. Now applied, thanks. greg k-h ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listi

Re: [Intel-gfx] [stable:v4.15] drm/i915/dp: Write to SET_POWER dpcd to enable MST hub.

2018-04-03 Thread Greg KH
On Tue, Apr 03, 2018 at 10:27:16AM +0300, Jani Nikula wrote: > > DK, please start stable backport commit messages with: > > commit b1e314462bba76660eec62760bb2e87f28f58866 upstream. Thank you for that, it helped me figure this out... greg k-h ___ Inte

Re: [Intel-gfx] drm/i915 4.5/4.6 stable backport request for CHV

2016-06-04 Thread Greg KH
On Fri, May 27, 2016 at 11:30:30AM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Several nasty i915 regressions affecting CHV slipped through > to 4.5 and 4.6. > > The first fix we want in 4.5 and 4.6 is > commit caed361d83b2 ("drm/i915: Fix watermarks for VLV/CHV") > It

Re: [Intel-gfx] drm/i915 4.5/4.6 stable backport request for CHV

2016-06-22 Thread Greg KH
On Wed, Jun 22, 2016 at 03:55:03PM +0200, Daniel Vetter wrote: > On Mon, Jun 6, 2016 at 11:32 AM, Ville Syrjälä > wrote: > > On Sat, Jun 04, 2016 at 02:06:58PM -0700, Greg KH wrote: > >> On Fri, May 27, 2016 at 11:30:30AM +0300, ville.syrj...@linux.intel.com > >

Re: [Intel-gfx] [PATCH 0/5] drm/i915/skl: Backport watermark fixes for 4.8.y

2016-10-28 Thread Greg KH
On Wed, Oct 26, 2016 at 03:36:32PM -0400, Lyude wrote: > Now that these have finally made it into 4.9, it's time to finally backport > these fixes. Skylake has been a mess in multi-monitor setups for a while now > because up until recently we've been updating the watermarks on Skylake just > like w

Re: [Intel-gfx] xrandr fails after resume from hibernation in kernels 4.7.4 and 4.8.0

2016-10-28 Thread Greg KH
On Fri, Oct 07, 2016 at 10:38:17AM -0300, Gaston Gonzalez wrote: > On Wed, Oct 05, 2016 at 07:23:23AM +0200, Greg KH wrote: > > On Tue, Oct 04, 2016 at 08:43:03PM -0300, Gaston Gonzalez wrote: > > > Hi, > > > > > > After hibernation I get the follow

Re: [Intel-gfx] xrandr fails after resume from hibernation in kernels 4.7.4 and 4.8.0

2016-10-29 Thread Greg KH
On Sat, Oct 29, 2016 at 10:13:25AM -0300, Gaston Gonzalez wrote: > On Fri, Oct 28, 2016 at 07:23:24PM +0300, Ville Syrjälä wrote: > > On Fri, Oct 28, 2016 at 11:53:40AM -0400, Greg KH wrote: > > > On Fri, Oct 07, 2016 at 10:38:17AM -0300, Gaston Gonzalez wrote: > > > &

Re: [Intel-gfx] [PATCH] DRM: i915: Fix gen8 graphics on Broadwell-U. These patches stop the random gpu hang on my XPS-13-9343, kernel version 4.8-rc5.

2016-09-14 Thread Greg KH
On Thu, Sep 15, 2016 at 11:12:08AM +0800, bobcao3 wrote: > Signed-off-by: bobcao3 > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 6 > drivers/gpu/drm/i915/i915_gem_stolen.c | 61 > - > drivers/gpu/drm/i915/i915_reg.h | 6 > drivers/gpu/drm/

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gen9: unconditionally apply the memory bandwidth WA

2016-10-11 Thread Greg KH
On Tue, Oct 11, 2016 at 10:34:14AM +0300, Jani Nikula wrote: > On Mon, 10 Oct 2016, Paulo Zanoni wrote: > > Mahesh Kumar is already working on a proper implementation for the > > workaround, but while we still don't have it, let's just > > unconditionally apply the workaround for everybody and we

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gen9: unconditionally apply the memory bandwidth WA

2016-10-11 Thread Greg KH
On Tue, Oct 11, 2016 at 01:54:09PM +0300, Jani Nikula wrote: > On Tue, 11 Oct 2016, Greg KH wrote: > > On Tue, Oct 11, 2016 at 10:34:14AM +0300, Jani Nikula wrote: > >> On Mon, 10 Oct 2016, Paulo Zanoni wrote: > >> The patch is a bit on the large side for stable. 100

Re: [Intel-gfx] [PATCH 4.1, 4.2] drm/i915: Silence DDR DVFS errors on CHV

2015-10-17 Thread Greg KH
On Mon, Sep 28, 2015 at 10:09:11PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > commit 58590c14d80defc94e900308a9d8fa55284de6f2 upstream. This is not the commit id of the patch below at all, I can't take this, please be more careful in the future. thanks, greg k-h >

Re: [Intel-gfx] [PATCH 4.1, 4.2] drm/i915: Silence DDR DVFS errors on CHV

2015-10-19 Thread Greg KH
On Mon, Oct 19, 2015 at 11:02:35AM +0300, Jani Nikula wrote: > On Sat, 17 Oct 2015, Greg KH wrote: > > On Mon, Sep 28, 2015 at 10:09:11PM +0300, ville.syrj...@linux.intel.com > > wrote: > >> From: Ville Syrjälä > >> > >> commit 58590c14d80defc94e900308

  1   2   >