Re: [Intel-gfx] [PATCH v6 RESEND 1/3] gpu: drm: separate panel orientation property creating and value setting

2021-07-15 Thread Enric Balletbo Serra
Hi Hsin-Yi, Thank you for your patch. Missatge de Hsin-Yi Wang del dia dj., 24 de juny 2021 a les 12:55: > > drm_dev_register() sets connector->registration_state to > DRM_CONNECTOR_REGISTERED and dev->registered to true. If > drm_connector_set_panel_orientation() is first called after > drm_dev

Re: [Intel-gfx] [PATCH v6 RESEND 2/3] drm/mediatek: init panel orientation property

2021-07-15 Thread Enric Balletbo Serra
Hi Hsin-Yi, Thank you for your patch. Missatge de Hsin-Yi Wang del dia dj., 24 de juny 2021 a les 12:55: > > Init panel orientation property after connector is initialized. Let the > panel driver decides the orientation value later. > > Signed-off-by: Hsin-Yi Wang > Acked-by: Chun-Kuang Hu Te

Re: [Intel-gfx] [PATCH v6 RESEND 3/3] arm64: dts: mt8183: Add panel rotation

2021-07-15 Thread Enric Balletbo Serra
Hi Hsin-Yi, Thank you for the patch. Missatge de Hsin-Yi Wang del dia dj., 27 de maig 2021 a les 9:42: > > krane, kakadu, and kodama boards have a default panel rotation. > > Signed-off-by: Hsin-Yi Wang It looks good to me, so Reviewed-by: Enric Balletbo i Serra and, on a Lenovo IdeaPad Due

Re: [Intel-gfx] [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-15 Thread Enric Balletbo Serra
Hi Neil, I suspect that this patch will conflict with some patches that will be queued for 4.18 that also introduces new devices, well, for now I don't see these merged in the Lee's tree. Based on some reviews I got when I send a patch to this file ... 2018-05-15 17:29 GMT+02:00 Hans Verkuil : >

Re: [Intel-gfx] [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-18 Thread Enric Balletbo Serra
2018-05-18 15:05 GMT+02:00 Neil Armstrong : > The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device > when the CEC feature bit is present. > > Signed-off-by: Neil Armstrong > --- > drivers/mfd/cros_ec_dev.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/

Re: [Intel-gfx] [PATCH v2 0/5] Add ChromeOS EC CEC Support

2018-05-18 Thread Enric Balletbo Serra
Hi Neil, 2018-05-18 15:04 GMT+02:00 Neil Armstrong : > Hi All, > > The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support > through it's Embedded Controller, to enable the Linux CEC Core to communicate > with it and get the CEC Physical Address from the correct HDMI Connector, th

Re: [Intel-gfx] [PATCH v2 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-18 Thread Enric Balletbo Serra
Hi Neil, 2018-05-18 15:05 GMT+02:00 Neil Armstrong : > The Chrome OS Embedded Controller can expose a CEC bus, this patch add the A minor nit, there is a "consensus" on tell cros-ec as "ChromeOS Embedded Controller" or "ChromeOS EC". Yes, I know that you can see in the kernel many other ways to r

Re: [Intel-gfx] [PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-18 Thread Enric Balletbo Serra
Hi Neil, 2018-05-18 15:05 GMT+02:00 Neil Armstrong : > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > Having a 16 byte mkbp event size makes it possible to send CEC > messages from the EC to the AP directly inside the mkbp event > ins

Re: [Intel-gfx] [PATCH v4 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-22 Thread Enric Balletbo Serra
Hi Neil, 2018-05-21 16:21 GMT+02:00 Neil Armstrong : > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > Having a 16 byte mkbp event size makes it possible to send CEC > messages from the EC to the AP directly inside the mkbp event > ins