On Tue, Jun 21, 2016 at 09:25:36PM +0100, Chris Wilson wrote:
> On Tue, Jun 21, 2016 at 07:34:34PM +0200, Egbert Eich wrote:
> > When the hw cursors are not disabled before the cursor planes get disabled
> > we may lose the cursor later on. Thus make sure the cursors are disabled
When the hw cursors are not disabled before the cursor planes get disabled
we may lose the cursor later on. Thus make sure the cursors are disabled
before the cursor planes are.
Signed-off-by: Egbert Eich
---
src/sna/sna_display.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/sna
In intel_sdvo_get_lvds_modes() the wrong i2c adapter record is used
for DDC. Thus the code will always have to rely on a LVDS panel
mode supplied by VBT.
In most cases this succeeds, so this didn't get detected for quite
a while.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_s
On Tue, May 21, 2013 at 05:17:27PM +0200, Egbert Eich wrote:
> On Wed, May 08, 2013 at 12:50:24PM +0300, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > Follow the same sequence when enabling the cursor plane during
> > modeset. No point in do
gt; >> commit 53d3b4d7778daf15900867336c85d3f8dd70600c
> > >> Author: Egbert Eich
> > >> Date: Tue Jun 4 17:13:21 2013 +0200
> > >>
> > >> drm/i915/sdvo: Use &intel_sdvo->ddc instead of intel_sdvo->i2c for
> > >&g
h a bit of refactoring. This patch is the very first step
> since in the end the irq storm handling code will handle all hotplug
> logic (and so also encapsulate the locking nicely).
>
> Cc: Egbert Eich
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/i915/i915_
Daniel Vetter writes:
> Everywhere the same.
>
> Cc: Egbert Eich
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/i915/i915_irq.c | 11 +++
> 1 file changed, 3 insertions(+), 8 deletions(-)
[reviewed code deleted]
Rev
Daniel Vetter writes:
> The usual pattern for our sub-function irq_handlers is that they check
> for the no-irq case themselves. This results in more streamlined code
> in the upper irq handlers.
>
> Cc: Egbert Eich
> Signed-off-by: Daniel Vetter
> ---
> drivers
y for pipestate, display
> interrupts and all the various gt interrupts).
>
> Cc: Egbert Eich
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/i915/i915_irq.c | 15 ++-
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers
Daniel Vetter writes:
> We already have a vfunc for this (and other parts of the hpd storm
> handling code already use it).
>
> Cc: Egbert Eich
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/i915/i915_irq.c | 29 +++--
> 1 fil
Daniel Vetter writes:
> On Sun, Jul 21, 2013 at 10:23 PM, Jan Niggemann wrote:
> >> But every time this happens we only let through a few interrupts, so this
> >> shouldn't affect you badly. Can you please check whether those slowdowns
> >> line up with 2 minute intervalls?
> >
> > I observe
oming thru although they
should be disabled.
Could you try if the patch below makes any difference?
Cheers,
Egbert.
>From 70dae32e99799d15ddcedd5853514215624a8289 Mon Sep 17 00:00:00 2001
From: Egbert Eich
Date: Mon, 22 Jul 2013 22:33:36 +0200
Subject: [PATCH] drm/i915: Make sure PORT_HOTPLU
Hi Jan -
Jan Niggemann writes:
>
> As to the log: I messed up the kernel parameters this morning... was
> out of coffee this morning and my 1,5y daughter played around me :-)
>
> Here's my kernel log with drm.debug and printk.time enabled:
> Uncompressed (22M): http://files.hz6.de/kern_2
Hi Jan!
Jan Niggemann writes:
> Hi Egbert,
[...]
Thanks for generating the logs! Hope you had a nice birthday dinner :)
>
> I applied this patch (but not the one you sent on Monday), recompiled
> and logged:
> uncompressed (8,2M) http://files.hz6.de/kern_20130724.log
> bz2 (288 KB) htt
Daniel Vetter writes:
>
> I've checked the docs again for gm45 and we seem to have the right
> values. But on early gen4 (i.e. i965g/gm) the Bspec has been wrong
> about these, so I wouldn't be surprised at all if they're wrong for
> the digital ports on gm45, too.
>
> Iirc we've already h
Jan Niggemann writes:
> Hi Daniel,
>
> Am 25.07.2013 11:58, schrieb Daniel Vetter:
> > Can you pls try the below
> > patch (on top of Egbert's debug stuff)?
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h
> > b/drivers/gpu/drm/i915/i915_reg.h
> > index 6caa748..2d4c884 100644
> > --
For HPD storm detection we now mask out individual interrupt source
bits. We have already seen a case where HPD interrupt enable bits
were assigned to the wrong pins. To track these conditions more
easily add some debugging messages.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915
Add posting read to make sure PORT_HOTPLUG_EN is written in
i915_hpd_irq_setup().
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 1f3a971..a38372b 100644
Chris Wilson writes:
> On Fri, Jul 26, 2013 at 12:31:30PM +0200, Egbert Eich wrote:
> > Add posting read to make sure PORT_HOTPLUG_EN is written in
> > i915_hpd_irq_setup().
>
> It's not vital that the write be flushed here. On the deferred reenable
> path a fur
: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index ee3e49c..6a1c207 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -919,6 +919,10
ne hotplug interrupt
> handling scheme.
>
> This WARN has been introduced in
>
> commit b8f102e8bf71cacf33326360fdf9dcfd1a63925b
> Author: Egbert Eich
> Date: Fri Jul 26 14:14:24 2013 +0200
>
> drm/i915: Add messages useful for HPD storm detection debugg
wins.
Eventually when intel_sdvo_detect() is called the active connector is
determined.
Delay encoder type initialization until the active connector is known
and set it to the type that corresponds to this connector.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_sdvo.c | 23
intel_connector_break_all_links()
is called) where this may lead to an inconsistent driver state.
The following two patches fix both situations.
Egbert Eich (2):
drm/i915: Only break encoder linked when linked to connector
drm/i915: Set up SDVO encoder type only at detect
drivers/gpu/drm/i915
== NULL).
To avoid this break the encoder links only if the connector is active
(ie. has drm_connector->encoder set).
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_display.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/dr
Chris Wilson writes:
> On Mon, Apr 14, 2014 at 07:26:08PM +0200, Egbert Eich wrote:
> > Depending on the SDVO output_flags SDVO may have multiple connectors
> > linking to the same encoder (in intel_connector->encoder->base).
> > Only one of those connectors shoul
the SDVO connector setup functions
as suggested by Chris Wilson .
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_sdvo.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c
b/drivers/gpu/drm/i915/intel_sdvo.c
Daniel Vetter writes:
> On Mon, Apr 14, 2014 at 07:26:09PM +0200, Egbert Eich wrote:
> > Depending on the SDVO output_flags SDVO may have multiple connectors.
> > These are all initialized in intel_sdvo_output_setup(). The connector
> > that is initialized later will over
Daniel Vetter writes:
>
> Hm, I think to address Chris' concern we should split this into two
> pieces: connector_break_all links which only breaks connector->encoder
> stuff, used in both places as is. And a new encoder_break_all links which
> we'll use in sanitize_crtc in a new encoder loop
e. in intel_sanitize_crtc() we can break the
crtc link separatly after the links to the encoders have been
broken which avoids above problem.
Signed-off-by: Egbert Eich
v2: This patch takes care of the concernes voiced by Chris Wilson
and Daniel Vetter that only breaking links if the drm_connecto
Bail out if crtc is NULL to keep the driver from crashing.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_display.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index c276733..dfebced 100644
drm/i915: read out the modeset hw state at load and resume time
so goes back to the very beginning of the modeset rework.
Signed-off-by: Egbert Eich
Reviewed-by: Daniel Vetter
Cc: sta...@vger.kernel.org
Cc: Jani Nikula
v2: This patch takes care of the concernes voiced by Chris Wilson
and Daniel
sysfs symlink to the connector's directory
This is the same what we do for DP connectors, so make things more
consistent.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_sdvo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel
Hi Jiri,
Just found your email, it got missed do to a temporary inaccessibility to
my email.
Jiri Kosina writes:
> On Thu, 3 Oct 2013, Daniel Vetter wrote:
>
> > Can you please attach full dmesg from boot up to the first WARN with
> > drm.debug=0xe? This really shouldn't happen and indicates
Jiri Kosina writes:
> On Mon, 21 Oct 2013, Egbert Eich wrote:
>
> > > On Thu, 3 Oct 2013, Daniel Vetter wrote:
> > >
> > > > Can you please attach full dmesg from boot up to the first WARN with
> > > > drm.debug=0xe? This really shouldn&
ropose those changes at a later time.
Egbert Eich (12):
DRM/i915: Remove valleyview_hpd_irq_setup.
DRM/I915: Add enum hpd_pin to intel_encoder.
DRM/i915: Convert HPD interrupts to make use of HPD pin assignment in
encoders.
DRM/i915: Remove i965_hpd_irq_setup.
DRM/i915: Get rid if the &#
n the i915 code path. These are considered harmless.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 53 +-
1 files changed, 18 insertions(+), 35 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
ind
It's basically identical to i915_hpd_irq_setup().
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 26 +-
1 files changed, 1 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 2c
This allows to enable HPD interrupts for individual pins to only receive
hotplug events from lines which are connected and working.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 160 --
drivers/gpu/drm/i915/i915_reg.h | 32 -
2
level.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_drv.h | 13 +
drivers/gpu/drm/i915/intel_crt.c |2 ++
drivers/gpu/drm/i915/intel_dp.c |4
drivers/gpu/drm/i915/intel_drv.h |1 +
drivers/gpu/drm/i915/intel_hdmi.c |4
drivers/gpu/drm
cy on the selected video mode.
Also on certain laptops interrupt noise seems to occur duing
battery charging when the battery is at a certain charge levels.
Thus we add a simple algorithm here that detects an 'interrupt storm'
condition.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/
o the default value, the HPD interrupts are marked
enabled.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 13 +
drivers/gpu/drm/i915/intel_crt.c |6 ++
drivers/gpu/drm/i915/intel_dp.c |1 -
drivers/gpu/drm/i915/intel_drv.h |4
drivers/gp
Now since we have replaced the bits to show interest in hotplug IRQs
we can go and nuke the 'hotplug_supported_mask'.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_drv.h |1 -
drivers/gpu/drm/i915/intel_crt.c |2 --
drivers/gpu/drm/i915/intel_dp.c |3 ---
d
When switching to enabling HPD IRQs only for lines where needed and supported
this will ensure that the right lines will be enabled on all generations when
intel_hpd_init() is called.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 10 +-
1 files changed, 5 insertions
s and fall back to periodic
device polling.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 69 ++-
1 files changed, 53 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index e0cf62
after a certain grace period (2 minutes).
Should the interrupt storm persist it will be detected immediately
and it will be disabled again.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_drv.h |2 +
drivers/gpu/drm/i915/i915_irq.c | 53 ++-
2
This way it is possible to limit 're'-detect() of displays to connectors
which have received an HPD event.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_drv.h |1 +
drivers/gpu/drm/i915/i915_irq.c | 10 ++
2 files changed, 11 insertions(+), 0 deletions(-)
di
Instead of calling into the DRM helper layer to poll all connectors for
changes in connected displays probe only those connectors which have
received a hotplug event.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 37 +++--
1 files changed, 31
This allows to enable HPD interrupts for individual pins to only receive
hotplug events from lines which are connected and working.
v2: Restructured initailization of const arrays following a suggstion
by Chris Wilson
Signed-off-by: Egbert Eich
Acked-by: Chris Wilson
---
drivers/gpu/drm
occur duing
battery charging when the battery is at a certain charge levels.
Thus we add a simple algorithm here that detects an 'interrupt storm'
condition.
v2: Fixed comment.
Signed-off-by: Egbert Eich
Acked-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.h |9 +
drive
briefly
enabling the cursor plane.
Signed-off-by: Egbert Eich
Bugzilla: https://bugs.freedesktop.org/attachment.cgi?bugid=61457
Acked-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_display.c | 28 +++-
1 files changed, 27 insertions(+), 1 deletions(-)
diff --git a
occur duing
battery charging when the battery is at a certain charge levels.
Thus we add a simple algorithm here that detects an 'interrupt storm'
condition.
v2: Fixed comment.
v3: Reordered drm_i915_private: moved hpd state tracking to hotplug work stuff.
Signed-off-by: Egbert Eich
after a certain grace period (2 minutes).
Should the interrupt storm persist it will be detected immediately
and it will be disabled again.
v2: Reordered drm_i915_private: moved hotplug_reenable_timer to hpd state
tracker.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_drv.h |2
This way it is possible to limit 're'-detect() of displays to connectors
which have received an HPD event.
v2: Reordered drm_i915_private: Move hpd_event_bits to hpd state tracking.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_drv.h |1 +
drivers/gpu/drm/i915/i915_ir
and Haswell,
Restructured loop to avoid deep nesting (all suggested by Ville Syrjälä)
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_drv.h |2 +
drivers/gpu/drm/i915/i915_irq.c | 53 ++-
2 files changed, 54 insertions(+), 1 deletions(-)
diff
s and fall back to periodic
device polling.
v2: Fixed cleanup typo.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 69 ++-
1 files changed, 53 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/
This way it is possible to limit 're'-detect() of displays to connectors
which have received an HPD event.
v2: Reordered drm_i915_private: Move hpd_event_bits to hpd state tracking.
v3: Fix patch.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_drv.h |1 +
drivers/gp
On Tue, Mar 05, 2013 at 08:00:30AM -0500, Egbert Eich wrote:
> This way it is possible to limit 're'-detect() of displays to connectors
> which have received an HPD event.
>
> v2: Reordered drm_i915_private: Move hpd_event_bits to hpd state tracking.
> v3: Fix patch.
&g
Instead of calling into the DRM helper layer to poll all connectors for
changes in connected displays probe only those connectors which have
received a hotplug event.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 37 +++--
1 files changed, 31
i915.ko does not build due to the following function in i915_debugfs.c:
i915_min_freq_set(void *data, u64 val)
{
...
dev_priv->rps.min_delay = val / GT_FREQUENCY_MULTIPLIER;
...
}
Doing a 64bit integer division on 32bit requires a
compiler run time library to be linked in,
Daniel Vetter writes:
> On Mon, Feb 25, 2013 at 12:06:52PM -0500, Egbert Eich wrote:
> > Now since we have replaced the bits to show interest in hotplug IRQs
> > we can go and nuke the 'hotplug_supported_mask'.
> >
> > Signed-off-by: Egbert Eich
>
Sorry for replying so late, I wasn't able to task switch my brain
towards this when it was discussed:
Daniel Vetter writes:
> diff --git a/drivers/gpu/drm/i915/i915_irq.c
> b/drivers/gpu/drm/i915/i915_irq.c
> index 43436e0..1279a44 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/driv
Hi Daniel,
Daniel Vetter writes:
> On Fri, Mar 29, 2013 at 5:35 PM, Egbert Eich wrote:
>
> Yeah, makes sense now that I think about it - I've simply didn't look
> ahead in your patch series while writing this little fixup ;-) Can you
> just re-add this when res
From: Egbert Eich
The connector associated with the encoder is considered active when the
output associtated with this connector is active on the encoder. The
encoder itself is considered active when either there is an active
output on it or the respective SDVO channel is active.
Having active
This set of patches contains the remaining bits to add IRQ strom detection and
disabling.
Daniel has asked me to send this batch as soon as possible even though this
latest batch has not yet been retested, yet.
Egbert Eich (7):
drm/i915: Add HPD IRQ storm detection (v4)
drm/i915: (re)init
From: Egbert Eich
Add a hotplug IRQ storm detection (triggered when a hotplug interrupt
fires more than 5 times / sec).
Rationale:
Despite of the many attempts to fix the problem with noisy hotplug
interrupt lines we are still seeing systems which have issues:
Once cause of noise seems to be bad
From: Egbert Eich
When an encoder is shared on several connectors there is only
one hotplug line, thus this line needs to be shared among these
connectors.
If HPD detect only works reliably on a subset of those connectors,
we want to poll the others. Thus we need to make sure that storm
From: Egbert Eich
To disable previously enabled HPD IRQs we need to reset them and
set the enabled ones individually.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915
From: Egbert Eich
This way it is possible to limit 're'-detect() of displays to connectors
which have received an HPD event.
v2: Reordered drm_i915_private: Move hpd_event_bits to hpd state tracking.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gp
From: Egbert Eich
Instead of calling into the DRM helper layer to poll all connectors for
changes in connected displays probe only those connectors which have
received a hotplug event.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 37 +++--
1
From: Egbert Eich
We disable hoptplug detection when we encounter a hotplug event
storm. Still hotplug detection is required on some outputs (like
Display Port). The interrupt storm may be only temporary (on certain
Dell Laptops for instance it happens at certain charging states of
the system
From: Egbert Eich
This patch disables hotplug interrupts if an 'interrupt storm'
has been detected.
Noise on the interrupt line renders the hotplug interrupt useless:
each hotplug event causes the devices to be rescanned which will
will only increase the system load.
Thus disable t
On Thu, Apr 11, 2013 at 01:44:51PM +0300, Jani Nikula wrote:
> > +
> > + spin_lock_irqsave(&dev_priv->irq_lock, irqflags);
> > + for (i = (HPD_NONE + 1); i < HPD_NUM_PINS; i++) {
> > + struct drm_connector *connector;
> > +
> > + if (dev_priv->hpd_stats[i].hpd_mark != HPD_MA
s and fall back to periodic
device polling.
v2: Fixed cleanup typo.
v3: Fixed format issues, clarified a variable name,
changed pr_warn() to DRM_INFO() as suggested by
Jani Nikula .
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 75 +++
and Haswell,
Restructured loop to avoid deep nesting (all suggested by Ville Syrjälä)
v4: Fixed two bugs pointed out by Jani Nikula.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 50 +
2 files
On Thu, Apr 11, 2013 at 04:21:54PM +0300, Jani Nikula wrote:
> > }
> > + if (hpd_event_bits & (1 << intel_encoder->hpd_pin)) {
> > + DRM_DEBUG_KMS("Connector %s (pin %i) received hotplug
> > event.\n",
> > + drm_get_connector_
This way it is possible to limit 're'-detect() of displays to connectors
which have received an HPD event.
v2: Reordered drm_i915_private: Move hpd_event_bits to hpd state tracking.
v3: Fixed merge conflicts with previous patches.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/
Instead of calling into the DRM helper layer to poll all connectors for
changes in connected displays probe only those connectors which have
received a hotplug event.
Signed-off-by: Egbert Eich
Reviewed-by: Jani Nikula
v2: Resolved conflicts with changes in previous commits.
Renamed
ed by Jani Nikula.
Signed-off-by: Egbert Eich
---
(Sorry for the spam, I had accidenty went the wrong version of this patch)
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 12
2 files changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/d
ontradiction.
Sorry for the late reply - last week I was quite busy with other stuff,
this week i'm a bit preoccupied.
>
> On Tue, 09 Apr 2013, Egbert Eich wrote:
> > From: Egbert Eich
> >
> > Add a hotplug IRQ storm detection (triggered when a hotplug interru
Hi Jani,
I've rebased and regenerated all the patches now, as there
were some other bikesheds i had not adressed. I've also
included all Reviewed-By:
This should make it easier to integrate the patches.
Some comments below:
On Thu, Apr 11, 2013 at 12:32:29PM +0300, Jani Nikula wrote:
> > +
to use a time_..() macro.
v5: Fixed coding style as suggested by Jani Nikula.
Signed-off-by: Egbert Eich
Acked-by: Chris Wilson
Reviewed-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_drv.h | 9 ++
drivers/gpu/drm/i915/i915_irq.c | 69 ++---
2 files changed
o the default value, the HPD interrupts are marked
enabled.
Signed-off-by: Egbert Eich
Reviewed-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_irq.c | 14 ++
drivers/gpu/drm/i915/intel_crt.c | 6 ++
drivers/gpu/drm/i915/intel_dp.c | 1 -
drivers/gpu/drm/i915/intel_drv.h
To disable previously enabled HPD IRQs we need to reset them and
set the enabled ones individually.
Signed-off-by: Egbert Eich
Reviewed-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_irq.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm
s and fall back to periodic
device polling.
v2: Fixed cleanup typo.
v3: Fixed format issues, clarified a variable name,
changed pr_warn() to DRM_INFO() as suggested by
Jani Nikula .
Signed-off-by: Egbert Eich
Reviewed-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_
and Haswell,
Restructured loop to avoid deep nesting (all suggested by Ville Syrjälä)
v4: Fixed two bugs pointed out by Jani Nikula.
Signed-off-by: Egbert Eich
Reviewed-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 52
ed by Jani Nikula.
Signed-off-by: Egbert Eich
Reviewed-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 11 +++
2 files changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 195b9fe..c0d9
Instead of calling into the DRM helper layer to poll all connectors for
changes in connected displays probe only those connectors which have
received a hotplug event.
Signed-off-by: Egbert Eich
Reviewed-by: Jani Nikula
v2: Resolved conflicts with changes in previous commits.
Renamed
On Tue, Apr 16, 2013 at 08:07:09PM +0200, Daniel Vetter wrote:
> On Tue, Apr 16, 2013 at 01:36:58PM +0200, Egbert Eich wrote:
> > We disable hoptplug detection when we encounter a hotplug event
> > storm. Still hotplug detection is required on some outputs (like
> > Display
On Fri, May 03, 2013 at 02:22:09PM +0300, Imre Deak wrote:
> Currently the driver's assumed behavior for a modeset with an attached
> FB is that the corresponding connector will be switched to DPMS ON mode
> if it happened to be in DPMS OFF (or another power save mode). This
> wasn't enforced thoug
power save mode outside the the
test for fb change: user space may have just disabled the encoders
but left everything else in place. Make sure the connector list is
not empty before running this test.
Signed-off-by: Imre Deak
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_disp
ipe);
>
As discussed on IRC this may interfere with
commit 61bc95c1fbbb6a08b55bbe161fdf1ea5493fc595
Author: Egbert Eich
Date: Mon Mar 4 09:24:38 2013 -0500
DRM/i915: On G45 enable cursor plane briefly after enabling the display
plane.
described in https://bugs.freedesktop.org/show_bu
>
> > Therefore:
> >
> > Acked-by: Egbert Eich
> >
Cheers,
Egbert.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
6651819b4b4fc3caa6964c5d825eb4bb996f3905
Author: Daniel Vetter
Date: Sun Apr 1 19:16:18 2012 +0200
drm/i915: handle input/output sdvo timings separately in mode_set
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_sdvo.c |8
1 files changed, 8 insertions(+), 0 deletions
SDVO LVDS are not clonable as the input mode gets adjusted by
the LVDS encoder.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_sdvo.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c
b/drivers/gpu/drm/i915/intel_sdvo.c
NCR machines with LVDS panels using Intel chipsets need to have the
QUIRK_INVERT_BRIGHTNESS bit set.
Unfortunately NCR doesn't set a meaningful subvendor/subdevice ID,
therefore we add a DMI dependent quirk list.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_display.c |
setup for clone modes.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_crt.c | 15 +--
1 files changed, 1 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
index c42b980..ae3a3d5 100644
--- a/drivers/gpu/drm/i915
hotplug needed to be recorded
for each connector.
- The interrupt enable functions needed to be separate, also they need
to be able to enable interrupts for each hotplug line independently.
Egbert Eich (8):
drm/i915: Remove pch_rq_mask from struct drm_i915_private.
drm/i915: Se
So far the hotplug_supported_mask in the struct drm_i915_private
is only used for pre-Ironlake chipsets.
This patch sets up the correct value for all generations.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_drv.h |4 ++
drivers/gpu/drm/i915/i915_irq.c | 71
cy on the selected video mode.
Also on certain laptops interrupt noise seems to occur duing
battery charging when the battery is at a certain charge levels.
Thus we add a simple algorithm here that detects an 'interrupt storm'
condition.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/
To be able to map an HPD interrupt to a connector add the
hpd status bit to the intel_connector structure.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_crt.c |3 ++-
drivers/gpu/drm/i915/intel_dp.c |3 ++-
drivers/gpu/drm/i915/intel_drv.h |3 +++
drivers/gpu/drm
1 - 100 of 141 matches
Mail list logo
