d in
i915_drm.h, and they start from the LSB and work up.
Other flags are defined in i915_gem_execbuffer, for internal use within
that file only; they start from the MSB and work down.
So here we add a compile-time check that the two sets of flags do not
overlap, which would cause all sorts of confus
"list_entry(eb->vmas.prev, ...)"
in the old version of eb_get_batch() with the equivalent but more explicit
"list_last_entry(&eb->vmas,...)"
in the new eb_get_batch_vma() and of course add an explanatory comment.
Signed-off-by: Dave Gor
transfers information from the
static table of (all) known engines to the dev_priv->engine array of
engines available on this device (adjusting the names along the way)
and then embed calls to it in both the LRC and the legacy-mode setup.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i91
On 30/06/16 13:49, Tvrtko Ursulin wrote:
On 30/06/16 11:22, Chris Wilson wrote:
On Thu, Jun 30, 2016 at 09:50:20AM +0100, Tvrtko Ursulin wrote:
On 30/06/16 02:35, Hong Liu wrote:
Return the allocated request pointer directly to remove
the double pointer parameter.
Signed-off-by: Hong Liu
-
platform.
Signed-off-by: Tvrtko Ursulin
Cc: Dave Gordon
---
drivers/gpu/drm/i915/intel_guc_loader.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c
b/drivers/gpu/drm/i915/intel_guc_loader.c
index 4f6311a91a7e
drm/i915/intel_tv.c| 12 +-
drivers/gpu/drm/i915/intel_uncore.c| 2 +-
47 files changed, 708 insertions(+), 709 deletions(-)
Looks fine :)
Reviewed-by: Dave Gordon
I found three more to convert, plus one place where we can delete
some entirely redundant locals, b
Also remove some redundant dev and dev_priv locals
Signed-off-by: Dave Gordon
Cc: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.c | 4 ++--
drivers/gpu/drm/i915/intel_display.c| 4
drivers/gpu/drm/i915/intel_guc_loader.c | 2 +-
3 files changed, 3 insertions(+), 7 deletions
On 04/07/16 05:08, Liu, Hong wrote:
On Fri, 2016-07-01 at 19:34 +0100, Chris Wilson wrote:
On Fri, Jul 01, 2016 at 05:58:18PM +0100, Dave Gordon wrote:
On 30/06/16 13:49, Tvrtko Ursulin wrote:
On 30/06/16 11:22, Chris Wilson wrote:
On Thu, Jun 30, 2016 at 09:50:20AM +0100, Tvrtko Ursulin
ick and easy fix for the GuC loading code and the whole area can
be evaluated afterwards.
Signed-off-by: Tvrtko Ursulin
Reported-by: Chris Wilson
Cc: Dave Gordon
---
drivers/gpu/drm/i915/intel_guc_loader.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/d
On 05/07/16 12:56, Tvrtko Ursulin wrote:
On 05/07/16 12:50, Dave Gordon wrote:
On 04/07/16 15:30, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
At the moment HAS_GUC_UCODE == HAS_GUC == IS_GEN9 ==
(INTEL_INFO(dev)->gen_mask & BIT(8)), which is true but not one. And
module paramet
On 05/07/16 09:51, Chris Wilson wrote:
Since drm_i915_private is now a subclass of drm_device we do not need to
chase the drm_i915_private->dev backpointer and can instead simply
access drm_i915_private->drm directly.
text data bss dec hex filename
10687574565 4
On 29/06/16 18:59, Rodrigo Vivi wrote:
On Wed, Jun 29, 2016 at 7:31 AM, Dave Gordon wrote:
On 29/06/16 00:03, Rodrigo Vivi wrote:
I don't believe we need to be that extreme here.
Daniel asked a cleaner version, but we don't need to block the huc on
a full rework of an unified
ill need rebasing (again), but it's
only a simple conflict with recent patches. Apart from that, its OK now, so:
Reviewed-by: Dave Gordon
(which you can carry over to the rebased version).
---
drivers/gpu/drm/i915/i915_debugfs.c| 12 +--
drivers/gpu/drm/i915/i915_guc_subm
"list_entry(eb->vmas.prev, ...)"
in the old version of eb_get_batch() with the equivalent but more explicit
"list_last_entry(&eb->vmas,...)"
in the new eb_get_batch_vma() and of course add an explanatory comment.
Signed-off-by: Dave Gor
d in
i915_drm.h, and they start from the LSB and work up.
Other flags are defined in i915_gem_execbuffer, for internal use within
that file only; they start from the MSB and work down.
So here we add a compile-time check that the two sets of flags do not
overlap, which would cause all sorts of confus
that as-is, because that interface doesn't quite
match what we need here).
Signed-off-by: Dave Gordon
Cc: Tvrtko Ursulin
Cc: Chris Wilson
---
drivers/gpu/drm/i915/i915_guc_submission.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_guc_s
So this patch just provides and uses names for the values
representing the DEFAULT, DISABLED, PREFERRED, and MANDATORY
options that the user can select (-1, 0, 1, 2 respectively).
This should produce identical code to the previous version!
Signed-off-by: Dave Gordon
Cc: Tvrtko Ursulin
---
Where we're going to continue regardless of the problem, rather than
fail, then the message should be a WARNing rather than an ERROR.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/i915_guc_submission.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --
underlying macro that does all the token-pasting.
DRM_ERROR is unchanged, as it's not just a printk wrapper.
Signed-off-by: Dave Gordon
---
include/drm/drmP.h | 26 --
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
Some downgraded from DRM_ERROR() to DRM_WARN(), some eliminated,
and a few upgraded from DRM_INFO() to DRM_NOTE() or DRM_WARN().
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/intel_guc_loader.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a
On 11/07/16 20:58, Chris Wilson wrote:
On Mon, Jul 11, 2016 at 06:12:40PM +0100, Dave Gordon wrote:
The existing code that accesses the "enable_guc_loading" and
"enable_guc_submission" parameters uses explicit numerical
values for the various possibilities, including in s
On 12/07/16 10:20, Tvrtko Ursulin wrote:
On 11/07/16 19:01, Dave Gordon wrote:
Where we're going to continue regardless of the problem, rather than
fail, then the message should be a WARNing rather than an ERROR.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/i915_guc_submiss
On 12/07/16 10:06, Tvrtko Ursulin wrote:
On 11/07/16 19:01, Dave Gordon wrote:
We had only DRM_INFO() and DRM_ERROR(), whereas the underlying printk()
provides several other useful intermediate levels such as NOTICE and
WARNING. So this patch fills out the set by providing both regular and
On 12/07/16 15:25, Daniel Vetter wrote:
On Mon, Jul 11, 2016 at 07:01:27PM +0100, Dave Gordon wrote:
We had only DRM_INFO() and DRM_ERROR(), whereas the underlying printk()
provides several other useful intermediate levels such as NOTICE and
WARNING. So this patch fills out the set by providing
On 12/07/16 10:26, Tvrtko Ursulin wrote:
On 11/07/16 19:01, Dave Gordon wrote:
Some downgraded from DRM_ERROR() to DRM_WARN(), some eliminated,
and a few upgraded from DRM_INFO() to DRM_NOTE() or DRM_WARN().
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/intel_guc_loader.c | 20
underlying macro that does all the token-pasting.
DRM_ERROR is unchanged, as it's not just a printk wrapper.
v2:
Fix whitespace, missing ## (Eric Engestrom)
Signed-off-by: Dave Gordon
Reviewed-by: Eric Engestrom
---
include/drm/drmP.h | 26 --
1 file change
Where we're going to continue regardless of the problem, rather than
fail, then the message should be a WARNing rather than an ERROR.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/i915_guc_submission.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --
the log with developer-only details.
v2: different permutation of levels :)
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/intel_guc_loader.c | 34 -
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c
b
So this patch just provides and uses names for the values
representing the DEFAULT, DISABLED, PREFERRED, and MANDATORY
options that the user can select (-1, 0, 1, 2 respectively).
This should produce identical code to the previous version!
Signed-off-by: Dave Gordon
Cc: Tvrtko Ursulin
---
On 13/07/16 14:16, Tvrtko Ursulin wrote:
On 13/07/16 13:23, Daniel Vetter wrote:
On Fri, Jul 01, 2016 at 05:47:11PM +0100, Tvrtko Ursulin wrote:
From: Dave Gordon
[snip]
{
-const struct logical_ring_info *info = &logical_rings[id];
+const struct engine_info *
On 13/07/16 13:44, Chris Wilson wrote:
On Wed, Jul 13, 2016 at 02:38:16PM +0200, Daniel Vetter wrote:
On Thu, Jun 30, 2016 at 04:12:49PM +0100, Dave Gordon wrote:
Precursor for fix to secure batch execution. We will need to be able to
retrieve the batch VMA (as well as the batch itself) from
On 13/07/16 14:38, Patchwork wrote:
== Series Details ==
Series: drm/i915/guc: Protect against HAS_GUC_* returning true values other
than one (rev4)
URL : https://patchwork.freedesktop.org/series/9473/
State : warning
== Summary ==
Series 9473v4 drm/i915/guc: Protect against HAS_GUC_* retur
"list_entry(eb->vmas.prev, ...)"
in the old version of eb_get_batch() with the equivalent but more
explicit
"list_last_entry(&eb->vmas,...)"
in the new eb_get_batch_vma() and of course add an explanatory comment.
Signed-off-by: Dave Gordon
Reviewed-by: D
d in
i915_drm.h, and they start from the LSB and work up.
Other flags are defined in i915_gem_execbuffer, for internal use within
that file only; they start from the MSB and work down.
So here we add a compile-time check that the two sets of flags do not
overlap, which would cause all sorts of confus
On 13/07/16 13:48, Daniel Vetter wrote:
On Thu, Jun 23, 2016 at 02:52:41PM +0100, Peter Antoine wrote:
On Thu, 23 Jun 2016, Dave Gordon wrote:
On 22/06/16 09:31, Daniel Vetter wrote:
No, the *correct* fix is to unify all the firmware loaders we have.
There should just be ONE piece of code that
On 14/07/16 15:16, Daniel Vetter wrote:
On Wed, Jul 13, 2016 at 03:52:39PM +0100, Peter Antoine wrote:
On Wed, 13 Jul 2016, Daniel Vetter wrote:
On Thu, Jun 23, 2016 at 02:52:41PM +0100, Peter Antoine wrote:
On Thu, 23 Jun 2016, Dave Gordon wrote:
On 22/06/16 09:31, Daniel Vetter wrote:
No
On 14/07/16 15:26, Daniel Vetter wrote:
On Thu, Jul 14, 2016 at 03:08:41PM +0100, Dave Gordon wrote:
On 13/07/16 13:48, Daniel Vetter wrote:
On Thu, Jun 23, 2016 at 02:52:41PM +0100, Peter Antoine wrote:
On Thu, 23 Jun 2016, Dave Gordon wrote:
On 22/06/16 09:31, Daniel Vetter wrote:
No, the
On 14/07/16 15:03, Chris Wilson wrote:
On Thu, Jul 14, 2016 at 02:12:55PM +0100, Dave Gordon wrote:
On 13/07/16 13:44, Chris Wilson wrote:
On Wed, Jul 13, 2016 at 02:38:16PM +0200, Daniel Vetter wrote:
On Thu, Jun 30, 2016 at 04:12:49PM +0100, Dave Gordon wrote:
Precursor for fix to secure
On 15/07/16 09:15, Patchwork wrote:
== Series Details ==
Series: series starting with [CI,resend,1/2] drm/i915: compile-time consistency
check on __EXEC_OBJECT flags
URL : https://patchwork.freedesktop.org/series/9876/
State : failure
== Summary ==
Series 9876v1 Series without cover letter
On 18/07/16 12:35, Chris Wilson wrote:
On Mon, Jul 18, 2016 at 12:15:32PM +0100, Tvrtko Ursulin wrote:
I am not sure about this, but looking at the raid6 for example, it
has a lot more annotations in cases like this.
It seems to be telling the compiler which memory ranges does each
instruction
On 18/07/16 13:29, Daniel Vetter wrote:
On Mon, Jul 18, 2016 at 11:43:08AM -, Patchwork wrote:
== Series Details ==
Series: drm/i915: Treat eDP as always connected, again
URL : https://patchwork.freedesktop.org/series/9977/
State : failure
== Summary ==
Series 9977v1 drm/i915: Treat eDP
On 18/07/16 13:50, Dave Gordon wrote:
On 18/07/16 13:29, Daniel Vetter wrote:
On Mon, Jul 18, 2016 at 11:43:08AM -, Patchwork wrote:
== Series Details ==
Series: drm/i915: Treat eDP as always connected, again
URL : https://patchwork.freedesktop.org/series/9977/
State : failure
On 18/07/16 13:56, Tvrtko Ursulin wrote:
On 18/07/16 12:57, Dave Gordon wrote:
On 18/07/16 12:35, Chris Wilson wrote:
On Mon, Jul 18, 2016 at 12:15:32PM +0100, Tvrtko Ursulin wrote:
I am not sure about this, but looking at the raid6 for example, it
has a lot more annotations in cases like
On 18/07/16 16:06, Tvrtko Ursulin wrote:
On 18/07/16 14:46, Tvrtko Ursulin wrote:
[snip]
This version generates the smallest code:
static void __memcpy_ntdqa(struct qw2 *dst, const struct qw2 *src, unsigned
long len)
{
unsigned long l4;
kernel_fpu_begin();
l4 = len
underlying macro that does all the token-pasting.
DRM_ERROR is unchanged, as it's not just a printk wrapper.
v2:
Fix whitespace, missing ## (Eric Engestrom)
Signed-off-by: Dave Gordon
Reviewed-by: Eric Engestrom
---
include/drm/drmP.h | 26 --
1 file change
Some downgraded from DRM_ERROR() to DRM_WARN() or DRM_NOTE(),
a few upgraded from DRM_INFO() to DRM_NOTE() or DRM_WARN(),
and one eliminated completely.
v2: different permutation of levels :)
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/intel_guc_loader.c | 34
Where we're going to continue regardless of the problem, rather than
fail, then the message should be a WARNing rather than an ERROR.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/i915_guc_submission.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --
abled, avoiding those that are marked as in use by any client.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/i915_guc_submission.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c
b/drivers/gpu/drm/i915/i915_guc_submission.c
workqueue slots.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/i915_debugfs.c| 25 -
drivers/gpu/drm/i915/i915_guc_submission.c | 35 +++---
drivers/gpu/drm/i915/intel_guc.h | 2 +-
3 files changed, 42 insertions(+), 20
e that
the client is associated with.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/i915_guc_submission.c | 15 ++-
drivers/gpu/drm/i915/intel_guc.h | 3 ++-
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c
b/drive
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/i915_guc_submission.c | 54 +-
1 file changed, 30 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c
b/drivers/gpu/drm/i915/i915_guc_submission.c
index d8402e4..dc5f485 100644
ore than once or twice, hopefully eliminating memory
references.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/i915_debugfs.c| 17 +
drivers/gpu/drm/i915/i915_guc_submission.c | 22 +-
2 files changed, 22 insertions(+), 17 deletions(-)
diff --git a
On 19/07/16 08:05, Daniel Vetter wrote:
On Mon, Jul 04, 2016 at 11:30:06AM -0400, Jeff Mahoney wrote:
This fixes the following build error with -Werror and gcc 6.1:
drivers/gpu/drm/i915/i915_debugfs.c:2103:6: error: suggest explicit braces to
avoid ambiguous 'else' [-Werror=parentheses]
Signe
On 19/07/16 14:53, Patchwork wrote:
== Series Details ==
Series: series starting with [CI-RESEND,1/3] drm: extra printk() wrapper macros
URL : https://patchwork.freedesktop.org/series/10036/
State : success
== Summary ==
Series 10036v1 Series without cover letter
http://patchwork.freedesktop
On 19/07/16 15:16, Patchwork wrote:
== Series Details ==
Series: series starting with [1/5] drm/i915/guc: doorbell reset should avoid
used doorbells
URL : https://patchwork.freedesktop.org/series/10040/
State : failure
== Summary ==
Series 10040v1 Series without cover letter
http://patchwor
On 19/07/16 16:02, Tvrtko Ursulin wrote:
On 19/07/16 13:59, Dave Gordon wrote:
When using a single GuC client for multiple engines, the i915 driver has
to merge all work items into a single work queue, which the GuC firmware
then demultiplexes into separate submission queues per engine. In
On 19/07/16 15:26, Tvrtko Ursulin wrote:
On 19/07/16 13:20, Dave Gordon wrote:
Some downgraded from DRM_ERROR() to DRM_WARN() or DRM_NOTE(),
a few upgraded from DRM_INFO() to DRM_NOTE() or DRM_WARN(),
and one eliminated completely.
v2: different permutation of levels :)
Signed-off-by: Dave
sulin].
Signed-off-by: Dave Gordon
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/intel_guc_loader.c | 34 -
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c
b/drivers/gpu/drm/i915/intel_guc_loader.
underlying macro that does all the token-pasting.
DRM_ERROR is unchanged, as it's not just a printk wrapper.
v2:
Fix whitespace, missing ## (Eric Engestrom)
Signed-off-by: Dave Gordon
Reviewed-by: Eric Engestrom
Cc: dri-de...@lists.freedesktop.org
---
include/drm/drmP.h
Where we're going to continue regardless of the problem, rather than
fail, then the message should be a WARNing rather than an ERROR.
Signed-off-by: Dave Gordon
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_guc_submission.c | 18 +++---
1 file changed, 7 inser
On 15/07/16 14:13, Tvrtko Ursulin wrote:
On 29/06/16 17:00, Chris Wilson wrote:
On Wed, Jun 29, 2016 at 04:41:58PM +0100, Tvrtko Ursulin wrote:
On 29/06/16 16:34, Chris Wilson wrote:
On Wed, Jun 29, 2016 at 04:09:31PM +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Replace per-engine in
On 14/07/16 15:15, Daniel Vetter wrote:
I forgot to remove these when reworking the firmware loading sequence
last year. The new sequence is that we load firmware, and if it's not
there we entirely (and permanently) fail dmc setup.
Reported-by: Dave Gordon
Signed-off-by: Daniel V
drm_gem_object_lookup(file_priv,
- put_image_rec->bo_handle));
- if (&new_bo->base == NULL) {
+ new_bo = i915_gem_object_lookup(file_priv, put_image_rec->bo_handle);
+ if (!new_bo) {
ret = -ENOENT;
goto out_free;
}
LGTM.
Reviewed-by: Dave Gordon
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
ary->state));
- work->pending_flip_obj = obj;
+ work->pending_flip_obj = i915_gem_object_get(obj);
ret = i915_mutex_lock_interruptible(dev);
if (ret)
This last one moves the point at which the reference is taken past
several function calls; is that intentional, or at least harmless?
With that answered, then
Reviewed-by: Dave Gordon
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 20/07/16 12:43, Joonas Lahtinen wrote:
On ke, 2016-07-20 at 09:59 +0100, Chris Wilson wrote:
diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c
b/drivers/gpu/drm/i915/intel_guc_loader.c
index 605c69658d2c..75a1496ceb6f 100644
--- a/drivers/gpu/drm/i915/intel_guc_loader.c
+++ b/drivers/gpu
| 4 ++--
3 files changed, 8 insertions(+), 9 deletions(-)
Just mechanical transformations with no issues that I can see, so
Reviewed-by: Dave Gordon
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 38d9ae90b613..0fef5cda4aca 100644
--- a/drivers/gpu/drm/i915
On 20/07/16 10:54, Tvrtko Ursulin wrote:
On 19/07/16 19:38, Dave Gordon wrote:
On 15/07/16 14:13, Tvrtko Ursulin wrote:
On 29/06/16 17:00, Chris Wilson wrote:
On Wed, Jun 29, 2016 at 04:41:58PM +0100, Tvrtko Ursulin wrote:
On 29/06/16 16:34, Chris Wilson wrote:
On Wed, Jun 29, 2016 at 04
On 20/07/16 13:50, Chris Wilson wrote:
On Wed, Jul 20, 2016 at 03:49:00PM +0300, Joonas Lahtinen wrote:
On ke, 2016-07-20 at 12:05 +, Patchwork wrote:
== Series Details ==
Series: series starting with [1/2] drm/i915/gen9: Add WaInPlaceDecompressionHang
URL : https://patchwork.freedesktop
On 20/07/16 14:11, Chris Wilson wrote:
Having ringbuf->ring point to an engine is confusing, so rename it once
again to ring->engine.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Doesn't do what i
On 20/07/16 14:11, Chris Wilson wrote:
Now that we have disambuigated ring and engine, we can use the clearer
and more consistent name for the intel_ringbuffer pointer in the
request.
Signed-off-by: Chris Wilson
You missed a few instances of 'ring' meaning engine:
i915_gem_execbuffer.c:
On 20/07/16 15:12, Dave Gordon wrote:
On 20/07/16 14:11, Chris Wilson wrote:
Now that we have disambuigated ring and engine, we can use the clearer
and more consistent name for the intel_ringbuffer pointer in the
request.
Signed-off-by: Chris Wilson
You missed a few instances of '
On 20/07/16 14:02, Patchwork wrote:
== Series Details ==
Series: series starting with [CI,1/9] drm/i915: Rename request
reference/unreference to get/put
URL : https://patchwork.freedesktop.org/series/10089/
State : failure
== Summary ==
Series 10089v1 Series without cover letter
http://patc
On 20/07/16 17:07, Tvrtko Ursulin wrote:
On 20/07/16 13:50, Dave Gordon wrote:
On 20/07/16 10:54, Tvrtko Ursulin wrote:
On 19/07/16 19:38, Dave Gordon wrote:
On 15/07/16 14:13, Tvrtko Ursulin wrote:
On 29/06/16 17:00, Chris Wilson wrote:
On Wed, Jun 29, 2016 at 04:41:58PM +0100, Tvrtko
Chris Wilson is trying to convert 'ringbuffer' to 'ring', but at present
there's rather too much legacy code using 'ring' for various other things,
usually engines or engine-ids. This patchset converts some of them (but
not as yet the gpu_error or trace code).
Chris: what is your prefered name for
'ring' is an old deprecated term for a GPU engine. Here we make the
terminology more consistent by renaming the 'ring' parameter of lots of
macros that calculate addresses within the MMIO space of an engine.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/i91
&engine);
- if (ret)
- return ret;
with
+ engine = eb_select_engine(dev_priv, file, args);
+ if (!engine)
+ return -EINVAL;
for increased clarity and maybe save a few cycles too.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i9
parameters called 'ring' to either 'engine' or 'engine_id' according to
what they actually are.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/intel_mocs.c | 6 +++---
drivers/gpu/drm/i915/intel_mocs.h | 2 +-
drivers/gpu/drm/i915/intel_ri
On 21/07/16 10:31, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Static table wastes space for invalid combinations and
engines which are not supported by Gen6 (legacy semaphores).
Replace it with a function devised by Dave Gordon.
I have verified that it generates the same mappings between
splatted in the recent
s/drm_gem_object_unreference/i915_gem_object_put/
where the _unlocked suffix was lost in this one case.
Also fixes a whitespace glitch introduced in the same commit.
Fixes: f8c417cd drm/i915: Rename drm_gem_object_unreference in preparation ...
Signed-off-by: Dave Gordon
C
On 21/07/16 11:38, Tvrtko Ursulin wrote:
On 20/07/16 22:07, Rodrigo Vivi wrote:
please kill this _ucode variation that is just a alias to guc instead
Not sure, it was added with a particular goal. Cc Dave in case he wants
to comment.
Regards,
Tvrtko
The comment is already in the source
rence in preparation ...
Signed-off-by: Dave Gordon
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_overlay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_overlay.c
b/drivers/gpu/drm/i915/intel_overlay.c
index 8654a32..c10ce36 100644
-
workqueue slots.
Dave Gordon (6):
drm/i915/guc: doorbell reset should avoid used doorbells
drm/i915/guc: refactor guc_init_doorbell_hw()
drm/i915/guc: use a separate GuC client for each engine
drm/i915/guc: add engine mask to GuC client & pass to GuC
drm/i915/guc: use for_each_engin
abled, avoiding those that are marked as in use by any client.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/i915_guc_submission.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c
b/drivers/gpu/drm/i915/i915_guc_submission.c
workqueue slots.
Signed-off-by: Dave Gordon
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c| 25 -
drivers/gpu/drm/i915/i915_guc_submission.c | 35 +++---
drivers/gpu/drm/i915/intel_guc.h | 2 +-
3 files changed
We have essentially the same code in each of two different loops, so we
can refactor it into a little helper function.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/i915_guc_submission.c | 54 +-
1 file changed, 30 insertions(+), 24 deletions(-)
diff --git a
e that
the client is associated with.
Signed-off-by: Dave Gordon
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_guc_submission.c | 15 ++-
drivers/gpu/drm/i915/intel_guc.h | 3 ++-
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/gp
ore than once or twice, hopefully eliminating memory
references.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/i915_debugfs.c| 17 +
drivers/gpu/drm/i915/i915_guc_submission.c | 22 +-
2 files changed, 22 insertions(+), 17 deletions(-)
diff --git a
As we're tweaking the GuC-related code in debugfs, we can
drop the now-used 'q_fail' and repack the structure.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/i915_debugfs.c | 1 -
drivers/gpu/drm/i915/intel_guc.h| 6 ++
2 files changed, 2 insertions(+), 5 deletions(-
A few adjustments to the messages emitted from the driver, promoting
or demoting them to the level most suited to the target audience as
well as the impact of the thing being reported.
Dave Gordon (3):
drm: extra printk() wrapper macros
drm/i915/guc: downgrade some DRM_ERROR() messages to
Where we're going to continue regardless of the problem, rather than
fail, then the message should be a WARNing rather than an ERROR.
Signed-off-by: Dave Gordon
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_guc_submission.c | 18 +++---
1 file changed, 7 inser
underlying macro that does all the token-pasting.
DRM_ERROR is unchanged, as it's not just a printk wrapper.
v2:
Fix whitespace, missing ## (Eric Engestrom)
Signed-off-by: Dave Gordon
Reviewed-by: Eric Engestrom
Cc: dri-de...@lists.freedesktop.org
---
include/drm/drmP.h
Some downgraded from DRM_ERROR() to DRM_WARN() or DRM_NOTE(),
a few upgraded from DRM_INFO() to DRM_NOTE() or DRM_WARN(),
and one eliminated completely.
v2: different permutation of levels :)
v3: convert a couple of "this shouldn't happen" messages to WARN()
Signed-off-by: Dave G
On 21/07/16 19:30, Chris Wilson wrote:
On Thu, Jul 21, 2016 at 07:15:39PM +0100, Dave Gordon wrote:
When using a single GuC client for multiple engines, the i915 driver has
to merge all work items into a single work queue, which the GuC firmware
then demultiplexes into separate submission
On 22/07/16 11:04, Tvrtko Ursulin wrote:
On 21/07/16 19:15, Dave Gordon wrote:
Now that host structures are indexed by host engine-id rather than
guc_id, we can usefully convert some for_each_engine() loops to use
for_each_engine_id() and avoid multiple dereferences of engine->id.
Also a
On 22/07/16 10:40, Antoine, Peter wrote:
-Original Message-
From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
Sent: Friday, July 22, 2016 10:38 AM
To: Antoine, Peter
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [I-G-T] igt/gem_mocs_settings: improve RC6 testings
On Thu, Jul 21,
On 22/07/16 07:25, Patchwork wrote:
== Series Details ==
Series: drm/i915/guc: emit (drm) messages at the most appropriate level
URL : https://patchwork.freedesktop.org/series/10150/
State : failure
== Summary ==
Series 10150v1 drm/i915/guc: emit (drm) messages at the most appropriate level
space for invalid combinations and
engines which are not supported by Gen6 (legacy semaphores).
Replace it with a function devised by Dave Gordon.
I have verified that it generates the same mappings between
mbox selectors and signalling registers.
So just how big was that table? How big are the
Of course, this also re-enables GuC loading and submission
by default on suitable platforms, since it's Intel's Plan
of Record that GuC submission shall be used where available.
Signed-off-by: Dave Gordon
---
drivers/gpu/drm/i915/i915_params.c | 6 +++---
1 file changed, 3 insert
names for the values
representing the DEFAULT, DISABLED, PREFERRED, and MANDATORY
submission options that the user can select (-1, 0, 1, 2
respectively).
This should produce identical code to the previous version!
Signed-off-by: Dave Gordon
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_guc_su
added (3/4
Re-enable GuC loading & submission (4/4)
Added cover letter :)
Dave Gordon (4):
drm/i915/guc: symbolic names for GuC submission preferences
drm/i915/guc: symbolic names for GuC firmare loading preferences
drm/i915/guc: symbolic name for GuC log-level none
drm/i915/guc:
1 - 100 of 1151 matches
Mail list logo
