Re: [Intel-gfx] [PATCH v2 15/17] drm/i915: Calculate haswell plane workaround, v2.

2015-05-18 Thread Daniel Stone
Hi, On 18 May 2015 at 16:47, Daniel Vetter wrote: > On Wed, May 13, 2015 at 10:23:45PM +0200, Maarten Lankhorst wrote: >> This needs to be a global check because at the time of crtc checking >> not all modesets have to be calculated yet. Use intel_crtc->atomic >> because there's no reason to keep

Re: [Intel-gfx] [PATCH] drm/atomic: Handle vblank events in atomic ioctl correctly.

2015-06-01 Thread Daniel Stone
Hi, On 1 June 2015 at 19:12, Maarten Lankhorst wrote: > drm_framebuffer_reference(new_fb); > plane->fb = new_fb; > plane->crtc = plane->state->crtc; > + drm_framebuffer_unreference(plane->old_fb)

Re: [Intel-gfx] [PATCH 4/7] drm: Add Gamma correction structure

2015-06-02 Thread Daniel Stone
Hi, On 2 June 2015 at 12:25, Jindal, Sonika wrote: > On 6/2/2015 1:22 AM, Kausal Malladi wrote: >> struct drm_intel_gamma { >> __u32 flags; >> (The flag variable will indicate if the property to be set/get >> is Gamma or DeGamma) >> __u32 gamma_level; >> (T

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Add pipe level Gamma correction for CHV/BSW

2015-06-02 Thread Daniel Stone
Hi, On 2 June 2015 at 12:38, Jindal, Sonika wrote: > On 6/2/2015 1:22 AM, Kausal Malladi wrote: >> +int drm_mode_crtc_update_color_property(struct drm_device *dev, >> + struct drm_property_blob **blob, >> + size_t length, const void *color_data, >> + stru

Re: [Intel-gfx] [PATCH 1/4] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

2015-02-05 Thread Daniel Stone
e zero padded. Reviewed-by: Daniel Stone ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v3 10/20] drm/i915: Set csc coefficients in intel_sanitize_crtc.

2015-07-13 Thread Daniel Stone
Hi, On 13 July 2015 at 15:30, Maarten Lankhorst wrote: > This might not have been set during boot, and when we preserve > the initial mode this can result in a black screen. > > Cc: Daniel Stone > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_displa

Re: [Intel-gfx] [PATCH v3 06/20] drm/i915: Remove plane_config from struct intel_crtc.

2015-07-13 Thread Daniel Stone
ffer_bits &= > + ~to_intel_plane(c->primary)->frontbuffer_bit; > drm_framebuffer_unreference(c->primary->fb); > c->primary->fb = NULL; > c->primary->crtc = c->primary->state->crtc = NULL; Unrelated cha

Re: [Intel-gfx] [PATCH v3 19/20] drm/i915: always disable irqs in intel_pipe_update_start

2015-07-13 Thread Daniel Stone
Hi, On 13 July 2015 at 15:30, Maarten Lankhorst wrote: > @@ -13649,9 +13647,7 @@ static void intel_begin_crtc_commit(struct drm_crtc > *crtc) > > /* Perform vblank evasion around commit operation */ > if (crtc->state->active) > - intel_crtc->atomic.evade = > -

Re: [Intel-gfx] [PATCH v3 00/20] Convert to atomic, part 4.

2015-07-13 Thread Daniel Stone
fastboot will have to be a separate patch because of the testing it > needs. > - I've cleaned up the changes to planes and split it into separate patches. > This makes it easier to bisect. > - Some commit logs have been updated. > Reviews sent to 6, 10 and 19 separately, bu

Re: [Intel-gfx] [PATCH v3 08/20] drm/i915: fill in more mode members

2015-07-14 Thread Daniel Stone
Hi, On 14 July 2015 at 10:50, Daniel Vetter wrote: > On Mon, Jul 13, 2015 at 04:30:21PM +0200, Maarten Lankhorst wrote: >> Signed-off-by: Maarten Lankhorst > > Needs a summary (or just pasting relevant parts of our mail threads) about > double-modesets, ways to avoid them and why exactly we ende

Re: [Intel-gfx] [PATCH v3 06/20] drm/i915: Remove plane_config from struct intel_crtc.

2015-07-14 Thread Daniel Stone
Hey, On 14 July 2015 at 09:27, Maarten Lankhorst wrote: > Op 13-07-15 om 18:30 schreef Daniel Stone: >> On 13 July 2015 at 15:30, Maarten Lankhorst >> wrote: >>> diff --git a/drivers/gpu/drm/i915/intel_display.c >>> b/drivers/gpu/drm/i915/intel_display.c >

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix reference leak in intel_modeset_readout_hw_state.

2015-07-14 Thread Daniel Stone
On 14 July 2015 at 12:42, Maarten Lankhorst wrote: > Unreference the old mode_blob by calling the crtc_destroy_state > helper before zeroing the crtc_state. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Daniel Stone ___ Intel-gfx

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Zero the mode in intel_sanitize_crtc when force disabling.

2015-07-14 Thread Daniel Stone
orst Reviewed-by: Daniel Stone ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Calculate vblank timestamping constants before enabling vblank.

2015-07-14 Thread Daniel Stone
On 14 July 2015 at 12:46, Maarten Lankhorst wrote: > This is required to properly initialize vblanks on the active crtc. > Without it drm_calc_vbltimestamp_from_scanoutpos can fail with > crtc 0: Noop due to uninitialized mode. > > Signed-off-by: Maarten Lankhorst Reviewed-b

Re: [Intel-gfx] [PATCH v3.1 08/20] drm/i915: fill in more mode members

2015-07-14 Thread Daniel Stone
On 14 July 2015 at 13:12, Maarten Lankhorst wrote: > Fill in driver type, hsync, vrefresh and name. > Those members are not read out but can be calculated from the mode. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Daniel Stone Should be safe to merge independently. Ch

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Also update legacy dpms state

2015-07-15 Thread Daniel Stone
On 15 July 2015 at 16:44, Daniel Vetter wrote: > Avoids legacy userspace/code getting confused when dpms doesn't > reflect reality of what's going on. > > Signed-off-by: Daniel Vetter Reviewed-by: Daniel Stone ___ Intel-gfx

Re: [Intel-gfx] [PATCH v3 00/20] Convert to atomic, part 4.

2015-07-16 Thread Daniel Stone
fastboot will have to be a separate patch because of the testing it > needs. > - I've cleaned up the changes to planes and split it into separate patches. > This makes it easier to bisect. > - Some commit logs have been updated. > Reviews sent to 6, 10 and 19 separately, bu

Re: [Intel-gfx] drm/atomic: Reject events for inactive crtc's.

2015-08-06 Thread Daniel Stone
Hi, On 30 July 2015 at 08:03, Maarten Lankhorst wrote: > This will cause drm_atomic_helper_page_flip and drm_mode_atomic_ioctl to > fail with -EINVAL if a event is requested on a inactive crtc. > > Signed-off-by: Maarten Lankhorst > --- > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/d

Re: [PATCH v1 1/3] drm/ci: refactor software-driver stage jobs

2024-10-07 Thread Daniel Stone
Hi Vignesh, On Fri, 4 Oct 2024 at 09:31, Vignesh Raman wrote: > +.software-driver: > + stage: software-driver > + extends: > +- .test-gl > +- .test-rules > + timeout: "1h30m" > + tags: > +- kvm > + script: > +- ln -sf $CI_PROJECT_DIR/install /install > +- mv install/bzIma

Re: [PATCH 0/8] Display Global Histogram

2024-11-21 Thread Daniel Stone
Hi Arun, On Thu, 21 Nov 2024 at 12:35, Arun R Murthy wrote: > The corresponding mutter changes to enable/disable histogram, read the > histogram data, communicate with the library and write the enhanced data > back to the KMD is also pushed for review at > https://gitlab.gnome.org/GNOME/mutter/-

Re: [PATCHv5 0/8] Display Global Histogram

2024-11-19 Thread Daniel Stone
Hi Arun, On Tue, 19 Nov 2024 at 10:55, Arun R Murthy wrote: > The corresponding mutter changes to enable/disable histogram, read the > histogram data, communicate with the library and write the enhanced data > back to the KMD is also pushed for review at > https://gitlab.gnome.org/GNOME/mutter/-

Re: [PATCHv5 0/8] Display Global Histogram

2024-11-19 Thread Daniel Stone
Hi Arun, On Tue, 19 Nov 2024 at 14:39, Murthy, Arun R wrote: > > On Tue, 19 Nov 2024 at 10:55, Arun R Murthy > > wrote: > > > The corresponding mutter changes to enable/disable histogram, read the > > > histogram data, communicate with the library and write the enhanced > > > data back to the KM

Re: [PATCH v1 1/3] drm/ci: uprev mesa

2025-03-24 Thread Daniel Stone
the series is: Acked-by: Daniel Stone Cheers, Daniel

<    1   2   3   4