We switched from calling i915_gem_alloc_context_obj() to calling
i915_gem_alloc_object() so the error handling needs to be updated to
check for NULL instead of IS_ERR().
Fixes: 149c86e74fe4 ('drm/i915: Allocate context objects from stolen')
Signed-off-by: Dan Carpenter
diff --git a/d
On Thu, Apr 30, 2015 at 03:43:02PM +0100, Chris Wilson wrote:
> On Thu, Apr 30, 2015 at 05:30:50PM +0300, Dan Carpenter wrote:
> > We switched from calling i915_gem_alloc_context_obj() to calling
> > i915_gem_alloc_object() so the error handling needs to be updated to
> > chec
There is an extra semi-colon on the if statement so the debug output
always says "Failed to write EDID checksum" even when it didn't fail.
Fixes: 559be30cb74d ('drm/i915: Implement the intel_dp_autotest_edid function
for DP EDID complaince tests')
Signed-off-by: Dan
intel_modeset_check_state(set->crtc->dev);
12742 }
12743
12744 if (ret) {
12745 DRM_DEBUG_KMS("failed to set mode on [CRTC:%d], err =
%d\n",
12746set->crtc->base.id, ret);
12747
I did add curly braces,
because generally mult-line indents should have curly braces to make
them more readable.
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu/drm/i915/i915_debugfs.c
index 26e9c7b..a76b2ed 100644
--- a/drivers/gpu/drm/i915/i915_debu
like a simple typo to me where "%p" was intended instead of
"%pa".
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
b/drivers/gpu/drm/i915/i915_gem_gtt.c
index e05488e..48eff65 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/
^^
Never true.
1189 return index;
1190 }
1191
regards,
dan carpenter
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
E(reg, ddi_translations_hdmi[hdmi_level * 2 +
i]);
^^
The static checker thinks "15 * 2 + 1 = 31" so we are beyond the size
of the largest array (either 20 or 24).
226 reg += 4;
227 }
228 }
regards,
dan carpenter
patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202410100801.8jzbrn3y-...@intel.com/
smatch warnings:
drivers/gpu/drm/i915/display/intel_audio.c:789 intel_audio_compute_sad() error:
uninitialized symbol
/202409231002.bmp89ipm-...@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 14.1.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https
-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202410010933.pzc3ug9p-...@intel.com/
New smatch warnings:
drivers/gpu/drm/i915/display/intel_display.c:4792 intel_modeset_pipe_config()
error: uninitialized symbol 'fixed_mode'.
vim +/fixed_
: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202411071102.0cmtieio-...@intel.com/
smatch warnings:
drivers/gpu/drm/display/drm_dp_mst_topology.c:6043
drm_dp_mst_dsc_aux_for_port() warn: variable dereferenced before check 'port'
(see line 6033)
tags
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202501080440.cxe0zhxj-...@intel.com/
smatch warnings:
drivers/gpu/drm/i915/display/skl_scaler.c:451 intel_atomic_setup_scaler()
error: uninitialized symbol 'hscale'.
drivers/gp
The filemap_lock_folio() function doesn't return NULL, it returns error
pointers.
Fixes: 25dd342f0cc8 ("drm/i915/gem: convert __shmem_writeback() to folios")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 de
ut BPC for ICL+ is 8 */
2164 return 8;
This 8 becomes "8 * 3" in the caller.
2165 }
regards,
dan carpenter
On Fri, Feb 07, 2025 at 12:02:43PM +0100, Andi Shyti wrote:
> Hi Dan,
>
> On Thu, Feb 06, 2025 at 11:17:02AM +0300, Dan Carpenter wrote:
> > The filemap_lock_folio() function doesn't return NULL, it returns error
> > pointers.
> >
> > Fixes: 25dd342f0cc8 (&q
hanks!
regards,
dan carpenter
This line is indented on tab too far. Delete the extra tab.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c
b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c
L dereference.
386
387 if (err >= 0)
388 err =
i915_sw_fence_await_dma_fence(wait,
389
&rq->fence,
390 0,
regards,
dan carpenter
)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project
cd708029e0b2869e80abe31ddb175f7c35361f90)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
On Mon, Jun 16, 2025 at 11:01:08AM -0400, Rodrigo Vivi wrote:
> On Fri, Jun 06, 2025 at 12:04:49PM +0300, Dan Carpenter wrote:
> > --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> > +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> > @@ -290,7 +290,12 @@ struct sm
it would lead to a NULL pointer
dereference.
To fix this, change the mock_request() function to return error pointers
and update all the callers to expect that.
Fixes: 52c0fdb25c7c ("drm/i915: Replace global breadcrumbs with per-context
interrupt tracking")
Signed-off-by: Dan Carpente
global breadcrumbs with per-context
interrupt tracking")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/selftests/i915_request.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c
b/drivers/gpu/drm/i915/selftes
e);
543 if (err) {
^^^
This should be:
if (err <= 0) {
err = err ?: -ETIMEDOUT;
SUBMIT_ERR(context, "wait for syncobj_in timed out");
It's a bit of a headache to return 0 or negavi
we're just not running them!
It's easy enough to warn about when we have:
ret = dma_fence_wait_timeout();
and ret is an int.
In Smatch I actually had hardcoded dma_fence_wait_timeout() as only
returning up to INT_MAX because there were enough places which saved it
as an int and it triggered false positives in callers where we knew the
timeout was reasonable.
regards,
dan carpenter
301 - 325 of 325 matches
Mail list logo
