Re: [Intel-gfx] [PATCH] drm/i915: Enable 5.4Ghz (HBR2) link rate for Displayport 1.2-capable devices

On Fri, Jan 17, 2014 at 07:58:58AM -0700, Todd Previte wrote: > >>diff --git a/drivers/gpu/drm/i915/intel_dp.c > >>b/drivers/gpu/drm/i915/intel_dp.c > >>index 7df5085..f92d1c0 100644 > >>--- a/drivers/gpu/drm/i915/intel_dp.c > >>+++ b/drivers/gpu/drm/i915/intel_dp.c > >>@@ -102,7 +102,10 @@ intel_

[Intel-gfx] New DP vfuncs get_aux{clock_divider,send_ctl}

A tiny bit of refactoring to make the code more pluggable: 1/ separate the get_aux_clock_divider() into multiple functions. I Tested this patch on IVB and HSW, the simpler to review that patch is to not look at the diff but the before/after version and follow the different code path for ea

[Intel-gfx] [PATCH 3/4] drm/i915: Reorder the AUX_CTL bits in descending order

So it's easier to compare what we program with the documentation, not having to jump at all. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_dp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm

[Intel-gfx] [PATCH 1/4] drm/i915: Turn get_aux_clock_divider() into per-product vfuncs

A tiny clean-up to allow better code separation between platforms. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_dp.c | 79 drivers/gpu/drm/i915/intel_drv.h | 2 + 2 files changed, 58 insertions(+), 23 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH 2/4] drm/i915: Factor out a function returning the AUX_CTL value to start a send

Also, move that computation outside of the for loop that tries 5 times, this value doesn't change between tries. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_dp.c | 59 ++--- 1 file changed, 37 insertions(+), 22 deletions(-) diff --

[Intel-gfx] [PATCH 4/4] drm/i915: Introduce a get_aux_send_ctl() vfunc

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_dp.c | 10 ++ drivers/gpu/drm/i915/intel_drv.h | 8 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index ae9902a..95147ac 100644

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Reorder the AUX_CTL bits in descending order

On Tue, Jan 21, 2014 at 12:09:18PM +0200, Jani Nikula wrote: > On Mon, 20 Jan 2014, Damien Lespiau wrote: > > So it's easier to compare what we program with the documentation, not > > having to jump at all. > > This could be squashed into the previous patch just as

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Factor out a function returning the AUX_CTL value to start a send

On Tue, Jan 21, 2014 at 12:07:23PM +0200, Jani Nikula wrote: > > On Mon, 20 Jan 2014, Damien Lespiau wrote: > > Also, move that computation outside of the for loop that tries 5 times, > > this value doesn't change between tries. > > Some general bikeshedding... >

[Intel-gfx] [PATCH 1/4 v2] drm/i915: Turn get_aux_clock_divider() into per-platform vfuncs

A tiny clean-up to allow better code separation between platforms. v2: Fix comment placement (put in in i9xx_get_aux_clock_divider()) and nuke the outdated PCH eDP comment (Jani Nikula) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_dp.c | 74

[Intel-gfx] [PATCH 4/4 v2] drm/i915: Introduce a get_aux_send_ctl() vfunc

We need a bit more flexibility here in the future, bits get shuffled around. v2: more descriptive commit message (Jani Nikula) Reviewed-by: Jani Nikula Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_dp.c | 10 ++ drivers/gpu/drm/i915/intel_drv.h | 8 2 files

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Move pipecrc debug functions to new file

lay related things into intel_drv.h, it was in i915_drv.h because it was in debugfs.c. Also intel_drv.h and i915_drv.h are neatly separated by file, so it'd be nice to have a separate entry for intel_display_test.c. Bikeshedding territory, I know, sorry. With that changed or not you have

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Move pipecrc debug functions to new file

On Tue, Jan 21, 2014 at 09:44:51PM +, Damien Lespiau wrote: > We try to put display related things into intel_drv.h, it was in > i915_drv.h because it was in debugfs.c. Also intel_drv.h and i915_drv.h > are neatly separated by file, so it'd be nice to have a separa

Re: [Intel-gfx] [PATCH] drm/i915: Add debugfs hooks for messign with watermark latencies

can also be done in the small helper from user space anyway. Reviewed-by: Damien Lespiau -- Damien > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/i915_debugfs.c | 171 > > 1 file changed, 171 insertions(+) > > diff

Re: [Intel-gfx] [PATCH] tools: Allow building on Android after noinst_PROGRAMS is not defined any more

On Wed, Jan 22, 2014 at 10:41:05AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Looks like filter-out macro gets silently unhappy about an undefined variable. > > Signed-off-by: Tvrtko Ursulin Reviewed-by: Damien Lespiau and pushed. Thanks for the pat

Re: [Intel-gfx] [PATCH] drm/i915: Add debugfs hooks for messign with watermark latencies

On Wed, Jan 22, 2014 at 04:38:11PM +0200, Ville Syrjälä wrote: > On Wed, Jan 22, 2014 at 02:26:26PM +0000, Damien Lespiau wrote: > > On Wed, Jan 22, 2014 at 02:36:08PM +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > &g

Re: [Intel-gfx] [PATCH] drm/i915: debugfs: Add support for probing DP sink CRC.

On Fri, Jan 24, 2014 at 10:05:32AM -0200, Rodrigo Vivi wrote: > +int intel_dp_sink_crc(struct intel_dp *intel_dp, u8 *crc) > +{ > + struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp); > + struct drm_device *dev = intel_dig_port->base.base.dev; > + struct intel_crtc *in

Re: [Intel-gfx] [PATCH] drm/i915: debugfs: Add support for probing DP sink CRC.

> > v5: removing last missing useless _retry (by Damien) > > Cc: Daniel Vetter > Cc: Damien Lespiau > Cc: Jani Nikula > Signed-off-by: Rodrigo Vivi Reviewed-by: Damien Lespiau -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] Fix LIBDRM_PATH for top android build

Hi, Can one of you guys review that patch from Joao? You're in a quite better place than me to do it. (Note: you don't have to wait until one garbage collects the patches on the ml, people should find good review candidates if nothing happens for too long). Thanks, -- Damien On Thu, Jan 23, 2

[Intel-gfx] [PATCH intel-gpu-tools] gem_ring_sync_copy: Add a ring to ring synchronization test

: Damien Lespiau --- tests/.gitignore | 1 + tests/Makefile.sources | 1 + tests/gem_ring_sync_copy.c | 367 + 3 files changed, 369 insertions(+) create mode 100644 tests/gem_ring_sync_copy.c diff --git a/tests/.gitignore b/tests

Re: [Intel-gfx] [PATCH] Fix LIBDRM_PATH for top android build

On Fri, Jan 31, 2014 at 09:36:25AM +, Barbalho, Rafael wrote: > The patch is incomplete. If you change these macros in the tests > directory then why does it not need to be changed in the tools > directory also? > > I have a patch that refactors these macros into a third file, I'll > send it u

Re: [Intel-gfx] [PATCH 0/5] Android build system clean-up

On Fri, Jan 31, 2014 at 02:57:35PM +, rafael.barba...@intel.com wrote: > From: Rafael Barbalho > > IGT in android still had some hang-ups from the initial porting, we were > re-compiling the lib directory every time for each tool or test binary. It > also could get its include paths confused

Re: [Intel-gfx] [PATCH intel-gpu-tools] gem_ring_sync_copy: Add a ring to ring synchronization test

On Wed, Jan 29, 2014 at 04:17:37PM +, Damien Lespiau wrote: > +static void run_test(data_t *data, enum ring r1, enum ring r2, enum test > test) > +{ > + struct ring_ops *r1_ops = &ops[r1]; > + struct ring_ops *r2_ops = &ops[r2]; > + drm_intel_bo

Re: [Intel-gfx] [PATCH 1/1] demos: Add intel_plane_rotate test to verify rotation of planes and crtc

On Tue, Feb 04, 2014 at 12:18:24PM +0100, Daniel Vetter wrote: > On Sat, Feb 01, 2014 at 12:43:48AM +0530, sagar.a.kam...@intel.com wrote: > > From: Sagar Kamble > > > > This test will verify the 180 degree rotation of sprite and crtc planes. > > It will allow user to control rotation separately

Re: [Intel-gfx] [PATCH 1/1] demos: Add intel_plane_rotate test to verify rotation of planes and crtc

On Tue, Feb 04, 2014 at 05:05:47PM +0530, Sagar Arun Kamble wrote: > On Tue, 2014-02-04 at 11:25 +0000, Damien Lespiau wrote: > > On Tue, Feb 04, 2014 at 12:18:24PM +0100, Daniel Vetter wrote: > > > On Sat, Feb 01, 2014 at 12:43:48AM +0530, sagar.a.kam...@intel.com wrote: &

Re: [Intel-gfx] [PATCH 1/1] demos: Add intel_plane_rotate test to verify rotation of planes and crtc

On Tue, Feb 04, 2014 at 02:08:27PM +0200, Ville Syrjälä wrote: > On Tue, Feb 04, 2014 at 11:46:46AM +0000, Damien Lespiau wrote: > > On Tue, Feb 04, 2014 at 05:05:47PM +0530, Sagar Arun Kamble wrote: > > > On Tue, 2014-02-04 at 11:25 +0000, Damien Lespiau wrote: > > > &

Re: [Intel-gfx] Haswell DisplayPort Multi Stream Transport status

On Wed, Jan 22, 2014 at 12:53:50PM +0900, Mike Hommey wrote: > Hi, > > What is the current status for DP MST support on Haswell? Are there > experimental patches that can be tested? If not, what can be done to > help progress? No patches to test yet. I would gate DP MST on the current DP aux refa

[Intel-gfx] [PATCH igt 21/28] lib: Include drm_fourcc.h from igt_kms.h

This include is needed for the DRM_FORMAT* defines used in the fb creation helpers. Signed-off-by: Damien Lespiau --- lib/igt_kms.h | 1 + tests/kms_cursor_crc.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/igt_kms.h b/lib/igt_kms.h index 8110dad..96dd9e4

[Intel-gfx] [PATCH igt 15/28] lib/crc: Factor out reading a single CRC value

Signed-off-by: Damien Lespiau --- lib/igt_debugfs.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index 4b96521..a0d84bf 100644 --- a/lib/igt_debugfs.c +++ b/lib/igt_debugfs.c @@ -301,6 +301,21 @@ static bool

[Intel-gfx] [PATCH igt 24/28] lib/display: Add a way to wait at every commit for inspection

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 74e52b6..fbbf6aa 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -1368,6 +1368,9 @@ int igt_display_commit(igt_display_t *display) LOG_UNINDENT

[Intel-gfx] [PATCH igt 08/28] tests/kms_cursor_crc: Move the array of cursor fb_ids to the stack

This array is not used outside ouf create_cursor_fb(). A stack allocated array is enough. Signed-off-by: Damien Lespiau --- tests/kms_cursor_crc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index 38aa1ab

[Intel-gfx] [PATCH igt 12/28] kms_cursor_crc: Port the test to the new modeset API

Signed-off-by: Damien Lespiau --- tests/kms_cursor_crc.c | 201 ++--- 1 file changed, 106 insertions(+), 95 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index 9ddee06..76e2845 100644 --- a/tests/kms_cursor_crc.c +++ b

[Intel-gfx] [PATCH igt 18/28] lib/display: Add support for DRM planes

We can now extend our plane support beyond primary and cursor planes. Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 116 +- lib/igt_kms.h | 6 +++ 2 files changed, 120 insertions(+), 2 deletions(-) diff --git a/lib/igt_kms.c b/lib

[Intel-gfx] [PATCH igt 20/28] kms_cursor_crc: Use kmstest_create_color_fb()

Signed-off-by: Damien Lespiau --- tests/kms_cursor_crc.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index a386ad9..6cdb785 100644 --- a/tests/kms_cursor_crc.c +++ b/tests/kms_cursor_crc.c

[Intel-gfx] [PATCH igt 14/28] lib/display: Check if we're trying to use the same pipe on 2 outputs

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index c503ebb..1933fa6 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -977,10 +977,34 @@ void igt_display_fini

[Intel-gfx] [PATCH igt 03/28] lib: Introduce symbolic names for display planes

It'd be nice to have symbolic names for planes instead of using an index in igt_output_get_plane(). We also namespace the enum to not conflict with anyone. Signed-off-by: Damien Lespiau --- lib/igt_display.h | 18 +- lib/igt_kms.c | 18 -- lib/igt_

[Intel-gfx] [PATCH igt 28/28] kms_plane: Start a basic display plane test

We test the sprite plane positionning in there, for now. Signed-off-by: Damien Lespiau --- tests/.gitignore | 1 + tests/Makefile.sources | 1 + tests/kms_plane.c | 247 + 3 files changed, 249 insertions(+) create mode 100644 tests

[Intel-gfx] [PATCH igt 02/28] kms_pipe_crc_basic: Port to the new modeset API

Signed-off-by: Damien Lespiau --- tests/kms_pipe_crc_basic.c | 126 +++-- 1 file changed, 29 insertions(+), 97 deletions(-) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index f4a97eb..fdec077 100644 --- a/tests/kms_pipe_crc_basic.c

[Intel-gfx] [PATCH igt 13/28] lib/display: Allow to override the display verbosity with an env variale

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index e2413e5..c503ebb 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -863,6 +863,7 @@ void igt_display_init(igt_display_t *display, int drm_fd

[Intel-gfx] [PATCH igt 01/28] lib: Introduce a modeset API

tests. Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 364 ++ lib/igt_kms.h | 59 ++ 2 files changed, 423 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 3960d24..dfa6b41 100644 --- a/lib/igt_kms.c +++ b/lib/igt

[Intel-gfx] [PATCH igt 06/28] lib/display: Add an accessor to retrieve the number of pipes

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 5 + lib/igt_kms.h | 1 + 2 files changed, 6 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index e3e902a..38ee82b 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -934,6 +934,11 @@ void igt_display_set_verbose(igt_display_t

[Intel-gfx] [PATCH igt 19/28] lib: Introduce a new helper kmstest_create_color_fb()

We need to create fbs of a single color in a few places. Time to abstract that out to a helper function. Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 19 +++ lib/igt_kms.h | 4 2 files changed, 23 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 23a7318

[Intel-gfx] [PATCH igt 11/28] lib/display: Add a way to specify we don't care about the pipe to use

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 12 lib/igt_kms.h | 6 ++ 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 3b75478..e2413e5 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -1226,10 +1226,14 @@ void

[Intel-gfx] [PATCH igt 09/28] lib/display: Fix the SetCrtc disabling log message

We were displaying the value of fb_id (0), when the actual interesting thing about this call it that it'll just down the pipe. Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 38

[Intel-gfx] [PATCH igt 25/28] lib/display: Print the fb id, not its pointer in the set_fb() log message

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index fbbf6aa..7d74bf8 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -1411,8 +1411,8 @@ void igt_plane_set_fb(igt_plane_t *plane, struct

[Intel-gfx] [PATCH igt 17/28] tests/kms_cursor_crc: Use igt_pipe_crc_collect_crc()

Signed-off-by: Damien Lespiau --- tests/kms_cursor_crc.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index 76e2845..a386ad9 100644 --- a/tests/kms_cursor_crc.c +++ b/tests/kms_cursor_crc.c @@ -94,7 +94,7

[Intel-gfx] [PATCH igt 26/28] lib/display: Wait for a vblank after SetPlane()

Let's be testing friendly and gently wait for the next vblank before returning from commit() when needed. After igt_display_commit() one can safely look at the CRC. Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 8 lib/igt_kms.h | 5 +++-- 2 files changed, 11 insertions(

[Intel-gfx] [PATCH igt 22/28] kms_pipe_crc_basic: Use kmstest_create_color_fb()

Reducing again the per-test number of lines. Signed-off-by: Damien Lespiau --- tests/kms_pipe_crc_basic.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index f4de64f..8a45c5b 100644 --- a

[Intel-gfx] [PATCH igt 07/28] kms_pipe_crc_basic: Use igt_display_get_n_pipes() instead of hardcoding 3

Signed-off-by: Damien Lespiau --- tests/kms_pipe_crc_basic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index 7d48ca6..f4de64f 100644 --- a/tests/kms_pipe_crc_basic.c +++ b/tests/kms_pipe_crc_basic.c @@ -169,7

[Intel-gfx] [PATCH igt 23/28] lib: Add a helper to wait for a keypress

Signed-off-by: Damien Lespiau --- lib/drmtest.c | 13 + lib/drmtest.h | 2 ++ 2 files changed, 15 insertions(+) diff --git a/lib/drmtest.c b/lib/drmtest.c index f7262d7..f0635d3 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -46,6 +46,7 @@ #include #include #include

[Intel-gfx] [PATCH igt 27/28] lib/display: Fix assertion in set_plane()

When cycling throuth planes, we still want to reach the cursor plane. We have to special case IGT_PLANE_CURSOR as a shorthand to select the cursor plane (the last plane on the pipe). Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Intel-gfx] Modeset API for KMS tests

The goal of that series is to introduce a small mode setting API to write our KMS tests, port kms_pipe_crc_basic and kms_cursor_crc to it and introduce a new kms_plane test. To be more precise, the goals are: - Fewer lines per test, - Be able to switch between a "legacy" backend and an "atomic

[Intel-gfx] [PATCH 6/8] drm/i915: Use I915_MAX_PIPES in the pipe/plane_to_crtc_mapping definitions

Reviewed-by: Mika Kuoppala Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 36ea189..80ff7df 100644 --- a

[Intel-gfx] [PATCH 4/8] drm/i915: Consolidate FUSE_STRAP in one set of defines

We had 2 set of defines for the same register, so make it one. Reviewed-by: Mika Kuoppala Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_reg.h | 18 -- drivers/gpu/drm/i915/intel_ddi.c | 2 +- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 8/8] drm/i915: Provide a command line option to disable display

If we can't actually determine at run-time we have a fused-off display, provide at least an option to disable it. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_dma.c| 3 ++- drivers/gpu/drm/i915/i915_drv.h| 1 + drivers/gpu/drm/i915/i915_params.c | 4 3 files ch

[Intel-gfx] [PATCH 5/8] drm/i915: Disable display when fused off

fused off try to read the FUSE_LOCK bit to determine if PCH display is disabled Reviewed-by: Mika Kuoppala (for v3) Reviewed-by: Ville Syrjälä (for v3) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_dma.c | 31 ++- drivers/gpu/drm/i915/i915_reg.h | 2

[Intel-gfx] [PATCH 2/8] drm/i915: Make the intel_device_info structure kept in dev_priv writable

tly, Keep the info field const to catch post initialization writes instead of the v2 solution, Use a direct structure copy for the initial info initialization to use the compiler type safety (Ville Syrjälä) Reviewed-by: Mika Kuoppala (for v2) Reviewed-by: Ville Syrjälä (

[Intel-gfx] [PATCH 3/8] drm/i915: Move num_plane to the intel_device_info structure

e info fields at run-time. v2: rename num_plane to num_sprites (Ville Syrjälä) v3: rebase on top of latest drm-nightly Reviewed-by: Mika Kuoppala (for v2) Reviewed-by: Ville Syrjälä (for v2) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_dma.c | 23 --- dr

[Intel-gfx] Supporting fused display configurations v5

Follow up of v4: http://lists.freedesktop.org/archives/intel-gfx/2014-January/037913.html The major changes are: - we try to be cunning on CPT/PPT and look at the fuses lock bit of SFUSE_STRAP to detect if PCH display reads are being dropped - we provide a module parameter to forcefully

[Intel-gfx] [PATCH 1/8] drm/i915: Always use INTEL_INFO() to access the device_info structure

off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_gem.c | 5 +++-- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- drivers/gpu/drm/i915/intel_display.c | 27 +++ drivers/gpu/drm/i915/intel_pm.c | 13 + 4 files changed, 29 insertions(+), 20 deletions(-)

[Intel-gfx] [PATCH 7/8] drm/i915: Reorder i915_params fields to not create holes

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 80ff7df..b1e91c3 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm

Re: [Intel-gfx] [PATCH] drm/i915: Print seqnos as unsigned in debugfs

On Thu, Aug 22, 2013 at 07:21:30PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > I don't like seeing signed seqnos. Make them unsigned. > > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH v3 12/15] drm/i915: Band Gap WA

On Tue, Aug 27, 2013 at 03:12:24PM +0300, Jani Nikula wrote: > +static void band_gap_wa(struct drm_i915_private *dev_priv) > +{ > + mutex_lock(&dev_priv->dpio_lock); > + > + /* Enable bandgap fix in GOP driver */ > + vlv_cck_modify(dev_priv, 0x6D, 0x0001, 0x0003); I hear that t

[Intel-gfx] [PATCH] drm/i915: It's its!

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_gem_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c index 403309c..e038513 100644 --- a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 01/17] drm/i915: Do not add an interrupt for a context switch

ET_CONTEXT, we > should be safe in not unduly placing blame on the new context. > > Signed-off-by: Chris Wilson > Cc: Ben Widawsky > Cc: Paulo Zanoni I'm somewhat new to the core GEM code, but I'm convinced by the commit message and the patch does what it says. So:

Re: [Intel-gfx] [PATCH 02/17] drm/i915: Rearrange the comments in i915_add_request()

; > Signed-off-by: Chris Wilson Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/i915_gem.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 56c9104.

Re: [Intel-gfx] [PATCH 03/17] drm/i915: Pin pages whilst mapping the dma-buf

y, so rearrange the code > and error paths to make it so. > > Signed-off-by: Chris Wilson Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/i915_gem_dmabuf.c | 41 > ++ > 1 file changed, 22 insertions(+), 19 deletions(

[Intel-gfx] [PATCH] drm/i915: Don't call sg_free_table() if sg_alloc_table() fails

One needs to call __sg_free_table() if __sg_alloc_table() fails, but sg_alloc_table() does that for us already. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_gem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c

[Intel-gfx] [PATCH] drm/i915: Remove unused mode_fixup() vfunc of struct intel_dvo_dev_ops

It's totally unused, so remove the last mode_fixup appearance in i915. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/dvo.h| 11 --- drivers/gpu/drm/i915/intel_dvo.c | 5 - drivers/gpu/drm/i915/intel_sdvo.c | 3 --- 3 files changed, 19 deletions(-) diff --

[Intel-gfx] [PATCH i-g-t 08/12] testdisplay: Fix CRTS typo

Signed-off-by: Damien Lespiau --- tests/testdisplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testdisplay.c b/tests/testdisplay.c index 6e47ae2..f94e5c4 100644 --- a/tests/testdisplay.c +++ b/tests/testdisplay.c @@ -366,7 +366,7 @@ set_mode(struct connector *c

[Intel-gfx] [PATCH i-g-t 11/12] testdisplay: Provide a full path when opening pngs

This way one doesn't have to be in tests/ for testsdisplay to be able to open pass.png. Signed-off-by: Damien Lespiau --- tests/Makefile.am | 5 - tests/testdisplay.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index dd

[Intel-gfx] [PATCH i-g-t 12/12] testdisplay: Test the stereo 3D modes

Now that modes have flags to describe which 3d formats the sink supports, it's time to test them. The new test cycles through the supported 3D formats and paint 3D stereoscopic images taken from publicly available samples: http://www.quantumdata.com/apps/3D/sample_BMP.asp Signed-off-by: D

[Intel-gfx] [PATCH i-g-t 03/12] lib: Split create_image_surface() out of create_cairo_ctx()

So we can use it in the next commit. Signed-off-by: Damien Lespiau --- lib/drmtest.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index f760028..12bd0ff 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -1483,9 +1483,8

[Intel-gfx] [PATCH i-g-t 10/12] testdisplay: Free the array of connectors

That's an array we allocated earlier in this function. Let's be symetric and free it once done. Signed-off-by: Damien Lespiau --- tests/testdisplay.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/testdisplay.c b/tests/testdisplay.c index 3a9eab7..00d777a 100644 -

[Intel-gfx] [PATCH i-g-t 04/12] lib: Add a helper to write a png from a struct kmstest_fb

Signed-off-by: Damien Lespiau --- lib/drmtest.c | 11 +++ lib/drmtest.h | 1 + 2 files changed, 12 insertions(+) diff --git a/lib/drmtest.c b/lib/drmtest.c index 12bd0ff..f7de232 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -1531,6 +1531,17 @@ void kmstest_remove_fb(int fd, struct

[Intel-gfx] [PATCH i-g-t 06/12] testdisplay: Map the fb inside paint_color_key()

So the code for this is self-contained. This goes along the way of reducing the number of global variables in testdisplay. Take the opportunity to unmap the fb after use as well. Signed-off-by: Damien Lespiau --- tests/testdisplay.c | 12 +++- 1 file changed, 7 insertions(+), 5

[Intel-gfx] [PATCH i-g-t 01/12] lib: Dump information about the supported 3D stereo formats

When dumping the details of a mode, let's add the 3D formats the mode supports. Signed-off-by: Damien Lespiau --- lib/drmtest.c | 37 +++-- lib/drmtest.h | 9 + 2 files changed, 44 insertions(+), 2 deletions(-) diff --git a/lib/drmtest.c b/lib/drmt

[Intel-gfx] [PATCH i-g-t 09/12] testdisplay: Untangle dump_info() from the main testing loop

-i is just supposed to show some information about the DRM resources. Right now it works in a quite convoluted way. Untangle this to call dump_info() when -i is given, exit the program and be done with it. Signed-off-by: Damien Lespiau --- tests/testdisplay.c | 30

[Intel-gfx] [PATCH i-g-t 07/12] testdisplay: Properly handle the life cycle of framebuffers

When cycling through the modes, let's make sure to free the previous framebuffers. This is the perfect occasion to use kmstest_remove_fb(). Signed-off-by: Damien Lespiau --- tests/testdisplay.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/

[Intel-gfx] [PATCH i-g-t 02/12] lib: Add a helper to paint a PNG using cairo

Signed-off-by: Damien Lespiau --- lib/drmtest.c | 28 lib/drmtest.h | 2 ++ 2 files changed, 30 insertions(+) diff --git a/lib/drmtest.c b/lib/drmtest.c index eca792c..f760028 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -1338,6 +1338,34 @@ void

[Intel-gfx] [PATCH i-g-t 05/12] testdisplay: Move the code sanitizing depth into main()

It'll be shared by the set_mode() and set_3d_mode() functions. Signed-off-by: Damien Lespiau --- tests/testdisplay.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tests/testdisplay.c b/tests/testdisplay.c index 6c39b68..c3a0d04 100644 --- a/

[Intel-gfx] [i-g-t] Stereo 3D

This series makes testdisplay able to display top and bottom, side by side half and frame packing stereo framebuffers. The final fb is composited from separate left and right images using cairo. I skipped the first couple of patches because of 2 massive 1080p pngs, but pushed a branch: http://cg

Re: [Intel-gfx] [PATCH v2 01/14] drm/i915: Grab the pixel clock from adjusted_mode not requested_mode

gt; > v2: Dropped the intel_compute_config() hunk due to killing of the > INTEL_FDI_FREQ check > > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau If you feel brave enough you could also have reindent the comment above the modified line to 80 chars. -- Damien

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Use adjusted_mode in intel_update_fbc()

e from the user requested mode. > > Extract both modes from pipe config instead of the drm_crtc. > > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/intel_pm.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(

Re: [Intel-gfx] [PATCH 06/14] drm/i915: Check the clock from adjusted mode in intel_crtc_active()

On Wed, Sep 04, 2013 at 06:25:23PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The clock in crtc->mode doesn't necessarily mean anything. Let's look > at the clock in adjusted_mode instead. > > Signed-off-by: Ville Syrjälä Reviewed-

Re: [Intel-gfx] [PATCH 05/14] drm/i915: Use adjusted_mode appropriately when computing watermarks

On Wed, Sep 04, 2013 at 06:25:22PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Currently most of the watermark code looks at crtc->mode which is the > user requested mode. The only piece of information there that is > relevant is hdisplay, the rest must come from adjuste

Re: [Intel-gfx] [PATCH v2 11/14] drm/i915: Add explicit pipe src size to pipe config

ly. As long as we treat primaries as full > screen only, we can get away with this. Eventually when we move > primaries over to drm_plane, we need to fix it all up. > > v2: Add a comment to explain what pipe_src_{w,h} are > Add a note about primary planes to commit message > &

Re: [Intel-gfx] [PATCH 12/14] drm/i915: Document the inteded use of requested_mode

On Wed, Sep 04, 2013 at 06:25:29PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Try to clarify the purpose of requested_mode. > > Signed-off-by: Ville Syrjälä (and intended in the summary) -- Damien ___ Intel-gfx mailing li

Re: [Intel-gfx] [PATCH 12/14] drm/i915: Document the inteded use of requested_mode

On Wed, Sep 04, 2013 at 06:25:29PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Try to clarify the purpose of requested_mode. > > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau > --- > drivers/gpu/drm/i915/intel_drv.h | 5 +

Re: [Intel-gfx] [PATCH 07/14] drm/i915: Use adjusted_mode when checking conditions for PSR

On Wed, Sep 04, 2013 at 06:25:24PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > intel_edp_psr_match_conditions() currently looks at crtc->mode > when it really needs to look at adjusted_mode. Fix it. > > Signed-off-by: Ville Syrjälä Review

Re: [Intel-gfx] [PATCH 10/14] drm/i915: Use adjusted_mode in DSI PLL calculations

t; > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/intel_dsi_pll.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dsi_pll.c > b/drivers/gpu/drm/i915/intel_dsi_pll.c

Re: [Intel-gfx] [PATCH v2 08/14] drm/i915: Make intel_crtc_active() available outside intel_pm.c

that one with a call to intel_crtc_active(). > > v2: Copy paste a big comment from danvet's mail explaining > when we can ditch the extra checks > > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/intel_display.c

Re: [Intel-gfx] [PATCH 03/14] drm/i915: Use adjusted_mode in HDMI 12bpc clock check

HDMI. But let's make the code > safe against such things happening in the future. > > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/intel_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Use adjusted_mode->clock in lpt_program_iclkip

On Wed, Sep 04, 2013 at 06:25:19PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > lpt_program_iclkip() wants to know the pixel clock. It should get that > information from adjusted_mode, not crtc->mode. > > Signed-off-by: Ville Syrjälä Review

Re: [Intel-gfx] [PATCH 09/14] drm/i915: Use pipe config in sprite code

On Wed, Sep 04, 2013 at 06:25:26PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Rather than dig up the pipe source size from crtc->mode, use > intel_crtc->config.requested_mode. > > Signed-off-by: Ville Syrjälä Reviewed-by: Dam

Re: [Intel-gfx] [PATCH 05/14] drm/i915: Use adjusted_mode appropriately when computing watermarks

est must come from adjusted_mode. Convert > all of the code to use requested_mode and adjusted_mode from > pipe config appropriately. > > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/intel_pm.c | 55 >

Re: [Intel-gfx] [PATCH] lib/drmtest: skip suspend tests in simulation

On Thu, Sep 12, 2013 at 02:02:30PM +0200, Daniel Vetter wrote: > The simulator doesn't like this nor really support it :( > > Cc: Ben Widawsky > Cc: Ville Syrjälä > Cc: Damien Lespiau > Signed-off-by: Daniel Vetter Aye! (I recall we don't really need that for i-g-

Re: [Intel-gfx] [PATCH 2/5] drm/i915: fix intel_dp_aux_native_read's reply array size

On Fri, Sep 13, 2013 at 12:21:21PM +0300, Jani Nikula wrote: > On Fri, 13 Sep 2013, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > So far we control all the reads an none of them exceeds the current > > limit of 20 bytes, but we never think about this when reviewing > > patches, so we may at

Re: [Intel-gfx] [PATCH 2/5] drm/i915: fix intel_dp_aux_native_read's reply array size

On Fri, Sep 13, 2013 at 04:41:42PM +0300, Jani Nikula wrote: > On Fri, 13 Sep 2013, Damien Lespiau wrote: > > On Fri, Sep 13, 2013 at 12:21:21PM +0300, Jani Nikula wrote: > >> On Fri, 13 Sep 2013, Paulo Zanoni wrote: > >> > From: Paulo Zanoni > >> >

Re: [Intel-gfx] Fix typo in intel_lid.man

On Fri, Sep 13, 2013 at 04:56:04PM +0300, Eero Tamminen wrote: > Hi, > > Attached patch fixes typo in intel_lid.man. Thanks for the diff, pushed. Next time don't hesitate to use git format-patch, that's really the preferred way to send patches and makes it easy to preserver the author and the com

Re: [Intel-gfx] [PATCH] drm/i915: garbage-collect vlv refclk function

On Mon, Sep 16, 2013 at 11:29:34AM +0200, Daniel Vetter wrote: > Simply inline the 100MHz default we're using. Having gunk around that > has leftover LVDS support on a platform that just doesn't have this > isn't of any use. > > Signed-off-by: Daniel Vetter

<    3   4   5   6   7   8   9   10   11   12   >