On Thu, Feb 13, 2014 at 11:10:00AM +0800, Xiang, Haihao wrote:
> On Tue, 2014-01-28 at 09:53 +0800, yakui.z...@intel.com wrote:
> > From: Zhao Yakui
> >
> > The Sampler/Constant cache is read-only. And it can't be used as
> > the target cache agent of WRITE message.
> >
> > Signed-off-by: Zhao
Coverity points out that, if we end up in the 'failed' label, that's
precisely because we couldn't retrieve a fixed mode (ie fixed_mode is
NULL) and then "if (fixed_mode)" is always false.
Remove that dead code.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i9
On Fri, Feb 14, 2014 at 02:06:06PM +0100, Daniel Vetter wrote:
> Spotted while auditing the code for fencing issues.
>
> Cc: Chris Wilson
> Signed-off-by: Daniel Vetter
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/intel_display.c | 10 +-
On Tue, Feb 18, 2014 at 01:28:54PM +, joao.san...@intel.com wrote:
> From: Joao Santos
>
> We do not have GLib there so it does not build.
>
>
> Signed-off-by: Joao Santos
> ---
> tests/Android.mk |2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/Android.mk b/tests/Andro
On Tue, Feb 18, 2014 at 01:15:12PM +, joao.san...@intel.com wrote:
> From: Joao Santos
>
> Added in new macros to support new platforms.
What's the real purpose of this patch? you're adding a bunch of defines
here without any user. I'd argue that we really want to move away from
those define
On Tue, Feb 18, 2014 at 04:58:58PM +, Santos, Joao wrote:
> Someone asked me to put the kms_sysfs_edid_timing for the same reason,
> I honestly didn't check it myself. I think we should still add
> kms_plane to the skip_list because otherwise it blocks anyone who
> tries to build igt tests.
Y
On Wed, Feb 19, 2014 at 02:19:19PM +, joao.san...@intel.com wrote:
> From: Joao Santos
>
> Skipping this test until we have Cairo in the build.
>
> Signed-off-by: Joao Santos
Thanks for the patch, pushed. Any more news on the EDID retrieval
script?
--
Damien
_
In the future we want to be able to specify a per-pipe number of sprites. This
series introduces this with a bit of refactoring first to, hopefully, don't
make the same mistake that v1 did again.
--
Damien
Damien Lespiau (3):
drm/i915: Use a pipe variable to cycle trough the pipes
drm
#x27; this time around.
It's all a lame excuse, but it does make it harder to redo the same
mistake.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_display.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/
In the future, we need to be able to specify per-pipe number of
planes/sprites. Let's start today!
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_dma.c | 14 +++---
drivers/gpu/drm/i915/i915_drv.h | 6 +++---
2 files changed, 14 insertions(+), 6 deletions(-)
diff --
This macro is similar to for_each_pipe() we already have. Convert the
two call sites we have at the same time.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/intel_display.c | 16
2 files changed, 9 insertions(+), 8 deletions
On Fri, Feb 28, 2014 at 05:30:02PM +, Chris Wilson wrote:
> On Fri, Feb 28, 2014 at 04:42:15PM +0000, Damien Lespiau wrote:
> > In the future, we need to be able to specify per-pipe number of
> > planes/sprites. Let's start today!
>
> But today, what's wrong w
: kbuild test robot
> Cc: Imre Deak
> Signed-off-by: Daniel Vetter
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/i915_irq.c | 4 ++--
> drivers/gpu/drm/i915/intel_display.c | 10 +-
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
On Fri, Feb 28, 2014 at 05:49:20PM +, Chris Wilson wrote:
> On Fri, Feb 28, 2014 at 05:37:39PM +0000, Damien Lespiau wrote:
> > On Fri, Feb 28, 2014 at 05:30:02PM +, Chris Wilson wrote:
> > > On Fri, Feb 28, 2014 at 04:42:15PM +0000, Damien Lespiau wrote:
> > >
patch
--
Damien
Damien Lespiau (5):
drm/i915: Use a pipe variable to cycle through the pipes
drm/i915: Don't declare unnecessary shadowing variable
drm/i915: Replace a few for_each_pipe(i) by for_each_pipe(pipe)
drm/i915: Add a for_each_sprite() macro
drm/i915: Make num_sprites
#x27; this time around.
It's all a lame excuse, but it does make it harder to redo the same
mistake.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_display.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/
In the future, we need to be able to specify per-pipe number of
planes/sprites. Let's start today!
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_dma.c | 8 ++--
drivers/gpu/drm/i915/i915_drv.h | 6 +++---
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/dr
This macro is similar to for_each_pipe() we already have. Convert the
two call sites we have at the same time.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/intel_display.c | 16
2 files changed, 9 insertions(+), 8 deletions
'i' is already defined in the function scope and used elsewhere. Let's
use it instead.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_debugfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu/drm/i915/i915_
l to do so (eg. when there isn't another
pipe variable already).
Suggested-by: Chris Wilson
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_debugfs.c | 14 +++---
drivers/gpu/drm/i915/i915_irq.c | 14 +++---
drivers/gpu/drm/i915/intel_pm.c | 16
I have a script around that catches a few things otherwise hard to find
(because you'd need analysis beyond a single compilation unit). The last run
returned 3 hits.
HTH,
--
Damien
Damien Lespiau (3):
drm/i915: Make i915_gem_retire_requests_ring() static
drm/i915: Remove u
This function was removed by Imre's power well work.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_drv.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index a4ffc02..a0cfc62 100644
--- a/drivers/gpu/drm
2013 +0100
drm/i915: Embed the ring->private within the struct intel_ring_buffer
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_drv.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index f89c308..d6a07e
Its last usage outside of i915_gem.c was removed in:
commit 1f70999f9052f5a1b0ce1a55aff3808f2ec9fe42
Author: Chris Wilson
Date: Mon Jan 27 22:43:07 2014 +
drm/i915: Prevent recursion by retiring requests when the ring is full
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm
While reading some code, out of boredom, stumbled on a tiny tiny fix.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_gem_context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_context.c
b/drivers/gpu/drm/i915/i915_gem_context.c
We allocate memory in drm_display_mode_from_vic_index() and use it
without checking the pointer is valid. Fix that.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/drm_edid.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index
On Tue, Mar 04, 2014 at 09:38:40PM +0100, Kenneth Johansson wrote:
> On 2014-03-04 17:12, Jani Nikula wrote:
> >On Tue, 04 Mar 2014, Kenneth Johansson wrote:
> >>So I have a brix pro that is a i7 4700R with Intel Iris Pro Graphics 5200.
> >>and I 4k display from dell that can do 3840 x 2160 at 60
On Tue, Mar 04, 2014 at 11:44:43PM +, Damien Lespiau wrote:
> > Tried that same result. I turned on drm.debug=0x4 but for me the
> > only thing I can see is that the 60Hz mode is not in the list
>
> The EDID doesn't even list the 4k@60 fps mode, to me, this looks li
On Wed, Mar 05, 2014 at 01:12:03AM +0100, Kenneth Johansson wrote:
> I can't see anything about MST on the spec tab on the website.
> the only thing is that you have to use DP1.2 for 60Hz.
>
> the note on that line is.
And this is a confusing statement that could either mean:
- It needs HBR2 (t
On Wed, Mar 05, 2014 at 01:12:03AM +0100, Kenneth Johansson wrote:
> I can't see anything about MST on the spec tab on the website.
> the only thing is that you have to use DP1.2 for 60Hz.
>
> the note on that line is.
Ah, found the definitive source. The monitor manual...
"To display 3840 x 216
On Wed, Mar 05, 2014 at 12:27:08AM +, Damien Lespiau wrote:
> On Wed, Mar 05, 2014 at 01:12:03AM +0100, Kenneth Johansson wrote:
> > I can't see anything about MST on the spec tab on the website.
> > the only thing is that you have to use DP1.2 for 60Hz.
> >
&g
On Wed, Mar 05, 2014 at 01:46:35AM +0100, Kenneth Johansson wrote:
> Now the question is is it possible to make the i7 4770R chip(I
> guess its another chip doing the displayport stuff the cpu is only
> the gfx accellerator right) support MST and DisplayID . And if so
> what is needed in the driv
this caused bit 30 of said registers to be set, which
> caused the sprite CSC to produce incorrect results.
>
> Cc: sta...@vger.kernel.org
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72220
> Signed-off-by: Ville Syrjälä
Reviewed-by: Damien Lespiau
--
Damien
> ---
; Also note that we implemnt WaFbcAsynchFlipDisableFbcQueue:bdw.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/intel_pm.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers
we've
> given to a similar bit on earlier platforms.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/i915_reg.h | 10 ++
> drivers/gpu/drm/i915/intel_pm.c | 8
> 2 files changed, 6 insertions(+), 1
Not everyone has that git c alias defined.
Signed-off-by: Damien Lespiau
---
qf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
mode change 100755 => 100644 qf
diff --git a/qf b/qf
old mode 100755
new mode 100644
index 41f18ba..742e704
--- a/qf
+++ b/qf
@@ -158,7 +158,7 @@ funct
Signed-off-by: Damien Lespiau
---
qf | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 qf
diff --git a/qf b/qf
old mode 100644
new mode 100755
--
1.8.3.1
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.
A ':' was missing (should have been ':+'), but I think we want ':-', not
':+' ie we want to substitute if the parameter is undefined or empty:
http://www.gnu.org/software/bash/manual/bash.html#Shell-Parameter-Expansion
Signed-off-by: Damien Lespiau
This needs to be useremail, not username here.
Signed-off-by: Damien Lespiau
---
qf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qf b/qf
index 742e704..057ae08 100755
--- a/qf
+++ b/qf
@@ -298,8 +298,8 @@ case "$1" in
username=${username+`
On Wed, Mar 05, 2014 at 02:38:50PM -0800, Ben Widawsky wrote:
> It wasn't completely fortuitous, I did check. I was lucky you think my
> check was satisfactory though. I agree it makes future code somewhat
> risky so maybe some improvement is needed to safeguard. I also have/had
> a patch to length
On Mon, Feb 24, 2014 at 09:14:41PM +0530, Sagar Arun Kamble wrote:
> Gentle Reminder !!!
> Kindly review and provide feedback
This main issue here is that we don't have yet the split between the
CRTC and the primary plane in the DRM API.
Why is this a problem? because you need to define a 'plane-
On Thu, Mar 06, 2014 at 12:03:07PM +, Damien Lespiau wrote:
> On Mon, Feb 24, 2014 at 09:14:41PM +0530, Sagar Arun Kamble wrote:
> > Gentle Reminder !!!
> > Kindly review and provide feedback
>
> This main issue here is that we don't have yet the split between the
&g
While wandering in the spec, I noticed that BDW removes those 2 bits
from INSTPM. I couldn't find any direct way to invalidate the TLB (ie
without the ring working already). Maybe someone will be more lucky.
At least, we now know we may be a problem.
Signed-off-by: Damien Lespiau
---
dr
In the future, we'll need the height of the fb we're fetching from
memory for WM computation.
At some point in the future, it'd be nice to give a pointer to a
mystical plane_config structure instead of chaplet of parameters.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/
No need of any here.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_display.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index d34add5..c6743f0 100644
--- a/drivers/gpu
This function is only used on ILK+, so rename it accordingly.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 6dbaf66..47bf433 100644
chlen=%ld\n",
The ptrdiff_t type has its own modifier: 't'.
Cc: Brad Volkin
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_cmd_parser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_cmd_parser.c
b/drivers/gpu/drm/i9
On its own, "git push origin" will do something different depending on
the the push.default option. So let's speficy the full local:remote
branch here.
Signed-off-by: Damien Lespiau
---
qf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qf b/qf
index 9838ffc.
On Wed, Mar 19, 2014 at 09:44:38AM +0100, Daniel Vetter wrote:
> On Tue, Mar 18, 2014 at 01:53:56PM -0700, Siva Chandra wrote:
> > On Tue, Mar 18, 2014 at 1:06 PM, Jesse Barnes
> > wrote:
> > > On Tue, 18 Mar 2014 12:51:07 -0700
> > > Siva Chandra wrote:
> > >
> > >> This property helps one turn
On Sat, Mar 08, 2014 at 01:51:18PM +0530, sagar.a.kam...@intel.com wrote:
> From: Sagar Kamble
>
> This patch enables property for changin the pixel format
> of plane to enable/disable pre-multiplied alpha format.
> Client has to set BIT(DRM_BLEND_PREMULTIPLIED_ALPHA) | 0x0/0x1
> to disable/enabl
On Thu, Mar 20, 2014 at 03:29:42PM +0530, Sagar Arun Kamble wrote:
> Hi Damien,
>
> On Wed, 2014-03-19 at 15:10 +0000, Damien Lespiau wrote:
> > On Sat, Mar 08, 2014 at 01:51:18PM +0530, sagar.a.kam...@intel.com wrote:
> > > From: Sagar Kamble
> > >
> > &g
On Sat, Mar 08, 2014 at 01:51:16PM +0530, sagar.a.kam...@intel.com wrote:
> From: Sagar Kamble
>
> This patch creates a generic blending enum property.
> Drivers may support subset of these values.
>
> Cc: airl...@linux.ie
> Cc: dri-de...@lists.freedesktop.org
> Cc: linux-ker...@vger.kernel.org
On Sat, Mar 08, 2014 at 01:51:17PM +0530, sagar.a.kam...@intel.com wrote:
> From: Sagar Kamble
>
> This patch enables constant alpha property for Sprite planes.
> Client has to set BIT(DRM_BLEND_CONSTANT_ALPHA) | (8 bit alpha value)
> for applying constant alpha on a plane. To disable constant al
On Thu, Mar 20, 2014 at 02:51:20PM +0100, Daniel Vetter wrote:
> I don't really have a decent opinion on the pre-multiplied vs
> non-premultiplied ARGB formats issue at hand. In case of doubt I think we
> should follow what gl does. But I have no clue how that's handled in gl
> ;-)
I'd still like
On Sat, Mar 08, 2014 at 01:51:15PM +0530, sagar.a.kam...@intel.com wrote:
> From: Sagar Kamble
>
> This patch series introduces drm property modelled after glBlendFuc function.
> For i915
> constant alpha is exposed through this property to start with. Additional new
> property
> value for cont
On Sat, Mar 08, 2014 at 01:51:16PM +0530, sagar.a.kam...@intel.com wrote:
> From: Sagar Kamble
>
> This patch creates a generic blending enum property.
> Drivers may support subset of these values.
>
> Cc: airl...@linux.ie
> Cc: dri-de...@lists.freedesktop.org
> Cc: linux-ker...@vger.kernel.org
On Thu, Mar 20, 2014 at 02:11:40PM +, Damien Lespiau wrote:
> (source is premultiplied)
>
> RGBA = ADD(SRC_COLOR*SRC_ALPHA, DST_COLOR*ONE_MINUS_SRC_ALPHA)
Grr, copy/paste error. If the source is already premultiplied:
RGBA = ADD(SRC_COLOR, DST_COLOR*ONE_MINUS_SRC_ALPHA)
-
On Fri, Feb 07, 2014 at 05:52:10PM +0530, akash.g...@intel.com wrote:
> From: Akash Goel
>
> Added a new rendering specific Workaround 'WaTlbInvalidateStoreDataBefore'.
> In this WA, before pipecontrol with TLB invalidate set, need to add 2 MI
> Store data commands.
>
> v2: Modified the WA comme
For setups where we don't have gtk-doc installed, ie when the
GTK_DOC_CHECK macro doesn't expand, we still need to populate the
enable_gtk_doc variable to provide a value to the configure summary.
Cc: Thomas Wood
Signed-off-by: Damien Lespiau
---
configure.ac | 1 +
1 file changed, 1
On Fri, Mar 21, 2014 at 10:55:44AM +0100, Daniel Vetter wrote:
> > tests/Makefile.am | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/Makefile.am b/tests/Makefile.am
> > index aadcbc8..ddb0fd7 100644
> > --- a/tests/Makefile.am
> > +++ b/tests/Makefile.am
> > @
On Fri, Mar 21, 2014 at 02:40:00PM +, Damien Lespiau wrote:
> For setups where we don't have gtk-doc installed, ie when the
> GTK_DOC_CHECK macro doesn't expand, we still need to populate the
> enable_gtk_doc variable to provide a value to the configure summary.
>
&
On Thu, Mar 13, 2014 at 02:31:37PM +0530, sourab.gu...@intel.com wrote:
> From: Sourab Gupta
>
> Using MMIO based flips on VLV for Media power well residency optimization.
> The blitter ring is currently being used just for command streamer based
> flip calls. For pure 3D workloads, with MMIO fli
On Fri, Mar 21, 2014 at 07:06:46PM +0530, Sagar Arun Kamble wrote:
> Hi Damien,
>
> On Thu, 2014-03-20 at 14:45 +0000, Damien Lespiau wrote:
> > On Thu, Mar 20, 2014 at 02:11:40PM +, Damien Lespiau wrote:
> > > (source is premultiplied)
> > >
> > >
On Mon, Feb 24, 2014 at 09:11:43PM +0530, sagar.a.kam...@intel.com wrote:
> From: Sagar Kamble
>
> With this patch we allow larger cursor planes of sizes 128x128
> and 256x256.
>
> v2: Added more precise check on size while setting cursor plane.
I've just noticed that we currently hardcode 64 p
On Mon, Mar 24, 2014 at 11:00:07PM +0530, sourab.gu...@intel.com wrote:
> From: Akash Goel
>
> For disabling L3 clock gating we need to set bit 25 of MMIO
> register 940c. Earlier this was being done by just writing 1
> into bit 25 and resetting all other bits.
> This patch modifies the routine t
Using uint64_t in that second member makes it aligned to 64bits, while
the first member is only 32bits. We then had a 32bits hole in there!
Found-by: Chris Wilson
Cc: Ben Widawsky
Cc: Rafael Barbalho
Signed-off-by: Damien Lespiau
---
lib/gen8_render.h | 38
On Tue, Mar 25, 2014 at 11:51:57AM +0100, Daniel Vetter wrote:
> On Tue, Mar 25, 2014 at 03:33:42PM +0530, Sagar Arun Kamble wrote:
> > Hi Damien,
> >
> > Could you please clarify following queries.
>
> He did, in a reply to your mail ...
In case you cannot find it:
http://lists.freedesktop.o
On Tue, Mar 25, 2014 at 03:46:36PM +0530, sagar.a.kam...@intel.com wrote:
> From: Sagar Kamble
>
> Cursor size is changed now take care of larger cursor sizes.
> wm calculation was hardcoded to 64 before so changing it.
>
> Cc: Daniel Vetter
> Cc: Jani Nikula
> Cc:
Noticed that, if I'm not mistaken, we were misunderstanding the intention of
mode_config.cursor_{width,height}, and those 3 patches are the resulting fixes.
Damien Lespiau (3):
drm/i915: Don't set mode_config's cursor size
drm/i915: Remove max_cursor_{width,height} from the
Now that we can use different cursor sizes, we can't hardcode 64 pixels
as the cursor width anymore.
Cc: Sagar Kamble
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/dr
On Tue, Mar 25, 2014 at 02:54:56PM +, Chris Wilson wrote:
> On Tue, Mar 25, 2014 at 02:49:30PM +0000, Damien Lespiau wrote:
> > Those fields are supposed to be a good default value for the cursor
> > size, intended for the case where the hardware doesn't support 64x64
>
ll return 64 is we don't). If we declare 256x256, that
generic driver will use a big buffer for the cursor, without any good
reason.
Cc: Sagar Kamble
Cc: Imre Deak
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_display.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/
On Tue, Mar 25, 2014 at 03:09:16PM +, Chris Wilson wrote:
> On Tue, Mar 25, 2014 at 02:59:18PM +0000, Damien Lespiau wrote:
> > On Tue, Mar 25, 2014 at 02:54:56PM +, Chris Wilson wrote:
> > > On Tue, Mar 25, 2014 at 02:49:30PM +0000, Damien Lespiau wrote:
> > >
t need to store them elsewhere.
Cc: Sagar Kamble
Cc: Imre Deak
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_display.c | 8
drivers/gpu/drm/i915/intel_drv.h | 7 ---
2 files changed, 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drive
On Tue, Mar 25, 2014 at 04:38:24PM +, Chris Wilson wrote:
> For the record,
>
> 16:30 < agd5f> ickle, our GPUs don't have selectable cursor sizes
> 16:31 < agd5f> so on the newer ones, xf86-video-modesetting, etc. would
> allocate a 64x64 cursor and it would look squashed and funky since the
>
On Tue, Mar 25, 2014 at 04:38:24PM +, Chris Wilson wrote:
> > Are you saying the Intel DDX currently derives a different meaning to
> > the intented behaviour? in which case it can still be changed to not do
> > that?
>
> I still disagree though. This provides all the information I need to
> s
On Tue, Mar 25, 2014 at 07:23:26PM +0100, Daniel Vetter wrote:
> Or we simply do this per-pixel format with one for each framebuffer plane,
> i.e.
>
> struct drm_get_plane_fb_limits {
> uint32_t plane_id; /* in */
> uint32_t fourcc; /* in */
> struct drm_plane_limits limits[MAX_F
On Wed, Mar 26, 2014 at 12:38:15PM +, Chris Wilson wrote:
> If the cursor width is changed, we may need to recompute our WM to
> prevent untold flickering. We hope that the registers are flushed on the
> same vblank to prevent underruns...
>
> Cc: Damien Lespiau
> Cc: Saga
On Wed, Mar 26, 2014 at 12:38:14PM +, Chris Wilson wrote:
> Now that we can use different cursor size, we can not hardcode 64 pixels
> as the cursor width anymore.
>
> v2: Apply to 965gm/g4x paths as well
>
> Cc: Damien Lespiau
> Cc: Sagar Kamble
> Signed-off-by: Ch
Not implementing this W/A can lead to hangs.
Cc: Ben Widawsky
Cc: Rafael Barbalho
Cc: Ville Syrjälä
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_reg.h | 3 ++-
drivers/gpu/drm/i915/intel_pm.c | 4
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu
On Wed, Mar 26, 2014 at 06:45:11PM +, Barbalho, Rafael wrote:
> > -Original Message-
> > From: Lespiau, Damien
> > Sent: Monday, March 24, 2014 11:54 AM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Widawsky, Benjamin; Barbalho, Rafael
> > Subject: [PATCH] rendercopy/gen8: Remove a ho
ursor size
- other drivers fall back to returning 64x64
The common contract is to return a valid cursor size.
Cc: Sagar Kamble
Cc: Chris Wilson
Cc: Alex Deucher
Cc: Imre Deak
Signed-off-by: Damien Lespiau
---
include/uapi/drm/drm.h | 9 +
1 file changed, 9 insertions(+)
diff --
be
more accurate about what these value really are.
Cc: Sagar Kamble
Cc: Chris Wilson
Cc: Imre Deak
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_display.c | 19 +--
drivers/gpu/drm/i915/intel_drv.h | 5 ++---
2 files changed, 11 insertions(+), 13 deletions
A couple of cleanups to not expose some of the forcewake handling to the rest
of driver.
Damien Lespiau (2):
drm/i915: Hide vlv_force_wake_{get,put}() in intel_uncore.c
drm/i915: Hide the per forcewake-engine register ranges
drivers/gpu/drm/i915/i915_drv.h | 14 --
drivers
That function isn't used outside this file anymore.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_drv.h | 3 ---
drivers/gpu/drm/i915/intel_uncore.c | 6 ++
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gp
These defines are only used in intel_uncore.c.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_drv.h | 11 ---
drivers/gpu/drm/i915/intel_uncore.c | 11 +++
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers
printf("0x%08x\n", GEN_RANGE(4, 4));
printf("0x%08x\n", GEN_RANGE(4, 5));
printf("0x%08x\n", GEN_RANGE(1, 31));
printf("0x%08x\n", GEN_RANGE(4, 8));
return 0;
}
$ ./bit-range
0x0002
0x0006
0x0010
0x0030
On Thu, Mar 27, 2014 at 06:00:08PM +, oscar.ma...@intel.com wrote:
> + reg_state[CTX_PDP3_UDW+1] = ppgtt->pd_dma_addr[3] >> 32;
> + reg_state[CTX_PDP3_LDW+1] = ppgtt->pd_dma_addr[3];
> + reg_state[CTX_PDP2_UDW+1] = ppgtt->pd_dma_addr[2] >> 32;
> + reg_state[CTX_PDP2_LDW+1] = ppg
On Thu, Mar 27, 2014 at 05:59:48PM +, oscar.ma...@intel.com wrote:
> + if (ring->id == RCS)
> + reg_state[CTX_LRI_HEADER_0] = MI_LOAD_REGISTER_IMM(14);
> + else
> + reg_state[CTX_LRI_HEADER_0] = MI_LOAD_REGISTER_IMM(11);
In the "Register State Context", this hea
On Thu, Mar 27, 2014 at 05:59:46PM +, oscar.ma...@intel.com wrote:
> --- a/drivers/gpu/drm/i915/i915_lrc.c
> +++ b/drivers/gpu/drm/i915/i915_lrc.c
> @@ -41,7 +41,45 @@
> #include
> #include "i915_drv.h"
>
> +#define GEN8_LR_CONTEXT_SIZE (21 * PAGE_SIZE)
I'm a bit puzzled by that number:
On Tue, Apr 01, 2014 at 02:47:19PM +0100, Mateo Lozano, Oscar wrote:
> > > --- a/drivers/gpu/drm/i915/i915_lrc.c
> > > +++ b/drivers/gpu/drm/i915/i915_lrc.c
> > > @@ -41,7 +41,45 @@
> > > #include
> > > #include "i915_drv.h"
> > >
> > > +#define GEN8_LR_CONTEXT_SIZE (21 * PAGE_SIZE)
> >
> > I'm
On Tue, Apr 01, 2014 at 12:18:24PM -0700, Ben Widawsky wrote:
> On Tue, Apr 01, 2014 at 02:51:27PM +0100, Damien Lespiau wrote:
> > On Tue, Apr 01, 2014 at 02:47:19PM +0100, Mateo Lozano, Oscar wrote:
> > > > > --- a/drivers/gpu/drm/i915/i915_lrc.c
> > > > >
On Tue, Apr 01, 2014 at 03:37:27PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> We should only enable interrupts at postinstall.
>
> And now on ILK/SNB/IVB/HSW the irq_preinstall and irq_postinstall
> functions leave the hardware in the same state.
>
> Signed-off-by: Paulo Zanoni
Ortho
On Thu, Mar 27, 2014 at 06:00:10PM +, oscar.ma...@intel.com wrote:
> @@ -543,6 +545,9 @@ static int init_ring_common_lrc(struct intel_engine *ring)
> ringbuf->space = ringbuf->size;
> ringbuf->last_retired_head = -1;
>
> + I915_WRITE_IMR(ring, ~(ring->irq_enable_mask | ring->i
On Wed, Apr 02, 2014 at 01:49:38PM +0200, Daniel Vetter wrote:
> On Wed, Apr 02, 2014 at 12:42:11PM +0100, Damien Lespiau wrote:
> > On Thu, Mar 27, 2014 at 06:00:10PM +, oscar.ma...@intel.com wrote:
> > > @@ -543,6 +545,9 @@ static int init_ring_common_lrc(struct intel_e
On Thu, Mar 27, 2014 at 06:00:08PM +, oscar.ma...@intel.com wrote:
> +static int gen8_write_pdp_ctx(struct i915_hw_context *ctx,
> +struct i915_hw_ppgtt *ppgtt)
> +{
> + struct page *page;
> + uint32_t *reg_state;
> +
> + page = i915_gem_object_get_pa
On Wed, Apr 02, 2014 at 04:28:06PM +0100, Chris Wilson wrote:
> On Wed, Apr 02, 2014 at 11:14:58AM -0300, Paulo Zanoni wrote:
> > 2014-04-02 8:27 GMT-03:00 Chris Wilson :
> > > On Wed, Apr 02, 2014 at 12:23:51PM +0100, Chris Wilson wrote:
> > >> On Wed, Apr 02, 20
On Mon, Mar 31, 2014 at 06:21:28PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Print the enable_mask and status_mask from
> __i915_{enable,disable}_pipestat() when the called has messed them up
> somehow.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/i
Fix a typo in the commit message
>
> Reviewed-by: Jesse Barnes
> Signed-off-by: Ville Syrjälä
Reviewed-by: Damien Lespiau
> ---
> drivers/gpu/drm/i915/i915_irq.c | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i
On Thu, Apr 03, 2014 at 11:30:16AM +0200, Daniel Vetter wrote:
> I've merged all the patches Jesse reviewed from this series, expect the
> one Damien has a bikeshed pending.
It wasn't bikeshedding, we were printing "%c",0 instead of "%c",'A' :)
--
Damien
_
401 - 500 of 2567 matches
Mail list logo
