render state initialization
> drm/i915: add null render states for gen6, gen7 and gen8
Acked-by: Damien Lespiau
>
> drivers/gpu/drm/i915/Makefile |6 +
> drivers/gpu/drm/i915/i915_drv.h |2 +
> drivers/gpu/drm/i915/i915_g
On Wed, May 14, 2014 at 10:24:53AM +, Mateo Lozano, Oscar wrote:
> Hi Mika,
>
> > -Original Message-
> > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf
> > Of
> > Mika Kuoppala
> > Sent: Tuesday, May 06, 2014 3:30 PM
> > To: intel-gfx@lists.freedesktop.org
On Tue, May 13, 2014 at 03:28:27PM +0200, Daniel Vetter wrote:
> On Fri, May 09, 2014 at 01:08:36PM +0100, oscar.ma...@intel.com wrote:
> > From: Oscar Mateo
> >
> > In the upcoming patches, we plan to break the correlation between
> > engines (a.k.a. rings) and ringbuffers, so it makes sense to
init (Ben Widawsky)
>
> v3: - move to cpu/gpu (Chris Wilson)
>
> Tested-by: Kristen Carlson Accardi (v1)
> Tested-by: Oscar Mateo
> Acked-by: Damien Lespiau
This one can be upgraded to a:
Reviewed-by: Damien Lespiau
--
Damien
__
On Wed, May 14, 2014 at 06:00:46PM +0200, Daniel Vetter wrote:
> I want to use them elsewhere ...
>
> Signed-off-by: Daniel Vetter
> ---
> lib/igt_aux.c | 114
> +
> lib/igt_aux.h | 11 ++
> tests/pm_pc8.c | 96 ++--
On Wed, May 14, 2014 at 08:34:03PM +0200, Daniel Vetter wrote:
> On Wed, May 14, 2014 at 06:50:27PM +0100, Damien Lespiau wrote:
> > On Wed, May 14, 2014 at 06:00:46PM +0200, Daniel Vetter wrote:
> > > I want to use them elsewhere ...
> > >
> > > Signed-off-by:
On Thu, May 15, 2014 at 05:05:05PM +0300, Ville Syrjälä wrote:
> > I must be missing something important. The FBC buffer is the only one
> > requiring a non-zero offset from the base of stolen memory.
>
> Nothing important can be placed there since the CS apparently writes
> there without anyone e
On Mon, Apr 14, 2014 at 11:18:24AM +0530, Shobhit Kumar wrote:
> In VBT fields operation mode is 0 for Video mode and 1 for command mode.
> This field will be directly used as is in generic panel driver. So
> adjust accordingly.
>
> Signed-off-by: Shobhit Kumar
Reviewed-by:
On Mon, Apr 14, 2014 at 11:18:25AM +0530, Shobhit Kumar wrote:
> Signed-off-by: Shobhit Kumar
Reviewed-by: Damien Lespiau
--
Damien
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
nabling support
>
> Signed-off-by: Shobhit Kumar
Just a small note on patch ordering, You're using values that no code
initializes yet, doesn't matter at all this time.
Reviewed-by: Damien Lespiau
--
Damien
___
Intel-gfx mailing list
Intel
On Mon, Apr 14, 2014 at 11:18:27AM +0530, Shobhit Kumar wrote:
> This driver makes use of the generic panel information from the VBT.
> Panel information is classified into two - panel configuration and panel
> power sequence which is unique to each panel. The generic driver uses the
> panel config
On Thu, May 15, 2014 at 05:48:57PM +0100, Damien Lespiau wrote:
> > +static struct gpio_table gtable[] = {
>
> const
>
Please, disregard this comment. It's being written to to track GPIO
initialization.
--
Damien
___
Intel-gfx ma
On Mon, Apr 14, 2014 at 11:18:27AM +0530, Shobhit Kumar wrote:
> +#define NS_MHZ_RATIO 100
[...]
> +static bool generic_init(struct intel_dsi_device *dsi)
> +{
[...]
> + /*
> + * ui(s) = 1/f [f in hz]
> + * ui(ns) = 10^9/f*10^6 [f in Mhz] -> 10^3/f(Mhz)
ui(ns) = 10^9/(f*10^6)
7;s something
we've clearly defined.
Also the error message is not super clear and uses Mipi instead of MIPI,
we always captalize it elsewhere.
Depending on how much bikesheddy other peole are:
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/i915_drv.h |3
On Mon, May 19, 2014 at 08:54:04PM +0530, Shashank Sharma wrote:
> Re-define MIPI register definitions in such a way that most of
> the existing DSI code can be re-used for future platforms. Register
> definitions are re-written using MMIO offset variable, so that without
> changing the existing se
ount == 0)
pll->hw_state = crtc->config.dpll_hw_state
Oh well.
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/intel_display.c | 12 +---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i9
we need to first make the
> haswell code save before we can touch the core code.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/intel_display.c | 26 +++---
> 1 file changed, 19 insertions(+),
On Thu, Apr 24, 2014 at 11:55:14PM +0200, Daniel Vetter wrote:
> Besides the fairly useless BUG_ON the logic is completely generic
> and cane be used on any platform what wants to reuse the shared
> dpll support code.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: Damien Lespi
On Thu, Apr 24, 2014 at 11:55:31PM +0200, Daniel Vetter wrote:
> Signed-off-by: Daniel Vetter
The list of CRTCs using those shared PLLs would also be useful in the
mix.
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 26 ++
On Thu, Apr 24, 2014 at 11:55:32PM +0200, Daniel Vetter wrote:
> Just boring sed job for preparation.
>
> Signed-off-by: Daniel Vetter
We want want a ddi structure to gather all the DDI config fields later
down the road.
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drive
: Make use of the read-out ddi_pll_sel in intel_ddi_clock_get.
>
> Signed-off-by: Daniel Vetter
Moving things out of intel_ddi.c to intel_display.c seems to be the
opposite of what we want. I don't see why we couldn't leave the DDI
readout function inside intel_ddi.c?
Reviewed-by: Da
On Thu, Apr 24, 2014 at 11:55:34PM +0200, Daniel Vetter wrote:
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -272,6 +272,7 @@ void intel_ddi_put_crtc_pll(struct drm_crtc *crtc)
> I915_WRITE(WRPLL_CTL1, val & ~WRPLL_PLL_ENABLE);
>
by: Daniel Vetter
With the consts added:
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/i915_drv.h | 6 --
> drivers/gpu/drm/i915/intel_ddi.c | 17 +
> drivers/gpu/drm/i915/intel_display.c | 21 +
> 3 fi
On Thu, Apr 24, 2014 at 11:55:36PM +0200, Daniel Vetter wrote:
> The WRPLLs won't use them.
>
> Signed-off-by: Daniel Vetter
/*
* Comments spawning multiple lines are formatted...
* ...this way
*/
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/i9
On Thu, Apr 24, 2014 at 11:55:37PM +0200, Daniel Vetter wrote:
> Still tacked onto the side, but slowly getting there.
>
> v2: Don't forget the debugfs file.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: Damien Lespiau
> ---
> drivers/gpu/drm/i915/i915_debugfs.c
-by: Daniel Vetter
Reviewed-by: Damien Lespiau
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 51
> +++-
> 1 file changed, 19 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> b/drivers/gpu/drm/i915/intel_d
e the right pll.
>
> Signed-off-by: Daniel Vetter
With the small bikeshed below:
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 27 ---
> drivers/gpu/drm/i915/intel_display.c | 8 +---
> 2 files change
_set and off hooks. But changing the actual hardware sequence
> will be done in the next step.
>
> Note that besides the massive amount of changes in this patch the
> places and order in which the low-level WRPLL code is called is
> absolutely unchanged.
>
> Signed-off-by: Da
ut and cross checking. Which allows us to do this switch in
> a fairly small patch.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: Damien Lespiau
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 12 +---
> drivers/gpu/drm/i915/intel_display.c | 16 +++-
>
On Wed, Apr 09, 2014 at 01:28:41PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> The following workarounds should be needed for pre-production hardware
> only:
> * WaDisablePwrmtrEvent:chv
> * WaSetMaskForGfxBusyness:chv
> * WaDisableGunitClockGating:chv
> * WaDisableFfDop
On Tue, May 20, 2014 at 04:41:13PM +0300, Ville Syrjälä wrote:
> On Tue, May 20, 2014 at 02:22:51PM +0100, Damien Lespiau wrote:
> > On Wed, Apr 09, 2014 at 01:28:41PM +0300, ville.syrj...@linux.intel.com
> > wrote:
> > > From: Ville Syrjälä
> > >
> >
On Fri, Apr 25, 2014 at 08:14:30PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> The comments in i915_reg.h aren't proper kernel-doc comments, so replace
> the magic /** with just /*
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Dami
On Tue, May 20, 2014 at 09:46:01PM +0530, Shobhit Kumar wrote:
> >- UI is a period, so is homogeneous to time (s), but ui_num being in
> > s^-1 and ui_den a constant, ui_num/ui_den looks like a frequency. Or
> > could it be that UI = ui_den / ui_num? would be confusing, but the
> > code below
ille Syrjälä
I guess one could also add the AUX units here as well. But that's still
way better than what we currently have.
Reviewed-by: Damien Lespiau
--
Damien
> ---
> Documentation/DocBook/drm.tmpl | 86
> ++
> 1 file changed, 86 in
On Wed, May 21, 2014 at 06:35:12PM +0300, Ville Syrjälä wrote:
> > +
> > +/* VLV port control */
> > #define _MIPIA_PORT_CTRL (VLV_DISPLAY_BASE + 0x61190)
> > #define _MIPIB_PORT_CTRL (VLV_DISPLAY_BASE + 0x61700)
> > #define MIPI_PORT_CTRL(pipe)
ts to have more clarity
> - using max() instead of ternary operator
> - Fix names (ui_num, ui_den) while using UI in calculations
> - compute max of lp_to_hs switch and hs_to_lp switch while computing
> hs_lp_switch_count
>
> Signed-off-by: Shobhit Kumar
Hopefull
On Fri, May 23, 2014 at 09:39:28PM +0530, Shobhit Kumar wrote:
> It seems by default the VBT has MIPI configuration block as well. The
> Generic driver will assume always MIPI if MIPI configuration block is found.
> This is causing probelm when actually there is eDP. Fix this by looking
> into gene
On Tue, May 27, 2014 at 01:51:22PM +0200, Daniel Vetter wrote:
> > Hmm, I will check my vim config and be more careful next time. Thanks for
> > pointing out. Have you taken care of these or I will push another patch to
> > fix the alignment issues ?
>
> Yeah, a quick fixup patch would be pretty.
On Tue, May 27, 2014 at 05:40:23PM +0530, Kumar, Shobhit wrote:
> >>struct {
> >>+ u16 port;
> >
> >We store the port but never use it, is it needed?
>
> Just wanted to store as we might want to use later while enabling.
> Shouldn't harm ? In fact we have a need to enable PORT C inte
as_mipi;
I meant this can be added in the bitfield (after
fdi_rx_polarity_inverted) so it only takes 1 bit
Otherwise:
Reviewed-by: Damien Lespiau
--
Damien
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Sorry to be such a bore but:
On Tue, May 27, 2014 at 07:33:59PM +0530, Shobhit Kumar wrote:
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -660,6 +660,10 @@ bool intel_dsi_init(struct drm_device *dev)
>
> DRM_DEBUG_KMS("\n");
>
> + /* There is
ric MIPI panel driver
>
> Fixed all except the DRM logging which go beyond line 80
>
> Signed-off-by: Shobhit Kumar
To squash into previous commit?
Reviewed-by: Damien Lespiau
--
Damien
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop
rmat and the second line not aligned
with the '(' as we usually do:
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/intel_pm.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gp
On Tue, May 27, 2014 at 05:31:42PM +0300, Ville Syrjälä wrote:
> On Tue, May 27, 2014 at 03:17:15PM +0100, Damien Lespiau wrote:
> > Sorry to be such a bore but:
> >
> > On Tue, May 27, 2014 at 07:33:59PM +0530, Shobhit Kumar wrote:
> > > --- a/drivers/gpu/drm/i915/i
On Tue, May 27, 2014 at 08:04:43PM +0530, Kumar, Shobhit wrote:
> On 5/27/2014 7:49 PM, Damien Lespiau wrote:
> >On Tue, May 27, 2014 at 07:23:46PM +0530, Shobhit Kumar wrote:
> >>Fix warnings introduced by the following commit -
> >>
> >>commit 9c92da2c7c17eea
On Tue, May 27, 2014 at 10:12:07AM +0200, Daniel Vetter wrote:
> diff --git a/drivers/gpu/drm/i915/intel_drv.h
> b/drivers/gpu/drm/i915/intel_drv.h
> index 0542de982260..6d86820d350b 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -327,6 +327,7 @@ stru
lle Syrjälä
Suggested-by: Shobhit Kumar
Cc: Ville Syrjälä
Cc: Shobhit Kumar
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_drv.h | 2 +-
drivers/gpu/drm/i915/intel_dsi.c | 12 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_drv
People from distros have reported that packaging the newer versions is
more difficult because we now depend on SWIG. We don't have to, it's
needed for the python dumper and is an optional build dependency.
Signed-off-by: Damien Lespiau
---
configure.ac | 8 +++-
1 file changed, 7
Signed-off-by: Damien Lespiau
---
tests/kms_pipe_crc_basic.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
index c4abdf7..5727b61 100644
--- a/tests/kms_pipe_crc_basic.c
+++ b/tests/kms_pipe_crc_basic.c
@@ -127,8 +127,13
Sometimes it's practical to be able to set the logging level to debug
from the command line arguments.
Signed-off-by: Damien Lespiau
---
lib/igt_core.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib/igt_core.c b/lib/igt_core.c
index 6e553cf..9d59ab4 100644
--- a/lib/igt_c
-sequence
succeeds, using pipe B turning the power well on.
--
Damien
Damien Lespiau (6):
kms_pipe_crc_basic: Split the main test function a bit more
kms_pipe_crc_basic: Cycle between 2 differently colored buffer
kms_pipe_crc_basic: Make the number of CRCs a parameter
kms_pipe_crc_basic
Let's make the test a bit more generic and have the number of CRCs we're
collecting a define so it can be changed easily.
Signed-off-by: Damien Lespiau
---
tests/kms_pipe_crc_basic.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --g
So we have a change to see something on the screen, while still being
relatively short (~1s per sub-test).
Signed-off-by: Damien Lespiau
---
tests/kms_pipe_crc_basic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
Let's put the per-output test in its own function to get rid of 1 level
of indentation. We'll need it to cycle through 2 different framebuffers
to make sure we compute different CRCs if the fbs are different.
Signed-off-by: Damien Lespiau
---
tests/kms_pipe_crc_bas
Instead of just testing if the CRCs are stable, we also test 2 different
fbs to make sure that the CRC is actually changing.
Signed-off-by: Damien Lespiau
---
tests/kms_pipe_crc_basic.c | 95 +-
1 file changed, 61 insertions(+), 34 deletions(-)
diff
On Thu, May 29, 2014 at 12:27:55AM +0200, Daniel Vetter wrote:
> - if (IS_HASWELL(dev) &&
> intel_crtc->config.pch_pfit.enabled)
> + if (IS_HASWELL(dev) &&
> intel_crtc->config.pch_pfit.enabled ||
> + intel_crtc->config.pch_pfit.forc
On Thu, May 29, 2014 at 12:41:44PM +0200, Daniel Vetter wrote:
> On Thu, May 29, 2014 at 1:21 AM, Damien Lespiau
> wrote:
> > On Thu, May 29, 2014 at 12:27:55AM +0200, Daniel Vetter wrote:
> >> - if (IS_HASWELL(dev) &&
> >&g
On Fri, May 30, 2014 at 09:05:41AM +0100, Sharma, Shashank wrote:
> From: Sharma, Shashank
> Sent: Thursday, May 22, 2014 5:02 PM
> To: intel-gfx@lists.freedesktop.org; Lespiau, Damien;
> ville.syrj...@linux.intel.com; Vetter, Daniel
> Cc: Kumar, Shobhit; Sharma, Shashank
> Subject: [PATCH 2/2] d
On Fri, May 30, 2014 at 08:12:34PM +0530, Shashank Sharma wrote:
> Re-define MIPI register definitions in such a way that most of
> the existing DSI code can be re-used for future platforms. Register
> definitions are re-written using MMIO offset variable, so that without
> changing the existing se
On Sat, May 31, 2014 at 01:32:42PM +0530, Shashank Sharma wrote:
> Re-define MIPI register definitions in such a way that most of
> the existing DSI code can be re-used for future platforms. Register
> definitions are re-written using MMIO offset variable, so that without
> changing the existing se
On Sun, Jun 01, 2014 at 06:41:54AM +0100, Sharma, Shashank wrote:
> Hi Damien,
> Please correct me if I am missing something, but the only reason we
> are seeing those extra formatting changes is, almost all of the old
> MIPI register definitions were beyond 80 char, and was checked in like
> that
On Sun, Jun 01, 2014 at 07:24:47PM +0530, Shashank Sharma wrote:
>
> /* XXX: all bits reserved */
> -#define _MIPIA_AUTOPWG (VLV_DISPLAY_BASE +
> 0x611a0)
> +#define _MIPIA_AUTOPWG (dev_priv->mipi_mmio_base +
> 0x611a0)
This one isn't part o
oved 80 char limit formatting for existing MIPI regs
> V6: Removed extra space, change one definition
>
> Signed-off-by: Shashank Sharma
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/i915_reg.h | 183
>
> 1 fil
h 2
>
> Signed-off-by: Shashank Sharma
You still have a few inconsistencies here and there because you tried to
get everything under 80 chars in a previous version. Oh well. I guess we
can have a pass on top if someone's OCD is uncontrollable.
Reviewed-by: Damien Lespiau
--
Da
ncluded in the passed in power domain.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=79505
> References: https://bugs.freedesktop.org/show_bug.cgi?id=79038
> Reported-by: Chris Wilson
> Signed-off-by: Imre Deak
Reviewed-by: Damien Lespiau
--
Damien
On Mon, Jun 02, 2014 at 01:55:13PM +0100, Sharma, Shashank wrote:
> Hi Damien,
>
> Can you please point out these, as this patch is re-based on latest
> 2/3, I was expecting this to be without any inconsistency.
> I personally checked for any <80 char formatting, which is not
> required. But if
On Mon, Jun 02, 2014 at 04:59:39PM +0200, Robin Schroer wrote:
> Fixed several double space pointer notations, and added one newline
>
> Signed-off-by: Robin Schroer
Reviewed-by: Damien Lespiau
--
Damien
___
Intel-gfx mailing list
mit b840d907fcf6d5d5ef91af4518b3dab3a5da0f75
Author: Jesse Barnes
Date: Tue Dec 13 13:19:38 2011 -0800
drm/i915: add SNB and IVB video sprite support v6
Reviewed-by: Damien Lespiau
> ---
> drivers/gpu/drm/i915/intel_drv.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/dr
On Tue, Jun 03, 2014 at 03:05:14PM +0300, Jani Nikula wrote:
> > - return false;
> > + return;
>
> Okay this went in already, but I find return statements at the end of
> void functions like that a bit silly...
>
> ...but hey, you can send a fix removing that! ;)
Sigh, will do, thanks for po
intel_dsi_init() lost its return value in:
Damien Lespiau
Date: Wed May 28 12:30:56 2014 +0100
drm/i915: Make intel_dsi_init() return void
However, I left a return; at the end of the function and, as Jani noticed, it
looks silly.
Suggested-by: Jani Nikula
Signed-off-by: Damien
On Tue, Jun 03, 2014 at 04:35:01PM +0300, Jani Nikula wrote:
> On Tue, 03 Jun 2014, Damien Lespiau wrote:
> > intel_dsi_init() lost its return value in:
> >
> > Damien Lespiau
> > Date: Wed May 28 12:30:56 2014 +0100
> >
> > drm/i915: Make intel
On Fri, Jun 06, 2014 at 08:22:08AM +0200, Daniel Vetter wrote:
> + mutex_lock(&crtc->base.mutex);
> + if (crtc->active)
> + intel_wait_for_vblank(dev, pipe);
> + mutex_unlock(&crtc->base.mutex);
drivers/gpu/drm/i915/i915_debugfs.c: In functio
pipe_name() returns an ascii character.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_fbdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_fbdev.c
b/drivers/gpu/drm/i915/intel_fbdev.c
index 088fe93..27975c3 100644
--- a/drivers
DRM_COMMAND_END is 0xa0, so the last driver ioctl is 0x9f, not 0x99.
Signed-off-by: Damien Lespiau
---
include/uapi/drm/drm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h
index 9abbeb9..b0b8556 100644
--- a/include/uapi/drm
It was reported that this comment was confusing, and indeed it is.
Signed-off-by: Damien Lespiau
---
include/uapi/drm/i915_drm.h | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
index ff57f07..eacd063 100644
I cannot see a need to provide a DRM_ version of ARRAY_SIZE(), only used
in a few places. I suspect its usage has been spread by copy & paste
rather than anything else.
Let's just remove it for plain ARRAY_SIZE().
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/armada/armada_drv.
It was reported a long time ago the various comments about the DRM/driver
specific ioctl split were confusing. So tried to fix that.
Patch #1 is a bonus patch that removes DRM_ARRAY_SIZE().
--
Damien
Damien Lespiau (3):
drm: Remove DRM_ARRAY_SIZE() for ARRAY_SIZE()
drm: Driver-specific
On Mon, Jun 09, 2014 at 10:06:49AM -0700, Tom.O'rou...@intel.com wrote:
> From: Tom O'Rourke
>
> In gen8_enable_rps, don't write CHV registers unless IS_CHERRYVIEW.
>
> Signed-off-by: Tom O'Rourke
A lovely catch.
Reviewed-by: Damien Lespiau
--
Da
The "usage" text should explain it all. I found, in my quilt series
handling endeavours, that I wanted to be able to shift the prefix
numbers of a patch series.
Signed-off-by: Damien Lespiau
---
frob-patch-rank | 47 +++
1 file changed, 47
The "usage" text should explain it all. I found, in my quilt series
handling endeavours, that I wanted to be able to shift the prefix
numbers of a patch series.
v2: Use heredoc for usage string, fix second example, use mv -i (Jani)
Signed-off-by: Damien Lespiau
---
frob-patch
Signed-off-by: Damien Lespiau
---
scripts/list-workarounds | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/list-workarounds b/scripts/list-workarounds
index 68200dc..5a84ee8 100755
--- a/scripts/list-workarounds
+++ b/scripts/list-workarounds
@@ -17,7 +17,8 @@ def
Signed-off-by: Damien Lespiau
---
lib/igt_kms.c | 148 ++
lib/igt_kms.h | 13 +-
2 files changed, 150 insertions(+), 11 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 64fb39a..3b75478 100644
--- a/lib/igt_kms.c
+++ b
So we can easily cycle through them in tests without knowing too many
internal details about how igt_display_t organize its data.
Signed-off-by: Damien Lespiau
---
lib/igt_kms.h | 4
1 file changed, 4 insertions(+)
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 80cdfb6..1d06767 100644
Signed-off-by: Damien Lespiau
---
tests/kms_pipe_crc_basic.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
index fdec077..7d48ca6 100644
--- a/tests/kms_pipe_crc_basic.c
+++ b/tests/kms_pipe_crc_basic.c
In this case, we also take care of starting/stopping the CRC collection.
Signed-off-by: Damien Lespiau
---
lib/igt_debugfs.c | 14 ++
lib/igt_debugfs.h | 1 +
2 files changed, 15 insertions(+)
diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index a0d84bf..4a4a4dd 100644
--- a
On Thu, Jan 23, 2014 at 11:15:33PM +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Add an encoder specific hook to be called alongside the crtc .off()
> hook.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Damien Le
eople may consider that
> an improvement.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Damien Lespiau
--
Damien
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
second doesn't get any
> infoframes. And if there's a DVI sink on the other port, it will
> no longer disable DIP transmission for the other port.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Damien Lespiau
I guess follow-up patches could turn off Video DIPs on other pla
On Mon, Feb 10, 2014 at 02:53:29PM +0200, Ville Syrjälä wrote:
> > Since every access should now go through the macro I think it'd be good to
> > give this a __ prefix to make it clear that users better think twice
> > before using it. Maybe as a patch on top of all this?
>
> No. Everyone having t
tion.
>
> Signed-off-by: Paulo Zanoni
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/intel_display.c | 29 ++---
> 1 file changed, 14 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
>
On Fri, Jan 17, 2014 at 01:51:10PM -0200, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> Now that we pass struct intel_crtc as an argument, there's no need for
> it.
>
> Signed-off-by: Paulo Zanoni
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/
On Fri, Jan 17, 2014 at 01:51:11PM -0200, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> Now that we pass struct intel_crtc as an argument, we can check for
> DSI inside the function, removing one more of those confusing boolean
> arguments.
>
> Signed-off-by: Paulo Zanoni
the previous HW gens.
>
> Signed-off-by: Paulo Zanoni
Reviewed-by: Damien Lespiau
Looking at BSpec for info on this, I didn't find any mention of having
to wait of a vblank indeed. There's a nice workaround we don't seem to
implement though (underrun when switching from one to multi
FORCE. So let's add a WARN that serves two purposes:
> - tell us in case we have done something wrong;
> - document the only case where we expect this.
>
> Signed-off-by: Paulo Zanoni
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/intel_display
like it, but this is quite a large difference, and I've
> been unable to reproduce > 5 msec delays at all, while before they do
> happen (just not in the trace above)."
>
> gem_gtt_hog on an old Pineview (GMA3150),
> before: 4969.119ms
> after: 4122.749ms
>
>
rjälä (for v3)
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_dma.c | 32 +++-
drivers/gpu/drm/i915/i915_reg.h | 2 ++
2 files changed, 33 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index e2
If we can't actually determine at run-time we have a fused-off display,
provide at least an option to disable it.
v2: Move the i915.disable_display test in a separate check
(Daniel Vetter)
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_dma.c| 9 ++---
drivers/gp
On Fri, Feb 07, 2014 at 02:48:44PM +, Damien Lespiau wrote:
> The goal of that series is to introduce a small mode setting API to write our
> KMS tests, port kms_pipe_crc_basic and kms_cursor_crc to it and introduce a
> new kms_plane test.
So, I've pushed that series, nobdy see
In the future, we need to be able to specify per-pipe number of planes.
Let's start today!
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_dma.c | 14 +++---
drivers/gpu/drm/i915/i915_drv.h | 4 ++--
drivers/gpu/drm/i915/intel_display.c | 4 ++--
3 files ch
On Wed, Feb 12, 2014 at 02:28:50PM -0800, Ben Widawsky wrote:
> I keep meaning to do this... by now almost the entire file has been
> written by an Intel employee (including Daniel post-2010).
>
> Signed-off-by: Ben Widawsky
> ---
> drivers/gpu/drm/i915/i915_gem_gtt.c | 1 +
> 1 file changed, 1
301 - 400 of 2567 matches
Mail list logo
