[Intel-gfx] [PATCH 0/2] Splitting intel-gtt calls for non-x86 platforms

2022-03-18 Thread Casey Bowman
splitting the calls, it's very much open to discussion. Casey Bowman (2): drm/i915: Require INTEL_GTT to depend on X86 drm/i915/gt: Split intel-gtt functions by arch drivers/gpu/drm/i915/Kconfig| 2 +- drivers/gpu/drm/i915/Makefile | 2 + drivers/gpu/drm

[Intel-gfx] [PATCH 1/2] drm/i915: Require INTEL_GTT to depend on X86

2022-03-18 Thread Casey Bowman
The intel-gtt module is not used on other, non-x86 platforms, so we will restrict it to x86 platforms only. Signed-off-by: Casey Bowman --- drivers/gpu/drm/i915/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/2] drm/i915/gt: Split intel-gtt functions by arch

2022-03-18 Thread Casey Bowman
implementations. Signed-off-by: Casey Bowman --- drivers/gpu/drm/i915/Makefile | 2 + drivers/gpu/drm/i915/gt/intel_ggtt.c| 97 + drivers/gpu/drm/i915/gt/intel_gt.c | 6 +- drivers/gpu/drm/i915/gt/intel_gtt.h | 10 ++ drivers/gpu/drm/i915/gt

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Require INTEL_GTT to depend on X86

2022-03-19 Thread Casey Bowman
On 3/18/22 20:40, Lucas De Marchi wrote: On Fri, Mar 18, 2022 at 07:00:41PM -0700, Casey Bowman wrote: The intel-gtt module is not used on other, non-x86 platforms, so we will restrict it to x86 platforms only. Signed-off-by: Casey Bowman this should probably be the second patch, not the

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Split intel-gtt functions by arch

2022-03-19 Thread Casey Bowman
On 3/18/22 20:39, Lucas De Marchi wrote: On Fri, Mar 18, 2022 at 07:00:42PM -0700, Casey Bowman wrote: Some functions defined in the intel-gtt module are used in several areas, but is only supported on x86 platforms. By separating these calls and their static underlying functions to area

Re: [Intel-gfx] [RFC PATCH v3 1/1] i915/drm: Split out x86/arm64 for run_as_guest

2022-03-21 Thread Casey Bowman
) ... #else ... #endif Would we also prefer this RFC series be merged or would it be preferred to create a new series instead? Regards, Casey On 2/15/22 15:41, Casey Bowman wrote: Splitting out run_as_guest into platform-specific functions as arm64 does not support this functionality. Signed

[Intel-gfx] [PATCH v4 1/1] i915/drm: Split run_as_guest into x86 and non-x86

2022-03-22 Thread Casey Bowman
Splitting run_as_guest into a more arch-friendly function as non-x86 builds do not support this functionality. Signed-off-by: Casey Bowman --- drivers/gpu/drm/i915/i915_drv.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v4 0/1] Splitting up platform-specific calls

2022-03-22 Thread Casey Bowman
more arch-neutral split. Casey Bowman (1): i915/drm: Split run_as_guest into x86 and non-x86 drivers/gpu/drm/i915/i915_drv.h | 5 + 1 file changed, 5 insertions(+) -- 2.25.1

[Intel-gfx] [PATCH v2 0/2] Splitting intel-gtt calls for non-x86 platforms

2022-03-29 Thread Casey Bowman
splitting the calls, it's very much open to discussion. v2: Refactored to move gmch functions, renamed exported functions Casey Bowman (2): drm/i915/gt: Split intel-gtt functions by arch drm/i915: Require INTEL_GTT to depend on X86 drivers/gpu/drm/i915/Kconfig| 2 +- driver

[Intel-gfx] [PATCH v2 2/2] drm/i915: Require INTEL_GTT to depend on X86

2022-03-29 Thread Casey Bowman
The intel-gtt module is not used on other, non-x86 platforms, so we will restrict it to x86 platforms only. Signed-off-by: Casey Bowman --- drivers/gpu/drm/i915/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Split intel-gtt functions by arch

2022-03-29 Thread Casey Bowman
implementations. In addition to the problematic calls, we are moving the gmch-related functions to the new area. Signed-off-by: Casey Bowman --- drivers/gpu/drm/i915/Makefile | 2 + drivers/gpu/drm/i915/gt/intel_ggtt.c| 663 +--- drivers/gpu/drm/i915/gt/intel_gt.c

[Intel-gfx] [PATCH v3 2/2] drm/i915: Require INTEL_GTT to depend on X86

2022-03-29 Thread Casey Bowman
The intel-gtt module is not used on other, non-x86 platforms, so we will restrict it to x86 platforms only. Signed-off-by: Casey Bowman --- drivers/gpu/drm/i915/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v3 0/2] Splitting intel-gtt calls for non-x86 platforms

2022-03-29 Thread Casey Bowman
splitting the calls, it's very much open to discussion. v2: Refactored to move gmch functions, renamed exported functions v3: Added drm/i915_drm.h header Casey Bowman (2): drm/i915/gt: Split intel-gtt functions by arch drm/i915: Moved drm/i915_drm.h header to intel_gt_gmch.c drivers/gp

[Intel-gfx] [PATCH v3 1/2] drm/i915/gt: Split intel-gtt functions by arch

2022-03-29 Thread Casey Bowman
implementations. In addition to the problematic calls, we are moving the gmch-related functions to the new area. Signed-off-by: Casey Bowman --- drivers/gpu/drm/i915/Makefile | 2 + drivers/gpu/drm/i915/gt/intel_ggtt.c| 665 +--- drivers/gpu/drm/i915/gt/intel_gt.c

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/gt: Split intel-gtt functions by arch

2022-03-30 Thread Casey Bowman
On 3/30/22 03:23, Jani Nikula wrote: On Wed, 30 Mar 2022, Tvrtko Ursulin wrote: On 30/03/2022 00:58, Casey Bowman wrote: Some functions defined in the intel-gtt module are used in several areas, but is only supported on x86 platforms. By separating these calls and their static underlying

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/gt: Split intel-gtt functions by arch

2022-03-30 Thread Casey Bowman
On 3/30/22 03:16, Jani Nikula wrote: On Tue, 29 Mar 2022, Casey Bowman wrote: +/* Stubs for non-x86 platforms */ +#else +static inline void intel_gt_gmch_gen5_chipset_flush(struct intel_gt *gt) +{ +} +static inline int intel_gt_gmch_gen5_probe(struct i915_ggtt *ggtt) +{ + /* No HW

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/gt: Split intel-gtt functions by arch

2022-03-30 Thread Casey Bowman
On 3/30/22 02:55, Tvrtko Ursulin wrote: On 30/03/2022 00:58, Casey Bowman wrote: Some functions defined in the intel-gtt module are used in several areas, but is only supported on x86 platforms. By separating these calls and their static underlying functions to another area, we are able to

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/gt: Split intel-gtt functions by arch

2022-03-30 Thread Casey Bowman
On 3/30/22 10:25, Jani Nikula wrote: On Wed, 30 Mar 2022, Casey Bowman wrote: On 3/30/22 02:55, Tvrtko Ursulin wrote: I mean I could suggest to do something about the incosistency of: static inline void intel_gt_gmch_gen5_chipset_flush(struct intel_gt *gt) vs: static inline int

[Intel-gfx] [PATCH v4 0/2] Splitting intel-gtt calls for non-x86 platforms

2022-03-30 Thread Casey Bowman
splitting the calls, it's very much open to discussion. v2: Refactored to move gmch functions, renamed exported functions v3: Added drm/i915_drm.h header v4: Rebased on drm-intel-next, resolved build and naming issues Casey Bowman (2): drm/i915/gt: Split intel-gtt functions by arch drm

[Intel-gfx] [PATCH v4 1/2] drm/i915/gt: Split intel-gtt functions by arch

2022-03-30 Thread Casey Bowman
implementations. In addition to the problematic calls, we are moving the gmch-related functions to the new area. Signed-off-by: Casey Bowman --- drivers/gpu/drm/i915/Makefile | 2 + drivers/gpu/drm/i915/gt/intel_ggtt.c| 664 +--- drivers/gpu/drm/i915/gt/intel_gt.c

[Intel-gfx] [PATCH v4 2/2] drm/i915: Require INTEL_GTT to depend on X86

2022-03-30 Thread Casey Bowman
The intel-gtt module is not used on other, non-x86 platforms, so we will restrict it to x86 platforms only. Signed-off-by: Casey Bowman --- drivers/gpu/drm/i915/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v5 0/2] Splitting intel-gtt calls for non-x86 platforms

2022-03-30 Thread Casey Bowman
splitting the calls, it's very much open to discussion. v2: Refactored to move gmch functions, renamed exported functions v3: Added drm/i915_drm.h header v4: Rebased on drm-intel-next, resolved build and naming issues Casey Bowman (2): drm/i915/gt: Split intel-gtt functions by arch drm

[Intel-gfx] [PATCH v5 2/2] drm/i915: Require INTEL_GTT to depend on X86

2022-03-30 Thread Casey Bowman
The intel-gtt module is not used on other, non-x86 platforms, so we will restrict it to x86 platforms only. Signed-off-by: Casey Bowman --- drivers/gpu/drm/i915/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v5 1/2] drm/i915/gt: Split intel-gtt functions by arch

2022-03-30 Thread Casey Bowman
implementations. In addition to the problematic calls, we are moving the gmch-related functions to the new area. Signed-off-by: Casey Bowman --- drivers/gpu/drm/i915/Makefile | 2 + drivers/gpu/drm/i915/gt/intel_ggtt.c| 664 +--- drivers/gpu/drm/i915/gt/intel_gt.c

[Intel-gfx] [RFC PATCH v5 0/1] Splitting up platform-specific calls

2022-03-30 Thread Casey Bowman
more arch-neutral split. v5: Rebased on top of the run_as_guest -> i915_run_as_guest changes Casey Bowman (1): Split i915_run_as_guest into x86 and non-x86 drivers/gpu/drm/i915/i915_utils.h | 5 + 1 file changed, 5 insertions(+) -- 2.25.1

[Intel-gfx] [RFC PATCH v5 1/1] Split i915_run_as_guest into x86 and non-x86

2022-03-30 Thread Casey Bowman
Splitting i915_run_as_guest into a more arch-friendly function as non-x86 builds do not support this functionality. Signed-off-by: Casey Bowman --- drivers/gpu/drm/i915/i915_utils.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm

[Intel-gfx] [PATCH v6 1/1] Split i915_run_as_guest into x86 and non-x86

2022-03-31 Thread Casey Bowman
Splitting i915_run_as_guest into a more arch-friendly function as non-x86 builds do not support this functionality. Signed-off-by: Casey Bowman Acked-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_utils.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v6 0/1] Splitting up platform-specific calls

2022-03-31 Thread Casey Bowman
o use simple if-else structure. v4: Modified into more arch-neutral split. v5: Rebased on top of the run_as_guest -> i915_run_as_guest changes v6: Added suggestion of x86-only inclusion for asm/hypervisor.h Casey Bowman (1): Split i915_run_as_guest into x86 and non-x86 drivers/gpu/

Re: [Intel-gfx] [PATCH v6 1/1] Split i915_run_as_guest into x86 and non-x86

2022-04-05 Thread Casey Bowman
@Jani/Lucas, any other thoughts here? Regards, Casey On 3/31/22 13:43, Casey Bowman wrote: Splitting i915_run_as_guest into a more arch-friendly function as non-x86 builds do not support this functionality. Signed-off-by: Casey Bowman Acked-by: Tvrtko Ursulin --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915/gt: Split intel-gtt functions by arch

2022-04-05 Thread Casey Bowman
@Jani/Lucas, any other thoughts here? Regards, Casey On 3/31/22 07:36, Tvrtko Ursulin wrote: On 31/03/2022 00:48, Casey Bowman wrote: Some functions defined in the intel-gtt module are used in several areas, but is only supported on x86 platforms. By separating these calls and their static

[Intel-gfx] [RFC PATCH v3 0/1] Splitting up platform-specific calls

2022-02-15 Thread Casey Bowman
e can avoid scaling issues when including multiple architectures and multiple functions (as the number of function calls will inevitably increase with more architectures). v2: Revised to use kernel's platform-splitting scheme. v3: Revised to use simple if-else structure. Casey Bowman (1):

[Intel-gfx] [RFC PATCH v3 1/1] i915/drm: Split out x86/arm64 for run_as_guest

2022-02-15 Thread Casey Bowman
Splitting out run_as_guest into platform-specific functions as arm64 does not support this functionality. Signed-off-by: Casey Bowman --- drivers/gpu/drm/i915/i915_drv.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [RFC PATCH 0/1] Splitting up platform-specific calls

2022-01-20 Thread Casey Bowman
e can avoid scaling issues when including multiple architectures and multiple functions (as the number of function calls will inevitably increase with more architectures). Casey Bowman (1): i915/drm: Split out x86 and arm64 functionality drivers/gpu/drm/i915/Makefile | 4 +++ dr

[Intel-gfx] [RFC PATCH 1/1] i915/drm: Split out x86 and arm64 functionality

2022-01-20 Thread Casey Bowman
Some x86 checks are unnecessary on arm64 systems, so they are being split out to avoid being used. There may be further arm64 implementations created in the future for this area, so it's better to split this out now. Signed-off-by: Casey Bowman --- drivers/gpu/drm/i915/Mak

Re: [Intel-gfx] [RFC PATCH 0/1] Splitting up platform-specific calls

2022-02-03 Thread Casey Bowman
CC'ing more reviewers for comments. On 1/20/22 14:16, Casey Bowman wrote: In this RFC I would like to ask the community their thoughts on how we can best handle splitting architecture-specific calls. I would like to address the following: 1. How do we want to split architecture

Re: [Intel-gfx] [RFC PATCH 0/1] Splitting up platform-specific calls

2022-02-08 Thread Casey Bowman
On 2/7/22 05:02, Jani Nikula wrote: On Thu, 20 Jan 2022, Casey Bowman wrote: In this RFC I would like to ask the community their thoughts on how we can best handle splitting architecture-specific calls. I would like to address the following: 1. How do we want to split architecture calls

Re: [Intel-gfx] [RFC PATCH 0/1] Splitting up platform-specific calls

2022-02-08 Thread Casey Bowman
On 2/7/22 07:36, Tvrtko Ursulin wrote: On 20/01/2022 22:16, Casey Bowman wrote: In this RFC I would like to ask the community their thoughts on how we can best handle splitting architecture-specific calls. I would like to address the following: 1. How do we want to split architecture calls

Re: [Intel-gfx] [RFC PATCH 0/1] Splitting up platform-specific calls

2022-02-10 Thread Casey Bowman
On 2/10/22 03:10, Tvrtko Ursulin wrote: On 09/02/2022 05:25, Casey Bowman wrote: On 2/7/22 07:36, Tvrtko Ursulin wrote: On 20/01/2022 22:16, Casey Bowman wrote: In this RFC I would like to ask the community their thoughts on how we can best handle splitting architecture-specific calls

[Intel-gfx] [RFC PATCH v2 0/1] Splitting up platform-specific calls

2022-02-10 Thread Casey Bowman
e can avoid scaling issues when including multiple architectures and multiple functions (as the number of function calls will inevitably increase with more architectures). v2: Revised to use kernel's platform-splitting scheme. Casey Bowman (1): i915/drm: Split out x86 and arm64 functionality

[Intel-gfx] [RFC PATCH v2 1/1] i915/drm: Split out x86 and arm64 functionality

2022-02-10 Thread Casey Bowman
cific libraries, but these calls are localized to i915. Signed-off-by: Casey Bowman --- drivers/gpu/drm/i915/Makefile | 3 +++ drivers/gpu/drm/i915/i915_drv.h | 7 ++- drivers/gpu/drm/i915/platforms/Makefile | 8 .../arm64/in

Re: [Intel-gfx] [RFC PATCH v2 0/1] Splitting up platform-specific calls

2022-02-14 Thread Casey Bowman
On 2/11/22 05:51, Tvrtko Ursulin wrote: On 11/02/2022 11:55, Jani Nikula wrote: On Thu, 10 Feb 2022, Casey Bowman wrote: In this RFC I would like to ask the community their thoughts on how we can best handle splitting architecture-specific calls. I would like to address the following: 1