On Fri, Dec 15, 2017 at 2:35 PM, Rodrigo Vivi wrote:
> In case we have multiple modesets for different connectors
> happening in parallel we could have a race on the RMW on these
> shared registers.
>
> This possibility was initially raised by Paulo when reviewing
> commit '555e38d27317 ("drm/i915
On Tue, Sep 12, 2017 at 4:57 PM, Dhinakaran Pandiyan
wrote:
> Print connector name in destroy_connect() and this doesn't add any extra
> lines to dmesg. The debug macro has been moved before the unregister
> call so that we don't lose the connector name and id.
>
> Signed-off-by: Dhinakaran Pandiy
On Tue, Sep 12, 2017 at 4:57 PM, Dhinakaran Pandiyan
wrote:
> We debug log the esi dpcd's twice after reading them back, which is not
> necessary.
>
> Signed-off-by: Dhinakaran Pandiyan
While you're cleaning this up, why not move the do_again label beneath
the if - the only time the goto happens
On Tue, Sep 12, 2017 at 4:57 PM, Dhinakaran Pandiyan
wrote:
> Both mst_disable_dp and mst_post_disable_dp print number of active links
> before the variable has been updated. Move the print statement in
> mst_disable_dp after the decrement so that the printed values indicate
> the disabing of a ms
On Tue, Sep 12, 2017 at 4:57 PM, Dhinakaran Pandiyan
wrote:
> The buffer size defined is 16 bytes whereas only 14 bytes are read. Add a
> macro to avoid this discrepancy.
>
> Signed-off-by: Dhinakaran Pandiyan
Reviewed-by: James Ausmus
> ---
> drivers/gpu/drm/i915/intel_dp.c | 15 +---
On Tue, Sep 12, 2017 at 4:57 PM, Dhinakaran Pandiyan
wrote:
> The caller already has code to handle failure, no need to duplicate
> that.
>
> Signed-off-by: Dhinakaran Pandiyan
> ---
> drivers/gpu/drm/i915/intel_dp.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i
On Tue, Sep 12, 2017 at 4:57 PM, Dhinakaran Pandiyan
wrote:
> The other instances of link training are protected with
> connection_mutex, so do the same in check_mst_status() too.
We don't seem to be taking connection_mutex around
intel_dp_start/stop_link_train in the intel_enable_dp or
intel_ddi
On Tue, Sep 12, 2017 at 4:57 PM, Dhinakaran Pandiyan
wrote:
> intel_dp_can_mst() performs these checks.
>
> Signed-off-by: Dhinakaran Pandiyan
> ---
> drivers/gpu/drm/i915/intel_dp.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i
On Fri, Sep 15, 2017 at 3:18 AM, Ville Syrjälä
wrote:
> On Thu, Sep 14, 2017 at 12:59:35PM -0700, James Ausmus wrote:
>> Make intel_dp_add_mst_connector handle error returns from the drm_ calls.
>> Add intel_connector_destroy to support cleanup on the error path.
>
> That name makes one think that
On Fri, Sep 15, 2017 at 11:38 AM, Manasi Navare
wrote:
> On Thu, Sep 14, 2017 at 03:26:37PM -0700, Ausmus, James wrote:
>> On Tue, Sep 12, 2017 at 4:57 PM, Dhinakaran Pandiyan
>> wrote:
>> > The other instances of link training are protected with
>> > co
On Fri, Sep 15, 2017 at 11:09 AM, Ville Syrjälä
wrote:
> On Fri, Sep 15, 2017 at 10:49:09AM -0700, James Ausmus wrote:
>> Make intel_dp_add_mst_connector handle error returns from the drm_ calls.
>> Add intel_connector_free to support cleanup on the error path.
>>
>> v2: Rename new function to avo
On Mon, Sep 18, 2017 at 3:21 PM, Dhinakaran Pandiyan
wrote:
> Rewriting this code without the goto, I believe, makes it more readable.
> One functional change that has been included is the handling of failed ESI
> register reads. Instead of disabling MST only for the first failed read, we
> now di
On Wed, Sep 20, 2017 at 12:55 PM, Pandiyan, Dhinakaran
wrote:
> On Wed, 2017-09-20 at 12:11 -0700, Ausmus, James wrote:
>> On Mon, Sep 18, 2017 at 3:21 PM, Dhinakaran Pandiyan
>> wrote:
>> > Rewriting this code without the goto, I believe, makes it more readable.
>>
On Wed, Sep 20, 2017 at 3:47 PM, Pandiyan, Dhinakaran
wrote:
> On Wed, 2017-09-20 at 13:02 -0700, Ausmus, James wrote:
>> On Wed, Sep 20, 2017 at 12:55 PM, Pandiyan, Dhinakaran
>> wrote:
>> > On Wed, 2017-09-20 at 12:11 -0700, Ausmus, James wrote:
>> >
On Thu, Sep 21, 2017 at 11:54 AM, Dhinakaran Pandiyan
wrote:
> Rewriting this code without the goto, I believe, makes it more readable.
> One functional change that has been included is the handling of failed ESI
> register reads. Instead of disabling MST only for the first failed read, we
> now d
On Thu, Sep 28, 2017 at 1:40 AM, Petri Latvala wrote:
> On Wed, Sep 27, 2017 at 04:08:27PM -0700, James Ausmus wrote:
>> Some distros (such as Gentoo) are removing the include of
>> sys/sysmacros.h from sys/types.h. Explicitly include sysmacros.h in
>> files where we use the minor() and major() fu
On Tue, Oct 3, 2017 at 3:08 PM, Rodrigo Vivi wrote:
> On PLL Enable sequence we need to "Configure DPCLKA_CFGCR0 to turn on
> the clock for the DDI and map the DPLL to the DDI"
>
> So we first do the map and then we unset DDI_CLK_OFF to turn the clock
> on. We do this in 2 separated steps.
>
> How
On Tue, Oct 3, 2017 at 3:08 PM, Rodrigo Vivi wrote:
> HDMI Mode selection on CNL is on CFGCR0 for that PLL, not
> on in a global CTRL1 as it was on SKL.
>
> The original patch addressed this difference, but leaving behind
> this single entry here. So we were checking the wrong bits during
> the PL
On Tue, Oct 3, 2017 at 12:06 AM, Rodrigo Vivi wrote:
> From: Paulo Zanoni
>
> These functions even have their own page in our spec,
> so extract them from cnl_set_cdclk().
>
> v2: (By Rodrigo) Fixed inverted logic on error return of
> cnl_dvfs_pre_change.
>
> Cc: Ville Syrjälä
> Signed-off-b
Original Message-
> From: Vivi, Rodrigo
> Sent: Wednesday, 4 October, 2017 1:25 PM
> To: Ausmus, James
> Cc: intel-gfx@lists.freedesktop.org; ville.syrj...@linux.intel.com;
> jani.nik...@linux.intel.com; Runyan, Arthur J ;
> b...@bwidawsk.net
> Subject: Re:
On Wed, Sep 27, 2017 at 11:29 AM, James Ausmus wrote:
> Make intel_dp_add_mst_connector handle error returns from the drm_ calls.
> Add intel_connector_free to support cleanup on the error path.
>
> v2: Rename new function to avoid confusion, and simplify error
> paths (Ville)
>
> v3: Indentation
On Thu, Oct 12, 2017 at 1:59 PM, Rodrigo Vivi wrote:
> On Thu, Oct 12, 2017 at 06:58:20PM +0000, Ausmus, James wrote:
>> On Wed, Oct 4, 2017 at 3:54 PM, Runyan, Arthur J
>> wrote:
>> > I think the failure was with one particularly slow eDP panel, but it is
>> >
On Fri, Oct 13, 2017 at 8:35 PM, Patchwork
wrote:
> == Series Details ==
>
> Series: drm/i915: Handle drm-layer errors in intel_dp_add_mst_connector (rev6)
> URL : https://patchwork.freedesktop.org/series/30384/
> State : failure
>
> == Summary ==
>
> Test kms_flip:
> Subgroup basic-flip
On Mon, Oct 16, 2017 at 7:56 AM, Ville Syrjala
wrote:
> From: Ville Syrjälä
>
> We'll want to use the intel_ddi_get_buf_trans_*() functions a bit
> earlier in the file, so move them up. While at it start using them
> in the iboost setup to get rid of the platform checks there.
>
> v2: Rebase due
On Mon, Oct 16, 2017 at 7:56 AM, Ville Syrjala
wrote:
> From: Ville Syrjälä
>
> Introduce intel_ddi_get_buf_trans_hdmi() and start using it where we
> can.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 50
> ++--
> 1 file change
On Mon, Oct 16, 2017 at 7:56 AM, Ville Syrjala
wrote:
> From: Ville Syrjälä
>
> encoder->type isn't reliable for DP/HDMI encoders, so pass the type
> explicity to skl_set_iboost(). Also take the opportunity to streamline
> the code.
>
> v2: Clean up the argument types to skl_ddi_set_iboost() whil
On Mon, Oct 16, 2017 at 7:56 AM, Ville Syrjala
wrote:
> From: Ville Syrjälä
>
> The caller of intel_prepare_hdmi_ddi_buffers() alreday figured out the
> level, so let's just pass it in instead if figuring it out again.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: James Ausmus
> ---
> driver
On Fri, Jan 19, 2018 at 10:48 AM, Paulo Zanoni
wrote:
>
> From: Anusha Srivatsa
>
> ICP has two backlight controllers - similar to previous platforms like
> BXT -, but we only use one controller for now, so we can just reuse
> the CNP code.
>
> v2: Remove the usage of ICP_SECOND_PPS_BACKLIGHT reg
On Mon, Feb 05, 2018 at 01:40:42PM -0200, Paulo Zanoni wrote:
> This commit adds the basic CDCLK functions, but it's still missing
> pieces of the display initialization sequence.
>
> v2:
> - Implement the voltage levels.
> - Rebase.
> v3:
> - Adjust to the new "bypass" clock (Imre).
> - Call i
On Fri, Aug 16, 2013 at 1:15 AM, Jani Nikula
wrote:
>
> On Fri, 16 Aug 2013, Daniel Vetter wrote:
> > On Thu, Aug 15, 2013 at 05:30:25PM -0700, james.aus...@intel.com wrote:
> >> Hello All-
> >>
> >> I'm trying to determine if the ChromeOS-only patches being carried by
> >> Google still make sens
On Tue, Mar 18, 2014 at 4:09 PM, Ben Widawsky
wrote:
> Apparently it is wiped out from under us, and we get some really fun
> caching artifacts upon resume (it seems to be WB for all types by
> default).
>
> Reported-by: James Ausmus
> Signed-off-by: Ben Widawsky
Tested-by: James Ausmus
Works
On Sat, Mar 22, 2014 at 4:34 AM, Daniel Vetter wrote:
> On Fri, Mar 21, 2014 at 05:51:01PM -0700, Ben Widawsky wrote:
>> Let's try this again. I've pushed a branch here:
>> http://cgit.freedesktop.org/~bwidawsk/drm-intel/log/?h=bdw-backports
>>
>> I need to re-review some of the merge conflicts fo
On Mon, Nov 18, 2013 at 6:32 PM, Rodrigo Vivi wrote:
>
> This is another drm-intel-collector updated notice:
> http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector
>
> Here goes the update list in order for better reviewers assignment:
>
> Patch drm/i915: Asynchronously pe
On Wed, Nov 6, 2013 at 6:22 AM, Grant wrote:
>>> >> > I'm getting the following segfault intermittently when using sna.
>>> >> > I've tried xf86-video-intel-2.99.905 and the latest from git a week or
>>> >> > so ago.
>>> >>
>>> >> Symbols, please.
>>> >>
>>> >> addr2line -e /usr/lib64/xorg/modules
On Wed, Nov 6, 2013 at 10:17 AM, Grant wrote:
>>> Thank you, here's what I get:
>>>
>>> # addr2line -e /usr/lib64/xorg/modules/drivers/intel_drv.so -i 0x2fe79
>>> 0x3037f
>>> /var/tmp/portage/x11-drivers/xf86-video-intel-2.99.905-r1/work/xf86-video-intel-2.99.905/src/sna/sna_accel.c:6079
>>> /var
On Wed, Nov 6, 2013 at 10:48 AM, Grant wrote:
> Thank you, here's what I get:
>
> # addr2line -e /usr/lib64/xorg/modules/drivers/intel_drv.so -i 0x2fe79
> 0x3037f
Grant - I'm assuming that this was done on the emerged
xf86-video-intel, not the git-compiled one?
> /var/tmp/p
8_PPAT(0, GEN8_PPAT_UC);
> +
> /* XXX: spec defines this as 2 distinct registers. It's unclear
if a 64b
> * write would work. */
> I915_WRITE(GEN8_PRIVATE_PAT, pat);
> --
> 1.9.3
>
Tested-by: James Ausmus
--
James Ausmus
Sr. Software Engineer
SSG-OTC ChromeOS
On Fri, Oct 31, 2014 at 5:27 AM, Rodrigo Vivi
wrote:
>
> Global GTT doesn't have pat_sel[2:0] so it always point to pat_sel = 000;
> So the only way to avoid screen corruptions is setting PAT 0 to Uncached.
>
> MOCS can still be used though. But if userspace is trusting PTE for
> cache selection t
On Thu, Feb 26, 2015 at 2:48 PM, Joe Konno
wrote:
>
> From: Joe Konno
>
> In instances where cursor sizes change, as in Chromium Ozone/Freon,
> watermarks should be recomputed. There should be no hard-coded
> assumptions about cursor widths. This was corrected originally here:
>
> commit 64f9
On Wed, Jul 15, 2015 at 2:34 AM, Daniel Vetter wrote:
>
> On Tue, Jul 14, 2015 at 01:37:32PM -0700, Greg KH wrote:
> > On Tue, Jul 14, 2015 at 11:22:35AM +0200, Daniel Vetter wrote:
> > > On Mon, Jul 13, 2015 at 09:36:45AM -0700, jay.p.pa...@intel.com wrote:
> > > > From: Jay Patel
> > > >
> > >
40 matches
Mail list logo
