Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_ctx_isolation: Ignore the low bits of BB_OFFSET

2019-01-10 Thread Antonio Argenziano
On 07/01/19 04:41, Chris Wilson wrote: On Skylake, BB_OFFSET seems to be unstable. Since this is an offset into the batch at the time of CS execution, it should be actively written to as we read from the register so allow it a qword of discrepancy (since the CS should be reading in qwords). Thi

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_ctx_isolation: Ignore the low bits of BB_OFFSET

2019-01-10 Thread Antonio Argenziano
On 10/01/19 13:29, Chris Wilson wrote: Quoting Chris Wilson (2019-01-10 21:27:54) Quoting Antonio Argenziano (2019-01-10 21:24:56) On 07/01/19 04:41, Chris Wilson wrote: On Skylake, BB_OFFSET seems to be unstable. Since this is an offset into the batch at the time of CS execution, it

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/hangman: Skip if disabled by the kernel

2019-01-10 Thread Antonio Argenziano
. Signed-off-by: Chris Wilson LGTM. Acked-by: Antonio Argenziano ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-10 Thread Antonio Argenziano
On 07/01/19 08:58, Tvrtko Ursulin wrote: On 07/01/2019 13:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 13:43:29) On 07/01/2019 11:58, Tvrtko Ursulin wrote: [snip] Note about future interaction with preemption: Preemption could happen in a command sequence prior to watchdog

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-11 Thread Antonio Argenziano
On 11/01/19 00:22, Tvrtko Ursulin wrote: On 11/01/2019 00:47, Antonio Argenziano wrote: On 07/01/19 08:58, Tvrtko Ursulin wrote: On 07/01/2019 13:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 13:43:29) On 07/01/2019 11:58, Tvrtko Ursulin wrote: [snip] Note about future

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-16 Thread Antonio Argenziano
On 16/01/19 08:15, Tvrtko Ursulin wrote: On 11/01/2019 21:28, John Harrison wrote: On 1/11/2019 09:31, Antonio Argenziano wrote: On 11/01/19 00:22, Tvrtko Ursulin wrote: On 11/01/2019 00:47, Antonio Argenziano wrote: On 07/01/19 08:58, Tvrtko Ursulin wrote: On 07/01/2019 13:57, Chris

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-16 Thread Antonio Argenziano
On 16/01/19 09:42, Antonio Argenziano wrote: On 16/01/19 08:15, Tvrtko Ursulin wrote: On 11/01/2019 21:28, John Harrison wrote: On 1/11/2019 09:31, Antonio Argenziano wrote: On 11/01/19 00:22, Tvrtko Ursulin wrote: On 11/01/2019 00:47, Antonio Argenziano wrote: On 07/01/19 08:58

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/pm_rpm: Check for functional GEM before use

2019-01-29 Thread Antonio Argenziano
On 27/01/19 05:13, Chris Wilson wrote: Check the GPU (using GEM) is up an operational before submitting commands. Always a good idea. Reviewed-by: Antonio Argenziano Signed-off-by: Chris Wilson --- tests/pm_rpm.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/pm_rpm.c

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_latency: Normalize results into ns

2019-01-29 Thread Antonio Argenziano
On 29/01/19 01:55, Chris Wilson wrote: Present the latency results in nanoseconds not RCS cycles. Signed-off-by: Chris Wilson --- tests/i915/gem_exec_latency.c | 38 +++ 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/tests/i915/gem_exec_laten

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_eio: Check for allow-hang prior to issuing a reset

2019-01-29 Thread Antonio Argenziano
On 27/01/19 04:49, Chris Wilson wrote: Check that we are allowed to hang/reset the GPU before we actually do so for the first time. Signed-off-by: Chris Wilson --- tests/i915/gem_eio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/i915/gem_eio.c b/tests/

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_capture: Check the strlen() for an empty file

2019-01-29 Thread Antonio Argenziano
ed" otherwise. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109481 Signed-off-by: Chris Wilson LGTM. Reviwed-by: Antonio Argenziano --- tests/i915/gem_exec_capture.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/i915/gem_exec_capt

[Intel-gfx] [PATCH i-g-t] tests/i915/gem_madvise.c: Add more mappings

2019-04-04 Thread Antonio Argenziano
Check madvise versus more memory mappings. Suggested-by: Chris Wilson Signed-off-by: Antonio Argenziano --- tests/i915/gem_madvise.c | 115 ++- 1 file changed, 76 insertions(+), 39 deletions(-) diff --git a/tests/i915/gem_madvise.c b/tests/i915

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_exec_reuse: stop the hang detector afterwards

2019-02-11 Thread Antonio Argenziano
s[n]); } + + igt_fixture + igt_stop_hang_detector(no.fd); This doesn't take an fd... incoming changes to the lib? Still makes sense, with fix, Reviewed-by: Antonio Argenziano } ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.o

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] i915/gem_exec_latency: Normalize results into ns

2019-02-12 Thread Antonio Argenziano
On 29/01/19 10:01, Chris Wilson wrote: Quoting Antonio Argenziano (2019-01-29 17:55:45) On 29/01/19 01:55, Chris Wilson wrote: Present the latency results in nanoseconds not RCS cycles. Signed-off-by: Chris Wilson --- tests/i915/gem_exec_latency.c | 38

Re: [Intel-gfx] [PATCH i-g-t 1/8] i915/gem_eio: Check that context create fails when wedged

2019-02-19 Thread Antonio Argenziano
On 17/02/19 06:35, Chris Wilson wrote: Lock down the new uABI that DRM_IOCTL_I915_GEM_CONTEXT_CREATE returns -EIO when wedged. Signed-off-by: Chris Wilson Cc: Mika Kuoppala LGTM. Reviewed-by: Antonio Argenziano --- tests/i915/gem_eio.c | 14 ++ 1 file changed, 14

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/8] i915/gem_eio: Check we only ban the context

2019-02-19 Thread Antonio Argenziano
On 17/02/19 06:35, Chris Wilson wrote: In trigger the ban, we only want to observe the local context be banned and not the fpriv as a whole. Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- tests/i915/gem_eio.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/i915/gem_eio

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_eio: Check we only ban the context

2019-02-19 Thread Antonio Argenziano
On 19/02/19 09:11, Chris Wilson wrote: In trigger the ban, we only want to observe the local context be banned and not the fpriv as a whole. v2: And send an execbuf down the new context. Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Antonio Argenziano Reviewed-by: Antonio Argenziano

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/8] lib: Restore the i915.reset modparam before cleaning up

2019-02-19 Thread Antonio Argenziano
kernel unable to fulfil typo -^ our request (and those naughty batches continue to disrupt testing). Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Petri Latvala Re-enabling reset sounds good. Acked-by: Antonio Argenziano

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_schedule: Switch bach to gem_set_domain()

2019-02-19 Thread Antonio Argenziano
from the GPU. Signed-off-by: Chris Wilson Cc: Antonio Argenziano LGTM. Reviewed-by: Antonio Argenziano Antonio --- tests/i915/gem_exec_schedule.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c index

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang

2019-02-21 Thread Antonio Argenziano
On 21/02/19 02:19, Chris Wilson wrote: To control hang detection, we manipulate the i915.reset module parameter. However, to be nice we should SKIP if we cannot modify the parameter as opposed to outright FAILing. References: https://bugs.freedesktop.org/show_bug.cgi?id=108891 Signed-off-by: C

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] igt/drv_hangman: Skip if resets are disallowed

2019-02-21 Thread Antonio Argenziano
On 21/02/19 02:19, Chris Wilson wrote: If we tell the machine to reset but they are disallowed, we will leave the system in a wedged state, preventing the majority of subsequent tests. Signed-off-by: Chris Wilson LGTM. Reviewed-by: Antonio Argenziano --- tests/i915/i915_hangman.c | 7

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang

2019-02-21 Thread Antonio Argenziano
On 21/02/19 08:11, Chris Wilson wrote: Quoting Antonio Argenziano (2019-02-21 16:08:04) On 21/02/19 02:19, Chris Wilson wrote: To control hang detection, we manipulate the i915.reset module parameter. However, to be nice we should SKIP if we cannot modify the parameter as opposed to

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_eio: Not everyone actually has contexts

2019-02-21 Thread Antonio Argenziano
it didn't apply to context-less platforms as it would fail here. I think it still makes sense to test you get banned on context 0 so, Reviwed-by: Antonio Argenziano - - /* And check it actually works! */ - execbuf.rsvd1 = ctx; -

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/pm_rpm: Show the contents of i915_runtime_pm_status on setup

2018-12-05 Thread Antonio Argenziano
On 05/12/18 02:48, Chris Wilson wrote: To try and help debug situations where the driver has leaked a runtime reference before executing the pm_rpm tests, show the contents of i915_runtime_pm_status at startup, which will include all currently held wakerefs. LGTM. Reviewed-by: Antonio

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/amdgpu_amd_prime: Bail if we fail to create more contexts

2018-12-13 Thread Antonio Argenziano
context created! References: https://bugs.freedesktop.org/show_bug.cgi?id=109049 Signed-off-by: Chris Wilson LGTM. Reviwed-by: Antonio Argenziano --- tests/amdgpu/amd_prime.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/amdgpu/amd_prime.c b/tests/amdgpu

[Intel-gfx] [RFC PATCH 2/2] drm/i915: Account for platform without mappable aperture when returning size

2019-03-07 Thread Antonio Argenziano
Some devices will not expose a mappable aperture anymore so we need to return an appropriate value in that case. Signed-off-by: Antonio Argenziano Cc: Matthew Auld Cc: Daniele Ceraolo Spurio Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 3 ++- 1 file changed, 2 insertions(+), 1

[Intel-gfx] [RFC PATCH 1/2] drm/i915: Return mappable aperture size

2019-03-07 Thread Antonio Argenziano
Extend the API to return the mappable aperture size directly in the I915_GEM_GET_APERTURE IOCTL. Signed-off-by: Antonio Argenziano Cc: Matthew Auld Cc: Daniele Ceraolo Spurio Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 2 ++ include/uapi/drm/i915_drm.h | 5 + 2 files

Re: [Intel-gfx] [RFC PATCH 2/2] drm/i915: Account for platform without mappable aperture when returning size

2019-03-07 Thread Antonio Argenziano
On 07/03/19 13:59, Chris Wilson wrote: Quoting Antonio Argenziano (2019-03-07 19:11:15) Some devices will not expose a mappable aperture anymore so we need to return an appropriate value in that case. Signed-off-by: Antonio Argenziano Cc: Matthew Auld Cc: Daniele Ceraolo Spurio Cc: Chris

Re: [Intel-gfx] [PATCH i-g-t] lib: sync with the newer i915_pciids.h from the Kernel

2019-03-21 Thread Antonio Argenziano
On 21/03/19 11:02, Anusha wrote: From: Anusha Srivatsa Add CML IDS and additional CNL ID. Please add the kernel commits to be consistent with the previous updates. Acked-by: Antonio Argenziano v2: Copy header from kernel (Jose) - Change commit message (Lucas) Cc: José Roberto de

Re: [Intel-gfx] [PATCH i-g-t 2/5] lib/igt_core: reserve long options for individual tests

2019-05-29 Thread Antonio Argenziano
individual test. While at it, fix the coding style to use tab rather than space. Signed-off-by: Lucas De Marchi Acked-by: Antonio Argenziano --- lib/igt_core.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 9c86d664

Re: [Intel-gfx] [PATCH i-g-t 4/5] testdisplay: use first available option values

2019-05-29 Thread Antonio Argenziano
On 29/05/19 16:27, Lucas De Marchi wrote: Now that core options are set to 500 and above, start from the lowest values without causing problems with conflicts. This also rename the constants to follow the names from the core. Signed-off-by: Lucas De Marchi Acked-by: Antonio Argenziano

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_ctx_shared: Fixup vec0 mmio base for icl

2019-06-04 Thread Antonio Argenziano
all bases. Still, fixes the test so: Reviewed-by: Antonio Argenziano Antonio else mmio_base = 0x1a000; break; ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org ht

Re: [Intel-gfx] [PATCH i-g-t] overlay: Drop legacy mmio access

2019-07-03 Thread Antonio Argenziano
can be discarded. Signed-off-by: Chris Wilson Cc: Antonio Argenziano Cc: Tvrtko Ursulin LGTM. Acked-by: Antonio Argenziano --- overlay/Makefile.am | 2 - overlay/gpu-top.c | 167 +--- overlay/igfx.c | 264

Re: [Intel-gfx] [PATCH i-g-t] i915: Mark up a few more tests that only target GGTT

2019-11-12 Thread Antonio Argenziano
On 12/11/19 07:47, Chris Wilson wrote: If a test is only targeting the GGTT API and its corner cases, it can only run if we have a mappable aperture. Signed-off-by: Chris Wilson Cc: Antonio Argenziano --- lib/i915/gem_mman.c | 19 +++ lib/i915/gem_mman.h

Re: [Intel-gfx] [PATCH i-g-t] i915: Mark up a few more tests that only target GGTT

2019-11-12 Thread Antonio Argenziano
On 12/11/19 10:21, Chris Wilson wrote: Quoting Antonio Argenziano (2019-11-12 18:17:41) On 12/11/19 07:47, Chris Wilson wrote: If a test is only targeting the GGTT API and its corner cases, it can only run if we have a mappable aperture. Signed-off-by: Chris Wilson Cc: Antonio Argenziano

Re: [Intel-gfx] [RFC PATCH i-g-t] tests/gem_userptr_blits: Enhance invalid mapping exercise

2020-01-27 Thread Antonio Argenziano
On 22/01/20 08:26, Janusz Krzysztofik wrote: Working with a userptr GEM object backed by any type of mapping to another GEM object, not only GTT mapping currently examined bu the test, may cause a currently unavoidable lockdep splat inside the i915 driver. Then, such operations are expected t

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_reloc: Add SIGINT injection

2020-01-29 Thread Antonio Argenziano
On 29/01/20 14:24, Chris Wilson wrote: Do a pass over gem_exec_reloc where we inject lots of SIGINTs. Signed-off-by: Chris Wilson Cc: Antonio Argenziano LGTM. Reviewed-by: Antonio Argenziano --- tests/i915/gem_exec_reloc.c | 13 + 1 file changed, 9 insertions(+), 4

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_basic: Drop per-engine testing of *execbuf

2020-02-03 Thread Antonio Argenziano
On 03/02/20 13:45, Chris Wilson wrote: The gtt/readonly tests are nothing to do with execution and engines; they are strictly checking the copy-from-user of the ioctl arguments. Drop the silly per-engine tests. Signed-off-by: Chris Wilson Cc: Antonio Argenziano --- tests/i915

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_basic: Drop per-engine testing of *execbuf

2020-02-03 Thread Antonio Argenziano
On 03/02/20 14:18, Chris Wilson wrote: Quoting Antonio Argenziano (2020-02-03 22:15:26) On 03/02/20 13:45, Chris Wilson wrote: @@ -121,30 +43,29 @@ igt_main igt_fixture { fd = drm_open_driver(DRIVER_INTEL); - igt_require_gem(fd

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_basic: Drop per-engine testing of *execbuf

2020-02-03 Thread Antonio Argenziano
On 03/02/20 13:45, Chris Wilson wrote: The gtt/readonly tests are nothing to do with execution and engines; they are strictly checking the copy-from-user of the ioctl arguments. Drop the silly per-engine tests. Signed-off-by: Chris Wilson Cc: Antonio Argenziano LGTM. Reviewed-by

Re: [Intel-gfx] [PATCH i-g-t 2/2] i915/gem_ctx_sseu: Extend the mmapped parameters test

2020-02-06 Thread Antonio Argenziano
On 06/02/20 02:06, Chris Wilson wrote: The current implementation of the test only maps the arguments in gtt, but we have similar problems arising from any of our own custom pagefault handlers. Signed-off-by: Chris Wilson Cc: Antonio Argenziano Cc: Dixit Ashutosh For the series

Re: [Intel-gfx] [PATCH i-g-t] lib/i915/gem_engine_topology.c - intel_get_current_engine invalid result

2020-02-14 Thread Antonio Argenziano
ng(fd, e2->flags)) + (fd < 0) || Patch LGTM, Chris do you have any issues merging this before someone implements some tests for the infrastructure? Acked-by: Antonio Argenziano + gem_has_ring(fd, e2->flags)) { +

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/4] i915/gem_ctx_engines: Exercise 0 engines[]

2020-02-14 Thread Antonio Argenziano
On 14/02/20 11:40, Chris Wilson wrote: Setup a context with no engines, and make sure we reject all execution attempts. Signed-off-by: Chris Wilson Reviewed-by: Antonio Argenziano --- tests/i915/gem_ctx_engines.c | 45 1 file changed, 45

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/4] i915/gem_ctx_engine: Exercise for_each_context_engine() with custom engine[]

2020-02-14 Thread Antonio Argenziano
void libapi(int i915) +{ + struct i915_context_param_engines engines = {}; Is there a case for invalid engines as well? Acked-by: Antonio Argenziano + struct drm_i915_gem_context_param p = { + .ctx_id = gem_context_create(i915), + .param

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_schedule: Exercise implicit ordering between engines

2020-02-18 Thread Antonio Argenziano
On 18/02/20 09:42, Chris Wilson wrote: Check that reads are serialised after a write, and that a subsequent write is after all reads. Signed-off-by: Chris Wilson Cc: Antonio Argenziano Cc: Sravan Kumar Nedunoori --- tests/i915/gem_exec_schedule.c | 73

Re: [Intel-gfx] [PATCH i-g-t] lib: Don't specify a non-existent blitter ring

2020-02-18 Thread Antonio Argenziano
On 18/02/20 06:47, Chris Wilson wrote: I915_EXEC_BLT only exists on gen6+ Closes: https://gitlab.freedesktop.org/drm/intel/issues/1256 Signed-off-by: Chris Wilson Acked-by: Antonio Argenziano --- lib/intel_batchbuffer.c | 23 --- 1 file changed, 8 insertions

[Intel-gfx] [PATCH i-g-t 1/3] igt_dummyload: Add preemptible parameter to spinning batch.

2017-12-04 Thread Antonio Argenziano
been kept. All the places that used a spin batch are still using a pre-emptible spin batch. Cc: Chris Wilson Cc: Michal Winiarski Signed-off-by: Antonio Argenziano --- lib/igt_dummyload.c | 18 +++--- lib/igt_dummyload.h | 6 -- tests/drv_missed_irq.c| 2

[Intel-gfx] [PATCH i-g-t 2/3] tests/gem_exec_schedule: Add reset on failed preemption test.

2017-12-04 Thread Antonio Argenziano
et while a preemption is pending. Cc: Chris Wilson Cc: Michal Winiarski Signed-off-by: Antonio Argenziano --- tests/gem_exec_schedule.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tests/gem_exec_schedule.c b/tests/gem_exec_schedule.c index 1e6b0ae7..ae44a6c0 10

[Intel-gfx] [PATCH i-g-t 3/3] tests/gem_exec_schedule: Add test for resetting preemptive batch

2017-12-04 Thread Antonio Argenziano
Signed-off-by: Antonio Argenziano --- tests/gem_exec_schedule.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/tests/gem_exec_schedule.c b/tests/gem_exec_schedule.c index ae44a6c0..5a4d63f9 100644 --- a/tests/gem_exec_schedule.c +++ b/tests/gem_exec_

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests/gem_exec_schedule: Add test for resetting preemptive batch

2017-12-04 Thread Antonio Argenziano
On 04/12/17 09:42, Chris Wilson wrote: Quoting Antonio Argenziano (2017-12-04 17:23:15) This patch adds a test that will trigger a preemption of a low priority batch by a 'bad' batch buffer which will hang. The test aims at making sure that a hanging high priority batch will not d

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/gem_exec_schedule: Add reset on failed preemption test.

2017-12-04 Thread Antonio Argenziano
On 04/12/17 09:37, Chris Wilson wrote: Quoting Antonio Argenziano (2017-12-04 17:23:14) This patch adds a test where a low priority batch is going to be declared hung while a preemption is pending. The test wants to verify that a 'bad' low priority batch will not disrupt the exec

[Intel-gfx] [PATCH i-g-t v2 2/2] tests/gem_exec_schedule: Add test for resetting preemptive batch

2017-12-04 Thread Antonio Argenziano
- Use igt_hang_ctx to hang ring (Chris) - Add comment on execution order checks (Chris) Cc: Chris Wilson Cc: Michal Winiarski Signed-off-by: Antonio Argenziano --- tests/gem_exec_schedule.c | 37 + 1 file changed, 37 insertions(+) diff --g

[Intel-gfx] [PATCH i-g-t v2 1/2] tests/gem_exec_schedule: Add reset on failed preemption test.

2017-12-04 Thread Antonio Argenziano
et while a preemption is pending. -v2: - Use igt_hang_ctx to hang the engine (Chris) - Enable/Process engine reset using IGT libs (Chris) - Create new subtest_group for the test (Chris) Cc: Chris Wilson Cc: Michal Winiarski Signed-off-by: Antonio Argenziano

[Intel-gfx] [RFC i-g-t 1/5] igt_dummyload: Wrap function parameters into struct

2017-12-06 Thread Antonio Argenziano
The intent of this patch is to clean-up the interface of the spinning batch workload by grouping the parameters used to spawn it into a struct. Cc: Chris Wilson Signed-off-by: Antonio Argenziano --- lib/igt_dummyload.c | 19 +++ lib/igt_dummyload.h | 16

[Intel-gfx] [RFC i-g-t 4/5] igt_dummyload: Add preemptible parameter to spin batch

2017-12-06 Thread Antonio Argenziano
This patch adds a parameter that allows to make the spinning batch pre-emptible by adding an arbitration point to the spinning loop. Cc: Chris Wilson Signed-off-by: Antonio Argenziano --- lib/igt_dummyload.c | 4 ++-- lib/igt_dummyload.h | 1 + lib/igt_gt.c | 3

[Intel-gfx] [RFC i-g-t 5/5] igt_hang_ctx: Add preemptible parameter

2017-12-06 Thread Antonio Argenziano
This patch adds a parameter to make the hanging context pre-emptible. Cc: Chris Wilson Signed-off-by: Antonio Argenziano --- lib/igt_gt.c| 4 ++-- lib/igt_gt.h| 1 + tests/drv_hangman.c | 2 +- tests/gem_reset_stats.c | 2 +- tests/gem_softpin.c | 2 +- 5 files

[Intel-gfx] [RFC i-g-t 2/5] igt_hang_ctx: Wrap parameters into struct

2017-12-06 Thread Antonio Argenziano
This patch wraps the parameters for the function used to hang a context (igt_hang_ctx) into a struct to cleanup the interface and make it easier to add more parameters. Cc: Chris Wilson Signed-off-by: Antonio Argenziano --- lib/igt_dummyload.c | 25 - lib/igt_gt.c

[Intel-gfx] [RFC i-g-t 3/5] lib/igt_hang_ctx: Use dummyload batch to hang ctx.

2017-12-06 Thread Antonio Argenziano
To hang a context we were effectively reimplementing a spinning batch and never stopping it. This patch reuses the recursive batch from igt_dummyload to hang a context. Cc: Chris Wilson Signed-off-by: Antonio Argenziano --- lib/igt_dummyload.c | 4 +++- lib/igt_dummyload.h | 2 ++ lib

Re: [Intel-gfx] [RFC i-g-t 3/5] lib/igt_hang_ctx: Use dummyload batch to hang ctx.

2017-12-07 Thread Antonio Argenziano
On 07/12/17 03:05, Chris Wilson wrote: Quoting Antonio Argenziano (2017-12-06 23:03:44) To hang a context we were effectively reimplementing a spinning batch and never stopping it. This patch reuses the recursive batch from igt_dummyload to hang a context. Cc: Chris Wilson Signed-off-by

[Intel-gfx] [PATCH i-g-t 1/5] igt_dummyload: Wrap function parameters into struct

2017-12-07 Thread Antonio Argenziano
Cleanup the interface for creating dummyloads by folding its parameters into a struct. Cc: Chris Wilson Signed-off-by: Antonio Argenziano --- lib/igt_dummyload.c | 19 +++ lib/igt_dummyload.h | 16 tests/drv_missed_irq.c| 3 ++- tests

[Intel-gfx] [PATCH i-g-t 2/5] igt_hang_ctx: Wrap hang_ctx parameters into struct

2017-12-07 Thread Antonio Argenziano
Cleanup the interface to create a hang on a context by folding its parameters into a struct. Cc: Chris Wilson Signed-off-by: Antonio Argenziano --- lib/igt_dummyload.c | 25 - lib/igt_gt.c| 41 +++-- lib/igt_gt.h

[Intel-gfx] [PATCH i-g-t 3/5] lib/igt_hang_ctx: Use recursive batch to hang ctx.

2017-12-07 Thread Antonio Argenziano
To hang a context we were effectively reimplementing a spinning batch and never stopping it. This patch reuses the recursive batch from igt_dummyload to hang a context. Cc: Chris Wilson Signed-off-by: Antonio Argenziano --- lib/igt_dummyload.c | 4 +++- lib/igt_dummyload.h | 2 ++ lib

[Intel-gfx] [PATCH i-g-t 4/5] igt_dummyload: Add preemptible parameter to recursive batch

2017-12-07 Thread Antonio Argenziano
This patch adds a parameter that allows to make the spinning batch pre-emptible by conditionally adding an arbitration point to the spinning loop. From RFC: - Implicitly initialize struct members to zero. (Chris) Cc: Chris Wilson Signed-off-by: Antonio Argenziano --- lib

[Intel-gfx] [PATCH i-g-t 5/5] igt_hang_ctx: Add preemptible parameter

2017-12-07 Thread Antonio Argenziano
This patch adds a parameter to make the hanging context conditionally pre-emptible. Cc: Chris Wilson Signed-off-by: Antonio Argenziano --- lib/igt_gt.c | 2 +- lib/igt_gt.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/igt_gt.c b/lib/igt_gt.c index 614fd83b..a36e5506

[Intel-gfx] [PATCH i-g-t] tests/gem_reset_stats: Fix retrieval of hangcheck stats expectation

2017-12-08 Thread Antonio Argenziano
The test expected IOCTL 'I915_GET_RESET_STATS' would return an error when not root. That is no longer true in the driver and therefore the test was incorrectly failing. Cc: Michel Thierry Cc: Arkadiusz Hiler Signed-off-by: Antonio Argenziano --- tests/gem_reset_st

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_reset_stats: Fix retrieval of hangcheck stats expectation

2017-12-08 Thread Antonio Argenziano
On 08/12/17 08:46, Chris Wilson wrote: Quoting Antonio Argenziano (2017-12-08 16:27:17) The test expected IOCTL 'I915_GET_RESET_STATS' would return an error when not root. That is no longer true in the driver and therefore the test was incorrectly failing. Cc: Michel Thierry Cc:

[Intel-gfx] [PATCH i-g-t v3] tests/gem_exec_schedule: Add test for resetting preemptive batch

2017-12-08 Thread Antonio Argenziano
- Use igt_hang_ctx to hang ring (Chris) - Add comment on execution order checks (Chris) -v3: - Use library call to consume hang (Chris) - Use a more explicit name for array size (Chris) Cc: Chris Wilson Cc: Michal Winiarski Signed-off-by: Antonio Argenziano R

[Intel-gfx] [PATCH i-g-t v2] tests/gem_reset_stats: Fix retrieval of hangcheck stats expectation

2017-12-13 Thread Antonio Argenziano
hanged the behaviour in the Driver to the commit message (Michel) Cc: Michel Thierry Cc: Arkadiusz Hiler Cc: Chris Wilson Signed-off-by: Antonio Argenziano --- tests/gem_reset_stats.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/tests

[Intel-gfx] [PATCH i-g-t] tests/gem_eio: Fix usage of gem_quiescent_gpu

2017-12-14 Thread Antonio Argenziano
Cc: Joonas Lahtinen Signed-off-by: Antonio Argenziano --- tests/gem_eio.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/tests/gem_eio.c b/tests/gem_eio.c index 2ac9f0a9..868f2236 100644 --- a/tests/gem_eio.c +++ b/tests/gem_eio.c @@ -60,13 +60,41

Re: [Intel-gfx] [PATCH igt] lib: Provide a library function to test nop execution

2017-12-14 Thread Antonio Argenziano
On 14/12/17 14:24, Chris Wilson wrote: Sometimes a test wants to verify that an engine, or all of them, are functional by executing a nop batch. Provide a common routine to submit an empty batch then test whether the driver is wedged. Reported-by: Antonio Argenziano Signed-off-by: Chris

[Intel-gfx] [PATCH i-g-t] tests/gem_ctx_param: Update invalid param

2017-12-15 Thread Antonio Argenziano
Since commit: drm/i915/scheduler: Support user-defined priorities, the driver support an extra context param to set context's priority. Add tests for that interface and update invalid tests. Signed-off-by: Antonio Argenziano Cc: Chris Wilson Cc: Michal Winiarski --- tests/gem_ctx_param.c

Re: [Intel-gfx] [PATCH i-g-t 2/4] tests: Move gem_bad_address to hw-tests

2017-12-15 Thread Antonio Argenziano
On 13/12/17 05:26, Chris Wilson wrote: Quoting Petri Latvala (2017-12-13 12:58:14) Since the test is considered to be HW focused, meaning that it doesn't really exercise the driver but rather an HW feature, it is placed in tests/hw-tests. Do we really want to keep this test at all? It's an i

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_ctx_param: Update invalid param

2017-12-18 Thread Antonio Argenziano
On 15/12/17 16:14, Chris Wilson wrote: Quoting Antonio Argenziano (2017-12-15 19:01:11) Since commit: drm/i915/scheduler: Support user-defined priorities, the driver support an extra context param to set context's priority. Add tests for that interface and update invalid tests. Signed-o

[Intel-gfx] [PATCH i-g-t v2] tests/gem_ctx_param: Update invalid param

2017-12-19 Thread Antonio Argenziano
Chris) - Add test for unsupported platforms. (Chris) - Feed interface with all priority values and in random order. (Chris) Signed-off-by: Antonio Argenziano Cc: Chris Wilson Cc: Michal Winiarski --- tests/gem_ctx_param.c | 143 +- 1

Re: [Intel-gfx] [PATCH igt] igt/gem_exec_schedule: Exercise preemption timeout

2018-04-13 Thread Antonio Argenziano
On 13/04/18 07:14, Chris Wilson wrote: Set up a unpreemptible spinner such that the only way we can inject a high priority request onto the GPU is by resetting the spinner. The test fails if we trigger hangcheck rather than the fast timeout mechanism. Signed-off-by: Chris Wilson --- lib/i91

Re: [Intel-gfx] [PATCH igt] igt/gem_exec_schedule: Exercise preemption timeout

2018-04-13 Thread Antonio Argenziano
On 13/04/18 08:59, Chris Wilson wrote: Quoting Antonio Argenziano (2018-04-13 16:54:27) On 13/04/18 07:14, Chris Wilson wrote: Set up a unpreemptible spinner such that the only way we can inject a high priority request onto the GPU is by resetting the spinner. The test fails if we trigger

Re: [Intel-gfx] [igt-dev] [PATCH igt] test/gem_exec_schedule: Check each engine is an independent timeline

2018-04-23 Thread Antonio Argenziano
On 23/04/18 06:43, Chris Wilson wrote: In the existing ABI, each engine operates its own timeline (fence.context) and so should execute independently of any other. If we install a blocker on all other engines, that should not affect execution on the local engine. Signed-off-by: Chris Wilson C

Re: [Intel-gfx] [igt-dev] [PATCH igt] test/gem_exec_schedule: Check each engine is an independent timeline

2018-04-23 Thread Antonio Argenziano
On 23/04/18 08:51, Chris Wilson wrote: Quoting Antonio Argenziano (2018-04-23 16:37:17) On 23/04/18 06:43, Chris Wilson wrote: In the existing ABI, each engine operates its own timeline (fence.context) and so should execute independently of any other. If we install a blocker on all other

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/gem_eio: Exercise banning

2018-05-14 Thread Antonio Argenziano
On 12/05/18 02:03, Chris Wilson wrote: If we trigger "too many" resets, the context and even the file, will be banend and subsequent execbufs should fail with -EIO. Signed-off-by: Chris Wilson Does this replace gem_reset_stats@test_ban? Thanks, Antonio _

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/gem_eio: Exercise banning

2018-05-14 Thread Antonio Argenziano
On 14/05/18 08:02, Chris Wilson wrote: Quoting Antonio Argenziano (2018-05-14 15:51:04) On 12/05/18 02:03, Chris Wilson wrote: If we trigger "too many" resets, the context and even the file, will be banend and subsequent execbufs should fail with -EIO. Signed-off-by: Chris Wils

Re: [Intel-gfx] [PATCH i-g-t 1/3] igt/gem_cpu_reloc: Check HW exists before attempting to use it

2018-05-17 Thread Antonio Argenziano
On 17/05/18 01:23, Chris Wilson wrote: Confirm we have the available HW before asserting it succeeds. Signed-off-by: Chris Wilson --- tests/gem_cpu_reloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/gem_cpu_reloc.c b/tests/gem_cpu_reloc.c index 882c312d4..e3bbcd239 100644 --

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/5] igt/kms_getfb: Check the iface exists before use

2018-10-01 Thread Antonio Argenziano
On 28/09/18 03:19, Chris Wilson wrote: If the driver doesn't support the getfb iface (e.g. because KMS has been disabled), the ioctls will fail with ENOTSUP. This is expected, so skip the test as nothing useful can be learnt. Signed-off-by: Chris Wilson --- tests/kms_getfb.c | 40 ++

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/5] igt/kms_getfb: Check the iface exists before use

2018-10-01 Thread Antonio Argenziano
On 01/10/18 12:43, Chris Wilson wrote: Quoting Antonio Argenziano (2018-10-01 19:36:24) On 28/09/18 03:19, Chris Wilson wrote: If the driver doesn't support the getfb iface (e.g. because KMS has been disabled), the ioctls will fail with ENOTSUP. This is expected, so skip the te

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/5] igt/kms_getfb: Check the iface exists before use

2018-10-02 Thread Antonio Argenziano
On 02/10/18 01:30, Joonas Lahtinen wrote: Quoting Antonio Argenziano (2018-10-01 22:53:46) Fair enough. Acked-by: Antonio Argenziano for the series. Please, read the following chapters (they're applicable for the patch tag meanings in IGT, too): https://www.kernel.org/doc/html/

Re: [Intel-gfx] [PATCH i-g-t] lib/gt: Make use of dummyload library to create recursive batch

2018-07-13 Thread Antonio Argenziano
On 13/07/18 03:06, Chris Wilson wrote: From: Antonio Argenziano An hanging batch is nothing more than a spinning batch that never gets stopped, so re-use the routines implemented in dummyload.c. v2: Let caller decide spin loop size v3: Only use loose loops for hangs (Chris) v4: No requires

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt: Remove gvt_basic

2018-07-17 Thread Antonio Argenziano
On 17/07/18 05:43, Chris Wilson wrote: Quoting Chris Wilson (2018-07-13 18:57:41) This was always a placeholder for GVT stakeholders to provide some better tests. 2 years later and none have been put forward so stop wasting CI's time running a placeholder. Bugzilla: https://bugs.freedesktop.o

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/3] igt/gem_sync: Exercising waiting while keeping the GPU busy

2018-08-10 Thread Antonio Argenziano
On 10/08/18 04:01, Chris Wilson wrote: Normally we wait on the last request, but that overlooks any difficulties in waiting on a request while the next is being qeued. /s/qeued/queued Check those. Signed-off-by: Chris Wilson --- tests/gem_sync.c | 72

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/3] igt/gem_sync: Exercising waiting while keeping the GPU busy

2018-08-10 Thread Antonio Argenziano
On 10/08/18 10:51, Chris Wilson wrote: Quoting Antonio Argenziano (2018-08-10 18:41:22) On 10/08/18 04:01, Chris Wilson wrote: Normally we wait on the last request, but that overlooks any difficulties in waiting on a request while the next is being qeued. /s/qeued/queued Check those

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/3] igt/gem_sync: Exercising waiting while keeping the GPU busy

2018-08-14 Thread Antonio Argenziano
On 14/08/18 11:27, Chris Wilson wrote: Quoting Antonio Argenziano (2018-08-10 19:11:02) On 10/08/18 10:51, Chris Wilson wrote: Quoting Antonio Argenziano (2018-08-10 18:41:22) How does the test fail if the sync goes wrong? Hang detector on the queued batch? We have a hang detector for

Re: [Intel-gfx] [PATCH i-g-t 1/3] igt/gem_sync: Exercise sync after context switch

2018-08-14 Thread Antonio Argenziano
On 10/08/18 04:01, Chris Wilson wrote: This exercises a special case that may be of interest, waiting for a context that may be preempted in order to reduce the wait. Signed-off-by: Chris Wilson --- tests/gem_sync.c | 146 +++ 1 file changed, 146

Re: [Intel-gfx] [PATCH i-g-t 1/3] igt/gem_sync: Exercise sync after context switch

2018-08-15 Thread Antonio Argenziano
On 15/08/18 03:26, Chris Wilson wrote: Quoting Antonio Argenziano (2018-08-15 00:50:43) On 10/08/18 04:01, Chris Wilson wrote: This exercises a special case that may be of interest, waiting for a context that may be preempted in order to reduce the wait. Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH i-g-t 1/3] igt/gem_sync: Exercise sync after context switch

2018-08-15 Thread Antonio Argenziano
On 15/08/18 10:24, Chris Wilson wrote: Quoting Antonio Argenziano (2018-08-15 18:20:10) On 15/08/18 03:26, Chris Wilson wrote: Quoting Antonio Argenziano (2018-08-15 00:50:43) On 10/08/18 04:01, Chris Wilson wrote: This exercises a special case that may be of interest, waiting for a

Re: [Intel-gfx] [PATCH i-g-t 1/3] igt/gem_sync: Exercise sync after context switch

2018-08-16 Thread Antonio Argenziano
On 16/08/18 00:08, Chris Wilson wrote: Quoting Antonio Argenziano (2018-08-16 00:59:30) On 15/08/18 10:24, Chris Wilson wrote: Quoting Antonio Argenziano (2018-08-15 18:20:10) On 15/08/18 03:26, Chris Wilson wrote: Quoting Antonio Argenziano (2018-08-15 00:50:43) On 10/08/18 04:01

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/3] gem_sync: Measure wakeup latency while also scheduling the next batch

2018-08-17 Thread Antonio Argenziano
On 10/08/18 04:01, Chris Wilson wrote: More variants on stress waits to serve the dual purpose of investigating different aspects of the latency (this time while also serving execlists interrupts) while also checking that we never miss the wakeup. Signed-off-by: Chris Wilson --- tests/gem_s

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module

2018-08-17 Thread Antonio Argenziano
On 15/08/18 02:25, Chris Wilson wrote: Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload") Signed-off-by: Chris Wilson --- tests/pm_rpm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c index 65489bcdb..a4f9f783e 100

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] igt/pm_rpm: Avoid at_exit_drm_fd

2018-08-17 Thread Antonio Argenziano
On 15/08/18 13:59, Chris Wilson wrote: Keep the drm_fd owned by pm_rpm as we need to relinquish all ownership of the device in order to unload the module. Signed-off-by: Chris Wilson LGTM. Reviewed-by: Antonio Argenziano --- tests/pm_rpm.c | 5 - 1 file changed, 4 insertions

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module

2018-08-17 Thread Antonio Argenziano
On 17/08/18 10:49, Chris Wilson wrote: Quoting Antonio Argenziano (2018-08-17 18:29:09) On 15/08/18 02:25, Chris Wilson wrote: Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload") Signed-off-by: Chris Wilson --- tests/pm_rpm.c | 2 ++

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib: Cancel all outstanding requests at the end of a test

2018-09-07 Thread Antonio Argenziano
degrades into the existing mechanism. Signed-off-by: Chris Wilson LGTM. Just, if I have to be really picky, the comment for quiescent_gpu() says it is installed as an exit handler. Reviewed-by: Antonio Argenziano --- lib/drmtest.c | 25 +++-- lib/igt_debugfs.h

Re: [Intel-gfx] [igt-dev] [PATCH igt 1/3] igt/gem_eio: Exercise set-wedging against request submission

2018-03-16 Thread Antonio Argenziano
son Cc: Mika Kuoppala LGTM. Acked-by: Antonio Argenziano --- tests/gem_eio.c | 108 1 file changed, 108 insertions(+) ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org ht

Re: [Intel-gfx] [igt-dev] [PATCH igt 2/3] igt/gem_exec_fence: Exercise merging fences

2018-03-16 Thread Antonio Argenziano
all = -1; + for_each_engine(fd, engine) { for_each_physical_engines to avoid submitting twice to the same engine. Other than that it LGTM. Reviewed-by: Antonio Argenziano + int fence, new; + + execbuf.flags = engine | LOCAL_EXEC_FENCE_OUT; + execbuf.rsvd2 =

  1   2   >