Re: [Intel-gfx] [PATCH] drm/i915/guc: Protect against HAS_GUC_* returning true values other than one

2016-07-05 Thread Antoine, Peter
This is not quite right. If no guc loading then there should be no guc_submission can't have submission without loading. But, I guess that should be handled later. Peter. -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Tvrtko Ursulin Sen

Re: [Intel-gfx] [I-G-T] igt/gem_mocs_settings: improve RC6 testings

2016-07-21 Thread Antoine, Peter
-Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Thursday, July 21, 2016 9:40 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org Subject: Re: [I-G-T] igt/gem_mocs_settings: improve RC6 testings On Tue, Jul 19, 2016 at 11:25:29AM +0100, Peter Antoine

Re: [Intel-gfx] [I-G-T] igt/gem_mocs_settings: improve RC6 testings

2016-07-22 Thread Antoine, Peter
-Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Friday, July 22, 2016 10:38 AM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org Subject: Re: [I-G-T] igt/gem_mocs_settings: improve RC6 testings On Thu, Jul 21, 2016 at 09:49:51PM +, Antoine, Peter

Re: [Intel-gfx] [I-G-T 2/3] igt/gem_mocs_settings: adding RC6 testings

2016-07-29 Thread Antoine, Peter
Please Ignore this patch. Finger trouble. Peter. -Original Message- From: Antoine, Peter Sent: Friday, July 29, 2016 10:35 AM To: intel-gfx@lists.freedesktop.org Cc: ch...@chris-wilson.co.uk; Antoine, Peter Subject: [I-G-T 2/3] igt/gem_mocs_settings: adding RC6 testings This change

Re: [Intel-gfx] [PATCH v3 1/6] drm/i915/guc: Make the GuC fw loading helper functions general

2016-08-02 Thread Antoine, Peter
riginal Message- From: Gordon, David S Sent: Friday, July 29, 2016 12:19 PM To: Antoine, Peter ; intel-gfx@lists.freedesktop.org Subject: Re: [PATCH v3 1/6] drm/i915/guc: Make the GuC fw loading helper functions general On 06/07/16 15:24, Peter Antoine wrote: > Rename some of the GuC fw lo

Re: [Intel-gfx] [I-G-T 3/3] igt/gem_mocs_settings: Reduce the amount of cascading failures

2016-08-02 Thread Antoine, Peter
nal"/"skip" handler so that the tidyup can be done cleanly. That was the question that was asked and not answered. Peter. -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Tuesday, August 2, 2016 3:37 PM To: Antoine

Re: [Intel-gfx] [I-G-T 3/3] igt/gem_mocs_settings: Reduce the amount of cascading failures

2016-08-03 Thread Antoine, Peter
Drop this patch. Peter. -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Wednesday, August 3, 2016 8:37 AM To: Antoine, Peter Cc: Daniel Vetter ; Chris Wilson ; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [I-G-T 3/3

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Consolidate firmware major-minor to one place

2016-08-10 Thread Antoine, Peter
Should we not get the HuC patches merged before we amend them? Peter. -Original Message- From: Gordon, David S Sent: Wednesday, August 10, 2016 4:25 PM To: Tvrtko Ursulin ; Intel-gfx@lists.freedesktop.org Cc: Ursulin, Tvrtko ; Vivi, Rodrigo ; Antoine, Peter ; Thierry, Michel Subject

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/guc: Make the GuC fw loading helper functions general

2016-08-11 Thread Antoine, Peter
Just rebasing now. Is the other patch ok? Peter. -Original Message- From: Gordon, David S Sent: Thursday, August 11, 2016 11:56 AM To: Antoine, Peter ; intel-gfx@lists.freedesktop.org Cc: Alex Dai Subject: Re: [PATCH v4 1/6] drm/i915/guc: Make the GuC fw loading helper functions

Re: [Intel-gfx] [PATCH v4 2/6] drm/i915/huc: Unified css_header struct for GuC and HuC

2016-08-11 Thread Antoine, Peter
I'll add the blank lines. Patched should be turned around today. Thanks for the review. Peter. -Original Message- From: Gordon, David S Sent: Thursday, August 11, 2016 12:03 PM To: Antoine, Peter ; intel-gfx@lists.freedesktop.org Cc: Alex Dai Subject: Re: [PATCH v4 2/6] drm/i91

Re: [Intel-gfx] [PATCH v4 6/6] drm/i915/huc: Add BXT HuC Loading Support

2016-08-11 Thread Antoine, Peter
: Antoine, Peter ; intel-gfx@lists.freedesktop.org Subject: Re: [PATCH v4 6/6] drm/i915/huc: Add BXT HuC Loading Support On 04/08/16 09:16, Peter Antoine wrote: > This patch adds the HuC Loading for the BXT. > Version 1.7 of the HuC firmware. > > v2: rebased. > v3: rebased. > ch

Re: [Intel-gfx] ✗ Ro.CI.BAT: failure for HuC Loading Patches

2016-08-12 Thread Antoine, Peter
This would be so much easier if there was actually a link to the test server rather than having to work it out. Peter -Original Message- From: Patchwork [mailto:patchw...@emeril.freedesktop.org] Sent: Friday, August 12, 2016 9:35 AM To: Antoine, Peter Cc: intel-gfx

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/get_params: Add HuC status to getparams

2016-08-17 Thread Antoine, Peter
Will do for both patches. Peter. -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Wednesday, August 17, 2016 1:11 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/get_params: Add HuC status to

Re: [Intel-gfx] [PATCH 2/2] i915/guc: Add Kabylake GuC Loading

2016-06-03 Thread Antoine, Peter
I'll remove the comment. :) -Original Message- From: Thierry, Michel Sent: Friday, June 3, 2016 9:44 AM To: Antoine, Peter ; intel-gfx@lists.freedesktop.org Cc: Gordon, David S Subject: Re: [PATCH 2/2] i915/guc: Add Kabylake GuC Loading On 6/2/2016 6:01 PM, Peter Antoine wrote: &

Re: [Intel-gfx] [PATCH 6/6] drm/i915/huc: Add BXT HuC Loading Support

2016-06-21 Thread Antoine, Peter
to use :) ). -Original Message- From: Vivi, Rodrigo Sent: Tuesday, June 21, 2016 7:26 PM To: intel-gfx@lists.freedesktop.org; Antoine, Peter Cc: Prigent, Christophe ; Kelley, Sean V ; Gordon, David S ; Li, Lawrence T Subject: Re: [PATCH 6/6] drm/i915/huc: Add BXT HuC Loading Support Hi

Re: [Intel-gfx] [PATCH 2/6] drm/i915/huc: Unified css_header struct for GuC and HuC

2016-06-30 Thread Antoine, Peter
-Original Message- From: Gordon, David S Sent: Tuesday, June 28, 2016 3:33 PM To: Antoine, Peter ; intel-gfx@lists.freedesktop.org Cc: Prigent, Christophe ; Kelley, Sean V ; Li, Lawrence T ; Vivi, Rodrigo ; Dai, Yu Subject: Re: [PATCH 2/6] drm/i915/huc: Unified css_header struct for

Re: [Intel-gfx] [PATCH 5/6] drm/i915/huc: Support HuC authentication

2016-06-30 Thread Antoine, Peter
-Original Message- From: Gordon, David S Sent: Tuesday, June 28, 2016 4:08 PM To: Antoine, Peter ; intel-gfx@lists.freedesktop.org Cc: Prigent, Christophe ; Kelley, Sean V ; Li, Lawrence T ; Vivi, Rodrigo ; Dai, Yu Subject: Re: [PATCH 5/6] drm/i915/huc: Support HuC authentication On

Re: [Intel-gfx] [PATCH] drm/i915/mocs: Program MOCS for all engines on init

2016-03-10 Thread Antoine, Peter
Ignore this patch. It is the wrong patch. Peter. -Original Message- From: Antoine, Peter Sent: Thursday, March 10, 2016 3:27 PM To: intel-gfx@lists.freedesktop.org Cc: Mcgee, Jeff ; Antoine, Peter Subject: [PATCH] drm/i915/mocs: Program MOCS for all engines on init Allow for the MOCS

Re: [Intel-gfx] [PATCH] drm/i915/mocs: Program MOCS for all engines on init

2016-03-10 Thread Antoine, Peter
Sorry chris, resent the patch, it was the wrong one. I'll update the version and send again. Peter. -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Thursday, March 10, 2016 3:36 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org Subject: Re: [

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-04 Thread Antoine, Peter
r the different tables? Peter. -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Wednesday, May 4, 2016 2:47 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org; Widawsky, Benjamin Subject: Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-05 Thread Antoine, Peter
.intel.com] Sent: Wednesday, May 4, 2016 5:56 PM To: Antoine, Peter Cc: Chris Wilson ; intel-gfx@lists.freedesktop.org; Widawsky, Benjamin Subject: Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state On Wed, May 04, 2016 at 03:51:21PM +0100, Peter Antoine wrote: > > Sorry Ville,

Re: [Intel-gfx] [PATCH v3] drm/i915: resize the GuC WOPCM for rc6

2016-05-05 Thread Antoine, Peter
: Gordon, David S Sent: Thursday, May 5, 2016 2:41 PM To: Antoine, Peter ; intel-gfx@lists.freedesktop.org Cc: Vivi, Rodrigo Subject: Re: [PATCH v3] drm/i915: resize the GuC WOPCM for rc6 On 26/04/2016 10:11, Peter Antoine wrote: > This patch resizes the GuC WOPCM to so that the GuC and the RC6 mem

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-06 Thread Antoine, Peter
Anymore feedback on this? -Original Message- From: Antoine, Peter Sent: Thursday, May 5, 2016 8:17 AM To: Ville Syrjälä Cc: Chris Wilson ; intel-gfx@lists.freedesktop.org; Widawsky, Benjamin Subject: RE: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state It's a little ove

Re: [Intel-gfx] [PATCH v3] drm/i915: resize the GuC WOPCM for rc6

2016-05-10 Thread Antoine, Peter
best bet for RC6 issues. I hope that helps. Peter. -Original Message- From: Paauwe, Bob J Sent: Tuesday, May 10, 2016 4:59 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo Subject: Re: [Intel-gfx] [PATCH v3] drm/i915: resize the GuC WOPCM for rc6 On Tue, 26 Apr

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Add Broxton GuC firmware loading support

2016-05-10 Thread Antoine, Peter
Reviewed-by: peter.anto...@intel.com -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Nick Hoath Sent: Friday, May 6, 2016 11:43 AM To: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Add Broxton GuC firmware l

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Use major_minor version for filename

2016-05-10 Thread Antoine, Peter
Reviewed-by: peter.anto...@intel.com -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Nick Hoath Sent: Friday, May 6, 2016 11:43 AM To: intel-gfx@lists.freedesktop.org Cc: O'Rourke, Tom Subject: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Use maj

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: resize the GuC WOPCM for rc6

2016-05-12 Thread Antoine, Peter
-Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Tuesday, April 26, 2016 3:20 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: resize the GuC WOPCM for rc6 On

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Wait after context init with GuC Submission

2016-01-11 Thread Antoine, Peter
Ok, Please ignore this patch. It is really part of the pre-emption series. Was included as is being used in Android. Peter. -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Friday, January 8, 2016 3:20 PM To: Antoine, Peter Cc: intel-gfx

Re: [Intel-gfx] [PATCH] i915/guc: Add Kabylake GuC Loading

2016-01-19 Thread Antoine, Peter
Yup, I missed a patch. Just sent a new sequence. Peter. -Original Message- From: Dai, Yu Sent: Tuesday, January 19, 2016 6:18 PM To: Antoine, Peter; intel-gfx@lists.freedesktop.org Cc: daniel.vet...@ffwll.ch; Gordon, Dave; Thierry, Michel Subject: Re: [PATCH] i915/guc: Add Kabylake GuC

Re: [Intel-gfx] [PATCH] i915/guc: Add Kabylake GuC Loading

2016-01-19 Thread Antoine, Peter
Please look at v2, had to change the order of the patches. -Original Message- From: Antoine, Peter Sent: Tuesday, January 19, 2016 9:20 PM To: Dai, Yu; intel-gfx@lists.freedesktop.org Cc: daniel.vet...@ffwll.ch; Gordon, Dave; Thierry, Michel Subject: RE: [PATCH] i915/guc: Add Kabylake

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread Antoine, Peter
l.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Tuesday, March 31, 2015 2:26 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock On Tue, Mar 31, 2015 at 09:09:33AM +0100, Peter Antoine wrote: > This patch fixes a possibl

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread Antoine, Peter
Patch ordering, is deliberate. They are not dependent on each other. I'll rebase and add the new dri-de...@lists.freedesktop.org when is resubmit the patches. Peter. -Original Message- From: Lespiau, Damien Sent: Tuesday, March 31, 2015 2:35 PM To: Daniel Vetter Cc: Antoine,

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread Antoine, Peter
No problem. Will sequence them when I re-submit. -Original Message- From: Lespiau, Damien Sent: Tuesday, March 31, 2015 2:44 PM To: Antoine, Peter Cc: Daniel Vetter; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock On Tue, Mar 31, 2015 at

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-03-31 Thread Antoine, Peter
Probably. I'll need to check this end. I'll have a look. Peter. -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Tuesday, March 31, 2015 3:01 PM To: Antoine, Peter Cc: Daniel Vetter; intel-gfx@lists.freedesktop.org S

Re: [Intel-gfx] [PATCH] drm/i915 : Added Programming of the MOCS

2015-06-05 Thread Antoine, Peter
Done. I'll wait abit any other review responses then update the patch. Peter. -Original Message- From: Matt Turner [mailto:matts...@gmail.com] Sent: Thursday, June 4, 2015 10:33 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915 :

Re: [Intel-gfx] [PATCH v2] drm/i915 : Added Programming of the MOCS

2015-06-05 Thread Antoine, Peter
015 3:54 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v2] drm/i915 : Added Programming of the MOCS On Fri, Jun 05, 2015 at 03:43:36PM +0100, Peter Antoine wrote: > This change adds the programming of the MOCS registers to the gen 9+ > platforms.

Re: [Intel-gfx] [PATCH v3] drm/i915 : Added Programming of the MOCS

2015-06-17 Thread Antoine, Peter
On Mon, 2015-06-15 at 14:51 +0200, Daniel Vetter wrote: > On Wed, Jun 10, 2015 at 09:12:16AM +0100, Peter Antoine wrote: > > This change adds the programming of the MOCS registers to the gen 9+ > > platforms. This change set programs the MOCS register values to a set > > of values that are defined

Re: [Intel-gfx] [PATCH v3] drm/i915 : Added Programming of the MOCS

2015-06-17 Thread Antoine, Peter
On Wed, 2015-06-10 at 11:37 +0100, Chris Wilson wrote: > On Wed, Jun 10, 2015 at 09:12:16AM +0100, Peter Antoine wrote: > > This change adds the programming of the MOCS registers to the gen 9+ > > platforms. This change set programs the MOCS register values to a set > > of values that are defined t

Re: [Intel-gfx] [PATCH v4] drm/i915 : Added Programming of the MOCS

2015-06-18 Thread Antoine, Peter
On Wed, 2015-06-17 at 17:33 +0100, Chris Wilson wrote: > On Wed, Jun 17, 2015 at 04:19:22PM +0100, Peter Antoine wrote: > > This change adds the programming of the MOCS registers to the gen 9+ > > platforms. This change set programs the MOCS register values to a set > > of values that are defined

Re: [Intel-gfx] [PATCH v4] drm/i915 : Added Programming of the MOCS

2015-06-18 Thread Antoine, Peter
-Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Thursday, June 18, 2015 8:42 AM To: Daniel Vetter Cc: Antoine, Peter; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v4] drm/i915 : Added Programming of the MOCS On Thu, Jun 18, 2015 at 08:59

Re: [Intel-gfx] [PATCH v4] drm/i915 : Added Programming of the MOCS

2015-06-18 Thread Antoine, Peter
On Thu, 2015-06-18 at 08:49 +0100, ch...@chris-wilson.co.uk wrote: > On Thu, Jun 18, 2015 at 07:36:41AM +0000, Antoine, Peter wrote: > > > > On Wed, 2015-06-17 at 17:33 +0100, Chris Wilson wrote: > > > On Wed, Jun 17, 2015 at 04:19:22PM +0100, Peter Antoine wrote: >

Re: [Intel-gfx] [PATCH v4] drm/i915 : Added Programming of the MOCS

2015-06-18 Thread Antoine, Peter
On Thu, 2015-06-18 at 10:10 +0100, ch...@chris-wilson.co.uk wrote: > On Thu, Jun 18, 2015 at 08:45:10AM +0000, Antoine, Peter wrote: > > On Thu, 2015-06-18 at 08:49 +0100, ch...@chris-wilson.co.uk wrote: > > > On Thu, Jun 18, 2015 at 07:36:41AM +0000, Antoine, Peter wrote: >

Re: [Intel-gfx] [PATCH v5] drm/i915 : Added Programming of the MOCS

2015-06-18 Thread Antoine, Peter
-Original Message- From: Lespiau, Damien Sent: Thursday, June 18, 2015 2:51 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org; daniel.vetter.intel@irsmsx102.ger.corp.intel.com; ch...@chris-wilson.co.uk; matts...@gmail.com Subject: Re: [PATCH v5] drm/i915 : Added

Re: [Intel-gfx] [PATCH v5] drm/i915 : Added Programming of the MOCS

2015-06-18 Thread Antoine, Peter
On Thu, 2015-06-18 at 16:50 +0100, Damien Lespiau wrote: > On Thu, Jun 18, 2015 at 03:45:44PM +0100, Antoine, Peter wrote: > > Not a blocker. It gets a little more interesting, as the L3CC > > registers are shared across all engines, but is only saved in the RCS > > context

Re: [Intel-gfx] [PATCH 2/3] drm: Convert drm_legacy_ctxbitmap_init to void return type

2015-06-23 Thread Antoine, Peter
On Tue, 2015-06-23 at 11:37 +0200, Daniel Vetter wrote: > It can't fail really. > > Also remove the redundant kms check Peter added. > > Cc: Peter Antoine > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_context.c | 5 ++--- > drivers/gpu/drm/drm_drv.c | 10 +- > drivers

Re: [Intel-gfx] [PATCH 1/3] drm: Turn off Legacy Context Functions

2015-06-23 Thread Antoine, Peter
On Tue, 2015-06-23 at 11:37 +0200, Daniel Vetter wrote: > From: Peter Antoine > > The context functions are not used by the i915 driver and should not > be used by modeset drivers. These driver functions contain several bugs > and security holes. This change makes these functions optional can be

Re: [Intel-gfx] [PATCH 3/3] drm: Reject DRI1 hw lock ioctl functions for kms drivers

2015-06-23 Thread Antoine, Peter
On Tue, 2015-06-23 at 11:37 +0200, Daniel Vetter wrote: > I've done some extensive history digging across libdrm, mesa and > xf86-video-{intel,nouveau,ati}. The only potential user of this with > kms drivers I could find was ttmtest, which once used drmGetLock > still. But that mistake was quickly

Re: [Intel-gfx] [PATCH] drm: Kernel Crash in drm_unlock

2015-04-15 Thread Antoine, Peter
have DRIVER_KMS_LEGACY_CONTEXT enabled? Is this about right? Thanks, Peter. On Tue, 2015-03-31 at 16:00 +0200, Daniel Vetter wrote: > On Tue, Mar 31, 2015 at 01:34:25PM +0000, Antoine, Peter wrote: > > This was found by the security guys using an ioctl fuzzer. > > 12 lines of

Re: [Intel-gfx] [PATCH 1/5] drm: Kernel Crash in drm_unlock

2015-04-23 Thread Antoine, Peter
] Sent: Thursday, April 23, 2015 3:20 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org; airl...@redhat.com; dri-de...@lists.freedesktop.org; daniel.vet...@ffwll.ch Subject: Re: [Intel-gfx] [PATCH 1/5] drm: Kernel Crash in drm_unlock On Thu, Apr 23, 2015 at 03:07:54PM +0100, Peter Antoine

Re: [Intel-gfx] [PATCH 1/5] drm: Kernel Crash in drm_unlock

2015-04-23 Thread Antoine, Peter
found it) and we should reward them with a application exit. Peter. On Thu, 2015-04-23 at 15:39 +0100, Chris Wilson wrote: > On Thu, Apr 23, 2015 at 02:34:24PM +0000, Antoine, Peter wrote: > > Before the patch the system required rebooting (driver crash and/or kernel > > pani

Re: [Intel-gfx] [PATCH] drm/i915: Avoid GPU hang when coming out of P3 or P4

2015-04-27 Thread Antoine, Peter
Ignore this. I mean S3/S4 not P3/P4. -Original Message- From: Antoine, Peter Sent: Monday, April 27, 2015 3:25 PM To: intel-gfx@lists.freedesktop.org Cc: S, Deepak; Weinehall, David; Tian, YeX; Antoine, Peter Subject: [PATCH] drm/i915: Avoid GPU hang when coming out of P3 or P4 This

Re: [Intel-gfx] [PATCH 4/5] drm: Make HW_LOCK access functions optional.

2015-04-27 Thread Antoine, Peter
Hi, (replies inline) -Original Message- From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] Sent: Monday, April 27, 2015 6:04 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org; airl...@redhat.com; dri-de...@lists.freedesktop.org; daniel.vet...@ffwll.ch Subject: Re

Re: [Intel-gfx] [PATCH i-g-t] tests/drm_hw_lock: Tests for hw_lock fixes.

2015-04-28 Thread Antoine, Peter
Thanks for the review, new patch inbound. -Original Message- From: Thomas Wood [mailto:thomas.w...@intel.com] Sent: Monday, April 27, 2015 4:25 PM To: Antoine, Peter Cc: Intel Graphics Development; airl...@redhat.com; dri-de...@lists.freedesktop.org; Daniel Vetter Subject: Re: [Intel

Re: [Intel-gfx] [PATCH i-g-t] tests/drm_hw_lock: Tests for hw_lock fixes.

2015-04-28 Thread Antoine, Peter
On Mon, 2015-04-27 at 16:33 +0100, Chris Wilson wrote: > On Mon, Apr 27, 2015 at 04:24:37PM +0100, Thomas Wood wrote: > > On 23 April 2015 at 15:07, Peter Antoine wrote: > > > There are several issues with the hardware locks functions that stretch > > > from kernel crashes to priority escalations.

Re: [Intel-gfx] [PATCH 4/5] drm: Make HW_LOCK access functions optional.

2015-04-28 Thread Antoine, Peter
reply at end. On Tue, 2015-04-28 at 13:40 +0300, Ville Syrjälä wrote: > On Tue, Apr 28, 2015 at 05:52:20AM +0000, Antoine, Peter wrote: > > Hi, > > > > (replies inline) > > > > -Original Message- > > From: Ville Syrjälä [mailto:ville.syrj...@linux

Re: [Intel-gfx] [PATCH 4/5] drm: Make HW_LOCK access functions optional.

2015-04-28 Thread Antoine, Peter
On Tue, 2015-04-28 at 16:08 +0300, Ville Syrjälä wrote: > On Tue, Apr 28, 2015 at 11:29:06AM +0000, Antoine, Peter wrote: > > > > > diff --git a/include/drm/drmP.h b/include/drm/drmP.h index > > > > > 62c40777..367e42f 100644 > > > > > --- a/inclu

Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid GPU hang when coming out of S3 or S4

2015-04-28 Thread Antoine, Peter
; Antoine, Peter; intel-gfx@lists.freedesktop.org; Tian, YeX; Weinehall, David Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid GPU hang when coming out of S3 or S4 Yes agreed, we need to make changes in other paths :) On Tuesday 28 April 2015 02:14 PM, Chris Wilson wrote: > On Tue, Apr 28, 2

Re: [Intel-gfx] [PATCH 1/5] drm: Kernel Crash in drm_unlock

2015-05-04 Thread Antoine, Peter
On Mon, 2015-05-04 at 15:52 +0200, Daniel Vetter wrote: > On Tue, Apr 28, 2015 at 10:52:32AM +0100, ch...@chris-wilson.co.uk wrote: > > On Tue, Apr 28, 2015 at 10:21:49AM +0100, Dave Gordon wrote: > > > On 24/04/15 06:52, Antoine, Peter wrote: > > > > I picked up

Re: [Intel-gfx] [PATCH 3/5] drm: Possible lock priority escalation.

2015-05-04 Thread Antoine, Peter
On Mon, 2015-05-04 at 15:56 +0200, Daniel Vetter wrote: > On Mon, Apr 27, 2015 at 07:52:46PM +0300, Ville Syrjälä wrote: > > On Thu, Apr 23, 2015 at 03:07:56PM +0100, Peter Antoine wrote: > > > If an application that has a driver lock created, wants the lock the > > > kernel context, it is not allo

Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid GPU hang when coming out of S3 or S4

2015-05-05 Thread Antoine, Peter
> > On Tue, Apr 28, 2015 at 02:38:25PM +, Antoine, Peter wrote: > > > > > So is the plan to push these patches and have follow-on work to cover > > > > > the other paths? > > > > > As this fixes the Bugzilla issue that has been raised.

Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid GPU hang when coming out of S3 or S4

2015-05-05 Thread Antoine, Peter
at 02:07:19PM +0300, David Weinehall wrote: > > > > On Tue, Apr 28, 2015 at 03:46:46PM +0100, Chris Wilson wrote: > > > > > On Tue, Apr 28, 2015 at 02:38:25PM +, Antoine, Peter wrote: > > > > > > So is the plan to push these patches and have follow-on w

Re: [Intel-gfx] [PATCH i-g-t] tests/drm_hw_lock: Tests for hw_lock fixes.

2015-05-12 Thread Antoine, Peter
Please ignore this test as fixes are being implemented differently. On Thu, 2015-04-23 at 15:07 +0100, Peter Antoine wrote: > There are several issues with the hardware locks functions that stretch > from kernel crashes to priority escalations. This new test will test the > the fixes for these fea