Re: [Intel-gfx] [PATCH 0/2] Nuke PAGE_KERNEL_IO

2021-11-12 Thread Andy Lutomirski
6/xen/setup.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 4 ++-- include/asm-generic/fixmap.h | 2 +- 6 files changed, 6 insertions(+), 13 deletions(-) Acked-by: Andy Lutomirski

[Intel-gfx] Skylake underruns on 4.8-rc4

2016-08-29 Thread Andy Lutomirski
My Dell XPS 13 9350 laptop just got a buffer underrun: [drm:intel_cpu_fifo_underrun_irq_handler [i915]] *ERROR* CPU pipe A FIFO underrun I'm seeing this very occasionally, and they don't come in groups -- I seem to get one underrun with a black flash and that's it. This is with just the laptop s

[Intel-gfx] DP link training and performance issues with HDMI USB-C dongle and Skylake

2016-06-22 Thread Andy Lutomirski
I have a Dell XPS 13 9350 (Skylake) and a Dell DA200 adapter. The latter is a Thunderbolt device that includes an HDMI port and connects over USB Type C. I believe that it's internally using DP Alternate Mode. When I plug it in on 4.7-rc4, I get spew like this: [ 90.718106] [drm:intel_dp_star

[Intel-gfx] i915 Skylake crash on 4.4-rc3

2015-12-07 Thread Andy Lutomirski
[53834.386369] traps: gnome-session-b[2308] general protection ip:7f10efc1fc2b sp:7ffdfde31880 error:0 in libc-2.22.so[7f10efba1000+1b7000] [53834.687584] [ cut here ] [53834.687607] WARNING: CPU: 0 PID: 23730 at drivers/gpu/drm/i915/i915_gem_context.c:144 i915_gem_context_f

Re: [Intel-gfx] Possible 4.5 i915 Skylake regression

2016-02-16 Thread Andy Lutomirski
On Sun, Feb 14, 2016 at 6:59 PM, Andy Lutomirski wrote: > Hi- > > On 4.5-rc3 on a Dell XPS 13 9350 (Skylake i915, no nvidia on this > model), shortly after resume, I saw a single black flash on the > screen. The log said: > > [Feb13 07:05] [drm:intel_cpu_fifo_underrun_irq_h

Re: [Intel-gfx] Possible 4.5 i915 Skylake regression

2016-02-16 Thread Andy Lutomirski
On Tue, Feb 16, 2016 at 8:12 AM, Daniel Vetter wrote: > On Mon, Feb 15, 2016 at 06:58:33AM -0800, Andy Lutomirski wrote: >> On Sun, Feb 14, 2016 at 6:59 PM, Andy Lutomirski wrote: >> > Hi- >> > >> > On 4.5-rc3 on a Dell XPS 13 9350 (Skylake i915, no nvidi

Re: [Intel-gfx] Possible 4.5 i915 Skylake regression

2016-02-16 Thread Andy Lutomirski
On Tue, Feb 16, 2016 at 9:12 AM, Andy Lutomirski wrote: > On Tue, Feb 16, 2016 at 8:12 AM, Daniel Vetter wrote: >> On Mon, Feb 15, 2016 at 06:58:33AM -0800, Andy Lutomirski wrote: >>> On Sun, Feb 14, 2016 at 6:59 PM, Andy Lutomirski wrote: >>> > Hi- >>> &

Re: [Intel-gfx] Possible 4.5 i915 Skylake regression

2016-02-17 Thread Andy Lutomirski
On Wed, Feb 17, 2016 at 8:18 AM, Daniel Vetter wrote: > On Tue, Feb 16, 2016 at 09:26:35AM -0800, Andy Lutomirski wrote: >> On Tue, Feb 16, 2016 at 9:12 AM, Andy Lutomirski wrote: >> > On Tue, Feb 16, 2016 at 8:12 AM, Daniel Vetter wrote: >> >> On Mon, Feb 15,

Re: [Intel-gfx] Possible 4.5 i915 Skylake regression

2016-02-22 Thread Andy Lutomirski
On Wed, Feb 17, 2016 at 5:36 PM, Andy Lutomirski wrote: > On Wed, Feb 17, 2016 at 8:18 AM, Daniel Vetter wrote: >> On Tue, Feb 16, 2016 at 09:26:35AM -0800, Andy Lutomirski wrote: >>> On Tue, Feb 16, 2016 at 9:12 AM, Andy Lutomirski >>> wrote: >>> >

Re: [Intel-gfx] i915 Skylake: "Invalid ROM contents"

2016-02-29 Thread Andy Lutomirski
On Sun, Jan 10, 2016 at 11:12 AM, Andy Lutomirski wrote: > On Sun, Jan 10, 2016 at 10:41 AM, Andy Lutomirski wrote: >> On Wed, Nov 18, 2015 at 8:12 AM, Daniel Stone wrote: >>> Hi, >>> >>> On 18 November 2015 at 15:59, Andy Lutomirski wrote: >>>>

Re: [Intel-gfx] [PATCH v1 00/12] PCI: Rework shadow ROM handling

2016-03-11 Thread Andy Lutomirski
On Tue, Mar 8, 2016 at 9:45 AM, Bjorn Helgaas wrote: > On Thu, Mar 03, 2016 at 10:53:50AM -0600, Bjorn Helgaas wrote: >> The purpose of this series is to: >> >> - Fix the "BAR 6: [??? 0x flags 0x2] has bogus alignment" >> messages reported by Linus [1], Andy [2], and others. >> >>

Re: [Intel-gfx] [PATCH v1 00/12] PCI: Rework shadow ROM handling

2016-03-11 Thread Andy Lutomirski
On Fri, Mar 11, 2016 at 3:29 PM, Bjorn Helgaas wrote: > On Fri, Mar 11, 2016 at 01:16:09PM -0800, Andy Lutomirski wrote: >> On Tue, Mar 8, 2016 at 9:45 AM, Bjorn Helgaas wrote: >> > On Thu, Mar 03, 2016 at 10:53:50AM -0600, Bjorn Helgaas wrote: >> >> Th

Re: [Intel-gfx] Possible 4.5 i915 Skylake regression

2016-03-11 Thread Andy Lutomirski
On Mon, Feb 22, 2016 at 7:13 PM, Andy Lutomirski wrote: > On Wed, Feb 17, 2016 at 5:36 PM, Andy Lutomirski wrote: >> On Wed, Feb 17, 2016 at 8:18 AM, Daniel Vetter wrote: >>> On Tue, Feb 16, 2016 at 09:26:35AM -0800, Andy Lutomirski wrote: >>>> On Tue, Feb 16, 20

Re: [Intel-gfx] Possible 4.5 i915 Skylake regression

2016-03-13 Thread Andy Lutomirski
On Wed, Feb 17, 2016 at 8:18 AM, Daniel Vetter wrote: > On Tue, Feb 16, 2016 at 09:26:35AM -0800, Andy Lutomirski wrote: >> On Tue, Feb 16, 2016 at 9:12 AM, Andy Lutomirski wrote: >> > On Tue, Feb 16, 2016 at 8:12 AM, Daniel Vetter wrote: >> >> On Mon, Feb 15,

[Intel-gfx] i915 Skylake: "Invalid ROM contents"

2015-11-17 Thread Andy Lutomirski
Typing: # cat /sys/devices/pci:00/:00:02.0/rom Provokes: i915 :00:02.0: Invalid ROM contents This is on a Dell XPS 13 9350 (Skylake). This is 4.3.0 plus some wireless-next bits. --Andy -- Andy Lutomirski AMA Capital Management, LLC

Re: [Intel-gfx] i915 Skylake: "Invalid ROM contents"

2015-11-18 Thread Andy Lutomirski
[adding linux-pci] On Wed, Nov 18, 2015 at 2:59 AM, Ville Syrjälä wrote: > On Tue, Nov 17, 2015 at 11:43:25AM -0800, Andy Lutomirski wrote: >> Typing: >> >> # cat /sys/devices/pci:00/:00:02.0/rom >> >> Provokes: >> >> i915 :00:02.0: In

Re: [Intel-gfx] i915 Skylake: "Invalid ROM contents"

2016-01-10 Thread Andy Lutomirski
On Wed, Nov 18, 2015 at 8:12 AM, Daniel Stone wrote: > Hi, > > On 18 November 2015 at 15:59, Andy Lutomirski wrote: >> On Wed, Nov 18, 2015 at 2:59 AM, Ville Syrjälä >> wrote: >>> On Tue, Nov 17, 2015 at 11:43:25AM -0800, Andy Lutomirski wrote: >>>> Ty

Re: [Intel-gfx] i915 Skylake: "Invalid ROM contents"

2016-01-10 Thread Andy Lutomirski
On Sun, Jan 10, 2016 at 10:41 AM, Andy Lutomirski wrote: > On Wed, Nov 18, 2015 at 8:12 AM, Daniel Stone wrote: >> Hi, >> >> On 18 November 2015 at 15:59, Andy Lutomirski wrote: >>> On Wed, Nov 18, 2015 at 2:59 AM, Ville Syrjälä >>> wrote: >>>

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Improve PSR activation timing

2018-02-23 Thread Andy Lutomirski
On Tue, Feb 13, 2018 at 11:26 PM, Rodrigo Vivi wrote: > From: Andy Lutomirski > > + > + dev_priv->psr.activate_timer.expires = jiffies - 1; That can't possibly be okay. ___ Intel-gfx mailing list Intel-gfx@lists.f

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Improve PSR activation timing

2018-02-27 Thread Andy Lutomirski
On Wed, Feb 28, 2018 at 12:22 AM, Chris Wilson wrote: > Quoting Rodrigo Vivi (2018-02-28 00:14:08) >> From: Andy Lutomirski >> >> The current PSR code has a two call sites that each schedule delayed >> work to activate PSR. As far as I can tell, each call site inte

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Improve PSR activation timing

2018-02-27 Thread Andy Lutomirski
On Wed, Feb 28, 2018 at 12:26 AM, Chris Wilson wrote: > Quoting Andy Lutomirski (2018-02-24 00:07:23) >> On Tue, Feb 13, 2018 at 11:26 PM, Rodrigo Vivi >> wrote: >> > From: Andy Lutomirski >> > >> > + >> > + dev_priv->psr.activate_tim

Re: [Intel-gfx] REGRESSION in c5552fde102f ("nvme: Enable autonomous power state transitions")

2018-01-24 Thread Andy Lutomirski
On Wed, Jan 24, 2018 at 5:35 AM, Ville Syrjälä wrote: > On Wed, Jan 24, 2018 at 01:42:08PM +0200, Jani Nikula wrote: >> >> Hi Andy, all - >> >> So this is an odd one. >> >> I'm getting display FIFO underruns in a very specific setting: Laptop >> display switched off, and an external display connec

[Intel-gfx] i915 PSR test results and cursor lag

2018-02-01 Thread Andy Lutomirski
Hi- As requested in your blog post, I tested PSR. I see something like 2.69W with PSR off and 2.17W with PSR on. Screen blanking, suspend/resume, and the contents of the screen all seem okay. This is a Dell XPS 13 9350, i.e.: System Information Manufacturer: Dell Inc. Product N

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-01 Thread Andy Lutomirski
On Thu, Feb 1, 2018 at 9:40 AM, Andy Lutomirski wrote: > Hi- > > As requested in your blog post, I tested PSR. I see something like > 2.69W with PSR off and 2.17W with PSR on. Screen blanking, > suspend/resume, and the contents of the screen all seem okay. This is > a Del

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-01 Thread Andy Lutomirski
On Thu, Feb 1, 2018 at 9:53 AM, Chris Wilson wrote: > Quoting Andy Lutomirski (2018-02-01 17:40:22) >> *However*, I do see one unfortunate side effect of turning on PSR. It >> seems that, when I move my cursor a little bit after a few seconds of >> doing nothing, there see

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-01 Thread Andy Lutomirski
On Thu, Feb 1, 2018 at 9:20 PM, Chris Wilson wrote: > Quoting Andy Lutomirski (2018-02-01 21:04:30) >> I got this after a recent suspend/resume: >> >> Feb 01 09:44:34 laptop systemd-logind[2412]: Lid closed. >> Feb 01 09:44:34 laptop systemd-logind[2412]: device-enume

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-02 Thread Andy Lutomirski
On Fri, Feb 2, 2018 at 1:24 AM, Andy Lutomirski wrote: > On Thu, Feb 1, 2018 at 9:20 PM, Chris Wilson wrote: >> Quoting Andy Lutomirski (2018-02-01 21:04:30) >>> I got this after a recent suspend/resume: >>> >>> Feb 01 09:44:34 laptop systemd-logind[2412]: Li

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-02 Thread Andy Lutomirski
On Fri, Feb 2, 2018 at 7:18 PM, Andy Lutomirski wrote: > On Fri, Feb 2, 2018 at 1:24 AM, Andy Lutomirski wrote: >> On Thu, Feb 1, 2018 at 9:20 PM, Chris Wilson >> wrote: >>> Quoting Andy Lutomirski (2018-02-01 21:04:30) >>>> I got this after a recent suspe

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-03 Thread Andy Lutomirski
On Sat, Feb 3, 2018 at 5:20 AM, Pandiyan, Dhinakaran wrote: > > On Fri, 2018-02-02 at 19:18 +, Andy Lutomirski wrote: >> I updated to 4.15, and the situation is much worse. With >> enable_psr=1, the system survives for several seconds and then the >> screen stops

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-03 Thread Andy Lutomirski
On Fri, Feb 2, 2018 at 7:18 PM, Andy Lutomirski wrote: > On Fri, Feb 2, 2018 at 1:24 AM, Andy Lutomirski wrote: >> On Thu, Feb 1, 2018 at 9:20 PM, Chris Wilson >> wrote: >>> Quoting Andy Lutomirski (2018-02-01 21:04:30) >>>> I got this after a recent suspe

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-04 Thread Andy Lutomirski
On Sat, Feb 3, 2018 at 5:08 PM, Andy Lutomirski wrote: > On Sat, Feb 3, 2018 at 5:20 AM, Pandiyan, Dhinakaran > wrote: >> >> On Fri, 2018-02-02 at 19:18 +0000, Andy Lutomirski wrote: >>> I updated to 4.15, and the situation is much worse. With >>> enable_ps

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-05 Thread Andy Lutomirski
On Mon, Feb 5, 2018 at 6:53 PM, Pandiyan, Dhinakaran wrote: > > > > On Sun, 2018-02-04 at 21:50 +, Andy Lutomirski wrote: >> On Sat, Feb 3, 2018 at 5:08 PM, Andy Lutomirski wrote: >> > On Sat, Feb 3, 2018 at 5:20 AM, Pandiyan, Dhinakaran >> > wrote: >

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-05 Thread Andy Lutomirski
On Mon, Feb 5, 2018 at 9:17 PM, Pandiyan, Dhinakaran wrote: > > On Mon, 2018-02-05 at 20:35 +, Andy Lutomirski wrote: >> On Mon, Feb 5, 2018 at 6:53 PM, Pandiyan, Dhinakaran >> wrote: >> > >> > >> > >> > On Sun, 2018-02-04 at 21:50 +,

[Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

2018-02-05 Thread Andy Lutomirski
ded. This adds a new function intel_psr_schedule(), which will enable PSR after the requested time but no sooner. Signed-off-by: Andy Lutomirski --- drivers/gpu/drm/i915/i915_debugfs.c | 9 +++-- drivers/gpu/drm/i915/i915_drv.h | 4 ++- drivers/gpu/drm/i915/inte

Re: [Intel-gfx] i915 PSR test results and cursor lag

2018-02-05 Thread Andy Lutomirski
> On Feb 5, 2018, at 2:50 PM, Rodrigo Vivi wrote: > >> On Sat, Feb 03, 2018 at 05:33:08PM +, Andy Lutomirski wrote: >>> On Fri, Feb 2, 2018 at 7:18 PM, Andy Lutomirski wrote: >>>> On Fri, Feb 2, 2018 at 1:24 AM, Andy Lutomirski wrote: >>>>&

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

2018-02-08 Thread Andy Lutomirski
ch on that bugzilla entry but only now I stop to >> really think why I have written the code that way. >> >> So some clarity below. >> >>> On Mon, Feb 05, 2018 at 10:07:09PM +, Andy Lutomirski wrote: >>> The current PSR code has a two call sites that eac

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

2018-02-09 Thread Andy Lutomirski
ed with PSR and sorry for not replying sooner. >>>> >>>> I first saw this patch on that bugzilla entry but only now I stop to >>>> really think why I have written the code that way. >>>> >>>> So some clarity below. >>>>

[Intel-gfx] [PATCH] i915: Fix CRT hotplug regression in 2.6.35-rc1

2010-06-12 Thread Andy Lutomirski
later. The old code never restored PORT_HOTPLUG_EN so this could only happen once, but they new code restores those registers. So just set those bits when we set up the interrupt in the first place. Signed-off-by: Andy Lutomirski --- The regression was introduced by the Extra CRT hotplug par

Re: [Intel-gfx] [PATCH 0/3] fbdev no more!

2013-06-17 Thread Andy Lutomirski
On 06/16/2013 07:57 AM, Daniel Vetter wrote: > Hi all, > > So I've taken a look again at the locking mess in our fbdev support and cried. > Fixing up the console_lock mess around the fbdev notifier will be real work, > semanatically the fbdev layer does lots of stupid things (like the radeon > re

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use Write-Through cacheing for the display plane on Iris

2013-08-02 Thread Andy Lutomirski
On 08/01/2013 10:39 AM, Chris Wilson wrote: > Haswell GT3e has the unique feature of supporting Write-Through cacheing > of objects within the eLLC/LLC. The purpose of this is to enable the display > plane to remain coherent whilst objects lie resident in the eLLC/LLC - so > that we, in theory, get

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use Write-Through cacheing for the display plane on Iris

2013-08-02 Thread Andy Lutomirski
On Fri, Aug 2, 2013 at 12:21 PM, Ben Widawsky wrote: > On Fri, Aug 02, 2013 at 11:45:22AM -0700, Andy Lutomirski wrote: >> On 08/01/2013 10:39 AM, Chris Wilson wrote: >> > Haswell GT3e has the unique feature of supporting Write-Through cacheing >> > of objects within t

Re: [Intel-gfx] [PULL] drm-intel-next

2011-08-10 Thread Andy Lutomirski
On 08/03/2011 11:14 PM, Keith Packard wrote: Here's a pile of fixes on top of the stuff already in drm-core-next. * Pile of mode setting fixes which eliminate a selection of bugs and other annoyances. Eliminates the 'stripey' effect when going from two to one monitor, makes hot-plug w

[Intel-gfx] [RFC PATCH] drm: Fix off-by-one races on vblank disable

2011-11-16 Thread Andy Lutomirski
rdware and software vblank counts. Signed-off-by: Andy Lutomirski --- Rather than tweaking more things to reduce the chance of hitting a race while keeping the vblank disable timeout as low as possible, why not just fix the race? This compiles but is not very well tested, because I don't know wh

Re: [Intel-gfx] Intel graphics CPU usage - SDVO detect bogosity?

2010-08-16 Thread Andy Lutomirski
[cc: intel-gfx] Linus Torvalds wrote: > On Sun, Aug 15, 2010 at 9:06 PM, Andy Lutomirski wrote: >> You might be hitting the infamous hotplug storm [1]. The symptoms vary by >> kernel version. > > Hmm. I don't think it's a storm. The drm.debug=4 thing shows thing

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Andy Lutomirski
of 0 (!) before actually waiting. Signed-off-by: Andy Lutomirski --- Jesse, you asked for the deletion of the timer to be separate from reducing the timeout, but that seemed silly because I'm ripping out the entire old mechanism. If you're worried about the added time spent in the interrupt h

[Intel-gfx] [ANCIENT PATCH] Enable 30-bit depth

2011-04-19 Thread Andy Lutomirski
Signed-off-by: Andy Lutomirski --- This patch is over a year old, caused problems, and probably doesn't even apply anymore. It worked at least a little bit, though. There's a lot more that needs doing, especially in relation to DirectColor mode. src/intel_driver.c |5 +++-

[Intel-gfx] [PATCH] drm/i915: Revert i915.semaphore=1 default from 47ae63e0

2011-05-13 Thread Andy Lutomirski
drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem_execbuffer.c (It's worth noting that the offending change is i915_drv.c, which is not a conflict.) Signed-off-by: Andy Lutomirski --- This fixes a 2.6.39 regression that affects my Q67 box but not my SNB laptop. Send

Re: [Intel-gfx] [2.6.39-rc7] i915: kworker busily spinning...

2011-05-24 Thread Andy Lutomirski
n necessary, which might exacerbate the problem. Here's an old patch I wrote that probably doesn't apply any more but might help. commit 82c9114cdc60aba7d9bec1396d818362a208cfdc Author: Andy Lutomirski Date: Tue Aug 17 09:38:59 2010 -0400 drm: Try to poll fewer unnecessary

Re: [Intel-gfx] Regression: audit: x86: drop arch from __audit_syscall_entry() interface

2014-10-22 Thread Andy Lutomirski
On 10/22/2014 11:23 AM, Eric Paris wrote: > That's really serious. Looking now. > > On Wed, 2014-10-22 at 16:08 -0200, Paulo Zanoni wrote: >> Hi >> >> (Cc'ing everybody mentioned in the original patch) >> >> I work for Intel, on our Linux Graphics driver - aka i915.ko - and our >> QA team recentl

Re: [Intel-gfx] Regression: audit: x86: drop arch from __audit_syscall_entry() interface

2014-10-22 Thread Andy Lutomirski
On Wed, Oct 22, 2014 at 12:16 PM, Richard Guy Briggs wrote: > On 14/10/22, Andy Lutomirski wrote: >> On 10/22/2014 11:23 AM, Eric Paris wrote: >> > That's really serious. Looking now. >> > >> > On Wed, 2014-10-22 at 16:08 -0200, Paulo Zanoni wrot