Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/utils: do not depend on config being defined

W dniu 29.09.2021 o 20:33, Lucas De Marchi pisze: > Like the IS_ENABLED() counterpart, we can make IS_CONFIG_NONZERO() to > return the right thing when the config is not defined rather than a > build error, with the limitation that it can't be used on preprocessor > context. > > The trick here is

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/utils: do not depend on config being defined

W dniu 30.09.2021 o 00:54, Lucas De Marchi pisze: > On Wed, Sep 29, 2021 at 11:08:18PM +0200, Andrzej Hajda wrote: >> >> W dniu 29.09.2021 o 20:33, Lucas De Marchi pisze: >>> Like the IS_ENABLED() counterpart, we can make IS_CONFIG_NONZERO() to >>> return the r

Re: [Intel-gfx] [PATCH 1/4] drm/edid: Pass connector to AVI inforframe functions

Quite late, hopefully not too late. On 21.11.2018 12:51, Ville Syrjälä wrote: > On Wed, Nov 21, 2018 at 01:40:43PM +0200, Jani Nikula wrote: >> >>> return; >>> diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c >>> b/drivers/gpu/drm/bridge/sil-sii8620.c >>> index a6e8f4591e63..0cc293a

Re: [Intel-gfx] [PATCH 1/4] drm/edid: Pass connector to AVI inforframe functions

foframe_from_connector() then, unless mode passed and mode set on the connector differs? Regards Andrzej > > Please see below for an additional comment. > >> Cc: Alex Deucher >> Cc: "Christian König" >> Cc: "David (ChunMing) Zhou" >> Cc: Arch

Re: [Intel-gfx] [v2, 1/8] drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane

Hi Ville, As Christoph cannot respond till middle next week I can try to respond in his absence, as I am familiar with the subject. On 30.11.2018 14:25, Ville Syrjälä wrote: > On Fri, Nov 30, 2018 at 02:08:11PM +0100, Christoph Manszewski wrote: >> Hi, >> >> I am looking for a way to export the c

Re: [Intel-gfx] [v2, 1/8] drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane

On 30.11.2018 15:48, Hans Verkuil wrote: > On 11/30/18 15:29, Ville Syrjälä wrote: >> On Fri, Nov 30, 2018 at 03:20:59PM +0100, Andrzej Hajda wrote: >>> Hi Ville, >>> >>> As Christoph cannot respond till middle next week I can try to respond >>> in h

Re: [Intel-gfx] [v2, 1/8] drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane

On 03.12.2018 12:52, Hans Verkuil wrote: > On 12/03/2018 12:23 PM, Andrzej Hajda wrote: >> On 30.11.2018 15:48, Hans Verkuil wrote: >>> On 11/30/18 15:29, Ville Syrjälä wrote: >>>> On Fri, Nov 30, 2018 at 03:20:59PM +0100, Andrzej Hajda wrote: >>>>&

Re: [Intel-gfx] [PATCH 1/4] drm/edid: Pass connector to AVI inforframe functions

On 03.12.2018 22:48, Ville Syrjälä wrote: > On Thu, Nov 29, 2018 at 09:46:16AM +0100, Andrzej Hajda wrote: >> Quite late, hopefully not too late. >> >> >> On 21.11.2018 12:51, Ville Syrjälä wrote: >>> On Wed, Nov 21, 2018 at 01:40:43PM +0200, Jani Nikula wrote

Re: [Intel-gfx] [PATCH 1/4] drm/edid: Pass connector to AVI inforframe functions

On 03.12.2018 22:38, Ville Syrjälä wrote: > On Thu, Nov 29, 2018 at 10:08:07AM +0100, Andrzej Hajda wrote: >> On 21.11.2018 19:19, Laurent Pinchart wrote: >>> Hi Ville, >>> >>> Thank you for the patch. >>> >>> On Tuesday, 20 November 2018 18:1

Re: [Intel-gfx] [PATCH 1/4] drm/edid: Pass connector to AVI inforframe functions

On 04.12.2018 20:02, Ville Syrjälä wrote: > On Tue, Dec 04, 2018 at 08:03:53AM +0100, Andrzej Hajda wrote: >> On 03.12.2018 22:48, Ville Syrjälä wrote: >>> On Thu, Nov 29, 2018 at 09:46:16AM +0100, Andrzej Hajda wrote: >>>> Quite late, hopefully not too late. >

Re: [Intel-gfx] [PATCH 1/4] drm/edid: Pass connector to AVI inforframe functions

On 05.12.2018 07:32, Laurent Pinchart wrote: > Hi Ville, > > On Tuesday, 4 December 2018 21:13:20 EET Ville Syrjälä wrote: >> On Tue, Dec 04, 2018 at 08:46:53AM +0100, Andrzej Hajda wrote: >>> On 03.12.2018 22:38, Ville Syrjälä wrote: >>>> On Thu, Nov 29, 201

Re: [Intel-gfx] [PATCH v7] drm/i915/display: disable HPD workers before display driver unregister

On 10.06.2022 20:37, Ville Syrjälä wrote: On Fri, Jun 10, 2022 at 06:00:24PM +0200, Andrzej Hajda wrote: Handling HPD during driver removal is pointless, and can cause different use-after-free/concurrency issues: 1. Setup of deferred fbdev after fbdev unregistration. 2. Access to DP-AUX after

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix vm use-after-free in vma destruction

t;mutex. */ + gt = vma->vm->gt; mutex_unlock(&vma->vm->mutex); - release_references(vma, vm_ddestroy); + release_references(vma, gt, vm_ddestroy); Reviewed-by: Andrzej Hajda Regards Andrzej } void i915_vma_parked(struct intel_gt *gt)

[Intel-gfx] [PATCH 0/2] drm/i915/display: stop HPD workers before display driver unregister

ments, and more importantly I am not able to test properly. [1]: https://patchwork.freedesktop.org/series/103811/ Regards Andrzej Andrzej Hajda (2): drm/i915/hpd: postpone HPD cancel work after last user suspension drm/i915/fbdev: suspend HPD before fbdev unregistration drivers/gpu/drm/i9

[Intel-gfx] [PATCH 2/2] drm/i915/fbdev: suspend HPD before fbdev unregistration

] remove_conflicting_pci_framebuffers+0xc8/0x110 [272.634595] drm_aperture_remove_conflicting_pci_framebuffers+0x52/0x70 [272.634604] i915_driver_probe+0x63a/0xdd0 [i915] Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5329 Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5510 Signed-off-by: Andrzej

[Intel-gfx] [PATCH 1/2] drm/i915/hpd: postpone HPD cancel work after last user suspension

308] ? __down_killable+0x70/0x140 [283.406313] i915_digport_work_func+0xba/0x150 [i915] Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4586 Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5558 Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ driv

[Intel-gfx] [PATCH] drm/i915/selftests: fix subtraction overflow bug

t;) Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3674 Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix a lockdep warning at error capture

d of extra callbacks. Anyway both should work. Reviewed-by: Andrzej Hajda Regards Andrzej void (*cleanup)(struct i915_address_space *vm); void (*foreach)(struct i915_address_space *vm, diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/int

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: stop HPD workers before display driver unregister

On 27.06.2022 18:00, Patchwork wrote: *Patch Details* *Series:* drm/i915/display: stop HPD workers before display driver unregister *URL:* https://patchwork.freedesktop.org/series/105557/ *State:*failure *Details:* https://intel-gfx-c

Re: [Intel-gfx] [PATCH 2/2] drm/i915/fbdev: suspend HPD before fbdev unregistration

Thanks for comments, On 29.06.2022 07:38, Murthy, Arun R wrote: void intel_fbdev_unregister(struct drm_i915_private *dev_priv) { struct intel_fbdev *ifbdev = dev_priv->fbdev; @@ -573,6 +594,8 @@ void intel_fbdev_unregister(struct drm_i915_private *dev_priv) if (!ifbdev)

[Intel-gfx] [PATCH v2 0/2] drm/i915/display: stop HPD workers before display driver unregister

different requirements, and more importantly I am not able to test properly. v2 (thx Arun for review): - reword of commit message (Arun) - intel_fbdev_hpd_set_suspend replaced with intel_fbdev_set_suspend (Arun) [1]: https://patchwork.freedesktop.org/series/103811/ Regards Andrzej Andrzej Hajda (2):

[Intel-gfx] [PATCH v2 2/2] drm/i915/fbdev: suspend HPD before fbdev unregistration

] remove_conflicting_pci_framebuffers+0xc8/0x110 [272.634595] drm_aperture_remove_conflicting_pci_framebuffers+0x52/0x70 [272.634604] i915_driver_probe+0x63a/0xdd0 [i915] Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5329 Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5510 Signed-off-by: Andrzej

[Intel-gfx] [PATCH v2 1/2] drm/i915/hpd: postpone HPD cancel work after last user suspension

ned-off-by: Andrzej Hajda Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ drivers/gpu/drm/i915/i915_irq.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/disp

Re: [Intel-gfx] [PATCH] drm/i915: Drain freed object after suspend display

happen very late in the suspend process causing issues. So here draining all freed objects released by display fixing suspend issues. Describing the issues would be helpful, alternatively bug tracker reference if any. Signed-off-by: José Roberto de Souza Anyway: Reviewed-by: Andrzej Hajda

Re: [Intel-gfx] [PATCH] drm/i915: Remove __dma_fence_is_chain()

On 29.06.2022 01:35, Rob Clark wrote: From: Rob Clark drive-by cleanup Signed-off-by: Rob Clark Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/gem

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: fix subtraction overflow bug

On 27.06.2022 21:59, Patchwork wrote: *Patch Details* *Series:* drm/i915/selftests: fix subtraction overflow bug *URL:* https://patchwork.freedesktop.org/series/105597/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/

Re: [Intel-gfx] [PATCH] drm: i915: fix a possible refcount leak in intel_dp_add_mst_connector()

rrors in intel_dp_add_mst_connector") Signed-off-by: Hangyu Hua Reviewed-by: José Roberto de Souza Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_d

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: stop HPD workers before display driver unregister (rev2)

On 01.07.2022 10:51, Patchwork wrote: *Patch Details* *Series:* drm/i915/display: stop HPD workers before display driver unregister (rev2) *URL:* https://patchwork.freedesktop.org/series/105557/ *State:*failure *Details:* https://inte

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/gt: Serialize GRDOM access between multiple engine resets

d-off-by: Mauro Carvalho Chehab Reviewed-by: Andrzej Hajda Regards Andrzej --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 0/2] at: https://lore.kernel.org/all/cover.1656921701.git.mche...@kernel.org/ drivers/gpu/drm

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/gt: Serialize TLB invalidates with GT resets

backing store") Reported-by: Mauro Carvalho Chehab Tested-by: Mauro Carvalho Chehab Reviewed-by: Mauro Carvalho Chehab Cc: Chris Wilson Cc: Tvrtko Ursulin Cc: Thomas Hellström Cc: Andi Shyti Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH 1/2] i915/perf: Replace DRM_DEBUG with driver specific drm_dbg call

ses of &stream->perf->i915->drm I wonder if some helper wouldn't simplify things, sth like to_drm(stream) ? Anyway: Reviewed-by: Andrzej Hajda Regards Andrzej + "OA buffer overflow (exponent = %d): force restart\n", +

Re: [Intel-gfx] [PATCH 2/2] i915/perf: Disable OA sseu config param for gfx12.50+

mesh Nerlige Ramappa Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/i915_perf.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index b3beb89884e0..f3c23fe9ad9c 100644 --- a/drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH] drm/i915/gvt: IS_ERR() vs NULL bug in intel_gvt_update_reg_whitelist()

On 08.07.2022 10:41, Dan Carpenter wrote: The shmem_pin_map() function returns NULL, it doesn't return error pointers. Fixes: 97ea656521c8 ("drm/i915/gvt: Parse default state to update reg whitelist") Signed-off-by: Dan Carpenter Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH v5 4/7] drm/i915/gt: create per-tile sysfs interface

On 13.03.2022 20:45, Andi Shyti wrote: Hi Andrzej, I'm sorry, but I'm not fully understanding, +struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev, + const char *name) +{ + struct kobject *kobj = &dev->kobj; + + /* +*

Re: [Intel-gfx] [PATCH v6 3/7] drm/i915: Prepare for multiple GTs

wed-by: Matt Roper --- Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH v6 7/7] drm/i915/gt: Adding new sysfs frequency attributes

- throttle_reason_thermal - throttle_reason_prochot - throttle_reason_ratl - throttle_reason_vr_thermalert - throttle_reason_vr_tdc Signed-off-by: Sujaritha Sundaresan Cc: Dale B Stimson Signed-off-by: Andi Shyti --- Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH v6 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces

915. Signed-off-by: Andi Shyti Signed-off-by: Lucas De Marchi Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Matt Roper Cc: Sujaritha Sundaresan Cc: Tvrtko Ursulin --- Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH v6 4/7] drm/i915/gt: create per-tile sysfs interface

drivers/gpu/drm/i915/i915_sysfs.h| 3 + scripts/extract-cert | Bin 0 -> 17952 bytes With above removed. Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH 21/22] drm: Use drm_mode_init() for on-stack modes

lä --- Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH 22/22] drm: Use drm_mode_copy()

emcpy(&mode, E, S) + drm_mode_copy(&mode, E) ) @@ struct drm_display_mode *mode; @@ - &*mode + mode Signed-off-by: Ville Syrjälä --- Reviewed-by: Andrzej Hajda Regards Andrzej

[Intel-gfx] [PATCH] drm/i915/fbdev: unregister framebuffer after disabling hpd

634592] remove_conflicting_pci_framebuffers+0xc8/0x110 [272.634595] drm_aperture_remove_conflicting_pci_framebuffers+0x52/0x70 [272.634604] i915_driver_probe+0x63a/0xdd0 [i915] Signed-off-by: Andrzej Hajda --- Hi all, This patch tries to solve frequent issue [1]. Currently observed only on bat-rpls-2 machine on public Intel C

Re: [Intel-gfx] [PATCH 1/2] drm/i915/fbdev: print error in case drm_fb_helper_initial_config fails

Hi Jani, On 05.05.2022 20:37, Jani Nikula wrote: On Wed, 04 May 2022, Andrzej Hajda wrote: On some configurations drm_fb_helper_initial_config sometimes fails. Logging error value should help debugging such issues. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display

Re: [Intel-gfx] [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup

Syrjälä Reported-by: Andrzej Hajda Signed-off-by: Javier Martinez Canillas --- Reviewed-by: Andrzej Hajda Regards Andrzej drivers/video/fbdev/efifb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.

[Intel-gfx] [PATCH] drm/i915/fbdev: disable HPD before framebuffer unregistration

634592] remove_conflicting_pci_framebuffers+0xc8/0x110 [272.634595] drm_aperture_remove_conflicting_pci_framebuffers+0x52/0x70 [272.634604] i915_driver_probe+0x63a/0xdd0 [i915] Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/intel_fbdev.c | 43 +++--- 1 file changed, 22 insertions(

Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs

erent code organization. v2: s/gtn/gt/ (Andi) Cc: Andi Shyti Cc: Andrzej Hajda Fixes: b770bcfae9ad ("drm/i915/gt: create per-tile sysfs interface") Signed-off-by: Ashutosh Dixit ---   drivers/gpu/drm/i915/gt/intel_gt.c   |  1 +   drivers/gpu/drm/i915/gt/intel_

Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs

On 10.05.2022 10:18, Tvrtko Ursulin wrote: On 10/05/2022 08:58, Andrzej Hajda wrote: Hi Tvrtko, On 10.05.2022 09:28, Tvrtko Ursulin wrote: On 29/04/2022 20:56, Ashutosh Dixit wrote: All kmalloc'd kobjects need a kobject_put() to free memory. For example in previous

Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs

On 10.05.2022 11:48, Tvrtko Ursulin wrote: On 10/05/2022 10:39, Andrzej Hajda wrote: On 10.05.2022 10:18, Tvrtko Ursulin wrote: On 10/05/2022 08:58, Andrzej Hajda wrote: Hi Tvrtko, On 10.05.2022 09:28, Tvrtko Ursulin wrote: On 29/04/2022 20:56, Ashutosh Dixit wrote: All kmalloc&#

[Intel-gfx] [PATCH] drm/i915/display: disable HPD workers before display driver unregister

] Signed-off-by: Andrzej Hajda --- Hi all, This is my 3rd attempt to solve some old CI bug[1]. The first one caused issues in kms code [2], 2nd one revealed that not only fbdev does not like HPD on removal [3]. I hope this one will solve things definitely. Moreover this is quite rare bug, but due to

[Intel-gfx] [PATCH v2] drm/i915/display: disable HPD workers before display driver unregister

] Signed-off-by: Andrzej Hajda --- Hi all, This is my Nth attempt to solve some old CI bug[1]. v1: caused issues in kms code [2], v2: revealed that not only fbdev does not like HPD on removal [3], v3: lacks drm_kms_helper_poll_disable[4] Moreover this is quite rare bug, but due to specific configuration

[Intel-gfx] [PATCH v3] drm/i915/display: disable HPD workers before display driver unregister

] Signed-off-by: Andrzej Hajda --- Hi all, This is my Nth attempt to solve some old CI bug[1]. v1: caused issues in kms code [2], v2: revealed that not only fbdev does not like HPD on removal [3], v3: lacks drm_kms_helper_poll_disable[4] Moreover this is quite rare bug, but due to specific configuration

[Intel-gfx] [PATCH v5] drm/i915/display: disable HPD workers before display driver unregister

] Signed-off-by: Andrzej Hajda --- Hi all, This is my Nth attempt to solve some old CI bug[1]. v-2: caused issues in kms code [2], v-1: revealed that not only fbdev does not like HPD on removal [3], v3: lacks drm_kms_helper_poll_disable[4] v4: added dump_stack to detect late fb registration v5: added

[Intel-gfx] [PATCH v6] drm/i915/display: disable HPD workers before display driver unregister

] Signed-off-by: Andrzej Hajda --- Hi all, This is my Nth attempt to solve some old CI bug[1]. v-2: caused issues in kms code [2], v-1: revealed that not only fbdev does not like HPD on removal [3], v3: lacks drm_kms_helper_poll_disable[4] v4: added dump_stack to detect late fb registration v5: added

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: disable HPD workers before display driver unregister (rev7)

On 14.05.2022 19:03, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* drm/i915/display: disable HPD workers before display driver unregister (rev7) *URL:* https://patchwork.freedesktop.org/series/103811/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tre

Re: [Intel-gfx] [PATCH v6] drm/i915/display: disable HPD workers before display driver unregister

Seems the patch correctly fixes the the issue and passes CI so added maintainers/reviewers to CC. On 13.05.2022 18:06, Andrzej Hajda wrote: Handling HPD during driver removal is pointless, and can cause different use-after-free/concurrency issues: 1. Setup of deferred fbdev after fbdev

[Intel-gfx] [PATCH RESEND v6] drm/i915/display: disable HPD workers before display driver unregister

] Signed-off-by: Andrzej Hajda --- Hi all, This is resend of [1]. For unknown reason CC-ing ppl did not work, so I've decided to resend. I hope this time it will work. The patch was already succesfully tested by CI (rev6, rev7 of [1]). [1]: https://patchwork.freedesktop.org/series/103811/ Re

Re: [Intel-gfx] [PATCH] drm/i915/hwconfig: Report no hwconfig support on ADL-N

On 23.05.2022 09:51, Balasubramani Vivekanandan wrote: ADL-N being a subplatform of ADL-P, it lacks support for hwconfig table. Explicit check added to skip ADL-N. Signed-off-by: Balasubramani Vivekanandan Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/gt/uc

Re: [Intel-gfx] [PATCH] drm/i915: Update tiled blits selftest

if (gen < 12) + return true; Why gen variable? you can use expression directly. Anyway: Reviewed-by: Andrzej Hajda Regards Andrzej + + if (!HAS_LMEM(i915) || IS_DG1(i915)) + return false; + + return true; +} + +static bool fast_blit_ok(

Re: [Intel-gfx] [PATCH v1 01/13] drm/edid: add block count and data helper functions for drm_edid

oop checks, and better code IMO). 2. Implement kind of iterator, for example drm_edid_extension_block_next(drm_edid, edid_ext), then use loop: for (edid_ext = NULL; edid_ext = drm_edid_extension_block_next(drm_edid, edid_ext;) ... Up to you. Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH v6] drm/i915: Individualize fences before adding to dma_resv obj

ma_fence_array_for_each(curr, idx, fence) + ; This look little odd. Maybe we could add helper to dma core to get fences count, different story. Reviewed-by: Andrzej Hajda Regards Andrzej + err = dma_resv_reserve_fences(vma->obj->base.resv, idx); + if

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/tc: Don't default disconnected legacy Type-C ports to TBT mode (v2)

e Deak Cc: José Roberto de Souza Signed-off-by: Vivek Kasireddy Looks sane. Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/display/intel_tc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/

Re: [Intel-gfx] [PATCH] drm/i915: Improve user experience and driver robustness under SIGINT or similar

xiting(ce)) continue; else if (!persistent && intel_context_exit_nonpersistent(ce, NULL) continue; Anyway: Reviewed-by: Andrzej Hajda Regards Andrzej /* * Check the current active state of this context; if we @@ -1395,7 +1402,7 @@ stat

Re: [Intel-gfx] [PATCH] drm/edid: ignore the CEA modes not defined in CEA-861-D

On 31.05.2022 12:13, William Tseng wrote: This is a workaround for HDMI 1.4 sink which has a CEA mode with higher vic than what is defined in CEA-861-D. As an example, a HDMI 1.4 sink has the video format 2560x1080p to be displayed and the video format is indicated by both SVD (with vic 90 and p

Re: [Intel-gfx] [RESEND] drm/i915/display: stop using BUG()

On 31.05.2022 18:25, Jani Nikula wrote: Avoid bringing the entire machine down even if there's a bug that shouldn't happen, but won't corrupt the system either. Log them loudly and limp on. Signed-off-by: Jani Nikula All BUG() cases seems to be converted. Reviewed-by

[Intel-gfx] [PATCH v7] drm/i915/display: disable HPD workers before display driver unregister

] Signed-off-by: Andrzej Hajda --- Hi All, I am not sure about changes in shutdown path, any comments welcome. I suspect suspend path have also some common bits, but I am little bit afraid of touching it. Changes: v1 - v6: - chasing the bug appearing only on public CI. v7: - shutdown path

[Intel-gfx] [PATCH v3 0/3] drm/i915/display: stop HPD workers before display driver unregister

l/-/issues/5950 [1]: https://patchwork.freedesktop.org/series/103811/ Regards Andrzej Andrzej Hajda (3): drm/i915/hpd: postpone HPD cancel work after last user suspension drm/i915/fbdev: suspend HPD before fbdev unregistration drm/i915/display: add hotplug.suspended flag drivers/gp

[Intel-gfx] [PATCH v3 1/3] drm/i915/hpd: postpone HPD cancel work after last user suspension

ned-off-by: Andrzej Hajda Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ drivers/gpu/drm/i915/i915_irq.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/disp

[Intel-gfx] [PATCH v3 2/3] drm/i915/fbdev: suspend HPD before fbdev unregistration

] remove_conflicting_pci_framebuffers+0xc8/0x110 [272.634595] drm_aperture_remove_conflicting_pci_framebuffers+0x52/0x70 [272.634604] i915_driver_probe+0x63a/0xdd0 [i915] Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5329 Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5510 Signed-off-by: Andrzej

[Intel-gfx] [PATCH v3 3/3] drm/i915/display: add hotplug.suspended flag

. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5950 Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_hotplug.c | 13 - drivers/gpu/drm/i915/display/intel_hotplug.h | 2 +- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/fbdev: suspend HPD before fbdev unregistration

/intel/-/issues/5329 Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5510 Signed-off-by: Andrzej Hajda --- Reviewed-by: Arun R Murthy Thanks and Regards, Arun R Murthy Ups, I forgot to add your r-b. Anyway, thanks for both r-b. Regards Andrzej

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: stop HPD workers before display driver unregister (rev6)

On 14.07.2022 12:42, Patchwork wrote: *Patch Details* *Series:* drm/i915/display: stop HPD workers before display driver unregister (rev6) *URL:* https://patchwork.freedesktop.org/series/105557/ *State:*failure *Details:* https://inte

Re: [Intel-gfx] [PATCH RFC] drm/i915/gt: Retry RING_HEAD reset until it sticks

tcase: igt/i915_selftest/hangcheck Signed-off-by: Chris Wilson Cc: Andrzej Hajda Cc: Mika Kuoppala Signed-off-by: Mauro Carvalho Chehab That is pity hw does not provide reliable way of reset. Reviewed-by: Andrzej Hajda Regards Andrzej --- .../gpu/drm/i915/gt/intel_ring_submissio

Re: [Intel-gfx] [PATCH] drm/i915: Pass drm_i915_private struct instead of gt for gen11_gu_misc_irq_handler()

On 18.07.2022 20:34, Anusha Srivatsa wrote: gen11_gu_misc_irq_handler() does not do anything tile specific. Cc: Matt Roper Signed-off-by: Anusha Srivatsa Reviewed-by: Andrzej Hajda Regards Andrzej

[Intel-gfx] [PATCH v4 0/3] drm/i915/display: stop HPD workers before display driver unregister

l/-/issues/5950 v4: - check suspend flag also in i915_digport_work_func [1]: https://patchwork.freedesktop.org/series/103811/ Regards Andrzej Andrzej Hajda (3): drm/i915/hpd: postpone HPD cancel work after last user suspension drm/i915/fbdev: suspend HPD before fbdev unregistration drm/i9

[Intel-gfx] [PATCH v4 1/3] drm/i915/hpd: postpone HPD cancel work after last user suspension

ned-off-by: Andrzej Hajda Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ drivers/gpu/drm/i915/i915_irq.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/disp

[Intel-gfx] [PATCH v4 2/3] drm/i915/fbdev: suspend HPD before fbdev unregistration

] remove_conflicting_pci_framebuffers+0xc8/0x110 [272.634595] drm_aperture_remove_conflicting_pci_framebuffers+0x52/0x70 [272.634604] i915_driver_probe+0x63a/0xdd0 [i915] Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5329 Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5510 Signed-off-by: Andrzej

[Intel-gfx] [PATCH v4 3/3] drm/i915/display: add hotplug.suspended flag

. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5950 Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_hotplug.c | 11 ++- drivers/gpu/drm/i915/display/intel_hotplug.h | 2 +- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Suppress oom warning for shmemfs object allocation failure

|= __GFP_RETRY_MAYFAIL | __GFP_NOWARN; Reviewed-by: Andrzej Hajda Regards Andrzej } } while (1);

[Intel-gfx] [PATCH v5 0/4] drm/i915/display: stop HPD workers before display driver unregister

l/-/issues/5950 v4: - check suspend flag also in i915_digport_work_func v5: - added patch blocking FB creation in case HPD is supended, - added R-B from Arun to patch 3, thx [1]: https://patchwork.freedesktop.org/series/103811/ Regards Andrzej Andrzej Hajda (4): drm/i915/hpd: postpone

[Intel-gfx] [PATCH v5 3/4] drm/i915/display: add hotplug.suspended flag

. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5950 Signed-off-by: Andrzej Hajda Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_hotplug.c | 11 ++- drivers/gpu/drm/i915/display/intel_hotplug.h | 2

[Intel-gfx] [PATCH v5 4/4] drm/i915/fbdev: do not create fbdev if HPD is suspended

In case of deferred FB setup core can try to create new framebuffer. Disallow it if hpd_suspended flag is set. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/intel_fbdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b

[Intel-gfx] [PATCH v5 1/4] drm/i915/hpd: postpone HPD cancel work after last user suspension

ned-off-by: Andrzej Hajda Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ drivers/gpu/drm/i915/i915_irq.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/disp

[Intel-gfx] [PATCH v5 2/4] drm/i915/fbdev: suspend HPD before fbdev unregistration

] remove_conflicting_pci_framebuffers+0xc8/0x110 [272.634595] drm_aperture_remove_conflicting_pci_framebuffers+0x52/0x70 [272.634604] i915_driver_probe+0x63a/0xdd0 [i915] Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5329 Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5510 Signed-off-by: Andrzej

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo

o err; - /* Force the wait wait now to avoid including it in the benchmark */ + /* Force the wait now to avoid including it in the benchmark */ err = i915_vma_sync(vma); if (err) goto err_pin; Reviewed-by: Andrzej Hajda Regards Andrzej

[Intel-gfx] [PATCH v6 0/4] drm/i915/display: stop HPD workers before display driver unregister

et_suspend was not called in case of deferred setup, fixed in patch 2. [1]: https://patchwork.freedesktop.org/series/103811/ Regards Andrzej Andrzej Hajda (4): drm/i915/hpd: postpone HPD cancel work after last user suspension drm/i915/fbdev: suspend HPD before fbdev unregistration drm/i9

[Intel-gfx] [PATCH v6 3/4] drm/i915/display: add hotplug.suspended flag

. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5950 Signed-off-by: Andrzej Hajda Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_hotplug.c | 11 ++- drivers/gpu/drm/i915/display/intel_hotplug.h | 2

[Intel-gfx] [PATCH v6 1/4] drm/i915/hpd: postpone HPD cancel work after last user suspension

ned-off-by: Andrzej Hajda Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ drivers/gpu/drm/i915/i915_irq.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/disp

[Intel-gfx] [PATCH v6 2/4] drm/i915/fbdev: suspend HPD before fbdev unregistration

] remove_conflicting_pci_framebuffers+0xc8/0x110 [272.634595] drm_aperture_remove_conflicting_pci_framebuffers+0x52/0x70 [272.634604] i915_driver_probe+0x63a/0xdd0 [i915] Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5329 Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5510 Signed-off-by: Andrzej

[Intel-gfx] [PATCH v6 4/4] drm/i915/fbdev: do not create fbdev if HPD is suspended

In case of deferred FB setup core can try to create new framebuffer. Disallow it if hpd_suspended flag is set. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/intel_fbdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b

Re: [Intel-gfx] [PATCH v5 1/7] drm: Move and add a few utility macros into drm util header

On 25.07.2022 11:25, Gwan-gyeong Mun wrote: It moves overflows_type utility macro into drm util header from i915_utils header. The overflows_type can be used to catch the truncation between data types. And it adds safe_conversion() macro which performs a type conversion (cast) of an source value

Re: [Intel-gfx] [PATCH v5 2/7] drm/i915/gem: Typecheck page lookups

ff-by: Chris Wilson Signed-off-by: Gwan-gyeong Mun Cc: Tvrtko Ursulin Cc: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH v5 3/7] drm/i915: Check for integer truncation on scatterlist creation

Hellström Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH v5 4/7] drm/i915: Check for integer truncation on the configuration of ttm place

: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH v5 5/7] drm/i915: Check if the size is too big while creating shmem file

ted-by: kernel test robot Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH v5 6/7] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

converts return value to -E2BIG. Signed-off-by: Gwan-gyeong Mun Cc: Chris Wilson Cc: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 11 +++ 1

Re: [Intel-gfx] [PATCH v5 7/7] drm/i915: Remove truncation warning for large objects

://gitlab.freedesktop.org/drm/intel/-/issues/4991 Reviewed-by: Nirmoy Das Reviewed-by: Mauro Carvalho Chehab Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Use of BARs names instead of numbers

+ b/drivers/gpu/drm/i915/intel_pci_config.h @@ -6,6 +6,13 @@ #ifndef __INTEL_PCI_CONFIG_H__ #define __INTEL_PCI_CONFIG_H__ +/* PCI BARs */ +#define GTTMMADR_BAR 0 +#define GEN2_GTTMMADR_BAR 1 +#define GFXMEM_BAR 2 +#define GTT_APERTURE_BAR GFXMEM_BAR +#define GEN12_LMEM_BAR GFXMEM_BAR In INTEL_GVT_PCI_BAR_GTTMMIO we have BAR in prefix, here in suffix. I am not sure which onel is better, just pointing out slight incosistency. Anyway: Reviewed-by: Andrzej Hajda Regards Andrzej + /* BSM in include/drm/i915_drm.h */ #define MCHBAR_I9150x44

Re: [Intel-gfx] [PATCH v6 0/4] drm/i915/display: stop HPD workers before display driver unregister

Regards Andrzej On 02.08.2022 14:24, Gwan-gyeong Mun wrote: Hi Jani, Ville and Imre, If there are no problems after reviewing this patch series, could you please merge it? Many thanks, G.G. On 7/22/22 3:51 PM, Andrzej Hajda wrote: Hi Jani, Ville, Arun, This patchset is replacement of patch

Re: [Intel-gfx] [PATCH] Fixes KW issues for NULL pointer dereference

On 11.08.2022 13:28, Tapas Rana wrote: I guess even for trivial patches rules should be followed - subject should describe what has changed, commit message should describe why. --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/driver

Re: [Intel-gfx] [PATCH v3] drm/i915/pxp: don't start pxp without mei_pxp bind

unbind. Anyway: Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/gpu/drm/i915/pxp/intel_pxp.c index 15311eaed848..17109c513259 100644

Re: [Intel-gfx] [PATCH v7 1/8] overflow: Move and add few utility macros into overflow

On 18.08.2022 02:12, Kees Cook wrote: On Thu, Aug 18, 2022 at 01:07:29AM +0200, Andi Shyti wrote: Hi Kees, would you mind taking a look at this patch? Hi! Thanks for the heads-up! Thanks, Andi On Tue, Aug 16, 2022 at 06:35:18PM +0900, Gwan-gyeong Mun wrote: It moves overflows_type utilit

  1   2   3   4   5   6   7   8   9   >