Just a trivial review of an the vm bind document that is still
an rfc document.
Signed-off-by: Andi Shyti
---
Hi,
I'm not a big fan of this kind of patches, but while reading and
reviewing this document I spotted few potential grammatical fixes.
Andi
Documentation/gpu/rfc/i915_vm_bin
Hi Andrzej,
On Fri, Jun 24, 2022 at 01:35:28PM +0200, Andrzej Hajda wrote:
> On some machines hole_end can be small enough to cause subtraction
> overflow. On the other side (addr + 2 * min_alignment) can overflow
> in case of mock tests. This patch should handle both cases.
>
> Fixes: e1c5f75406
t we don't know if we saw the interrupt and so need
> to check signaling.
>
> References: 047a1b877ed4 ("dma-buf & drm/amdgpu: remove dma_resv workaround")
> Signed-off-by: Chris Wilson
> Signed-off-by: Karolina Drobnik
sorry, I missed this patch.
Reviewed-by: Andi Shyti
Thanks,
Andi
On Wed, Dec 08, 2021 at 08:27:58PM +0530, Ramalingam C wrote:
> From: Chris Wilson
>
> Remove the portion of stolen memory reserved for private use from driver
> access.
>
> Signed-off-by: Chris Wilson
> cc: Matthew Auld
> Signed-off-by: Ramalingam C
> Reviewed-by: Matthew Auld
> ---
> driv
; Reviewed-by: Matthew Auld
Reviewed-by: Andi Shyti
Thanks,
Andi
0;
> +
> + if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM))
> + err = iomemtest(mem, caller);
I don't understand the debugging part of the iomemtest, if memory
is failing we wouldn't relise if DEBUG_GEM is not enabled.
In any case,
Reviewed-by: Andi Shyti
Andi
> - if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM))
> - err = iomemtest(mem, caller);
> + if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM) || i915->params.memtest)
> + err = iomemtest(mem, i915->params.memtest, caller);
... but still I am missing the debugging
Hi Ram,
Reviewed-by: Andi Shyti
but just two notes on the patchstyle, no need to resend:
1. would be nice to have [PATCH v2...] otherwise it's difficult
to see if I'm reading the correct version. (I don't see the
difficulty 'git format-patch -v 2...')
ff-by: Stuart Summers
> Signed-off-by: Ramalingam C
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Reviewed-by: Lucas De Marchi
> Reviewed-by: Thomas Hellstrom
Reviewed-by: Andi Shyti
Thanks,
Andi
such platforms and call it a day, since that
> should work for all configurations.
>
> Signed-off-by: Matthew Auld
> Signed-off-by: Ramalingam C
> Reviewed-by: Thomas Hellstrom
Reviewed-by: Andi Shyti
Andi
; Signed-off-by: Matthew Auld
> Signed-off-by: Ramalingam C
> Reviewed-by: Thomas Hellström
Reviewed-by: Andi Shyti
Andi
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 22
drivers/gpu/
From: Michał Winiarski
We now support a per-gt uncore, yet we're not able to infer which GT
we're operating upon. Let's store a backpointer for now.
Signed-off-by: Michał Winiarski
Signed-off-by: Matt Roper
Reviewed-by: Andi Shyti
Signed-off-by: Andi Shyti
---
drivers/
In preparation of the multitile support, highlight the root GT by
calling it gt0 inside the drm i915 private data.
Signed-off-by: Andi Shyti
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Lucas De Marchi
Cc: Rodrigo Vivi
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h | 4 ++--
1 file
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Andi Shyti
Cc: Michał Winiarski
---
drivers/gpu/drm/i915/selftests/i915_active.c | 2 +-
drivers/gpu/drm/i915/selftests/i915_gem.c | 2 +-
.../gpu/
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/i915_debugfs.c| 38 +++
drivers/gpu/drm/i
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/
From: Michał Winiarski
To allow further refactoring and abstract away the fact that GT is
stored inside i915 private.
No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 7 +--
drivers/gpu/drm/i915
igned-off-by: Andi Shyti
---
drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
.../gpu/drm/i915/display/intel_plane_initial.c | 2 +-
drivers/gpu/drm/i915/gem/i915_gem_context.h | 2 +-
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +-
drivers/gpu/drm/i915/gem/i915_gem_mman.c
uch freedom and changed more than it was
supposed to.
- fix a compile error which did not appear in my local build
v1 -> v2:
- patch 2: do not use anymore the reference i915->gt but use
to_root_gt(), coming from Matt Roper's patch.
- fix some comments from Chris.
Andi Shyti (3):
dr
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
---
.../gpu/drm/i915/display/intel_atomic_plane.c | 4 ++--
drivers/gpu/drm/i915/disp
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gt/intel_engine_user.c | 2 +-
drivers/gpu/drm/i915
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gvt/gvt.c | 2 +-
drivers/gpu/drm/i915/gvt/scheduler.c
Hi Jani,
thanks for looking at it.
> > - intel_gt_init_early(&dev_priv->gt, dev_priv);
> > + __intel_gt_init_early(&dev_priv->gt, dev_priv);
>
> Why double underscores here? It looks like it's supposed to be internal
> to intel_gt, not to be called by anyone else.
I forgot to write two line
Hi Matt,
> > -static inline struct intel_pxp *i915_dev_to_pxp(struct device *i915_kdev)
> > +static struct intel_pxp *i915_dev_to_pxp(struct device *i915_kdev)
>
> Was dropping the inline here intentional? It doesn't seem like there's
> any reason to drop it, and if it was intentional the white
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Andi Shyti
---
Hi,
the inline of i915_dev_to_pxp() was accidentally removed in v6.
Thanks Matt.
Andi
drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 4 +++-
Hi Matt,
> > GGTT is currently available both through i915->ggtt and gt->ggtt, and we
> > eventually want to get rid of the i915->ggtt one.
> > Use to_gt() for all i915->ggtt accesses to help with the future
> > refactoring.
>
> I think we can also convert the two references in i915_drm_suspend()
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/driv
t_gt(), coming from Matt Roper's patch.
- fix some comments from Chris.
Andi Shyti (4):
drm/i915/selftests: Use to_gt() helper
drm/i915/pxp: Use to_gt() helper
drm/i915: Rename i915->gt to i915->gt0
drm/i915: Move the GGTT from i915 private data to the GT
Michał Winiarski (8
he i915 private data pointer and the uncore. A temporary
function has been made and the two parts are
__intel_gt_init_early() and intel_gt_init_early(). This split
will be fixed in the future with the multitile patch.
Signed-off-by: Michał Winiarski
Signed-off-by: Matt Roper
Reviewed-by: Andi Shyti
From: Michał Winiarski
To allow further refactoring and abstract away the fact that GT is
stored inside i915 private.
No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 7
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
.../gpu/drm/i915/display/intel_atomic_plane.c |
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_engine_user.c |
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gem/i915_gem_context.c |
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gvt/gvt.c | 2 +-
drivers/gpu/
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Andi Shyti
Cc: Michał Winiarski
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/selftests/i915_active.c | 2 +-
drivers/gpu/drm/i915/selftests/i915_ge
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/i915_debugfs.c|
In preparation of the multitile support, highlight the root GT by
calling it gt0 inside the drm i915 private data.
Signed-off-by: Andi Shyti
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Lucas De Marchi
Cc: Rodrigo Vivi
Cc: Tvrtko Ursulin
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915
igned-off-by: Andi Shyti
---
drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
drivers/gpu/drm/i915/display/intel_fbdev.c| 2 +-
.../drm/i915/display/intel_plane_initial.c| 2 +-
drivers/gpu/drm/i915/gem/i915_gem_context.h | 2 +-
.../gpu/drm/i915/gem/i915_gem_execbuffer.c| 2
GGTT was available both through i915->ggtt and gt->ggtt, and we
eventually want to get rid of the i915->ggtt one.
Move the GGTT from i915 to gt and use to_gt() for accesssing the
ggtt.
Signed-off-by: Andi Shyti
Cc: Michal Wajdeczko
Cc: Matt Roper
---
drivers/gpu/drm/i915/display/in
Sorry... messed up with git-send-email and the series is not
threaded. I'm going to resend it.
Andi
On Sun, Dec 12, 2021 at 05:10:55PM +0200, Andi Shyti wrote:
> Hi,
>
> the first patch concludes the first stage of refactoring which
> makes the use of intel_gt on the differen
t_gt(), coming from Matt Roper's patch.
- fix some comments from Chris.
Andi Shyti (4):
drm/i915/selftests: Use to_gt() helper
drm/i915/pxp: Use to_gt() helper
drm/i915: Rename i915->gt to i915->gt0
drm/i915: Move the GGTT from i915 private data to the GT
Michał Winiarski (8
he i915 private data pointer and the uncore. A temporary
function has been made and the two parts are
__intel_gt_init_early() and intel_gt_init_early(). This split
will be fixed in the future with the multitile patch.
Signed-off-by: Michał Winiarski
Signed-off-by: Matt Roper
Reviewed-by: Andi Shyti
From: Michał Winiarski
To allow further refactoring and abstract away the fact that GT is
stored inside i915 private.
No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 7
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
.../gpu/drm/i915/display/intel_atomic_plane.c |
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_engine_user.c |
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gem/i915_gem_context.c |
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gvt/gvt.c | 2 +-
drivers/gpu/
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Andi Shyti
Cc: Michał Winiarski
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/selftests/i915_active.c | 2 +-
drivers/gpu/drm/i915/selftests/i915_ge
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/driv
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/i915_debugfs.c|
In preparation of the multitile support, highlight the root GT by
calling it gt0 inside the drm i915 private data.
Signed-off-by: Andi Shyti
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Lucas De Marchi
Cc: Rodrigo Vivi
Cc: Tvrtko Ursulin
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915
igned-off-by: Andi Shyti
---
drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
drivers/gpu/drm/i915/display/intel_fbdev.c| 2 +-
.../drm/i915/display/intel_plane_initial.c| 2 +-
drivers/gpu/drm/i915/gem/i915_gem_context.h | 2 +-
.../gpu/drm/i915/gem/i915_gem_execbuffer.c| 2
GGTT was available both through i915->ggtt and gt->ggtt, and we
eventually want to get rid of the i915->ggtt one.
Move the GGTT from i915 to gt and use to_gt() for accesssing the
ggtt.
Signed-off-by: Andi Shyti
Cc: Michal Wajdeczko
Cc: Matt Roper
---
drivers/gpu/drm/i915/display/in
Hi Matt,
> > diff --git a/drivers/gpu/drm/i915/i915_driver.c
> > b/drivers/gpu/drm/i915/i915_driver.c
> > index 95174938b160..2619bb17b6eb 100644
> > --- a/drivers/gpu/drm/i915/i915_driver.c
> > +++ b/drivers/gpu/drm/i915/i915_driver.c
> > @@ -571,6 +571,8 @@ static int i915_driver_hw_probe(struc
Hi Matt,
On Mon, Dec 13, 2021 at 10:16:47AM -0800, Matt Roper wrote:
> On Sun, Dec 12, 2021 at 05:21:17PM +0200, Andi Shyti wrote:
> > GGTT was available both through i915->ggtt and gt->ggtt, and we
> > eventually want to get rid of the i915->ggtt one.
> > Move th
ocal build
v1 -> v2:
- patch 2: do not use anymore the reference i915->gt but use
to_root_gt(), coming from Matt Roper's patch.
- fix some comments from Chris.
Andi Shyti (4):
drm/i915/selftests: Use to_gt() helper
drm/i915/pxp: Use to_gt() helper
drm/i915: Rename i915->gt
he i915 private data pointer and the uncore. A temporary
function has been made and the two parts are
__intel_gt_init_early() and intel_gt_init_early(). This split
will be fixed in the future with the multitile patch.
Signed-off-by: Michał Winiarski
Signed-off-by: Matt Roper
Reviewed-by: Andi Shyti
From: Michał Winiarski
To allow further refactoring and abstract away the fact that GT is
stored inside i915 private.
No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 7
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
.../gpu/drm/i915/display/intel_atomic_plane.c |
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_engine_user.c |
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gem/i915_gem_context.c |
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gvt/gvt.c | 2 +-
drivers/gpu/
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Andi Shyti
Cc: Michał Winiarski
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/selftests/i915_active.c | 2 +-
drivers/gpu/drm/i915/selftests/i915_ge
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/driv
From: Michał Winiarski
Use to_gt() helper consistently throughout the codebase.
Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
Signed-off-by: Michał Winiarski
Signed-off-by: Andi Shyti
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/i915_debugfs.c|
In preparation of the multitile support, highlight the root GT by
calling it gt0 inside the drm i915 private data.
Signed-off-by: Andi Shyti
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Lucas De Marchi
Cc: Rodrigo Vivi
Cc: Tvrtko Ursulin
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915
igned-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gem/i915_gem_context.h | 2 +-
.../gpu/drm/i915/gem/i915_gem_execbuffer.c| 2 +-
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 19 ++-
drivers/gpu/drm/i915/gem/i915_gem_pm.c| 2 +-
drivers/gpu/drm/i915/gem/i915_ge
igned-off-by: Andi Shyti
---
drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +-
drivers/gpu/drm/i915/display/intel_plane_initial.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/in
igned-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gt/intel_ggtt.c | 14 +++---
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 6 +++---
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 4 ++--
drivers/gpu/drm/i915/gt/selftest_reset.c | 2 +-
4 files changed, 13 insertions(+),
igned-off-by: Andi Shyti
---
drivers/gpu/drm/i915/selftests/i915_gem.c| 8
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c| 6 +++---
drivers/gpu/drm/i915/selftests/i915_request.c| 2 +-
drivers/gpu/drm/i915/selftests/i915_vma.c| 2 +-
drivers/gpu/drm/i9
igned-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gvt/dmabuf.c| 2 +-
drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
drivers/gpu/drm/i915/i915_driver.c | 8
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_gem.c | 23 ---
drivers/
The reference to the GGTT from the private date is not used
anymore. Remove it.
Suggested-by: Matt Roper
Signed-off-by: Andi Shyti
Cc: Michał Winiarski
---
drivers/gpu/drm/i915/gt/intel_gt.c| 7 +--
drivers/gpu/drm/i915/gt/intel_gt.h| 2 +-
drivers/gpu/drm/i915
Hi Matt,
> > diff --git a/drivers/gpu/drm/i915/i915_driver.c
> > b/drivers/gpu/drm/i915/i915_driver.c
> > index 95174938b160..3c984553d86f 100644
> > --- a/drivers/gpu/drm/i915/i915_driver.c
> > +++ b/drivers/gpu/drm/i915/i915_driver.c
> > @@ -571,6 +571,8 @@ static int i915_driver_hw_probe(struc
Hi Matt,
> The first 10 patches have gone through several clean CI cycles now, so
> I've pushed those to drm-intel-gt-next. There are just a couple minor
> comments on the ggtt patches, so we can push the rest of those once the
> comments are addressed.
>
> BTW, there's one i915->gt reference in
v2 -> v3:
- sed -i ... took too much freedom and changed more than it was
supposed to.
- fix a compile error which did not appear in my local build
v1 -> v2:
- patch 2: do not use anymore the reference i915->gt but use
to_root_gt(), coming from Matt Roper's patch.
- fix some comm
igned-off-by: Andi Shyti
Reviewed-by: Sujaritha Sundaresan
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_ggtt.c | 14 +++---
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 6 +++---
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 4 ++--
drivers/gpu/drm/i915/gt/self
igned-off-by: Andi Shyti
Reviewed-by: Sujaritha Sundaresan
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gem/i915_gem_context.h | 2 +-
.../gpu/drm/i915/gem/i915_gem_execbuffer.c| 2 +-
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 19 ++-
drivers/gpu/drm/i915/gem/i
igned-off-by: Andi Shyti
Reviewed-by: Sujaritha Sundaresan
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +-
drivers/gpu/drm/i915/display/intel_plane_initial.c | 2 +-
3 files changed, 3 insertions(+),
igned-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gvt/dmabuf.c| 2 +-
drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
drivers/gpu/drm/i915/i915_driver.c | 4 ++--
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_gem.c | 23 ---
drivers/
igned-off-by: Andi Shyti
Reviewed-by: Sujaritha Sundaresan
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/selftests/i915_gem.c| 8
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c| 6 +++---
drivers/gpu/drm/i915/selftests/i915_request.c| 2 +-
drivers/gpu/drm/i915/selftest
The reference to the GGTT from the private date is not used
anymore. Remove it.
The ggtt in the root gt will now be dynamically allocated and the
deallocation handled by the drmm_* managed allocation.
Suggested-by: Matt Roper
Signed-off-by: Andi Shyti
Cc: Michał Winiarski
Reviewed-by
Hi Matt,
> > diff --git a/drivers/gpu/drm/i915/i915_perf.c
> > b/drivers/gpu/drm/i915/i915_perf.c
> > index 170bba913c30..128315aec517 100644
> > --- a/drivers/gpu/drm/i915/i915_perf.c
> > +++ b/drivers/gpu/drm/i915/i915_perf.c
> > @@ -1630,7 +1630,7 @@ static int alloc_noa_wait(struct i915_perf_
on of the gt
(intel_gt_init_hw_early()) is moved prior to any access to the
ggtt. This because it's in that moment we assign the ggtt to the
gt and we want to do that before using it.
Signed-off-by: Michał Winiarski
Cc: Michal Wajdeczko
Signed-off-by: Andi Shyti
Reviewed-by: Sujaritha Sundaresan
Review
Hi guys,
> > > > > struct drm_i915_gem_object *bo;
> > > > > struct i915_vma *vma;
> > > > > const u64 delay_ticks = 0x -
> > > > > -
> > > > > intel_gt_ns_to_clock_interval(stream->perf->i915->ggtt.vm.gt,
> > > > > +
> > > > > intel_gt_n
igned-off-by: Andi Shyti
---
Hi Matt,
I'm sending this this v10 as reply-to, if it confuses you I can
send the whole v10.
The only trivial difference is that in i915_perf.c I'm using
to_gt(perf->i915)
instead of
to_gt(perf->i915)->ggtt->vm.gt
Andi
drivers/gpu/drm/i91
.
Andi Shyti (1):
drm/i915/gt: make a gt sysfs group and move power management files
Tvrtko Ursulin (1):
drm/i915: Prepare for multiple GTs
drivers/gpu/drm/i915/Makefile | 4 +-
drivers/gpu/drm/i915/gt/intel_gt.c| 141 ++-
drivers/gpu/drm/i915/gt/intel_gt.h
ure is in place to handle them.
Signed-off-by: Abdiel Janulgue
Signed-off-by: Daniele Ceraolo Spurio
Signed-off-by: Tvrtko Ursulin
Signed-off-by: Matt Roper
Signed-off-by: Andi Shyti
Cc: Daniele Ceraolo Spurio
Cc: Joonas Lahtinen
Cc: Matthew Auld
---
drivers/gpu/drm/i915/gt/inte
freq_mhz|it points to gt0/
├── gt_RP0_freq_mhz|
└── gt_RP1_freq_mhz|
└── gt_RPn_freq_mhz -+
Signed-off-by: Andi Shyti
Signed-off-by: Lucas De Marchi
Cc: Matt Roper
Cc: Sujaritha Sundaresan
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Makefile | 4 +-
d
Hi Dale,
thanks for looking into this patch,
> > + /*
> > +* i915->gt[0] == &i915->gt0
> > +*/
> > +#define I915_MAX_GT 4
> > + struct intel_gt *gt[I915_MAX_GT];
> > +
>
>
> It would be nice if I915_MAX_GT was defined in a more basic header file so
> that the definition of I915_MAX_
Hi Sujaritha,
[...]
> > +static ssize_t act_freq_mhz_show(struct device *dev,
> > +struct device_attribute *attr, char *buff)
> Alignment with the initial (
OK
[...]
> > +static INTEL_GT_RPS_SYSFS_ATTR(RP1_freq_mhz, 0444, rps_rp_mhz_show, NULL);
> > +static INT
ure is in place to handle them.
Signed-off-by: Abdiel Janulgue
Signed-off-by: Daniele Ceraolo Spurio
Signed-off-by: Tvrtko Ursulin
Signed-off-by: Matt Roper
Signed-off-by: Andi Shyti
Cc: Daniele Ceraolo Spurio
Cc: Joonas Lahtinen
Cc: Matthew Auld
---
drivers/gpu/drm/i915/gt/inte
.
Thanks,
Andi
Patchwork: https://patchwork.freedesktop.org/series/98741/
Changelog
=
v1 -> v2
- fixed a couple of coding style issues in patch 2.
Andi Shyti (1):
drm/i915/gt: make a gt sysfs group and move power management files
Tvrtko Ursulin (1):
drm/i915: Prepare for multiple
freq_mhz|it points to gt0/
├── gt_RP0_freq_mhz|
└── gt_RP1_freq_mhz|
└── gt_RPn_freq_mhz -+
Signed-off-by: Andi Shyti
Signed-off-by: Lucas De Marchi
Cc: Matt Roper
Cc: Sujaritha Sundaresan
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Makefile | 4 +-
d
Hi Matt,
[...]
> > -int intel_uncore_setup_mmio(struct intel_uncore *uncore)
> > +int intel_uncore_setup_mmio(struct intel_uncore *uncore, phys_addr_t
> > phys_addr)
> > {
> > struct drm_i915_private *i915 = uncore->i915;
> > - struct pci_dev *pdev = to_pci_dev(i915->drm.dev);
> > - int
gt_boost_freq_mhz |
> > ├── gt_cur_freq_mhz|Original interface
> > ├── gt_max_freq_mhz+─-> kept as existing ABI;
> > ├── gt_min_freq_mhz|it points to gt0/
> > ├── gt_RP0_freq_mhz|
> > └── gt_RP1_freq_mhz
a couple of coding style issues in patch 2.
Andi Shyti (1):
drm/i915/gt: make a gt sysfs group and move power management files
Tvrtko Ursulin (1):
drm/i915: Prepare for multiple GTs
drivers/gpu/drm/i915/Makefile | 4 +-
drivers/gpu/drm/i915/gt/intel_gt.c| 141 +
ure is in place to handle them.
Signed-off-by: Abdiel Janulgue
Signed-off-by: Daniele Ceraolo Spurio
Signed-off-by: Tvrtko Ursulin
Signed-off-by: Matt Roper
Signed-off-by: Andi Shyti
Cc: Daniele Ceraolo Spurio
Cc: Joonas Lahtinen
Cc: Matthew Auld
Reviewed-by: Matt Roper
---
drivers/gpu/dr
nly tile 0 and
getting incomplete results.
Signed-off-by: Andi Shyti
Signed-off-by: Lucas De Marchi
Cc: Matt Roper
Cc: Sujaritha Sundaresan
Cc: Tvrtko Ursulin
Reviewed-by: Sujaritha Sundaresan
---
drivers/gpu/drm/i915/Makefile | 4 +-
drivers/gpu/drm/i915/gt/intel_gt.c| 2 +
d
Hi Tvrtko,
> > The previous power management files are kept in their original
> > root directory to avoid breaking the ABI. They point to the tile
> > '0' and a warning message is printed whenever accessed to. The
> > deprecated interface needs for the CONFIG_SYSFS_DEPRECATED_V2
> > flag in order
101 - 200 of 2148 matches
Mail list logo
