Re: [Intel-gfx] [PATCH v2] drm: Check actual format for legacy pageflip.

2021-01-11 Thread Alex Deucher
her drivers and it doesn't look like they end up triggering > this case so I think this is safe to relax. > > Signed-off-by: Bas Nieuwenhuizen > Reviewed-by: Daniel Vetter > Reviewed-by: Zhan Liu > Acked-by: Christian König > Acked-by: Alex Deucher > Fixes: 816853f9

Re: [Intel-gfx] [PATCH v2] drm: Check actual format for legacy pageflip.

2021-01-11 Thread Alex Deucher
On Mon, Jan 11, 2021 at 11:39 AM Bas Nieuwenhuizen wrote: > > On Mon, Jan 11, 2021 at 4:02 PM Alex Deucher wrote: > > > > On Sat, Jan 9, 2021 at 9:11 PM Bas Nieuwenhuizen > > wrote: > > > > > > With modifiers one can actually have different format_inf

Re: [Intel-gfx] [PATCH 3/4] drm/amd/display: Add DP 2.0 MST DC Support

2021-10-20 Thread Alex Deucher
On Wed, Oct 20, 2021 at 3:50 PM Bhawanpreet Lakha wrote: > > From: Fangzhi Zuo Please include a patch description. Alex > > Signed-off-by: Fangzhi Zuo > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 14 + > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 280 ++ > ..

Re: [Intel-gfx] [PATCH 00/14] drm/hdcp: Pull HDCP auth/exchange/check into

2021-09-13 Thread Alex Deucher
On Mon, Sep 13, 2021 at 1:57 PM Sean Paul wrote: > > From: Sean Paul > > Hello, > This patchset pulls the HDCP protocol auth/exchange/check logic out from > i915 into a HDCP helper library which drivers can use to implement the > proper protocol and UAPI interactions for achieving HDCP. > > Origi

Re: [Intel-gfx] [PATCH 1/2] Enable buddy memory manager support

2021-09-20 Thread Alex Deucher
On Mon, Sep 20, 2021 at 3:21 PM Arunpravin wrote: Please prefix the patch subject with drm. E.g., drm: Enable buddy memory manager support Same for the second patch, but make it drm/amdgpu instead. Alex > > Port Intel buddy system manager to drm root folder > Add CPU mappable/non-mappable reg

Re: [Intel-gfx] [PATCH 2/2] Add drm buddy manager support to amdgpu driver

2021-09-20 Thread Alex Deucher
On Mon, Sep 20, 2021 at 3:21 PM Arunpravin wrote: > > Replace drm_mm with drm buddy manager for > VRAM memory management Would be good to document why we are doing this and what advantages it brings over the old drm_mm code. Alex > > Signed-off-by: Arunpravin > --- > .../gpu/drm/amd/amdgpu/a

Re: [Intel-gfx] [PATCH v3 03/13] drm/dp: add LTTPR DP 2.0 DPCD addresses

2021-09-22 Thread Alex Deucher
+ Harry, Leo Can you guys get someone to clean this up? Alex On Wed, Sep 22, 2021 at 7:10 AM Jani Nikula wrote: > > On Tue, 21 Sep 2021, Nathan Chancellor wrote: > > On Thu, Sep 09, 2021 at 03:51:55PM +0300, Jani Nikula wrote: > >> DP 2.0 brings some new DPCD addresses for PHY repeaters. > >>

Re: [Intel-gfx] [RFC 0/8] Per client GPU stats

2021-07-23 Thread Alex Deucher
On Fri, Jul 23, 2021 at 9:51 AM Tvrtko Ursulin wrote: > > > On 23/07/2021 12:23, Christian König wrote: > > Am 23.07.21 um 13:21 schrieb Tvrtko Ursulin: > >> > >> On 15/07/2021 10:18, Tvrtko Ursulin wrote: > >>> From: Tvrtko Ursulin > >>> > >>> Same old work but now rebased and series ending with

Re: [Intel-gfx] [RFC 8/8] drm/amdgpu: Convert to common fdinfo format

2021-07-23 Thread Alex Deucher
+ David, Roy On Thu, Jul 15, 2021 at 5:18 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Convert fdinfo format to one documented in drm-usage-stats.rst. > > Opens: > * Does it work for AMD? > * What are the semantics of AMD engine utilisation reported in percents? >Can it align with

Re: [Intel-gfx] [PATCH v2] fbdev/efifb: Release PCI device's runtime PM ref during FB destroy

2021-08-10 Thread Alex Deucher
On Tue, Aug 10, 2021 at 4:36 AM Imre Deak wrote: > > Hi Kai-Heng, Alex, > > could you add your ack if the fix looks ok and you're ok if I push it to > the i915 tree? > Acked-by: Alex Deucher > Thanks, > Imre > > On Mon, Aug 09, 2021 at 04:31:46PM +0300,

Re: [Intel-gfx] New uAPI for color management proposal and feedback request

2021-05-12 Thread Alex Deucher
On Wed, May 12, 2021 at 9:04 AM Ville Syrjälä wrote: > > On Wed, May 12, 2021 at 02:06:56PM +0200, Werner Sembach wrote: > > Hello, > > > > In addition to the existing "max bpc", and "Broadcast RGB/output_csc" drm > > properties I propose 4 new properties: > > "preferred pixel encoding", "active

Re: [Intel-gfx] [PATCH 0/7] Per client engine busyness

2021-05-13 Thread Alex Deucher
On Thu, May 13, 2021 at 7:00 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Resurrect of the previosuly merged per client engine busyness patches. In a > nutshell it enables intel_gpu_top to be more top(1) like useful and show not > only physical GPU engine usage but per process view as we

Re: [Intel-gfx] [PATCH 0/7] Per client engine busyness

2021-05-13 Thread Alex Deucher
+ David, Christian On Thu, May 13, 2021 at 12:41 PM Tvrtko Ursulin wrote: > > > Hi, > > On 13/05/2021 16:48, Alex Deucher wrote: > > On Thu, May 13, 2021 at 7:00 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >>

Re: [Intel-gfx] [PATCH 1/3] gpu: drm: replace occurrences of invalid character

2021-05-19 Thread Alex Deucher
Pushed out to drm-misc-next. Also fixed up Michel's name. Alex On Wed, May 19, 2021 at 11:56 AM Randy Dunlap wrote: > > On 5/19/21 1:15 AM, Mauro Carvalho Chehab wrote: > > There are some places at drm that ended receiving a > > REPLACEMENT CHARACTER U+fffd ('�'), probably because of > > some b

Re: [Intel-gfx] [RFC PATCH 00/97] Basic GuC submission support in the i915

2021-05-25 Thread Alex Deucher
On Fri, May 14, 2021 at 12:31 PM Jason Ekstrand wrote: > > Pulling a few threads together... > > On Mon, May 10, 2021 at 1:39 PM Francisco Jerez wrote: > > > > I agree with Martin on this. Given that using GuC currently involves > > making your open-source graphics stack rely on a closed-source

Re: [Intel-gfx] [PATCH] drm/amdgpu: switch from 'pci_' to 'dma_' API

2021-08-23 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Aug 23, 2021 at 2:16 AM Christian König wrote: > > Am 22.08.21 um 23:21 schrieb Christophe JAILLET: > > The wrappers in include/linux/pci-dma-compat.h should go away. > > > > The patch has been generated with the coccinelle script below. > > > > It has been compile

Re: [Intel-gfx] [PATCH 2/2] drm/amdgpu: Disable PCIE_DPM on Intel RKL Platform

2021-08-25 Thread Alex Deucher
On Wed, Aug 25, 2021 at 10:22 AM Lazar, Lijo wrote: > > > > On 8/25/2021 4:46 PM, Koba Ko wrote: > > On Wed, Aug 25, 2021 at 6:24 PM Jani Nikula > > wrote: > >> > >> On Wed, 25 Aug 2021, Koba Ko wrote: > >>> On Wed, Aug 25, 2021 at 5:22 PM Jani Nikula > >>> wrote: > > On Wed, 25 Aug

Re: [Intel-gfx] [PATCH 01/15] dma-resv: Fix kerneldoc

2021-06-22 Thread Alex Deucher
by: Daniel Vetter > Cc: Sumit Semwal > Cc: "Christian König" > Cc: linux-me...@vger.kernel.org > Cc: linaro-mm-...@lists.linaro.org Reviewed-by: Alex Deucher > --- > include/linux/dma-resv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Intel-gfx] [PATCH 02/15] dma-buf: Switch to inline kerneldoc

2021-06-22 Thread Alex Deucher
On Tue, Jun 22, 2021 at 12:55 PM Daniel Vetter wrote: > > Also review & update everything while we're at it. > > This is prep work to smash a ton of stuff into the kerneldoc for > @resv. > > Signed-off-by: Daniel Vetter > Cc: Sumit Semwal > Cc: "C

Re: [Intel-gfx] [PULL] drm-misc-next-fixes

2021-04-22 Thread Alex Deucher
On Thu, Apr 22, 2021 at 12:33 PM Maxime Ripard wrote: > > Hi Dave, Daniel, > > Here's this week drm-misc-next-fixes PR, for the next merge window > Can we also cherry-pick this patch: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=d510c88cfbb294d2b1e2d0b71576e9b79d0e2e83 It should have real

Re: [Intel-gfx] [PATCH v6 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-28 Thread Alex Deucher
+ dri-devel as well. On Wed, Apr 28, 2021 at 4:44 PM Nikola Cornij wrote: > > [why] > DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is > set, Extended Base Receiver Capability DPCD space must be used. Without > doing that, the three DPCD values that differ will be wrong, lea

Re: [Intel-gfx] [PULL] drm-misc-next-fixes

2021-04-28 Thread Alex Deucher
On Mon, Apr 26, 2021 at 3:35 AM Maxime Ripard wrote: > > Hi Alex, > > On Thu, Apr 22, 2021 at 12:40:10PM -0400, Alex Deucher wrote: > > On Thu, Apr 22, 2021 at 12:33 PM Maxime Ripard wrote: > > > > > > Hi Dave, Daniel, > > > > > > Here&

Re: [Intel-gfx] [PATCH] drm: Split out drm_probe_helper.h

2019-01-15 Thread Alex Deucher
> > I hope there's no other driver who'll blow up accidentally because > someone else is doing a drmP.h cleanup. Laurent maybe? > > Jani, ack on this? > -Daniel amdgpu and radeon: Acked-by: Alex Deucher ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm: remove redundant 'default n' from Kconfig

2019-04-12 Thread Alex Deucher
lied). > That might make it clearer to people that a bare 'default n' is > redundant. > ... > > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Alex Deucher for amdgpu and drm. > --- > drivers/gpu/drm/Kconfig |5 - > drivers/

Re: [Intel-gfx] [PATCH] drm: Nuke drm_calc_{h,v}scale_relaxed()

2019-02-06 Thread Alex Deucher
On Wed, Feb 6, 2019 at 1:32 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > The fuzzy drm_calc_{h,v}scale_relaxed() helpers are no longer used. > Throw them in the bin. > > Signed-off-by: Ville Syrjälä Acked-by: Alex Deucher > --- > drive

Re: [Intel-gfx] [RFC PATCH 00/42] Introduce memory region concept (including device local memory)

2019-02-25 Thread Alex Deucher
On Mon, Feb 25, 2019 at 9:35 PM Joonas Lahtinen wrote: > > Quoting Dave Airlie (2019-02-25 12:24:48) > > On Tue, 19 Feb 2019 at 23:32, Joonas Lahtinen > > wrote: > > > > > > + dri-devel mailing list, especially for the buddy allocator part > > > > > > Quoting Dave Airlie (2019-02-15 02:47:07) > >

Re: [Intel-gfx] [RFC PATCH 00/42] Introduce memory region concept (including device local memory)

2019-02-26 Thread Alex Deucher
On Tue, Feb 26, 2019 at 7:17 AM Joonas Lahtinen wrote: > > Quoting Alex Deucher (2019-02-25 21:31:43) > > On Mon, Feb 25, 2019 at 9:35 PM Joonas Lahtinen > > wrote: > > > > > > Quoting Dave Airlie (2019-02-25 12:24:48) > > > > On Tue, 19 F

Re: [Intel-gfx] [RFC PATCH 00/42] Introduce memory region concept (including device local memory)

2019-02-26 Thread Alex Deucher
On Tue, Feb 26, 2019 at 12:20 PM Alex Deucher wrote: > > On Tue, Feb 26, 2019 at 7:17 AM Joonas Lahtinen > wrote: > > > > Quoting Alex Deucher (2019-02-25 21:31:43) > > > On Mon, Feb 25, 2019 at 9:35 PM Joonas Lahtinen > > > wrote: > > > &g

Re: [Intel-gfx] [PATCH 4/4] drm/edid: Add display_info.rgb_quant_range_selectable

2018-11-28 Thread Alex Deucher
On Wed, Nov 28, 2018 at 12:19 PM Eric Anholt wrote: > > Ville Syrjala writes: > > > From: Ville Syrjälä > > > > Move the CEA-861 QS bit handling entirely into the edid code. No > > need to bother the drivers with this. > > > > Cc: Alex Deuch

Re: [Intel-gfx] [PATCH] drm/dp-mst-helper: Remove hotplug callback

2018-11-29 Thread Alex Deucher
point. Probably should move it there. > > Signed-off-by: Daniel Vetter Acked-by: Alex Deucher > --- > .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c| 9 - > drivers/gpu/drm/drm_dp_mst_topology.c | 7 --- > drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH 4/7] drm: Move the legacy kms disable_all helper to crtc helpers

2018-12-10 Thread Alex Deucher
> > Cc: Sam Bobroff > Signed-off-by: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Ben Skeggs > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David (ChunMing) Zhou" > Cc: Rex Zhu

Re: [Intel-gfx] [PATCH 0/7] legacy helper cleanup

2018-12-10 Thread Alex Deucher
legacy kms in the > same driver module (nouveau and amdgpu). > > Last patch is a bit huge, but splitting it up will make the churn only > worse. > > Comments and review very much appreciated. Some comments on patch 4, 1-3,4-6 are: Reviewed-by: Alex Deucher Assuming the build is

Re: [Intel-gfx] [PATCH 4/7] drm: Move the legacy kms disable_all helper to crtc helpers

2018-12-11 Thread Alex Deucher
On Tue, Dec 11, 2018 at 10:53 AM Sean Paul wrote: > > On Mon, Dec 10, 2018 at 10:58:20AM -0500, Alex Deucher wrote: > > On Mon, Dec 10, 2018 at 5:04 AM Daniel Vetter > > wrote: > > > > > > It's not a core function, and the matching atomic functions

Re: [Intel-gfx] [PATCH i-g-t] igt/amdgpu_amd_prime: Bail if we fail to create more contexts

2018-12-13 Thread Alex Deucher
or that we just need at least one context created! > > References: https://bugs.freedesktop.org/show_bug.cgi?id=109049 > Signed-off-by: Chris Wilson Acked-by: Alex Deucher > --- > tests/amdgpu/amd_prime.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >

Re: [Intel-gfx] [PATCH v2 8/9] drm/amdgpu: use drm_debug_enabled() to check for debug categories

2019-09-24 Thread Alex Deucher
On Tue, Sep 24, 2019 at 9:00 AM Jani Nikula wrote: > > Allow better abstraction of the drm_debug global variable in the > future. No functional changes. > > Cc: Alex Deucher > Cc: Christian König > Cc: David (ChunMing) Zhou > Cc: amd-...@lists.freedesktop.org >

Re: [Intel-gfx] [PATCH v2 1/9] drm/print: move drm_debug variable to drm_print.[ch]

2019-09-24 Thread Alex Deucher
On Tue, Sep 24, 2019 at 8:59 AM Jani Nikula wrote: > > Move drm_debug variable declaration and definition to where they are > relevant and needed. No functional changes. > > Signed-off-by: Jani Nikula Acked-by: Alex Deucher > --- > drivers/gpu

Re: [Intel-gfx] [PATCH v2 2/9] drm/print: add drm_debug_enabled()

2019-09-24 Thread Alex Deucher
On Tue, Sep 24, 2019 at 8:59 AM Jani Nikula wrote: > > Add helper to check if a drm debug category is enabled. Convert drm core > to use it. No functional changes. > > v2: Move unlikely() to drm_debug_enabled() (Eric) > > Signed-off-by: Jani Nikula Acked-by: Alex Deucher

Re: [Intel-gfx] [PATCH v2 9/9] drm/print: rename drm_debug to __drm_debug to discourage use

2019-09-24 Thread Alex Deucher
On Tue, Sep 24, 2019 at 9:00 AM Jani Nikula wrote: > > drm_debug_enabled() is the way to check. __drm_debug is now reserved for > drm print code only. No functional changes. > > v2: Rebase on move unlikely() to drm_debug_enabled() > > Signed-off-by: Jani Nikula A

Re: [Intel-gfx] [PATCH] drm/dp: Set the connector's TILE property even for DP SST connectors

2019-03-13 Thread Alex Deucher
s been tested with xrandr --props and modetest and verified > that TILE property is exposed correctly. > > Cc: Dave Airlie > Cc: Jani Nikula > Cc: Daniel Vetter > Cc: Ville Syrjälä > Signed-off-by: Manasi Navare Reviewed-by: Alex Deucher > --- > drivers/gpu/drm

Re: [Intel-gfx] [PATCH 21/21] drm/fb-helper: Unexport fill_{var, info}

2019-03-26 Thread Alex Deucher
On Tue, Mar 26, 2019 at 9:21 AM Daniel Vetter wrote: > > Not used by drivers anymore. > > v2: Rebase > > Signed-off-by: Daniel Vetter Other than the spelling typos noted by Noralf, the series is: Reviewed-by: Alex Deucher > --- > drivers/gpu/

Re: [Intel-gfx] [PATCH 0/5] drm: Aspect ratio fixes

2019-06-21 Thread Alex Deucher
irkin > > Ville Syrjälä (5): > drm: Do not use bitwise OR to set picure_aspect_ratio > drm: Do not accept garbage mode aspect ratio flags > drm: WARN on illegal aspect ratio when converting a mode to umode Patches 1-3: Reviewed-by: Alex Deucher > drm/i915: Do not overri

Re: [Intel-gfx] linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Alex Deucher
Pushed to drm-misc-next. Alex On Wed, Jun 15, 2022 at 7:26 PM Stephen Rothwell wrote: > > Hi all, > > On Wed, 15 Jun 2022 13:52:34 -0700 Nathan Chancellor > wrote: > > > > On Wed, Jun 15, 2022 at 04:45:16PM -0400, Alex Deucher wrote: > > > On Wed, Jun 1

Re: [Intel-gfx] [PATCH] dma-buf: revert "return only unsignaled fences in dma_fence_unwrap_for_each v3"

2022-07-12 Thread Alex Deucher
in where it makes sense. > >> > >> Signed-off-by: Christian König > > > > After applying the patch, fence merging works and all sw_sync subtests > > are passing. Thanks for taking care of this. > > > > Tested-by: Karolina Drobnik > > can an

Re: [Intel-gfx] [PATCH 02/22] drm/amdgpu: Remove pointless on stack mode copies

2022-03-15 Thread Alex Deucher
. > > > > Cc: Harry Wentland > > Cc: Leo Li > > Cc: Rodrigo Siqueira > > Cc: Alex Deucher > > Cc: amd-...@lists.freedesktop.org > > Cc: Nikola Cornij > > Cc: Aurabindo Pillai > > Signed-off-by: Ville Syrjälä > > Reviewed

Re: [Intel-gfx] [PATCH 05/22] drm/radeon: Use drm_mode_copy()

2022-03-15 Thread Alex Deucher
+ drm_mode_copy(mode, &E) > | > - memcpy(mode, E, S) > + drm_mode_copy(mode, E) > ) > > @depends on !is_mode_copy@ > struct drm_display_mode mode; > expression E; > @@ > ( > - mode = E > + drm_mode_copy(&mode, &E) > | > - memcpy(&mode, E, S)

Re: [Intel-gfx] [PATCH 04/22] drm/amdgpu: Use drm_mode_copy()

2022-03-15 Thread Alex Deucher
, S) > > + drm_mode_copy(mode, E) > > ) > > > > @depends on !is_mode_copy@ > > struct drm_display_mode mode; > > expression E; > > @@ > > ( > > - mode = E > > + drm_mode_copy(&mode, &E) > > | > > - memcpy(&mode

Re: [Intel-gfx] [PATCH 00/22] drm: Review of mode copies

2022-03-15 Thread Alex Deucher
On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä wrote: > > On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: > > drm: Add drm_mode_init() > > drm/bridge: Use drm_mode_copy() > > drm/imx: Use drm_mode_duplicate() > > drm/panel: Use drm_mode_duplicate() > > drm/vc4: Use drm_mode

Re: [Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Alex Deucher
On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > On Wed, 23 Mar 2022 at 08:19, Christian König > wrote: > > Am 23.03.22 um 09:10 schrieb Paul Menzel: > > > Sorry, I disagree. The motivation needs to be part of the commit > > > message. For example see recent discussion on the LWN article

Re: [Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Alex Deucher
On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: > > Hi Alex, > > On Wed, 23 Mar 2022 at 14:42, Alex Deucher wrote: > > On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > > On Wed, 23 Mar 2022 at 08:19, Christian König > > > wrote: > > >

Re: [Intel-gfx] [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-05-16 Thread Alex Deucher
On Mon, May 16, 2022 at 8:40 AM Mike Lothian wrote: > > Hi > > The merge window for 5.19 will probably be opening next week, has > there been any progress with this bug? It took a while to find a combination of GPUs that would repro the issue, but now that we can, it is still being investigated.

Re: [Intel-gfx] Per file OOM badness

2022-05-31 Thread Alex Deucher
+ dri-devel On Tue, May 31, 2022 at 6:00 AM Christian König wrote: > > Hello everyone, > > To summarize the issue I'm trying to address here: Processes can allocate > resources through a file descriptor without being held responsible for it. > > Especially for the DRM graphics driver subsystem th

Re: [Intel-gfx] [PATCH v2 03/29] drm/amdgpu: Don't register backlight when another backlight should be used

2022-07-20 Thread Alex Deucher
> - To avoid linker errors when amdgpu is builtin and video_detect.c is in > a module, select ACPI_VIDEO and its deps if ACPI && X86 are enabled. > When these are not set, ACPI_VIDEO is disabled, ensuring the stubs > from acpi/video.h will be used. > > Signed-of

Re: [Intel-gfx] [PATCH v2 04/29] drm/radeon: Don't register backlight when another backlight should be used

2022-07-20 Thread Alex Deucher
> - To avoid linker errors when radeon is builtin and video_detect.c is in > a module, select ACPI_VIDEO and its deps if ACPI && X86 are enabled. > When these are not set, ACPI_VIDEO is disabled, ensuring the stubs > from acpi/video.h will be used. > > Signed-of

Re: [Intel-gfx] [PATCH v2 03/29] drm/amdgpu: Don't register backlight when another backlight should be used

2022-07-20 Thread Alex Deucher
On Wed, Jul 20, 2022 at 12:44 PM Alex Deucher wrote: > > On Tue, Jul 12, 2022 at 3:39 PM Hans de Goede wrote: > > > > Before this commit when we want userspace to use the acpi_video backlight > > device we register both the GPU's native backlight device and acpi_vi

Re: [Intel-gfx] [PATCH v2 09/29] ACPI: video: Make backlight class device registration a separate step

2022-07-20 Thread Alex Deucher
On Tue, Jul 12, 2022 at 3:40 PM Hans de Goede wrote: > > On x86/ACPI boards the acpi_video driver will usually initializing before initializing -> initialize > the kms driver (except i915). This causes /sys/class/backlight/acpi_video0 > to show up and then the kms driver registers its own native

Re: [Intel-gfx] [PATCH v2 13/29] drm/amdgpu: Register ACPI video backlight when skipping amdgpu backlight registration

2022-07-20 Thread Alex Deucher
ster_acpi_backlight: > + /* Try registering an ACPI video backlight device instead. */ > + acpi_video_register_backlight(); > + return; Can drop the return here. Either way, Acked-by: Alex Deucher > } > > void > diff --git a/drivers/gpu/drm/amd/display/amd

Re: [Intel-gfx] [PATCH v2 14/29] drm/radeon: Register ACPI video backlight when skipping radeon backlight registration

2022-07-20 Thread Alex Deucher
klight device should be used, it will be available > before the radeon drm_device gets registered with userspace. > > Signed-off-by: Hans de Goede Acked-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_encoders.c | 11 ++- > 1 file changed, 10 insertions(+), 1 delet

Re: [Intel-gfx] [PATCH 1/3] drm/amd/display: Fix merge conflict resolution in amdgpu_dm_plane.c

2022-08-10 Thread Alex Deucher
Acked-by: Alex Deucher On Mon, Aug 1, 2022 at 10:08 AM Simon Ser wrote: > > Acked-by: Simon Ser > > CC amd-gfx > > On Monday, August 1st, 2022 at 15:52, Imre Deak wrote: > > > The API change introduced in > > > > commit 30c637151cfa ("drm/plane-hel

Re: [Intel-gfx] [PATCH 01/13] drm/connector: Add define for HDMI 1.4 Maximum Pixel Rate

2021-11-02 Thread Alex Deucher
display/intel_hdmi.c | 2 +- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 ++-- > drivers/gpu/drm/radeon/radeon_encoders.c | 2 +- For radeon: Acked-by: Alex Deucher Note that there are several instances of this in amdgpu as well: drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c:

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-18 Thread Alex Deucher
On Fri, Feb 18, 2022 at 7:13 AM Simon Ser wrote: > > On Friday, February 18th, 2022 at 12:54, Hans de Goede > wrote: > > > On 2/18/22 12:39, Simon Ser wrote: > > > On Friday, February 18th, 2022 at 11:38, Hans de Goede > > > wrote: > > > > > >> What I'm reading in the above is that it is being

Re: [Intel-gfx] [PATCH v12 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-03-02 Thread Alex Deucher
On Wed, Mar 2, 2022 at 10:55 AM Michael Cheng wrote: > > Thanks for the feedback Robin! > > Sorry my choices of word weren't that great, but what I meant is to > understand how ARM flushes a range of dcache for device drivers, and not > an equal to x86 clflush. > > I believe the concern is if the

Re: [Intel-gfx] [RFC v2 1/2] drm/doc/rfc: VM_BIND feature design document

2022-03-09 Thread Alex Deucher
On Mon, Mar 7, 2022 at 3:30 PM Niranjana Vishwanathapura wrote: > > VM_BIND design document with description of intended use cases. > > Signed-off-by: Niranjana Vishwanathapura > --- > Documentation/gpu/rfc/i915_vm_bind.rst | 210 + > Documentation/gpu/rfc/index.rst

Re: [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-02 Thread Alex Deucher
Acked-by: Alex Deucher On Wed, Feb 2, 2022 at 6:31 AM Maxime Ripard wrote: > > On Mon, Jan 31, 2022 at 10:05:32PM +0100, Daniel Vetter wrote: > > Ever since Tomi extracted the core code in 2014 it's been defacto me > > maintaining this, with help from others from

Re: [Intel-gfx] [PATCH 6/6] drm/amdgpu: use dma_fence_chain_contained

2022-02-04 Thread Alex Deucher
On Fri, Feb 4, 2022 at 5:04 AM Christian König wrote: > > Instead of manually extracting the fence. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletion

Re: [Intel-gfx] [PATCH 0/6] Remove unused declarations for gpu/drm

2022-09-13 Thread Alex Deucher
Pushed patches 1-5 to drm-misc-next. Alex On Tue, Sep 13, 2022 at 2:14 AM Christian König wrote: > > Nice cleanup. Acked-by: Christian König for > the whole series. > > Thanks, > Christian. > > Am 13.09.22 um 04:48 schrieb Gaosheng Cui: > > This series contains a few cleanup patches, to remove

Re: [Intel-gfx] [PATCH TRIVIAL v2] gpu: Fix Kconfig indentation

2019-10-07 Thread Alex Deucher
On Mon, Oct 7, 2019 at 7:39 AM Jani Nikula wrote: > > On Fri, 04 Oct 2019, Krzysztof Kozlowski wrote: > > drivers/gpu/drm/i915/Kconfig | 12 +- > > drivers/gpu/drm/i915/Kconfig.debug | 144 +++ > > Please split these out to a separate patch. Can't speak for

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-10-09 Thread Alex Deucher
Applied. thanks! Alex On Tue, Oct 8, 2019 at 8:36 PM Stephen Rothwell wrote: > > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_module.c:25: > drivers/gpu/drm/amd/

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-10-16 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Oct 15, 2019 at 8:22 PM Stephen Rothwell wrote: > > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/gpu/drm/amd/amdgpu/amdgpu_tmz.c:23:10: fatal error: drm/drmP.h: No > such file or direct

Re: [Intel-gfx] [PATCH] drm/amdgpu/dm: Do not throw an error for a display with no audio

2019-11-14 Thread Alex Deucher
so don't flag it as such. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112140 > > References: ae2a3495973e ("drm/amd: be quiet when no SAD block is found") > > Signed-off-by: Chris Wilson > > Reviewed-by: Harry Wentland > Applied. thanks! Al

Re: [Intel-gfx] drm core/helpers and MIT license

2019-11-15 Thread Alex Deucher
On Tue, Nov 12, 2019 at 10:03 AM Daniel Vetter wrote: > > Hi all, > > Dave and me chatted about this last week on irc. Essentially we have: > > $ git grep SPDX.*GPL -- ':(glob)drivers/gpu/drm/*c' > drivers/gpu/drm/drm_client.c:// SPDX-License-Identifier: GPL-2.0 > drivers/gpu/drm/drm_damage_helper

Re: [Intel-gfx] [PATCH v2 2/2] drm: share address space for dma bufs

2019-11-22 Thread Alex Deucher
everybody. > > > > Signed-off-by: Gerd Hoffmann > > Reviewed-by: Daniel Vetter > > But I think you want at least an ack from amd guys for double checking here. > -Daniel Looks correct to me. Reviewed-by: Alex Deucher > > --- > > drivers/gpu/drm/amd

Re: [Intel-gfx] [PATCH v3 1/9] drm/amd/display: Align macro name as per DP spec

2020-01-06 Thread Alex Deucher
n, Dec 30, 2019 at 09:45:15PM +0530, Animesh Manna wrote: > > [Why]: > > Aligh with DP spec wanted to follow same naming convention. > > > > [How]: > > Changed the macro name of the dpcd address used for getting requested > > test-pattern. > > > > C

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add current maximum eDP link rate to sink_rate array.

2020-01-09 Thread Alex Deucher
On Thu, Jan 9, 2020 at 10:08 AM Mario Kleiner wrote: > > If the current eDP link rate, as read from hw, provides a > higher bandwidth than the standard link rates, then add the > current link rate to the link_rates array for consideration > in future mode-sets. > > These initial current eDP link s

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add current maximum eDP link rate to sink_rate array.

2020-01-09 Thread Alex Deucher
On Thu, Jan 9, 2020 at 11:47 AM Mario Kleiner wrote: > > On Thu, Jan 9, 2020 at 4:40 PM Alex Deucher wrote: >> >> On Thu, Jan 9, 2020 at 10:08 AM Mario Kleiner >> wrote: >> > >> > If the current eDP link rate, as read from hw, provides a >> >

Re: [Intel-gfx] [PATCH 02/23] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-13 Thread Alex Deucher
On Fri, Jan 10, 2020 at 4:21 AM Thomas Zimmermann wrote: > > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert > amdgpu over. > I would prefer to just change the signature of amdgpu_display_get_crtc_scano

Re: [Intel-gfx] [PATCH 05/23] drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-13 Thread Alex Deucher
On Fri, Jan 10, 2020 at 4:22 AM Thomas Zimmermann wrote: > > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert > radeon over. > I'd prefer to just change the signature of radeon_get_crtc_scanoutpos() to m

Re: [Intel-gfx] [PATCH 12/23] drm/amdgpu: Convert to CRTC VBLANK callbacks

2020-01-13 Thread Alex Deucher
On Fri, Jan 10, 2020 at 4:22 AM Thomas Zimmermann wrote: > > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Convert amdgpu over. I think I'd prefer to just update the signatures of the relevant functions rather than wrapping them. A

Re: [Intel-gfx] [PATCH 17/23] drm/radeon: Convert to CRTC VBLANK callbacks

2020-01-13 Thread Alex Deucher
On Fri, Jan 10, 2020 at 4:22 AM Thomas Zimmermann wrote: > > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Convert radeon over. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher > --- > d

Re: [Intel-gfx] [PATCH 02/23] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-15 Thread Alex Deucher
On Wed, Jan 15, 2020 at 4:41 AM Thomas Zimmermann wrote: > > Hi > > Am 13.01.20 um 19:52 schrieb Alex Deucher: > > On Fri, Jan 10, 2020 at 4:21 AM Thomas Zimmermann > > wrote: > >> > >> The callback struct drm_driver.get_scanout_positi

Re: [Intel-gfx] [PATCH 1/4] drm/mst: Don't do atomic checks over disabled managers

2020-01-17 Thread Alex Deucher
> irq_exit+0xa9/0xc0 > > [ 306.089859] CPU: 3 PID: 183 Comm: kworker/3:2 Tainted: > > G D 5.5.0-rc6+ #1404 > > [ 306.098167] Hardware name: Intel Corporation Ice Lake Client > > Platform/IceLake U DDR4 SODIMM PD RVP TLC, BIOS > > ICLSFWR1.R00.3201.A00

Re: [Intel-gfx] [PATCH 5/6] drm/amdgpu: add support for exporting VRAM using DMA-buf v2

2020-03-11 Thread Alex Deucher
On Wed, Mar 11, 2020 at 9:52 AM Christian König wrote: > > We should be able to do this now after checking all the prerequisites. > > v2: fix entrie count in the sgt > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 56 --- > drivers/gpu/drm/amd/am

Re: [Intel-gfx] [PATCH 1/9] drm: Constify topology id

2020-03-13 Thread Alex Deucher
On Fri, Mar 13, 2020 at 12:21 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Make the topology id const since we don't want to change it. > > Signed-off-by: Ville Syrjälä Series is: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/drm_connec

Re: [Intel-gfx] [PATCH 4/5] drm/amdgpu: utilize subconnector property for DP through atombios

2020-04-16 Thread Alex Deucher
On Wed, Apr 15, 2020 at 6:05 AM Jani Nikula wrote: > > > Alex, Harry, Christian, can you please eyeball this series and see if it > makes sense for you? > Patches 4, 5 are: Acked-by: Alex Deucher Feel free to take them through whichever tree you want. Alex > Thanks, > J

Re: [Intel-gfx] [PATCH v2 7/9] PM: sleep: core: Rename DPM_FLAG_NEVER_SKIP

2020-04-22 Thread Alex Deucher
> Acked-by: Bjorn Helgaas # for PCI parts > Acked-by: Jeff Kirsher Acked-by: Alex Deucher for radeon and amdgpu Alex > --- > > -> v2: >* Rebased. >* Added tags received so far. > > --- > Documentation/driver-api/pm/devices.rst| 6 +++--- > Documen

Re: [Intel-gfx] [PATCH v6 23/24] drm/radeon: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Alex Deucher
On Fri, Jul 26, 2019 at 1:29 PM Andrzej Pietrasiewicz wrote: > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_connectors.c | 142 +++-- >

Re: [Intel-gfx] [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Alex Deucher
/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c With those updated as well: Acked-by: Alex Deucher > --- > .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 96 ++- > 1 file changed, 70 insertions(+), 26 deletions(-) >

Re: [Intel-gfx] [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Alex Deucher
On Fri, Jul 26, 2019 at 3:42 PM Andrzej Pietrasiewicz wrote: > > Hi Alex, > > > W dniu 26.07.2019 o 21:28, Alex Deucher pisze: > > On Fri, Jul 26, 2019 at 1:28 PM Andrzej Pietrasiewicz > > wrote: > >> > >> Use the ddc pointer provided by the generi

Re: [Intel-gfx] [PATCH RESEND 02/14] drm/radeon: Provide ddc symlink in connector sysfs directory

2019-08-27 Thread Alex Deucher
On Mon, Aug 26, 2019 at 3:26 PM Andrzej Pietrasiewicz wrote: > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_connectors.c | 143 +++-- >

Re: [Intel-gfx] [PATCH v3 4/7] drm/i915: utilize subconnector property for DP

2019-08-29 Thread Alex Deucher
On Wed, Aug 28, 2019 at 10:27 AM Ville Syrjälä wrote: > > On Mon, Aug 26, 2019 at 04:22:13PM +0300, Oleg Vasilev wrote: > > Since DP-specific information is stored in driver's structures, every > > driver needs to implement subconnector property by itself. > > > > v2: updates to match previous com

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Clear out spurious whitespace

2020-01-27 Thread Alex Deucher
Title should be s/i915/edid/ , with that fixed: Reviewed-by: Alex Deucher On Fri, Jan 24, 2020 at 3:03 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Nuke some whitespace that shouldn't be there. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/dr

Re: [Intel-gfx] [PATCH 5/8] drm/edid: Document why we don't bounds check the DispID CEA block start/end

2020-01-27 Thread Alex Deucher
o non-DTD data. > */ > if (cea[0] == DATA_BLOCK_CTA) { > + /* > +* for_each_displayid_db() has already verified > +* that these stay within expected bounds. > +*/ I think the preferred format is to have the

Re: [Intel-gfx] [PATCH 6/8] drm/edid: Add a FIXME about DispID CEA data block revision

2020-01-27 Thread Alex Deucher
On Fri, Jan 24, 2020 at 3:02 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > I don't understand what the DispID CEA data block revision > means. The spec doesn't say. I guess some DispID must have > a value of >= 3 in there or else we generally wouldn't > even parse the CEA data blocks. Or do

Re: [Intel-gfx] [PATCH 2/8] drm/edid: Don't accept any old garbage as a display descriptor

2020-01-27 Thread Alex Deucher
ero for display descriptors so we check > those too). > > Unlike Allen's original proposed patch to just fix is_rb() we > roll this out across the board to fix everything. > > Cc: Allen Chen > Signed-off-by: Ville Syrjälä Acked-by: Alex Deucher > --- > drivers/gp

Re: [Intel-gfx] [PATCH 3/8] drm/edid: Introduce is_detailed_timing_descritor()

2020-01-27 Thread Alex Deucher
On Fri, Jan 24, 2020 at 3:02 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Let's introduce is_detailed_timing_descritor() as the opposite > counterpart of is_display_descriptor(). > > Cc: Allen Chen > Signed-off-by: Ville Syrjälä Acked-by: Alex Deuch

Re: [Intel-gfx] [PATCH 7/8] drm/edid: Constify lots of things

2020-01-27 Thread Alex Deucher
On Fri, Jan 24, 2020 at 3:03 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Let's try to make a lot more stuff const in the edid parser. > > The "downside" is that we can no longer mangle the EDID in the > middle of the parsing to apply quirks (drm_mode_detailed()). > I don't really think ma

Re: [Intel-gfx] [PATCH 1/8] drm/edid: Check the number of detailed timing descriptors in the CEA ext block

2020-01-27 Thread Alex Deucher
the code > does already survive that case as we'd just end up with a negative > number of descriptors and the loop would not do anything. > > Cc: Allen Chen > Signed-off-by: Ville Syrjälä Acked-by: Alex Deucher > --- > drivers/gpu/drm/drm_edid.c | 5 - > 1 file cha

Re: [Intel-gfx] [PATCH 8/8] drm/edid: Dump bogus 18 byte descriptors

2020-01-27 Thread Alex Deucher
; if our CI has anything that hits this :) > > Signed-off-by: Ville Syrjälä Acked-by: Alex Deucher > --- > drivers/gpu/drm/drm_edid.c | 22 +++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/

Re: [Intel-gfx] [PATCH v4 10/22] drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-02-03 Thread Alex Deucher
> Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/radeon/atombios_crtc.c | 1 + > drivers/gpu/drm/radeon/radeon_display.c | 13 + > drivers/gpu/drm/radeon/radeon_drv.c | 11 --- > drivers/gpu/drm/radeon/radeon

Re: [Intel-gfx] [PATCH v4 04/22] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-02-03 Thread Alex Deucher
On Thu, Jan 23, 2020 at 9:00 AM Thomas Zimmermann wrote: > > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert > amdgpu over. > > Signed-off-by: Thomas Zimmermann Reviewe

Re: [Intel-gfx] [PATCH v4 05/22] drm/amdgpu: Convert to CRTC VBLANK callbacks

2020-02-03 Thread Alex Deucher
t; > Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +++--- > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 > driver

  1   2   3   4   >