[PATCH RFC 2/4] drm/nouveau/dp: Use the generic helper to control LTTPR transparent mode

2024-11-01 Thread Abel Vesa
LTTPRs operating modes are defined by the DisplayPort standard and the generic framework now provides a helper to switch between them. So use the drm generic helper instead as it makes the code a bit cleaner. Signed-off-by: Abel Vesa --- drivers/gpu/drm/nouveau/nouveau_dp.c | 9 +++-- 1

[PATCH RFC 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2024-11-01 Thread Abel Vesa
DPTX by issuing an AUX write to the DPCD PHY_REPEATER_MODE register. Add a generic helper that allows switching between these modes. Signed-off-by: Abel Vesa --- drivers/gpu/drm/display/drm_dp_helper.c | 17 + include/drm/display/drm_dp_helper.h | 1 + 2 files changed, 18

[PATCH RFC 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode

2024-11-01 Thread Abel Vesa
LTTPRs operating modes are defined by the DisplayPort standard and the generic framework now provides a helper to switch between them. So use the drm generic helper instead as it makes the code a bit cleaner. Signed-off-by: Abel Vesa --- drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2

[PATCH RFC 4/4] drm/msm/dp: Add support for LTTPR handling

2024-11-01 Thread Abel Vesa
ation mode to transparent mode first and then to non-transparent, just like the mentioned section of the specification mandates. Signed-off-by: Abel Vesa --- drivers/gpu/drm/msm/dp/dp_display.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/m

[PATCH RFC 0/4] drm/dp: Rework LTTPR transparent mode handling and add support to msm driver

2024-11-01 Thread Abel Vesa
patchset has been tested on. Signed-off-by: Abel Vesa --- Abel Vesa (4): drm/dp: Add helper to set LTTPRs in transparent mode drm/nouveau/dp: Use the generic helper to control LTTPR transparent mode drm/i915/dp: Use the generic helper to control LTTPR transparent mode drm/msm/dp

[PATCH v3 0/4] drm/dp: Rework LTTPR transparent mode handling and add support to msm driver

2025-01-07 Thread Abel Vesa
patchset has been tested on. Signed-off-by: Abel Vesa --- Changes in v3: - Picked-up T-b tag from Johan for the drm/dp transparent mode set helper patch - Re-worked the return value of the drm/dp transparet mode set helper - Added some more details about what the values of the lttpr_count arg is

[PATCH v3 4/4] drm/msm/dp: Add support for LTTPR handling

2025-01-07 Thread Abel Vesa
ype-C dongles) that have at least one such an LTTPR, set its operation mode to transparent mode first and then to non-transparent, just like the mentioned section of the specification mandates. Tested-by: Johan Hovold Signed-off-by: Abel Vesa --- drivers/gpu/drm/msm/dp/dp_display.c

[PATCH v3 2/4] drm/nouveau/dp: Use the generic helper to control LTTPR transparent mode

2025-01-07 Thread Abel Vesa
the new drm generic helper instead as it makes the code a bit cleaner. Reviewed-by: Lyude Paul Signed-off-by: Abel Vesa --- drivers/gpu/drm/nouveau/nouveau_dp.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_dp.c b/drivers/

Re: [PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2025-01-07 Thread Abel Vesa
On 24-12-11 21:22:00, Dmitry Baryshkov wrote: > On Wed, Dec 11, 2024 at 03:04:12PM +0200, Abel Vesa wrote: > > According to the DisplayPort standard, LTTPRs have two operating > > modes: > > - non-transparent - it replies to DPCD LTTPR field specific AUX > >request

Re: [PATCH v2 4/4] drm/msm/dp: Add support for LTTPR handling

2025-01-07 Thread Abel Vesa
On 24-12-11 15:56:53, Johan Hovold wrote: > On Wed, Dec 11, 2024 at 03:04:15PM +0200, Abel Vesa wrote: > > > +static void msm_dp_display_lttpr_init(struct msm_dp_display_private *dp) > > +{ > > + int lttpr_count; > > + > > + if (drm_dp_read_lttpr_

Re: [PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2025-01-07 Thread Abel Vesa
On 24-12-11 15:42:27, Johan Hovold wrote: > On Wed, Dec 11, 2024 at 03:04:12PM +0200, Abel Vesa wrote: > > > +/** > > + * drm_dp_lttpr_set_transparent_mode - set the LTTPR in transparent mode > > + * @aux: DisplayPort AUX channel > > + * @enable: Enab

Re: [PATCH v3 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode

2025-01-07 Thread Abel Vesa
On 25-01-03 20:09:42, Dmitry Baryshkov wrote: > On Fri, Jan 03, 2025 at 02:58:17PM +0200, Abel Vesa wrote: > > LTTPRs operating modes are defined by the DisplayPort standard and the > > generic framework now provides a helper to switch between them, which > > is handling the

[PATCH v3 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode

2025-01-07 Thread Abel Vesa
the new drm generic helper instead as it makes the code a bit cleaner. Acked-by: Imre Deak Signed-off-by: Abel Vesa --- .../gpu/drm/i915/display/intel_dp_link_training.c | 24 +- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/i915/disp

[PATCH v3 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2025-01-07 Thread Abel Vesa
ard v2.0 section 3.6.6.1. Do this in order to move this handling out of the vendor specific driver implementation into the generic framework. Tested-by: Johan Hovold Signed-off-by: Abel Vesa --- drivers/gpu/drm/display/drm_dp_helper.c | 61 + include/drm/disp

[PATCH v5 0/4] drm/dp: Rework LTTPR transparent mode handling and add support to msm driver

2025-02-03 Thread Abel Vesa
patchset has been tested on. Signed-off-by: Abel Vesa --- Changes in v5: - Added kernel-doc () suffix and semicolon after "Return" for drm_dp_lttpr_set_transparent_mode, and dropped the extra blank line from kernel-doc of drm_dp_lttpr_init, like Bjorn suggested - Picked up Abhinav's R

[PATCH v5 2/4] drm/nouveau/dp: Use the generic helper to control LTTPR transparent mode

2025-02-03 Thread Abel Vesa
the new drm generic helper instead as it makes the code a bit cleaner. Reviewed-by: Lyude Paul Signed-off-by: Abel Vesa --- drivers/gpu/drm/nouveau/nouveau_dp.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_dp.c b/drivers/

[PATCH v5 4/4] drm/msm/dp: Add support for LTTPR handling

2025-02-03 Thread Abel Vesa
ype-C dongles) that have at least one such an LTTPR, set its operation mode to transparent mode first and then to non-transparent, just like the mentioned section of the specification mandates. Tested-by: Johan Hovold Reviewed-by: Dmitry Baryshkov Reviewed-by: Johan Hovold Signed-off-by: Abel

[PATCH v5 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2025-02-03 Thread Abel Vesa
ard v2.0 section 3.6.6.1. Do this in order to move this handling out of the vendor specific driver implementation into the generic framework. Tested-by: Johan Hovold Reviewed-by: Dmitry Baryshkov Reviewed-by: Johan Hovold Reviewed-by: Abhinav Kumar Signed-off-by: Abel Vesa --- drivers/gpu/

[PATCH v5 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode

2025-02-03 Thread Abel Vesa
eak Signed-off-by: Abel Vesa --- .../gpu/drm/i915/display/intel_dp_link_training.c | 24 +- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c in

Re: [PATCH RFC 4/4] drm/msm/dp: Add support for LTTPR handling

2024-12-12 Thread Abel Vesa
On 24-12-11 11:55:54, Dmitry Baryshkov wrote: > On Wed, Dec 11, 2024 at 11:08:16AM +0200, Abel Vesa wrote: > > On 24-10-31 18:54:25, Dmitry Baryshkov wrote: > > > On Thu, Oct 31, 2024 at 05:12:48PM +0200, Abel Vesa wrote: > > > > Link Training Tunable PHY Rep

[PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2024-12-12 Thread Abel Vesa
ard v2.0 section 3.6.6.1. Do this in order to move this handling out of the vendor specific driver implementation into the generic framework. Signed-off-by: Abel Vesa --- drivers/gpu/drm/display/drm_dp_helper.c | 50 + include/drm/display/drm_dp_helper.h | 2 ++

[PATCH v2 0/4] drm/dp: Rework LTTPR transparent mode handling and add support to msm driver

2024-12-12 Thread Abel Vesa
patchset has been tested on. Signed-off-by: Abel Vesa --- Changes in v2: - Added new wrapper over the set_transparent new helper in order to move the non-transparent disable and the its enable->disable sequence mentioned in the DP standard section 3.6.6.1 entirely in the generic implemetat

[PATCH v2 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode

2024-12-12 Thread Abel Vesa
the new drm generic helper instead as it makes the code a bit cleaner. Signed-off-by: Abel Vesa --- .../gpu/drm/i915/display/intel_dp_link_training.c | 24 +- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c

[PATCH v2 4/4] drm/msm/dp: Add support for LTTPR handling

2024-12-12 Thread Abel Vesa
ype-C dongles) that have at least one such an LTTPR, set its operation mode to transparent mode first and then to non-transparent, just like the mentioned section of the specification mandates. Signed-off-by: Abel Vesa --- drivers/gpu/drm/msm/dp/dp_display.c | 17 + 1 file change

Re: [PATCH RFC 4/4] drm/msm/dp: Add support for LTTPR handling

2024-12-12 Thread Abel Vesa
On 24-10-31 18:54:25, Dmitry Baryshkov wrote: > On Thu, Oct 31, 2024 at 05:12:48PM +0200, Abel Vesa wrote: > > Link Training Tunable PHY Repeaters (LTTPRs) are defined in DisplayPort > > 1.4a specification. As the name suggests, these PHY repeaters are > > capable of adjus

Re: [PATCH RFC 2/4] drm/nouveau/dp: Use the generic helper to control LTTPR transparent mode

2024-12-12 Thread Abel Vesa
On 24-10-31 18:44:55, Dmitry Baryshkov wrote: > On Thu, Oct 31, 2024 at 05:12:46PM +0200, Abel Vesa wrote: > > LTTPRs operating modes are defined by the DisplayPort standard and the > > generic framework now provides a helper to switch between them. > > So use the drm generic

[PATCH v2 2/4] drm/nouveau/dp: Use the generic helper to control LTTPR transparent mode

2024-12-12 Thread Abel Vesa
the new drm generic helper instead as it makes the code a bit cleaner. Signed-off-by: Abel Vesa --- drivers/gpu/drm/nouveau/nouveau_dp.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_dp.c b/drivers/gpu/drm/nouveau/nouveau_d

[PATCH v4 0/4] drm/dp: Rework LTTPR transparent mode handling and add support to msm driver

2025-01-08 Thread Abel Vesa
patchset has been tested on. Signed-off-by: Abel Vesa --- Changes in v4: - Picked up Dmitry's and Johan's R-b tags for the drm generic and drm msm patches. - Moved the comment about the roll-back to transparent mode inside the if statement and fixed the typos, like Johan suggested. -

[PATCH v4 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2025-01-08 Thread Abel Vesa
ard v2.0 section 3.6.6.1. Do this in order to move this handling out of the vendor specific driver implementation into the generic framework. Tested-by: Johan Hovold Reviewed-by: Dmitry Baryshkov Reviewed-by: Johan Hovold Signed-off-by: Abel Vesa --- drivers/gpu/drm/display/drm_dp_helper.c |

[PATCH v4 4/4] drm/msm/dp: Add support for LTTPR handling

2025-01-08 Thread Abel Vesa
ype-C dongles) that have at least one such an LTTPR, set its operation mode to transparent mode first and then to non-transparent, just like the mentioned section of the specification mandates. Tested-by: Johan Hovold Reviewed-by: Dmitry Baryshkov Reviewed-by: Johan Hovold Signed-off-by: Abel

[PATCH v4 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode

2025-01-08 Thread Abel Vesa
eak Signed-off-by: Abel Vesa --- .../gpu/drm/i915/display/intel_dp_link_training.c | 24 +- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c in

[PATCH v4 2/4] drm/nouveau/dp: Use the generic helper to control LTTPR transparent mode

2025-01-08 Thread Abel Vesa
the new drm generic helper instead as it makes the code a bit cleaner. Reviewed-by: Lyude Paul Signed-off-by: Abel Vesa --- drivers/gpu/drm/nouveau/nouveau_dp.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_dp.c b/drivers/

Re: [PATCH v3 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2025-01-08 Thread Abel Vesa
On 25-01-07 10:30:29, Johan Hovold wrote: > On Fri, Jan 03, 2025 at 02:58:15PM +0200, Abel Vesa wrote: > > According to the DisplayPort standard, LTTPRs have two operating > > modes: > > - non-transparent - it replies to DPCD LTTPR field specific AUX > >request

Re: [PATCH v3 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode

2025-01-08 Thread Abel Vesa
On 25-01-08 15:11:50, Dmitry Baryshkov wrote: > On Mon, Jan 06, 2025 at 02:45:48PM +0200, Abel Vesa wrote: > > On 25-01-03 20:09:42, Dmitry Baryshkov wrote: > > > On Fri, Jan 03, 2025 at 02:58:17PM +0200, Abel Vesa wrote: > > > > LTTPRs operating modes are defined b

Re: [PATCH v4 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2025-01-09 Thread Abel Vesa
On 25-01-08 16:17:47, Bjorn Andersson wrote: > On Wed, Jan 08, 2025 at 04:31:43PM +0200, Abel Vesa wrote: > > According to the DisplayPort standard, LTTPRs have two operating > > modes: > > - non-transparent - it replies to DPCD LTTPR field specific AUX > >request

Re: [PATCH v4 4/4] drm/msm/dp: Add support for LTTPR handling

2025-01-09 Thread Abel Vesa
On 25-01-08 14:57:41, Abhinav Kumar wrote: > > > On 1/8/2025 6:31 AM, Abel Vesa wrote: > > Link Training Tunable PHY Repeaters (LTTPRs) are defined in DisplayPort > > 1.4a specification. As the name suggests, these PHY repeaters are > > capable of adjusting the

Re: [PATCH v4 4/4] drm/msm/dp: Add support for LTTPR handling

2025-01-09 Thread Abel Vesa
On 25-01-08 16:25:31, Bjorn Andersson wrote: > On Wed, Jan 08, 2025 at 04:31:46PM +0200, Abel Vesa wrote: > > Link Training Tunable PHY Repeaters (LTTPRs) are defined in DisplayPort > > 1.4a specification. As the name suggests, these PHY repeaters are > > capable of adjusting