On Wed, 03 May 2017 15:39:06 +0200,
Ville Syrjälä wrote:
>
> On Fri, Apr 28, 2017 at 10:41:37AM +0200, Takashi Iwai wrote:
> > On Thu, 27 Apr 2017 18:02:19 +0200,
> > ville.syrj...@linux.intel.com wrote:
> > >
> > > From: Ville Syrjälä
> > >
>
hread+0x49/0x4a0
> kthread+0x107/0x140
> ? process_one_work+0x6d0/0x6d0
> ? kthread_create_on_node+0x40/0x40
> ret_from_fork+0x2e/0x40
>
> Fixes: 38b19ed7f81e ("ALSA: hda: fix to wait for RIRB & CORB DMA to set")
> Bugzilla: https://bugs.fre
On Thu, 04 May 2017 12:30:32 +0200,
Vinod Koul wrote:
>
> On Thu, May 04, 2017 at 12:25:26PM +0200, Takashi Iwai wrote:
> > On Thu, 04 May 2017 12:18:29 +0200,
> > Chris Wilson wrote:
> > >
> > > hdac_wait_for_cmd_dmas() uses a jiffie timeout to ensure that we
during driver probing create the link with DL_FLAG_STATELESS. Since the
> probe time ordering has to be optional we use the component framework
> for that.
>
> Cc: Ville Syrjälä
> Cc: Takashi Iwai
> Signed-off-by: Imre Deak
This looks like a good idea!
thanks,
Takashi
>
t;ALSA: hda - Fix mutex deadlock at HDMI/DP hotplug")
> Signed-off-by: Chris Wilson
> Cc: Ville Syrjälä
> Cc: Takashi Iwai
> Cc: Vinod Koul
Thanks, applied with Cc to stable.
Takashi
___
Intel-gfx mailing list
Intel-gfx@lists.freed
On Wed, 27 Jun 2018 08:30:37 +0200,
Takashi Iwai wrote:
>
> On Wed, 27 Jun 2018 08:25:32 +0200,
> Chris Wilson wrote:
> >
> > Obtaining the runtime pm wakeref can fail, especially in a hotplug
> > scenario where i915.ko has been unloaded. If we do not catch the
>
On Thu, 12 Jul 2018 08:54:34 +0200,
Daniel Vetter wrote:
>
> On Thu, Jul 12, 2018 at 09:29:01AM +0800, Feng Tang wrote:
> > On Tue, Jun 26, 2018 at 10:29:16AM +0800, Feng Tang wrote:
> > > On Mon, Jun 25, 2018 at 05:36:32PM +0200, Daniel Vetter wrote:
> >
> > > Hi Daneil/Jani/Takashi,
> > >
> >
, the corresponding code is removed
by passing hdac_bus object to the function, too.
Signed-off-by: Takashi Iwai
---
include/sound/hda_i915.h | 6 --
sound/hda/hdac_i915.c| 34 +-
sound/pci/hda/patch_hdmi.c | 5 +++--
sound/soc/codecs/hdac_hdmi.c | 2
he fly.
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/Kconfig | 1 +
include/drm/drm_audio_component.h | 23 ++
include/sound/hda_component.h | 61 ++
include/sound/hda_i915.h | 39 +---
sound/hda/Kconfig | 7 +-
sound/hda/Makefile
a preliminary change for further development, and no
functional changes by this patch itself, merely code-split and
renames.
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/intel_audio.c | 22 +++---
include/drm/drm_audio_component.h | 115 +
include/drm
et me know if anyone has concerns.
Thanks!
Takashi
===
Takashi Iwai (3):
drm/i915: Split audio component to a generic type
ALSA: hda/i915: Associate audio component with devres
ALSA: hda: Make audio component support more generic
drivers/gpu/drm/i915/Kconfig | 1 +
drivers/gp
On Mon, 16 Jul 2018 19:22:17 +0200,
Rodrigo Vivi wrote:
>
> > --- /dev/null
> > +++ b/include/drm/drm_audio_component.h
> > @@ -0,0 +1,115 @@
> > +/*
> > + * Copyright © 2014 Intel Corporation
> > + *
> > + * Permission is hereby granted, free of charge, to any person obtaining a
> > + * copy of t
On Mon, 16 Jul 2018 15:48:15 +0200,
Takashi Iwai wrote:
>
> +static int hdac_component_master_bind(struct device *dev)
> +{
> + struct drm_audio_component *acomp = hdac_get_acomp(dev);
> + int ret;
> +
> + ret = component_bind_all(dev, acomp)
On Mon, 16 Jul 2018 19:50:48 +0200,
Takashi Iwai wrote:
>
> On Mon, 16 Jul 2018 19:22:17 +0200,
> Rodrigo Vivi wrote:
> >
> > > --- /dev/null
> > > +++ b/include/drm/drm_audio_component.h
> > > @@ -0,0 +1,115 @@
> > &g
, the corresponding code is removed
by passing hdac_bus object to the function, too.
Signed-off-by: Takashi Iwai
---
include/sound/hda_i915.h | 6 --
sound/hda/hdac_i915.c| 34 +-
sound/pci/hda/patch_hdmi.c | 5 +++--
sound/soc/codecs/hdac_hdmi.c | 2
he fly.
v1->v2: Fix missing NULL check in master_bind/unbind
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/Kconfig | 1 +
include/drm/drm_audio_component.h | 23 ++
include/sound/hda_component.h | 61 ++
include/sound/hda_i915.h | 39 +---
sound/hda/Kconfig
915
argument in drm_audio_component.h
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/intel_audio.c | 22 +++
include/drm/drm_audio_component.h | 95 ++
include/drm/i915_component.h | 85 ++
include/sound/hda_i915.h |
et me know if anyone has concerns.
Thanks!
Takashi
===
v1->v2:
* Change to SPDX for the new drm_audio_component.h
* Fix remaining i915 word in drm_audio_component.h comments
* Fix NULL dereference in master_bind / _unbind ops
===
Takashi Iwai (3):
drm/i915: Split audio component to a
On Wed, 18 Jul 2018 22:54:35 +0200,
Pierre-Louis Bossart wrote:
>
>
>
> On 07/17/2018 04:26 AM, Takashi Iwai wrote:
> > Hi,
> >
> > this is a preliminiary patch set to convert the existing i915 /
> > HD-audio component binding to be applicable to other dri
On Thu, 19 Jul 2018 15:05:45 +0200,
Pierre-Louis Bossart wrote:
>
> On 7/19/18 12:50 AM, Takashi Iwai wrote:
> > On Wed, 18 Jul 2018 22:54:35 +0200,
> > Pierre-Louis Bossart wrote:
> >>
> >>
> >>
> >> On 07/17/2018 04:26 AM, Takashi Iwai wro
onent registration.
For addressing it, implement a completion to be synced with the master
binding. The timeout is set to 10 seconds which should be long enough
and hopefully be not too annoying if anyone boots up a debugging
session with i915 KMS turned off.
Signed-off-by: Takashi Iwai
---
This is ap
On Tue, 14 Aug 2018 11:34:07 +0200,
Daniel Vetter wrote:
>
> On Tue, Aug 14, 2018 at 02:54:31PM +0800, Feng Tang wrote:
> > Hi Jani, Daniel
> >
> > Could you help to comment? thanks,
> >
> > - Feng
> >
> > On Thu, Jul 12, 2018 at 03:51:34PM +0800, Feng Tang wrote:
> > > Hi Daniel,
> > >
> > >
On Fri, 17 Aug 2018 11:38:01 +0200,
Imre Deak wrote:
>
> On Fri, Aug 17, 2018 at 10:24:30AM +0100, Chris Wilson wrote:
> > Quoting Imre Deak (2018-08-17 10:14:51)
> > > On Thu, Aug 16, 2018 at 07:01:36PM +0100, Chris Wilson wrote:
> > > > Loading the sounds modules is asynchronous with the sysfs d
On Wed, 12 Sep 2018 19:46:58 +0200,
Ville Syrjälä wrote:
>
> On Tue, Sep 11, 2018 at 03:50:13PM +0200, Bruno Prémont wrote:
> > Hi,
> >
> > I have a system with multiple monitors and would like to send
> > notification sounds to the monitor on which corresponding
> > window is visible.
> >
> > F
On Wed, 12 Sep 2018 15:18:47 +0200,
Imre Deak wrote:
>
> +Takashi
>
> On Wed, Sep 12, 2018 at 04:18:12PM +0300, Imre Deak wrote:
> > Hi Kumar, Takashi,
> >
> > On Tue, Jun 19, 2018 at 03:01:11PM -0700, Abhay Kumar wrote:
> > > From: Ville Syrjälä
> > >
> > > CDCLK has to be at least twice the
On Thu, 13 Sep 2018 15:54:37 +0200,
Imre Deak wrote:
>
> On Wed, Sep 12, 2018 at 08:18:37PM +0200, Takashi Iwai wrote:
> > On Wed, 12 Sep 2018 15:18:47 +0200,
> > Imre Deak wrote:
> > >
> > > +Takashi
> > >
> > > On Wed, Sep 12, 2018
On Thu, 13 Sep 2018 09:25:37 +0200,
Bruno Prémont wrote:
>
> On Wed, 12 Sep 2018 20:06:43 +0200 Takashi Iwai wrote:
> > On Wed, 12 Sep 2018 19:46:58 +0200,
> > Ville Syrjälä wrote:
> > >
> > > On Tue, Sep 11, 2018 at 03:50:13PM +0200, Bruno Prémont wrote:
&
On Wed, 20 Jun 2018 08:25:23 +0200,
Feng Tang wrote:
>
> Hi Jani/Chris/Takashi,
>
> On Wed, Jun 06, 2018 at 11:21:43AM +0300, Jani Nikula wrote:
> > >>
> > >> http://patchwork.freedesktop.org/patch/msgid/20180323083048.13327-1-ch...@chris-wilson.co.uk
> > >
> > > IIUC, you are waiting for the H
On Wed, 20 Jun 2018 10:02:42 +0200,
Daniel Vetter wrote:
>
> On Wed, Jun 20, 2018 at 10:11:34AM +0300, Jani Nikula wrote:
> > On Wed, 20 Jun 2018, Feng Tang wrote:
> > > Hi Takashi,
> > >
> > > On Wed, Jun 20, 2018 at 08:35:05AM +0200, Takashi Iwai wro
On Thu, 19 Nov 2015 16:51:05 +0100,
Daniel Vetter wrote:
>
> On Thu, Nov 19, 2015 at 12:09:56PM +0100, Takashi Iwai wrote:
> > Currently a DDI port may register the DP hotplug handler even though
> > it's used with HDMI, and the DP HPD handler overrides the encoder
> &g
On Thu, 19 Nov 2015 17:04:20 +0100,
Takashi Iwai wrote:
>
> On Thu, 19 Nov 2015 16:51:05 +0100,
> Daniel Vetter wrote:
> >
> > On Thu, Nov 19, 2015 at 12:09:56PM +0100, Takashi Iwai wrote:
> > > Currently a DDI port may register the DP hotplug handler even though
On Wed, 25 Nov 2015 10:56:51 +0100,
Zhang, Xiong Y wrote:
>
> Recently I always see the following error message during S4 or S3 resume with
> drm-intel-nightly.
> [ 97.778063] PM: Syncing filesystems ... done.
> [ 97.801550] Freezing user space processes ... (elapsed 0.002 seconds) done.
> [
On Wed, 25 Nov 2015 11:57:13 +0100,
Zhang, Xiong Y wrote:
>
> > On Wed, 25 Nov 2015 10:56:51 +0100,
> > Zhang, Xiong Y wrote:
> > >
> > > Recently I always see the following error message during S4 or S3 resume
> > with drm-intel-nightly.
> > > [ 97.778063] PM: Syncing filesystems ... done.
> >
e.com/show_bug.cgi?id=956397
Fixes: cfb23ed622d0 ('drm/i915: Allow fuzzy matching in pipe_config_compare,
v2')
Cc: # v4.3+
Reported-and-tested-by: Max Lin
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/intel_display.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drive
On Thu, 26 Nov 2015 07:06:56 +0100,
Zhang, Xiong Y wrote:
>
> > On Wed, 25 Nov 2015 11:57:13 +0100,
> > Zhang, Xiong Y wrote:
> > >
> > > > On Wed, 25 Nov 2015 10:56:51 +0100,
> > > > Zhang, Xiong Y wrote:
> > > > >
> > > > > Recently I always see the following error message during S4 or S3
> > >
On Thu, 26 Nov 2015 08:57:30 +0100,
Zhang, Xiong Y wrote:
>
> > > > BTW, I have a patchset to avoid the audio h/w wakeup by a new
> > > > component ops to get ELD and connection states. It was posted to
> > > > alsa-devel shortly ago just as a reference, but this should work well
> > > > in such
On Thu, 26 Nov 2015 10:16:17 +0100,
Zhang, Xiong Y wrote:
>
>
> > On Thu, 26 Nov 2015 08:57:30 +0100,
> > Zhang, Xiong Y wrote:
> > >
> > > > > > BTW, I have a patchset to avoid the audio h/w wakeup by a new
> > > > > > component ops to get ELD and connection states. It was posted to
> > > > > >
On Thu, 26 Nov 2015 16:08:06 +0100,
David Henningsson wrote:
>
>
>
> On 2015-11-26 10:24, Takashi Iwai wrote:
> > On Thu, 26 Nov 2015 10:16:17 +0100,
> > Zhang, Xiong Y wrote:
> >>
> >>
> >>> On Thu, 26 Nov 2015 08:57:30 +0100,
> >>
On Thu, 26 Nov 2015 16:29:12 +0100,
David Henningsson wrote:
>
>
>
> On 2015-11-26 16:23, Takashi Iwai wrote:
> > On Thu, 26 Nov 2015 16:08:06 +0100,
> > David Henningsson wrote:
> >>
> >>
> >>
> >> On 2015-11-26 10:24, Takashi Iwai
On Thu, 26 Nov 2015 16:43:23 +0100,
Ville Syrjälä wrote:
>
> On Thu, Nov 26, 2015 at 04:29:12PM +0100, David Henningsson wrote:
> >
> >
> > On 2015-11-26 16:23, Takashi Iwai wrote:
> > > On Thu, 26 Nov 2015 16:08:06 +0100,
> > > David Henningsson wrote:
On Thu, 26 Nov 2015 16:58:09 +0100,
Ville Syrjälä wrote:
>
> On Thu, Nov 26, 2015 at 04:51:04PM +0100, Takashi Iwai wrote:
> > On Thu, 26 Nov 2015 16:43:23 +0100,
> > Ville Syrjälä wrote:
> > >
> > > On Thu, Nov 26, 2015 at 04:29:12PM +0100, David Henningsson
_get_state(codec->card) != SNDRV_CTL_POWER_D0)
> > + return;
> > +
> > check_presence_and_report(codec, pin_nid);
> > }
> >
> [Zhang, Xiong Y] yes, this patch could remove the error message.
Alright, then it's indeed a failure in the sound driver side.
Below is the offici
On Fri, 27 Nov 2015 14:45:31 +0100,
David Henningsson wrote:
>
>
>
> On 2015-11-27 14:38, Takashi Iwai wrote:
> > On Fri, 27 Nov 2015 03:55:28 +0100,
> > Zhang, Xiong Y wrote:
> >>
> >>> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_
Instead of doing in each caller side, snd_hdmi_parse_eld() does
zero-clear of the parsed data by itself. This is safer and simplifies
the code.
Signed-off-by: Takashi Iwai
---
sound/pci/hda/hda_eld.c| 1 +
sound/pci/hda/patch_hdmi.c | 2 --
2 files changed, 1 insertion(+), 2 deletions
to_intel_crtc() always returns a non-NULL pointer.
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/intel_audio.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c
b/drivers/gpu/drm/i915/intel_audio.c
index 4dccd9b003a1..0c38cc6c82ae 100644
--- a
version, posted to both i915 and alsa-devel for
review.
The current patchset is found in sound git tree test/hdmi-jack
branch.
Takashi
Takashi Iwai (7):
drm/i915: Remove superfluous NULL check
drm/i915: Add get_eld audio component
drm/i915: refactoring audio component functions
ALSA: hda
new field audio_enabled is added to struct
intel_digital_port. This is set/reset at each audio enable/disable
call in intel_audio.c.
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/intel_audio.c | 40 ++
drivers/gpu/drm/i915/intel_drv.h | 1 +
i
We have a common loop of encoder to look for the given audio port in
two audio component functions. Split out a local helper function to
do it for the code simplification.
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/intel_audio.c | 61 --
1 file
cally designed for the pin sense read and
unsol events, both of which aren't used any longer in our case.
Signed-off-by: Takashi Iwai
---
sound/pci/hda/patch_hdmi.c | 84 --
1 file changed, 82 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/patc
, we can skip it when received during PM
process.
Signed-off-by: Takashi Iwai
---
sound/pci/hda/patch_hdmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 23a4292c355f..0492f3cf744e 100644
--- a/sound/pci/hda/patch_hdmi.c
This is a preliminary patch for the later change to support ELD/jack
handling with i915 audio component. This splits the ELD update code
from hdmi_present_sense() so that it can be called from other places.
Just a code refactoring, no functional change.
Signed-off-by: Takashi Iwai
---
sound
On Mon, 30 Nov 2015 15:11:16 +0100,
Daniel Vetter wrote:
>
> On Mon, Nov 30, 2015 at 02:37:46PM +0100, Takashi Iwai wrote:
> > Implement a new i915_audio_component_ops, get_eld(). It's called by
> > the audio driver to fetch the current ELD of the given HDMI/DP port.
>
On Mon, 30 Nov 2015 15:14:03 +0100,
Daniel Vetter wrote:
>
> On Mon, Nov 30, 2015 at 02:37:47PM +0100, Takashi Iwai wrote:
> > We have a common loop of encoder to look for the given audio port in
> > two audio component functions. Split out a local helper function to
>
On Mon, 30 Nov 2015 16:24:41 +0100,
Ville Syrjälä wrote:
>
> On Mon, Nov 30, 2015 at 02:37:46PM +0100, Takashi Iwai wrote:
> > Implement a new i915_audio_component_ops, get_eld(). It's called by
> > the audio driver to fetch the current ELD of the given HDMI/DP port.
>
On Mon, 30 Nov 2015 16:34:22 +0100,
David Henningsson wrote:
>
>
>
> On 2015-11-30 16:29, Takashi Iwai wrote:
> > On Mon, 30 Nov 2015 16:24:41 +0100,
> > Ville Syrjälä wrote:
> >>
> >> On Mon, Nov 30, 2015 at 02:37:46PM +0100, Takashi Iwai wrote:
>
On Mon, 30 Nov 2015 15:17:05 +0100,
Daniel Vetter wrote:
>
> On Mon, Nov 30, 2015 at 03:11:16PM +0100, Daniel Vetter wrote:
> > On Mon, Nov 30, 2015 at 02:37:46PM +0100, Takashi Iwai wrote:
> > > diff --git a/include/drm/i915_component.h b/include/drm/i915_component.h
>
On Mon, 30 Nov 2015 17:00:33 +0100,
Vinod Koul wrote:
>
> On Mon, Nov 30, 2015 at 02:37:48PM +0100, Takashi Iwai wrote:
> >
> > +/* update per_pin ELD from the given new ELD;
> > + * setup info frame and notification accordingly
> > + */
>
> nitpick, comm
On Mon, 30 Nov 2015 17:42:33 +0100,
Vinod Koul wrote:
>
> On Mon, Nov 30, 2015 at 02:37:49PM +0100, Takashi Iwai wrote:
> > Since we have a new audio component ops to fetch the current ELD and
> > state now, we can reduce the usage of unsol event of HDMI/DP pins.
> > Th
On Mon, 30 Nov 2015 17:09:33 +0100,
Ville Syrjälä wrote:
>
> On Mon, Nov 30, 2015 at 05:24:41PM +0200, Ville Syrjälä wrote:
> > On Mon, Nov 30, 2015 at 02:37:46PM +0100, Takashi Iwai wrote:
> > > Implement a new i915_audio_component_ops, get_eld(). It's called by
>
For achieving this implementation, a new field audio_enabled is added
to struct intel_digital_port. This is set/reset at each audio
enable/disable call in intel_audio.c. It's protected with the modeset
lock as well.
Signed-off-by: Takashi Iwai
---
v1->v2:
* Use modeset lock for get_eld lock
This is a preliminary patch for the later change to support ELD/jack
handling with i915 audio component. This splits the ELD update code
from hdmi_present_sense() so that it can be called from other places.
Just a code refactoring, no functional change.
Signed-off-by: Takashi Iwai
---
sound
This patch adds a reverse mapping from a digital port number to
intel_encoder object containing the corresponding intel_digital_port.
It simplifies the query of the encoder a lot.
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/i915_drv.h| 2 ++
drivers/gpu/drm/i915/intel_audio.c | 22
oll_count (with the
direct access to the graphics driver, we need really no repoll, in
anyway).
Signed-off-by: Takashi Iwai
---
v1->v2:
* Deferred invocation of get_eld from the eld_notify in HDA side
* A bit more code refactoring
sound/pci/hda/patch_hdmi.c | 133 ++
se map from a port number to the encoder
* Deferred invocation of get_eld from the eld_notify in HDA side
* A bit more code refactoring in HDA side
* Move audio component accessors to hdac_i915.c
Takashi Iwai (9):
drm/i915: Remove superfluous NULL check
drm/i915: Add get_eld audio compone
to_intel_crtc() always returns a non-NULL pointer.
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/intel_audio.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c
b/drivers/gpu/drm/i915/intel_audio.c
index 4dccd9b003a1..0c38cc6c82ae 100644
--- a
, we can skip it when received during PM
process.
Signed-off-by: Takashi Iwai
---
sound/pci/hda/patch_hdmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 4dc21ecf7230..75815acb77db 100644
--- a/sound/pci/hda/patch_hdmi.c
Instead of doing in each caller side, snd_hdmi_parse_eld() does
zero-clear of the parsed data by itself. This is safer and simplifies
the code.
Signed-off-by: Takashi Iwai
---
sound/pci/hda/hda_eld.c| 1 +
sound/pci/hda/patch_hdmi.c | 2 --
2 files changed, 1 insertion(+), 2 deletions
We have a common loop of encoder to look for the given audio port in
two audio component functions. Split out a local helper function to
do it for the code simplification.
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/intel_audio.c | 61 --
1 file
mapping is also moved to hdac_i915.c, so that it can be fixed /
enhanced more cleanly.
Signed-off-by: Takashi Iwai
---
include/sound/hda_i915.h | 14 ++
sound/hda/hdac_i915.c | 66
sound/pci/hda/patch_hdmi.c | 69
On Tue, 01 Dec 2015 17:09:57 +0100,
Takashi Iwai wrote:
>
> The ELD notification can be received asynchronously from the graphics
> side, and this may happen just at the moment the sound driver is
> processing the suspend or the resume, and it would confuse the whole
> procedure.
Hi,
I've experienced a few graphics issues recently, and I tend to believe
that it has happened since 4.4-rc. Namely, after some long time usage
on my HSW laptop (two or three days), the mouse cursor vanished
suddenly. It kept pointing but just became invisible. Also, after
some S3 cycles, some
On Thu, 03 Dec 2015 21:33:29 +0100,
Ville Syrjälä wrote:
>
> On Thu, Dec 03, 2015 at 09:00:55PM +0100, Takashi Iwai wrote:
> > Hi,
> >
> > I've experienced a few graphics issues recently, and I tend to believe
> > that it has happened since 4.4-rc. Namely, a
On Fri, 04 Dec 2015 11:21:02 +0100,
Daniel Vetter wrote:
>
> On Tue, Dec 01, 2015 at 05:09:51PM +0100, Takashi Iwai wrote:
> > Implement a new i915_audio_component_ops, get_eld(). It's called by
> > the audio driver to fetch the current audio status and ELD of the
>
On Fri, 04 Dec 2015 13:10:01 +0100,
Ville Syrjälä wrote:
>
> On Fri, Dec 04, 2015 at 11:49:46AM +0100, Takashi Iwai wrote:
> > On Fri, 04 Dec 2015 11:21:02 +0100,
> > Daniel Vetter wrote:
> > >
> > > On Tue, Dec 01, 2015 at 05:09:51PM +0100, Takashi
On Fri, 04 Dec 2015 13:16:46 +0100,
Ville Syrjälä wrote:
>
> On Tue, Dec 01, 2015 at 05:09:50PM +0100, Takashi Iwai wrote:
> > to_intel_crtc() always returns a non-NULL pointer.
>
> Eh? to_intel_crtc(NULL) should return NULL or we might have tons of
> breakage on our hands
On Fri, 04 Dec 2015 14:07:03 +0100,
Ville Syrjälä wrote:
>
> On Fri, Dec 04, 2015 at 01:54:56PM +0100, Takashi Iwai wrote:
> > On Fri, 04 Dec 2015 13:16:46 +0100,
> > Ville Syrjälä wrote:
> > >
> > > On Tue, Dec 01, 2015 at 05:09:50PM +0100, Takashi Iwai w
On Tue, 01 Dec 2015 17:09:53 +0100,
Takashi Iwai wrote:
>
> This patch adds a reverse mapping from a digital port number to
> intel_encoder object containing the corresponding intel_digital_port.
> It simplifies the query of the encoder a lot.
While this is good for a code reduct
On Fri, 04 Dec 2015 16:02:29 +0100,
Daniel Vetter wrote:
>
> On Fri, Dec 04, 2015 at 03:40:03PM +0100, Takashi Iwai wrote:
> > On Tue, 01 Dec 2015 17:09:53 +0100,
> > Takashi Iwai wrote:
> > >
> > > This patch adds a reverse mapping from a digital port
On Fri, 04 Dec 2015 16:00:46 +0100,
Daniel Vetter wrote:
>
> On Fri, Dec 04, 2015 at 11:49:46AM +0100, Takashi Iwai wrote:
> > On Fri, 04 Dec 2015 11:21:02 +0100,
> > Daniel Vetter wrote:
> > >
> > > On Tue, Dec 01, 2015 at 05:09:51PM +0100, Takashi
On Fri, 04 Dec 2015 16:53:02 +0100,
Daniel Vetter wrote:
>
> On Fri, Dec 04, 2015 at 04:15:24PM +0100, Takashi Iwai wrote:
> > On Fri, 04 Dec 2015 16:00:46 +0100,
> > Daniel Vetter wrote:
> > >
> > > On Fri, Dec 04, 2015 at 11:49:46AM +0100, Takashi Iwai wrot
On Fri, 04 Dec 2015 16:54:32 +0100,
Daniel Vetter wrote:
>
> On Fri, Dec 04, 2015 at 04:15:24PM +0100, Takashi Iwai wrote:
> > diff --git a/include/drm/i915_component.h b/include/drm/i915_component.h
> > index 30d89e0da2c6..058d39e8d57f 100644
> > --- a/include/drm/i9
thing to do in all cases.
>
> The noticeable effect other than the debug messages would be an increase
> in the suspend time. I have not measure how expensive it actually is.
>
> I think it would be good to spend further time to root cause why we're
>
On Fri, 04 Dec 2015 17:15:59 +0100,
Daniel Vetter wrote:
>
> On Fri, Dec 04, 2015 at 05:03:55PM +0100, Takashi Iwai wrote:
> > On Fri, 04 Dec 2015 16:54:32 +0100,
> > Daniel Vetter wrote:
> > >
> > > On Fri, Dec 04, 2015 at 04:15:24PM +0100, Takashi Iwai wro
On Fri, 04 Dec 2015 17:20:15 +0100,
Takashi Iwai wrote:
>
> On Fri, 04 Dec 2015 17:15:59 +0100,
> Daniel Vetter wrote:
> >
> > On Fri, Dec 04, 2015 at 05:03:55PM +0100, Takashi Iwai wrote:
> > > On Fri, 04 Dec 2015 16:54:32 +0100,
> > > Daniel Vetter wrote
On Fri, 04 Dec 2015 17:49:43 +0100,
Daniel Vetter wrote:
>
> On Fri, Dec 04, 2015 at 05:27:12PM +0100, Takashi Iwai wrote:
> > On Fri, 04 Dec 2015 17:20:15 +0100,
> > Takashi Iwai wrote:
> > >
> > > On Fri, 04 Dec 2015 17:15:59 +0100,
> > > Daniel
This patch adds a reverse mapping from a digital port number to
intel_encoder object containing the corresponding intel_digital_port.
It simplifies the query of the encoder a lot.
Signed-off-by: Takashi Iwai
---
v2->v3:
* Squashed previously two cleanup patches to a single patch
drivers/
mutex
* Return the expected size from get_eld, not the copied size
* Add reverse map from a port number to the encoder
* Deferred invocation of get_eld from the eld_notify in HDA side
* A bit more code refactoring in HDA side
* Move audio component accessors to hdac_i915.c
Takashi Iwai (4):
drm/i91
added to struct intel_digital_port. It points to the connector
assigned to the given digital port. It's set/reset at each audio
enable/disable call in intel_audio.c, and protected with av_mutex.
Signed-off-by: Takashi Iwai
---
v2->v3:
* Track drm_connector for easier ELD retrieval, remove supe
cally designed for the pin sense read and
unsol events, both of which aren't used any longer in our case.
Signed-off-by: Takashi Iwai
---
v2->v3:
* Adapt the earlier applied preliminary patches
* Direct invocation of get_eld now instead of deferred call, as we
have no longer deadlocks
mapping is also moved to hdac_i915.c, so that it can be fixed /
enhanced more cleanly.
Signed-off-by: Takashi Iwai
---
include/sound/hda_i915.h | 14 ++
sound/hda/hdac_i915.c | 66
sound/pci/hda/patch_hdmi.c | 69
On Mon, 07 Dec 2015 09:44:45 +0100,
Daniel Vetter wrote:
>
> On Fri, Dec 04, 2015 at 06:12:47PM +0100, Takashi Iwai wrote:
> > This patch adds a reverse mapping from a digital port number to
> > intel_encoder object containing the corresponding intel_digital_port.
> > It
On Mon, 07 Dec 2015 11:30:05 +0100,
Jani Nikula wrote:
>
> On Fri, 04 Dec 2015, Takashi Iwai wrote:
> > This patch adds a reverse mapping from a digital port number to
> > intel_encoder object containing the corresponding intel_digital_port.
> > It simplifies the qu
On Thu, 03 Dec 2015 22:25:48 +0100,
Ville Syrjälä wrote:
>
> On Thu, Dec 03, 2015 at 10:08:05PM +0100, Takashi Iwai wrote:
> > On Thu, 03 Dec 2015 21:33:29 +0100,
> > Ville Syrjälä wrote:
> > >
> > > On Thu, Dec 03, 2015 at 09:00:55PM +0100, Takashi Iwai wrot
On Mon, 07 Dec 2015 10:41:51 +0100,
Takashi Iwai wrote:
>
> On Mon, 07 Dec 2015 09:44:45 +0100,
> Daniel Vetter wrote:
> >
> > On Fri, Dec 04, 2015 at 06:12:47PM +0100, Takashi Iwai wrote:
> > > This patch adds a reverse mapping from a digital port number to
> &g
On Thu, 10 Dec 2015 10:38:14 +0100,
Daniel Vetter wrote:
>
> On Tue, Dec 08, 2015 at 06:42:09PM +0100, Takashi Iwai wrote:
> > On Mon, 07 Dec 2015 10:41:51 +0100,
> > Takashi Iwai wrote:
> > >
> > > On Mon, 07 Dec 2015 09:44:45 +0100,
> > > Daniel
ranch.
----
Takashi Iwai (2):
drm/i915: Add get_eld audio component
drm/i915: Add reverse mapping between port and intel_encoder
---
drivers/gpu/drm/i915/i915_drv.h| 2 +
drivers/gpu/drm/i915/intel_audio.c
On Thu, 10 Dec 2015 17:36:04 +0100,
Ville Syrjälä wrote:
>
> On Fri, Dec 04, 2015 at 04:05:26PM +, Chris Wilson wrote:
> > A long time ago (before 3.14) we relied on a permanent pinning of the
> > ifbdev to lock the fb in place inside the GGTT. However, the
> > introduction of stealing the BIO
On Fri, 11 Dec 2015 07:07:53 +0100,
Libin Yang wrote:
>
> >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c
> >>> b/drivers/gpu/drm/i915/intel_audio.c
> >>> index 9aa83e7..5ad2e66 100644
> >>> --- a/drivers/gpu/drm/i915/intel_audio.c
> >>> +++ b/drivers/gpu/drm/i915/intel_audio.c
> >>> @@ -262,
On Fri, 11 Dec 2015 11:43:51 +0100,
Takashi Iwai wrote:
>
> On Fri, 11 Dec 2015 07:07:53 +0100,
> Libin Yang wrote:
> >
> > >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c
> > >>> b/drivers/gpu/drm/i915/intel_audio.c
> > >>> inde
On Fri, 11 Dec 2015 07:07:53 +0100,
Libin Yang wrote:
>
> Add Takashi and ALSA mail list.
>
> On 12/10/2015 05:02 PM, Daniel Vetter wrote:
> > On Tue, Dec 08, 2015 at 04:01:20PM +0800, Libin Yang wrote:
> >> Hi all,
> >>
> >> Any comments on the patches?
> >
> > Sorry, simply fell through the cra
101 - 200 of 615 matches
Mail list logo
