On 29/06/2015 15:29, Mika Kuoppala wrote:
Nick Hoath writes:
Add stepping check for A0 workarounds, and remove the associated
FIXME tags.
Split out unrelated WAs for later condition checking.
v2: Fixed format (PeterL)
v3: Corrected stepping check for WaDisableSDEUnitClockGating
ebase breakage. Put context pinning in separate
function. Removed code churn. (Thomas Daniel)
Issue: VIZ-4798
Signed-off-by: Nick Hoath
Cc: Daniel Vetter
Cc: Chris Wilson
Cc: John Harrison
Cc: David Gordon
Cc: Thomas Daniel
---
drivers/gpu/drm/i915/i915_drv.h| 1 -
d
ebase breakage. Put context pinning in separate
function. Removed code churn. (Thomas Daniel)
v6: Cleanup up issues introduced in v2 & v5 (Thomas Daniel)
Issue: VIZ-4798
Signed-off-by: Nick Hoath
Cc: Daniel Vetter
Cc: Chris Wilson
Cc: John Harrison
Cc: David Gordon
Cc: Thomas Danie
Remove extraneous request cancel in request allocation failure path
in intel_lr_context_deferred_alloc (Tvrtko Ursulin)
Signed-off-by: Nick Hoath
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/intel_lrc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b
On 29/04/2015 15:35, Deak, Imre wrote:
On pe, 2015-03-20 at 09:29 +, Nick Hoath wrote:
This stepping isn't listed separately in the specs, so needs confirmation.
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/dr
On 29/04/2015 13:26, Deak, Imre wrote:
On pe, 2015-04-10 at 13:12 +0100, Nick Hoath wrote:
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_ringbuffer.c | 7 +++
2 files changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i915
On 05/05/2015 17:18, Deak, Imre wrote:
On ti, 2015-05-05 at 15:20 +0100, Nick Hoath wrote:
On 29/04/2015 15:35, Deak, Imre wrote:
On pe, 2015-03-20 at 09:29 +, Nick Hoath wrote:
This stepping isn't listed separately in the specs, so needs confirmation.
Signed-off-by: Nick
On 29/04/2015 14:02, Deak, Imre wrote:
On pe, 2015-04-10 at 13:12 +0100, Nick Hoath wrote:
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
b/drivers/gpu/drm/i915
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 49e4610..cdbdf49 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 3f1a784..ac1ad44 100644
--- a/drivers/gpu/drm/i915
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
b/drivers/gpu/drm/i915/intel_ringbuffer.c
index cdbdf49..3f1a784 100644
--- a/drivers/gpu/drm/i915
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 7ef9a29..49e4610 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
. (Imre)
Cleaned up revision ID usage (Imre)
Nick Hoath (9):
drm/i915/bxt: Mark WaDisablePartialInstShootdown as for Broxton also.
drm/i915/bxt: Mark workaround as for Skylake & Broxton
drm/i915/bxt: Enable WaDisableDgMirrorFixInHalfSliceChicken5 for
Broxton
drm/i915/bxt: En
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
b/drivers/gpu/drm/i915/intel_ringbuffer.c
index e5c9f9a..001343f 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
b/drivers/gpu/drm/i915/intel_ringbuffer.c
index dec0e74..cf36c6b 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 076d3e5..dec0e74 100644
--- a/drivers/gpu
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
b/drivers/gpu/drm/i915/intel_ringbuffer.c
index ac1ad44..076d3e5 100644
--- a/drivers/gpu/drm/i915
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
b/drivers/gpu/drm/i915/intel_ringbuffer.c
index cf36c6b..e5c9f9a 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
Implement WaBarrierPerformanceFixDisable
The workaround ended up in the chv workarounds. Not sure what the reason or
history of that is, but it /seems/ wrong. Don't know if this fixes anything
patch doesn't always get it right...
Reviewed-by: Nick Hoath
since I have many other problems with my platform.
Cc
Where there were duplicate variables for the tail, context and ring (engine)
in the gem request and the execlist queue item, use the one from the request
and remove the duplicate from the execlist queue item.
Issue: VIZ-4274
v1: Rebase
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915
Move all remaining elements that were unique to execlists queue items
in to the associated request.
Issue: VIZ-4274
v2: Rebase. Fixed issue of overzealous freeing of request.
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_debugfs.c | 8 +++
drivers/gpu/drm/i915/i915_drv.h
: Integrate this changeset with the removal of duplicate request/execlist
queue item members.
v3: Rebase
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_gem.c | 7 ++--
drivers/gpu/drm/i915/intel_lrc.c| 68 -
drivers/gpu/drm/i915/intel_lrc.h
it_request and drm_i915_gem_request, rebase changes &
add cover letter
v3: Rebase over upstreamed "Replace seqno values with request structures" and
add overzealous freeing fix.
Issue: VIZ-4274
Nick Hoath (4):
drm/i915: execlist request keeps ptr/ref to gem_request
drm/i915: R
Add a reference and pointer from the execlist queue item to the associated
gem request. For execlist requests that don't have a request, create one
as a placeholder.
Issue: VIZ-4274
v1: Rebase after upstream of "Replace seqno values with request structures"
patchset.
Signed-off
Where there were duplicate variables for the tail, context and ring (engine)
in the gem request and the execlist queue item, use the one from the request
and remove the duplicate from the execlist queue item.
Issue: VIZ-4274
v1: Rebase
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915
it_request and drm_i915_gem_request, rebase changes &
add cover letter
v3: Rebase over upstreamed "Replace seqno values with request structures" and
add overzealous freeing fix.
v4: Removed re-addition of cleanup work queue (found by Daniel Vetter)
Issue: VIZ-4274
Nick Hoath (
: Integrate this changeset with the removal of duplicate request/execlist
queue item members.
v3: Rebase
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_gem.c | 7 ++--
drivers/gpu/drm/i915/intel_lrc.c| 68 -
drivers/gpu/drm/i915/intel_lrc.h
Move all remaining elements that were unique to execlists queue items
in to the associated request.
Issue: VIZ-4274
v2: Rebase. Fixed issue of overzealous freeing of request.
v3: Removed re-addition of cleanup work queue (found by Daniel Vetter)
Signed-off-by: Nick Hoath
---
drivers/gpu/drm
Add a reference and pointer from the execlist queue item to the associated
gem request. For execlist requests that don't have a request, create one
as a placeholder.
Issue: VIZ-4274
v1: Rebase after upstream of "Replace seqno values with request structures"
patchset.
Signed-off
Add a reference and pointer from the execlist queue item to the associated
gem request. For execlist requests that don't have a request, create one
as a placeholder.
Issue: VIZ-4274
v1: Rebase after upstream of "Replace seqno values with request structures"
patchset.
Signed-off
: Integrate this changeset with the removal of duplicate request/execlist
queue item members.
v3: Rebase
v4: Rebase. Remove passing of context when the request is passed.
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_gem.c | 5 +--
drivers/gpu/drm/i915/intel_lrc.c| 67
patch (0002). Separated out the tail pointer
from the postfix pointer (found by Thomas Daniel)
v6: Actual removal of intel_ctx_submit_request. Update both tail and postfix
pointer in __i915_add_request (found by Thomas Daniel)
Nick Hoath (4):
drm/i915: execlist request keeps ptr/ref to gem_req
tail pointers as these are
used in different ways. Reinserted missing full tail pointer update.
Signed-off-by: Nick Hoath
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
drivers/gpu/drm/i915/i915_drv.h | 9 -
drivers/gpu/drm/i915/i915_gem.c
intel_ctx_submit_request. Update both tail and postfix
pointer in __i915_add_request (found by Thomas Daniel)
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_debugfs.c | 8 +++
drivers/gpu/drm/i915/i915_drv.h | 21 +
drivers/gpu/drm/i915/i915_gem.c | 12 +-
drivers
patch (0002). Separated out the tail pointer
from the postfix pointer (found by Thomas Daniel)
v6: Actual removal of intel_ctx_submit_request. Update both tail and postfix
pointer in __i915_add_request (found by Thomas Daniel)
v7: Removed unrelated changes
Nick Hoath (4):
drm/i915: execlist
Add a reference and pointer from the execlist queue item to the associated
gem request. For execlist requests that don't have a request, create one
as a placeholder.
Issue: VIZ-4274
v1: Rebase after upstream of "Replace seqno values with request structures"
patchset.
Signed-off
tail pointers as these are
used in different ways. Reinserted missing full tail pointer update.
Signed-off-by: Nick Hoath
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
drivers/gpu/drm/i915/i915_drv.h | 9 -
drivers/gpu/drm/i915/i915_gem.c
intel_ctx_submit_request. Update both tail and postfix
pointer in __i915_add_request (found by Thomas Daniel)
v6: Removed unrelated changes
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_debugfs.c | 8 +++
drivers/gpu/drm/i915/i915_drv.h | 21 +
drivers/gpu/drm/i915/i915_gem.c
: Integrate this changeset with the removal of duplicate request/execlist
queue item members.
v3: Rebase
v4: Rebase. Remove passing of context when the request is passed.
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_gem.c | 5 +--
drivers/gpu/drm/i915/intel_lrc.c| 67
Remove request from list before unreferencing it, in case it's actually
the only reference. (Found by Tvrtko Ursulin)
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_lrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/driver
On 30/01/2015 16:33, Daniel Vetter wrote:
On Fri, Jan 30, 2015 at 11:01:30AM +0200, Mika Kuoppala wrote:
Nick Hoath writes:
Remove request from list before unreferencing it, in case it's actually
the only reference. (Found by Tvrtko Ursulin)
Signed-off-by: Nick Hoath
Do we h
From: "Hoath, Nicholas"
Move Wa4x4STCOptimizationDisable to gen9_init_workarounds
v1: rebase
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_pm.c | 4
drivers/gpu/drm/i915/intel_ringbuffer.c | 3 +++
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git
Move WaDisableDgMirrorFixInHalfSliceChicken5 to gen9_init_workarounds
v1: Added stepping check
v2: Removed unused register bitmap
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_pm.c | 8
drivers/gpu/drm/i915/intel_ringbuffer.c | 10 ++
2 files changed, 10
From: "Hoath, Nicholas"
Add:
WaEnableForceRestoreInCtxtDescForVCS
v1: Add stepping check.
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_lrc.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drive
From: "Hoath, Nicholas"
Add framework for gen 9 HW WAs
v1: Changed SOC specific WA function to gen 9 common function (Req: Damien
Lespiau)
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gp
Move WaEnableYV12BugFixInHalfSliceChicken7 to gen9_init_workarounds
v1: Add stepping check.
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_reg.h | 3 +++
drivers/gpu/drm/i915/intel_ringbuffer.c | 6 ++
2 files changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915
From: "Hoath, Nicholas"
Add:
WaDisablePartialInstShootdown
v1: Dont add WaDisableThreadStallDopClockGating as not SKL WA. (Found by Damien
Lespiau)
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/d
From: "Hoath, Nicholas"
Add Skylake stepping Revision IDs definitions.
v1: Use existing revision id.
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_drv.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_d
9 h/w w/a (Wa4x4STCOptimizationDisable)
drm/i915: gen 9 h/w w/a (WaForceEnableNonCoherent)
drm/i915: gen 9 h/w w/a (WaEnableForceRestoreInCtxtDescForVCS)
Nick Hoath (3):
drm/i915: gen 9 h/w w/a (WaDisableDgMirrorFixInHalfSliceChicken5)
drm/i915: gen 9 h/w w/a (syncing dependencies between
Added:
Syncing dependencies between camera and graphics
v1: Added missing register bitmap
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_ringbuffer.c | 4
2 files changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h
From: "Hoath, Nicholas"
Add:
WaForceEnableNonCoherent
v1: Don't add WaHdcDisableFetchWhenMasked. Add stepping check for
WaForceEnableNonCoherent
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 11 +++
1 file changed, 11 insertions(+)
diff --gi
From: "Hoath, Nicholas"
Add stepping check for WaDisableSDEUnitClockGating.
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_pm.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_
On 06/02/2015 08:52, Daniel Vetter wrote:
On Thu, Feb 05, 2015 at 05:51:46PM +, Damien Lespiau wrote:
On Thu, Feb 05, 2015 at 10:47:18AM +, Nick Hoath wrote:
From: "Hoath, Nicholas"
Add:
WaDisablePartialInstShootdown
Just an editor note: that's not really additio
Add:
WaEnableForceRestoreInCtxtDescForVCS
v2: Add stepping check.
v3: Fixed stepping check direction. Cleaned up indentation.
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_lrc.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm
Fixed the stepping check on WaDisableDgMirrorFixInHalfSliceChicken5
to be for the correct SOC (Skylake)
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
b/drivers
Fix stepping check on WaDisableDgMirrorFixInHalfSliceChicken5, and
clean up WaEnableForceRestoreInCtxtDescForVCS patch.
Nick Hoath (2):
drm/i915: gen 9 h/w w/a Fix stepping check
drm/i915: gen 9 h/w w/a (WaEnableForceRestoreInCtxtDescForVCS)
drivers/gpu/drm/i915/intel_lrc.c| 15
On 09/02/2015 19:33, Damien Lespiau wrote:
When enabling new platforms, we may not have any W/A to apply,
especially that, now, a bunch of them have to be done from the ring.
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_pm.c | 3 ++-
1 file
On 09/02/2015 19:33, Damien Lespiau wrote:
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_dp.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index d4c82d7..4a60c6a 100644
--- a/drivers/gp
On 09/02/2015 19:33, Damien Lespiau wrote:
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_pm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index a3b979d..6fd6f26 100644
On 09/02/2015 19:33, Damien Lespiau wrote:
We'll gather cross-gen9 W/A in a separate function later.
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm
On 09/02/2015 19:33, Damien Lespiau wrote:
Let's also take the opportunity the remove the comment telling it's a
pre-prod W/A, it should be obvious from the stepping test.
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drive
On 09/02/2015 19:33, Damien Lespiau wrote:
WaDisableAsyncFlipPerfMode isn't listed for SKL and
INSTPM_FORCE_ORDERING is MBZ so let's make a gen9 specific render init
function.
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_
On 09/02/2015 19:33, Damien Lespiau wrote:
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_uncore.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/intel_uncore.c
b/drivers/gpu/drm/i915/intel_uncore.c
index c47a3ba..ad71575
On 09/02/2015 19:33, Damien Lespiau wrote:
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_pm.c | 4
2 files changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 2043e82..a457c2
On 09/02/2015 19:33, Damien Lespiau wrote:
This function will host SKL-only W/As.
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915
On 09/02/2015 19:33, Damien Lespiau wrote:
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_reg.h | 5 +++--
drivers/gpu/drm/i915/intel_ringbuffer.c | 8
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/
On 09/02/2015 19:33, Damien Lespiau wrote:
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_ringbuffer.c | 3 +++
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers
On 09/02/2015 19:33, Damien Lespiau wrote:
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_reg.h | 3 +++
drivers/gpu/drm/i915/intel_pm.c | 5 +
3 files changed, 9 insertions(+)
diff --git a/drivers/gpu
On 09/02/2015 19:33, Damien Lespiau wrote:
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_pm.c | 6 ++
2 files changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915
On 09/02/2015 19:33, Damien Lespiau wrote:
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_reg.h | 3 +++
drivers/gpu/drm/i915/intel_pm.c | 7 ++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b
On 09/02/2015 19:33, Damien Lespiau wrote:
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_ringbuffer.c | 4
2 files changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers
On 09/02/2015 19:33, Damien Lespiau wrote:
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_ringbuffer.c | 7 +++
2 files changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88652
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
drivers/gpu/drm/i915/i915_gem.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915
On 09/02/2015 19:33, Damien Lespiau wrote:
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_reg.h | 4
drivers/gpu/drm/i915/intel_ringbuffer.c | 8
2 files changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b
27;((->dev->pdev->revision) >= (0)) => (0-255 >= 0)'
That's because revision is a u8. Tweak a bit the condition then.
Cc: Nick Hoath
Signed-off-by: Damien Lespiau
A bit contrived :) but:
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 4 ++-
On 11/02/2015 18:21, Lespiau, Damien wrote:
I have no idea how that crept in, but we need to do the write from the
ring and this is a masked register. Two fixes in 1!
Cc: Nick Hoath
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 10
On 09/02/2015 19:33, Damien Lespiau wrote:
This W/A is put in a gen9 specific function because it may well be
needed on other gen9 platforms.
Signed-off-by: Damien Lespiau
Reviewed-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_reg.h | 3 +++
drivers/gpu/drm/i915/intel_pm.c | 11
On 13/02/2015 09:32, Daniel Vetter wrote:
On Thu, Feb 12, 2015 at 12:29:21PM +, Nick Hoath wrote:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88652
Signed-off-by: Nick Hoath
Commit message is missing the absolutely crucial detail about which patch
introduced this regression
place the free's.
Problem introduced in:
commit 6d3d8274bc45de4babb62d64562d92af984dd238
Author: Nick Hoath
AuthorDate: Thu Jan 15 13:10:39 2015 +
drm/i915: Subsume intel_ctx_submit_request in to drm_i915_gem_request
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i
On 11/02/2015 17:48, Lespiau, Damien wrote:
On Wed, Feb 11, 2015 at 03:29:51PM +, Nick Hoath wrote:
On 09/02/2015 19:33, Damien Lespiau wrote:
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_reg.h | 5 +++--
drivers/gpu/drm/i915/intel_ringbuffer.c | 8
2
context's reference count should be bumped using i915_gem_context_reference.
i915_gem_request_reference will reduce the context reference count when
the request is freed.
Problem introduced in:
commit 6d3d8274bc45de4babb62d64562d92af984dd238
Author: Nick Hoath
AuthorDate: Thu Jan 15 13:10
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_reg.h | 3 +++
drivers/gpu/drm/i915/intel_pm.c | 10 ++
2 files changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 39bdbf9..7f9150b 100644
--- a/drivers/gpu/drm/i915
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_dma.c | 4 +++-
drivers/gpu/drm/i915/i915_gem.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index 5804aa5..df9a3a5 100644
--- a/drivers/gpu/drm
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 7f9150b..0326399 100644
--- a/drivers/gpu/drm/i915
Nick Hoath (3):
drm/i915: gen 9 h/w w/a (Wa32bitGeneralStateOffset &
Wa32bitInstructionBaseOffset)
drm/i915: gen 9 h/w w/a (WaDisablePooledEuLoadBalancingFix)
Signed-off-by: Nick Hoath
gen 9 h/w w/a (WaClearFlowControlGpgpuContextSave) Signed-off-by:
Nick H
On 19/02/2015 11:23, Gordon, David S wrote:
On 18/02/15 14:01, Nick Hoath wrote:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88652
When converting from implicitly tracked execlist queue items to ref counted
requests, not all frees of requests were replaced with unrefs, and
context's reference count should be bumped using i915_gem_context_reference.
i915_gem_request_reference will reduce the context reference count when
the request is freed.
Problem introduced in
commit 6d3d8274bc45de4babb62d64562d92af984dd238
Author: Nick Hoath
AuthorDate: Thu Jan 15 13:10
This set of patches cleans up a number of issues that
were pushed out in the initial execlist submission.
Nick Hoath (5):
drm/i915: Clean up gen8 irq handler
drm/i915: Unify execlist and legacy request life-cycles
drm/i915: Simplify runtime_pm reference for execlists
drm/i915: Reorder
intel_lr_context_deferred_alloc, to reflect reduced functionality.
Issue: VIZ-4798
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_drv.h| 1 -
drivers/gpu/drm/i915/i915_gem.c| 41
drivers/gpu/drm/i915/i915_gem_context.c| 21 --
drivers/gpu/drm/i915
() is called when
contexts complete as well as when a user interrupt occurs so that
notification happens when a request is complete and context save has
finished.
v2: Rebase over the read-read optimisation changes
Signed-off-by: Thomas Daniel
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915
Moved common code handling command streamer interrupts into a function.
Renamed tmp variable to the more descriptive iir.
Signed-off-by: Thomas Daniel
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_irq.c | 68 +
1 file changed, 35 insertions
Issue: VIZ-4798
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/intel_lrc.c | 86
1 file changed, 43 insertions(+), 43 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index adc4942..770a6f6 100644
--- a
No longer take a runtime_pm reference for each execlist request. Only
take a single reference when the execlist queue becomes nonempty and
release it when it becomes empty.
Signed-off-by: Thomas Daniel
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_gem.c | 10 +++---
drivers/gpu
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_pm.c | 4
3 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 709b3c7
v2: Patch leakage fixed
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_pm.c | 4
3 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 059de0f..afa8972 100644
On 09/07/2015 12:12, Chris Wilson wrote:
On Thu, Jul 09, 2015 at 11:57:41AM +0100, Nick Hoath wrote:
There is a desire to simplify the i915 driver by reducing the number of
different code paths introduced by the LRC / execlists support. As the
execlists request is now part of the gem request
On 09/07/2015 12:14, Chris Wilson wrote:
On Thu, Jul 09, 2015 at 11:57:42AM +0100, Nick Hoath wrote:
No longer take a runtime_pm reference for each execlist request. Only
take a single reference when the execlist queue becomes nonempty and
release it when it becomes empty.
Nak. We already
intel_lr_context_deferred_alloc, to reflect reduced functionality.
Issue: VIZ-4798
Signed-off-by: Nick Hoath
---
drivers/gpu/drm/i915/i915_drv.h| 1 -
drivers/gpu/drm/i915/i915_gem.c| 23 ++---
drivers/gpu/drm/i915/i915_gem_context.c| 21 -
drivers/gpu/drm/i915
On 07/08/2015 11:13, Chris Wilson wrote:
On Fri, Aug 07, 2015 at 11:05:24AM +0100, Nick Hoath wrote:
Clean up lrc context init by:
- Move context initialisation in to i915_gem_init_hw
- Move one off initialisation for render ring to
i915_gem_validate_context
- Move default
Left ->init_context int intel_lr_context_deferred_alloc (Daniel Vetter)
Remove unnecessary init flag & ring type test. (Daniel Vetter)
Improve commit message (Daniel Vetter)
Issue: VIZ-4798
Signed-off-by: Nick Hoath
Cc: Daniel Vetter
---
drivers/gpu/drm/i915/i915_drv.h|
101 - 200 of 203 matches
Mail list logo
