[PATCH v2] drm/i915/psr: Add PSR pause/resume reference count

2025-03-28 Thread Jouni Högander
We have now seen this: <4> [2120.434153] i915 :00:02.0: [drm] drm_WARN_ON(psr->paused) <4> [2120.434196] WARNING: CPU: 3 PID: 4430 at drivers/gpu/drm/i915/display/intel_psr.c:2227 intel_psr_pause+0x16e/0x180 [i915] Comment for drm_WARN_ON(display->drm, psr->paused) in intel_psr_pause says:

Re: [PATCH] drm/i915/gem: Convert SPDX headers to single-line format

2025-03-28 Thread Mikolaj Wasiak
Hi Andi, Consider also changing the SPDX licence header in gem/selftests as currently we have there mix of oneliners and multiliners. Mikołaj

✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: Add PSR pause/resume reference count (rev3)

2025-03-28 Thread Patchwork
== Series Details == Series: drm/i915/psr: Add PSR pause/resume reference count (rev3) URL : https://patchwork.freedesktop.org/series/146286/ State : warning == Summary == Error: dim checkpatch failed eded8337ed9f drm/i915/psr: Add PSR pause/resume reference count -:12: WARNING:COMMIT_LOG_LONG

RE: [PATCH] drm/i915/gem: Convert SPDX headers to single-line format

2025-03-28 Thread Gote, Nitin R
Hi Andi, > -Original Message- > From: Intel-gfx On Behalf Of Andi > Shyti > Sent: Friday, March 28, 2025 4:56 AM > To: intel-gfx ; dri-devel de...@lists.freedesktop.org> > Cc: Tvrtko Ursulin ; Joonas Lahtinen > ; Andi Shyti ; > Andi > Shyti > Subject: [PATCH] drm/i915/gem: Convert SPD

[PATCH v10 2/4] drm/plane: modify create_in_formats to acommodate async

2025-03-28 Thread Arun R Murthy
create_in_formats creates the list of supported format/modifiers for synchronous flips, modify the same function so as to take the format_mod_supported as argument and create list of format/modifier for async as well. v5: create_in_formats can return -ve value in failure case, correct the if condi

✓ i915.CI.BAT: success for drm/i915/psr: Add PSR pause/resume reference count (rev3)

2025-03-28 Thread Patchwork
== Series Details == Series: drm/i915/psr: Add PSR pause/resume reference count (rev3) URL : https://patchwork.freedesktop.org/series/146286/ State : success == Summary == CI Bug Log - changes from CI_DRM_16334 -> Patchwork_146286v3 Summary

✓ i915.CI.BAT: success for Expose modifiers/formats supported by async flips (rev12)

2025-03-28 Thread Patchwork
== Series Details == Series: Expose modifiers/formats supported by async flips (rev12) URL : https://patchwork.freedesktop.org/series/140935/ State : success == Summary == CI Bug Log - changes from CI_DRM_16339 -> Patchwork_140935v12 Summar

[PATCH v2 4/6] drm/i915/gt: Check for the first CCS instead of FIRST_RENDER_COMPUTE

2025-03-28 Thread Andi Shyti
From: Andi Shyti Enable the CCS engine when the first CCS is encountered in the execlist setup, instead of checking for the I915_ENGINE_FIRST_RENDER_COMPUTE flag. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[PATCH v11 3/5] drm/i915/display: Acomodate format check in can_async_flip()

2025-03-28 Thread Arun R Murthy
The function pointer can_async_flip() checks for async supported modifier, add format support check also in the same function. v11: Move filtering Indexed 8bit to a separate patch Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/i9xx_plane.c | 4 ++-- drivers/gpu/drm/i915

Re: [PATCH 0/6] drm/i915: dpll, ddi, crc, psr etc conversions to struct intel_display

2025-03-28 Thread Jani Nikula
On Fri, 28 Mar 2025, Ville Syrjälä wrote: > On Tue, Mar 25, 2025 at 02:36:32PM +0200, Jani Nikula wrote: >> We're getting there! >> >> Jani Nikula (6): >> drm/i915/dpll: convert intel_dpll.[ch] to struct intel_display >> drm/i915/ddi: convert intel_ddi.c to struct intel_display >> drm/i915/

Re: [PATCH] drm/i915/gem: Convert SPDX headers to single-line format

2025-03-28 Thread Mikolaj Wasiak
Hi Andi, Ok! then Reviewed-by: Mikołaj Wasiak Mikołaj

✗ Fi.CI.SPARSE: warning for Expose modifiers/formats supported by async flips (rev12)

2025-03-28 Thread Patchwork
== Series Details == Series: Expose modifiers/formats supported by async flips (rev12) URL : https://patchwork.freedesktop.org/series/140935/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH] drm/i915/display: Fix htmldocs build

2025-03-28 Thread Rodrigo Vivi
Fixes a wrong documentation block indentation: Documentation/gpu/i915:141: ./drivers/gpu/drm/i915/display/intel_hotplug.c:1080: ERROR: Unexpected indentation. Documentation/gpu/i915:141: ./drivers/gpu/drm/i915/display/intel_hotplug.c:1082: WARNING: Block quote ends without a blank line; unexpe

[PATCH] drm/i915/display: Fix htmldocs build

2025-03-28 Thread Rodrigo Vivi
Fixes a wrong documentation block indentation: Documentation/gpu/i915:141: ./drivers/gpu/drm/i915/display/intel_hotplug.c:1080: ERROR: Unexpected indentation. Documentation/gpu/i915:141: ./drivers/gpu/drm/i915/display/intel_hotplug.c:1082: WARNING: Block quote ends without a blank line; unexpe

Re: [PATCH v11 5/5] drm/i915/display: Indexed 8bit format does not support async flip

2025-03-28 Thread Ville Syrjälä
On Fri, Mar 28, 2025 at 06:15:39PM +0530, Arun R Murthy wrote: > Async flip is not supported with Indexed 8 bit format as it depends on > LUT and can't be updated atomically. > > Signed-off-by: Arun R Murthy Seems OK to me. Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/inte

Re: [PATCH v11 3/5] drm/i915/display: Acomodate format check in can_async_flip()

2025-03-28 Thread Ville Syrjälä
On Fri, Mar 28, 2025 at 06:15:37PM +0530, Arun R Murthy wrote: > The function pointer can_async_flip() checks for async supported > modifier, add format support check also in the same function. You are changing intel_plane_can_async_flip(), not the .can_async_flip() vfunc. So this commit message d

✗ Fi.CI.SPARSE: warning for Expose modifiers/formats supported by async flips (rev11)

2025-03-28 Thread Patchwork
== Series Details == Series: Expose modifiers/formats supported by async flips (rev11) URL : https://patchwork.freedesktop.org/series/140935/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH v2 10/59] dyndbg: replace classmap list with a vector

2025-03-28 Thread jim . cromie
On Mon, Mar 24, 2025 at 9:08 AM Louis Chauvet wrote: > > > > Le 20/03/2025 à 19:51, Jim Cromie a écrit : > Thanks for your explanation of __outvar! It makes sense. I never seen > this pattern anywhere in the kernel, maybe a simple doc comment is > enough to carry the information: Im gonna pull

[PATCH v11 2/5] drm/plane: modify create_in_formats to acommodate async

2025-03-28 Thread Arun R Murthy
create_in_formats creates the list of supported format/modifiers for synchronous flips, modify the same function so as to take the format_mod_supported as argument and create list of format/modifier for async as well. v5: create_in_formats can return -ve value in failure case, correct the if condi

[PATCH v11 4/5] drm/i915/display: Add i915 hook for format_mod_supported_async

2025-03-28 Thread Arun R Murthy
Hook up the newly added plane function pointer format_mod_supported_async to populate the modifiers/formats supported by asynchronous flips. v5: Correct the if condition for modifier support check (Chaitanya) v6: Replace uint32_t/uint64_t with u32/u64 (Jani) v7: Move plannar check from intel_async

[PATCH v11 1/5] drm/plane: Add new plane property IN_FORMATS_ASYNC

2025-03-28 Thread Arun R Murthy
There exists a property IN_FORMATS which exposes the plane supported modifiers/formats to the user. In some platforms when asynchronous flip are used all of modifiers/formats mentioned in IN_FORMATS are not supported. This patch adds a new plane property IN_FORMATS_ASYNC to expose the async flip su

RE: [PATCH v10 3/4] drm/i915/display: Acomodate format check in can_async_flip()

2025-03-28 Thread Murthy, Arun R
> On Fri, Mar 28, 2025 at 02:59:15PM +0530, Arun R Murthy wrote: > > The function pointer can_async_flip() checks for async supported > > modifier, add format support check also in the same function. > > > > Signed-off-by: Arun R Murthy > > --- > > drivers/gpu/drm/i915/display/i9xx_plane.c

[PATCH v3] drm/i915/psr: Add PSR pause/resume reference count

2025-03-28 Thread Jouni Högander
We have now seen this: <4> [2120.434153] i915 :00:02.0: [drm] drm_WARN_ON(psr->paused) <4> [2120.434196] WARNING: CPU: 3 PID: 4430 at drivers/gpu/drm/i915/display/intel_psr.c:2227 intel_psr_pause+0x16e/0x180 [i915] Comment for drm_WARN_ON(display->drm, psr->paused) in intel_psr_pause says:

[PATCH 2/3] drm/i915/dp_mst: Fix side-band message timeouts due to long PPS delays

2025-03-28 Thread Imre Deak
The Panel Power Sequencer lock held on an eDP port (a) blocks a DP AUX transfer on another port (b), since the PPS lock is device global, thus shared by all ports. The PPS lock can be held on port (a) for a longer period due to the various PPS delays (panel/backlight on/off, power-cycle delays). Th

RE: [PATCH v3] drm/i915/psr: Add PSR pause/resume reference count

2025-03-28 Thread Manna, Animesh
> -Original Message- > From: Hogander, Jouni > Sent: Friday, March 28, 2025 1:36 PM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Cc: Manna, Animesh ; Hogander, Jouni > > Subject: [PATCH v3] drm/i915/psr: Add PSR pause/resume reference count > > We have now se

✓ i915.CI.BAT: success for drm/i915/display: Fix htmldocs build (rev2)

2025-03-28 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix htmldocs build (rev2) URL : https://patchwork.freedesktop.org/series/146974/ State : success == Summary == CI Bug Log - changes from CI_DRM_16342 -> Patchwork_146974v2 Summary --- **

Re: Regression on linux-next (next-20250321)

2025-03-28 Thread Josh Poimboeuf
On Tue, Mar 25, 2025 at 10:43:17AM -0300, Jason Gunthorpe wrote: > On Tue, Mar 25, 2025 at 12:40:16AM -0700, Nicolin Chen wrote: > > > > On Tue, Mar 25, 2025 at 05:39:39AM +, Borah, Chaitanya Kumar wrote: > > > Hello Nicolin, > > > > > > Hope you are doing well. I am Chaitanya from the linux

Re: [PATCH 16/63] dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP

2025-03-28 Thread jim . cromie
On Mon, Mar 24, 2025 at 9:07 AM Louis Chauvet wrote: > trimming > >>> + __section("__dyndbg_class_users") _uname = {\ > >>> + .mod_name = KBUILD_MODNAME, \ > >>> + .map = &(_var), \

Re: [PATCH 06/11] migrate: Remove call to ->writepage

2025-03-28 Thread Zi Yan
On Fri Mar 7, 2025 at 8:54 AM EST, Matthew Wilcox (Oracle) wrote: > The writepage callback is going away; filesystems must implement > migrate_folio or else dirty folios will not be migratable. What is the impact of this? Are there any filesystem that has a_ops->writepage() without migrate_folio()

Re: [PATCH 28/63] dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API

2025-03-28 Thread jim . cromie
On Sun, Mar 16, 2025 at 3:14 PM wrote: > > On Tue, Feb 25, 2025 at 7:29 AM Louis Chauvet > wrote: > > > > > > > > Le 25/01/2025 à 07:45, Jim Cromie a écrit : > > > move the DYNDBG_CLASSMAP_PARAM macro from test-dynamic-debug.c into > > > the header, and refine it, by distinguishing the 2 use cas

Re: [PATCH v2 30/59] dyndbg: drop "protection" of class'd pr_debugs from legacy queries

2025-03-28 Thread jim . cromie
On Tue, Mar 25, 2025 at 12:29 PM wrote: > > On Mon, Mar 24, 2025 at 9:20 AM Louis Chauvet > wrote: > > > > > > > > Le 20/03/2025 à 19:52, Jim Cromie a écrit : > > > Current classmap code protects class'd pr_debugs from unintended > > > changes by "legacy" unclassed queries: > > > > > ># this

Re: [PATCH 06/11] migrate: Remove call to ->writepage

2025-03-28 Thread Zi Yan
On Thu Mar 27, 2025 at 12:52 PM EDT, Matthew Wilcox wrote: > On Thu, Mar 27, 2025 at 11:04:57AM -0400, Zi Yan wrote: >> On Fri Mar 7, 2025 at 8:54 AM EST, Matthew Wilcox (Oracle) wrote: >> > The writepage callback is going away; filesystems must implement >> > migrate_folio or else dirty folios wil

Re: [PATCH v2 30/59] dyndbg: drop "protection" of class'd pr_debugs from legacy queries

2025-03-28 Thread jim . cromie
On Mon, Mar 24, 2025 at 9:20 AM Louis Chauvet wrote: > > > > Le 20/03/2025 à 19:52, Jim Cromie a écrit : > > Current classmap code protects class'd pr_debugs from unintended > > changes by "legacy" unclassed queries: > > > ># this doesn't disable all of DRM_UT_* categories > >echo "-p" > /

Re: [PATCH v2 30/59] dyndbg: drop "protection" of class'd pr_debugs from legacy queries

2025-03-28 Thread jim . cromie
> > - int valid_class; > > + int slctd_class; > > Nitpick: can you use full words? slctd is difficult to read. > yes. done. thx.

Re: [PATCH v2 33/59] docs/dyndbg: add classmap info to howto (TBD)

2025-03-28 Thread jim . cromie
On Mon, Mar 24, 2025 at 9:23 AM Louis Chauvet wrote: > > > > Le 20/03/2025 à 19:52, Jim Cromie a écrit : > > Describe the 3 API macros providing dynamic_debug's classmaps > > > > DYNDBG_CLASSMAP_DEFINE - create & export a classmap ... > > +Dynamic Debug classmaps > > +=== > > +

Re: [PATCH v2 47/59] drm-dyndbg: add DRM_CLASSMAP_USE to bochs

2025-03-28 Thread jim . cromie
On Mon, Mar 24, 2025 at 9:03 AM Louis Chauvet wrote: > > > > Le 20/03/2025 à 19:52, Jim Cromie a écrit : > > tiny/bochs has 5 DRM_UT_* debugs, make them controllable when > > CONFIG_DRM_USE_DYNAMIC_DEBUG=y by telling dyndbg that the module has > > class'd debugs. > > > > Signed-off-by: Jim Cromie

Re: [PATCH v2 44/59] drm-dyndbg: add DRM_CLASSMAP_USE to Xe driver

2025-03-28 Thread jim . cromie
On Mon, Mar 24, 2025 at 9:24 AM Louis Chauvet wrote: > > > > Le 20/03/2025 à 19:52, Jim Cromie a écrit : > > Invoke DRM_CLASSMAP_USE from xe_drm_client.c. When built with > > CONFIG_DRM_USE_DYNAMIC_DEBUG=y, this tells dydnbg that Xe uses > > has drm.debug calls. > > > > Signed-off-by: Jim Cromie

Re: [PATCH] drm/i915: reduce intel_wakeref.h dependencies

2025-03-28 Thread Rodrigo Vivi
On Wed, Mar 26, 2025 at 01:54:52PM +0200, Jani Nikula wrote: > Forward declare struct drm_printer instead of including drm/drm_print.h, > as we only need the pointer. Turns out quite a few places depend on this > include implicitly. Make them explicit. > > Some of the includes are just stale and u

RE: [PATCH v11 3/5] drm/i915/display: Acomodate format check in can_async_flip()

2025-03-28 Thread Murthy, Arun R
> On Fri, Mar 28, 2025 at 06:15:37PM +0530, Arun R Murthy wrote: > > The function pointer can_async_flip() checks for async supported > > modifier, add format support check also in the same function. > > You are changing intel_plane_can_async_flip(), not the > .can_async_flip() vfunc. So this comm

[PATCH v11 1/5] drm/plane: Add new plane property IN_FORMATS_ASYNC

2025-03-28 Thread Arun R Murthy
There exists a property IN_FORMATS which exposes the plane supported modifiers/formats to the user. In some platforms when asynchronous flip are used all of modifiers/formats mentioned in IN_FORMATS are not supported. This patch adds a new plane property IN_FORMATS_ASYNC to expose the async flip su

[PATCH v11 4/5] drm/i915/display: Add i915 hook for format_mod_supported_async

2025-03-28 Thread Arun R Murthy
Hook up the newly added plane function pointer format_mod_supported_async to populate the modifiers/formats supported by asynchronous flips. v5: Correct the if condition for modifier support check (Chaitanya) v6: Replace uint32_t/uint64_t with u32/u64 (Jani) v7: Move plannar check from intel_async

[PATCH v11 2/5] drm/plane: modify create_in_formats to acommodate async

2025-03-28 Thread Arun R Murthy
create_in_formats creates the list of supported format/modifiers for synchronous flips, modify the same function so as to take the format_mod_supported as argument and create list of format/modifier for async as well. v5: create_in_formats can return -ve value in failure case, correct the if condi

[PATCH v11 3/5] drm/i915/display: Acomodate format check in intel_plane_can_async_flip()

2025-03-28 Thread Arun R Murthy
The function intel_plane_can_async_flip() checks for async supported modifier, add format support check also in the same function. Note: on ADL the surface base addr is required to be 16k aligned and if not might generate DMAR and GGTT faults leading to glitches. v11: Move filtering Indexed 8bit

[PATCH v11 5/5] drm/i915/display: Indexed 8bit format does not support async flip

2025-03-28 Thread Arun R Murthy
Async flip is not supported with Indexed 8 bit format as it depends on LUT and can't be updated atomically. Signed-off-by: Arun R Murthy Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v10 3/4] drm/i915/display: Acomodate format check in can_async_flip()

2025-03-28 Thread Arun R Murthy
The function pointer can_async_flip() checks for async supported modifier, add format support check also in the same function. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/i9xx_plane.c | 4 ++-- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 11 ++- drive

Re: [PATCH] drm/i915/gem: Convert SPDX headers to single-line format

2025-03-28 Thread Andi Shyti
Hi Mikolaj, On Fri, Mar 28, 2025 at 09:08:53AM +0100, Mikolaj Wasiak wrote: > Consider also changing the SPDX licence header in gem/selftests as > currently we have there mix of oneliners and multiliners. thanks for your suggestion. If you don't mind I would do it in a separate patch, otherwise t

✓ i915.CI.BAT: success for Expose modifiers/formats supported by async flips (rev11)

2025-03-28 Thread Patchwork
== Series Details == Series: Expose modifiers/formats supported by async flips (rev11) URL : https://patchwork.freedesktop.org/series/140935/ State : success == Summary == CI Bug Log - changes from CI_DRM_16335 -> Patchwork_140935v11 Summar

Re: [PATCH v2 29/59] dyndbg: change __dynamic_func_call_cls* macros into expressions

2025-03-28 Thread jim . cromie
On Mon, Mar 24, 2025 at 9:19 AM Louis Chauvet wrote: > > > > Le 20/03/2025 à 19:52, Jim Cromie a écrit : > > The Xe driver's XE_IOCTL_DBG macro calls drm_dbg() from inside an if > > (expression). This breaks when CONFIG_DRM_USE_DYNAMIC_DEBUG=y because > > the invoked macro has a do-while-0 wrappe

Re: [PATCH] drm/i915/gsc: delete a stray tab in intel_gsc_fw_get_binary_info()

2025-03-28 Thread Rodrigo Vivi
On Mon, Mar 10, 2025 at 10:46:19PM +0300, Dan Carpenter wrote: > This line is indented on tab too far. Delete the extra tab. > > Signed-off-by: Dan Carpenter Reviewed-by: Rodrigo Vivi and pushing right now... > --- > drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 2 +- > 1 file changed, 1 inse

Re: [PATCH 2/2] drm/i915/dram: Consolidate logging of DRAM type

2025-03-28 Thread Matt Roper
On Mon, Mar 24, 2025 at 07:28:42PM -0700, Lucas De Marchi wrote: > Instead of logging the dram type in the per version/platform function, > do it in the generic one. This fixes a few discrepancies depending on > the platform: > > - There was no DRAM type logging for graphics version 12 and >

Re: [PATCH 1/2] drm/i915/dram: Add missing INTEL_DRAM str conversions

2025-03-28 Thread Matt Roper
On Mon, Mar 24, 2025 at 07:28:41PM -0700, Lucas De Marchi wrote: > Some new dram types were added without adding the corresponding string > conversion, probably because it's not being used by recent platforms. > Add them, together with a BUILD_BUG_ON() to ensure it keeps in sync, in > preparation t

Re: [PATCH v2] drm/i915/selftest: allow larger memory allocation

2025-03-28 Thread Krzysztof Karas
Hi Mikołaj, > Due to changes in allocator, the size of the allocation for > contiguous region is not rounded up to a power-of-two and > instead allocated as is. Thus, change the part of test that > expected the allocation to fail. > > Signed-off-by: Mikolaj Wasiak > --- > v1 -> v2: > - Added neg

Re: [PATCH v4] drm/i915/dsi: let HW maintain the HS-TRAIL timing

2025-03-28 Thread Jani Nikula
On Tue, 11 Mar 2025, William Tseng wrote: > This change is to avoid over-specification of the TEOT timing > parameter, which is derived from software in current design. > > Supposed that THS-TRAIL and THS-EXIT have the minimum values, > i.e., 60 and 100 in ns. If SW is overriding the HW default, >

✗ Fi.CI.SPARSE: warning for Expose modifiers/formats supported by async flips (rev10)

2025-03-28 Thread Patchwork
== Series Details == Series: Expose modifiers/formats supported by async flips (rev10) URL : https://patchwork.freedesktop.org/series/140935/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Expose modifiers/formats supported by async flips (rev10)

2025-03-28 Thread Patchwork
== Series Details == Series: Expose modifiers/formats supported by async flips (rev10) URL : https://patchwork.freedesktop.org/series/140935/ State : warning == Summary == Error: dim checkpatch failed f7133a7c112e drm/plane: Add new plane property IN_FORMATS_ASYNC 1778d0106429 drm/plane: modif

Re: [PATCH 2/2] drm/i915/display: Avoid use of VTOTAL.Vtotal bits

2025-03-28 Thread Ville Syrjälä
On Thu, Mar 27, 2025 at 08:16:29PM +0530, Ankit Nautiyal wrote: > For platforms that always use VRR Timing Generator, the VTOTAL.Vtotal > bits are not required. Since the support for these bits is going to > be deprecated in upcoming platforms, avoid writing these bits for the > platforms that do n

Re: [PATCH 0/6] drm/i915: dpll, ddi, crc, psr etc conversions to struct intel_display

2025-03-28 Thread Ville Syrjälä
On Tue, Mar 25, 2025 at 02:36:32PM +0200, Jani Nikula wrote: > We're getting there! > > Jani Nikula (6): > drm/i915/dpll: convert intel_dpll.[ch] to struct intel_display > drm/i915/ddi: convert intel_ddi.c to struct intel_display > drm/i915/crc: convert intel_pipe_crc.c to struct intel_displ

[CI 5/9] drm/i915/hotplug: convert hotplug irq handling to intel_de_*()

2025-03-28 Thread Jani Nikula
All the registers handled here are display registers. Switch from intel_uncore_*() to intel_de_*() functions. Reviewed-by: Uma Shankar Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_hotplug_irq.c | 205 ++ 1 file changed, 114 insertion

Re: [PATCH v10 3/4] drm/i915/display: Acomodate format check in can_async_flip()

2025-03-28 Thread Ville Syrjälä
On Fri, Mar 28, 2025 at 02:59:15PM +0530, Arun R Murthy wrote: > The function pointer can_async_flip() checks for async supported > modifier, add format support check also in the same function. > > Signed-off-by: Arun R Murthy > --- > drivers/gpu/drm/i915/display/i9xx_plane.c | 4 ++--

✓ i915.CI.BAT: success for Expose modifiers/formats supported by async flips (rev10)

2025-03-28 Thread Patchwork
== Series Details == Series: Expose modifiers/formats supported by async flips (rev10) URL : https://patchwork.freedesktop.org/series/140935/ State : success == Summary == CI Bug Log - changes from CI_DRM_16334 -> Patchwork_140935v10 Summar

Re: [PATCH] drm/i915/gem: Convert SPDX headers to single-line format

2025-03-28 Thread Jani Nikula
On Fri, 28 Mar 2025, Andi Shyti wrote: > Replace multi-line SPDX license headers with single-line > equivalents (// SPDX-License-Identifier: MIT or /* ... */ for > headers), as preferred by current kernel coding style. > > Signed-off-by: Andi Shyti Acked-by: Jani Nikula -- Jani Nikula, Intel

[PATCH v10 1/4] drm/plane: Add new plane property IN_FORMATS_ASYNC

2025-03-28 Thread Arun R Murthy
There exists a property IN_FORMATS which exposes the plane supported modifiers/formats to the user. In some platforms when asynchronous flip are used all of modifiers/formats mentioned in IN_FORMATS are not supported. This patch adds a new plane property IN_FORMATS_ASYNC to expose the async flip su

Re: [PATCH 1/2] drm/i915/display: Introduce transcoder_has_vrr() helper

2025-03-28 Thread Ville Syrjälä
On Thu, Mar 27, 2025 at 08:16:28PM +0530, Ankit Nautiyal wrote: > Introduce a new helper to check transcoder_has_vrr() and use > that to exclude transcoders which do not support VRR. > > v2: Include HAS_VRR into the helper. (Ville) > v3: Drop the usage in places where not applicable. (Ville) > >

Re: [PATCH 00/11] Remove aops->writepage

2025-03-28 Thread Christian Brauner
On Fri, Mar 07, 2025 at 01:54:00PM +, Matthew Wilcox wrote: > I was preparing for LSFMM and noticed that actually we're almost done > with the writepage conversion. This patchset finishes it off. > Something changed in my test environment and now it crashes before > even starting a run, so thi

[PATCH v11 5/5] drm/i915/display: Indexed 8bit format does not support async flip

2025-03-28 Thread Arun R Murthy
Async flip is not supported with Indexed 8 bit format as it depends on LUT and can't be updated atomically. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_

Re: ✗ i915.CI.Full: failure for VRR Register Read/Write Updates (rev3)

2025-03-28 Thread Nautiyal, Ankit K
Hi, The failures below cannot be due to the patches, as the patches only skips writing VTOTAL.vtotal bits for PTL platform only. * igt@kms_busy@extended-modeset-hang-oldfb-with-reset: o shard-snb: PASS