[PATCH v5 3/6] drm/i915/hpd: Add support for blocking the IRQ handling on an HPD pin

2025-03-05 Thread Imre Deak
Add support for blocking the IRQ handling on the HPD pin of a given encoder, handling IRQs that arrived while in the blocked state after unblocking the IRQ handling. This will be used by a follow-up change, which blocks/unblocks the IRQ handling around DP link training. This is similar to the inte

[PATCH 02/16] sna: stop using obsolete type aliases

2025-03-05 Thread Enrico Weigelt, metux IT consult
The Xserver has been moved to using pixman for all matrix operations, back in 2008, but left some #define's so drivers still compile. Since 1.5 decades have passed now, it's time to fix remaining drivers still using the old name, so we can drop these #define's from the Xserver includes. Signed-off

[PATCH v6 5/6] drm/i915/dp: Queue a link check after link training is complete

2025-03-05 Thread Imre Deak
After link training - both in case of a passing and failing LT result - a work is scheduled to check the link state. This check should take place after the link training is completed by disabling the link training pattern and setting intel_dp::link_trained=true. Atm, the work is scheduled before th

Re: [PATCH 15/22] drm/i915/display: Use fixed_rr timings in modeset sequence

2025-03-05 Thread Nautiyal, Ankit K
On 3/5/2025 12:20 AM, Ville Syrjälä wrote: On Tue, Mar 04, 2025 at 01:49:41PM +0530, Ankit Nautiyal wrote: During modeset enable sequence, program the fixed timings, and turn on the VRR Timing Generator (VRR TG) for platforms that always use VRR TG. For this intel_vrr_set_transcoder now alway

[PATCH v6 3/6] drm/i915/hpd: Add support for blocking the IRQ handling on an HPD pin

2025-03-05 Thread Imre Deak
Add support for blocking the IRQ handling on the HPD pin of a given encoder, handling IRQs that arrived while in the blocked state after unblocking the IRQ handling. This will be used by a follow-up change, which blocks/unblocks the IRQ handling around DP link training. This is similar to the inte

[PATCH] drm/xe/display: Fix fbdev GGTT mapping handling.

2025-03-05 Thread Maarten Lankhorst
FBDEV ggtt is not restored correctly, add missing GGTT flag to intel_fbdev_fb_alloc to make it work. This ensures that the global GGTT mapping is always restored on resume. The GGTT mapping would otherwise be created in intel_fb_pin_to_ggtt() by intel_fbdev anyway. This fixes the fbdev device no

Re: [PATCH 15/22] drm/i915/display: Use fixed_rr timings in modeset sequence

2025-03-05 Thread Ville Syrjälä
On Wed, Mar 05, 2025 at 02:11:21PM +0530, Nautiyal, Ankit K wrote: > > On 3/5/2025 12:20 AM, Ville Syrjälä wrote: > > On Tue, Mar 04, 2025 at 01:49:41PM +0530, Ankit Nautiyal wrote: > >> During modeset enable sequence, program the fixed timings, and turn on the > >> VRR Timing Generator (VRR TG) f

[PATCH v3.2] drm/xe/display: Fix fbdev GGTT mapping handling.

2025-03-05 Thread Maarten Lankhorst
On 2025-03-05 00:09, Lucas De Marchi wrote: > On Thu, Feb 20, 2025 at 06:17:01PM +0100, Maarten Lankhorst wrote: >> Hey, >> >> On 2025-02-20 16:43, Matthew Auld wrote: >>> On 20/02/2025 14:22, Lucas De Marchi wrote: On Wed, Feb 19, 2025 at 04:34:40PM +0100, Maarten Lankhorst wrote: > Th

Re: Discussion: Moving away from Patchwork for Intel i915/Xe CI

2025-03-05 Thread Lucas De Marchi
On Wed, Mar 05, 2025 at 10:51:20AM -0600, Knop, Ryszard wrote: Hey everyone, Patchwork has been having lots of issues recently, dropping patches, being unusably slow and generally starting to become more of a pain than help. Over on the CI side we are also not super fond of it and we don't have

Re: Discussion: Moving away from Patchwork for Intel i915/Xe CI

2025-03-05 Thread Jani Nikula
On Wed, 05 Mar 2025, "Knop, Ryszard" wrote: > Hey everyone, > > Patchwork has been having lots of issues recently, dropping patches, > being unusably slow and generally starting to become more of a pain > than help. Over on the CI side we are also not super fond of it and we > don't have enough re

✗ Fi.CI.SPARSE: warning for drm/i915/dp: Fix link training interrupted by HPD pulse (rev3)

2025-03-05 Thread Patchwork
== Series Details == Series: drm/i915/dp: Fix link training interrupted by HPD pulse (rev3) URL : https://patchwork.freedesktop.org/series/145782/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[v3 04/23] drm: Add Color lut range attributes

2025-03-05 Thread Uma Shankar
This defines a new structure to define color lut ranges, along with related macro definitions and enums. This will help describe segmented lut ranges/PWL LUTs in the hardware. Signed-off-by: Uma Shankar Signed-off-by: Chaitanya Kumar Borah --- include/uapi/drm/drm_mode.h | 64 ++

[v3 05/23] drm: Add Color ops capability property

2025-03-05 Thread Uma Shankar
Add capability property which a colorop can expose it's hardware's abilities. It's a blob property that can be filled with respective data structures depending on the colorop. The user space is expected to read this property and program the colorop accordingly. v2: Added documentation for hw_caps

Re: [PATCH 2/2] drm: ensure drm headers are self-contained and pass kernel-doc

2025-03-05 Thread Maxime Ripard
On Wed, Mar 05, 2025 at 03:05:25AM +0900, Masahiro Yamada wrote: > > IMO headers should almost invariably be self-contained, instead of > > putting the burden on their users to include other headers to make it > > work. It's a PITA in a project the size of the kernel, or even just the > > drm subsy

Re: [RFC PATCH] Revert "drm/i915: Disable compression tricks on JSL"

2025-03-05 Thread Sebastian Brzezinka
Hi The bug appeared recently once, and it is possible that it will pop up from time to times, so it might be better to get rid of this workaround from the kernel, especially since it's already in Mesa. I would like to know, what you think about it ? -- Best regards, Sebastian

Re: [RFC PATCH] Revert "drm/i915: Disable compression tricks on JSL"

2025-03-05 Thread Sebastian Brzezinka
Hi Ville On Wed Mar 5, 2025 at 3:26 PM UTC, Ville Syrjälä wrote: > On Wed, Mar 05, 2025 at 02:49:46PM +, Sebastian Brzezinka wrote: >> This reverts commit 0ddae025ab6cefa9aba757da3cd1d27908d70b0e. >> >> According to bspec 14181, CACHE_MODE_0 is a register that's under userspace >> control, an

✓ i915.CI.BAT: success for drm/i915/dp: Fix link training interrupted by HPD pulse (rev3)

2025-03-05 Thread Patchwork
== Series Details == Series: drm/i915/dp: Fix link training interrupted by HPD pulse (rev3) URL : https://patchwork.freedesktop.org/series/145782/ State : success == Summary == CI Bug Log - changes from CI_DRM_16229 -> Patchwork_145782v3 Su

RE: [PATCH 1/5] drm/i915/display: convert various port/phy helpers to struct intel_display

2025-03-05 Thread Jani Nikula
On Tue, 04 Mar 2025, "Garg, Nemesa" wrote: > LGTM, > Reviewed-by: Nemesa Garg Thanks for the reviews, series pushed to drm-intel-next. BR, Jani. -- Jani Nikula, Intel

Discussion: Moving away from Patchwork for Intel i915/Xe CI

2025-03-05 Thread Knop, Ryszard
Hey everyone, Patchwork has been having lots of issues recently, dropping patches, being unusably slow and generally starting to become more of a pain than help. Over on the CI side we are also not super fond of it and we don't have enough resources to maintain it properly. Lucas has suggested usi

[PATCH v3 0/4] drm/i915: Fix harmfull driver register/unregister assymetry

2025-03-05 Thread Janusz Krzysztofik
Starting with commit ec3e00b4ee27 ("drm/i915: stop registering if drm_dev_register() fails"), we may return from i915_driver_register() immediately, skipping remaining registration steps. However, the _unregister() counterpart called at device remove knows nothing about that skip and executes reve

[PATCH v3 1/4] drm/i915: Skip harmful unregister steps if not registered

2025-03-05 Thread Janusz Krzysztofik
Starting with commit ec3e00b4ee27 ("drm/i915: stop registering if drm_dev_register() fails"), we return from i915_driver_register() immediately if drm_dev_register() fails, skipping remaining registration steps. However, the _unregister() counterpart called at device remove knows nothing about tha

[PATCH v3 3/4] drm/i915: Fix asymmetry in PMU register/unregister step order

2025-03-05 Thread Janusz Krzysztofik
To simplify i915_driver_unregister() code, make sure reverts of driver registration steps executed before potentially unsuccessful device registration are symmetrically called after drm_dev_unplug(). There is one case that doesn't follow that rule, introduced by commit b46a33e271ed ("drm/i915/pmu:

[PATCH v3 4/4] drm/i915: Group not skipped unregister steps

2025-03-05 Thread Janusz Krzysztofik
Further simplification of i915_driver_unregister() requires moving of two steps, intel_pxp_fini() and intel_gt_driver_unregister(), down, e.g., right behind drm_dev_unplug(). Local testing hasn't revealed any issues with that move, so go for it. Former placement of intel_gt_driver_unregister() wi

✓ i915.CI.BAT: success for Revert "drm/i915: Disable compression tricks on JSL"

2025-03-05 Thread Patchwork
== Series Details == Series: Revert "drm/i915: Disable compression tricks on JSL" URL : https://patchwork.freedesktop.org/series/145842/ State : success == Summary == CI Bug Log - changes from CI_DRM_16229 -> Patchwork_145842v1 Summary

[PATCH v3 2/4] drm/i915: Omit unnecessary driver unregister steps

2025-03-05 Thread Janusz Krzysztofik
Now that we have a flag that indicates device registration status, when unregistering the driver, jump over reverts of driver registration steps that were not called due to device registration failure. Unfortunately, not all steps of i915_driver_unregister() are limited only to reverting changes i

[v3 10/23] drm/i915/color: Add helper to create intel colorop

2025-03-05 Thread Uma Shankar
From: Chaitanya Kumar Borah Add intel colorop create helper Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 39 ++ drivers/gpu/drm/i915/display/intel_color.h | 3 ++ 2 files changed, 42 insertions(+) diff -

[v3 03/23] drm: Add Enhanced LUT precision structure

2025-03-05 Thread Uma Shankar
Existing LUT precision structure is having only 16 bit precision. This is not enough for upcoming enhanced hardwares and advance usecases like HDR processing. Hence added a new structure with 32 bit precision values. Signed-off-by: Uma Shankar Signed-off-by: Chaitanya Kumar Borah --- drivers/gp

[v3 00/23] Plane Color Pipeline support for Intel platforms

2025-03-05 Thread Uma Shankar
This series intends to add support for Plane Color Management for Intel platforms. This is based on the design which has been agreed upon by the community. Series implementing the design for generic DRM core has been sent out by Harry Wentland and is under review below: https://patchwork.freedeskto

[v3 11/23] drm/i915/color: Create a transfer function color pipeline

2025-03-05 Thread Uma Shankar
From: Chaitanya Kumar Borah Add a color pipeline with three colorops in the sequence 1D LUT MULTSEG - CTM - 1D LUT MULTSEG This pipeline can be used to do any color space conversion or HDR tone mapping Signed-off-by: Uma Shankar Signed-off-by: Chaitanya Kumar Borah --- drivers/gpu/d

[v3 08/23] drm/i915: Add identifiers for intel color blocks

2025-03-05 Thread Uma Shankar
From: Chaitanya Kumar Borah Add macros to identify intel color blocks. It will help in mapping drm_color_ops to intel color HW blocks Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_display_limits.h | 13 + 1 file changed, 13

[v3 06/23] drm: Add 1D LUT multi-segmented color op

2025-03-05 Thread Uma Shankar
From: Chaitanya Kumar Borah Add support for color ops that can be programmed by 1 dimensional multi segmented Look Up Tables. v2: Fixed the documentation for Multi segmented lut (Dmitry) Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_atomic.c |

[v3 09/23] drm/i915: Add intel_color_op

2025-03-05 Thread Uma Shankar
From: Chaitanya Kumar Borah Add data structure to store intel specific details of colorop Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- .../drm/i915/display/intel_display_types.h| 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/

Re: [PATCH] i915/gt/selftest_lrc: Remove timestamp test

2025-03-05 Thread Sebastian Brzezinka
Hi Mikolaj On Tue Mar 4, 2025 at 1:09 PM UTC, Mikolaj Wasiak wrote: > This test exposes bug in tigerlake hardware which prevents it from > succeeding. Since the tested feature is only available on bugged hardware > and we won't support any new hardware, this test is obsolete and > should be remove

Re: [PATCH v4 3/8] bits: introduce fixed-type genmasks

2025-03-05 Thread Andy Shevchenko
On Wed, Mar 05, 2025 at 10:22:44AM -0500, Yury Norov wrote: > + Anshuman Khandual > > Anshuman, > > I merged your GENMASK_U128() because you said it's important for your > projects, and that it will get used in the kernel soon. > > Now it's in the kernel for more than 6 month, but no users were

Re: [PATCH v4 3/8] bits: introduce fixed-type genmasks

2025-03-05 Thread Jani Nikula
On Wed, 05 Mar 2025, Yury Norov wrote: > On Wed, Mar 05, 2025 at 10:00:15PM +0900, Vincent Mailhol via B4 Relay wrote: >> +#define GENMASK_U8(h, l) ((unsigned int)GENMASK_t(u8, h, l)) >> +#define GENMASK_U16(h, l) ((unsigned int)GENMASK_t(u16, h, l)) > > Typecast to the type that user provides ex

Re: [PATCH v4 0/8] bits: Fixed-type GENMASK()/BIT()

2025-03-05 Thread Jani Nikula
On Wed, 05 Mar 2025, Vincent Mailhol via B4 Relay wrote: > Introduce some fixed width variant of the GENMASK() and the BIT() > macros in bits.h. Note that the main goal is not to get the correct > type, but rather to enforce more checks at compile time. For example: > > GENMASK_U16(16, 0) > > w

[v3 12/23] drm/i915/color: Add and attach COLORPIPELINE plane property

2025-03-05 Thread Uma Shankar
From: Chaitanya Kumar Borah Add supported color pipelines and attach it to plane. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 42 ++ drivers/gpu/drm/i915/display/intel_color.h | 3 ++ 2 files changed, 45

[v3 14/23] drm/i915/color: Add callbacks to set plane CTM

2025-03-05 Thread Uma Shankar
From: Chaitanya Kumar Borah Add callback to intel color functions for setting plane CTM. Signed-off-by: Uma Shankar Signed-off-by: Chaitanya Kumar Borah --- drivers/gpu/drm/i915/display/intel_color.c | 23 ++ drivers/gpu/drm/i915/display/intel_color.h | 3 ++- 2 files cha

[v3 18/23] drm/i915/color: Add framework to program PRE/POST CSC LUT

2025-03-05 Thread Uma Shankar
From: Chaitanya Kumar Borah Add framework that will help in loading LUT to Pre/Post CSC color blocks. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 27 ++ drivers/gpu/drm/i915/display/intel_color.h | 2 ++

[v3 20/23] drm/i915/color: Program Pre-CSC registers

2025-03-05 Thread Uma Shankar
Add callback for programming Pre-CSC LUT for TGL and beyond Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 88 ++ 1 file changed, 88 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/dr

[v3 07/23] drm: Define helper to initialize segmented 1D LUT

2025-03-05 Thread Uma Shankar
This adds helper functions to create 1D multi-segmented Lut color block capabilities. It exposes the hardware block as segments which are converted to blob and passed in the property. This also adds helper to initialize 1D segmented LUT. v2: Squashed the 1d lut helpers (Dmitry) Signed-off-by: Cha

[v3 02/23] drm: Add support for 3x3 CTM

2025-03-05 Thread Uma Shankar
From: Chaitanya Kumar Borah Add support for 3x3 Color Transformation Matrices in Color Pipeline. v2: Updated the documentation for 3x3 CTM colorop (Dmitry) Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_atomic.c | 3 +++ drivers/gpu/drm/drm_atom

[v3 22/23] drm/i915/color: Enable Plane Color Pipelines

2025-03-05 Thread Uma Shankar
From: Chaitanya Kumar Borah Expose color pipeline and add ability to program it. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/display/skl_uni

[v3 16/23] drm/i915/color: Add plane CTM callback for D13 and beyond

2025-03-05 Thread Uma Shankar
Add callback for setting CTM block in platforms D13 and beyond Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 79 ++ 1 file changed, 79 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_color.c b

[v3 15/23] drm/i915/color: Add new color callbacks for Xelpd

2025-03-05 Thread Uma Shankar
From: Chaitanya Kumar Borah Since we intend to add plane color callbacks from Xelpd(D13 and beyond), create a different structure for it. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 15 ++- 1 file changed, 14 ins

[v3 13/23] drm/i915/color: Add framework to set colorop

2025-03-05 Thread Uma Shankar
From: Chaitanya Kumar Borah Add infrastructure to set colorop. We iterate through all the color ops in a selected COLOR PIPELINE and set them one by one. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 31 ++

Re: [PATCH v3.2] drm/xe/display: Fix fbdev GGTT mapping handling.

2025-03-05 Thread Lucas De Marchi
On Wed, Mar 05, 2025 at 11:39:50AM +0100, Maarten Lankhorst wrote: On 2025-03-05 00:09, Lucas De Marchi wrote: On Thu, Feb 20, 2025 at 06:17:01PM +0100, Maarten Lankhorst wrote: Hey, On 2025-02-20 16:43, Matthew Auld wrote: On 20/02/2025 14:22, Lucas De Marchi wrote: On Wed, Feb 19, 2025 a

Re: [PATCH] drm/xe/display: Fix fbdev GGTT mapping handling.

2025-03-05 Thread Lucas De Marchi
On Wed, Mar 05, 2025 at 12:01:06PM +0100, Maarten Lankhorst wrote: FBDEV ggtt is not restored correctly, add missing GGTT flag to intel_fbdev_fb_alloc to make it work. This ensures that the global GGTT mapping is always restored on resume. The GGTT mapping would otherwise be created in intel_fb

Re: [PATCH 15/22] drm/i915/display: Use fixed_rr timings in modeset sequence

2025-03-05 Thread Nautiyal, Ankit K
On 3/5/2025 6:23 PM, Ville Syrjälä wrote: On Wed, Mar 05, 2025 at 02:11:21PM +0530, Nautiyal, Ankit K wrote: On 3/5/2025 12:20 AM, Ville Syrjälä wrote: On Tue, Mar 04, 2025 at 01:49:41PM +0530, Ankit Nautiyal wrote: During modeset enable sequence, program the fixed timings, and turn on the V

[RFC PATCH] Revert "drm/i915: Disable compression tricks on JSL"

2025-03-05 Thread Sebastian Brzezinka
This reverts commit 0ddae025ab6cefa9aba757da3cd1d27908d70b0e. According to bspec 14181, CACHE_MODE_0 is a register that's under userspace control, and DISABLE_REPACKING_FOR_COMPRESSION workaround should be already in all recent Mesa releases. So, there is no need to include it in kernel. Also, th

Re: [RFC PATCH] Revert "drm/i915: Disable compression tricks on JSL"

2025-03-05 Thread Ville Syrjälä
On Wed, Mar 05, 2025 at 02:49:46PM +, Sebastian Brzezinka wrote: > This reverts commit 0ddae025ab6cefa9aba757da3cd1d27908d70b0e. > > According to bspec 14181, CACHE_MODE_0 is a register that's under userspace > control, and DISABLE_REPACKING_FOR_COMPRESSION workaround should be already > in al

Re: [PATCH 07/22] drm/i915/vrr: Prepare for fixed refresh rate timings

2025-03-05 Thread Nautiyal, Ankit K
On 3/5/2025 12:19 AM, Ville Syrjälä wrote: On Tue, Mar 04, 2025 at 01:49:33PM +0530, Ankit Nautiyal wrote: Currently we always compute the timings as if vrr is enabled. With this approach the state checker becomes complicated when we introduce fixed refresh rate mode with vrr timing generator.

Re: [PATCH 18/22] drm/i915/display: Use fixed rr timings in intel_set_transcoder_timings_lrr()

2025-03-05 Thread Nautiyal, Ankit K
On 3/5/2025 12:26 AM, Ville Syrjälä wrote: On Tue, Mar 04, 2025 at 01:49:44PM +0530, Ankit Nautiyal wrote: To have Guardband/Pipeline_full reconfigured seamlessly, move the guardband and pipeline_full from intel_pipe_config_compare() to fastboot exception. Update the intel_set_transcoder_timin

Re: [PATCH 19/22] drm/i915/vrr: Allow fixed_rr with pipe joiner

2025-03-05 Thread Nautiyal, Ankit K
On 3/5/2025 12:37 AM, Ville Syrjälä wrote: On Tue, Mar 04, 2025 at 01:49:45PM +0530, Ankit Nautiyal wrote: VRR with joiner is currently disabled as it still needs some work to correctly sequence the primary and secondary transcoders. However, we can still use VRR Timing generator in fixed refr

Re: [PATCH 16/22] drm/i915/vrr: Use fixed timings for platforms that support VRR

2025-03-05 Thread Nautiyal, Ankit K
On 3/5/2025 12:23 AM, Ville Syrjälä wrote: On Tue, Mar 04, 2025 at 01:49:42PM +0530, Ankit Nautiyal wrote: For fixed refresh rate use fixed timings for all platforms that support VRR. For this add checks to avoid computing and reading VRR for platforms that do not support VRR. v2: Avoid touch

Re: [PATCH] drm/i915/xe3lpd: Prune modes for YUV420

2025-03-05 Thread Ville Syrjälä
On Tue, Mar 04, 2025 at 12:00:31PM -0800, Matt Atwood wrote: > From: Suraj Kandpal > > We only support resolution upto 4k for single pipe when using > YUV420 format so we prune these modes and restrict the plane size > at src. > > Signed-off-by: Suraj Kandpal > Signed-off-by: Matt Atwood > ---

[v3 21/23] drm/i915/xelpd: Program Plane Post CSC Registers

2025-03-05 Thread Uma Shankar
Extract the LUT and program plane post csc registers. Signed-off-by: Uma Shankar Signed-off-by: Chaitanya Kumar Borah --- drivers/gpu/drm/i915/display/intel_color.c | 109 + 1 file changed, 109 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers

[v3 17/23] drm/i915: Add register definitions for Plane Degamma

2025-03-05 Thread Uma Shankar
Add macros to define Plane Degamma registers Signed-off-by: Uma Shankar Signed-off-by: Chaitanya Kumar Borah --- .../i915/display/skl_universal_plane_regs.h | 53 +++ 1 file changed, 53 insertions(+) diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane_regs.h b/driv

[v3 23/23] drm/doc/rfc: Add documentation for multi-segmented 1D LUT

2025-03-05 Thread Uma Shankar
Add documentation to explain properties of the exposed hardware 1D LUT blocks, its identification and computation of the LUT samples based on the number of samples, their distribution and precison. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- Documentation/gpu/rfc/color_p

[v3 19/23] drm/i915: Add register definitions for Plane Post CSC

2025-03-05 Thread Uma Shankar
Add macros to define Plane Post CSC registers Signed-off-by: Uma Shankar Signed-off-by: Chaitanya Kumar Borah --- .../i915/display/skl_universal_plane_regs.h | 73 +++ 1 file changed, 73 insertions(+) diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane_regs.h b/dri

Re: [PATCH] drm/i915/gt: Add a delay to let engine resumes correctly

2025-03-05 Thread Andi Shyti
Hi Nitin, On Wed, Mar 05, 2025 at 07:45:31AM +, Gote, Nitin R wrote: > > On Mon, Feb 24, 2025 at 12:01:04PM +0530, Nitin Gote wrote: > > > Sometimes engine reset fails because the engine resumes from an > > > incorrect RING_HEAD. Engine head failed to set to zero even after > > > writing into

Re: [PATCH v4 3/8] bits: introduce fixed-type genmasks

2025-03-05 Thread Andy Shevchenko
On Wed, Mar 05, 2025 at 10:00:15PM +0900, Vincent Mailhol via B4 Relay wrote: > From: Yury Norov > > Add __GENMASK_t() which generalizes __GENMASK() to support different Is it with double underscore? I do not see it. _t is used for typedef simple types. It's unfortunate to have it in such a mac

Re: [PATCH v4 1/8] bits: fix typo 'unsigned __init128' -> 'unsigned __int128'

2025-03-05 Thread Andy Shevchenko
On Wed, Mar 05, 2025 at 10:00:13PM +0900, Vincent Mailhol via B4 Relay wrote: > From: Vincent Mailhol > > "int" was misspelled as "init" in GENMASK_U128() comments. Fix the typo. Please, fix it everywhere: $ git grep -lw __init128 include/linux/bits.h include/uapi/linux/const.h tools/include/li

Re: [PATCH v4 5/8] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_*

2025-03-05 Thread Andy Shevchenko
On Wed, Mar 05, 2025 at 10:00:17PM +0900, Vincent Mailhol via B4 Relay wrote: > From: Lucas De Marchi > > Now that include/linux/bits.h implements fixed-width GENMASK_*, use them GENMASK_*() and in the Subject REG_GENMASK*() > to implement the i915/xe specific macros. Converting each driver t

Re: [PATCH v4 4/8] bits: introduce fixed-type BIT

2025-03-05 Thread Andy Shevchenko
On Wed, Mar 05, 2025 at 10:00:16PM +0900, Vincent Mailhol via B4 Relay wrote: > From: Lucas De Marchi > > Implement fixed-type BIT to help drivers add stricter checks, like was Here and in the Subject I would use BIT_Uxx(). > done for GENMASK(). ... > +/* > + * Fixed-type variants of BIT(), w

Re: [PATCH v4 1/8] bits: fix typo 'unsigned __init128' -> 'unsigned __int128'

2025-03-05 Thread Andy Shevchenko
On Wed, Mar 05, 2025 at 09:30:20AM -0500, Yury Norov wrote: > On Wed, Mar 05, 2025 at 10:00:13PM +0900, Vincent Mailhol via B4 Relay wrote: > > From: Vincent Mailhol > > > > "int" was misspelled as "init" in GENMASK_U128() comments. Fix the typo. > > Thanks for respinning the series. I'll take t

Re: [PATCH v4 3/8] bits: introduce fixed-type genmasks

2025-03-05 Thread Andy Shevchenko
On Wed, Mar 05, 2025 at 11:38:19PM +0900, Vincent Mailhol wrote: > On 05/03/2025 at 23:30, Andy Shevchenko wrote: > > On Wed, Mar 05, 2025 at 10:00:15PM +0900, Vincent Mailhol via B4 Relay > > wrote: ... > > Perhaps T or TYPE will suffice. Or perhaps we want > > __GENMASK_Uxx() here? > > If no

Re: [PATCH v4 4/8] bits: introduce fixed-type BIT

2025-03-05 Thread Andy Shevchenko
On Wed, Mar 05, 2025 at 11:48:10PM +0900, Vincent Mailhol wrote: > On 05/03/2025 at 23:33, Andy Shevchenko wrote: > > On Wed, Mar 05, 2025 at 10:00:16PM +0900, Vincent Mailhol via B4 Relay > > wrote: ... > >> +#define BIT_U8(b) (BIT_INPUT_CHECK(u8, b) + (unsigned int)BIT(b)) > >> +#define BIT_U1

[PATCH v2 0/2] drm/xe/compat: cleanup

2025-03-05 Thread Jani Nikula
Rebase of [1]. Patch 1 allows #include "i915_drv.h" to be removed from intel_atomic_plane.c in patch 2. BR, Jani. [1] https://lore.kernel.org/r/20250228142539.3216960-1-jani.nik...@intel.com Jani Nikula (2): drm/xe/compat: refactor compat i915_drv.h drm/i915/plane: convert intel_atomic_plan

[PATCH v2 2/2] drm/i915/plane: convert intel_atomic_plane.[ch] to struct intel_display

2025-03-05 Thread Jani Nikula
Going forward, struct intel_display is the main display device data pointer. Convert intel_atomic_plane.[ch] to struct intel_display. Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_atomic_plane.c | 78 +-- 1 file changed, 38 insertions(+), 40 deletions(-) diff --g

[PATCH v2 1/2] drm/xe/compat: refactor compat i915_drv.h

2025-03-05 Thread Jani Nikula
The compat i915_drv.h contains things that aren't there in the original i915_drv.h. Split out gem/i915_gem_object.h and i915_scheduler_types.h, moving the corresponding pieces out, including FORCEWAKE_ALL to intel_uncore.h. Technically I915_PRIORITY_DISPLAY should be in i915_priolist_types.h, but

Re: [PATCH v2] i915/selftest/igt_mmap: let mmap tests run in kthread

2025-03-05 Thread Krzysztof Niemiec
Hi Mikolaj, On 2025-03-04 at 09:43:26 GMT, Mikolaj Wasiak wrote: > When the driver is loaded on the system with numa nodes it might be run in > a kthread, which makes it impossible to use current->mm in the selftest. > This patch allows the selftest to use current->mm by using active_mm. > > Sign

Re: [PATCH v4 4/8] bits: introduce fixed-type BIT

2025-03-05 Thread Andy Shevchenko
On Thu, Mar 06, 2025 at 02:17:18AM +0900, Vincent Mailhol wrote: > On 06/03/2025 at 00:48, Andy Shevchenko wrote: > > On Wed, Mar 05, 2025 at 11:48:10PM +0900, Vincent Mailhol wrote: > >> On 05/03/2025 at 23:33, Andy Shevchenko wrote: > >>> On Wed, Mar 05, 2025 at 10:00:16PM +0900, Vincent Mailhol

Re: [v3 01/23] drm: color pipeline base work

2025-03-05 Thread kernel test robot
Hi Uma, kernel test robot noticed the following build errors: [auto build test ERROR on next-20250305] [also build test ERROR on v6.14-rc5] [cannot apply to drm-exynos/exynos-drm-next linus/master v6.14-rc5 v6.14-rc4 v6.14-rc3] [If your patch is applied to the wrong git tree, kindly drop us a

Re: [PATCH v4 3/8] bits: introduce fixed-type genmasks

2025-03-05 Thread Andy Shevchenko
On Thu, Mar 06, 2025 at 01:48:49AM +0900, Vincent Mailhol wrote: > On 06/03/2025 at 00:47, Yury Norov wrote: > > On Wed, Mar 05, 2025 at 10:00:15PM +0900, Vincent Mailhol via B4 Relay > > wrote: ... > > Having, in fact, different implementations of the same macro for kernel > > and userspace is

Re: Discussion: Moving away from Patchwork for Intel i915/Xe CI

2025-03-05 Thread Lucas De Marchi
On Wed, Mar 05, 2025 at 07:52:31PM +0200, Jani Nikula wrote: On Wed, 05 Mar 2025, "Knop, Ryszard" wrote: Hey everyone, Patchwork has been having lots of issues recently, dropping patches, being unusably slow and generally starting to become more of a pain than help. Over on the CI side we are

Re: [v3 01/23] drm: color pipeline base work

2025-03-05 Thread kernel test robot
Hi Uma, kernel test robot noticed the following build errors: [auto build test ERROR on next-20250305] [also build test ERROR on v6.14-rc5] [cannot apply to drm-exynos/exynos-drm-next linus/master v6.14-rc5 v6.14-rc4 v6.14-rc3] [If your patch is applied to the wrong git tree, kindly drop us a

Re: [v3 01/23] drm: color pipeline base work

2025-03-05 Thread kernel test robot
Hi Uma, kernel test robot noticed the following build warnings: [auto build test WARNING on next-20250305] [also build test WARNING on v6.14-rc5] [cannot apply to drm-exynos/exynos-drm-next linus/master v6.14-rc5 v6.14-rc4 v6.14-rc3] [If your patch is applied to the wrong git tree, kindly drop

✗ Fi.CI.CHECKPATCH: warning for drm/xe/compat: cleanup

2025-03-05 Thread Patchwork
== Series Details == Series: drm/xe/compat: cleanup URL : https://patchwork.freedesktop.org/series/145854/ State : warning == Summary == Error: dim checkpatch failed 0e1c61e96f57 drm/xe/compat: refactor compat i915_drv.h -:36: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does M

✗ i915.CI.BAT: failure for drm/xe/compat: cleanup

2025-03-05 Thread Patchwork
== Series Details == Series: drm/xe/compat: cleanup URL : https://patchwork.freedesktop.org/series/145854/ State : failure == Summary == CI Bug Log - changes from CI_DRM_16230 -> Patchwork_145854v1 Summary --- **FAILURE** Serious

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix harmfull driver register/unregister assymetry (rev4)

2025-03-05 Thread Patchwork
== Series Details == Series: drm/i915: Fix harmfull driver register/unregister assymetry (rev4) URL : https://patchwork.freedesktop.org/series/144436/ State : warning == Summary == Error: dim checkpatch failed fc579ebc3a39 drm/i915: Skip harmful unregister steps if not registered -:14: WARNING

✗ Fi.CI.SPARSE: warning for drm/i915: Fix harmfull driver register/unregister assymetry (rev4)

2025-03-05 Thread Patchwork
== Series Details == Series: drm/i915: Fix harmfull driver register/unregister assymetry (rev4) URL : https://patchwork.freedesktop.org/series/144436/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ i915.CI.BAT: success for drm/i915: Fix harmfull driver register/unregister assymetry (rev4)

2025-03-05 Thread Patchwork
== Series Details == Series: drm/i915: Fix harmfull driver register/unregister assymetry (rev4) URL : https://patchwork.freedesktop.org/series/144436/ State : success == Summary == CI Bug Log - changes from CI_DRM_16231 -> Patchwork_144436v4

RE: [PATCH v2 1/2] drm/xe/compat: refactor compat i915_drv.h

2025-03-05 Thread Garg, Nemesa
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Wednesday, March 5, 2025 10:08 PM > To: intel-gfx@lists.freedesktop.org > Cc: intel...@lists.freedesktop.org; Nikula, Jani ; > Vivi, > Rodrigo > Subject: [PATCH v2 1/2] drm/xe/compat: refactor compat i915_drv.h >

RE: [PATCH v2 2/2] drm/i915/plane: convert intel_atomic_plane.[ch] to struct intel_display

2025-03-05 Thread Garg, Nemesa
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Wednesday, March 5, 2025 10:08 PM > To: intel-gfx@lists.freedesktop.org > Cc: intel...@lists.freedesktop.org; Nikula, Jani ; > Vivi, > Rodrigo > Subject: [PATCH v2 2/2] drm/i915/plane: convert intel_atomic_plane