RE: [PATCH] drm/xe/display: Re-use display vmas when possible

> -Original Message- > From: Intel-xe On Behalf Of > Maarten Lankhorst > Sent: Friday, December 6, 2024 1:10 AM > To: intel...@lists.freedesktop.org > Cc: intel-gfx@lists.freedesktop.org; Maarten Lankhorst > Subject: [PATCH] drm/xe/display: Re-use display vmas when possible > > i915 h

[PATCH v4 00/11] mtd: add driver for Intel discrete graphics

Add driver for access to Intel discrete graphics card internal NVM device. Expose device on auxiliary bus by i915 and Xe drivers and provide mtd driver to register this device with MTD framework. This is a rewrite of "drm/i915/spi: spi access for discrete graphics" and "spi: add driver for Intel d

[PATCH v4 01/11] mtd: core: always create master device

Create master device without partition when CONFIG_MTD_PARTITIONED_MASTER flag is unset. This streamlines device tree and allows to anchor runtime power management on master device in all cases. Signed-off-by: Alexander Usyskin --- drivers/mtd/mtdcore.c | 123 ---

[PATCH v4 02/11] mtd: add driver for intel graphics non-volatile memory device

Add auxiliary driver for intel discrete graphics non-volatile memory device. CC: Lucas De Marchi Reviewed-by: Rodrigo Vivi Acked-by: Miquel Raynal Co-developed-by: Tomas Winkler Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- MAINTAINERS| 7 ++ dr

[PATCH v4 03/11] mtd: intel-dg: implement region enumeration

In intel-dg, there is no access to the spi controller, the information is extracted from the descriptor region. CC: Lucas De Marchi Reviewed-by: Rodrigo Vivi Acked-by: Miquel Raynal Co-developed-by: Tomas Winkler Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/mtd/

[PATCH v4 06/11] mtd: intel-dg: align 64bit read and write

GSC NVM controller HW errors on quad access overlapping 1K border. Align 64bit read and write to avoid readq/writeq over 1K border. Acked-by: Miquel Raynal Signed-off-by: Alexander Usyskin --- drivers/mtd/devices/mtd-intel-dg.c | 35 ++ 1 file changed, 35 insertions(

[PATCH v4 04/11] mtd: intel-dg: implement access functions

Implement read(), erase() and write() functions. CC: Lucas De Marchi CC: Rodrigo Vivi Acked-by: Miquel Raynal Co-developed-by: Tomas Winkler Signed-off-by: Tomas Winkler Co-developed-by: Vitaly Lubart Signed-off-by: Vitaly Lubart Signed-off-by: Alexander Usyskin --- drivers/mtd/devices/mt

[PATCH v4 05/11] mtd: intel-dg: register with mtd

Register the on-die nvm device with the mtd subsystem. Refcount nvm object on _get and _put mtd callbacks. For erase operation address and size should be 4K aligned. For write operation address and size has to be 4bytes aligned. CC: Rodrigo Vivi CC: Lucas De Marchi Acked-by: Miquel Raynal Co-de

[PATCH v4 10/11] drm/xe/nvm: add on-die non-volatile memory device

Enable access to internal non-volatile memory on DGFX with GSC/CSC devices via a child device. The nvm child device is exposed via auxiliary bus. Reviewed-by: Rodrigo Vivi Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/xe_device.c |

[PATCH v4 07/11] mtd: intel-dg: wake card on operations

Enable runtime PM in mtd driver to notify graphics driver that whole card should be kept awake while nvm operations are performed through this driver. CC: Lucas De Marchi Acked-by: Miquel Raynal Signed-off-by: Alexander Usyskin --- drivers/mtd/devices/mtd-intel-dg.c | 79 ++

[PATCH v4 08/11] drm/i915/nvm: add nvm device for discrete graphics

Enable access to internal non-volatile memory on DGFX devices via a child device. The nvm child device is exposed via auxiliary bus. CC: Lucas De Marchi Reviewed-by: Rodrigo Vivi Co-developed-by: Tomas Winkler Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/

[PATCH v4 11/11] drm/xe/nvm: add support for access mode

Check NVM access mode from GSC FW status registers and overwrite access status read from SPI descriptor, if needed. Reviewed-by: Rodrigo Vivi Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/xe/regs/xe_gsc_regs.h | 4 drivers/gpu/drm/xe/xe_heci_gsc.c | 5 + drivers/gpu/drm/x

[PATCH v4 09/11] drm/i915/nvm: add support for access mode

Check NVM access mode from GSC FW status registers and overwrite access status read from SPI descriptor, if needed. Reviewed-by: Rodrigo Vivi Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/intel_nvm.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) di

RE: [PATCH v3 06/10] mtd: intel-dg: wake card on operations

> >> > >> >> If so, I have to add patch for mtd subsystem to always have device for > >> master > >> >> initialized regardless of kernel flag. > >> >> Only to initialize struct device, not to create full mtd node. > >> >> > >> >> Miquel - are you agree to this? > >> > >> Conceptually yes, but pleas

✗ Fi.CI.CHECKPATCH: warning for mtd: add driver for Intel discrete graphics (rev4)

== Series Details == Series: mtd: add driver for Intel discrete graphics (rev4) URL : https://patchwork.freedesktop.org/series/140306/ State : warning == Summary == Error: dim checkpatch failed dbe03a6f690c mtd: core: always create master device -:91: CHECK:UNNECESSARY_PARENTHESES: Unnecessary

✗ Fi.CI.SPARSE: warning for mtd: add driver for Intel discrete graphics (rev4)

== Series Details == Series: mtd: add driver for Intel discrete graphics (rev4) URL : https://patchwork.freedesktop.org/series/140306/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ i915.CI.BAT: failure for mtd: add driver for Intel discrete graphics (rev4)

== Series Details == Series: mtd: add driver for Intel discrete graphics (rev4) URL : https://patchwork.freedesktop.org/series/140306/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15892 -> Patchwork_140306v4 Summary --