[core-for-CI] Revert "lockdep: Enable PROVE_RAW_LOCK_NESTING with PROVE_LOCKING."

2024-12-11 Thread Luca Coelho
This reverts commit 560af5dc839eef08a273908f390cfefefb82aa04. Signed-off-by: Luca Coelho --- lib/Kconfig.debug | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index f3d723705879..de4ffe09323b 100644 --- a/lib/Kconfig.debug +

[PATCH v4 0/4] Implement Wa_14022698537

2024-12-11 Thread Raag Jadav
This series implements Wa_14022698537 for DG2 along with its prerequisites in i915. Detailed description in commit message. v1: https://patchwork.freedesktop.org/series/139628/ v2: Introduce DG2_WA subplatform for workaround (Jani) Fix Wa_ID and include it in subject (Badal) Rephrase comm

Re: [PATCH] drm/i915/display: use IS_ERR_OR_NULL macro on DP tunnel mgr creation failure

2024-12-11 Thread Krzysztof Karas
Thanks for review! > > --- a/drivers/gpu/drm/i915/display/intel_dp_tunnel.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp_tunnel.c > > @@ -793,7 +793,7 @@ int intel_dp_tunnel_mgr_init(struct intel_display > > *display) > > drm_connector_list_iter_end(&connector_list_iter); > > > > tun

Re: [PATCH] drm/i915/display: use IS_ERR_OR_NULL macro on DP tunnel mgr creation failure

2024-12-11 Thread Krzysztof Karas
Thanks for review! > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_tunnel.c > > b/drivers/gpu/drm/i915/display/intel_dp_tunnel.c > > index 94198bc04939..6c960416f776 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp_tunnel.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp_tunnel.c > >

[PATCH v4 1/4] drm/intel/pciids: Refactor DG2 PCI IDs into segment ranges

2024-12-11 Thread Raag Jadav
Refactor DG2 PCI IDs into D, E and M ranges which will be useful for segment specific features. v3: Rework subplatform naming (Jani) Signed-off-by: Raag Jadav Acked-by: Jani Nikula Reviewed-by: Riana Tauro Reviewed-by: Andi Shyti --- include/drm/intel/pciids.h | 55 ++

✗ Fi.CI.SPARSE: warning for Implement Wa_14022698537 (rev3)

2024-12-11 Thread Patchwork
== Series Details == Series: Implement Wa_14022698537 (rev3) URL : https://patchwork.freedesktop.org/series/139883/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Implement Wa_14022698537 (rev3)

2024-12-11 Thread Patchwork
== Series Details == Series: Implement Wa_14022698537 (rev3) URL : https://patchwork.freedesktop.org/series/139883/ State : warning == Summary == Error: dim checkpatch failed ba38e573b559 drm/intel/pciids: Refactor DG2 PCI IDs into segment ranges -:28: ERROR:COMPLEX_MACRO: Macros with complex

[PATCH 1/2] drm/i915/dp: add g4x_dp_compute_config()

2024-12-11 Thread Jani Nikula
Add g4x_dp_compute_config() instead of using intel_dp_compute_config() directly, in order to slightly reduce the clutter in the latter wrt ->has_pch_encoder. Cc: Ville Syrjala Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/g4x_dp.c | 14 +- drivers/gpu/drm/i915/displa

[PATCH 2/2] drm/i915/dp: move g4x_dp_set_clock() call to g4x_dp_compute_config()

2024-12-11 Thread Jani Nikula
It does not look like anything in intel_dp_compute_config() after the g4x_dp_set_clock() call depends on the changes it makes, namely setting dpll and clock_set in crtc_state. Move the call one level higher to g4x_dp_compute_config() to reduce the clutter in intel_dp_compute_config(). Cc: Ville Sy

✓ i915.CI.BAT: success for Implement Wa_14022698537 (rev3)

2024-12-11 Thread Patchwork
== Series Details == Series: Implement Wa_14022698537 (rev3) URL : https://patchwork.freedesktop.org/series/139883/ State : success == Summary == CI Bug Log - changes from CI_DRM_15819 -> Patchwork_139883v3 Summary --- **SUCCESS**

Re: [PATCH] drm/i915/display: use IS_ERR_OR_NULL macro on DP tunnel mgr creation failure

2024-12-11 Thread Imre Deak
On Wed, Dec 11, 2024 at 09:56:50AM +, Krzysztof Karas wrote: > drm_dp_tunnel_mgr_create() may return NULL on failure, which will not > be caught via IS_ERR(), so replace it with IS_ERR_OR_NULL() macro. > > Signed-off-by: Krzysztof Karas > --- > drivers/gpu/drm/i915/display/intel_dp_tunnel.c

✓ i915.CI.BAT: success for Revert "lockdep: Enable PROVE_RAW_LOCK_NESTING with PROVE_LOCKING." (rev2)

2024-12-11 Thread Patchwork
== Series Details == Series: Revert "lockdep: Enable PROVE_RAW_LOCK_NESTING with PROVE_LOCKING." (rev2) URL : https://patchwork.freedesktop.org/series/142298/ State : success == Summary == CI Bug Log - changes from CI_DRM_15819 -> Patchwork_142298v2 ===

Re: [PATCH 2/2] drm/i915/dp: move g4x_dp_set_clock() call to g4x_dp_compute_config()

2024-12-11 Thread Ville Syrjälä
On Wed, Dec 11, 2024 at 02:54:31PM +0200, Jani Nikula wrote: > It does not look like anything in intel_dp_compute_config() after the > g4x_dp_set_clock() call depends on the changes it makes, namely setting > dpll and clock_set in crtc_state. Hmm, yeah I was a bit worried about DRRS and such, but

✓ i915.CI.BAT: success for series starting with [1/2] drm/i915/dp: add g4x_dp_compute_config()

2024-12-11 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp: add g4x_dp_compute_config() URL : https://patchwork.freedesktop.org/series/142411/ State : success == Summary == CI Bug Log - changes from CI_DRM_15819 -> Patchwork_142411v1 ===

✗ i915.CI.Full: failure for Implement Wa_14022698537 (rev3)

2024-12-11 Thread Patchwork
== Series Details == Series: Implement Wa_14022698537 (rev3) URL : https://patchwork.freedesktop.org/series/139883/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15819_full -> Patchwork_139883v3_full Summary --- **FA

[PATCH v1] drm/ci: uprev IGT

2024-12-11 Thread Vignesh Raman
Uprev IGT to the latest version and update expectation files. Signed-off-by: Vignesh Raman --- v1: - Pipeline link - https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1327810 Will update the flake bug report link after v1 is reviewed. --- drivers/gpu/drm/ci/gitlab-ci.yml

Re: [PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2024-12-11 Thread Johan Hovold
On Wed, Dec 11, 2024 at 03:04:12PM +0200, Abel Vesa wrote: > +/** > + * drm_dp_lttpr_set_transparent_mode - set the LTTPR in transparent mode > + * @aux: DisplayPort AUX channel > + * @enable: Enable or disable transparent mode > + * > + * Returns 0 on success or a negative error code on failure.

[PATCH] drm/i915/mst: use intel_dp_compute_config_limits() for DP MST

2024-12-11 Thread Jani Nikula
There's a lot of duplication between mst_stream_compute_config_limits() and intel_dp_compute_config_limits(). Adjust the latter to suit the needs of the former, and use the same function for both. This reduces duplication and highlights the differences for SST and MST and UHBR. Remove the kernel-d

[PATCH v2] drm/display: use ERR_PTR on DP tunnel manager creation fail

2024-12-11 Thread Krzysztof Karas
Instead of returning a generic NULL on error from drm_dp_tunnel_mgr_create(), use error pointers with informative codes. This will also trigger IS_ERR() in current caller (intel_dp_tunnerl_mgr_init()) instead of bypassing it via NULL pointer. v2: use error codes inside drm_dp_tunnel_mgr_create() i

Re: [PATCH v2 4/4] drm/msm/dp: Add support for LTTPR handling

2024-12-11 Thread Johan Hovold
On Wed, Dec 11, 2024 at 03:04:15PM +0200, Abel Vesa wrote: > +static void msm_dp_display_lttpr_init(struct msm_dp_display_private *dp) > +{ > + int lttpr_count; > + > + if (drm_dp_read_lttpr_common_caps(dp->aux, dp->panel->dpcd, > + dp->lttpr_caps)) >

Re: [PATCH v2] drm/display: use ERR_PTR on DP tunnel manager creation fail

2024-12-11 Thread Andi Shyti
Hi Krzysztof, On Wed, Dec 11, 2024 at 02:52:20PM +, Krzysztof Karas wrote: > Instead of returning a generic NULL on error from drm_dp_tunnel_mgr_create(), > use error pointers with informative codes. This will also trigger IS_ERR() in > current caller (intel_dp_tunnerl_mgr_init()) instead of b

Re: [PATCH v2] drm/display: use ERR_PTR on DP tunnel manager creation fail

2024-12-11 Thread Andi Shyti
On Wed, Dec 11, 2024 at 04:18:06PM +0100, Andi Shyti wrote: > Hi Krzysztof, > > On Wed, Dec 11, 2024 at 02:52:20PM +, Krzysztof Karas wrote: > > Instead of returning a generic NULL on error from > > drm_dp_tunnel_mgr_create(), > > use error pointers with informative codes. This will also trig

✗ Fi.CI.CHECKPATCH: warning for drm/ci: uprev IGT (rev2)

2024-12-11 Thread Patchwork
== Series Details == Series: drm/ci: uprev IGT (rev2) URL : https://patchwork.freedesktop.org/series/135749/ State : warning == Summary == Error: dim checkpatch failed 954d51ca75ac drm/ci: uprev IGT -:858: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updat

✗ i915.CI.Full: failure for series starting with [1/2] drm/i915/dp: add g4x_dp_compute_config()

2024-12-11 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp: add g4x_dp_compute_config() URL : https://patchwork.freedesktop.org/series/142411/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15819_full -> Patchwork_142411v1_full =

✗ Fi.CI.CHECKPATCH: warning for drm/display: use ERR_PTR on DP tunnel manager creation fail

2024-12-11 Thread Patchwork
== Series Details == Series: drm/display: use ERR_PTR on DP tunnel manager creation fail URL : https://patchwork.freedesktop.org/series/142423/ State : warning == Summary == Error: dim checkpatch failed aa96e1997901 drm/display: use ERR_PTR on DP tunnel manager creation fail -:6: WARNING:COMMI

✓ i915.CI.BAT: success for drm/i915/mst: use intel_dp_compute_config_limits() for DP MST

2024-12-11 Thread Patchwork
== Series Details == Series: drm/i915/mst: use intel_dp_compute_config_limits() for DP MST URL : https://patchwork.freedesktop.org/series/142422/ State : success == Summary == CI Bug Log - changes from CI_DRM_15821 -> Patchwork_142422v1 Sum

✓ i915.CI.BAT: success for drm/ci: uprev IGT (rev2)

2024-12-11 Thread Patchwork
== Series Details == Series: drm/ci: uprev IGT (rev2) URL : https://patchwork.freedesktop.org/series/135749/ State : success == Summary == CI Bug Log - changes from CI_DRM_15821 -> Patchwork_135749v2 Summary --- **SUCCESS** No reg

Re: [PATCH v1] drm/ci: uprev IGT

2024-12-11 Thread Helen Mae Koike Fornazier
Hi Vignesh, thanks for the patch. On Wed, 11 Dec 2024 11:28:05 -0300 Vignesh Raman wrote --- > Uprev IGT to the latest version and update expectation files. > > Signed-off-by: Vignesh Raman vignesh.ra...@collabora.com> > --- > > v1: > - Pipeline link - > https://gitlab.

✓ i915.CI.BAT: success for drm/display: use ERR_PTR on DP tunnel manager creation fail

2024-12-11 Thread Patchwork
== Series Details == Series: drm/display: use ERR_PTR on DP tunnel manager creation fail URL : https://patchwork.freedesktop.org/series/142423/ State : success == Summary == CI Bug Log - changes from CI_DRM_15821 -> Patchwork_142423v1 Summa

Re: [core-for-CI] Revert "lockdep: Enable PROVE_RAW_LOCK_NESTING with PROVE_LOCKING."

2024-12-11 Thread Lucas De Marchi
On Wed, Dec 11, 2024 at 02:16:35PM +0200, Luca Coelho wrote: This reverts commit 560af5dc839eef08a273908f390cfefefb82aa04. Signed-off-by: Luca Coelho I added some more context to the commit message and pushed to topic/core-for-CI with Rodrigo's ack: 81827bbe1d8b ("Revert "lockdep: Enable

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-11 Thread Maxime Ripard
On Wed, Dec 04, 2024 at 01:17:17PM +0200, Raag Jadav wrote: > + misc maintainers > > On Tue, Dec 03, 2024 at 11:18:00AM +0100, Christian König wrote: > > Am 03.12.24 um 06:00 schrieb Raag Jadav: > > > On Mon, Dec 02, 2024 at 10:07:59AM +0200, Raag Jadav wrote: > > > > On Fri, Nov 29, 2024 at 10:40

Re: [PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2024-12-11 Thread Dmitry Baryshkov
On Wed, Dec 11, 2024 at 03:42:27PM +0100, Johan Hovold wrote: > On Wed, Dec 11, 2024 at 03:04:12PM +0200, Abel Vesa wrote: > > > +/** > > + * drm_dp_lttpr_set_transparent_mode - set the LTTPR in transparent mode > > + * @aux: DisplayPort AUX channel > > + * @enable: Enable or disable transparent

Re: [PATCH v1] drm/ci: uprev IGT

2024-12-11 Thread Dmitry Baryshkov
On Wed, Dec 11, 2024 at 07:58:05PM +0530, Vignesh Raman wrote: > Uprev IGT to the latest version and update expectation files. > > Signed-off-by: Vignesh Raman > --- > > v1: > - Pipeline link - > https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1327810 > Will update the flake

✓ i915.CI.Full: success for drm/display: use ERR_PTR on DP tunnel manager creation fail

2024-12-11 Thread Patchwork
== Series Details == Series: drm/display: use ERR_PTR on DP tunnel manager creation fail URL : https://patchwork.freedesktop.org/series/142423/ State : success == Summary == CI Bug Log - changes from CI_DRM_15821_full -> Patchwork_142423v1_full =

Re: [PATCH] drm/xe/display: Use a single early init call for display

2024-12-11 Thread Maarten Lankhorst
Hey Jani, I believe at least for the platforms xe cares about (gen12+), display is sufficiently separated that everything can be performed in a single init call before we enable interrupts. Because of the strict separation between xe and display, it should be fine to keep the ordering as-is

Re: [PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2024-12-11 Thread Dmitry Baryshkov
On Wed, Dec 11, 2024 at 03:42:27PM +0100, Johan Hovold wrote: > On Wed, Dec 11, 2024 at 03:04:12PM +0200, Abel Vesa wrote: > > > +/** > > + * drm_dp_lttpr_set_transparent_mode - set the LTTPR in transparent mode > > + * @aux: DisplayPort AUX channel > > + * @enable: Enable or disable transparent

✓ i915.CI.BAT: success for drm/xe/display: Program double buffered LUT registers

2024-12-11 Thread Patchwork
== Series Details == Series: drm/xe/display: Program double buffered LUT registers URL : https://patchwork.freedesktop.org/series/142437/ State : success == Summary == CI Bug Log - changes from CI_DRM_15825 -> Patchwork_142437v1 Summary ---

[PULL] drm-intel-next

2024-12-11 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our first drm-intel-next round targeting 6.14. One drm/print change coming from here. The rest is mostly display changes and one GSC FW update for ARL platforms. Thanks, Rodrigo. drm-intel-next-2024-12-11: Core Changes: - drm/print: add drm_print_hex_dump() Driver

Re: [PATCH 2/2] drm/i915/dp: move g4x_dp_set_clock() call to g4x_dp_compute_config()

2024-12-11 Thread Jani Nikula
On Wed, 11 Dec 2024, Ville Syrjälä wrote: > On Wed, Dec 11, 2024 at 02:54:31PM +0200, Jani Nikula wrote: >> It does not look like anything in intel_dp_compute_config() after the >> g4x_dp_set_clock() call depends on the changes it makes, namely setting >> dpll and clock_set in crtc_state. > > Hmm,

[PATCH v4 2/4] drm/i915/dg2: Introduce DG2_D subplatform

2024-12-11 Thread Raag Jadav
Introduce DG2_D subplatform for the devices that span across multiple DG2 subplatforms but are within same segment and will be useful for segment specific features. v3: Rework subplatform naming (Jani) Split subplatform check into separate case (Jani) Signed-off-by: Raag Jadav Acked-by: Jani

✗ i915.CI.BAT: failure for drm/i915/display: use IS_ERR_OR_NULL macro on DP tunnel mgr creation failure

2024-12-11 Thread Patchwork
== Series Details == Series: drm/i915/display: use IS_ERR_OR_NULL macro on DP tunnel mgr creation failure URL : https://patchwork.freedesktop.org/series/142404/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15819 -> Patchwork_142404v1 =

[PATCH v4 3/4] drm/i915: Introduce intel_cpu_info.c for CPU IDs

2024-12-11 Thread Raag Jadav
Having similar naming convention in intel-family.h and intel_device_info.h results in redefinition of a few platforms. Define CPU IDs in its own file to avoid this. v3: Move file out of gt directory, add kernel doc (Riana) Rephrase file description (Jani) Signed-off-by: Raag Jadav Acked-by:

✗ i915.CI.Full: failure for drm/ci: uprev IGT (rev2)

2024-12-11 Thread Patchwork
== Series Details == Series: drm/ci: uprev IGT (rev2) URL : https://patchwork.freedesktop.org/series/135749/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15821_full -> Patchwork_135749v2_full Summary --- **FAILURE**

✓ i915.CI.Full: success for drm/i915/mst: use intel_dp_compute_config_limits() for DP MST

2024-12-11 Thread Patchwork
== Series Details == Series: drm/i915/mst: use intel_dp_compute_config_limits() for DP MST URL : https://patchwork.freedesktop.org/series/142422/ State : success == Summary == CI Bug Log - changes from CI_DRM_15821_full -> Patchwork_142422v1_full ===

[PATCH v4 4/4] drm/i915/dg2: Implement Wa_14022698537

2024-12-11 Thread Raag Jadav
G8 power state entry is disabled due to a limitation on DG2, so we enable it from driver with Wa_14022698537. For now we enable it for all DG2 devices with the exception of a few, for which, we enable only when paired with whitelisted CPU models. This works with native ASPM and reduces idle power c

[PULL] drm-intel-fixes

2024-12-11 Thread Tvrtko Ursulin
Hi Dave, Sima, A handful of fixes for the weekly release candidate cycle: One fix for a performance regression in DSB register programming and also in the same area a partial fix for the legacy LUT and DSB interaction. Then there is a fix for a null pointer dereference in the GuC error state ca

[RFC PATCH] drm/xe/display: Program double buffered LUT registers

2024-12-11 Thread Chaitanya Kumar Borah
>From PTL, LUT registers are made double buffered. This helps us to program them in the active region without any concern of tearing. This particulary helps in case of displays with high refresh rates where vblank periods are shorter. This patch tries to incorporates LUT programming to the noarm c

Re: [PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2024-12-11 Thread Dmitry Baryshkov
On Wed, Dec 11, 2024 at 03:04:12PM +0200, Abel Vesa wrote: > According to the DisplayPort standard, LTTPRs have two operating > modes: > - non-transparent - it replies to DPCD LTTPR field specific AUX >requests, while passes through all other AUX requests > - transparent - it passes through a

Re: [PATCH v2] drm/display: use ERR_PTR on DP tunnel manager creation fail

2024-12-11 Thread Andi Shyti
Hi Krzysztof, On Wed, Dec 11, 2024 at 02:52:20PM +, Krzysztof Karas wrote: > Instead of returning a generic NULL on error from drm_dp_tunnel_mgr_create(), > use error pointers with informative codes. This will also trigger IS_ERR() in > current caller (intel_dp_tunnerl_mgr_init()) instead of b

[PATCH v3 10/11] drm/i915/dp_mst: Fix error handling while adding a connector

2024-12-11 Thread Imre Deak
After an error during adding an MST connector the MST port and the intel_connector object could be leaked, fix this up. Reviewed-by: Rodrigo Vivi Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) dif

[PATCH v3 08/11] drm/connector: Warn if a connector is registered/added incorrectly

2024-12-11 Thread Imre Deak
All the drivers should be converted now to use drm_connector_dynamic_init() for MST connectors, hence drm_connector_dynamic_register()->drm_connector_add() can WARN now if this was not the case (for instance if a driver inited an MST connector with one of the drm_connector_init*() functions incorre

[PATCH v3 11/11] drm/i915/dp_mst: Use intel_connector vs. drm_connector pointer in intel_dp_mst.c

2024-12-11 Thread Imre Deak
Follow the canonical way in intel_dp_mst.c, referencing a connector only via a struct intel_connector pointer and naming this pointer 'connector' instead of 'intel_connector', the only exception being the casting of a drm_connector function parameter pointer to intel_connector, calling the drm_conn

[PATCH v3 07/11] drm/nouveau/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-12-11 Thread Imre Deak
After a connector is added to the drm_mode_config::connector_list, it's visible to any in-kernel users looking up connectors via the above list. Make sure that the connector is properly initialized before such look-ups, by initializing the connector with drm_connector_dynamic_register() - which doe

[PATCH v3 09/11] drm/tests: Add tests for drm_connector_dynamic_init()/register()

2024-12-11 Thread Imre Deak
Add kunit tests for drm_connector_dynamic_init()/drm_connector_dynamic_register() added in this patchset. Suggested-by: Maxime Ripard Signed-off-by: Imre Deak --- drivers/gpu/drm/tests/drm_connector_test.c | 463 + 1 file changed, 463 insertions(+) diff --git a/drivers/gpu/

[PATCH v3 03/11] drm/connector: Add deprication notes for drm_connector_register/unregister

2024-12-11 Thread Imre Deak
Drivers should register/unregister only dynamic (MST) connectors manually using drm_connector_dynamic_register()/unregister(). Static connectors are registered/unregistered by the DRM core automatically. Some drivers still call drm_connector_register()/ unregister() for static connectors, both of w

[PATCH v3 0/7] drm/connector: Expose only a properly inited connector

2024-12-11 Thread Imre Deak
This is v3 of [1], with the following changes: - Instead of the drm_connector_init_core()/drm_connector_add() add a drm_connector_dynamic_init()/drm_connector_dynamic_register() interface. Adding the connector to the connector list is now part of the registration step done by the latter func

[PATCH v3 01/11] drm/connector: Add a way to init/add a connector in separate steps

2024-12-11 Thread Imre Deak
Atm when the connector is added to the drm_mode_config::connector_list, the connector may not be fully initialized yet. This is not a problem for static connectors initialized/added during driver loading, for which the driver ensures that look-ups via the above list are not possible until all the c

[PATCH v3 04/11] drm/dp_mst: Register connectors via drm_connector_dynamic_register()

2024-12-11 Thread Imre Deak
MST connectors should be initialized/registered by calling drm_connector_dynamic_init()/drm_connector_dynamic_register(). The previous patch adding these functions explains the issue with the current drm_connector_init*()/drm_connector_register() interface for MST connectors. Based on the above ad

[PATCH v3 05/11] drm/i915/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-12-11 Thread Imre Deak
After a connector is added to the drm_mode_config::connector_list, it's visible to any in-kernel users looking up connectors via the above list. Make sure that the connector is properly initialized before such look-ups, by initializing the connector with drm_connector_dynamic_register() - which doe

[PATCH v3 02/11] drm/connector: Add FIXME for GETRESOURCES ioctl wrt. uninited connectors

2024-12-11 Thread Imre Deak
The connectors enumerated by the GETRESOURCES ioctl may not be fully initialized yet wrt. to the state set up during connector registration (for instance the connector's debugfs/sysfs interfaces may not exist yet). This can happen in two ways: 1. Connectors initialized and added to the drm_mode

[PATCH v3 06/11] drm/amd/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-12-11 Thread Imre Deak
After a connector is added to the drm_mode_config::connector_list, it's visible to any in-kernel users looking up connectors via the above list. Make sure that the connector is properly initialized before such look-ups, by initializing the connector with drm_connector_dynamic_register() - which doe

Re: [PATCH v3 4/4] drm/i915/dg2: Implement Wa_14022698537

2024-12-11 Thread Andi Shyti
On Wed, Dec 11, 2024 at 07:21:54AM +0200, Raag Jadav wrote: > On Tue, Dec 10, 2024 at 01:52:21PM +0100, Andi Shyti wrote: > > Hi Raag, > > > > > +/* Wa_14022698537:dg2 */ > > > +static void i915_enable_g8(struct drm_i915_private *i915) > > > +{ > > > + if (IS_DG2(i915)) { > > > + if (IS_DG

Re: [PATCH] drm/i915/display: use IS_ERR_OR_NULL macro on DP tunnel mgr creation failure

2024-12-11 Thread Andi Shyti
Hi Krzysztof, On Wed, Dec 11, 2024 at 09:56:50AM +, Krzysztof Karas wrote: > drm_dp_tunnel_mgr_create() may return NULL on failure, which will not > be caught via IS_ERR(), so replace it with IS_ERR_OR_NULL() macro. > > Signed-off-by: Krzysztof Karas Fixes: 91888b5b1ad2 ("drm/i915/dp: Add s

Re: [PATCH] drm/i915/display: use IS_ERR_OR_NULL macro on DP tunnel mgr creation failure

2024-12-11 Thread Michal Wajdeczko
On 11.12.2024 10:56, Krzysztof Karas wrote: > drm_dp_tunnel_mgr_create() may return NULL on failure, which will not > be caught via IS_ERR(), so replace it with IS_ERR_OR_NULL() macro. > > Signed-off-by: Krzysztof Karas > --- > drivers/gpu/drm/i915/display/intel_dp_tunnel.c | 2 +- > 1 file c

RE: [PATCH 3/6] drm/i915/display: Replace adjusted mode with pipe mode

2024-12-11 Thread Garg, Nemesa
> -Original Message- > From: Ville Syrjälä > Sent: Saturday, November 23, 2024 1:32 AM > To: Garg, Nemesa > Cc: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Subject: Re: [PATCH 3/6] drm/i915/display: Replace adjusted mode with pipe > mode > > On Wed, Nov 20, 2024 a

RE: [PATCH] drm/i915/display: clean up DP Adaptive Sync SDP state mismatch logging

2024-12-11 Thread Jani Nikula
On Tue, 10 Dec 2024, "Golani, Mitulkumar Ajitkumar" wrote: >> -Original Message- >> From: Intel-gfx On Behalf Of Jani >> Nikula >> Sent: 05 December 2024 15:01 >> To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org >> Cc: Nikula, Jani >> Subject: [PATCH] drm/i915/display

Re: [PATCH RFC 4/4] drm/msm/dp: Add support for LTTPR handling

2024-12-11 Thread Dmitry Baryshkov
On Wed, Dec 11, 2024 at 11:08:16AM +0200, Abel Vesa wrote: > On 24-10-31 18:54:25, Dmitry Baryshkov wrote: > > On Thu, Oct 31, 2024 at 05:12:48PM +0200, Abel Vesa wrote: > > > Link Training Tunable PHY Repeaters (LTTPRs) are defined in DisplayPort > > > 1.4a specification. As the name suggests, the

RE: [PATCH 06/10] mtd: intel-dg: wake card on operations

2024-12-11 Thread Usyskin, Alexander
Adding Kartihik > Subject: Re: [PATCH 06/10] mtd: intel-dg: wake card on operations > > Hi Alexander, > > Please reduce the context when answering, otherwise it's hard to find > all places where you commented. > > >> > > > That's the part that I'm not sure if I agree. if I remember from some >

[PATCH] drm/i915/display: use IS_ERR_OR_NULL macro on DP tunnel mgr creation failure

2024-12-11 Thread Krzysztof Karas
drm_dp_tunnel_mgr_create() may return NULL on failure, which will not be caught via IS_ERR(), so replace it with IS_ERR_OR_NULL() macro. Signed-off-by: Krzysztof Karas --- drivers/gpu/drm/i915/display/intel_dp_tunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/g

[PULL] drm-xe-next

2024-12-11 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our first Xe PR towards 6.14. It's important to highlight that in couple backmerges we had to manually solve some silent conflicts: 1. Namespace conflict issue caused by commit cdd30ebb1b9f ("module: Convert symbol namespace to string literal") and commit 0c45e76fcc62

Re: [PATCH v3 01/11] drm/connector: Add a way to init/add a connector in separate steps

2024-12-11 Thread Lyude Paul
Coming in again with the good patches I see :D Apologies for not seeing these patches before, I really need to figure out a way to keep up with dri-devel outside of patches that are CC'd to me :S (if you ever need me to review something, you're more then welcome to poke me via IRC btw) For patche

✓ i915.CI.BAT: success for drm/connector: Expose only a properly inited connector

2024-12-11 Thread Patchwork
== Series Details == Series: drm/connector: Expose only a properly inited connector URL : https://patchwork.freedesktop.org/series/142445/ State : success == Summary == CI Bug Log - changes from CI_DRM_15827 -> Patchwork_142445v1 Summary --

Re: [PATCH v4 0/4] Implement Wa_14022698537

2024-12-11 Thread Andi Shyti
Hi Raag, > Raag Jadav (4): > drm/intel/pciids: Refactor DG2 PCI IDs into segment ranges > drm/i915/dg2: Introduce DG2_D subplatform > drm/i915: Introduce intel_cpu_info.c for CPU IDs > drm/i915/dg2: Implement Wa_14022698537 merged to drm-intel-next. Thanks, Andi

✗ Fi.CI.CHECKPATCH: warning for drm/connector: Expose only a properly inited connector

2024-12-11 Thread Patchwork
== Series Details == Series: drm/connector: Expose only a properly inited connector URL : https://patchwork.freedesktop.org/series/142445/ State : warning == Summary == Error: dim checkpatch failed f8b5a1808248 drm/connector: Add a way to init/add a connector in separate steps 42da5fe8446c drm

✗ Fi.CI.SPARSE: warning for drm/connector: Expose only a properly inited connector

2024-12-11 Thread Patchwork
== Series Details == Series: drm/connector: Expose only a properly inited connector URL : https://patchwork.freedesktop.org/series/142445/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH v1] drm/ci: uprev IGT

2024-12-11 Thread Vignesh Raman
Hi Dmitry, On 12/12/24 03:09, Dmitry Baryshkov wrote: On Wed, Dec 11, 2024 at 07:58:05PM +0530, Vignesh Raman wrote: Uprev IGT to the latest version and update expectation files. Signed-off-by: Vignesh Raman --- v1: - Pipeline link - https://gitlab.freedesktop.org/vigneshraman/linux/-/pi

Re: [PATCH 3/5] drm/i915/display: Enable the second scaler for sharpness

2024-12-11 Thread Nautiyal, Ankit K
On 11/14/2024 3:48 PM, Nemesa Garg wrote: As only second scaler can be used for sharpness check if it is available and also check if panel fitting is also not enabled, then set the sharpness. Panel fitting will have the preference over sharpness property. v2: Add the panel fitting check before

Re: [PATCH 4/5] drm/i915/display: Add registers and compute the strength

2024-12-11 Thread Nautiyal, Ankit K
On 11/14/2024 3:48 PM, Nemesa Garg wrote: Add new registers and related bits. Compute the strength value and tap value based on display mode. v2: Replace i915/dev_priv with display[Jani] v3: Create separate file for defining register[Jani] Add display->drm in debug prints[Jani] v4: Rebase

Re: [PATCH v1] drm/ci: uprev IGT

2024-12-11 Thread Vignesh Raman
Hi Helen, On 11/12/24 21:57, Helen Mae Koike Fornazier wrote: Hi Vignesh, thanks for the patch. On Wed, 11 Dec 2024 11:28:05 -0300 Vignesh Raman wrote --- > Uprev IGT to the latest version and update expectation files. > > Signed-off-by: Vignesh Raman vignesh.ra...@collabora.com

Re: [PATCH v4 0/4] Implement Wa_14022698537

2024-12-11 Thread Raag Jadav
On Thu, Dec 12, 2024 at 12:40:07AM +0100, Andi Shyti wrote: > Hi Raag, > > > Raag Jadav (4): > > drm/intel/pciids: Refactor DG2 PCI IDs into segment ranges > > drm/i915/dg2: Introduce DG2_D subplatform > > drm/i915: Introduce intel_cpu_info.c for CPU IDs > > drm/i915/dg2: Implement Wa_1402

Re: [PATCH] usb: typec: ucsi: Fix connector status writing past buffer size

2024-12-11 Thread Mario Limonciello
On 12/3/2024 14:00, Lucas De Marchi wrote: Similar to commit 65c4c9447bfc ("usb: typec: ucsi: Fix a missing bits to bytes conversion in ucsi_init()"), there was a missing conversion from bits to bytes. Here the outcome is worse though: since the value is lower than UCSI_MAX_DATA_LENGTH, instead o

Re: [PATCH 2/5] drm/i915/display: Compute the scaler filter coefficients

2024-12-11 Thread Nautiyal, Ankit K
On 11/14/2024 3:48 PM, Nemesa Garg wrote: The sharpness property requires the use of one of the scaler so need to set the sharpness scaler coefficient values. These values are based on experiments and vary for different tap value/win size. These values are normalized by taking the sum of all va

RE: [PATCHv4] drm/i915/dp: Guarantee a minimum HBlank time

2024-12-11 Thread Kandpal, Suraj
> -Original Message- > From: Intel-xe On Behalf Of Arun R > Murthy > Sent: Monday, November 11, 2024 2:56 PM > To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv4] drm/i915/dp: Guarantee a minimum HBlank time > > Mandate a minim