[PATCH v6] drm/i915: Implement Dbuf overlap detection feature starting from LNL

2024-10-29 Thread Vinod Govindapillai
From: Stanislav Lisovskiy >From LNL onwards there is a new hardware feature, which allows to detect if the driver wrongly allocated DBuf entries and they happen to overlap. If enabled this will cause a specific interrupt to occur. We now handle it in the driver, by writing correspondent error mes

[PATCH 2/3] drm/i915/psr: stop using bitwise OR with booleans in wm_optimization_wa()

2024-10-29 Thread Jani Nikula
Bitwise OR for booleans is a bit of an abuse. We can trivially drop the usage. Cc: Jouni Högander Cc: Suraj Kandpal Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_psr.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/d

[PATCH v2] drm/i915/psr: WA for panels stating bad link status after PSR is enabled

2024-10-29 Thread Jouni Högander
We are currently seeing unexpected link trainings with several different eDP panels. These are caused by these panels stating bad link status in their dpcd registers. This can be observed by doing following test: 1. Boot up without Xe module loaded 2. Load Xe module with PSR disabled: $ modpr

✓ Fi.CI.BAT: success for drm/i915/xe3lpd: Power request asserting/deasserting

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/xe3lpd: Power request asserting/deasserting URL : https://patchwork.freedesktop.org/series/140583/ State : success == Summary == CI Bug Log - changes from CI_DRM_15604 -> Patchwork_140583v1 Summary

Re: [RESEND 0/4] drm/i915: add dedicated lock for each sideband

2024-10-29 Thread Hogander, Jouni
On Tue, 2024-10-29 at 11:25 +0200, Jani Nikula wrote: > It's misleading to use the same sideband mutex for LPT/WPT IOSF, > VLV/CHV > IOSF, and punit. Add dedicated locks for clarity. For the whole series: Reviewed-by: Jouni Högander > > Jani Nikula (4): >   drm/i915/sbi: add intel_sbi_{lock,un

✗ Fi.CI.SPARSE: warning for drm/i915/color: Debug improvements and intel_display conversion (rev4)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/color: Debug improvements and intel_display conversion (rev4) URL : https://patchwork.freedesktop.org/series/140452/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./a

✓ Fi.CI.BAT: success for drm/i915/color: Debug improvements and intel_display conversion (rev4)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/color: Debug improvements and intel_display conversion (rev4) URL : https://patchwork.freedesktop.org/series/140452/ State : success == Summary == CI Bug Log - changes from CI_DRM_15604 -> Patchwork_140452v4

✗ Fi.CI.CHECKPATCH: warning for drm/i915/color: Debug improvements and intel_display conversion (rev4)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/color: Debug improvements and intel_display conversion (rev4) URL : https://patchwork.freedesktop.org/series/140452/ State : warning == Summary == Error: dim checkpatch failed a794d5d0b2f5 drm/i915/color: Pimp debugs 2649507ae053 drm/i915: Handle intel_pla

Re: [PATCH v2 0/3] drm/i915 & drm/xe: shared PCI ID macros

2024-10-29 Thread Rodrigo Vivi
On Tue, Oct 29, 2024 at 10:51:35AM +0200, Jani Nikula wrote: > On Tue, 22 Oct 2024, Andi Shyti wrote: > > Hi Jani, > > > >> Jani Nikula (3): > >> drm/i915/pciids: add PVC PCI ID macros > >> drm/intel/pciids: rename i915_pciids.h to just pciids.h > >> drm/xe: switch to common PCI ID macros >

✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/xen: remove redundant initialization info print

2024-10-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/xen: remove redundant initialization info print URL : https://patchwork.freedesktop.org/series/140600/ State : warning == Summary == Error: dim checkpatch failed e8018fe19f82 drm/xen: remove redundant initialization info print f78

Re: [PATCH] drm/i915/display: use x100 version for full version and release

2024-10-29 Thread Lucas De Marchi
On Fri, Oct 25, 2024 at 07:58:29AM -0700, Matt Roper wrote: On Fri, Oct 25, 2024 at 11:49:34AM +0300, Jani Nikula wrote: On Fri, 25 Oct 2024, Ville Syrjälä wrote: > On Thu, Oct 24, 2024 at 08:11:04PM +0300, Jani Nikula wrote: >> Use x100, or ver * 100 + rel, versions for full IP version checks,

[PATCH v3] drm/i915/xe3lpd: Power request asserting/deasserting

2024-10-29 Thread Mika Kahola
There is a HW issue that arises when there are race conditions between TCSS entering/exiting TC7 or TC10 states while the driver is asserting/deasserting TCSS power request. As a workaround, Display driver will implement a mailbox sequence to ensure that the TCSS is in TC0 when TCSS power request i

✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/xen: remove redundant initialization info print

2024-10-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/xen: remove redundant initialization info print URL : https://patchwork.freedesktop.org/series/140600/ State : success == Summary == CI Bug Log - changes from CI_DRM_15604 -> Patchwork_140600v1

Re: [PATCH v2] drm/i915/display: convert I915_STATE_WARN() to struct intel_display

2024-10-29 Thread Jani Nikula
On Thu, 24 Oct 2024, Jani Nikula wrote: > Convert I915_STATE_WARN() to struct intel_display *, and rename to > INTEL_DISPLAY_STATE_WARN(). Do some minor opportunistic struct > drm_i915_private to struct intel_display conversions while at it. > > v2: crtc_state may be NULL in intel_connector_verify

✓ Fi.CI.BAT: success for Add 6k resolution support for a single CRTC (rev5)

2024-10-29 Thread Patchwork
== Series Details == Series: Add 6k resolution support for a single CRTC (rev5) URL : https://patchwork.freedesktop.org/series/139978/ State : success == Summary == CI Bug Log - changes from CI_DRM_15603 -> Patchwork_139978v5 Summary --

RE: [PATCH] drm/i915/xe3lpd: Power request asserting/deasserting

2024-10-29 Thread Kahola, Mika
> -Original Message- > From: Sousa, Gustavo > Sent: Monday, 28 October 2024 17.51 > To: Kahola, Mika ; intel-gfx@lists.freedesktop.org > Cc: Kahola, Mika > Subject: Re: [PATCH] drm/i915/xe3lpd: Power request asserting/deasserting > > Quoting Mika Kahola (2024-10-28 09:58:35-03:00) > >The

Re: [PATCH] drm/i915/gsc: ARL-H and ARL-U need a newer GSC FW.

2024-10-29 Thread Rodrigo Vivi
On Mon, Oct 28, 2024 at 04:31:32PM -0700, Daniele Ceraolo Spurio wrote: > All MTL and ARL SKUs share the same GSC FW, but the newer platforms are > only supported in newer blobs. In particular, ARL-S is supported > starting from 102.0.10.1878 (which is already the minimum required > version for ARL

Re: [PATCH] drm/i915/xe3lpd: Disable HDCP Line Rekeying for Xe3

2024-10-29 Thread Pottumuttu, Sai Teja
On 29-10-2024 10:56, Suraj Kandpal wrote: We need to disable HDCP Line Rekeying for Xe3 when we are using an HDMI encoder. Also remove the Wa comment tag as this follows the bspec and does not implement the wa. v2: add additional definition instead of function, commit message typo fix and upda

Re: [PATCH v2 0/3] drm/i915 & drm/xe: shared PCI ID macros

2024-10-29 Thread Jani Nikula
On Tue, 22 Oct 2024, Andi Shyti wrote: > Hi Jani, > >> Jani Nikula (3): >> drm/i915/pciids: add PVC PCI ID macros >> drm/intel/pciids: rename i915_pciids.h to just pciids.h >> drm/xe: switch to common PCI ID macros > > Reviewed-by: Andi Shyti Thanks. Rodrigo, Lucas, ack for merging via drm

[PATCH] drm/i915/hdcp: Add the loop only for DP encoders

2024-10-29 Thread Suraj Kandpal
Add the loop on the first read and write only for DP/DPMST encoders as this issue is only observed here no need to burden other encoders with extra retries. Fixes: 9d5a05f86d2f ("drm/i915/hdcp: Retry first read and writes to downstream") Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/disp

✓ Fi.CI.BAT: success for drm/i915/dp: Guarantee a minimum HBlank time (rev3)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/dp: Guarantee a minimum HBlank time (rev3) URL : https://patchwork.freedesktop.org/series/139267/ State : success == Summary == CI Bug Log - changes from CI_DRM_15603 -> Patchwork_139267v3 Summary -

Re: [PATCH v2 0/2] drm/ci: add new devices for testing

2024-10-29 Thread Helen Mae Koike Fornazier
On Tue, 22 Oct 2024 06:45:03 -0300 Vignesh Raman wrote --- > Add jobs that execute the IGT test suite for sm8350-hdk and dedede. > > Dropped the refactor software-driver stage jobs patch from this series. > I will send it as a separate patch. > > Successful pipeline link,

[PATCH] drm/i915/crt: convert to struct intel_display

2024-10-29 Thread Jani Nikula
struct intel_display will replace struct drm_i915_private as the main device pointer for display code. Switch CRT code over to it. v2: Rebase Reviewed-by: Rodrigo Vivi Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_crt.c | 209 +- drivers/gpu/drm/i915/di

RE: [PATCH] drm/i915/hdcp: Add the loop only for DP encoders

2024-10-29 Thread Jani Nikula
On Tue, 29 Oct 2024, "Borah, Chaitanya Kumar" wrote: >> -Original Message- >> From: Kandpal, Suraj >> Sent: Tuesday, October 29, 2024 2:23 PM >> To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org >> Cc: Borah, Chaitanya Kumar ; Kandpal, >> Suraj >> Subject: [PATCH] drm/

✓ Fi.CI.BAT: success for drm/i915/psr: WA for panels stating bad link status after PSR is enabled

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/psr: WA for panels stating bad link status after PSR is enabled URL : https://patchwork.freedesktop.org/series/140570/ State : success == Summary == CI Bug Log - changes from CI_DRM_15603 -> Patchwork_140570v1 ==

RE: [PATCH] drm/i915/hdcp: Add the loop only for DP encoders

2024-10-29 Thread Borah, Chaitanya Kumar
> -Original Message- > From: Kandpal, Suraj > Sent: Tuesday, October 29, 2024 2:23 PM > To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar ; Kandpal, > Suraj > Subject: [PATCH] drm/i915/hdcp: Add the loop only for DP encoders > > Add the l

[PATCH 0/3] drm/i915/psr: minor cleanups

2024-10-29 Thread Jani Nikula
Some cleanups in PSR code. If this conflicts with more important stuff, this can wait. Cc: Jouni Högander Cc: Suraj Kandpal Jani Nikula (3): drm/i915/psr: add LATENCY_REPORTING_REMOVED() register bit helper drm/i915/psr: stop using bitwise OR with booleans in wm_optimization_wa() drm/

[PATCH 1/3] drm/i915/psr: add LATENCY_REPORTING_REMOVED() register bit helper

2024-10-29 Thread Jani Nikula
Drop the wa_16013835468_bit_get() function in favour of the register macro. It doesn't have to be so complicated, and we don't have to use the workaround name in everything that's related to it. Cc: Jouni Högander Cc: Suraj Kandpal Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/in

[PATCH 3/3] drm/i915/psr: clarify intel_psr_pre_plane_update() conditions

2024-10-29 Thread Jani Nikula
Make the conditions easier to follow. We don't do anything for !psr->enabled, so hoist psr->enabled check higher, avoiding all the checks when !psr->enabled. Stop the bitwise OR abuse on booleans by removing the temporary variable altogether. Cc: Jouni Högander Cc: Suraj Kandpal Signed-off-by: J

RE: [PATCH 06/10] mtd: intel-dg: wake card on operations

2024-10-29 Thread Usyskin, Alexander
> -Original Message- > From: Gupta, Anshuman > Sent: Monday, October 28, 2024 5:02 PM > To: Vivi, Rodrigo ; Usyskin, Alexander > ; Deak, Imre > Cc: Miquel Raynal ; Richard Weinberger > ; Vignesh Raghavendra ; De Marchi, > Lucas ; Thomas Hellström > ; Maarten Lankhorst > ; Maxime Ripard ;

✗ Fi.CI.SPARSE: warning for Add 6k resolution support for a single CRTC (rev5)

2024-10-29 Thread Patchwork
== Series Details == Series: Add 6k resolution support for a single CRTC (rev5) URL : https://patchwork.freedesktop.org/series/139978/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

[RESEND 1/4] drm/i915/sbi: add intel_sbi_{lock,unlock}()

2024-10-29 Thread Jani Nikula
Abstract the LPT/WPT IOSF sideband locking by adding dedicated sbi lock/unlock functions. Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_pch_refclk.c | 26 +-- drivers/gpu/drm/i915/intel_sbi.c | 10 +++ drivers/gpu/drm/i915/intel_sbi.h

✓ Fi.CI.BAT: success for drm/i915: ensure segment offset never exceeds allowed max (rev5)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915: ensure segment offset never exceeds allowed max (rev5) URL : https://patchwork.freedesktop.org/series/140374/ State : success == Summary == CI Bug Log - changes from CI_DRM_15604 -> Patchwork_140374v5

✗ Fi.CI.CHECKPATCH: warning for drm/i915: ensure segment offset never exceeds allowed max (rev5)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915: ensure segment offset never exceeds allowed max (rev5) URL : https://patchwork.freedesktop.org/series/140374/ State : warning == Summary == Error: dim checkpatch failed ee10652b82f8 drm/i915: ensure segment offset never exceeds allowed max -:45: WARNING:F

✗ Fi.CI.CHECKPATCH: warning for drm/i915/xe3lpd: Power request asserting/deasserting

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/xe3lpd: Power request asserting/deasserting URL : https://patchwork.freedesktop.org/series/140583/ State : warning == Summary == Error: dim checkpatch failed d6195a4d986c drm/i915/xe3lpd: Power request asserting/deasserting -:42: ERROR:COMPLEX_MACRO: Macro

✓ Fi.CI.BAT: success for drm/i915/gsc: ARL-H and ARL-U need a newer GSC FW.

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/gsc: ARL-H and ARL-U need a newer GSC FW. URL : https://patchwork.freedesktop.org/series/140620/ State : success == Summary == CI Bug Log - changes from CI_DRM_15605 -> Patchwork_140620v1 Summary --

✓ Fi.CI.BAT: success for drm/i915/psr: Disable psr1 if setup_time > vblank

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/psr: Disable psr1 if setup_time > vblank URL : https://patchwork.freedesktop.org/series/140623/ State : success == Summary == CI Bug Log - changes from CI_DRM_15605 -> Patchwork_140623v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm/i915: add dedicated lock for each sideband (rev2)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915: add dedicated lock for each sideband (rev2) URL : https://patchwork.freedesktop.org/series/139437/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH 0/9] drm/i915/scaler: Scaler code cleanups

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä Bunch of cleanups/refactoring in the scaler code. Ville Syrjälä (9): drm/i915/scaler: s/intel_crtc/crtc/ etc. drm/i915/scaler: Remove redudant junk from skl_scaler.h drm/i915/scaler: Pass the whole atomic state into intel_atomic_setup_scalers() drm/i915/scaler: Cl

[PATCH 2/9] drm/i915/scaler: Remove redudant junk from skl_scaler.h

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä Nuke some redundant includes and forward declarations from skl_scaler.h. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/skl_scaler.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/skl_scaler.h b/drivers/gpu/drm/i915/displ

[PATCH 4/9] drm/i915/scaler: Clean up intel_atomic_setup_scalers() a bit

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä intel_atomic_setup_scalers() is currently messing around with the internals of the atomic states. Stop doing that and instead use the regular interfaces so that we don't need to know any ugly implementation details. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/disp

[PATCH 5/9] drm/i915/scaler: Convert the scaler code to intel_display

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä struct intel_display will replace struct drm_i915_private as the main thing for display code. Convert the scaler code to use it (as much as possible at this stage). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/skl_scaler.c | 105 +++--- 1 fi

[PATCH 9/9] drm/i915/scaler: Extract intel_allocate_scaler()

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä intel_atomic_setup_scaler() is a mess. Make it a bit less so by moving the scaler allocation loop into its own function. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/skl_scaler.c | 31 ++- 1 file changed, 19 insertions(+), 12 deletions(-

[PATCH 8/9] drm/i915/scaler: Make scaler in_use a bool

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä Make scaler in_use a boolean since that's how it's used. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display_types.h | 2 +- drivers/gpu/drm/i915/display/skl_scaler.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 3/9] drm/i915/scaler: Pass the whole atomic state into intel_atomic_setup_scalers()

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä intel_atomic_setup_scalers() currently digs out the full atomic state from the crtc state. Flip that on its head so that we instead pass in the full atomic state and dig out the crtc state (and whatever else we need). This is generallte the better approach as it works in all p

✓ Fi.CI.BAT: success for drm/i915/dp_mst: Fix DDI function/DP2 config programming

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/dp_mst: Fix DDI function/DP2 config programming URL : https://patchwork.freedesktop.org/series/140685/ State : success == Summary == CI Bug Log - changes from CI_DRM_15607 -> Patchwork_140685v1 Summary

Re: [PATCH v4 3/7] drm/i915/xe3lpd: Disable HDCP Line Rekeying for Xe3

2024-10-29 Thread Matt Roper
On Sun, Oct 27, 2024 at 09:11:07PM -0700, Kandpal, Suraj wrote: > > > > -Original Message- > > From: Roper, Matthew D > > Sent: Saturday, October 26, 2024 12:28 AM > > To: Kandpal, Suraj > > Cc: Atwood, Matthew S ; intel- > > x...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org >

✗ Fi.CI.SPARSE: warning for drm/i915/dp_mst: Fix DDI function/DP2 config programming

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/dp_mst: Fix DDI function/DP2 config programming URL : https://patchwork.freedesktop.org/series/140685/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/includ

[PATCH 1/9] drm/i915/scaler: s/intel_crtc/crtc/ etc.

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä Rename some variables from the intel_foo to just foo, to match the more modern style used throughout the driver. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/skl_scaler.c | 33 +++ drivers/gpu/drm/i915/display/skl_scaler.h | 2 +- 2 fil

✓ Fi.CI.BAT: success for drm/i915/psr: WA for panels stating bad link status after PSR is enabled (rev2)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/psr: WA for panels stating bad link status after PSR is enabled (rev2) URL : https://patchwork.freedesktop.org/series/140570/ State : success == Summary == CI Bug Log - changes from CI_DRM_15606 -> Patchwork_140570v2 ==

✗ Fi.CI.BAT: failure for drm/i915/cdclk: Declutter CDCLK code

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/cdclk: Declutter CDCLK code URL : https://patchwork.freedesktop.org/series/140697/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15608 -> Patchwork_140697v1 Summary --- **FAILURE

✗ Fi.CI.SPARSE: warning for drm/i915/scaler: Scaler code cleanups

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/scaler: Scaler code cleanups URL : https://patchwork.freedesktop.org/series/140694/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:

Re: [PATCH 7/8] drm/i915/pmu: Remove pointless synchronize_rcu() call

2024-10-29 Thread Matt Roper
On Fri, Oct 11, 2024 at 03:54:29PM -0700, Lucas De Marchi wrote: > This is already done inside perf_pmu_unregister() - no need to do it > before. > > Signed-off-by: Lucas De Marchi Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/i915_pmu.c | 7 +-- > 1 file changed, 1 insertion(+), 6

✗ Fi.CI.SPARSE: warning for drm/i915/cdclk: Declutter CDCLK code

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/cdclk: Declutter CDCLK code URL : https://patchwork.freedesktop.org/series/140697/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915/cdclk: Declutter CDCLK code

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/cdclk: Declutter CDCLK code URL : https://patchwork.freedesktop.org/series/140697/ State : warning == Summary == Error: dim checkpatch failed 692ab31effb0 drm/i915: Introduce HAS_DOUBLE_WIDE() 522cd55cd86a drm/i915/cdclk: Extract intel_cdclk_guardband() an

Re: [PATCH v2 2/3] accel/ivpu: remove DRIVER_DATE conditional drm_driver init

2024-10-29 Thread Jacek Lawrynowicz
Reviewed-by: Jacek Lawrynowicz On 10/28/2024 7:51 PM, Jani Nikula wrote: > The ivpu struct drm_driver has conditional initialization based on #ifdef > DRIVER_DATE, which is never defined anywhere. Neither are the macros > referenced within the block: DRIVER_DATE, DRIVER_MAJOR, DRIVER_MINOR, > and

[PATCH 05/11] drm/i915/cdclk: Factor out has_audio check in intel_audio_min_cdclk()

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä All the if statements in intel_audio_min_cdclk() check for has_audio==true. Check that once ahead of time to make things a bit simpler. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_audio.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

✓ Fi.CI.BAT: success for drm/i915/display: use x100 version for full version and release (rev4)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/display: use x100 version for full version and release (rev4) URL : https://patchwork.freedesktop.org/series/140454/ State : success == Summary == CI Bug Log - changes from CI_DRM_15606 -> Patchwork_140454v4

✗ Fi.CI.BAT: failure for drm/i915: add dedicated lock for each sideband (rev3)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915: add dedicated lock for each sideband (rev3) URL : https://patchwork.freedesktop.org/series/139437/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15607 -> Patchwork_139437v3 Summary ---

✗ Fi.CI.BAT: failure for drm/i915/scaler: Scaler code cleanups

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/scaler: Scaler code cleanups URL : https://patchwork.freedesktop.org/series/140694/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15607 -> Patchwork_140694v1 Summary --- **FAILUR

Re: [PATCH 2/4] drm/i915/dp: Export intel_ddi_config_transcoder_dp2()

2024-10-29 Thread Jani Nikula
On Tue, 29 Oct 2024, Imre Deak wrote: > Export intel_ddi_config_transcoder_dp2() taken into use by the MST > encoder in the next patch. Move the HAS_DP20() check to the function, so > it doesn't need to be checked for each caller. Besides enabling the DP2 > configuration also add a way to disable

✗ Fi.CI.SPARSE: warning for drm/i915: add dedicated lock for each sideband (rev3)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915: add dedicated lock for each sideband (rev3) URL : https://patchwork.freedesktop.org/series/139437/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH 6/8] drm/i915/pmu: Replace closed with registered

2024-10-29 Thread Matt Roper
On Fri, Oct 11, 2024 at 03:54:28PM -0700, Lucas De Marchi wrote: > Since i915 calls perf_pmu_register/perf_pmu_unregister, let's call the > variable "registered" so we can flip the logic and rely on it being > false by default. Looking at other drivers, it's also more common. > Examples: arch/x86/e

Re: [PATCH 5/8] drm/i915/pmu: Stop setting event_init to NULL

2024-10-29 Thread Matt Roper
On Fri, Oct 11, 2024 at 03:54:27PM -0700, Lucas De Marchi wrote: > Setting event_init to NULL is mostly done to detect when the driver is > partially working: i915 probed, but pmu is not registered. However, > checking for event_init is odd as it was supposed to always be set and > kernel/events/ w

Re: [PATCH 8/8] drm/i915/pmu: Release open events when unregistering

2024-10-29 Thread Matt Roper
On Fri, Oct 11, 2024 at 03:54:30PM -0700, Lucas De Marchi wrote: > When unregistering the PMU, disable the active events. This > allows userspace to see the change and possibly react on it, like > reopening the fd. > > With perf-stat, "" starts to be printed: > > 2.007597571500,909,

[PATCH 6/9] drm/i915/scaler: Carve up intel_atomic_setup_scalers()

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä Declutter intel_atomic_setup_scalers() a bit by splitting the crtc scaling/pfit vs. plane scaling cases into their own functions. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/skl_scaler.c | 92 ++- 1 file changed, 56 insertions(+), 36 de

✓ Fi.CI.BAT: success for drm/i915/xe3lpd: Power request asserting/deasserting (rev2)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/xe3lpd: Power request asserting/deasserting (rev2) URL : https://patchwork.freedesktop.org/series/140583/ State : success == Summary == CI Bug Log - changes from CI_DRM_15606 -> Patchwork_140583v2 Summa

[PATCH 03/11] drm/i915/cdclk: Extract hsw_ips_min_cdclk()

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä Pull the whole BDW IPS min CDCLK stuff into the IPS code so that all the details around IPS are contained in once place. Note that while - min_cdclk = DIV_ROUND_UP(min_cdclk * 100, 95); vs. + min_cdclk = max(DIV_ROUND_UP(crtc_state->pixel_rate * 100, 95), min_cdclk) may look

[PATCH 10/11] drm/i915/cdclk: Relocate intel_vdsc_min_cdclk()

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä Move intel_vdsc_min_cdclk() into intel_vdsc.c from intel_cdclk.c so that details about DSC are better contained. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 46 -- drivers/gpu/drm/i915/display/intel_vdsc.c | 46

✗ Fi.CI.SPARSE: warning for pmu changes with igt (rev2)

2024-10-29 Thread Patchwork
== Series Details == Series: pmu changes with igt (rev2) URL : https://patchwork.freedesktop.org/series/140379/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for pmu changes with igt (rev2)

2024-10-29 Thread Patchwork
== Series Details == Series: pmu changes with igt (rev2) URL : https://patchwork.freedesktop.org/series/140379/ State : warning == Summary == Error: dim checkpatch failed 78b9c1eafb55 pmu changes -:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit

[PATCH 7/9] drm/i915/scaler: Move pfit scaler into pfit state

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä The plane scaler is stored in the plane state, but the crtc scaler is stored in the scaler_state. That is a bit incosistent as the plane state is the state of the consumer, but scaler_state is more the state of the producer. Move the crtc scaler into the pfit state which is mo

[PATCH 07/11] drm/i915/cdclk: Factor out INTEL_OUTPUT_DSI check in vlv_dsi_min_cdclk()

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä All the if statements in vlv_dsi_min_cdclk() check for INTEL_OUTPUT_DSI. Make life simpler by checking that just once at the start. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/vlv_dsi.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[PATCH 08/11] drm/i915/cdclk: Suck the compression_enable check into intel_vdsc_min_cdclk()

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä Declutter intel_crtc_compute_min_cdclk() by moving the crtc_state->dsc.compression_enable check into intel_vdsc_min_cdclk(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH 02/11] drm/i915/cdclk: Extract intel_cdclk_guardband() and intel_cdclk_ppc()

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä We are duplicating the CDCLK guardband and "pixels per clock" figures in two places. Pull those out into small helpers that can be used by both places. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 50 +++--- 1 file changed, 2

[PATCH 04/11] drm/i915/cdclk: Extract intel_audio_min_cdclk()

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä Pull the audio min cdclk calculation into a helper and hide it inside intel_audio.c in order to keep most audio related details in one place. The one audio related thing that remains in intel_cdclk.c is commit 451eaa1a614c ("drm/i915: Bump GLK CDCLK frequency when driving mul

[PATCH 01/11] drm/i915: Introduce HAS_DOUBLE_WIDE()

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä Make the code a bit more self documenting by adding HAS_DOUBLE_WIDE(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- drivers/gpu/drm/i915/display/intel_display.c| 4 ++-- drivers/gpu/drm/i915/display/intel_display_devic

[PATCH 06/11] drm/i915/cdclk: Extract vlv_dsi_min_cdclk()

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä Pull the DSI min cdclk calculation into a helper and hide it inside vlv_dsi.c in order to keep most DSI related details in one place. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 23 ++-- drivers/gpu/drm/i915/display/vlv_dsi.

[PATCH 11/11] drm/i915/cdclk: Unify cdclk max() parameter order

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä In some places we do min_cdclk = max(min_cdclk, other_min_cdclk) and in other places we have the arguments swapped as min_cdclk = max(other_min_cdclk, min_cdclk) Unify everyone to use the first order of arguments, because it looks cleaner, especially within intel_crtc_compu

[PATCH 00/11] drm/i915/cdclk: Declutter CDCLK code

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä Declutter the CDCLK code a bit by moving a all the foo_min_cdclk() things out into their respective files. And I also reworked the "pixels per clock" and guardband handling so that we don't have to repeat essentially the same platform if-ladder two times. TODO: the dsi and a

[PATCH 09/11] drm/i915/cdclk: Drop pointles max_t() usage in intel_vdsc_min_cdclk()

2024-10-29 Thread Ville Syrjala
From: Ville Syrjälä min_cdclk==0 when intel_vdsc_min_cdclk() calls max_t() on it. Drop the redundant max_t(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_

✗ Fi.CI.CHECKPATCH: warning for drm/i915/xe3lpd: Power request asserting/deasserting (rev2)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/xe3lpd: Power request asserting/deasserting (rev2) URL : https://patchwork.freedesktop.org/series/140583/ State : warning == Summary == Error: dim checkpatch failed 6f87bd284a1f drm/i915/xe3lpd: Power request asserting/deasserting -:49: WARNING:LONG_LINE:

✓ Fi.CI.BAT: success for pmu changes with igt (rev2)

2024-10-29 Thread Patchwork
== Series Details == Series: pmu changes with igt (rev2) URL : https://patchwork.freedesktop.org/series/140379/ State : success == Summary == CI Bug Log - changes from CI_DRM_15606 -> Patchwork_140379v2 Summary --- **SUCCESS** No

✓ Fi.CI.BAT: success for drm/i915/psr: minor cleanups

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/psr: minor cleanups URL : https://patchwork.freedesktop.org/series/140651/ State : success == Summary == CI Bug Log - changes from CI_DRM_15605 -> Patchwork_140651v1 Summary --- **SUCCESS** No

✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: bunch of struct intel_display conversions (rev6)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/display: bunch of struct intel_display conversions (rev6) URL : https://patchwork.freedesktop.org/series/140324/ State : warning == Summary == Error: dim checkpatch failed ad128789ff31 drm/i915/gmbus: convert to struct intel_display c7142960f3a5 drm/i915/c

✗ Fi.CI.SPARSE: warning for drm/i915/display: bunch of struct intel_display conversions (rev6)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/display: bunch of struct intel_display conversions (rev6) URL : https://patchwork.freedesktop.org/series/140324/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for drm/i915/display: bunch of struct intel_display conversions (rev6)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/display: bunch of struct intel_display conversions (rev6) URL : https://patchwork.freedesktop.org/series/140324/ State : success == Summary == CI Bug Log - changes from CI_DRM_15607 -> Patchwork_140324v6

✗ Fi.CI.SPARSE: warning for drm/i915/display: convert I915_STATE_WARN() to struct intel_display (rev3)

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/display: convert I915_STATE_WARN() to struct intel_display (rev3) URL : https://patchwork.freedesktop.org/series/140444/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

Re: [PATCH 00/21] hrtimers: Switch to new hrtimer interface functions (1/5)

2024-10-29 Thread Thomas Gleixner
On Mon, Oct 28 2024 at 09:05, Sean Christopherson wrote: > On Mon, Oct 28, 2024, Nam Cao wrote: >> This is the first part of a 5-part series (split for convenience). All 5 >> parts are: >> >> Part 1: >> https://lore.kernel.org/lkml/cover.1729864615.git.nam...@linutronix.de >> Part 2: >> https://

[PATCH 3/4] drm/i915/ptl/dp_mst: Align slave transcoder sequences with spec wrt. DP2 config

2024-10-29 Thread Imre Deak
On PTL during modeset enabling and disabling enable and disable the DP2 configuration for MST slave transcoders as required by the specification. The spec requires the same programming steps on ADLP+ platforms as well, this will be addressed by the next patch. Bspec: 68849 Signed-off-by: Imre Dea

[PATCH 1/4] drm/i915/ptl/dp_mst: Fix slave transcoder enabling wrt. DDI function

2024-10-29 Thread Imre Deak
On PTL during modeset enabling configure the DDI function without enabling it for MST slave transcoders before programming the data and link M/N values. The DDI function gets enabled separately later in the transcoder enabling sequence. This fixes a slave transcoder getting stuck during enabling,

[PATCH 2/4] drm/i915/dp: Export intel_ddi_config_transcoder_dp2()

2024-10-29 Thread Imre Deak
Export intel_ddi_config_transcoder_dp2() taken into use by the MST encoder in the next patch. Move the HAS_DP20() check to the function, so it doesn't need to be checked for each caller. Besides enabling the DP2 configuration also add a way to disable it, required by the MST slave transcoder disabl

[PATCH 4/4] drm/i915/adlp+: Align slave transcoder sequences with spec wrt. DDI function/DP2 config

2024-10-29 Thread Imre Deak
On ADLP+ during modeset enabling configure the DDI function without enabling it for MST slave transcoders before programming the data and link M/N values. The DDI function gets enabled separately later in the transcoder enabling sequence. Also for these platforms the DP2 configuration needs to be

✗ Fi.CI.SPARSE: warning for drm/i915/psr: minor cleanups

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/psr: minor cleanups URL : https://patchwork.freedesktop.org/series/140651/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warnin

Re: [PATCH v3] drm/i915/xe3lpd: Power request asserting/deasserting

2024-10-29 Thread Raag Jadav
On Tue, Oct 29, 2024 at 04:41:29PM +0200, Jani Nikula wrote: > On Tue, 29 Oct 2024, Mika Kahola wrote: ... > > +static void wa_14020908590(struct intel_display *display, > > + bool enable) > > +{ > > + bool error = false; > > + > > + /* check if mailbox is running busy *

✗ Fi.CI.CHECKPATCH: warning for drm/i915/gsc: ARL-H and ARL-U need a newer GSC FW.

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/gsc: ARL-H and ARL-U need a newer GSC FW. URL : https://patchwork.freedesktop.org/series/140620/ State : warning == Summary == Error: dim checkpatch failed a2f1e2c2a443 drm/i915/gsc: ARL-H and ARL-U need a newer GSC FW. -:183: ERROR:COMPLEX_MACRO: Macros w

✗ Fi.CI.SPARSE: warning for drm/i915/gsc: ARL-H and ARL-U need a newer GSC FW.

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/gsc: ARL-H and ARL-U need a newer GSC FW. URL : https://patchwork.freedesktop.org/series/140620/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH v3] drm/i915/xe3lpd: Power request asserting/deasserting

2024-10-29 Thread Gustavo Sousa
Quoting Raag Jadav (2024-10-29 13:56:33-03:00) >On Tue, Oct 29, 2024 at 04:00:37PM +0200, Mika Kahola wrote: > >... > >> Use boolean enable instead of if-else structure (Gustavo) > >Hmm... Not sure if I'm reading it correctly, maybe need to revisit v2. Yeah, this was Raag's suggestion. -- Gus

Re: [PATCH v3] drm/i915/xe3lpd: Power request asserting/deasserting

2024-10-29 Thread Raag Jadav
On Tue, Oct 29, 2024 at 04:00:37PM +0200, Mika Kahola wrote: ... > Use boolean enable instead of if-else structure (Gustavo) Hmm... Not sure if I'm reading it correctly, maybe need to revisit v2. Raag

✗ Fi.CI.BAT: failure for drm/i915/xe3lpd: Disable HDCP Line Rekeying for Xe3

2024-10-29 Thread Patchwork
== Series Details == Series: drm/i915/xe3lpd: Disable HDCP Line Rekeying for Xe3 URL : https://patchwork.freedesktop.org/series/140624/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15605 -> Patchwork_140624v1 Summary -

  1   2   >