✓ Fi.CI.BAT: success for Ultrajoiner basic functionality series (rev13)

2024-09-30 Thread Patchwork
== Series Details == Series: Ultrajoiner basic functionality series (rev13) URL : https://patchwork.freedesktop.org/series/133800/ State : success == Summary == CI Bug Log - changes from CI_DRM_15453 -> Patchwork_133800v13 Summary ---

✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/display: Add own counter for Panel Replay vblank workaround

2024-09-30 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: Add own counter for Panel Replay vblank workaround URL : https://patchwork.freedesktop.org/series/139271/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

[PATCH v7 2/5] drm: Expose wedge recovery methods

2024-09-30 Thread Raag Jadav
Now that we have device wedged event in place, add wedge_recovery sysfs attribute which will expose recovery methods supported by the DRM device. This is useful for userspace consumers in cases where the device supports multiple recovery methods which can be used as fallbacks. $ cat /sys/class/d

[PATCH v7 1/5] drm: Introduce device wedged event

2024-09-30 Thread Raag Jadav
Introduce device wedged event, which will notify userspace of wedged (hanged/unusable) state of the DRM device through a uevent. This is useful especially in cases where the device is no longer operating as expected even after a hardware reset and has become unrecoverable from driver context. Purp

[PATCH v7 4/5] drm/xe: Use device wedged event

2024-09-30 Thread Raag Jadav
This was previously attempted as xe specific reset uevent but dropped in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset uevent for now") as part of refactoring. Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. W

[PATCH v7 3/5] drm/doc: Document device wedged event

2024-09-30 Thread Raag Jadav
Add documentation for device wedged event along with its consumer expectations. For now it is amended to 'Device reset' chapter, but with extended functionality in the future it can be refactored into its own chapter. Signed-off-by: Raag Jadav --- Documentation/gpu/drm-uapi.rst | 42

[PATCH v7 5/5] drm/i915: Use device wedged event

2024-09-30 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/intel_reset.c | 2 ++

[PATCH v7 0/5] Introduce DRM device wedged event

2024-09-30 Thread Raag Jadav
This series introduces device wedged event in DRM subsystem and uses it in xe and i915 drivers. Detailed description in commit message. This was earlier attempted as xe specific uevent in v1 and v2. https://patchwork.freedesktop.org/series/136909/ v2: Change authorship to Himal (Aravind) Add

Re: [PATCH] drm/i915/backlight: Remove a useless kstrdup_const()

2024-09-30 Thread Jani Nikula
On Sat, 28 Sep 2024, Christophe JAILLET wrote: > "name" is allocated and freed in intel_backlight_device_register(). > The initial allocation just duplicates "intel_backlight". > > Later, if a device with this name has already been registered, another > dynamically generated one is allocated using

✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/display: Add own counter for Panel Replay vblank workaround

2024-09-30 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: Add own counter for Panel Replay vblank workaround URL : https://patchwork.freedesktop.org/series/139271/ State : success == Summary == CI Bug Log - changes from CI_DRM_15456 -> Patchwork_139271v1 ==

[PATCH v4] docs/gpu: ci: update flake tests requirements

2024-09-30 Thread Vignesh Raman
Update the documentation to specify linking to a relevant GitLab issue or email report for each new flake entry. Added specific GitLab issue urls for amdgpu, i915, msm and xe driver. Acked-by: Maxime Ripard Acked-by: Rodrigo Vivi #intel and xe Acked-by: Abhinav Kumar # msm Acked-by: Dmitry Bary

Re: [PATCH] drm/i915/dp: Guarantee a minimum HBlank time

2024-09-30 Thread Jani Nikula
On Mon, 30 Sep 2024, Arun R Murthy wrote: > Mandate a minimum Hblank symbol cycle count between BS and BE in 8b/10b > MST and 12b/132b mode. > Spec: DP2.1a Why send patches on top of a baseline that's 20 days old? Please rebase and build before sending. Always. > Signed-off-by: Arun R Murthy >

Re: [PATCH 1/2] drm/i915/display: Add own counter for Panel Replay vblank workaround

2024-09-30 Thread Jani Nikula
On Mon, 30 Sep 2024, Jouni Högander wrote: > We are about to change meaning of vblank_enabled to fix Panel Replay vblank > workaround. For sake of clarity we need to rename it. Vblank_enabled is > used for i915gm/i945gm vblank irq workaround as well -> instead of rename > add new counter named as

Re: [PATCH v3] docs/gpu: ci: update flake tests requirements

2024-09-30 Thread Vignesh Raman
Hi Rodrigo, On 27/09/24 20:05, Rodrigo Vivi wrote: On Fri, Sep 27, 2024 at 10:54:14AM +0530, Vignesh Raman wrote: Update the documentation to specify linking to a relevant GitLab issue or email report for each new flake entry. Added specific GitLab issue urls for i915, msm and amdgpu driver. A

Re: [PATCH] tests: drm_fdinfo: Fix zero tolerance checks

2024-09-30 Thread Peter Senna Tschudin
On 16.09.2024 11:03, Janusz Krzysztofik wrote: > When we expect an engine to be busy, we check if its reported busy time > falls within a +/-5% tolerance range of measurement time period. > However, when we expect the engine to be idle, we compare its reported > busy time against zero, still wit

[PATCH v5] drm/i915/selftests: Implement frequency logging for energy reading validation

2024-09-30 Thread sk . anirban
From: Sk Anirban Introduce RC6 & RC0 frequency logging mechanism aimed at ensuring the accuracy of energy readings in case of GPU energy leak. v2: - Improved commit message. v3: - Used pr_err log to display frequency. (Anshuman) - Sorted headers alphabetically. (Sai Teja) v4: - Improved

[PATCH v3 08/19] scsi: libfcoe: Include instead of

2024-09-30 Thread Uros Bizjak
Substitute the inclusion of header with to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Reviewed-by: Bart Van Assche Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" --- include/scsi/libfcoe.h | 2 +- 1 file changed, 1 insertion(+), 1 d

[PATCH v3 07/19] fscrypt: Include in fs/crypto/keyring.c

2024-09-30 Thread Uros Bizjak
Include header to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Acked-by: Eric Biggers Cc: "Theodore Y. Ts'o" Cc: Jaegeuk Kim --- v2: Include instead of --- fs/crypto/keyring.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/crypto/keyring.c b/fs/crypto

[PATCH v3 06/19] mtd: tests: Include instead of

2024-09-30 Thread Uros Bizjak
Substitute the inclusion of header with to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Acked-by: Miquel Raynal Cc: Richard Weinberger Cc: Vignesh Raghavendra --- drivers/mtd/tests/oobtest.c | 2 +- drivers/mtd/tests/pagetest.c| 2 +- drivers/mtd/tests

[PATCH v3 10/19] lib/interval_tree_test.c: Include instead of

2024-09-30 Thread Uros Bizjak
Substitute the inclusion of header with to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Cc: Andrew Morton --- lib/interval_tree_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/interval_tree_test.c b/lib/interval_tree_test.c index f

[CI 1/2] drm/i915: remove IS_LP()

2024-09-30 Thread Jani Nikula
The .is_lp member of struct intel_device_info and its wrapper IS_LP() are used to identify just four platforms, VLV/CHV/BXT/GLK. It didn't become as important as it was perhaps originally planned. Just remove it, and replace with exact platform identification. In a few places this becomes slightly

[PATCH v3 11/19] kunit: string-stream-test: Include

2024-09-30 Thread Uros Bizjak
Include header to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Cc: Brendan Higgins Cc: David Gow Cc: Rae Moar --- lib/kunit/string-stream-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/kunit/string-stream-test.c b/lib/kunit/string-stream-test.c

[CI 2/2] drm/i915/soc: stop using IS_GEN9_LP() and IS_GEN9_BC()

2024-09-30 Thread Jani Nikula
Replace IS_GEN9_LP() and IS_GEN9_BC() with direct platform checks. This lets us remove their compat counterparts, as neither soc/ nor /display now no longer needs them. v2: Use !A && !B instead of !(A || B) (Ville) Reviewed-by: Ville Syrjälä # v1 Signed-off-by: Jani Nikula --- drivers/gpu/drm/

[PATCH v3 09/19] bpf: Include instead of

2024-09-30 Thread Uros Bizjak
Substitute the inclusion of header with to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: John Fastabend Cc: Andrii Nakryiko Cc: Martin KaFai Lau Cc: Eduard Zingerman Cc: Song Liu Cc: Yonghong Song Cc: KP Singh

[PATCH v3 12/19] random32: Include instead of

2024-09-30 Thread Uros Bizjak
Substitute the inclusion of header with to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Cc: Andrew Morton Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni --- lib/random32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3 13/19] lib/rbtree-test: Include instead of

2024-09-30 Thread Uros Bizjak
Substitute the inclusion of header with to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Cc: Andrew Morton --- lib/rbtree_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rbtree_test.c b/lib/rbtree_test.c index 41ae3c7570d3..8655a76d

[PATCH v3 14/19] bpf/tests: Include instead of

2024-09-30 Thread Uros Bizjak
Substitute the inclusion of header with to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Cc: Andrew Morton Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Andrii Nakryiko Cc: Martin KaFai Lau Cc: Eduard Zingerman Cc: Song Liu Cc: Yonghong Song Cc: John Fasta

[PATCH v3 16/19] lib/test_scanf: Include instead of

2024-09-30 Thread Uros Bizjak
Substitute the inclusion of header with to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Acked-by: Petr Mladek Cc: Steven Rostedt Cc: Andy Shevchenko Cc: Rasmus Villemoes Cc: Sergey Senozhatsky Cc: Andrew Morton --- lib/test_scanf.c | 2 +- 1 file changed, 1

[PATCH v3 18/19] random: Do not include in

2024-09-30 Thread Uros Bizjak
Files that use prandom infrastructure are now converted to use header instead of . Remove the legacy inclusion of from . This is the "nice cleanup" part, wished in c0842fbc1b18. Signed-off-by: Uros Bizjak Fixes: c0842fbc1b18 ("random32: move the pseudo-random 32-bit definitions to prandom.h")

[PATCH v3 19/19] prandom: Include in

2024-09-30 Thread Uros Bizjak
include was removed from in d9f29deb7fe8 ("prandom: Remove unused include") because this inclusion broke arm64 due to a circular dependency on include files. __percpu tag is defined in include/linux/compiler_types.h, so there is currently no direct need for the inclusion of . However, in [1] we

[PATCH v3 15/19] lib/test_parman: Include instead of

2024-09-30 Thread Uros Bizjak
Substitute the inclusion of header with to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Cc: Andrew Morton Cc: Jiri Pirko --- lib/test_parman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_parman.c b/lib/test_parman.c index 35e322

[PATCH] drm/i915: remove all IS__GT() macros

2024-09-30 Thread Jani Nikula
There aren't many users for the IS__GT() macros, and many of them are in fact unused. Even among the users, the platform check is often redundant. Just remove the macros. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/gen7_renderclear.c | 3 ++- drivers/gpu/drm/i915/gt/intel_gt.c

[PATCH 00/28] drm: Remove DRM aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture helpers are merely wrappers around the respective helpers in drivers/video/. The DRM interface existed first, but was later generalized for use with fbdev and a few other graphics-related places in the kernel. It is time to remove the DRM wrappers and call the video helpers directly.

Re: [PATCH 00/28] drm: Remove DRM aperture helpers

2024-09-30 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > DRM's aperture helpers are merely wrappers around the respective > helpers in drivers/video/. The DRM interface existed first, but was > later generalized for use with fbdev and a few other graphics-related > places in the kernel. It is time to remove th

Re: [PATCH v3 00/19] random: Resolve circular include dependency and include

2024-09-30 Thread Jason A. Donenfeld
Hi Uros, Per your plan, I took this into random.git, and we'll now see if being in next unearths some problems over the next week or two. Jason

[PATCH] drm: Add check for encoder in intel_get_crtc_new_encoder()

2024-09-30 Thread George Rurikov
If the video card driver could not find the connector assigned to the current video controller, or if the hardware status has changed so that a pre-existing connector is no longer active, none of the state connectors will meet the assignment criteria for the current crtc video controller. In the d

[RESEND PATCH] drm/i915:Remove unused parameter in marco

2024-09-30 Thread He Lugang
The parameter dev_priv is actually not used in macro PORT_ALPM_CTL and PORT_ALPM_LFPS_CTL,so remove it to simplify the code. Reviewed-by: Jani Nikula Signed-off-by: He Lugang --- drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++-- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- driver

[PATCH] drm: Add check for encoder in intel_get_crtc_new_encoder()

2024-09-30 Thread George Rurikov
If the video card driver could not find the connector assigned to the current video controller, or if the hardware status has changed so that a pre-existing connector is no longer active, none of the state connectors will meet the assignment criteria for the current crtc video controller. In the d

[PATCH] drm: Add check for encoder in intel_get_crtc_new_encoder()

2024-09-30 Thread George Rurikov
If the video card driver could not find the connector assigned to the current video controller, or if the hardware status has changed so that a pre-existing connector is no longer active, none of the state connectors will meet the assignment criteria for the current crtc video controller. In the d

Re: [PATCH v5 42/80] drm/tilcdc: Run DRM default client setup

2024-09-30 Thread jyri . sarha
September 24, 2024 at 10:12 AM, "Thomas Zimmermann" mailto:tzimmerm...@suse.de?to=%22Thomas%20Zimmermann%22%20%3Ctzimmermann%40suse.de%3E > wrote: > > Call drm_client_setup_with_color_mode() to run the kernel's default > client setup for DRM. Set fbdev_probe in struct drm_driver, so that > the c

[PATCH] drm/i915: Use memdup_user() instead of kmalloc() and copy_from_user()

2024-09-30 Thread Thorsten Blum
Use memdup_user() instead of kmalloc() followed by copy_from_user() to simplify set_context_image(). Fixes the following Coccinelle/coccicheck warning reported by memdup_user.cocci: WARNING opportunity for memdup_user Signed-off-by: Thorsten Blum --- drivers/gpu/drm/i915/gem/i915_gem_context

[PATCH] gpu: drm: i915: display: Avoid null values intel_plane_atomic_check_with_state

2024-09-30 Thread Alessandro Zanni
This fix solves multiple Smatch errors: drivers/gpu/drm/i915/display/intel_atomic_plane.c:660 intel_plane_atomic_check_with_state() error: we previously assumed 'fb' could be null (see line 648) drivers/gpu/drm/i915/display/intel_atomic_plane.c:664 intel_plane_atomic_check_with_state() error: we

[PATCH] i915: Fix HBLANK Expansion Quirk Causing Modeset Failure on Dell WD19TB Dock at 3440x1440@100Hz

2024-09-30 Thread Benjamin Hoefs
Hello, I am using a Dell WD19TB dock with a 3440x1440 monitor. Using it at 100Hz used to work but recently I tried it again and discovered it no longer did, specifically the modeset seems to silently fail with no error message in userspace utilities like kscreen-doctor and xrandr and no output in

Re: [RFC] Add AS_SDP to fastset

2024-09-30 Thread Ville Syrjälä
On Thu, Aug 08, 2024 at 03:18:49PM +0530, Mitul Golani wrote: > Add full modeset being triggered during VRR enable/disable, specially > when panel has Adaptive sync SDP suypport. > > Signed-off-by: Mitul Golani > --- > drivers/gpu/drm/i915/display/intel_display.c | 3 ++- > 1 file changed, 2 ins

Re: [PATCH v2 1/6] drm/i915/gem: fix bitwise and logical AND mixup

2024-09-30 Thread Jani Nikula
On Mon, 30 Sep 2024, Matthew Auld wrote: > On 30/09/2024 14:54, Jani Nikula wrote: >> On Fri, 27 Sep 2024, Jani Nikula wrote: >>> On Thu, 26 Sep 2024, Rodrigo Vivi wrote: On Wed, Sep 18, 2024 at 08:35:43PM +0300, Jani Nikula wrote: > CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND is an int, defa

Re: ✗ Fi.CI.IGT: failure for Ultrajoiner basic functionality series (rev13)

2024-09-30 Thread Nautiyal, Ankit K
On 9/30/2024 7:50 PM, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* Ultrajoiner basic functionality series (rev13) *URL:* https://patchwork.freedesktop.org/series/133800/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_133800v1

[PATCH 04/13] drm/i915/display: Refactor enable_joiner_pipes

2024-09-30 Thread Ankit Nautiyal
Pass the current pipe into enabled_joiner_pipes(), and let it figure out the proper bitmasks for us. Since the enabled_joiner_pipes now gets the primary and secondary pipes wrt a given pipe, the helpers to get primary pipe and secondary pipes are no longer required. v2: -Simplify helper get_joiner

[PATCH 03/13] drm/i915/display: Add macro HAS_ULTRAJOINER()

2024-09-30 Thread Ankit Nautiyal
Add macro to check if platform supports Ultrajoiner. v2: -Use check for DISPLAY_VER >= 20, and add bmg as a special case. (Ville) -Add check for HAS_DSC. (Ville) Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display_device.h | 3 +++ 1 file cha

[PATCH 02/13] drm/i915: Add bigjoiner and uncompressed joiner hw readout sanity checks

2024-09-30 Thread Ankit Nautiyal
From: Stanislav Lisovskiy Add sanity checks for primary and secondary bigjoiner/uncompressed bitmasks, should make it easier to spot possible issues. v2: -Streamline the expected masks and add few more drm_WARNs. (Ville) -Use %#x format specifier for printing joiner masks. (Ville) -Use struct in

[PATCH 06/13] drm/i915/display/vdsc: Add ultrajoiner support with DSC

2024-09-30 Thread Ankit Nautiyal
From: Stanislav Lisovskiy Add changes to DSC which are required for Ultrajoiner. v2: -Use correct helper for setting bits for bigjoiner secondary. (Ankit) -Use primary/secondary instead of master/slave. (Suraj) v3: Add the ultrajoiner helpers and use it for setting ultrajoiner bits (Ankit) v4: U

[PATCH 08/13] drm/i915/dp: Use num_joined_pipes in bigjoiner_bw_max_bpp

2024-09-30 Thread Ankit Nautiyal
Streamline the helper to get max compressed bpp for bigjoiner case, to effectively use num of pipes joined. This will make the addition of ultrajoiner limitations easier and improve redability. Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c

[PATCH 05/13] drm/i915: Implement hw state readout and checks for ultrajoiner

2024-09-30 Thread Ankit Nautiyal
From: Stanislav Lisovskiy Ultrajoiner mode has some new bits and states to be read out from the hw. Lets make changes accordingly. v2: Fix checkpatch warnings. (Ankit) v3: Add separate functions for computing expected secondary_big/ultrajoiner pipes. (Ankit) v4: -Streamline the helpers for ultra

[PATCH 12/13] drm/i915/display: Consider ultrajoiner for computing maxdotclock

2024-09-30 Thread Ankit Nautiyal
Use the check for ultrajoiner while computing maxdotclock. v2: Add Check for HAS_UNCOMPRESSED_JOINER. (Ville) v3: Remove extraneous newline. (Ville) Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 5 +++-- 1 file changed, 3 insertions

[PATCH 10/13] drm/i915/dp: Simplify helper to get slice count with joiner

2024-09-30 Thread Ankit Nautiyal
From: Stanislav Lisovskiy When bigjoiner is used, we need at least 2 dsc slices per pipe. Modify the condition in intel_dp_dsc_get_slice_count() to reflect the same. Signed-off-by: Stanislav Lisovskiy Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/i

[PATCH 13/13] drm/i915/intel_dp: Add support for forcing ultrajoiner

2024-09-30 Thread Ankit Nautiyal
Allow forcing ultrajoiner through debugfs. v2: Minor refactoring of switch case logic. (Ville) Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 01/13] drm/i915: Split current joiner hw state readout

2024-09-30 Thread Ankit Nautiyal
We need to add a new sanity checks and also do some preparations for adding ultrajoiner hw state readout. Lets first split reading of the uncompressed joiner and bigjoiner bit masks into separate functions. v2: Fixed checkpatch warnings (Ankit) v3: Use struct intel_display in the new functions. (A

[PATCH 00/13] Ultrajoiner basic functionality series

2024-09-30 Thread Ankit Nautiyal
This patch series attempts to implement basic support for Ultrajoiner functionality. Rev6: -Upgrade the debugfs functionality to enable the joining of a specified number of pipes. -Modify the display helpers reliant on the pipe joiner mechanism to use number of pipes joined, instead of joiner flag

[PATCH 09/13] drm/i915/dp: Modify compressed bpp limitations for ultrajoiner

2024-09-30 Thread Ankit Nautiyal
Add compressed bpp limitations for ultrajoiner. v2: Fix the case for 1 pipe. (Ankit) v3: Refactor existing helper separately and add only ultrajoiner limitation. (Ville) v4: Separate out function for ultrajoiner_ram_bits. v5: Make the helper function more concise. (Ville) Signed-off-by: Ankit Nau

[PATCH 07/13] drm/i915/dp: Refactor joiner max_bpp calculations into separate functions

2024-09-30 Thread Ankit Nautiyal
Currently compressed max_bpp limitations for small joiner ram, big joiner etc are intermingled. Seprate these limitations into separate functions. v2: Use num_joined_pipes in small joiner ram helper and other minor fixes. (Ville) Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- dri

[PATCH 11/13] drm/i915: Compute config and mode valid changes for ultrajoiner

2024-09-30 Thread Ankit Nautiyal
From: Stanislav Lisovskiy Implement required changes for mode validation and compute config, to support Ultrajoiner. v2: -Drop changes for HDMI. -Separate out DSC changes into another patch. v3: Fix check in can_ultrajoiner. (Ankit) v4: -Unify helper to check joiner requirement. (Ville) -Split p

Re: [PATCH v3 17/19] netem: Include in sch_netem.c

2024-09-30 Thread Stephen Hemminger
On Mon, 30 Sep 2024 14:33:28 +0200 Uros Bizjak wrote: > Include header to allow the removal of legacy > inclusion of from . > > Signed-off-by: Uros Bizjak > Cc: Stephen Hemminger > Cc: Jamal Hadi Salim > Cc: Cong Wang > Cc: Jiri Pirko > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jak

RE: [RFC] Add AS_SDP to fastset

2024-09-30 Thread Golani, Mitulkumar Ajitkumar
> -Original Message- > From: Jani Nikula > Sent: Thursday, August 8, 2024 3:28 PM > To: Golani, Mitulkumar Ajitkumar ; > intel-gfx@lists.freedesktop.org > Cc: intel...@lists.freedesktop.org; Nautiyal, Ankit K > > Subject: Re: [RFC] Add AS_SDP to fastset > > On Thu, 08 Aug 2024, Mitul

[PATCH v2 08/13] drm/i915: Introduce intel_scanlines_to_usecs()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Introduce intel_scanlines_to_usecs() as a counterpart to intel_usecs_to_scanlines(). We'll have some use for this in DSB code as we want to do relative scanline waits to evade the delayed vblank, but unfortunately DSB can't do relative scanline waits (only absolute). So we'll

[PATCH v2 10/13] drm/i915: Extract intel_crtc_prepare_vblank_event()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Extract the code for staging the vblank event for the flip done interrupt handler. We'll reuse this for DSB stuff later. Reviewed-by: Animesh Manna Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_crtc.c | 21 +++-- drivers/gpu/drm/i915/d

[PATCH v2 11/13] drm/i915: Plumb 'dsb' all way to the plane hooks

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä We need to be able to do both MMIO and DSB based pipe/plane programming. To that end plumb the 'dsb' all way from the top into the plane commit hooks. The compiler appears smart enough to combine the branches from all the back-to-back register writes into a single branch. So

[PATCH v2 13/13] drm/i915/dsb: Use DSB for plane/color management updates

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Push regular plane/color management updates to the DSB, if other constraints allow it. The first part of the sequence will go as follows: - CPU will kick off DSB0 immediately - DSB0 writes double bufferd non-arming registers - DSB0 evades the vblank - DSB0 writes double buffe

[PATCH v2 12/13] drm/i915: Plumb 'dsb' all way to the color commit hooks

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Pass the 'dsb' all the way down to the color commit hooks so that we'll be able to update the double buffered color management registers (eg. CSC) via the DSB. Reviewed-by: Animesh Manna Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c| 180 +

[PATCH v2 01/13] drm/i915/dsb: Avoid reads of the DSB buffer for indexed register writes

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Reading from the DSB command buffer might be somewhat expensive on discrete GPUs because the buffer resides in GPU local memory. Avoid such reads in the indexed register write handling by tracking the previous instruction in intel_dsb. TODO: actually measure this Reviewed-by

[PATCH v2 02/13] drm/i915: Prepare clear color before wait_for_dependencies()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Read out the clear color as soon as fences and the transient data flush have finished. There is no need to wait for all the display specific operations that might still be going on. This could parallelize things a bit more effectively. Reviewed-by: Animesh Manna Signed-off-b

[PATCH v2 04/13] drm/i915/dsb: Enable programmable DSB interrupt

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä The DSB can signal a programmable interrupt in response to a specific DSB command getting executed. Hook that up. For now we'll just use this to signal the completion of the commit via a vblank event. If, in the future, we'll need to do other things in response to DSB interru

[PATCH v2 05/13] drm/i915/dsb: Introduce intel_dsb_vblank_evade()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Add a helper for performing vblank evasion on the DSB. DSB based plane updates will need this to guarantee all the double buffered arming registers will get programmed atomically within the same frame. With VRR we more or less have two vblanks to worry about: - vmax vblank st

[PATCH v2 07/13] drm/i915/dsb: Introduce intel_dsb_wait_vblanks()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Add a function to emit a DSB wait for vblank instruction. This just waits until the specified number of vblanks. Note that this triggers on the transcoder's undelayed vblank, as opposed to the pipe's delayed vblank. Reviewed-by: Animesh Manna Signed-off-by: Ville Syrjälä -

[PATCH v2 03/13] drm/i915/dsb: Generate the DSB buffer in commit_tail()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Once we start using DSB for plane updates we'll need to defer generating the DSB buffer until the clear color has been read out. So we need to move at some of the DSB stuff into commit_tail(). That is perhaps a better place for it anyway as the ioctl thread can move on immedia

[PATCH v2 09/13] drm/i915/dsb: Introduce intel_dsb_wait_vblank_delay()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Add intel_dsb_wait_vblank_delay() which instructs the DSB to wait for duration between the undelayed and delayed vblanks. We'll need this as the DSB can only directly wait for the undelayed vblank, but we'll need to wait until the delayed vblank has elapsed as well. Reviewed-

[PATCH v2 06/13] drm/i915/dsb: Introduce intel_dsb_wait_usec()

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Add a function to emit the DSB "wait usecs" instruction. This is just a usleep() for the DSB. As a lower bound it seems pretty accurate, but the upper bound seemed oddly relaxed (ie. sometimes I've seen waits that are quite a bit longer than specified, not sure why). Reviewe

[PATCH v2 00/13] drm/i915: Use DSB for plane/color management commits

2024-09-30 Thread Ville Syrjala
From: Ville Syrjälä Use the DSB to perform simple plane/color management commits. Anything more complicatd (modesets and fastsets) are still punted to the mmio path. Also DSB won't be used when any of these are in use: - scalers (scaler code needs more work) - VRR (need to figure out a race free

[RESEND] drm/i915/gvt: use macros from drm_dp.h instead of duplication

2024-09-30 Thread Jani Nikula
Use the existing macros in drm_dp.h for DPCD and DP AUX instead of duplicating. Remove unused macros, as well as the duplicate definition of DPCD_SIZE. AUX_NATIVE_REPLY_NAK is left unchanged, as it does not match DP_AUX_NATIVE_REPLY_NACK, and I'm not sure what the right thing to do is here. Signe

Re: [PATCH v2 1/6] drm/i915/gem: fix bitwise and logical AND mixup

2024-09-30 Thread Jani Nikula
On Fri, 27 Sep 2024, Jani Nikula wrote: > On Thu, 26 Sep 2024, Rodrigo Vivi wrote: >> On Wed, Sep 18, 2024 at 08:35:43PM +0300, Jani Nikula wrote: >>> CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND is an int, defaulting to 250. When >>> the wakeref is non-zero, it's either -1 or a dynamically allocated >>

Re: [PATCH 5/5] drm: Add client-lib module

2024-09-30 Thread Jocelyn Falempe
On 27/09/2024 16:37, Thomas Zimmermann wrote: Add drm_client_lib.ko to contain most of the client code. Move the existing client for fbdev emulation into the new module. Protect the new module behind CONFIG_DRM_CLIENT. The Kconfig rules separate the DRM drivers from the DRM clients. A driver can

[PATCH v3 17/19] netem: Include in sch_netem.c

2024-09-30 Thread Uros Bizjak
Include header to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Cc: Stephen Hemminger Cc: Jamal Hadi Salim Cc: Cong Wang Cc: Jiri Pirko Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni --- net/sched/sch_netem.c | 1 + 1 file changed

[RFC v2] drm/i915/vrr: Add AS_SDP to fastset

2024-09-30 Thread Mitul Golani
Enabling and disabling VRR should not trigger full modeset, for this use vrr.flipline instead of vrr.enable while computing Adaptive Sync SDP. This prevents VRR enable/disable to trigger full modeset. --v1: - Explain commit message more clearly [Jani] - Instead of tweaking to fastset use vrr.flipl

[PATCH] drm/i915: Allow fastset for change in HDR infoframe

2024-09-30 Thread Chaitanya Kumar Borah
Changes in Dynamic Range and Mastering infoframe should not trigger a full modeset. Therefore, allow fastset. Signed-off-by: Chaitanya Kumar Borah --- drivers/gpu/drm/i915/display/intel_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/i

[PATCH v3 00/19] random: Resolve circular include dependency and include

2024-09-30 Thread Uros Bizjak
There were several attempts to resolve circular include dependency after the addition of percpu.h: 1c9df907da83 ("random: fix circular include dependency on arm64 after addition of percpu.h"), c0842fbc1b18 ("random32: move the pseudo-random 32-bit definitions to prandom.h") and finally d9f29deb7fe8

[PATCH v3 01/19] x86/kaslr: Include instead of

2024-09-30 Thread Uros Bizjak
Substitute the inclusion of header with to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Cc: Dave Hansen Cc: Andy Lutomirski Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" --- arch/x86/mm/kaslr.c | 2 +- 1 fi

[PATCH v3 03/19] drm/i915/selftests: Include instead of

2024-09-30 Thread Uros Bizjak
Substitute the inclusion of header with to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Acked-by: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/i915/selftests/i915_gem.c| 2 +-

[PATCH v3 02/19] crypto: testmgr: Include instead of

2024-09-30 Thread Uros Bizjak
Substitute the inclusion of header with to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Cc: Herbert Xu Cc: "David S. Miller" --- crypto/testmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/testmgr.c b/crypto/testmgr.c index ee8da

[PATCH v3 05/19] media: vivid: Include in vivid-vid-cap.c

2024-09-30 Thread Uros Bizjak
Include to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Acked-by: Hans Verkuil Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org --- drivers/media/test-drivers/vivid/vivid-vid-cap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/test-d

[PATCH v3 04/19] drm/lib: Include instead of

2024-09-30 Thread Uros Bizjak
Substitute the inclusion of header with to allow the removal of legacy inclusion of from . Signed-off-by: Uros Bizjak Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/lib/drm_random.h | 2 +- 1 file changed, 1 insertion(

✓ Fi.CI.BAT: success for drm/i915/selftests: Implement frequency logging for energy reading validation (rev3)

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Implement frequency logging for energy reading validation (rev3) URL : https://patchwork.freedesktop.org/series/139235/ State : success == Summary == CI Bug Log - changes from CI_DRM_15461 -> Patchwork_139235v3 =

✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Workaround for odd panning for planar yuv (rev5)

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915/display: Workaround for odd panning for planar yuv (rev5) URL : https://patchwork.freedesktop.org/series/136416/ State : warning == Summary == Error: dim checkpatch failed 88141b5d86a7 drm/i915/display: Workaround for odd panning for planar yuv -:6: WARNIN

✓ Fi.CI.BAT: success for drm/i915/display: Workaround for odd panning for planar yuv (rev5)

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915/display: Workaround for odd panning for planar yuv (rev5) URL : https://patchwork.freedesktop.org/series/136416/ State : success == Summary == CI Bug Log - changes from CI_DRM_15461 -> Patchwork_136416v5

Re: [PATCH v3 02/19] crypto: testmgr: Include instead of

2024-09-30 Thread Herbert Xu
On Mon, Sep 30, 2024 at 02:33:13PM +0200, Uros Bizjak wrote: > Substitute the inclusion of header with > to allow the removal of legacy inclusion > of from . > > Signed-off-by: Uros Bizjak > Cc: Herbert Xu > Cc: "David S. Miller" > --- > crypto/testmgr.c | 2 +- > 1 file changed, 1 insertio

✗ Fi.CI.BAT: failure for drm/i915: Allow fastset for change in HDR infoframe

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915: Allow fastset for change in HDR infoframe URL : https://patchwork.freedesktop.org/series/139293/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15461 -> Patchwork_139293v1 Summary -

linux-next: build failure after merge of the drm-xe tree

2024-09-30 Thread Stephen Rothwell
Hi all, After merging the drm-xe tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/xe/display/xe_display.c: In function 'xe_display_pm_shutdown': drivers/gpu/drm/xe/display/xe_display.c:382:27: error: passing argument 1 of 'intel_dmc_suspend' from incompatibl

✓ Fi.CI.BAT: success for drm/i915/display: platform identification with display->platform.

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915/display: platform identification with display->platform. URL : https://patchwork.freedesktop.org/series/139302/ State : success == Summary == CI Bug Log - changes from CI_DRM_15461 -> Patchwork_139302v1

✗ Fi.CI.SPARSE: warning for drm/i915/display: platform identification with display->platform.

2024-09-30 Thread Patchwork
== Series Details == Series: drm/i915/display: platform identification with display->platform. URL : https://patchwork.freedesktop.org/series/139302/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: remove IS_LP()

2024-09-30 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: remove IS_LP() URL : https://patchwork.freedesktop.org/series/139304/ State : warning == Summary == Error: dim checkpatch failed 0bb70631ccc4 drm/i915: remove IS_LP() -:30: WARNING:LONG_LINE: line length of 109 exceeds 100 co

✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] drm/i915: remove IS_LP()

2024-09-30 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: remove IS_LP() URL : https://patchwork.freedesktop.org/series/139304/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/139304/revisions/1/mbox/ not found

Re: [PATCH 09/28] drm/meson: Use video aperture helpers

2024-09-30 Thread Neil Armstrong
On 30/09/2024 15:03, Thomas Zimmermann wrote: DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Kevin Hilman Cc: Jerome

[PATCH 20/28] drm/tegra: Use video aperture helpers

2024-09-30 Thread Thomas Zimmermann
DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Thierry Reding Cc: Mikko Perttunen Cc: Jonathan Hunter --- drivers/gpu/drm/tegra/drm.c |

  1   2   >