Re: [PATCH v2] docs/gpu: ci: update flake tests requirements

2024-09-26 Thread Vignesh Raman
Hi Maxime, On 26/09/24 12:56, Maxime Ripard wrote: On Thu, Sep 26, 2024 at 12:36:49PM GMT, Vignesh Raman wrote: Update the documentation to require linking to a relevant GitLab issue for each new flake entry instead of an email report. Added specific GitLab issue URLs for i915, xe and other dri

RE: [PATCH 3/5] drm/i915/dp: Return int from dsc_max/min_src_input_bpc helpers

2024-09-26 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Ankit > Nautiyal > Sent: Wednesday, December 13, 2023 2:47 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [PATCH 3/5] drm/i915/dp: Return int from > dsc_max/min_src_input_bpc helpers > > Use ints for dsc_max/m

[PATCH] drm/i915/vdsc: Add bpc check in intel_dsc_compute_params

2024-09-26 Thread Suraj Kandpal
DSC does not support bpc under 8 according to DSC 1.2a Section 2 Requirements. Return an error if that happens to be the case. --v2 -should be bit_per_component [Mitul/Chaitanya] -Add reference to this restriction [Chaitanya] --v3 -Add the bpc in which we see this warning [Jani] Signed-off-by: S

Re: [PATCH] drm/i915/vdsc: Add bpc check in intel_dsc_compute_params

2024-09-26 Thread Jani Nikula
On Thu, 26 Sep 2024, Suraj Kandpal wrote: > DSC does not support bpc under 8 according to DSC 1.2a Section 2 > Requirements. Return an error if that happens to be the case. > > --v2 > -should be bits_per_component [Mitul/Chaitanya/Srikanth] > -Add reference to this restriction [Chaitanya] > > Sign

RE: [PATCH 1/5] drm/i915/dp: Simplify checks for helper intel_dp_dsc_max_src_input_bpc

2024-09-26 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Ankit > Nautiyal > Sent: Wednesday, December 13, 2023 2:46 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [PATCH 1/5] drm/i915/dp: Simplify checks for helper > intel_dp_dsc_max_src_input_bpc > > In helper inte

Re: [PATCH 5/5] drm/i915/dp: Ignore max_requested_bpc if its too low for DSC

2024-09-26 Thread Jani Nikula
On Wed, 13 Dec 2023, Ankit Nautiyal wrote: > At the moment, while choosing the input bpc for DSC, we take into > account the max_requested_bpc property. This creates a problem, if the > max_requested_bpc is lower than the minimum bpc required by source with > DSC. > > So consider max_requested_bpc

RE: [PATCH v3] drm/i915/selftests: Implement frequency check for energy reading validation

2024-09-26 Thread Gupta, Anshuman
> -Original Message- > From: Pottumuttu, Sai Teja > Sent: Thursday, September 19, 2024 2:39 PM > To: Anirban, Sk ; intel-gfx@lists.freedesktop.org; > Gupta, > Anshuman > Cc: Poosa, Karthik ; Pottumuttu, Sai Teja > > Subject: Re: [PATCH v3] drm/i915/selftests: Implement frequency check

Re: [PATCH 1/7] drm/i915/histogram: Define registers for histogram

2024-09-26 Thread Jani Nikula
On Wed, 25 Sep 2024, Arun R Murthy wrote: > Add the register/bit definitions for global histogram. > > Signed-off-by: Arun R Murthy > --- > .../drm/i915/display/intel_histogram_reg.h| 54 +++ We have 36 files named *_regs.h under display/, and 0 files named *_reg.h. We should

Re: [PATCH 08/15] drm/i915/display: Refactor enable_joiner_pipes

2024-09-26 Thread Ville Syrjälä
On Thu, Sep 26, 2024 at 12:56:31PM +0530, Ankit Nautiyal wrote: > Pass the current pipe into enabled_joiner_pipes(), and let it figure out > the proper bitmasks for us. Since the enabled_joiner_pipes now gets the > primary and secondary pipe wrt a given pipe, the helpers > to get primary pipe and s

Re: [PATCH 09/15] drm/i915: Implement hw state readout and checks for ultrajoiner

2024-09-26 Thread Ville Syrjälä
On Thu, Sep 26, 2024 at 12:56:32PM +0530, Ankit Nautiyal wrote: > From: Stanislav Lisovskiy > > Ultrajoiner mode has some new bits and states to be > read out from the hw. Lets make changes accordingly. > > v2: Fix checkpatch warnings. (Ankit) > v3: Add separate functions for computing expected

Re: [PATCH 0/2] drm: revert some framebuffer API tests

2024-09-26 Thread Maxime Ripard
On Wed, Sep 25, 2024 at 09:04:39AM GMT, Guenter Roeck wrote: > On 9/25/24 06:05, Maxime Ripard wrote: > [ ... ] > > > > We've had similar discussions in the past around unit tests that wasted > > > too much cpu time with randomized combinatorial testing, and we've thrown > > > those out too from d

[PATCH v2] docs/gpu: ci: update flake tests requirements

2024-09-26 Thread Vignesh Raman
Update the documentation to require linking to a relevant GitLab issue for each new flake entry instead of an email report. Added specific GitLab issue URLs for i915, xe and other drivers. Signed-off-by: Vignesh Raman --- v2: - Add gitlab issue link for msm driver. --- Documentation/gpu/automa

[PATCH] drm/i915/hdcp: Retry first read and writes to downstream

2024-09-26 Thread Suraj Kandpal
Retry the first read and write to downstream at least 10 times with a 50ms delay if not hdcp2 capable(dock decides to stop advertising hdcp2 capability for some reason). The reason being that during suspend resume Dock usually keep the HDCP2 registers inaccesible causing AUX error. This wouldn't be

[PATCH 10/15] drm/i915/display/vdsc: Add ultrajoiner support with DSC

2024-09-26 Thread Ankit Nautiyal
From: Stanislav Lisovskiy Add changes to DSC which are required for Ultrajoiner. v2: -Use correct helper for setting bits for bigjoiner secondary. (Ankit) -Use primary/secondary instead of master/slave. (Suraj) v3: Add the ultrajoiner helpers and use it for setting ultrajoiner bits (Ankit) v4: U

[PATCH 14/15] drm/i915/display: Consider ultrajoiner for computing maxdotclock

2024-09-26 Thread Ankit Nautiyal
Use the check for ultrajoiner while computing maxdotclock. v2: Add Check for HAS_UNCOMPRESSED_JOINER. (Ville) v3: Remove extraneous newline. (Ville) Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 5 +++-- 1 file changed, 3 insertions

[PATCH 12/15] drm/i915/dp: Simplify helper to get slice count with joiner

2024-09-26 Thread Ankit Nautiyal
From: Stanislav Lisovskiy When bigjoiner is used, we need at least 2 dsc slices per pipe. Modify the condition in intel_dp_dsc_get_slice_count() to reflect the same. Signed-off-by: Stanislav Lisovskiy Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 8 ++-- 1 fi

[PATCH 07/15] drm/i915/display: Add macro HAS_ULTRAJOINER()

2024-09-26 Thread Ankit Nautiyal
Add macro to check if platform supports Ultrajoiner. v2: -Use check for DISPLAY_VER >= 20, and add bmg as a special case. (Ville) -Add check for HAS_DSC. (Ville) Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display_device.h | 3 +++ 1 file cha

[PATCH 13/15] drm/i915: Compute config and mode valid changes for ultrajoiner

2024-09-26 Thread Ankit Nautiyal
From: Stanislav Lisovskiy Implement required changes for mode validation and compute config, to support Ultrajoiner. v2: -Drop changes for HDMI. -Separate out DSC changes into another patch. v3: Fix check in can_ultrajoiner. (Ankit) v4: -Unify helper to check joiner requirement. (Ville) -Split p

[PATCH 15/15] drm/i915/intel_dp: Add support for forcing ultrajoiner

2024-09-26 Thread Ankit Nautiyal
Allow forcing ultrajoiner through debugfs. v2: Minor refactoring of switch case logic. (Ville) Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 03/15] drm/i915/display: Modify debugfs for joiner to force n pipes

2024-09-26 Thread Ankit Nautiyal
At the moment, the debugfs for joiner allows only to force enable/disable pipe joiner for 2 pipes. Modify it to force join 'n' number of pipes, where n is a valid pipe joiner configuration. This will help in case of ultra joiner where 4 pipes are joined. v2: -Fix commit message to state that only

[PATCH 04/15] drm/i915/dp: Add helper to compute num pipes required

2024-09-26 Thread Ankit Nautiyal
Add a helper to compute the number of pipes required. This will depend on whether the joiner is required or is forced through the debugfs. If no joiner is required the helper returns 1. v2: -Return 1 if no joiner is required. (Ville) -Change the suffix from joined_pipes to num_pipes. (Ville) -Use

[PATCH 06/15] drm/i915: Add bigjoiner and uncompressed joiner hw readout sanity checks

2024-09-26 Thread Ankit Nautiyal
From: Stanislav Lisovskiy Add sanity checks for primary and secondary bigjoiner/uncompressed bitmasks, should make it easier to spot possible issues. v2: -Streamline the expected masks and add few more drm_WARNs. (Ville) -Use %#x format specifier for printing joiner masks. (Ville) -Use struct in

[PATCH 08/15] drm/i915/display: Refactor enable_joiner_pipes

2024-09-26 Thread Ankit Nautiyal
Pass the current pipe into enabled_joiner_pipes(), and let it figure out the proper bitmasks for us. Since the enabled_joiner_pipes now gets the primary and secondary pipe wrt a given pipe, the helpers to get primary pipe and secondary pipes are no longer required. v2: -Simplify helper get_joiner_

[PATCH 05/15] drm/i915: Split current joiner hw state readout

2024-09-26 Thread Ankit Nautiyal
We need to add a new sanity checks and also do some preparations for adding ultrajoiner hw state readout. Lets first split reading of the uncompressed joiner and bigjoiner bit masks into separate functions. v2: Fixed checkpatch warnings (Ankit) v3: Use struct intel_display in the new functions. (A

[PATCH 11/15] drm/i915/dp: Modify compressed bpp limitations for ultrajoiner

2024-09-26 Thread Ankit Nautiyal
Add compressed bpp limitations for ultrajoiner. v2: Fix the case for 1 pipe. (Ankit) Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 27 +++-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c

[PATCH 09/15] drm/i915: Implement hw state readout and checks for ultrajoiner

2024-09-26 Thread Ankit Nautiyal
From: Stanislav Lisovskiy Ultrajoiner mode has some new bits and states to be read out from the hw. Lets make changes accordingly. v2: Fix checkpatch warnings. (Ankit) v3: Add separate functions for computing expected secondary_big/ultrajoiner pipes. (Ankit) v4: -Streamline the helpers for ultra

[PATCH 00/15] Ultrajoiner basic functionality series

2024-09-26 Thread Ankit Nautiyal
This patch series attempts to implement basic support for Ultrajoiner functionality. Rev6: -Upgrade the debugfs functionality to enable the joining of a specified number of pipes. -Modify the display helpers reliant on the pipe joiner mechanism to use number of pipes joined, instead of joiner flag

[PATCH 01/15] drm/i915/display_device: Add Check HAS_DSC for bigjoiner

2024-09-26 Thread Ankit Nautiyal
Bigjoiner needs DSC, but DSC might be disabled on some platforms. The platform check itself is not sufficient, so add a check for DSC to reflect that. v2: Modify the commit message to address the DSC fuse case. Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/d

[PATCH 02/15] drm/i915/display_debugfs: Allow force joiner only if supported

2024-09-26 Thread Ankit Nautiyal
Currently we support joiner only for DP encoder. Do not create the debugfs for joiner if DP does not support the joiner. This will also help avoiding cases where config has eDP MSO, with which we do not support joiner. v2: Check for intel_dp_has_joiner and avoid creating debugfs if not supported.

Re: [PATCH v2] docs/gpu: ci: update flake tests requirements

2024-09-26 Thread Maxime Ripard
On Thu, Sep 26, 2024 at 12:36:49PM GMT, Vignesh Raman wrote: > Update the documentation to require linking to a relevant GitLab > issue for each new flake entry instead of an email report. Added > specific GitLab issue URLs for i915, xe and other drivers. > > Signed-off-by: Vignesh Raman > --- >

Re: [PATCH v2] docs/gpu: ci: update flake tests requirements

2024-09-26 Thread Dmitry Baryshkov
On Thu, Sep 26, 2024 at 12:36:49PM GMT, Vignesh Raman wrote: > Update the documentation to require linking to a relevant GitLab > issue for each new flake entry instead of an email report. Added > specific GitLab issue URLs for i915, xe and other drivers. > > Signed-off-by: Vignesh Raman > --- >

[PULL] drm-intel-next-fixes

2024-09-26 Thread Joonas Lahtinen
Hi Dave & Sima, Here goes final drm-intel-next-fixes towards v6.12. Just one fix for DP colorimetry detection. Regards, Joonas *** drm-intel-next-fixes-2024-09-26: - Fix colorimetry detection for DP The following changes since commit d7126c0cfc137a580eba92bd82b6d288bd43961d: Merge tag 'dr

Re: [PATCH 3/3] drm/i915/dp: Extract intel_edp_set_sink_rates()

2024-09-26 Thread Jani Nikula
On Wed, 18 Sep 2024, Ville Syrjala wrote: > From: Ville Syrjälä > > Declutter intel_edp_init_dpcd() a bit by extracting the sink > rates probing into its own function. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_dp.c | 76 + > 1 file chang

Re: [PATCH 3/3] drm/i915/dp: Extract intel_edp_set_sink_rates()

2024-09-26 Thread Jani Nikula
On Thu, 26 Sep 2024, Jani Nikula wrote: > On Wed, 18 Sep 2024, Ville Syrjala wrote: >> +/* >> + * Use DP_LINK_RATE_SET if DP_SUPPORTED_LINK_RATES are available, >> + * default to DP_MAX_LINK_RATE and DP_LINK_BW_SET otherwise. >> + */ >> +if (intel_dp->num_sink_rates) >> +

Re: [PATCH 3/6] drm/i915/pm: Simplify pm hook documentation

2024-09-26 Thread Ville Syrjälä
On Thu, Sep 26, 2024 at 10:45:44AM -0400, Rodrigo Vivi wrote: > On Wed, Sep 25, 2024 at 05:45:23PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Stop spelling out each variant of the hook ("" vs. "_late" vs. > > "_early") and just say eg. "@thaw*" to indicate all of them. > > Avoids

Re: [PATCH 3/6] drm/i915/pm: Simplify pm hook documentation

2024-09-26 Thread Rodrigo Vivi
On Thu, Sep 26, 2024 at 06:38:56PM +0300, Ville Syrjälä wrote: > On Thu, Sep 26, 2024 at 10:45:44AM -0400, Rodrigo Vivi wrote: > > On Wed, Sep 25, 2024 at 05:45:23PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Stop spelling out each variant of the hook ("" vs. "_late" vs. >

Re: [PATCH 5/6] drm/i915/pm: Do pci_restore_state() in switcheroo resume hook

2024-09-26 Thread Ville Syrjälä
On Thu, Sep 26, 2024 at 10:48:41AM -0400, Rodrigo Vivi wrote: > On Wed, Sep 25, 2024 at 05:45:25PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Since this switcheroo stuff bypasses all the core pm we > > have to manually manage the pci state. To that end add the > > missing pci_res

Re: [PATCH 5/6] drm/i915/pm: Do pci_restore_state() in switcheroo resume hook

2024-09-26 Thread Rodrigo Vivi
On Thu, Sep 26, 2024 at 06:36:13PM +0300, Ville Syrjälä wrote: > On Thu, Sep 26, 2024 at 10:48:41AM -0400, Rodrigo Vivi wrote: > > On Wed, Sep 25, 2024 at 05:45:25PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Since this switcheroo stuff bypasses all the core pm we > > > hav

Re: [PATCH] i915: Fix HBLANK Expansion Quirk Causing Modeset Failure on Dell WD19TB Dock at 3440x1440@100Hz

2024-09-26 Thread Imre Deak
On Wed, Sep 25, 2024 at 07:25:34PM -0500, Benjamin Hoefs wrote: > Hello, > > I am using a Dell WD19TB dock with a 3440x1440 monitor. Using it at > 100Hz used to work but recently I tried it again and discovered it no longer > did, specifically the modeset seems to silently fail with no error messa

✓ Fi.CI.BAT: success for drm/i915/cx0: Set power state to ready only on owned PHY lanes (rev3)

2024-09-26 Thread Patchwork
== Series Details == Series: drm/i915/cx0: Set power state to ready only on owned PHY lanes (rev3) URL : https://patchwork.freedesktop.org/series/138985/ State : success == Summary == CI Bug Log - changes from CI_DRM_15446 -> Patchwork_138985v3 =

Re: [PATCH v5 80/80] drm/omapdrm: Run DRM default client setup

2024-09-26 Thread Tomi Valkeinen
On 24/09/2024 10:13, Thomas Zimmermann wrote: Rework fbdev probing to support fbdev_probe in struct drm_driver and remove the old fb_probe callback. Provide an initializer macro for struct drm_driver that sets the callback according to the kernel configuration. Call drm_client_setup() to run the

Re: [PATCH v5 79/80] drm/omapdrm: Remove struct drm_fb_helper from struct omap_fbdev.

2024-09-26 Thread Tomi Valkeinen
Hi, On 24/09/2024 10:13, Thomas Zimmermann wrote: Store instances of drm_fb_helper and struct omap_fbdev separately. This will allow omapdrm to use the common fbdev client, which allocates its own instance of struct drm_fb_helper. There is at most one instance of each per DRM device, so both ca

Re: [PATCH 02/15] drm/i915/display_debugfs: Allow force joiner only if supported

2024-09-26 Thread Nautiyal, Ankit K
On 9/26/2024 4:44 PM, Ville Syrjälä wrote: On Thu, Sep 26, 2024 at 12:56:25PM +0530, Ankit Nautiyal wrote: Currently we support joiner only for DP encoder. Do not create the debugfs for joiner if DP does not support the joiner. This will also help avoiding cases where config has eDP MSO, with

Re: [PATCH v5 42/80] drm/tilcdc: Run DRM default client setup

2024-09-26 Thread Tomi Valkeinen
On 24/09/2024 10:12, Thomas Zimmermann wrote: Call drm_client_setup_with_color_mode() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v5: - select DRM_CLIENT_SELECTION v3: - add DRM_FBDEV_DMA_DRIV

Re: [PATCH 2/6] drm/i915/pm: Hoist pci_save_state()+pci_set_power_state() to the end of pm _late() hook

2024-09-26 Thread Rodrigo Vivi
On Wed, Sep 25, 2024 at 05:45:22PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > driver/pci does the pci_save_state()+pci_set_power_state() from the > _noirq() pm hooks. Move our manual calls (needed for the hibernate+D3 > workaround with buggy BIOSes) towards that same point. We currentl

Re: [PATCH 3/6] drm/i915/pm: Simplify pm hook documentation

2024-09-26 Thread Rodrigo Vivi
On Wed, Sep 25, 2024 at 05:45:23PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Stop spelling out each variant of the hook ("" vs. "_late" vs. > "_early") and just say eg. "@thaw*" to indicate all of them. > Avoids having to update the docs whenever we start/stop using > one of the varia

Re: [PATCH 5/6] drm/i915/pm: Do pci_restore_state() in switcheroo resume hook

2024-09-26 Thread Rodrigo Vivi
On Wed, Sep 25, 2024 at 05:45:25PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Since this switcheroo stuff bypasses all the core pm we > have to manually manage the pci state. To that end add the > missing pci_restore_state() to the switcheroo resume hook. > We already have the pci_save

Re: [PATCH 02/15] drm/i915/display_debugfs: Allow force joiner only if supported

2024-09-26 Thread Ville Syrjälä
On Thu, Sep 26, 2024 at 06:37:46PM +0530, Nautiyal, Ankit K wrote: > > On 9/26/2024 4:44 PM, Ville Syrjälä wrote: > > On Thu, Sep 26, 2024 at 12:56:25PM +0530, Ankit Nautiyal wrote: > >> Currently we support joiner only for DP encoder. > >> Do not create the debugfs for joiner if DP does not suppo

Re: [PATCH v5 47/80] drm/xlnx: Run DRM default client setup

2024-09-26 Thread Tomi Valkeinen
On 24/09/2024 10:12, Thomas Zimmermann wrote: Call drm_client_setup_with_fourcc() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. v5: - select DRM_CLIENT_SELECTION v2: - use drm_client_setup_with_

Re: [PATCH 08/15] drm/i915/display: Refactor enable_joiner_pipes

2024-09-26 Thread Ville Syrjälä
On Thu, Sep 26, 2024 at 06:45:14PM +0530, Nautiyal, Ankit K wrote: > > On 9/26/2024 4:49 PM, Ville Syrjälä wrote: > > On Thu, Sep 26, 2024 at 12:56:31PM +0530, Ankit Nautiyal wrote: > >> Pass the current pipe into enabled_joiner_pipes(), and let it figure out > >> the proper bitmasks for us. Since

[PATCH 0/4] Enhance debugfs for forcing joiner

2024-09-26 Thread Ankit Nautiyal
This patch series introduces enhancements to debugfs for forcing pipe joiner and prepares for the implementation of the ultrajoiner. These patches are derived from the original series [1] focused on the basic functionality of the ultra joiner. The debugfs enhancements are intended for merging prior

[PATCH 4/4] drm/i915/dp: Add helper to compute num pipes required

2024-09-26 Thread Ankit Nautiyal
Add a helper to compute the number of pipes required. This will depend on whether the joiner is required or is forced through the debugfs. If no joiner is required the helper returns 1. v2: -Return 1 if no joiner is required. (Ville) -Change the suffix from joined_pipes to num_pipes. (Ville) -Use

[PATCH 2/4] drm/i915/display_debugfs: Allow force joiner only if supported

2024-09-26 Thread Ankit Nautiyal
Currently we support joiner only for DP encoder. Do not create the debugfs for joiner if DP does not support the joiner. This will also help avoiding cases where config has eDP MSO, with which we do not support joiner. v2: Check for intel_dp_has_joiner and avoid creating debugfs if not supported.

✗ Fi.CI.SPARSE: warning for drm/i915/hdmi: Convert comma to semicolon

2024-09-26 Thread Patchwork
== Series Details == Series: drm/i915/hdmi: Convert comma to semicolon URL : https://patchwork.freedesktop.org/series/138988/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

[PATCH 2/3] drm/i915/irq: remove GEN3_IRQ_RESET() and GEN3_IRQ_INIT() macros

2024-09-26 Thread Jani Nikula
Define register offset triplets for all registers used with GEN3_IRQ_RESET() and GEN3_IRQ_INIT() macros, and call the underlying gen3_irq_reset() and gen3_irq_init() functions directly. Remove the macros, along with the macro name concatenation hackery. Signed-off-by: Jani Nikula --- .../gpu/drm

[PATCH 1/3] drm/i915/irq: add struct i915_irq_regs triplet

2024-09-26 Thread Jani Nikula
Add struct i915_irq_regs to hold IMR/IER/IIR register offsets to pass to gen3_irq_reset() and gen3_irq_init(). This helps in grouping the registers and further cleanup. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_irq.c | 31 ++- drivers/gpu/drm/i915/i91

[PATCH 0/3] drm/i915/irq: clean up irq reset/init macro hacks

2024-09-26 Thread Jani Nikula
Add a struct to hold IMR/IER/IIR registers, and pass them together instead of the ugly macro hacks with macro name concatenation etc. BR, Jani. Jani Nikula (3): drm/i915/irq: add struct i915_irq_regs triplet drm/i915/irq: remove GEN3_IRQ_RESET() and GEN3_IRQ_INIT() macros drm/i915/irq: remo

[PATCH 3/3] drm/i915/irq: remove GEN8_IRQ_RESET_NDX() and GEN8_IRQ_INIT_NDX() macros

2024-09-26 Thread Jani Nikula
Define register offset triplets for all registers used with GEN8_IRQ_RESET_NDX() and GEN8_IRQ_INIT_NDX() macros, and call the underlying gen3_irq_reset() and gen3_irq_init() functions directly. Remove the macros, along with the macro name concatenation hackery. Signed-off-by: Jani Nikula --- ...

[PULL] drm-misc-fixes

2024-09-26 Thread Thomas Zimmermann
Hi Dave, Sima, this is the PR for drm-misc-fixes for this week. Mostly the usual small changes. That fix in the atomic-modesetting code touches UAPI code, but does not change the UAPI itself. Best regards Thomas drm-misc-fixes-2024-09-26: Short summary of fixes pull: atomic: - Use correct type

Re: [PATCH v5 41/80] drm/tidss: Run DRM default client setup

2024-09-26 Thread Tomi Valkeinen
On 24/09/2024 10:12, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The tidss driver specifies a preferred color mode of 32. As this is the defaul

Re: [PATCH 08/15] drm/i915/display: Refactor enable_joiner_pipes

2024-09-26 Thread Nautiyal, Ankit K
On 9/26/2024 4:49 PM, Ville Syrjälä wrote: On Thu, Sep 26, 2024 at 12:56:31PM +0530, Ankit Nautiyal wrote: Pass the current pipe into enabled_joiner_pipes(), and let it figure out the proper bitmasks for us. Since the enabled_joiner_pipes now gets the primary and secondary pipe wrt a given pip

Re: [PATCH i-g-t] tests/xe_gt_freq: Use sync reset

2024-09-26 Thread Rodrigo Vivi
On Wed, Sep 25, 2024 at 03:09:23PM -0700, Vinay Belgaumkar wrote: > Some recent WAs reduce the GT freq during driver load/reset. Use sync > reset so that we give enough time for GT frequency to be restored after > reset has completed. > > Also, stash/restore frequencies per GT as they can be diffe

Re: [PATCH 12/15] drm/i915/dp: Simplify helper to get slice count with joiner

2024-09-26 Thread Ville Syrjälä
On Thu, Sep 26, 2024 at 12:56:35PM +0530, Ankit Nautiyal wrote: > From: Stanislav Lisovskiy > > When bigjoiner is used, we need at least 2 dsc slices per pipe. > Modify the condition in intel_dp_dsc_get_slice_count() to reflect the > same. > > Signed-off-by: Stanislav Lisovskiy > Signed-off-by:

Re: [PATCH 02/15] drm/i915/display_debugfs: Allow force joiner only if supported

2024-09-26 Thread Ville Syrjälä
On Thu, Sep 26, 2024 at 12:56:25PM +0530, Ankit Nautiyal wrote: > Currently we support joiner only for DP encoder. > Do not create the debugfs for joiner if DP does not support the joiner. > This will also help avoiding cases where config has eDP MSO, with which > we do not support joiner. > > v2:

✓ Fi.CI.BAT: success for drm/i915/dp: Add FEC Enable Retry mechanism

2024-09-26 Thread Patchwork
== Series Details == Series: drm/i915/dp: Add FEC Enable Retry mechanism URL : https://patchwork.freedesktop.org/series/138963/ State : success == Summary == CI Bug Log - changes from CI_DRM_15446 -> Patchwork_138963v1 Summary --- **

[PATCH 1/4] drm/i915/display_device: Add Check HAS_DSC for bigjoiner

2024-09-26 Thread Ankit Nautiyal
Bigjoiner needs DSC, but DSC might be disabled on some platforms. The platform check itself is not sufficient, so add a check for DSC to reflect that. v2: Modify the commit message to address the DSC fuse case. Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/d

[PATCH 3/4] drm/i915/display: Modify debugfs for joiner to force n pipes

2024-09-26 Thread Ankit Nautiyal
At the moment, the debugfs for joiner allows only to force enable/disable pipe joiner for 2 pipes. Modify it to force join 'n' number of pipes, where n is a valid pipe joiner configuration. This will help in case of ultra joiner where 4 pipes are joined. v2: -Fix commit message to state that only

Re: [PATCH v2 0/9] drm/i915/display: platform identification with display->is.

2024-09-26 Thread Rodrigo Vivi
On Tue, Sep 24, 2024 at 04:37:04PM +0300, Jani Nikula wrote: > On Tue, 24 Sep 2024, Lucas De Marchi wrote: > > On Tue, Sep 24, 2024 at 12:49:25PM GMT, Jani Nikula wrote: > >>On Thu, 29 Aug 2024, Ville Syrjälä wrote: > >>> On Wed, Aug 28, 2024 at 04:41:24PM -0400, Rodrigo Vivi wrote: > On Mon

✗ Fi.CI.BUILD: failure for drm/display/dsc: Refactor MST DSC Determination Policy

2024-09-26 Thread Patchwork
== Series Details == Series: drm/display/dsc: Refactor MST DSC Determination Policy URL : https://patchwork.freedesktop.org/series/138989/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/138989/revisions/1/mbox/ not applied Applying: drm/display/ds

✓ Fi.CI.BAT: success for drm/i915/hdmi: Convert comma to semicolon

2024-09-26 Thread Patchwork
== Series Details == Series: drm/i915/hdmi: Convert comma to semicolon URL : https://patchwork.freedesktop.org/series/138988/ State : success == Summary == CI Bug Log - changes from CI_DRM_15448 -> Patchwork_138988v1 Summary --- **SU

✗ Fi.CI.CHECKPATCH: warning for drm/i915/bios: Refactor ROM access (rev2)

2024-09-26 Thread Patchwork
== Series Details == Series: drm/i915/bios: Refactor ROM access (rev2) URL : https://patchwork.freedesktop.org/series/138477/ State : warning == Summary == Error: dim checkpatch failed 8b4f246ee508 drm/i915/bios: Use drm_dbg_kms() consistently a487ab653835 drm/i915/bios: Add some size checks t

Re: [PATCH 1/2] drm/i915/hotplug: Reduce SHPD_FLITER_CNT for ICL and above

2024-09-26 Thread Matt Roper
On Tue, Sep 24, 2024 at 01:04:51PM +0530, Suraj Kandpal wrote: > Reduce SHPD_CNT to 250us for ICL and above as it lines up > with DP1.4a(Table3-4) spec. > > --v2 > -Update commit message and comment [Matt] > > --v3 > -drop condition and use value of 250us for ICL and above [Matt] > > Signed-off-

✓ Fi.CI.BAT: success for drm/i915/bios: Refactor ROM access (rev2)

2024-09-26 Thread Patchwork
== Series Details == Series: drm/i915/bios: Refactor ROM access (rev2) URL : https://patchwork.freedesktop.org/series/138477/ State : success == Summary == CI Bug Log - changes from CI_DRM_15448 -> Patchwork_138477v2 Summary --- **SU

✗ Fi.CI.SPARSE: warning for drm/i915/bios: Refactor ROM access (rev2)

2024-09-26 Thread Patchwork
== Series Details == Series: drm/i915/bios: Refactor ROM access (rev2) URL : https://patchwork.freedesktop.org/series/138477/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:

Re: [PATCH 1/6] PCI/PM: Respect pci_dev->skip_bus_pm in the .poweroff() path

2024-09-26 Thread Ville Syrjälä
On Wed, Sep 25, 2024 at 02:28:42PM -0500, Bjorn Helgaas wrote: > On Wed, Sep 25, 2024 at 05:45:21PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > On some older laptops i915 needs to leave the GPU in > > D0 when hibernating the system, or else the BIOS > > hangs somewhere. Currently

Re: [PATCH 2/3] drm/i915/irq: remove GEN3_IRQ_RESET() and GEN3_IRQ_INIT() macros

2024-09-26 Thread Rodrigo Vivi
On Thu, Sep 26, 2024 at 07:57:47PM +0300, Jani Nikula wrote: > Define register offset triplets for all registers used with > GEN3_IRQ_RESET() and GEN3_IRQ_INIT() macros, and call the underlying > gen3_irq_reset() and gen3_irq_init() functions directly. Remove the > macros, along with the macro name

✗ Fi.CI.CHECKPATCH: warning for Miscelaneous fixes for display tracepoints (rev2)

2024-09-26 Thread Patchwork
== Series Details == Series: Miscelaneous fixes for display tracepoints (rev2) URL : https://patchwork.freedesktop.org/series/137978/ State : warning == Summary == Error: dim checkpatch failed 4afc5faab7c8 drm/i915/display: Fix out-of-bounds access in pipe-related tracepoints -:19: WARNING:CO

Re: [PATCH 1/3] drm/i915/irq: add struct i915_irq_regs triplet

2024-09-26 Thread Rodrigo Vivi
On Thu, Sep 26, 2024 at 07:57:46PM +0300, Jani Nikula wrote: > Add struct i915_irq_regs to hold IMR/IER/IIR register offsets to pass to > gen3_irq_reset() and gen3_irq_init(). This helps in grouping the > registers and further cleanup. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/

✗ Fi.CI.SPARSE: warning for drm/i915/guc: Enable PXP GuC autoteardown flow (rev3)

2024-09-26 Thread Patchwork
== Series Details == Series: drm/i915/guc: Enable PXP GuC autoteardown flow (rev3) URL : https://patchwork.freedesktop.org/series/138337/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for Miscelaneous fixes for display tracepoints (rev2)

2024-09-26 Thread Patchwork
== Series Details == Series: Miscelaneous fixes for display tracepoints (rev2) URL : https://patchwork.freedesktop.org/series/137978/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15449 -> Patchwork_137978v2 Summary ---

Re: [PATCH 2/6] drm/i915/pm: Hoist pci_save_state()+pci_set_power_state() to the end of pm _late() hook

2024-09-26 Thread Ville Syrjälä
On Thu, Sep 26, 2024 at 10:43:21AM -0400, Rodrigo Vivi wrote: > On Wed, Sep 25, 2024 at 05:45:22PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > driver/pci does the pci_save_state()+pci_set_power_state() from the > > _noirq() pm hooks. Move our manual calls (needed for the hibernate

Re: [PATCH 3/3] drm/i915/irq: remove GEN8_IRQ_RESET_NDX() and GEN8_IRQ_INIT_NDX() macros

2024-09-26 Thread Rodrigo Vivi
On Thu, Sep 26, 2024 at 07:57:48PM +0300, Jani Nikula wrote: > Define register offset triplets for all registers used with > GEN8_IRQ_RESET_NDX() and GEN8_IRQ_INIT_NDX() macros, and call the > underlying gen3_irq_reset() and gen3_irq_init() functions > directly. Remove the macros, along with the ma

Re: [PATCH v2 5/6] drm/i915/audio: be explicit about intel_wakeref_t conversions

2024-09-26 Thread Rodrigo Vivi
On Wed, Sep 18, 2024 at 08:35:47PM +0300, Jani Nikula wrote: > Use explicit casts to convert between intel_wakeref_t and unsigned long, > to not rely on intel_wakeref_t underlying type remaining unsigned long, > allowing us to change it as needed. (And yes, this is indeed preparation > for changing

Re: [PATCH v2 6/6] drm/i915: switch intel_wakeref_t underlying type to struct ref_tracker *

2024-09-26 Thread Rodrigo Vivi
On Wed, Sep 18, 2024 at 08:35:48PM +0300, Jani Nikula wrote: > For intel_wakeref_t, opaque is reasonable, but disguising the underlying > struct ref_tracker * as an unsigned long is not so great. Update the > typedef to remove one level of disguise. > > Although the kernel coding style strongly di

Re: [PATCH v2 4/6] drm/i915/gt: add a macro for mock gt wakeref special value and use it

2024-09-26 Thread Rodrigo Vivi
On Wed, Sep 18, 2024 at 08:35:46PM +0300, Jani Nikula wrote: > Add a dedicated macro for the special mock gt wakeref value, with a cast > to intel_wakeref_t, instead of assuming you can assign or compare the > wakeref to -ENODEV directly. > > Arguably the whole thing is a hack that should not exis

Re: [PATCH 11/15] drm/i915/dp: Modify compressed bpp limitations for ultrajoiner

2024-09-26 Thread Ville Syrjälä
On Thu, Sep 26, 2024 at 12:56:34PM +0530, Ankit Nautiyal wrote: > Add compressed bpp limitations for ultrajoiner. > > v2: Fix the case for 1 pipe. (Ankit) > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_dp.c | 27 +++-- > 1 file changed, 21 inser

✓ Fi.CI.BAT: success for Reduce SHPD_FILTER_CNT value (rev3)

2024-09-26 Thread Patchwork
== Series Details == Series: Reduce SHPD_FILTER_CNT value (rev3) URL : https://patchwork.freedesktop.org/series/138743/ State : success == Summary == CI Bug Log - changes from CI_DRM_15451 -> Patchwork_138743v3 Summary --- **SUCCESS*

✗ Fi.CI.SPARSE: warning for Consider joiner calculation for panel fitting (rev4)

2024-09-26 Thread Patchwork
== Series Details == Series: Consider joiner calculation for panel fitting (rev4) URL : https://patchwork.freedesktop.org/series/136561/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/as

Re: [PATCH v2 3/6] drm/i915/display: return 0 instead of false for disabled power wakeref

2024-09-26 Thread Rodrigo Vivi
On Wed, Sep 18, 2024 at 08:35:45PM +0300, Jani Nikula wrote: > We can use 0 for intel_wakeref_t, but not false. Fix it. > > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202409190032.zchbxk9e-...@intel.com/ my bad, sorry! Reviewed-by: Rodrigo Vivi > Signed-

✗ Fi.CI.BUILD: failure for drm: Provide client setup helper and convert drivers (rev5)

2024-09-26 Thread Patchwork
== Series Details == Series: drm: Provide client setup helper and convert drivers (rev5) URL : https://patchwork.freedesktop.org/series/137389/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/137389/revisions/5/mbox/ not applied Applying: drm/fbdev

[PULL] drm-misc-next

2024-09-26 Thread Maarten Lankhorst
Hi Dave, Simona, Another pull request for v6.13, to keep up with the huge rate of changes. :-) Forgot to mention in the summary that Louis Chauvet is taking over from Rodrigo Siqueira as vkmms maintainer, sorry about that! Cheers, Maarten drm-misc-next-2024-09-26: drm-misc-next for v6.13:

Re: [PATCH v2 1/6] drm/i915/gem: fix bitwise and logical AND mixup

2024-09-26 Thread Rodrigo Vivi
On Wed, Sep 18, 2024 at 08:35:43PM +0300, Jani Nikula wrote: > CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND is an int, defaulting to 250. When > the wakeref is non-zero, it's either -1 or a dynamically allocated > pointer, depending on CONFIG_DRM_I915_DEBUG_RUNTIME_PM. It's likely that > the code works by

Re: [PATCH v2 2/6] drm/i915: use INTEL_WAKEREF_DEF instead of magic -1 for intel_wakeref_t

2024-09-26 Thread Rodrigo Vivi
On Wed, Sep 18, 2024 at 08:35:44PM +0300, Jani Nikula wrote: > A number of places rely on the magic -1 to denote > INTEL_WAKEREF_DEF. Switch to the macro. Define it for xe as well. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display_power.c| 2 +- > drivers/

✗ Fi.CI.CHECKPATCH: warning for Some correction in the DP Link Training sequence (rev3)

2024-09-26 Thread Patchwork
== Series Details == Series: Some correction in the DP Link Training sequence (rev3) URL : https://patchwork.freedesktop.org/series/139027/ State : warning == Summary == Error: dim checkpatch failed e456c1053e15 drm/i915/dp: use fsleep instead of usleep_range for LT -:12: WARNING:BAD_SIGN_OFF:

✗ Fi.CI.BAT: failure for Consider joiner calculation for panel fitting (rev4)

2024-09-26 Thread Patchwork
== Series Details == Series: Consider joiner calculation for panel fitting (rev4) URL : https://patchwork.freedesktop.org/series/136561/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15451 -> Patchwork_136561v4 Summary

✓ Fi.CI.BAT: success for series starting with [v1,1/1] drm/i915/gt: Use IS_ENABLED() instead of defined() on config check

2024-09-26 Thread Patchwork
== Series Details == Series: series starting with [v1,1/1] drm/i915/gt: Use IS_ENABLED() instead of defined() on config check URL : https://patchwork.freedesktop.org/series/138914/ State : success == Summary == CI Bug Log - changes from CI_DRM_15441 -> Patchwork_138914v1 =

[PATCH] drm/i915/hdcp: Retry first read and writes to downstream

2024-09-26 Thread Suraj Kandpal
Retry the first read and write to downstream at least 10 times with a 50ms delay if not hdcp2 capable(dock decides to stop advertising hdcp2 capability for some reason). The reason being that during suspend resume Dock usually keep the HDCP2 registers inaccesible causing AUX error. This wouldn't be

Re: [PATCH 2/6] drm/i915/pm: Hoist pci_save_state()+pci_set_power_state() to the end of pm _late() hook

2024-09-26 Thread Rodrigo Vivi
On Thu, Sep 26, 2024 at 06:41:17PM +0300, Ville Syrjälä wrote: > On Thu, Sep 26, 2024 at 10:43:21AM -0400, Rodrigo Vivi wrote: > > On Wed, Sep 25, 2024 at 05:45:22PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > driver/pci does the pci_save_state()+pci_set_power_state() from t

✗ Fi.CI.BAT: failure for drm/i915/hdcp: fix connector refcounting

2024-09-26 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: fix connector refcounting URL : https://patchwork.freedesktop.org/series/139057/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15451 -> Patchwork_139057v1 Summary --- **FAI

✗ Fi.CI.SPARSE: warning for Reconcile i915's and xe's display power mgt sequences

2024-09-26 Thread Patchwork
== Series Details == Series: Reconcile i915's and xe's display power mgt sequences URL : https://patchwork.freedesktop.org/series/139062/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

  1   2   >