Re: [PATCH 16/19] drm/i915: Add new abstraction layer to handle pipe order for different joiners

2024-09-16 Thread Nautiyal, Ankit K
On 9/12/2024 4:08 AM, Ville Syrjälä wrote: On Wed, Sep 11, 2024 at 06:43:46PM +0530, Ankit Nautiyal wrote: From: Stanislav Lisovskiy Ultrajoiner case requires special treatment where both reverse and staight order iteration doesn't work(for instance disabling case requires order to be: prima

[PATCH v2 0/2] Block DC6 on Vblank enable for Panel Replay

2024-09-16 Thread Jouni Högander
We need to block DC6 entry in case of Panel Replay as enabling VBI doesn't prevent DC6 in case of Panel Replay. This causes problems if user-space is polling for vblank events. v2: set/clear block_dc6_needed in intel_crtc_vblank_on/off Jouni Högander (2): drm/i915/display: Add block_dc6_needed

[PATCH v2 1/2] drm/i915/display: Add block_dc6_needed variable into intel_crtc

2024-09-16 Thread Jouni Högander
We need to block DC6 entry in case of Panel Replay as enabling VBI doesn't prevent DC6 in case of Panel Replay. This causes problems if user-space is polling for vblank events. For this purpose add new block_dc6_needed variable into intel_crtc. Check if eDP Panel Replay is possible and set the vari

[PATCH v2 2/2] drm/i915/display: Prevent DC6 while vblank is enabled for Panel Replay

2024-09-16 Thread Jouni Högander
We need to block DC6 entry in case of Panel Replay as enabling VBI doesn't prevent DC6 in case of Panel Replay. This causes problems if user-space is polling for vblank events. Fix this by setting target DC state as DC_STATE_EN_UPTO_DC5 when both source and sink are supporting eDP Panel Replay and

Re: [PATCH 6/8] drm/meson: dw-hdmi: annotate dw_hdmi_dwc_write_bits() with __maybe_unused

2024-09-16 Thread Jani Nikula
On Sun, 15 Sep 2024, Martin Blumenstingl wrote: > Hi Jani, > > On Tue, Sep 10, 2024 at 12:08 PM Jani Nikula wrote: >> >> Building with clang and and W=1 leads to warning about unused >> dw_hdmi_dwc_write_bits(). Fix by annotating it with __maybe_unused. >> >> See also commit 6863f5643dd7 ("kbuil

[PATCH v11 0/2] Vrr refactoring and panel replay workaround

2024-09-16 Thread Animesh Manna
Previous patch series link - https://patchwork.freedesktop.org/series/135629/ https://patchwork.freedesktop.org/series/135851/ Animesh Manna (2): drm/i915/vrr: Split vrr-compute-config in two phases drm/i915/panelreplay: Panel replay workaround with VRR drivers/gpu/drm/i915/display/intel_dis

[PATCH v11 2/2] drm/i915/panelreplay: Panel replay workaround with VRR

2024-09-16 Thread Animesh Manna
Panel Replay VSC SDP not getting sent when VRR is enabled and W1 and W2 are 0. So Program Set Context Latency in TRANS_SET_CONTEXT_LATENCY register to at least a value of 1. The same is applicable for PSR1/PSR2 as well. HSD: 14015406119 v1: Initial version. v2: Update timings stored in adjusted_m

[PATCH v11 1/2] drm/i915/vrr: Split vrr-compute-config in two phases

2024-09-16 Thread Animesh Manna
As vrr guardband calculation is dependent on modified vblank start so better to compute late after all vblank adjustement. v1: Initial version. v2: Split in a separate patch from panel-replay workaround. [Ankit] v3: Add a function for late vrr related computation. [Ville] Signed-off-by: Animesh M

✗ Fi.CI.SPARSE: warning for Block DC6 on Vblank enable for Panel Replay (rev2)

2024-09-16 Thread Patchwork
== Series Details == Series: Block DC6 on Vblank enable for Panel Replay (rev2) URL : https://patchwork.freedesktop.org/series/138630/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for Block DC6 on Vblank enable for Panel Replay (rev2)

2024-09-16 Thread Patchwork
== Series Details == Series: Block DC6 on Vblank enable for Panel Replay (rev2) URL : https://patchwork.freedesktop.org/series/138630/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15420 -> Patchwork_138630v2 Summary --

Re: [PATCH v3] firmware: coreboot: Don't register a pdev if screen_info data is present

2024-09-16 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas and Tzung-Bi, > Hi > > Am 15.09.24 um 09:44 schrieb kernel test robot: >> Hi Javier, >> >> kernel test robot noticed the following build errors: >> >> [auto build test ERROR on chrome-platform/for-next] >> [also build test ERROR on chrome-platform/for-firmw

Re: [PATCH 2/2] drm/i915/gt: Fixed an typo

2024-09-16 Thread Andi Shyti
Hi Zhang He, I merged your previous patch so that you don't need to resend it anymore. I already asked you not to resend it in the past version. Please, read carefully the comments you receive. I repeat: add the versioning. When you do: git format patch ... you get: [PATCH 1/1] drm/

[PATCH] drm/i915/psr: eDP Panel Replay is not supported on pipes other than A and B

2024-09-16 Thread Jouni Högander
Do not allow Panel Replay if pipe is other than A or B. Bspec: 68920 Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2736 Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display

Re: [PATCH v3] firmware: coreboot: Don't register a pdev if screen_info data is present

2024-09-16 Thread Thomas Zimmermann
Hi Javier Am 16.09.24 um 10:36 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas and Tzung-Bi, Hi Am 15.09.24 um 09:44 schrieb kernel test robot: Hi Javier, kernel test robot noticed the following build errors: [auto build test ERROR on chrome-platform/for-next] [a

[PATCH] tests: drm_fdinfo: Fix zero tolerance checks

2024-09-16 Thread Janusz Krzysztofik
When we expect an engine to be busy, we check if its reported busy time falls within a +/-5% tolerance range of measurement time period. However, when we expect the engine to be idle, we compare its reported busy time against zero, still with a +/-5% tolerance range, but now calculated against the

Re: [PATCH v3] firmware: coreboot: Don't register a pdev if screen_info data is present

2024-09-16 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Hi Javier > > Am 16.09.24 um 10:36 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >> Hello Thomas and Tzung-Bi, >> >>> Hi >>> >>> Am 15.09.24 um 09:44 schrieb kernel test robot: Hi Javier, kernel test robot noticed the

✓ Fi.CI.BAT: success for Vrr refactoring and panel replay workaround (rev2)

2024-09-16 Thread Patchwork
== Series Details == Series: Vrr refactoring and panel replay workaround (rev2) URL : https://patchwork.freedesktop.org/series/138232/ State : success == Summary == CI Bug Log - changes from CI_DRM_15420 -> Patchwork_138232v2 Summary --

Re: [PATCH v1] drm/i915/dp: Remove double assignment in intel_dp_compute_as_sdp()

2024-09-16 Thread Andi Shyti
Hi Yuesong, On Fri, Aug 23, 2024 at 10:36:12AM GMT, Yuesong Li wrote: > cocci report a double assignment warning. 'as_sdp->duration_incr_ms' > was assigned twice in intel_dp_compute_as_sdp(). > > Signed-off-by: Yuesong Li reviewed and merged to drm-intel-next. Thanks, Andi

Re: [PATCH v1] drm/i915/gvt: Correct multiple typos in comments

2024-09-16 Thread Andi Shyti
Hi Shen, On Fri, Sep 13, 2024 at 10:16:12AM GMT, Shen Lichuan wrote: > Fixed some spelling errors, the details are as follows: > > -in the code comments: > addess->address > trasitions->transitions > furture->future > unsubmited->unsubmitted > > Signed-off-by: Shen Lichua

Re: [PATCH v1] drm/i915/display: fix typo in the comment

2024-09-16 Thread Andi Shyti
Hi Yan, On Fri, Sep 13, 2024 at 02:17:27PM GMT, Yan Zhen wrote: > Correctly spelled comments make it easier for the reader to understand > the code. > > Replace 'platformas' with 'platforms' in the comment & > replace 'prefere' with 'prefer' in the comment & > replace 'corresponsding' with 'corre

Re: [PATCH v1] drm/i915: Fix typo in the comment

2024-09-16 Thread Andi Shyti
Hi Yan, On Sat, Sep 14, 2024 at 02:41:41PM GMT, Yan Zhen wrote: > Correctly spelled comments make it easier for the reader to understand > the code. > > Replace 'ojects' with 'objects' in the comment & > replace 'resonable' with 'reasonable' in the comment & > replace 'droping' with 'dropping' in

Re: [PATCH] drm/i915: Fix typos

2024-09-16 Thread Andi Shyti
Hi Andrew, On Sun, Sep 15, 2024 at 03:01:55PM GMT, Andrew Kreimer wrote: > Fix typos in documentation. > > Reported-by: Matthew Wilcox > Signed-off-by: Andrew Kreimer Reviewed-by: Andi Shyti Because we are receiving lots of typos patches in this period, it's nice to have the context written

[PATCH 0/4] Use num of pipes in joiner helpers

2024-09-16 Thread Ankit Nautiyal
Currently few joiner helpers pass joiner flag to represent if bigjoiner is used. To scale this for ultrajoiner, enhance these helpers to use num of pipes instead of joiner flag. This new approach is adaptable to various joiner configurations with 1 (no joiner), 2 (big joiner) and forthcoming 4 (ult

[PATCH 1/4] drm/i915/display: Simplify intel_joiner_num_pipes and its usage

2024-09-16 Thread Ankit Nautiyal
Currently intel_joiner_num_pipes is used to get num of pipes wrt num of pipes joined. Simplify this by returning 1 when no joiner is used and update the checks for no joiner case. v2: Rename the function to intel_crtc_num_joined_pipes and use helper intel_crtc_joined_pipe_mask. (Ville) Signed-off

[PATCH 3/4] drm/i915/display: Use joined pipes in intel_mode_valid_max_plane_size

2024-09-16 Thread Ankit Nautiyal
In preparation of ultrajoiner, use number of pipes in the intel_mode_valid_max_plane_size helper, instead of joiner flag. v2: Use num_joined_pipes 1 where there are no joined pipes (Ville) Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/

[PATCH 4/4] drm/i915/display: Use joined pipes in dsc helpers for slices, bpp

2024-09-16 Thread Ankit Nautiyal
In preparation of ultrajoiner, use number of joined pipes in the dsc helpers to compute dsc slices and max compressed bpp, instead of using the joiner flag. v2: Adjust the formulae to use num of pipes as 1 (no joiner) or 2 (bigjoiner). (Ankit) Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kan

[PATCH 2/4] drm/i915/display: Use joined pipes in intel_dp_joiner_needs_dsc

2024-09-16 Thread Ankit Nautiyal
In preparation of ultrajoiner, use number of joined pipes in the intel_dp_joiner_needs_dsc helper, instead of joiner flag. v2: Use intel_crtc_num_joined_pipes. (Ville) Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu

[PATCH v4 0/2] firmware: Avoid coreboot and sysfb to register a pdev for same framebuffer

2024-09-16 Thread Javier Martinez Canillas
Hello, This is v4 of a fix to prevent both coreboot and sysfb drivers to register a platform device to setup a system framebuffer. It has been converted to a series since contains changes for both drivers, to prevent build issues on architectures that don't define a global struct screen_info. Pat

[PATCH v4 1/2] firmware: sysfb: Add a sysfb_handles_screen_info() helper function

2024-09-16 Thread Javier Martinez Canillas
That can be used by drivers to check if the Generic System Framebuffers (sysfb) support can handle the data contained in the global screen_info. Drivers might need this information to know if have to setup the system framebuffer, or if they have to delegate this action to sysfb instead. Suggested

[PATCH v4 2/2] firmware: coreboot: Don't register a pdev if screen_info data is present

2024-09-16 Thread Javier Martinez Canillas
On coreboot platforms, a system framebuffer may be provided to the Linux kernel by filling a LB_TAG_FRAMEBUFFER entry in the coreboot table. But a coreboot payload (e.g: SeaBIOS) could also provide its own framebuffer information to the Linux kernel. If that's the case, arch x86 boot code will fil

[PATCH v4] drm/connector: hdmi: Fix writing Dynamic Range Mastering infoframes

2024-09-16 Thread Derek Foreman
The largest infoframe we create is the DRM (Dynamic Range Mastering) infoframe which is 26 bytes + a 4 byte header, for a total of 30 bytes. With HDMI_MAX_INFOFRAME_SIZE set to 29 bytes, as it is now, we allocate too little space to pack a DRM infoframe in write_device_infoframe(), leading to an E

Re: [PATCH v3] firmware: coreboot: Don't register a pdev if screen_info data is present

2024-09-16 Thread Tzung-Bi Shih
On Fri, Sep 13, 2024 at 11:32:29PM +0200, Javier Martinez Canillas wrote: > @@ -27,8 +28,10 @@ static int framebuffer_probe(struct coreboot_device *dev) > int i; > u32 length; > struct lb_framebuffer *fb = &dev->framebuffer; > + const struct screen_info *si = &screen_info; >

[PATCH] drm/i915: Fix typos

2024-09-16 Thread Andrew Kreimer
Fix typos in documentation. Reported-by: Matthew Wilcox Signed-off-by: Andrew Kreimer --- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- drivers/gpu/drm/i915/gt/shaders/README | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/

[PATCH 2/2] drm/i915/gt: Fixed an typo

2024-09-16 Thread Zhang He
column header should be GPU, not CPU --- ChangeLog: v1: use correct name as Author and Signer v2: change one line in drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c, LLC's information header from "Effective CPU freq" to "Effective GPU freq" Signed-off-by: Zhang He --- drivers/gpu

Re: [PATCH] drm/i915: Fix typos

2024-09-16 Thread Andrew Kreimer
On Mon, Sep 16, 2024 at 12:15:32PM +0200, Andi Shyti wrote: > Hi Andrew, > > On Sun, Sep 15, 2024 at 03:01:55PM GMT, Andrew Kreimer wrote: > > Fix typos in documentation. > > > > Reported-by: Matthew Wilcox > > Signed-off-by: Andrew Kreimer > > Reviewed-by: Andi Shyti > > Because we are rece

[PATCH v1] drm/i915: Fix typo in the comment

2024-09-16 Thread Yan Zhen
Correctly spelled comments make it easier for the reader to understand the code. Replace 'ojects' with 'objects' in the comment & replace 'resonable' with 'reasonable' in the comment & replace 'droping' with 'dropping' in the comment & replace 'sacrifical' with 'sacrificial' in the comment. Signe

Re: [PATCH 6/8] drm/meson: dw-hdmi: annotate dw_hdmi_dwc_write_bits() with __maybe_unused

2024-09-16 Thread Martin Blumenstingl
Hi Jani, On Tue, Sep 10, 2024 at 12:08 PM Jani Nikula wrote: > > Building with clang and and W=1 leads to warning about unused > dw_hdmi_dwc_write_bits(). Fix by annotating it with __maybe_unused. > > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static > inline functions for

[PATCH] drm/i915: add i9xx_display_irq_reset()

2024-09-16 Thread Jani Nikula
Add common i9xx_display_irq_reset() for display 2-4. The check for I915_HAS_HOTPLUG() covers all the alternatives. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_irq.c | 13 - drivers/gpu/drm/i915/display/intel_display_irq.h | 2 +- drivers/gpu/drm/i915/i9

✗ Fi.CI.BUILD: failure for tests: drm_fdinfo: Fix zero tolerance checks

2024-09-16 Thread Patchwork
== Series Details == Series: tests: drm_fdinfo: Fix zero tolerance checks URL : https://patchwork.freedesktop.org/series/138705/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/138705/revisions/1/mbox/ not applied Applying: tests: drm_fdinfo: Fix z

[PATCH v6 00/12] spi: add driver for Intel discrete graphics

2024-09-16 Thread Alexander Usyskin
Add driver for access to Intel discrete graphics card internal SPI device. Expose device on auxiliary bus by i915 and Xe drivers and provide spi driver to register this device with MTD framework. This is a rewrite of "drm/i915/spi: spi access for discrete graphics" series with connection to the Xe

[PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-16 Thread Alexander Usyskin
Add auxiliary driver for intel discrete graphics on-die spi device. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- MAINTAINERS | 7 ++ drivers/spi/Kconfig | 11 +++ drivers/spi/Makefile |

[PATCH v6 02/12] spi: intel-dg: implement region enumeration

2024-09-16 Thread Alexander Usyskin
From: Tomas Winkler In intel-dg spi, there is no access to the spi controller, the information is extracted from the descriptor region. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 190 +++

[PATCH v6 03/12] spi: intel-dg: implement spi access functions

2024-09-16 Thread Alexander Usyskin
From: Tomas Winkler Implement spi_read(), spi_erase() and spi_write() functions. CC: Lucas De Marchi CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Vitaly Lubart Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 199 + 1 fil

[PATCH v6 04/12] spi: intel-dg: spi register with mtd

2024-09-16 Thread Alexander Usyskin
From: Tomas Winkler Register the on-die spi device with the mtd subsystem. Refcount spi object on _get and _put mtd callbacks. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 111

[PATCH v6 05/12] spi: intel-dg: implement mtd access handlers

2024-09-16 Thread Alexander Usyskin
From: Tomas Winkler Implement mtd read, erase, and write handlers. For erase operation address and size should be 4K aligned. For write operation address and size has to be 4bytes aligned. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Vitaly Lubart Signed-o

[PATCH v6 06/12] spi: intel-dg: align 64bit read and write

2024-09-16 Thread Alexander Usyskin
GSC SPI HW errors on quad access overlapping 1K border. Align 64bit read and write to avoid readq/writeq over 1K border. Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/spi/spi-intel-

[PATCH v6 07/12] spi: intel-dg: wake card on operations

2024-09-16 Thread Alexander Usyskin
Enable runtime PM in spi driver to notify graphics driver that whole card should be kept awake while spi operations are performed through this driver. CC: Lucas De Marchi Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 44 ++ 1 file changed,

[PATCH v6 08/12] drm/i915/spi: add spi device for discrete graphics

2024-09-16 Thread Alexander Usyskin
From: Tomas Winkler Enable access to internal spi on DGFX devices via a child device. The spi child device is exposed via auxiliary bus. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/Makefile| 4 ++ drive

[PATCH v6 11/12] drm/xe/spi: add on-die spi device

2024-09-16 Thread Alexander Usyskin
Enable access to internal spi on DGFX with GSC/CSC devices via a child device. The spi child device is exposed via auxiliary bus. Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/xe_device.c | 3 + drivers/gpu/drm/xe/xe_device_types.h |

[PATCH v6 12/12] drm/xe/spi: add support for access mode

2024-09-16 Thread Alexander Usyskin
Check SPI access mode from GSC FW status registers and overwrite access status read from SPI descriptor, if needed. Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/xe/regs/xe_gsc_regs.h | 4 drivers/gpu/drm/xe/xe_heci_gsc.c | 5 +--- drivers/gpu/drm/xe/xe_spi.c | 33 ++

[PATCH v6 09/12] drm/i915/spi: add intel_spi_region map

2024-09-16 Thread Alexander Usyskin
From: Tomas Winkler Add the dGFX spi region map and convey it via auxiliary device to the spi child device. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/spi/intel_spi.c | 8 1 file changed, 8 insertions(

[PATCH v6 10/12] drm/i915/spi: add support for access mode

2024-09-16 Thread Alexander Usyskin
Check SPI access mode from GSC FW status registers and overwrite access status read from SPI descriptor, if needed. Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/spi/intel_spi.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/i915/spi/in

Re: [PATCH 1/2] drm/xe: Fix DSB buffer coherency

2024-09-16 Thread Ville Syrjälä
On Fri, Sep 13, 2024 at 08:44:01PM +0200, Maarten Lankhorst wrote: > > > Den 2024-09-13 kl. 19:12, skrev Ville Syrjälä: > > On Fri, Sep 13, 2024 at 01:47:53PM +0200, Maarten Lankhorst wrote: > >> Add the scanout flag to force WC caching, and add the memory barrier > >> where needed. > >> > >> Sig

✓ Fi.CI.BAT: success for drm/i915/psr: eDP Panel Replay is not supported on pipes other than A and B

2024-09-16 Thread Patchwork
== Series Details == Series: drm/i915/psr: eDP Panel Replay is not supported on pipes other than A and B URL : https://patchwork.freedesktop.org/series/138703/ State : success == Summary == CI Bug Log - changes from CI_DRM_15423 -> Patchwork_138703v1 ==

✗ Fi.CI.SPARSE: warning for Use num of pipes in joiner helpers (rev3)

2024-09-16 Thread Patchwork
== Series Details == Series: Use num of pipes in joiner helpers (rev3) URL : https://patchwork.freedesktop.org/series/138572/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:

Re: [PATCH] drm/i915/cx0: Use one lane to set power state to ready in DP alt mode

2024-09-16 Thread Gustavo Sousa
Hi, Vamsi. Thanks for your patch. Please, see my feedback below. Quoting Vamsi Krishna Brahmajosyula (2024-09-06 14:46:01-03:00) >In DP alt mode one lane is owned by display and the other by usb >intel_cx0pll_enable currently performs a power cycle ready on both >the lanes in all cases. > >Addres

Re: [PATCH v4 1/2] firmware: sysfb: Add a sysfb_handles_screen_info() helper function

2024-09-16 Thread Thomas Zimmermann
Am 16.09.24 um 13:00 schrieb Javier Martinez Canillas: That can be used by drivers to check if the Generic System Framebuffers (sysfb) support can handle the data contained in the global screen_info. Drivers might need this information to know if have to setup the system framebuffer, or if th

✗ Fi.CI.BAT: failure for Use num of pipes in joiner helpers (rev3)

2024-09-16 Thread Patchwork
== Series Details == Series: Use num of pipes in joiner helpers (rev3) URL : https://patchwork.freedesktop.org/series/138572/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15423 -> Patchwork_138572v3 Summary --- **FA

✗ Fi.CI.CHECKPATCH: warning for firmware: Avoid coreboot and sysfb to register a pdev for same framebuffer

2024-09-16 Thread Patchwork
== Series Details == Series: firmware: Avoid coreboot and sysfb to register a pdev for same framebuffer URL : https://patchwork.freedesktop.org/series/138709/ State : warning == Summary == Error: dim checkpatch failed c0fbd5ca4602 firmware: sysfb: Add a sysfb_handles_screen_info() helper func

Re: [PATCH 16/19] drm/i915: Add new abstraction layer to handle pipe order for different joiners

2024-09-16 Thread Ville Syrjälä
On Mon, Sep 16, 2024 at 01:09:42PM +0530, Nautiyal, Ankit K wrote: > > On 9/12/2024 4:08 AM, Ville Syrjälä wrote: > > On Wed, Sep 11, 2024 at 06:43:46PM +0530, Ankit Nautiyal wrote: > >> From: Stanislav Lisovskiy > >> > >> Ultrajoiner case requires special treatment where both reverse and > >> st

Re: [PATCH 16/19] drm/i915: Add new abstraction layer to handle pipe order for different joiners

2024-09-16 Thread Ville Syrjälä
On Mon, Sep 16, 2024 at 05:54:12PM +0300, Ville Syrjälä wrote: > On Mon, Sep 16, 2024 at 01:09:42PM +0530, Nautiyal, Ankit K wrote: > > > > On 9/12/2024 4:08 AM, Ville Syrjälä wrote: > > > On Wed, Sep 11, 2024 at 06:43:46PM +0530, Ankit Nautiyal wrote: > > >> From: Stanislav Lisovskiy > > >> > >

✓ Fi.CI.BAT: success for firmware: Avoid coreboot and sysfb to register a pdev for same framebuffer

2024-09-16 Thread Patchwork
== Series Details == Series: firmware: Avoid coreboot and sysfb to register a pdev for same framebuffer URL : https://patchwork.freedesktop.org/series/138709/ State : success == Summary == CI Bug Log - changes from CI_DRM_15423 -> Patchwork_138709v1 ===

✗ Fi.CI.SPARSE: warning for drm/connector: hdmi: Fix writing Dynamic Range Mastering infoframes

2024-09-16 Thread Patchwork
== Series Details == Series: drm/connector: hdmi: Fix writing Dynamic Range Mastering infoframes URL : https://patchwork.freedesktop.org/series/138711/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH 2/2] drm/i915: Extract intel_post_plane_update_after_readout()

2024-09-16 Thread Ville Syrjala
From: Ville Syrjälä Clean up the main commit_tail() codepath a bit by pulling the post plane update steps that need to performed after readout into their own little function (intel_post_plane_update_after_readout()). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c

[PATCH 1/2] drm/i915/color: Extract intel_color_modeset()

2024-09-16 Thread Ville Syrjala
From: Ville Syrjälä We always perform the same steps to program color management stuff during a full modeset. Extract that code to a helper to avoid duplication. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 17 ++ drivers/gpu/drm/i915/display/intel_co

[PATCH 0/2] drm/i915: Some modeset refactoring

2024-09-16 Thread Ville Syrjala
From: Ville Syrjälä Clean up the modeset code a bit by extracting some functions. Ville Syrjälä (2): drm/i915/color: Extract intel_color_modeset() drm/i915: Extract intel_post_plane_update_after_readout() drivers/gpu/drm/i915/display/intel_color.c | 17 ++ drivers/gpu/drm/i915/displa

Re: [PATCH 3/3] drm/i915/irq: Rename suspend/resume funcitons

2024-09-16 Thread Rodrigo Vivi
On Fri, Sep 13, 2024 at 11:07:33AM +0200, Andi Shyti wrote: > Hi Rodrigo, > > On Thu, Sep 12, 2024 at 01:25:39PM GMT, Rodrigo Vivi wrote: > > Although these functions are used in runtime_pm, they are not > > exclusively used there, so remove the misleading prefix. > > > > Signed-off-by: Rodrigo V

✓ Fi.CI.BAT: success for drm/connector: hdmi: Fix writing Dynamic Range Mastering infoframes

2024-09-16 Thread Patchwork
== Series Details == Series: drm/connector: hdmi: Fix writing Dynamic Range Mastering infoframes URL : https://patchwork.freedesktop.org/series/138711/ State : success == Summary == CI Bug Log - changes from CI_DRM_15423 -> Patchwork_138711v1 ===

[PATCH] drm/i915/irq: Uninstall should be called just once

2024-09-16 Thread Rodrigo Vivi
There shouldn't be any path where the irq uninstall is called twice nowadays. So, remove the FIXME commend and change the check to a WARN. Suggested-by: Jani Nikula Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_irq.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff

Re: [PATCH 2/2] drm/i915/display: move enum i9xx_plane_id to intel_display_limits.h

2024-09-16 Thread Rodrigo Vivi
On Sat, Sep 14, 2024 at 12:32:13AM +0300, Jani Nikula wrote: > On Fri, 13 Sep 2024, Rodrigo Vivi wrote: > > On Fri, Sep 13, 2024 at 04:54:39PM +0300, Jani Nikula wrote: > >> Move enum i9xx_plane_id from intel_display.h to intel_display_limits.h > >> to be able to reduce dependencies on intel_displ

[PATCH 0/7] drm/i915: Some wm/cxsr cleanups

2024-09-16 Thread Ville Syrjala
From: Ville Syrjälä Start sorting out the pre-skl wm/cxsr code a bit. My plan is: - move platform specific stuff out from intel_atomic_plane.c - make cxsr actually robust (currently it has a bunch of poorly handled corner cases) - probably some other fixes and cleanups This series doesn't achi

[PATCH 2/7] drm/i915: Combine .compute_{pipe, intermediate}_wm() into one

2024-09-16 Thread Ville Syrjala
From: Ville Syrjälä We always call .compute_pipe_wm() and .compute_intermediate_wm() back to back. Just combine them to a single hook for simplicity. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/i9xx_wm.c| 57 +-- drivers/gpu/drm/i915/display/intel_disp

[PATCH 1/7] drm/i915: Remove leftover intel_sprite_set_colorkey_ioctl() prototype

2024-09-16 Thread Ville Syrjala
From: Ville Syrjälä intel_sprite_set_colorkey_ioctl() lives in intel_sprice_uapi.{c,h} these days. For some reason the old protoype was left behind in intel_sprite.h and even used by i915_driver.c. Remove the leftovers and switch to including the correct header for the prototype. Signed-off-by:

[PATCH 3/7] drm/i915: Extract ilk_must_disable_lp_wm()

2024-09-16 Thread Ville Syrjala
From: Ville Syrjälä Pull the ilk/snb/ivb LP watermark disable checks into a separate function similar to the gmch counterpart (i9xx_must_disable_cxsr()). Reduces the clutter in intel_plane_atomic_calc_changes() significantly. Reviewed-by: Arun R Murthy Signed-off-by: Ville Syrjälä --- .../gpu

[PATCH 4/7] drm/i915: Clean up intel_wm_need_update()

2024-09-16 Thread Ville Syrjala
From: Ville Syrjälä intel_wm_need_update() is a mess when it comes to variable names and constness. The checks also keep alternating randomly between 'old != cur' vs. 'cur != old'. Clean it all up. Signed-off-by: Ville Syrjälä --- .../gpu/drm/i915/display/intel_atomic_plane.c | 20 +---

[PATCH 5/7] drm/i915: Move the dodgy pre-g4x wm stuff into i9xx_wm

2024-09-16 Thread Ville Syrjala
From: Ville Syrjälä As with other watermark calculations, the dodgy pre-g4x update_wm_{pre,post} flag calcultion would like to know if a modeset is about to happen or not, and technically later stages in the atomic_check() may still flag one. In practice that shouldn't happen as we don't have dyn

[PATCH 6/7] drm/i915: s/disable_lp_wm/disable_cxsr/

2024-09-16 Thread Ville Syrjala
From: Ville Syrjälä The ilk+ disable_lp_wm boolean has the exact same role as disable_cxsr for gmch platforms. The documentation also still talks about CxSR on ilk+ even theough the way you control it has now change to involve toggling the LP watermarks. Get rid of disable_lp_wm and just use disa

[PATCH 7/7] drm/i915: Rename variables in ilk_intermedidate_wm()

2024-09-16 Thread Ville Syrjala
From: Ville Syrjälä ilk_compute_intermediate_wm() uses rather poor variable names for its watermark structs. Borrow a better naming convention from the g4x/vlv counterpart code. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/i9xx_wm.c | 35 +++--- 1 file chan

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix typos

2024-09-16 Thread Patchwork
== Series Details == Series: drm/i915: Fix typos URL : https://patchwork.freedesktop.org/series/138712/ State : warning == Summary == Error: dim checkpatch failed d8f00862a069 drm/i915: Fix typos -:8: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a

Re: [PATCH] drm/i915: add i9xx_display_irq_reset()

2024-09-16 Thread Rodrigo Vivi
On Mon, Sep 16, 2024 at 04:47:20PM +0300, Jani Nikula wrote: > Add common i9xx_display_irq_reset() for display 2-4. The check for > I915_HAS_HOTPLUG() covers all the alternatives. Reviewed-by: Rodrigo Vivi > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display_irq.c

✓ Fi.CI.BAT: success for drm/i915: Fix typos

2024-09-16 Thread Patchwork
== Series Details == Series: drm/i915: Fix typos URL : https://patchwork.freedesktop.org/series/138712/ State : success == Summary == CI Bug Log - changes from CI_DRM_15424 -> Patchwork_138712v1 Summary --- **SUCCESS** No regressi

✓ Fi.CI.BAT: success for drm/i915/gt: Fixed an typo

2024-09-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: Fixed an typo URL : https://patchwork.freedesktop.org/series/138669/ State : success == Summary == CI Bug Log - changes from CI_DRM_15425 -> Patchwork_138669v1 Summary --- **SUCCESS** No r

Re: [PATCH v6 07/12] spi: intel-dg: wake card on operations

2024-09-16 Thread Rodrigo Vivi
On Mon, Sep 16, 2024 at 04:49:23PM +0300, Alexander Usyskin wrote: > Enable runtime PM in spi driver to notify graphics driver that > whole card should be kept awake while spi operations are > performed through this driver. > > CC: Lucas De Marchi > Signed-off-by: Alexander Usyskin > --- > driv

Re: [PATCH v6 11/12] drm/xe/spi: add on-die spi device

2024-09-16 Thread Rodrigo Vivi
On Mon, Sep 16, 2024 at 04:49:27PM +0300, Alexander Usyskin wrote: > Enable access to internal spi on DGFX with GSC/CSC devices > via a child device. > The spi child device is exposed via auxiliary bus. > > Signed-off-by: Alexander Usyskin > --- > drivers/gpu/drm/xe/Makefile | 1 + > d

✓ Fi.CI.BAT: success for drm/i915: Fix typo in the comment

2024-09-16 Thread Patchwork
== Series Details == Series: drm/i915: Fix typo in the comment URL : https://patchwork.freedesktop.org/series/138713/ State : success == Summary == CI Bug Log - changes from CI_DRM_15425 -> Patchwork_138713v1 Summary --- **SUCCESS**

✓ Fi.CI.BAT: success for drm/i915: add i9xx_display_irq_reset()

2024-09-16 Thread Patchwork
== Series Details == Series: drm/i915: add i9xx_display_irq_reset() URL : https://patchwork.freedesktop.org/series/138721/ State : success == Summary == CI Bug Log - changes from CI_DRM_15425 -> Patchwork_138721v1 Summary --- **SUCCE

✗ Fi.CI.CHECKPATCH: warning for spi: add driver for Intel discrete graphics (rev6)

2024-09-16 Thread Patchwork
== Series Details == Series: spi: add driver for Intel discrete graphics (rev6) URL : https://patchwork.freedesktop.org/series/131763/ State : warning == Summary == Error: dim checkpatch failed d45399ca7db7 spi: add driver for intel graphics on-die spi device -:67: WARNING:FILE_PATH_CHANGES: a

✗ Fi.CI.SPARSE: warning for spi: add driver for Intel discrete graphics (rev6)

2024-09-16 Thread Patchwork
== Series Details == Series: spi: add driver for Intel discrete graphics (rev6) URL : https://patchwork.freedesktop.org/series/131763/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for spi: add driver for Intel discrete graphics (rev6)

2024-09-16 Thread Patchwork
== Series Details == Series: spi: add driver for Intel discrete graphics (rev6) URL : https://patchwork.freedesktop.org/series/131763/ State : success == Summary == CI Bug Log - changes from CI_DRM_15425 -> Patchwork_131763v6 Summary --

✗ Fi.CI.SPARSE: warning for drm/i915: Some modeset refactoring

2024-09-16 Thread Patchwork
== Series Details == Series: drm/i915: Some modeset refactoring URL : https://patchwork.freedesktop.org/series/138727/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1:

✓ Fi.CI.BAT: success for drm/i915: Some modeset refactoring

2024-09-16 Thread Patchwork
== Series Details == Series: drm/i915: Some modeset refactoring URL : https://patchwork.freedesktop.org/series/138727/ State : success == Summary == CI Bug Log - changes from CI_DRM_15425 -> Patchwork_138727v1 Summary --- **SUCCESS**

✓ Fi.CI.BAT: success for drm/i915/irq: Uninstall should be called just once

2024-09-16 Thread Patchwork
== Series Details == Series: drm/i915/irq: Uninstall should be called just once URL : https://patchwork.freedesktop.org/series/138728/ State : success == Summary == CI Bug Log - changes from CI_DRM_15425 -> Patchwork_138728v1 Summary --

Re: [PATCH] drm/i915/display: Convert i915_suspend into i9xx_display_sr

2024-09-16 Thread Rodrigo Vivi
On Fri, Sep 13, 2024 at 02:22:34PM +0300, Ville Syrjälä wrote: > On Thu, Sep 12, 2024 at 01:45:34PM -0400, Rodrigo Vivi wrote: > > These save & restore functions inside i915_suspend are old display > > functions to save and restore a bunch of display related registers. > > > > Move it under displa

✗ Fi.CI.IGT: failure for drm/i915/psr: eDP Panel Replay is not supported on pipes other than A and B

2024-09-16 Thread Patchwork
== Series Details == Series: drm/i915/psr: eDP Panel Replay is not supported on pipes other than A and B URL : https://patchwork.freedesktop.org/series/138703/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15423_full -> Patchwork_138703v1_full

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Some wm/cxsr cleanups

2024-09-16 Thread Patchwork
== Series Details == Series: drm/i915: Some wm/cxsr cleanups URL : https://patchwork.freedesktop.org/series/138729/ State : warning == Summary == Error: dim checkpatch failed b9bbeffe8e8d drm/i915: Remove leftover intel_sprite_set_colorkey_ioctl() prototype e59da38fc0ee drm/i915: Combine .com

✗ Fi.CI.SPARSE: warning for drm/i915: Some wm/cxsr cleanups

2024-09-16 Thread Patchwork
== Series Details == Series: drm/i915: Some wm/cxsr cleanups URL : https://patchwork.freedesktop.org/series/138729/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for drm/i915: Some wm/cxsr cleanups

2024-09-16 Thread Patchwork
== Series Details == Series: drm/i915: Some wm/cxsr cleanups URL : https://patchwork.freedesktop.org/series/138729/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15426 -> Patchwork_138729v1 Summary --- **FAILURE**

✗ Fi.CI.BAT: failure for drm/i915/psr: Fix PSR sink enable sequence (rev2)

2024-09-16 Thread Patchwork
== Series Details == Series: drm/i915/psr: Fix PSR sink enable sequence (rev2) URL : https://patchwork.freedesktop.org/series/138530/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15427 -> Patchwork_138530v2 Summary ---

[PATCH v5 1/4] drm: Introduce device wedged event

2024-09-16 Thread Raag Jadav
Introduce device wedged event, which will notify userspace of wedged (hanged/unusable) state of the DRM device through a uevent. This is useful especially in cases where the device is no longer operating as expected and has become unrecoverable from driver context. Purpose of this implementation i

[PATCH v5 0/4] Introduce DRM device wedged event

2024-09-16 Thread Raag Jadav
This series introduces device wedged event in DRM subsystem and uses it in xe and i915 drivers. Detailed description in commit message. This was earlier attempted as xe specific uevent in v1 and v2. https://patchwork.freedesktop.org/series/136909/ v2: Change authorship to Himal (Aravind) Add

  1   2   >