Re: [PATCH v3 3/3] drm/i915: Use device wedged event

2024-09-03 Thread Raag Jadav
On Mon, Sep 02, 2024 at 02:22:21PM +0530, Aravind Iddamsetty wrote: > > On 02/09/24 13:18, Raag Jadav wrote: > > Now that we have device wedged event supported by DRM core, make use > > of it. With this in place, userspace will be notified of wedged device > > on gt reset failure. > > > > Signed-o

[PATCH] drm/i915: convert comma to semicolon

2024-09-03 Thread Chen Ni
Replace a comma between expression statements by a semicolon. Signed-off-by: Chen Ni --- drivers/gpu/drm/i915/display/intel_hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index

Re: [PATCH 0/8] drm/i915 & drm/xe: shared PCI ID macros

2024-09-03 Thread Jani Nikula
On Mon, 02 Sep 2024, Lucas De Marchi wrote: > On Mon, Sep 02, 2024 at 08:13:59PM GMT, Jani Nikula wrote: >>There's considerable overlap in i915 and xe PCI ID macros, and (as can >>be seen in this series) they get updated out of sync. With i915 display >>continuing to use PCI IDs for platforms that

Re: [PATCH] drm/i915/psr: Implment WA to help reach PC10

2024-09-03 Thread Hogander, Jouni
On Mon, 2024-09-02 at 10:01 +, Kandpal, Suraj wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Monday, September 2, 2024 3:07 PM > > To: Kandpal, Suraj ; intel- > > g...@lists.freedesktop.org > > Cc: Shankar, Uma > > Subject: Re: [PATCH] drm/i915/psr: Implment W

RE: [PATCH] drm/i915/psr: Implment WA to help reach PC10

2024-09-03 Thread Kandpal, Suraj
> -Original Message- > From: Hogander, Jouni > Sent: Tuesday, September 3, 2024 1:12 PM > To: Kandpal, Suraj ; intel- > g...@lists.freedesktop.org > Cc: Shankar, Uma > Subject: Re: [PATCH] drm/i915/psr: Implment WA to help reach PC10 > > On Mon, 2024-09-02 at 10:01 +, Kandpal, Sura

Re: [PATCH v3 1/3] drm: Introduce device wedged event

2024-09-03 Thread Raag Jadav
On Mon, Sep 02, 2024 at 02:44:21PM +0530, Aravind Iddamsetty wrote: > > On 02/09/24 13:18, Raag Jadav wrote: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM device through a uevent. This is > > useful especially in cases where the dev

Re: [PATCH 04/13] drm/i915/display: Enable MSA Ignore Timing PAR only when in not fixed_rr mode

2024-09-03 Thread kernel test robot
config-071-20240903 (https://download.01.org/0day-ci/archive/20240903/202409031530.5oehhqkb-...@intel.com/config) compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archiv

✓ Fi.CI.BAT: success for drm/i915/display: BMG supports UHBR13.5 (rev4)

2024-09-03 Thread Patchwork
== Series Details == Series: drm/i915/display: BMG supports UHBR13.5 (rev4) URL : https://patchwork.freedesktop.org/series/137828/ State : success == Summary == CI Bug Log - changes from CI_DRM_15347 -> Patchwork_137828v4 Summary ---

[PATCH] drm/i915/psr: Implment WA to help reach PC10

2024-09-03 Thread Suraj Kandpal
To reach PC10 when PKG_C_LATENCY is configure we must do the following things 1) Enter PSR1 only when delayed_vblank < 6 lines and DC5 can be entered 2) Allow PSR2 deep sleep when DC5 can be entered 3) DC5 can be entered when all transocoder have either PSR1, PSR2 or eDP 1.5 PR ALPM enabled and VBI

✓ Fi.CI.BAT: success for drm/i915: convert comma to semicolon

2024-09-03 Thread Patchwork
== Series Details == Series: drm/i915: convert comma to semicolon URL : https://patchwork.freedesktop.org/series/138128/ State : success == Summary == CI Bug Log - changes from CI_DRM_15349 -> Patchwork_138128v1 Summary --- **SUCCESS

Re: [PATCH v3 02/81] drm/fbdev-helper: Set and clear VGA switcheroo client from fb_info

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Call vga_switcheroo_client_fb_set() with the PCI device from the > instance of struct fb_info. All fbdev clients now run these calls. > For non-PCI devices or drivers without vga-switcheroo, this does > nothing. For i915 and radeon, it allows these drive

✓ Fi.CI.BAT: success for drm/i915/psr: Implment WA to help reach PC10 (rev2)

2024-09-03 Thread Patchwork
== Series Details == Series: drm/i915/psr: Implment WA to help reach PC10 (rev2) URL : https://patchwork.freedesktop.org/series/138065/ State : success == Summary == CI Bug Log - changes from CI_DRM_15349 -> Patchwork_138065v2 Summary -

RE: [PATCH] drm/i915/dmc: Hardcode path to MTL DMC v2.23

2024-09-03 Thread Bhadane, Dnyaneshwar
> -Original Message- > From: Bhadane, Dnyaneshwar > Sent: Tuesday, August 27, 2024 7:34 PM > To: intel-gfx@lists.freedesktop.org > Cc: Bhadane, Dnyaneshwar > Subject: [PATCH] drm/i915/dmc: Hardcode path to MTL DMC v2.23 > > NOT TO BE REVIEWED/MERGED > Hardcode path to DMC firmware for

Re: [PATCH v3 03/81] drm/fbdev: Add memory-agnostic fbdev client

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Add an fbdev client that can work with any memory manager. The > client implementation is the same as existing code in fbdev-dma or > fbdev-shmem. > > Provide struct drm_driver.fbdev_probe for the new client to allocate > the surface GEM buffer. The new callback replac

Re: [PATCH v3 02/81] drm/fbdev-helper: Set and clear VGA switcheroo client from fb_info

2024-09-03 Thread Thomas Zimmermann
Hi Javier Am 03.09.24 um 12:18 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Call vga_switcheroo_client_fb_set() with the PCI device from the instance of struct fb_info. All fbdev clients now run these calls. For non-PCI devices or drivers without vga-switcheroo,

Re: [PATCH v3 05/81] drm/fbdev-dma: Support struct drm_driver.fbdev_probe

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and reimplement the old fb_probe callback on top of it. Provide an > initializer macro for struct drm_driver that sets the callback > according to the kernel configuration. > > This change allows the co

Re: [PATCH v3 06/81] drm/arcgpu: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup_with_fourcc() to run the kernel's default client > setup for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > v2: > - use drm_client_setup_with_fourcc() > > Signed-off-by: Thomas Zimmerma

Re: [PATCH v3 10/81] drm/aspeed: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The aspeed driver specifies a preferred color mode of 32. As this > is the default if no

Re: [PATCH v3 12/81] drm/fsl-dcu: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup_with_color_mode() to run the kernel's default > client setup for DRM. Set fbdev_probe in struct drm_driver, so that > the client setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Stefan Agner > Cc: Alison Wang

Re: [PATCH v3 02/81] drm/fbdev-helper: Set and clear VGA switcheroo client from fb_info

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi Javier > > Am 03.09.24 um 12:18 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >> Hello Thomas, >> >>> Call vga_switcheroo_client_fb_set() with the PCI device from the >>> instance of struct fb_info. All fbdev clients now run these calls. >>> For

Re: [PATCH v3 14/81] drm/hx8357d: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/tiny/hx8357d.c | 4 +++- > 1 f

Re: [PATCH v3 15/81] drm/ili9163: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/tiny/ili9163.c | 4 +++- > 1 f

Re: [PATCH v3 17/81] drm/ili9341: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/tiny/ili9341.c | 4 +++- > 1 f

Re: [PATCH v3 18/81] drm/ili9486: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Kamlesh Gurudasani > --- > drivers/gpu/drm/tiny

Re: [PATCH v3 19/81] drm/imx/dcss: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The dcss driver specifies a preferred color mode of 32. As this > is the default if no fo

Re: [PATCH v3 20/81] drm/imx/ipuv3: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup_with_color_mode() to run the kernel's default > client setup for DRM. Set fbdev_probe in struct drm_driver, so that > the client setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Philipp Zabel > Cc: Shawn Guo >

Re: [PATCH v3 21/81] drm/imx/lcdc: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix

Re: [PATCH v3 23/81] drm/kmb: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Anitha Chrisanthus > Cc: Edmund Dea > --- > dr

Re: [PATCH v3 24/81] drm/logicvc: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The logicvc driver specifies a preferred color mode from the value > in struct drm_mode_c

Re: [PATCH v3 25/81] drm/mcde: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The mcde driver specifies a preferred color mode of 32. As this > is the default if no fo

Re: [PATCH v3 29/81] drm/mxsfb/lcdif: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The lcdif driver specifies a preferred color mode of 32. As this > is the default if no f

Re: [PATCH v3 30/81] drm/mxsfb: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The mxsfb driver specifies a preferred color mode of 32. As this > is the default if no f

Re: [PATCH v3 33/81] drm/pl111: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup_with_color_mode() to run the kernel's default > client setup for DRM. Set fbdev_probe in struct drm_driver, so that > the client setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/pl111/pl111_dr

Re: [PATCH v3 39/81] drm/sti: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The sti driver specifies a preferred color mode of 32. As this > is the default if no for

Re: [PATCH v3 41/81] drm/sun4i: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The sun4i driver specifies as preferred color mode of 32. As this > is the default if no

Re: [PATCH v3 42/81] drm/tidss: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The tidss driver specifies a preferred color mode of 32. As this > is the default if no f

Re: [PATCH v3 43/81] drm/tilcdc: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup_with_color_mode() to run the kernel's default > client setup for DRM. Set fbdev_probe in struct drm_driver, so that > the client setup can start the common fbdev client. > > v3: > - add DRM_FBDEV_DMA_DRIVER_OPS macro > > Signed-off-by: Thomas Zimm

Re: [PATCH v3 49/81] drm/fbdev-dma: Remove obsolete setup function

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The old setup function drm_fbdev_dma_setup() is unused. Remove it and > its internal callbacks. New drivers should call drm_client_setup() > instead. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_fbdev_dma.c | 120 +--- >

Re: [PATCH v3 50/81] drm/fbdev-shmem: Support struct drm_driver.fbdev_probe

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and reimplement the old fb_probe callback on top of it. Provide an > initializer macro for struct drm_driver that sets the callback > according to the kernel configuration. > > This change allows the co

Re: [PATCH v3 05/81] drm/fbdev-dma: Support struct drm_driver.fbdev_probe

2024-09-03 Thread Thomas Zimmermann
Hi Am 03.09.24 um 13:08 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Rework fbdev probing to support fbdev_probe in struct drm_driver and reimplement the old fb_probe callback on top of it. Provide an initializer macro for struct drm_driver that sets the callback according to t

Re: [PATCH v3 52/81] drm/cirrus: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The cirrus driver requests the same client pixel format as the value > stored in struct d

Re: [PATCH v3 53/81] drm/gm12u320: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Hans de Goede > --- > drivers/gpu/drm/tiny/gm12

Re: [PATCH v3 60/81] drm/udl: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Dave Airlie > Cc: Sean Paul > Cc: Thomas Zimmer

Re: [PATCH v3 61/81] drm/virtgpu: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The virtgpu driver specifies a preferred color mode of 32. As this > is the default if no

Re: [PATCH v3 62/81] drm/vkms: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Rodrigo Siqueira > Cc: Melissa Wen > Cc: "Maíra

Re: [PATCH v3 63/81] drm/fbdev-shmem: Remove obsolete setup function

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The old setup function drm_fbdev_shmem_setup() is unused. Remove it > and its internal callbacks. New drivers should call drm_client_setup() > instead. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_fbdev_shmem.c | 120 +-

Re: [PATCH v3 64/81] drm/fbdev-ttm: Support struct drm_driver.fbdev_probe

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and reimplement the old fb_probe callback on top of it. Provide an > initializer macro for struct drm_driver that sets the callback > according to the kernel configuration. > > This change allows the co

Re: [PATCH v3 66/81] drm/bochs: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The bochs driver specifies a preferred color mode of 32. As this > is the default if no f

Re: [PATCH v3 67/81] drm/hisilicon/hibmc: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The hibmc driver specifies a preferred color mode of 32. As this > is the default if no f

Re: [PATCH v3 70/81] drm/qxl: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The qxl driver specifies a preferred color mode of 32. As this > is the default if no for

Re: [PATCH v3 71/81] drm/vboxvideo: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The vboxvideo driver specifies a preferred color mode of 32. As this > is the default if

Re: [PATCH v3 72/81] drm/vmwgfx: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Zack Rusin > Cc: Broadcom internal kernel review

Re: [PATCH v3 73/81] drm/fbdev-ttm: Remove obsolete setup function

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The old setup function drm_fbdev_ttm_setup() is unused. Remove it and > its internal callbacks. New drivers should call drm_client_setup() > instead. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_fbdev_ttm.c | 119 >

Re: [PATCH v3 74/81] drm/armada: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and remove the old fb_probe callback. Provide an initializer macro > for struct drm_driver that sets the callback according to the kernel > configuration. > > Call drm_client_setup() to run the kernel's

Re: [PATCH v3 75/81] drm/exynos-drm: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and remove the old fb_probe callback. Provide an initializer macro > for struct drm_driver that sets the callback according to the kernel > configuration. > > Call drm_client_setup() to run the kernel's

Re: [PATCH v3 76/81] drm/gma500: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and remove the old fb_probe callback. Provide an initializer macro > for struct drm_driver that sets the callback according to the kernel > configuration. > > Call drm_client_setup() to run the kernel's

Re: [PATCH v3 77/81] drm/msm: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and remove the old fb_probe callback. Provide an initializer macro > for struct drm_driver that sets the callback according to the kernel > configuration. > > Call drm_client_setup() to run the kernel's

Re: [PATCH v3 79/81] drm/tegra: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and remove the old fb_probe callback. Provide an initializer macro > for struct drm_driver that sets the callback according to the kernel > configuration. > > Call drm_client_setup() to run the kernel's

Re: [PATCH v3 80/81] drm/omapdrm: Remove struct drm_fb_helper from struct omap_fbdev.

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Store instances of drm_fb_helper and struct omap_fbdev separately. > This will allow omapdrm to use the common fbdev client, which allocates > its own instance of struct drm_fb_helper. > > There is at most one instance of each per DRM device, so both can be > reference

Re: [PATCH v3 81/81] drm/omapdrm: Run DRM default client setup

2024-09-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and remove the old fb_probe callback. Provide an initializer macro > for struct drm_driver that sets the callback according to the kernel > configuration. > > Call drm_client_setup() to run the kernel's

Re: [PATCH 07/11] drm/i915/pps: pass intel_dp to pps_name()

2024-09-03 Thread Ville Syrjälä
On Fri, Aug 30, 2024 at 01:15:44PM +0300, Jani Nikula wrote: > Currently all of intel_pps.c passes struct intel_dp around. Do the same > with pps_name() instead of passing both struct drm_i915_private and > struct intel_pps. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/int

Re: [PATCH 06/13] drm/i915/vrr: Compute vrr vsync if platforms support it

2024-09-03 Thread Ville Syrjälä
On Mon, Sep 02, 2024 at 01:36:27PM +0530, Ankit Nautiyal wrote: > Previously, TRANS_VRR_VSYNC was exclusively used for panels with > adaptive-sync SDP support in VRR scenarios. However, to drive fixed refresh > rates using the VRR Timing generator, we now need to program > TRANS_VRR_VSYNC regardles

Re: [PATCH 03/13] drm/i915/display: Add member fixed_rr to denote Fixed refresh rate with VRRTG

2024-09-03 Thread Ville Syrjälä
On Mon, Sep 02, 2024 at 01:36:24PM +0530, Ankit Nautiyal wrote: > Add fixed_rr member to struct vrr to represent the case where a > fixed refresh rate with VRR timing generator is required. > > v2: Move get_config change where vrr.fixed is actually set. (Mitul) > > Signed-off-by: Ankit Nautiyal

[PATCH -next] drm/i915/gt: Make use of __assign_bit() API

2024-09-03 Thread Hongbo Li
We have for some time the __assign_bit() API to replace open coded if (foo) __set_bit(n, bar); else __clear_bit(n, bar); Use this API to simplify the code. No functional change intended. Signed-off-by: Hongbo Li --- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 5 +

[PATCH -next] drm/i915: Remove extra unlikely helper

2024-09-03 Thread Hongbo Li
In IS_ERR, the unlikely is used for the input parameter, so these is no need to use it again outside. Signed-off-by: Hongbo Li --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/

i915 | Bug in virtual PCH detection

2024-09-03 Thread Andrey Toloknev
Hello! I have 2 machines with Comet Lake CPUs on Tiger Lake PCH (500 series of Intel chipsets). For that configuration there was a patch for adding support for Tiger Lake PCH with CometLake CPU in 2021 - https://patchwork.freedesktop.org/patch/412664/ This patch made possible correct detection of

[PATCH -next] drm/i915: Use memdup_user() helper

2024-09-03 Thread Jinjie Ruan
Switching to memdup_user(), which combines kmalloc() and copy_from_user(), and it can simplfy code. Signed-off-by: Jinjie Ruan --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_contex

Re: [PATCH v3 43/81] drm/tilcdc: Run DRM default client setup

2024-09-03 Thread jyri . sarha
August 30, 2024 at 11:40 AM, "Thomas Zimmermann" mailto:tzimmerm...@suse.de?to=%22Thomas%20Zimmermann%22%20%3Ctzimmermann%40suse.de%3E > wrote: > > Call drm_client_setup_with_color_mode() to run the kernel's default > client setup for DRM. Set fbdev_probe in struct drm_driver, so that > the clie

Re: [PATCH 10/13] drm/i915/vrr: Avoid sending PUSH when VRR TG is used with Fixed refresh rate

2024-09-03 Thread Ville Syrjälä
On Mon, Sep 02, 2024 at 01:36:31PM +0530, Ankit Nautiyal wrote: > As per Bspec:68925: Push enable must be set if not configuring for a > fixed refresh rate (i.e Vmin == Flipline == Vmax is not true). > > Signed-off-by: Ankit Nautiyal > Reviewed-by: Mitul Golani > --- > drivers/gpu/drm/i915/disp

Re: [PATCH 11/13] drm/i915/vrr: Handle joiner with vrr

2024-09-03 Thread Ville Syrjälä
On Mon, Sep 02, 2024 at 01:36:32PM +0530, Ankit Nautiyal wrote: > Do not program transcoder registers for VRR for the secondary pipe of > the joiner. Remove check to skip VRR for joiner case. > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_vrr.c | 19

Re: [PATCH v3 77/81] drm/msm: Run DRM default client setup

2024-09-03 Thread Dmitry Baryshkov
On Fri, 30 Aug 2024 at 11:45, Thomas Zimmermann wrote: > > Rework fbdev probing to support fbdev_probe in struct drm_driver > and remove the old fb_probe callback. Provide an initializer macro > for struct drm_driver that sets the callback according to the kernel > configuration. > > Call drm_clie

Re: [PATCH 12/13] drm/i915/vrr: Always use VRR timing generator for XELPD+

2024-09-03 Thread Ville Syrjälä
On Mon, Sep 02, 2024 at 01:36:33PM +0530, Ankit Nautiyal wrote: > Currently VRR timing generator is used only when VRR is enabled by > userspace. From XELPD+, gradually move away from older timing > generator and use VRR timing generator for fixed refresh rate also. > In such a case, Flipline VMin

RE: [PATCH] drm: Ensure Proper Unload/Reload Order of MEI Modules for i915/Xe Driver

2024-09-03 Thread Bommu, Krishnaiah
++ intel-gfx@lists.freedesktop.org > -Original Message- > From: Kamil Konieczny > Sent: Tuesday, September 3, 2024 5:38 PM > To: intel...@lists.freedesktop.org > Cc: Bommu, Krishnaiah ; Ceraolo Spurio, > Daniele ; De Marchi, Lucas > > Subject: Re: [PATCH] drm: Ensure Proper Unload/Reload

Re: i915 | Bug in virtual PCH detection

2024-09-03 Thread Ville Syrjälä
On Sun, Sep 01, 2024 at 02:56:07PM +0500, Andrey Toloknev wrote: > Hello! > > I have 2 machines with Comet Lake CPUs on Tiger Lake PCH (500 series of > Intel chipsets). > For that configuration there was a patch for adding support for Tiger Lake > PCH with CometLake CPU in 2021 - > https://patchwo

[PATCH 0/4] drm/i915/display: add snapshot capture/print infra

2024-09-03 Thread Jani Nikula
Add display capture/print infra to abstract it from i915 gpu error state capture, and prepare for perhaps bolting it into xe devcoredump in the future. BR, Jani. Jani Nikula (4): drm/i915: dump display parameters captured in error state, not current drm/i915/display: add intel_display_snapsh

[PATCH 2/4] drm/i915/display: add intel_display_snapshot abstraction

2024-09-03 Thread Jani Nikula
The error state capture still handles display info at a too detailed level. Start abstracting the whole display snapshot capture and printing at a higher level. Move overlay to display snapshot first. Use the same nomenclature and style as in xe devcoredump, in preparation for perhaps some day bol

[PATCH 3/4] drm/i915/display: move device info and params handling to snapshot

2024-09-03 Thread Jani Nikula
Snapshot display device and runtime info as well as display parameters in display snapshot. Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_display_snapshot.c | 25 +++ drivers/gpu/drm/i915/i915_gpu_error.c | 10 drivers/gpu/drm/i915/i915_gpu_error.h

[PATCH 4/4] drm/i915/display: move dmc snapshotting to new display snapshot

2024-09-03 Thread Jani Nikula
Convert dmc error state printing to new snapshot capture/print division. Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_display_snapshot.c | 5 +++ drivers/gpu/drm/i915/display/intel_dmc.c | 39 +++ drivers/gpu/drm/i915/display/intel_dmc.h | 7 +++- drivers

[PATCH 1/4] drm/i915: dump display parameters captured in error state, not current

2024-09-03 Thread Jani Nikula
intel_display_params_dump() prints the current display parameters, not the ones captured during error capture. It's not likely the params get changed in between, but make it pedantically correct anyway. Pass in the parameters and driver name to intel_display_params_dump(). Signed-off-by: Jani Niku

Re: [PATCH 07/11] drm/i915/pps: pass intel_dp to pps_name()

2024-09-03 Thread Jani Nikula
On Tue, 03 Sep 2024, Ville Syrjälä wrote: > On Fri, Aug 30, 2024 at 01:15:44PM +0300, Jani Nikula wrote: >> Currently all of intel_pps.c passes struct intel_dp around. Do the same >> with pps_name() instead of passing both struct drm_i915_private and >> struct intel_pps. >> >> Signed-off-by: Jani

[PULL] drm-intel-next

2024-09-03 Thread Rodrigo Vivi
Hi Dave and Sima, We'd like to include this extra display clean-up towards the 6.12. Hence this extra pull-request on top of what I declared as our last one last week. It only delayed because it touches both Xe and i915 and it depended on xe changes that propagated through drm-xe-next last week +

✓ Fi.CI.BAT: success for drm/i915/gt: Make use of __assign_bit() API

2024-09-03 Thread Patchwork
== Series Details == Series: drm/i915/gt: Make use of __assign_bit() API URL : https://patchwork.freedesktop.org/series/138141/ State : success == Summary == CI Bug Log - changes from CI_DRM_15351 -> Patchwork_138141v1 Summary --- **

✓ Fi.CI.BAT: success for drm/i915: Remove extra unlikely helper

2024-09-03 Thread Patchwork
== Series Details == Series: drm/i915: Remove extra unlikely helper URL : https://patchwork.freedesktop.org/series/138142/ State : success == Summary == CI Bug Log - changes from CI_DRM_15351 -> Patchwork_138142v1 Summary --- **SUCCE

✓ Fi.CI.BAT: success for drm/i915: Use memdup_user() helper

2024-09-03 Thread Patchwork
== Series Details == Series: drm/i915: Use memdup_user() helper URL : https://patchwork.freedesktop.org/series/138143/ State : success == Summary == CI Bug Log - changes from CI_DRM_15353 -> Patchwork_138143v1 Summary --- **SUCCESS**

✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: add snapshot capture/print infra

2024-09-03 Thread Patchwork
== Series Details == Series: drm/i915/display: add snapshot capture/print infra URL : https://patchwork.freedesktop.org/series/138151/ State : warning == Summary == Error: dim checkpatch failed f3820671e52e drm/i915: dump display parameters captured in error state, not current -:34: WARNING:M

✗ Fi.CI.SPARSE: warning for drm/i915/display: add snapshot capture/print infra

2024-09-03 Thread Patchwork
== Series Details == Series: drm/i915/display: add snapshot capture/print infra URL : https://patchwork.freedesktop.org/series/138151/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for drm/i915/display: add snapshot capture/print infra

2024-09-03 Thread Patchwork
== Series Details == Series: drm/i915/display: add snapshot capture/print infra URL : https://patchwork.freedesktop.org/series/138151/ State : success == Summary == CI Bug Log - changes from CI_DRM_15353 -> Patchwork_138151v1 Summary --

Re: [PATCH 3/3] drm/amdgpu: drop redundant W=1 warnings from Makefile

2024-09-03 Thread Hamza Mahfooz
On 5/23/24 09:37, Jani Nikula wrote: Since commit a61ddb4393ad ("drm: enable (most) W=1 warnings by default across the subsystem"), most of the extra warnings in the driver Makefile are redundant. Remove them. Note that -Wmissing-declarations and -Wmissing-prototypes are always enabled by defaul

✗ Fi.CI.BAT: failure for drm/i915/hwmon: expose package temperature (rev2)

2024-09-03 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: expose package temperature (rev2) URL : https://patchwork.freedesktop.org/series/137874/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15354 -> Patchwork_137874v2 Summary ---

[PATCH 0/4] drm/xe/display: Clean-up PM sequences

2024-09-03 Thread Rodrigo Vivi
This series aim to bring a bit of clarity in the display PM sequences and start a clean-up around the runtime_pm ones. Specially around D3Cold. There are some ongoing discussions that we wouldn't need all the sequences that we currently have. So, let's at least split them up to separate functions

[PATCH 1/4] drm/xe/display: Spin-off xe_display runtime/d3cold sequences

2024-09-03 Thread Rodrigo Vivi
No functional change. This patch only splits the xe_display_pm suspend/resume functions in the regular suspend/resume from the runtime/d3cold ones. The goal is to continue with a clean-up on the sequences that might not be needed on runtime, even for D3cold. But, for now, bring them to a separate

[PATCH 2/4] drm/xe/display: Remove i915_drv.h include

2024-09-03 Thread Rodrigo Vivi
Change HAS_DISPLAY towards intel_display and remove one of the last includes of i915_drv.h in Xe. Cc: Jani Nikula Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/display/xe_display.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/display/xe_display.c

[PATCH 3/4] drm/xe/display: Kill useless has_display

2024-09-03 Thread Rodrigo Vivi
When HAS_DISPLAY is false, info.probe_display is set to false. Hence, all these calls to has_display() are bogus. With only one place left, use the main macro now and entirely kill has_display() local helper. Cc: Jani Nikula Cc: Maarten Lankhorst Cc: Lucas De Marchi Signed-off-by: Rodrigo Vivi

[PATCH 4/4] drm/xe/display: Reduce and streamline d3cold display sequence

2024-09-03 Thread Rodrigo Vivi
When going to d3cold we surely don't need to flush commits, nor handle fbdev. So, clean this up a bit. Also move the opregion call to make the function more symmetric. Cc: Imre Deak Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/display/xe_display.c | 12 +++- 1 file changed, 3 ins

✗ Fi.CI.BAT: failure for drm/xe/display: Clean-up PM sequences

2024-09-03 Thread Patchwork
== Series Details == Series: drm/xe/display: Clean-up PM sequences URL : https://patchwork.freedesktop.org/series/138164/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15355 -> Patchwork_138164v1 Summary --- **FAILUR

linux-next: build failure after merge of the drm-misc tree

2024-09-03 Thread Stephen Rothwell
^ drivers/gpu/drm/bridge/ti-tdp158.c:80:65: note: each undeclared identifier is reported only once for each function it appears in Caused by commit a15710027afb ("drm/bridge: add support for TI TDP158") I have used the drm-misc t

RE: [PATCHv2 3/5] Add crtc properties for global histogram

2024-09-03 Thread Murthy, Arun R
> > > +static int > > > +intel_atomic_replace_property_blob_from_id(struct drm_device *dev, > > > +struct drm_property_blob **blob, > > > +u64 blob_id, > > > +ssize_t expected_size, > > > +

Re: [PATCH 4/4] drm/xe/display: Reduce and streamline d3cold display sequence

2024-09-03 Thread Anshuman Gupta
On 2024-09-04 at 04:08:03 +0530, Rodrigo Vivi wrote: > When going to d3cold we surely don't need to flush commits, > nor handle fbdev. So, clean this up a bit. > > Also move the opregion call to make the function more symmetric. > > Cc: Imre Deak > Signed-off-by: Rodrigo Vivi > --- > drivers/g

linux-next: build warning after merge of the drm-misc-fixes tree

2024-09-03 Thread Stephen Rothwell
Hi all, After merging the drm-misc-fixes tree, today's linux-next build (htmldocs) produced this warning: Error: Cannot open file drivers/gpu/drm/drm_bridge_connector.c Introduced by commit 9da7ec9b19d8 ("drm/bridge-connector: move to DRM_DISPLAY_HELPER module") -- Cheers, Stephen Rothwell